| *** dane_leblanc has quit IRC | 00:01 | |
| *** oomichi has joined #openstack-neutron | 00:05 | |
| *** carl_baldwin has quit IRC | 00:06 | |
| *** aranjan has quit IRC | 00:08 | |
| *** rodrigods is now known as rodrigod` | 00:08 | |
| *** rodrigod` is now known as rodrigods | 00:08 | |
| *** rodrigods has quit IRC | 00:09 | |
| *** gildub has joined #openstack-neutron | 00:09 | |
| *** manishg has joined #openstack-neutron | 00:09 | |
| *** karimb has quit IRC | 00:10 | |
| *** VijayB_ has quit IRC | 00:11 | |
| *** VijayB has joined #openstack-neutron | 00:12 | |
| *** krii has quit IRC | 00:13 | |
| openstackgerrit | Matthew Thode proposed openstack/neutron: replaces enumeration method used to get a list of interfaces https://review.openstack.org/154128 | 00:15 |
|---|---|---|
| *** tiswanso has quit IRC | 00:16 | |
| *** yamamoto has joined #openstack-neutron | 00:17 | |
| *** rodrigods has joined #openstack-neutron | 00:19 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Allow AsyncProcess to block on process start and stop. https://review.openstack.org/158097 | 00:19 |
| amuller | marun: ^ | 00:19 |
| amuller | addressed all comments | 00:19 |
| amuller | thanks for the review | 00:19 |
| marun | amuller: https://review.openstack.org/#/c/159193/ | 00:22 |
| *** david-lyle is now known as david-lyle_Afk | 00:22 | |
| *** david-lyle_Afk is now known as david-lyle_afk | 00:22 | |
| HenryG | marun: ack, looking | 00:22 |
| *** markvoelker has quit IRC | 00:24 | |
| marun | HenryG: I think I've had a change of heart since my original ping :) | 00:26 |
| HenryG | marun: So if early skip in setUp is done, then you'll be OK with both FakeMachine and ensure run_as_root? | 00:27 |
| *** shashankhegde has joined #openstack-neutron | 00:27 | |
| HenryG | marun: Both those reviews, I mean | 00:28 |
| marun | HenryG: Maybe? I'm wondering if it should land ahead of decoupling of helper functions from TestCase instances. | 00:28 |
| *** cburgess has quit IRC | 00:28 | |
| *** Jabadia_ has joined #openstack-neutron | 00:28 | |
| marun | HenryG: I think v | 00:28 |
| *** cburgess has joined #openstack-neutron | 00:28 | |
| marun | https://review.openstack.org/#/c/159193/ is ready to go once the skip is made explicit | 00:28 |
| marun | HenryG: I have to take a closer look at the FakeMachine change, will do so shortly | 00:29 |
| *** gus has quit IRC | 00:29 | |
| *** EmilienM|afk has quit IRC | 00:29 | |
| *** markvoelker has joined #openstack-neutron | 00:29 | |
| ZZelle_ | marun, we can perform explicit check but currently it's not working | 00:29 |
| *** mwagner_lap has quit IRC | 00:29 | |
| *** Jabadia has quit IRC | 00:29 | |
| marun | ZZelle_: what's not working? | 00:30 |
| *** EmilienM has joined #openstack-neutron | 00:30 | |
| ZZelle_ | marun, helpers are not checking is sudo is enabled | 00:31 |
| *** sbfox has quit IRC | 00:31 | |
| *** gus has joined #openstack-neutron | 00:31 | |
| marun | ZZelle_: Why would it be up to the helper though? | 00:31 |
| marun | ZZelle_: to minimize potential setup cost, the testcase could be doing the check as it is now | 00:31 |
| marun | oops | 00:31 |
| marun | as it used to | 00:31 |
| ZZelle_ | marun, as it never did? | 00:32 |
| openstackgerrit | Merged openstack/neutron: Added a policy for retrieving the agent hosting a load balancer https://review.openstack.org/159544 | 00:32 |
| marun | I'm not really sure why all those different classes were calling check_is_sudo_enabled | 00:32 |
| marun | ZZelle_: it would seem to make sense for BaseSudo.setUp to do it and all subclasses get it automatically, exactly as your change enabled an implicit check | 00:33 |
| marun | ZZelle_: I know you're somewhat committed to the implicit check, what are your thoughts on the potential drawback? | 00:33 |
| ZZelle_ | marun, if so it simplifies things | 00:33 |
| ZZelle_ | marun, we will skip later using implicit check than using setUp based check | 00:35 |
| ZZelle_ | marun, but setUp based check is always done (which is currently not the case but why?) | 00:36 |
| marun | ZZelle_: It's probably an accident of history | 00:36 |
| HenryG | marun: Yup most likely | 00:37 |
| marun | ZZelle_: I think I might have wanted to have tests in a given class be able to decide selectively if they were going to require sudo, but it doesn't seem like any code is using that | 00:37 |
| HenryG | I say put the skip at the very start of BaseSudo setUp. (Before super even?) | 00:38 |
| marun | ZZelle_: although, it looks like test_process_monitor is based on BaseSudo and doesn't require it | 00:38 |
| HenryG | marun: Well then it's using the wrong base class | 00:38 |
| marun | HenryG: Agreed. | 00:39 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Introduce ip address monitor https://review.openstack.org/149647 | 00:39 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Change metadata driver unit tests to use monitored spawn https://review.openstack.org/155058 | 00:39 |
| marun | ZZelle_: I'd recommend taking a survey of subclasses of BaseSudo and fixing their base class if they appear to be able to run without the check. | 00:39 |
| marun | the check -> sudo | 00:39 |
| marun | amuller: I guess we can't use ip_lib because it uses execute? | 00:40 |
| *** tsg_ has quit IRC | 00:40 | |
| ZZelle_ | i will 1) look at BaseSudo subclasses 2) enable an explicit check in BaseSudo.setUp and remove check_sudo_enabled calls | 00:41 |
| ZZelle_ | it simplifies a lot things | 00:41 |
| amuller | marun: yeah the part that composes the namespace is buried deep inside | 00:42 |
| amuller | marun: we could extract it, place it in its own function in ip_lib | 00:43 |
| amuller | then use that | 00:43 |
| amuller | let me check | 00:43 |
| marun | ZZelle_: great!+ | 00:43 |
| HenryG | ZZelle_: ++ | 00:43 |
| amuller | marun: yeah I'll do that | 00:44 |
| openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Prevent direct port-delete of FIP Agent GW and CSNAT https://review.openstack.org/159679 | 00:44 |
| marun | amuller: other than that, you missed docstring additions for stop(). | 00:45 |
| amuller | bleh | 00:45 |
| *** ZZelle_ has quit IRC | 00:45 | |
| *** yamamoto has quit IRC | 00:49 | |
| HenryG | haleyb: LOL at all those test cases that pretended they could add ipv6 address with broadcast | 00:53 |
| HenryG | haleyb: Thanks for fixing that | 00:53 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Allow AsyncProcess to block on process start and stop. https://review.openstack.org/158097 | 00:55 |
| *** yamamoto has joined #openstack-neutron | 00:55 | |
| amuller | marun: ^ | 00:55 |
| *** reed has quit IRC | 00:55 | |
| *** aranjan has joined #openstack-neutron | 00:56 | |
| *** ajmiller has quit IRC | 00:56 | |
| amuller | marun: bet you thought I wouldn't add tests to the new helper | 00:57 |
| amuller | well, I did | 00:57 |
| *** manishg has quit IRC | 00:57 | |
| marun | amuller: heh | 00:57 |
| *** manishg has joined #openstack-neutron | 00:58 | |
| marun | amuller: you're in the zone, obviously | 00:58 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Introduce ip address monitor https://review.openstack.org/149647 | 00:58 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Send notification to controller about HA router state change https://review.openstack.org/126188 | 00:58 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Expose ha_state per router to agent binding via API https://review.openstack.org/126189 | 00:58 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Change metadata driver unit tests to use monitored spawn https://review.openstack.org/155058 | 00:58 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Replace keepalived notifier bash script with Python ip monitor https://review.openstack.org/125384 | 00:58 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Reuse nova batch notifier https://review.openstack.org/128013 | 00:58 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Remove unused L3 HA RPC method https://review.openstack.org/155370 | 00:58 |
| amuller | bam | 00:58 |
| *** achanda has quit IRC | 00:58 | |
| amuller | marun: going out for dinner, talk to you tomorrow | 00:58 |
| marun | amuller: have a good one | 00:59 |
| marun | :) | 00:59 |
| amuller | Cheesecake factory here we come! They have a killer strawberry shortcake | 00:59 |
| *** SumitNaiksatam has left #openstack-neutron | 00:59 | |
| *** SumitNaiksatam has joined #openstack-neutron | 00:59 | |
| *** shwetaap has quit IRC | 00:59 | |
| *** lazy_prince has quit IRC | 01:01 | |
| *** amuller has quit IRC | 01:01 | |
| *** yog_ has quit IRC | 01:01 | |
| *** dims has joined #openstack-neutron | 01:01 | |
| *** aranjan has quit IRC | 01:01 | |
| *** manishg has quit IRC | 01:02 | |
| *** aranjan has joined #openstack-neutron | 01:05 | |
| *** leenheer has quit IRC | 01:07 | |
| *** Sukhdev_ has quit IRC | 01:08 | |
| *** yamamoto has quit IRC | 01:11 | |
| *** armax has joined #openstack-neutron | 01:11 | |
| *** yamamoto has joined #openstack-neutron | 01:14 | |
| openstackgerrit | Michael Smith proposed openstack/neutron: Fix non-existent self.local_subnets in DvrRouter class https://review.openstack.org/157621 | 01:16 |
| *** Marga_ has quit IRC | 01:21 | |
| *** xgerman has quit IRC | 01:21 | |
| *** leenheer has joined #openstack-neutron | 01:22 | |
| *** Marga_ has joined #openstack-neutron | 01:23 | |
| *** popw has joined #openstack-neutron | 01:23 | |
| *** zhhuabj has joined #openstack-neutron | 01:24 | |
| *** aepifanov has quit IRC | 01:24 | |
| *** diegows has quit IRC | 01:24 | |
| *** SumitNaiksatam has quit IRC | 01:25 | |
| rms_13 | akamyshnikova: Ping | 01:26 |
| *** bobmel has quit IRC | 01:27 | |
| *** bobmel has joined #openstack-neutron | 01:27 | |
| *** baoli_ has quit IRC | 01:28 | |
| *** shashankhegde has quit IRC | 01:29 | |
| rms_13 | akamyshnikova, HenryG: Guys can you please take a look at https://review.openstack.org/#/c/159281/ when you get chance? Thx | 01:29 |
| *** markvoelker has quit IRC | 01:32 | |
| *** stanzgy has joined #openstack-neutron | 01:32 | |
| *** stanzgy_ has joined #openstack-neutron | 01:32 | |
| *** ChuckC has quit IRC | 01:33 | |
| *** _cjones_ has quit IRC | 01:33 | |
| *** yamamoto has quit IRC | 01:33 | |
| *** marun has quit IRC | 01:33 | |
| prometheanfire | uh, is gate failing? | 01:39 |
| prometheanfire | http://logs.openstack.org/28/154128/20/check/gate-neutron-python27/82c3e85/console.html | 01:39 |
| *** Marga_ has quit IRC | 01:40 | |
| *** armax has quit IRC | 01:42 | |
| *** rm_work is now known as rm_work|away | 01:46 | |
| *** VijayB has quit IRC | 01:49 | |
| *** VijayB has joined #openstack-neutron | 01:50 | |
| *** yamamoto has joined #openstack-neutron | 01:50 | |
| *** tsg has joined #openstack-neutron | 01:51 | |
| openstackgerrit | watanabe isao proposed openstack/neutron: Validate string length at API level https://review.openstack.org/145660 | 01:52 |
| *** tomoe_ has joined #openstack-neutron | 01:52 | |
| *** VijayB has quit IRC | 01:54 | |
| *** rms_13 has quit IRC | 01:55 | |
| *** armax has joined #openstack-neutron | 01:56 | |
| *** achanda has joined #openstack-neutron | 01:58 | |
| *** yapeng has joined #openstack-neutron | 01:58 | |
| *** SumitNaiksatam has joined #openstack-neutron | 01:59 | |
| *** rms_13 has joined #openstack-neutron | 02:06 | |
| *** aranjan has quit IRC | 02:09 | |
| *** changbl has joined #openstack-neutron | 02:09 | |
| *** johnbelamaric has quit IRC | 02:10 | |
| *** johnbelamaric has joined #openstack-neutron | 02:10 | |
| *** tiswanso has joined #openstack-neutron | 02:11 | |
| *** catohornet has quit IRC | 02:14 | |
| *** erkules_ has joined #openstack-neutron | 02:16 | |
| *** oda-g has joined #openstack-neutron | 02:16 | |
| *** manishg has joined #openstack-neutron | 02:18 | |
| *** SridharRamaswamy has quit IRC | 02:18 | |
| *** erkules has quit IRC | 02:19 | |
| openstackgerrit | badveli_vishnuus proposed openstack/neutron: Add service group as a firewall customized service https://review.openstack.org/159692 | 02:19 |
| openstackgerrit | watanabe isao proposed openstack/neutron: Improve validate of remove_router_interface https://review.openstack.org/151973 | 02:25 |
| *** baoli has joined #openstack-neutron | 02:25 | |
| *** rwsu is now known as rwsu-afk | 02:26 | |
| *** leenheer has quit IRC | 02:29 | |
| *** rms_13 has quit IRC | 02:31 | |
| *** ivar-laz_ has joined #openstack-neutron | 02:32 | |
| *** ivar-lazzaro has quit IRC | 02:35 | |
| *** ivar-laz_ has quit IRC | 02:36 | |
| *** tomoe_ has quit IRC | 02:37 | |
| *** nlahouti has quit IRC | 02:40 | |
| *** zhhuabj has quit IRC | 02:41 | |
| *** tomoe_ has joined #openstack-neutron | 02:41 | |
| *** zhhuabj has joined #openstack-neutron | 02:41 | |
| *** killer_prince has joined #openstack-neutron | 02:42 | |
| *** killer_prince is now known as lazy_prince | 02:42 | |
| *** carl_baldwin has joined #openstack-neutron | 02:42 | |
| *** spandhe has quit IRC | 02:44 | |
| openstackgerrit | yalei wang proposed openstack/neutron: Add portsecurity extension support https://review.openstack.org/126552 | 02:44 |
| *** s3wong has quit IRC | 02:47 | |
| *** ajmiller has joined #openstack-neutron | 02:51 | |
| *** dkehn has quit IRC | 02:52 | |
| *** yuanying has quit IRC | 02:52 | |
| *** yamamoto has quit IRC | 02:53 | |
| *** carl_baldwin has quit IRC | 02:58 | |
| *** zerda has joined #openstack-neutron | 02:58 | |
| *** yamamoto has joined #openstack-neutron | 02:59 | |
| *** dkehn has joined #openstack-neutron | 03:03 | |
| *** yamahata has quit IRC | 03:05 | |
| *** achanda has quit IRC | 03:05 | |
| *** mwagner_lap has joined #openstack-neutron | 03:06 | |
| *** achanda has joined #openstack-neutron | 03:08 | |
| openstackgerrit | Angus Lees proposed openstack/neutron: Update default tox envlist to match voting gate checks https://review.openstack.org/137516 | 03:10 |
| openstackgerrit | Angus Lees proposed openstack/neutron: Add pylint to default tox envlist https://review.openstack.org/159700 | 03:10 |
| *** sbalukoff has quit IRC | 03:12 | |
| openstackgerrit | Sridar Kandaswamy proposed openstack/neutron-fwaas: FWaaS Insertion Model on Routers https://review.openstack.org/152697 | 03:14 |
| *** gildub has quit IRC | 03:16 | |
| *** carl_baldwin has joined #openstack-neutron | 03:18 | |
| openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Add test case for the 'Peer ID gets additional "@"' fix https://review.openstack.org/158074 | 03:18 |
| *** SumitNaiksatam has quit IRC | 03:24 | |
| *** carl_baldwin has quit IRC | 03:25 | |
| *** jyuso1 has joined #openstack-neutron | 03:25 | |
| gus | huh, I missed whatever happened a few days ago re pylint and gate. | 03:30 |
| gus | What triggered it to be made non-voting? | 03:31 |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool https://review.openstack.org/157597 | 03:35 |
| gus | Does anyone know? I can't find any mail on os-dev, the change to move it over to pep8 tox env doesn't give any indication of the backstory, I can't find the change to zuul layout.yaml that made it non-voting (huh?) | 03:36 |
| *** yuanying has joined #openstack-neutron | 03:38 | |
| *** achanda has quit IRC | 03:40 | |
| *** csoukup has joined #openstack-neutron | 03:40 | |
| *** dims has quit IRC | 03:41 | |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: Basic subnetpool CRUD https://review.openstack.org/148698 | 03:45 |
| *** crc32 has joined #openstack-neutron | 03:46 | |
| *** tflynn has joined #openstack-neutron | 03:47 | |
| *** amuller has joined #openstack-neutron | 03:47 | |
| *** tflynn has quit IRC | 03:49 | |
| *** tflynn has joined #openstack-neutron | 03:49 | |
| *** armax has quit IRC | 03:50 | |
| *** flwang1 has quit IRC | 03:54 | |
| openstackgerrit | Juergen Brendel proposed openstack/neutron: ARP spoofing patch: Low level ebtables integration https://review.openstack.org/141130 | 03:56 |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool https://review.openstack.org/157597 | 03:56 |
| openstackgerrit | Angus Lees proposed openstack/neutron: Update default tox envlist to match voting gate checks https://review.openstack.org/137516 | 03:57 |
| openstackgerrit | yalei wang proposed openstack/neutron-fwaas: Implementation of Mcafee NGFW Driver https://review.openstack.org/152093 | 03:58 |
| *** shwetaap has joined #openstack-neutron | 03:59 | |
| mestery | gus: I'm not 100% sure, but armax will be online in about 30 minutes, ping him and he has the backstory. | 03:59 |
| *** achanda has joined #openstack-neutron | 03:59 | |
| mestery | gus: We got it voting again now though, patch merged today | 03:59 |
| *** SumitNaiksatam has joined #openstack-neutron | 03:59 | |
| gus | yeah, I'm just trying to unravel which form it landed again.. | 04:00 |
| gus | I found a reference to novaclient breakage in the infra change to make it non-voting. | 04:00 |
| mestery | gus: That sounds about right I think. | 04:00 |
| mestery | gus: For reference, the patch which fixed it: https://review.openstack.org/#/c/159198 | 04:00 |
| mestery | gus: I'm going afk now, but like I said, find armax once he comes online (he's in India at the moment so going to the office), he can fill you in with the gory details :) | 04:01 |
| gus | ack, thanks. | 04:01 |
| gus | (That change removes the pylint toxenv without removing all the references to it in zuul layout.yaml) | 04:02 |
| openstackgerrit | Juergen Brendel proposed openstack/neutron: ARP spoofing patch: Data structures for rules. https://review.openstack.org/157097 | 04:02 |
| openstackgerrit | Juergen Brendel proposed openstack/neutron: ARP spoofing patch: Ebtables manager https://review.openstack.org/157634 | 04:07 |
| *** achanda has quit IRC | 04:07 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Allow AsyncProcess to block on process start and stop https://review.openstack.org/158097 | 04:11 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Introduce ip address monitor https://review.openstack.org/149647 | 04:11 |
| *** yog_ has joined #openstack-neutron | 04:13 | |
| *** tflynn has quit IRC | 04:14 | |
| *** tflynn has joined #openstack-neutron | 04:14 | |
| *** yeungp has quit IRC | 04:17 | |
| *** baoli has quit IRC | 04:17 | |
| *** armax has joined #openstack-neutron | 04:17 | |
| *** baoli has joined #openstack-neutron | 04:17 | |
| gus | armax: I've only just realised there was some neutronpylint churn over the last week :/ | 04:19 |
| armax | gus: yes | 04:19 |
| gus | armax: what's the current status and plans wrt the zuul test? | 04:19 |
| gus | we're dismantling the separate environment because it was too expensive? | 04:19 |
| armax | gus: it’s in the gate, but it’s running as part of the pep8 job | 04:19 |
| armax | gus: but cumbersome | 04:20 |
| gus | yeah, why that vs resurrecting the old pylint check? | 04:20 |
| *** pradipta has joined #openstack-neutron | 04:21 | |
| *** tiswanso has quit IRC | 04:21 | |
| armax | gus: ? | 04:21 |
| gus | why was pylint added to pep8, rather than keeping it as a separate pylint toxenv? | 04:21 |
| gus | (I'm fine with this, just trying to catch up on the various motivations/decisions) | 04:22 |
| *** manishg has quit IRC | 04:24 | |
| *** amuller has quit IRC | 04:24 | |
| gus | armax: so from what I've been able to piece together, there was a novaclient release that did some fancy stuff with v1_1 = v2 which confused pylint and broke neutron gate. | 04:25 |
| armax | ya | 04:26 |
| armax | so the job was made non-voting | 04:26 |
| gus | (I'm unsure why pylint was confused by that, I thought that would work as intended. I'll have to look) | 04:26 |
| gus | right, so -infra made the job non-voting. | 04:26 |
| *** Murali_ has joined #openstack-neutron | 04:26 | |
| *** Murali_ is now known as Murali | 04:26 | |
| gus | then the import was fixed (I'm guessing, I haven't looked for those changes yet), and then your change to add pylint to pep8 was submitted. | 04:27 |
| armax | well | 04:27 |
| gus | (effectively making pylint voting again) | 04:27 |
| armax | I tried to make the job voting again | 04:27 |
| armax | but .. | 04:27 |
| armax | gus whilst the infra patch was churning | 04:27 |
| armax | the pylint job broke again | 04:27 |
| armax | and hence it became evident that this two-step process could very well lead us to shot ourselves in teh foot | 04:28 |
| armax | so, I figured it was going to be more effective to fold the pylint check in the pep8 job | 04:28 |
| armax | if we need to disable it for whatever reason | 04:28 |
| armax | we don’t have to involve infra | 04:28 |
| armax | and everything can be controlled by neutron patches | 04:28 |
| gus | yeah, I had to do a similar disable-everything-then-make-voting-then-remove-disables to get it in in the first place. | 04:28 |
| armax | then, the rest is history | 04:28 |
| gus | oh, I see - so we can disable it in the future by just commenting it out from pep8? | 04:29 |
| armax | which I’d rather leave to you to find it | 04:29 |
| armax | gus: ya | 04:29 |
| armax | or | 04:29 |
| armax | just do || true on the pylint check | 04:29 |
| gus | understood. | 04:29 |
| armax | if we still want to see what the heck is going on | 04:29 |
| *** annegentle has joined #openstack-neutron | 04:30 | |
| gus | So .. remaining cleanup: I should go remove the now pointless non-voting neutron-pylint check from zuul. | 04:30 |
| armax | it sounds like folks still have mixed feelings about having pylint in the gate | 04:30 |
| armax | but that should be a separate discussion | 04:30 |
| gus | .. and go and fix whatever those two newly-introduced bugs are that pylint would have prevented ;) | 04:30 |
| armax | I was only attempting at restoring the current state of affairs | 04:30 |
| armax | and at the same time making our life a little more sane | 04:31 |
| armax | it’s already done | 04:31 |
| armax | but for whatever reason the patch is stuck | 04:31 |
| gus | armax: yeah, I'm disappointed by some of those comments :( | 04:31 |
| armax | gus: https://review.openstack.org/#/c/159199/ | 04:31 |
| gus | thanks for getting it back voting again so swiftly :) | 04:31 |
| armax | gus if you wanna be a lamb and follow that up for me I’d appreciate it :) | 04:31 |
| gus | :) | 04:31 |
| armax | :) | 04:32 |
| gus | will do. | 04:32 |
| armax | gus: thanks | 04:32 |
| armax | gus: just to close the circle: | 04:32 |
| armax | some folks also complained about the lenghty run of pylint | 04:32 |
| armax | gus: so I pulled this one up: https://review.openstack.org/#/c/159341/ | 04:32 |
| *** sbalukoff has joined #openstack-neutron | 04:33 | |
| gus | yes, I don't think people understand just how much more sophisticated it's checks are compared to hacking/pep8 :( | 04:33 |
| armax | gus: well…time is precious | 04:34 |
| armax | gus: so if we can shave a few minutes here and there I guess the request warrants some one-off effort | 04:34 |
| gus | Interesting. That wouldn't catch another unmodified file that imported a freshly changed file in a way that was broken. | 04:34 |
| openstackgerrit | Gandharva proposed openstack/neutron: ovs_neutron_agent should exit gracefully https://review.openstack.org/153138 | 04:34 |
| armax | gus: correct, but the gate always check the entire lot | 04:35 |
| armax | gus: so you can shoot yourself in the foot if you ran the check on the diff locally | 04:35 |
| gus | ah cool. So long as we run the full tests in zuul we should be good. | 04:35 |
| armax | but that can’t happen in the gate | 04:35 |
| armax | gus: unless sowhere were to fiddle with the scripts themselves | 04:36 |
| armax | gus: but I don’t think that happens | 04:36 |
| gus | shoudl that HEAD~1 behaviour just be the default? | 04:36 |
| armax | gus: locally or in the gate? | 04:36 |
| gus | locally. | 04:37 |
| gus | there's even less reason to run pep8 on files that you haven't modified. | 04:37 |
| *** Murali has quit IRC | 04:37 | |
| armax | gus: understood, but to me the default behavior should be ‘care about everything’ | 04:37 |
| armax | gus: not just yourself :) | 04:37 |
| gus | oh, but then we'd need some env vars or something to make the gate do the full check. | 04:37 |
| armax | gus: but I was brought up as a good christian :) | 04:37 |
| gus | heh :) | 04:38 |
| armax | gus: so I’d oppose to flip the default check to be ‘diff’ only | 04:38 |
| gus | ok, I won't propose it then ;) | 04:38 |
| armax | gus: you can, if you like, but I’ll shot it down :) | 04:38 |
| armax | shoot | 04:39 |
| *** anish_ has joined #openstack-neutron | 04:41 | |
| *** dims has joined #openstack-neutron | 04:42 | |
| *** yfried has joined #openstack-neutron | 04:43 | |
| *** yfried|afk has quit IRC | 04:43 | |
| *** spandhe has joined #openstack-neutron | 04:46 | |
| *** dims has quit IRC | 04:47 | |
| openstackgerrit | Juergen Brendel proposed openstack/neutron: ARP spoofing patch: Ebtables/iptables integration https://review.openstack.org/158491 | 04:48 |
| *** aranjan has joined #openstack-neutron | 04:48 | |
| *** annegentle has quit IRC | 04:51 | |
| *** nlahouti has joined #openstack-neutron | 04:52 | |
| *** yuanying has quit IRC | 04:54 | |
| *** achanda has joined #openstack-neutron | 04:55 | |
| *** carl_baldwin has joined #openstack-neutron | 04:59 | |
| *** achanda has quit IRC | 04:59 | |
| *** Marga_ has joined #openstack-neutron | 05:00 | |
| *** Marga_ has quit IRC | 05:01 | |
| *** markvoelker has joined #openstack-neutron | 05:01 | |
| *** Marga_ has joined #openstack-neutron | 05:01 | |
| *** aranjan_ has joined #openstack-neutron | 05:03 | |
| *** aranjan has quit IRC | 05:03 | |
| *** saikrishna has joined #openstack-neutron | 05:03 | |
| *** sgordon is now known as steveg | 05:03 | |
| *** pradipta has quit IRC | 05:04 | |
| *** nlahouti has quit IRC | 05:05 | |
| *** pradip_vedams has joined #openstack-neutron | 05:05 | |
| *** coolsvap_ is now known as coolsvap | 05:08 | |
| *** achanda has joined #openstack-neutron | 05:11 | |
| *** VijayB_ has joined #openstack-neutron | 05:12 | |
| *** chandankumar has joined #openstack-neutron | 05:13 | |
| *** vthapar has joined #openstack-neutron | 05:13 | |
| *** nlahouti has joined #openstack-neutron | 05:16 | |
| *** pradipta has joined #openstack-neutron | 05:16 | |
| *** baoli has quit IRC | 05:19 | |
| *** nlahouti has quit IRC | 05:19 | |
| *** nlahouti has joined #openstack-neutron | 05:19 | |
| *** carl_baldwin has quit IRC | 05:24 | |
| *** pradipta has quit IRC | 05:24 | |
| *** lazy_prince has quit IRC | 05:26 | |
| *** achanda has quit IRC | 05:28 | |
| *** killer_prince has joined #openstack-neutron | 05:29 | |
| *** killer_prince is now known as lazy_prince | 05:29 | |
| *** markvoelker has quit IRC | 05:33 | |
| *** markvoelker has joined #openstack-neutron | 05:33 | |
| *** gildub has joined #openstack-neutron | 05:34 | |
| *** trinaths has joined #openstack-neutron | 05:36 | |
| *** markvoelker has quit IRC | 05:37 | |
| gus | armax: pylint gate job removed. | 05:38 |
| *** csoukup has quit IRC | 05:39 | |
| armax | gus: nice | 05:41 |
| openstackgerrit | stephen-ma proposed openstack/neutron: Router is not unscheduled when the last VM is deleted https://review.openstack.org/159296 | 05:42 |
| *** spandhe has quit IRC | 05:44 | |
| *** steveg is now known as sgordon | 05:47 | |
| *** aranjan_ has quit IRC | 05:49 | |
| *** shwetaap1 has joined #openstack-neutron | 05:49 | |
| *** shwetaap has quit IRC | 05:51 | |
| *** Krast has joined #openstack-neutron | 05:52 | |
| *** achanda has joined #openstack-neutron | 05:59 | |
| *** yatin has joined #openstack-neutron | 06:00 | |
| *** markvoelker has joined #openstack-neutron | 06:04 | |
| *** numan has joined #openstack-neutron | 06:04 | |
| *** rha has quit IRC | 06:05 | |
| *** armax has quit IRC | 06:06 | |
| openstackgerrit | Matthew Thode proposed openstack/neutron: replaces enumeration method used to get a list of interfaces https://review.openstack.org/154128 | 06:06 |
| *** garyk has joined #openstack-neutron | 06:07 | |
| *** trinaths has quit IRC | 06:07 | |
| *** armax has joined #openstack-neutron | 06:08 | |
| *** frickler has quit IRC | 06:08 | |
| *** markvoelker has quit IRC | 06:09 | |
| *** sthillma has joined #openstack-neutron | 06:09 | |
| openstackgerrit | gongysh proposed openstack/neutron: Start metadata agent without trying to connect db https://review.openstack.org/159365 | 06:10 |
| *** carl_baldwin has joined #openstack-neutron | 06:13 | |
| *** oomichi has quit IRC | 06:13 | |
| openstackgerrit | watanabe isao proposed openstack/neutron: KeyError when non enable_dhcp subnet id in the list https://review.openstack.org/157697 | 06:14 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron: Imported Translations from Transifex https://review.openstack.org/159345 | 06:17 |
| *** saikrishna has quit IRC | 06:17 | |
| *** jkraj has joined #openstack-neutron | 06:18 | |
| *** johnbelamaric has quit IRC | 06:18 | |
| *** johnbelamaric has joined #openstack-neutron | 06:18 | |
| *** yapeng has quit IRC | 06:19 | |
| *** saju_m has joined #openstack-neutron | 06:19 | |
| *** trinaths has joined #openstack-neutron | 06:20 | |
| *** carl_baldwin has quit IRC | 06:20 | |
| *** Marga_ has quit IRC | 06:21 | |
| *** anshul has joined #openstack-neutron | 06:23 | |
| *** saikrishna has joined #openstack-neutron | 06:28 | |
| *** dims has joined #openstack-neutron | 06:31 | |
| trinaths | Hi Neutroners, Very Good Morning all.. | 06:32 |
| trinaths | Freescale CI is not active. | 06:32 |
| trinaths | Freescale CI is now Active. | 06:32 |
| *** dims has quit IRC | 06:36 | |
| *** SridharG has joined #openstack-neutron | 06:41 | |
| *** chandankumar has quit IRC | 06:44 | |
| *** gildub has quit IRC | 06:45 | |
| *** Murali has joined #openstack-neutron | 06:45 | |
| *** VijayB_ has quit IRC | 06:47 | |
| openstackgerrit | Romil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB https://review.openstack.org/153891 | 06:51 |
| *** jobewan has quit IRC | 06:52 | |
| *** shwetaap1 has quit IRC | 06:54 | |
| *** tsg_ has joined #openstack-neutron | 06:56 | |
| *** bashok has joined #openstack-neutron | 06:59 | |
| *** tsg has quit IRC | 06:59 | |
| *** chandankumar has joined #openstack-neutron | 07:02 | |
| *** neeti has joined #openstack-neutron | 07:05 | |
| *** markvoelker has joined #openstack-neutron | 07:05 | |
| *** saju_m has quit IRC | 07:05 | |
| *** saju_m has joined #openstack-neutron | 07:06 | |
| *** aranjan has joined #openstack-neutron | 07:07 | |
| *** scheuran has joined #openstack-neutron | 07:08 | |
| *** gongysh has joined #openstack-neutron | 07:09 | |
| *** markvoelker has quit IRC | 07:09 | |
| *** spandhe has joined #openstack-neutron | 07:10 | |
| *** saikrishna has quit IRC | 07:10 | |
| *** saikrishna has joined #openstack-neutron | 07:11 | |
| *** aranjan has quit IRC | 07:11 | |
| *** saikrishna has quit IRC | 07:14 | |
| *** yfauser has joined #openstack-neutron | 07:17 | |
| *** yfauser has left #openstack-neutron | 07:18 | |
| *** SridharG has quit IRC | 07:19 | |
| *** SumitNaiksatam has quit IRC | 07:19 | |
| *** aepifanov has joined #openstack-neutron | 07:21 | |
| *** SumitNaiksatam has joined #openstack-neutron | 07:21 | |
| *** Murali_ has joined #openstack-neutron | 07:24 | |
| *** nlahouti has quit IRC | 07:24 | |
| *** Murali has quit IRC | 07:24 | |
| *** Murali_ is now known as Murali | 07:24 | |
| *** aepifanov has quit IRC | 07:25 | |
| *** oda-g has quit IRC | 07:27 | |
| *** tomoe_ has quit IRC | 07:29 | |
| *** saikrishna has joined #openstack-neutron | 07:32 | |
| *** tflynn has quit IRC | 07:36 | |
| *** crc32 has quit IRC | 07:37 | |
| *** achanda has quit IRC | 07:38 | |
| *** tomoe_ has joined #openstack-neutron | 07:39 | |
| *** numan has quit IRC | 07:41 | |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Add ability to run pylint check on modified files only https://review.openstack.org/159341 | 07:44 |
| *** achanda has joined #openstack-neutron | 07:45 | |
| *** Miouge has joined #openstack-neutron | 07:47 | |
| *** Murali_ has joined #openstack-neutron | 07:50 | |
| *** achanda has quit IRC | 07:50 | |
| *** armax has quit IRC | 07:52 | |
| *** Murali has quit IRC | 07:52 | |
| *** Murali_ is now known as Murali | 07:52 | |
| *** dmellado has quit IRC | 07:52 | |
| *** numan has joined #openstack-neutron | 07:54 | |
| *** dmellado has joined #openstack-neutron | 07:54 | |
| *** pask81 has joined #openstack-neutron | 08:04 | |
| *** yatin has quit IRC | 08:05 | |
| *** ronis has joined #openstack-neutron | 08:07 | |
| *** frickler has joined #openstack-neutron | 08:10 | |
| openstackgerrit | Brandon Logan proposed openstack/python-neutronclient: Fixed pool and health monitor create bugs https://review.openstack.org/159743 | 08:12 |
| *** tgohad has joined #openstack-neutron | 08:13 | |
| *** Murali_ has joined #openstack-neutron | 08:14 | |
| *** tsg_ has quit IRC | 08:15 | |
| *** doude has joined #openstack-neutron | 08:15 | |
| *** Murali has quit IRC | 08:16 | |
| *** Murali_ is now known as Murali | 08:17 | |
| *** spandhe has quit IRC | 08:18 | |
| *** Jabadia_ has quit IRC | 08:20 | |
| *** matrohon has joined #openstack-neutron | 08:23 | |
| *** yfried has quit IRC | 08:27 | |
| openstackgerrit | Nikolay Fedotov proposed openstack/neutron-vpnaas: Scenario test for vpnaas: ipsec-site-connection https://review.openstack.org/159746 | 08:27 |
| *** ChuckC has joined #openstack-neutron | 08:27 | |
| *** Miouge_ has joined #openstack-neutron | 08:31 | |
| *** Miouge has quit IRC | 08:31 | |
| *** Miouge_ is now known as Miouge | 08:31 | |
| *** criptoverso has joined #openstack-neutron | 08:32 | |
| *** tomoe_ has quit IRC | 08:33 | |
| *** criptoverso has left #openstack-neutron | 08:33 | |
| *** criptoverso has joined #openstack-neutron | 08:34 | |
| *** salv-orlando has joined #openstack-neutron | 08:34 | |
| *** jlanoux has joined #openstack-neutron | 08:39 | |
| *** tomoe_ has joined #openstack-neutron | 08:39 | |
| *** chlong has quit IRC | 08:44 | |
| *** kawa2014 has joined #openstack-neutron | 08:46 | |
| *** ygbo has joined #openstack-neutron | 08:46 | |
| *** jpena has joined #openstack-neutron | 08:48 | |
| openstackgerrit | Darragh O'Reilly proposed openstack/neutron: Fix dhcp _test_sync_state_helper asserting calls wrong https://review.openstack.org/159756 | 08:56 |
| *** jistr has joined #openstack-neutron | 08:56 | |
| *** yamamoto has quit IRC | 08:58 | |
| *** apuimedo has joined #openstack-neutron | 08:59 | |
| *** sbelous has joined #openstack-neutron | 09:00 | |
| openstackgerrit | Elena Ezhova proposed openstack/neutron: Prevent calling waitall() inside a GreenPool's greenthread https://review.openstack.org/157320 | 09:03 |
| *** ajo has joined #openstack-neutron | 09:03 | |
| *** yamamoto has joined #openstack-neutron | 09:03 | |
| *** ajo has quit IRC | 09:07 | |
| *** markvoelker has joined #openstack-neutron | 09:07 | |
| *** ajo has joined #openstack-neutron | 09:10 | |
| openstackgerrit | Elena Ezhova proposed openstack/neutron: Prevent calling waitall() inside a GreenPool's greenthread https://review.openstack.org/157320 | 09:11 |
| openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Add test case for the 'Peer ID gets additional "@"' fix https://review.openstack.org/158074 | 09:12 |
| *** saikrishna has quit IRC | 09:12 | |
| *** markvoelker has quit IRC | 09:13 | |
| *** tomoe_ has quit IRC | 09:14 | |
| *** numan has quit IRC | 09:16 | |
| *** yatin has joined #openstack-neutron | 09:18 | |
| *** tomoe_ has joined #openstack-neutron | 09:22 | |
| *** tomoe_ has quit IRC | 09:26 | |
| *** tomoe_ has joined #openstack-neutron | 09:26 | |
| *** tomoe_ has quit IRC | 09:26 | |
| *** chandankumar has quit IRC | 09:31 | |
| *** ihrachyshka has joined #openstack-neutron | 09:34 | |
| *** chandankumar has joined #openstack-neutron | 09:36 | |
| *** flwang1 has joined #openstack-neutron | 09:39 | |
| *** armax has joined #openstack-neutron | 09:43 | |
| *** neeti has quit IRC | 09:45 | |
| *** aepifanov has joined #openstack-neutron | 09:46 | |
| *** belmoreira has joined #openstack-neutron | 09:47 | |
| *** neeti has joined #openstack-neutron | 09:47 | |
| *** numan has joined #openstack-neutron | 09:48 | |
| *** chandankumar has quit IRC | 09:52 | |
| *** aignatov has quit IRC | 09:53 | |
| *** aignatov has joined #openstack-neutron | 09:53 | |
| armax | enikanorov: ping | 09:56 |
| armax | enikanorov__: ping | 09:57 |
| armax | kevinbenton: ping | 09:57 |
| *** popw has quit IRC | 09:59 | |
| openstackgerrit | gongysh proposed openstack/neutron: Add extra subnet route to ha router https://review.openstack.org/159772 | 10:04 |
| *** chandankumar has joined #openstack-neutron | 10:05 | |
| openstackgerrit | Aman Kumar proposed openstack/neutron: br-tun lost ports/flows if openvswitch restart https://review.openstack.org/159775 | 10:10 |
| enikanorov__ | armax: hi | 10:14 |
| armax | enikanorov__: posted a couple of comments on https://review.openstack.org/#/c/137017/ | 10:14 |
| armax | enikanorov__: see if they make sense to you | 10:14 |
| enikanorov__ | armax: yeah | 10:15 |
| armax | enikanorov__: cool | 10:16 |
| *** rkukura_ has joined #openstack-neutron | 10:19 | |
| *** rkukura has quit IRC | 10:21 | |
| *** rkukura_ is now known as rkukura | 10:21 | |
| *** yatin has quit IRC | 10:28 | |
| *** neeti has quit IRC | 10:33 | |
| openstackgerrit | Pranav Salunke proposed openstack/neutron: Add non-isolated network metadata server route https://review.openstack.org/159580 | 10:36 |
| *** ajmiller has quit IRC | 10:38 | |
| *** ajmiller has joined #openstack-neutron | 10:38 | |
| openstackgerrit | yalei wang proposed openstack/neutron: Add portsecurity extension support https://review.openstack.org/126552 | 10:42 |
| *** Miouge has quit IRC | 10:44 | |
| openstackgerrit | Dermot Tynan proposed openstack/neutron: Make del_fdb_flow() idempotent. https://review.openstack.org/157871 | 10:50 |
| *** yog_ has quit IRC | 10:50 | |
| openstackgerrit | Aman Kumar proposed openstack/neutron: br-tun lost ports/flows if openvswitch restart https://review.openstack.org/159775 | 10:51 |
| *** aix has joined #openstack-neutron | 10:52 | |
| *** stanzgy_ has quit IRC | 10:53 | |
| *** stanzgy has quit IRC | 10:54 | |
| *** trinaths has left #openstack-neutron | 10:54 | |
| *** claudiub has joined #openstack-neutron | 10:54 | |
| openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Add test case for the 'Peer ID gets additional "@"' fix https://review.openstack.org/158074 | 10:56 |
| openstackgerrit | Rossella Sblendido proposed openstack/neutron: Don't mock plugin in L3SchedulerTestBaseMixin https://review.openstack.org/159505 | 11:01 |
| *** pc_m has joined #openstack-neutron | 11:09 | |
| *** markvoelker has joined #openstack-neutron | 11:10 | |
| openstackgerrit | Zhang Hua proposed openstack/neutron-vpnaas: Functional tests of ipsec strongswan vpnaas driver https://review.openstack.org/158560 | 11:10 |
| openstackgerrit | Zhang Hua proposed openstack/neutron-vpnaas: IPsec strongSwan driver implemention https://review.openstack.org/144391 | 11:10 |
| *** Miouge has joined #openstack-neutron | 11:12 | |
| *** markvoelker has quit IRC | 11:17 | |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron-vpnaas: Decouple L3 and VPN service plugins during router operations https://review.openstack.org/159793 | 11:18 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Check whether sudo is enabled in BaseSudoTestCase.setUpClass https://review.openstack.org/159193 | 11:21 |
| *** yamamoto has quit IRC | 11:29 | |
| *** coolsvap is now known as coolsvap_ | 11:30 | |
| *** SridharG has joined #openstack-neutron | 11:31 | |
| *** zhhuabj has quit IRC | 11:33 | |
| *** zhhuabj has joined #openstack-neutron | 11:34 | |
| ZZelle | gongysh, hi | 11:34 |
| *** jprovazn has joined #openstack-neutron | 11:44 | |
| *** SridharG has quit IRC | 11:44 | |
| openstackgerrit | Merged openstack/neutron: test_l2population: Use a fake mech driver instead of ofagent https://review.openstack.org/150239 | 11:50 |
| openstackgerrit | Pavel Bondar proposed openstack/neutron: Introduce External IPAM Interface https://review.openstack.org/134339 | 11:52 |
| *** diegows has joined #openstack-neutron | 11:53 | |
| openstackgerrit | Rossella Sblendido proposed openstack/neutron: Don't mock plugin in L3SchedulerTestBaseMixin https://review.openstack.org/159505 | 11:59 |
| openstackgerrit | Merged openstack/neutron: Remove port from ovsdb after its deletion https://review.openstack.org/143865 | 11:59 |
| *** aix has quit IRC | 12:00 | |
| *** coolsvap_ is now known as coolsvap | 12:02 | |
| *** ronis_ has joined #openstack-neutron | 12:03 | |
| *** ronis has quit IRC | 12:03 | |
| *** erkules_ is now known as erkules | 12:04 | |
| *** afazekas has joined #openstack-neutron | 12:04 | |
| *** dims has joined #openstack-neutron | 12:04 | |
| *** zhhuabj has quit IRC | 12:06 | |
| *** marrusl has quit IRC | 12:12 | |
| *** chandankumar_ has joined #openstack-neutron | 12:12 | |
| *** zhhuabj has joined #openstack-neutron | 12:12 | |
| *** SridharG has joined #openstack-neutron | 12:12 | |
| *** markvoelker has joined #openstack-neutron | 12:13 | |
| *** yamamoto has joined #openstack-neutron | 12:14 | |
| *** flaviof has joined #openstack-neutron | 12:15 | |
| *** chandankumar has quit IRC | 12:15 | |
| *** markvoelker has quit IRC | 12:17 | |
| *** marrusl has joined #openstack-neutron | 12:20 | |
| *** amotoki has joined #openstack-neutron | 12:21 | |
| *** lazy_prince is now known as killer_prince | 12:23 | |
| openstackgerrit | Claudiu Belu proposed openstack/neutron: Remove HyperVNeutronPlugin https://review.openstack.org/153394 | 12:24 |
| openstackgerrit | Claudiu Belu proposed openstack/neutron: Adds migration script for Hyper-V Plugin tables https://review.openstack.org/156288 | 12:24 |
| *** SridharG has left #openstack-neutron | 12:24 | |
| *** neeti has joined #openstack-neutron | 12:32 | |
| *** SridharG has joined #openstack-neutron | 12:35 | |
| *** saju_m has quit IRC | 12:36 | |
| *** johnbelamaric has quit IRC | 12:37 | |
| openstackgerrit | Pavel Bondar proposed openstack/neutron: Implement IPAM Driver loader https://review.openstack.org/147479 | 12:41 |
| *** SridharG has left #openstack-neutron | 12:41 | |
| ZZelle | Hi, | 12:47 |
| ZZelle | Is it normal that only 5 checks have been done on https://review.openstack.org/159193 ? | 12:48 |
| *** wverdugo500 has left #openstack-neutron | 12:48 | |
| *** saikrishna has joined #openstack-neutron | 12:52 | |
| *** ZZelle has quit IRC | 12:52 | |
| *** ZZelle has joined #openstack-neutron | 12:52 | |
| salv-orlando | ZZelle: maybe your patch matches the filter https://review.openstack.org/#/c/152298/6/zuul/layout.yaml and dsvm have been skipped because of https://review.openstack.org/#/c/146762/ | 12:54 |
| *** aix has joined #openstack-neutron | 12:55 | |
| ZZelle | salv-orlando, outch so less jobs for test/doc only changes | 12:56 |
| salv-orlando | do you think it's a bad idea? It makes some sense to me | 12:56 |
| ZZelle | salv-orlando, it's really a good idea but just surprised we can fine tune CI so much | 12:57 |
| ZZelle | salv-orlando, if you have some time, could you look at https://review.openstack.org/147437 (about not running metadata proxy as root on dhcp-agent)? | 12:58 |
| salv-orlando | ZZelle: ok | 12:59 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Migrate to oslo.log https://review.openstack.org/159638 | 12:59 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: oslo: sync all modules that depend on incubator log module https://review.openstack.org/159654 | 12:59 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: test_metadata_agent: don't check implementation details https://review.openstack.org/159821 | 12:59 |
| *** neeti has quit IRC | 13:06 | |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron-vpnaas: Decouple L3 and VPN service plugins during router operations https://review.openstack.org/159793 | 13:11 |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Decouple L3 and VPN service plugins during router operations https://review.openstack.org/153776 | 13:13 |
| *** pradip_vedams has quit IRC | 13:13 | |
| *** pradip_vedams has joined #openstack-neutron | 13:13 | |
| *** markvoelker has joined #openstack-neutron | 13:14 | |
| *** ronis_ has quit IRC | 13:14 | |
| *** markvoelker has quit IRC | 13:19 | |
| *** devvesa has joined #openstack-neutron | 13:19 | |
| *** baoli has joined #openstack-neutron | 13:19 | |
| *** sbelous has quit IRC | 13:21 | |
| *** baoli has quit IRC | 13:24 | |
| *** scheuran has quit IRC | 13:25 | |
| *** ronis_ has joined #openstack-neutron | 13:25 | |
| *** baoli has joined #openstack-neutron | 13:25 | |
| *** armax has quit IRC | 13:26 | |
| *** sbelous has joined #openstack-neutron | 13:26 | |
| *** bobmel has quit IRC | 13:27 | |
| *** dims is now known as dimsum__ | 13:27 | |
| *** bobmel has joined #openstack-neutron | 13:27 | |
| *** yfauser1 has joined #openstack-neutron | 13:27 | |
| *** yfauser1 has left #openstack-neutron | 13:28 | |
| *** ajmiller has quit IRC | 13:29 | |
| *** Miouge has quit IRC | 13:37 | |
| *** lukasa has quit IRC | 13:38 | |
| *** amuller has joined #openstack-neutron | 13:38 | |
| openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: Document the testing effort on OpenFlow stateful firewalling https://review.openstack.org/159840 | 13:48 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Allow AsyncProcess to block on process start and stop https://review.openstack.org/158097 | 13:48 |
| *** Miouge has joined #openstack-neutron | 13:49 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Introduce ip address monitor https://review.openstack.org/149647 | 13:49 |
| *** gongysh has quit IRC | 13:53 | |
| *** vthapar has quit IRC | 13:53 | |
| *** vthapar has joined #openstack-neutron | 13:53 | |
| *** vthapar has quit IRC | 13:53 | |
| *** radez_g0n3 is now known as radez | 13:58 | |
| *** shwetaap has joined #openstack-neutron | 14:02 | |
| *** lukasa has joined #openstack-neutron | 14:07 | |
| *** Miouge_ has joined #openstack-neutron | 14:07 | |
| *** Miouge has quit IRC | 14:08 | |
| *** Miouge_ is now known as Miouge | 14:08 | |
| *** shwetaap1 has joined #openstack-neutron | 14:08 | |
| openstackgerrit | Claudiu Belu proposed openstack/neutron: Remove HyperVNeutronPlugin https://review.openstack.org/153394 | 14:10 |
| *** bashok has quit IRC | 14:10 | |
| openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Make listing security groups faster https://review.openstack.org/159850 | 14:10 |
| *** chandankumar_ has quit IRC | 14:11 | |
| *** shwetaap has quit IRC | 14:12 | |
| *** itzikb has joined #openstack-neutron | 14:12 | |
| *** gongysh has joined #openstack-neutron | 14:12 | |
| openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Make listing security groups faster https://review.openstack.org/159850 | 14:13 |
| openstackgerrit | Brian Haley proposed openstack/neutron: Change linux/ip_lib code to better handle address families https://review.openstack.org/157555 | 14:14 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Transform BaseLinuxTestCase methods in helpers (WIP) https://review.openstack.org/159852 | 14:15 |
| *** markvoelker has joined #openstack-neutron | 14:15 | |
| *** saikrishna has quit IRC | 14:17 | |
| *** Miouge has quit IRC | 14:17 | |
| *** dboik has joined #openstack-neutron | 14:18 | |
| *** jprovazn has quit IRC | 14:19 | |
| *** dboik has quit IRC | 14:20 | |
| *** markvoelker has quit IRC | 14:20 | |
| *** dboik has joined #openstack-neutron | 14:20 | |
| *** saikrishna has joined #openstack-neutron | 14:21 | |
| *** markvoelker has joined #openstack-neutron | 14:22 | |
| *** trown|outttypeww is now known as trown | 14:22 | |
| *** amotoki has quit IRC | 14:24 | |
| *** mestery has quit IRC | 14:25 | |
| *** devvesa has quit IRC | 14:25 | |
| *** tiswanso has joined #openstack-neutron | 14:25 | |
| *** Murali has quit IRC | 14:26 | |
| gongysh | amuller, hi | 14:27 |
| amuller | gongysh: heya | 14:27 |
| *** csoukup has joined #openstack-neutron | 14:30 | |
| *** dane_leblanc has joined #openstack-neutron | 14:30 | |
| *** Miouge has joined #openstack-neutron | 14:31 | |
| *** coolsvap is now known as coolsvap_ | 14:31 | |
| *** logan2 has quit IRC | 14:32 | |
| *** kbringard has joined #openstack-neutron | 14:33 | |
| *** thomasem has joined #openstack-neutron | 14:33 | |
| *** thomasem has quit IRC | 14:34 | |
| *** dimsum__ has quit IRC | 14:36 | |
| *** numan has quit IRC | 14:37 | |
| *** itzikb has quit IRC | 14:38 | |
| *** tgohad has quit IRC | 14:38 | |
| *** dims_ has joined #openstack-neutron | 14:38 | |
| *** claudiub has quit IRC | 14:39 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: policy: don't hack around oslo.config path search algorithm https://review.openstack.org/159862 | 14:41 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: initialize policy in BaseTestCase https://review.openstack.org/159863 | 14:41 |
| *** mestery has joined #openstack-neutron | 14:41 | |
| *** johnbelamaric has joined #openstack-neutron | 14:42 | |
| *** pradip_rawat has joined #openstack-neutron | 14:42 | |
| *** pradip_rawat has quit IRC | 14:43 | |
| *** pradip_rawat has joined #openstack-neutron | 14:43 | |
| mestery | HenryG: You around? | 14:43 |
| HenryG | mestery: Yo | 14:44 |
| mestery | HenryG: Do you have time to look at a new gate bug? It's IPV6 related, so I thought of you ;) | 14:44 |
| mestery | HenryG: https://bugs.launchpad.net/neutron/+bug/1426397 | 14:44 |
| openstack | Launchpad bug 1426397 in neutron "tempest.scenario.test_network_v6.TestGettingAddress.test_slaac_from_os intermittently fails with MismatchError" [Undecided,New] | 14:44 |
| *** pradip_vedams has quit IRC | 14:45 | |
| *** pradip_rawat is now known as pradip_vedams | 14:45 | |
| HenryG | mestery: I'll take a look | 14:45 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Migrate to oslo.log https://review.openstack.org/159638 | 14:45 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: oslo: sync all modules that depend on incubator log module https://review.openstack.org/159654 | 14:45 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: test_metadata_agent: don't check implementation details https://review.openstack.org/159821 | 14:45 |
| mestery | HenryG: Thanks! Let me know if you don't have time. | 14:45 |
| *** logan2 has joined #openstack-neutron | 14:45 | |
| *** dansmith is now known as superdan | 14:48 | |
| *** pradip_vedams has quit IRC | 14:48 | |
| *** pradip_vedams has joined #openstack-neutron | 14:49 | |
| *** thomasem has joined #openstack-neutron | 14:49 | |
| *** numan has joined #openstack-neutron | 14:50 | |
| *** Zemeio has quit IRC | 14:56 | |
| *** Zemeio has joined #openstack-neutron | 14:56 | |
| *** anish_ has quit IRC | 15:00 | |
| *** numan has quit IRC | 15:02 | |
| *** rushil has joined #openstack-neutron | 15:02 | |
| *** criptoverso has quit IRC | 15:03 | |
| amuller | kevinbenton: alive? | 15:08 |
| amuller | about https://review.openstack.org/#/c/158097/ | 15:08 |
| *** SridharG has joined #openstack-neutron | 15:09 | |
| *** yamamoto has quit IRC | 15:09 | |
| *** zz_jgrimm is now known as jgrimm | 15:12 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-vpnaas: Migrate to oslo.log https://review.openstack.org/159880 | 15:13 |
| *** ajmiller has joined #openstack-neutron | 15:15 | |
| *** carl_baldwin has joined #openstack-neutron | 15:19 | |
| *** apuimedo has quit IRC | 15:21 | |
| *** yeungp has joined #openstack-neutron | 15:21 | |
| *** apuimedo has joined #openstack-neutron | 15:22 | |
| *** yamamoto has joined #openstack-neutron | 15:23 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Transform BaseLinuxTestCase methods in helpers (WIP) https://review.openstack.org/159852 | 15:23 |
| *** ChuckC has quit IRC | 15:23 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: policy: don't hack around oslo.config path search algorithm https://review.openstack.org/159862 | 15:26 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: initialize policy in BaseTestCase https://review.openstack.org/159863 | 15:26 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Introduce ip address monitor https://review.openstack.org/149647 | 15:28 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-vpnaas: Migrate to oslo.log https://review.openstack.org/159887 | 15:29 |
| *** numan has joined #openstack-neutron | 15:29 | |
| *** yamamoto has quit IRC | 15:29 | |
| *** achanda has joined #openstack-neutron | 15:31 | |
| *** manishg has joined #openstack-neutron | 15:31 | |
| *** annegentle has joined #openstack-neutron | 15:31 | |
| *** markvoelker has quit IRC | 15:32 | |
| *** markvoelker has joined #openstack-neutron | 15:32 | |
| *** prad has joined #openstack-neutron | 15:34 | |
| *** jobewan has joined #openstack-neutron | 15:35 | |
| *** ajmiller_ has joined #openstack-neutron | 15:35 | |
| *** vishwanathj has joined #openstack-neutron | 15:36 | |
| *** achanda has quit IRC | 15:36 | |
| *** markvoelker has quit IRC | 15:37 | |
| *** vishwanathj has quit IRC | 15:37 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-fwaas: Migrate to oslo.log https://review.openstack.org/159891 | 15:38 |
| *** ajmiller has quit IRC | 15:38 | |
| *** manishg has quit IRC | 15:39 | |
| *** amotoki has joined #openstack-neutron | 15:40 | |
| *** manishg has joined #openstack-neutron | 15:40 | |
| *** salv-orlando has quit IRC | 15:40 | |
| openstackgerrit | Carl Baldwin proposed openstack/neutron: Refactor DVR _arp_entry methods https://review.openstack.org/158433 | 15:41 |
| *** manishg has quit IRC | 15:44 | |
| *** dtynan has joined #openstack-neutron | 15:44 | |
| *** tsg has joined #openstack-neutron | 15:45 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-fwaas: Removed lockutils-wrapper from tox targets https://review.openstack.org/159895 | 15:45 |
| *** blues-man has joined #openstack-neutron | 15:45 | |
| *** prad has quit IRC | 15:46 | |
| openstackgerrit | gongysh proposed openstack/neutron: Add extra subnet route to ha router https://review.openstack.org/159772 | 15:47 |
| *** afazekas has quit IRC | 15:50 | |
| *** Miouge has quit IRC | 15:52 | |
| *** armax has joined #openstack-neutron | 15:53 | |
| *** armax has quit IRC | 15:53 | |
| *** armax has joined #openstack-neutron | 15:54 | |
| openstackgerrit | Zhang Hua proposed openstack/neutron-vpnaas: Functional tests of ipsec strongswan vpnaas driver https://review.openstack.org/158560 | 15:57 |
| openstackgerrit | Zhang Hua proposed openstack/neutron-vpnaas: IPsec strongSwan driver implemention https://review.openstack.org/144391 | 15:57 |
| *** markvoelker has joined #openstack-neutron | 15:58 | |
| openstackgerrit | Pavel Bondar proposed openstack/neutron: Refactor db_base_plugin_v2.py to use new IPAM https://review.openstack.org/153236 | 15:58 |
| *** Miouge has joined #openstack-neutron | 15:58 | |
| openstackgerrit | Romil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB https://review.openstack.org/153891 | 16:01 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: policy: don't hack around oslo.config path search algorithm https://review.openstack.org/159862 | 16:02 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: initialize policy in BaseTestCase https://review.openstack.org/159863 | 16:02 |
| *** Marga_ has joined #openstack-neutron | 16:03 | |
| *** ajo has quit IRC | 16:04 | |
| *** ajmiller_ is now known as ajmiller | 16:04 | |
| *** gongysh has quit IRC | 16:05 | |
| *** csoukup has quit IRC | 16:06 | |
| *** ajo has joined #openstack-neutron | 16:08 | |
| *** rushil has quit IRC | 16:09 | |
| *** ronis_ has quit IRC | 16:09 | |
| *** xgerman has joined #openstack-neutron | 16:14 | |
| *** tomoe_ has joined #openstack-neutron | 16:14 | |
| *** csoukup has joined #openstack-neutron | 16:15 | |
| *** ChuckC has joined #openstack-neutron | 16:16 | |
| *** ChuckC has quit IRC | 16:17 | |
| *** ChuckC has joined #openstack-neutron | 16:17 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Transform BaseLinuxTestCase methods in helpers (WIP) https://review.openstack.org/159852 | 16:18 |
| ZZelle | haleyb, hi | 16:18 |
| haleyb | ZZelle: hi, you must have seen my comment | 16:18 |
| ZZelle | haleyb, i fail to understand your last comment :( | 16:19 |
| *** rushil has joined #openstack-neutron | 16:19 | |
| *** david-lyle_afk is now known as david-lyle | 16:19 | |
| ZZelle | haleyb, it seems something is missing in PS3 to match your needs? | 16:19 |
| *** ChuckC has quit IRC | 16:20 | |
| haleyb | ZZelle: yes, even with that change if i directly curl the endpoint for versions i get "http" because it's basically hard-coded | 16:20 |
| *** apuimedo has quit IRC | 16:20 | |
| *** ChuckC has joined #openstack-neutron | 16:21 | |
| *** anish_ has joined #openstack-neutron | 16:22 | |
| *** gongysh has joined #openstack-neutron | 16:22 | |
| *** tim_o_ has joined #openstack-neutron | 16:23 | |
| ZZelle | haleyb, strange, it's working on heat juno when i do curl http:....:8004/ -H "X-Forwarded-Proto: https" | 16:24 |
| *** markvoelker has quit IRC | 16:25 | |
| haleyb | ZZelle: well, if you don't use the X-Forwarded... | 16:26 |
| ZZelle | haleyb, the X-Forward-Proto header should be added by the ssl termination proxy | 16:27 |
| *** reed has joined #openstack-neutron | 16:27 | |
| ZZelle | ie: i am testing without a proxy :) | 16:27 |
| *** aepifanov has quit IRC | 16:28 | |
| haleyb | ZZelle: yes, this might be more an internal requirement that we always want to say https, but that req.mumble member is always http | 16:28 |
| ZZelle | let me check with neutron | 16:29 |
| *** prad has joined #openstack-neutron | 16:30 | |
| ChuckC | armax: hi | 16:30 |
| *** yamamoto has joined #openstack-neutron | 16:30 | |
| *** markvoelker has joined #openstack-neutron | 16:32 | |
| *** Matt2 has joined #openstack-neutron | 16:32 | |
| armax | ChuckC: hi | 16:33 |
| ZZelle | haleyb, https://github.com/openstack/heat/blob/master/heat/api/openstack/versions.py looks really different | 16:33 |
| ChuckC | armax: In https://review.openstack.org/#/c/129085/13/specs/kilo/mac_addr_update.rst,cm you requested a scenario test, but I struggle now with modifying the mac address of the virtual nic underlying the neutron port | 16:33 |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Add ability to run pylint check on modified files only https://review.openstack.org/159341 | 16:33 |
| armax | ChuckC: struggle how? | 16:33 |
| ChuckC | armax: I don't know how to do that without manipulating the hypervisor directly which is a no-no for tempest, right? Do you have any ideas, or perhaps I'll focus on functional test? | 16:33 |
| armax | ChuckC: can you remind me the test you’re trying to write? | 16:34 |
| ChuckC | armax: sorry, just to test updating the mac address of an (offline) port | 16:35 |
| *** yamamoto has quit IRC | 16:35 | |
| *** david-lyle is now known as david-lyle_Afk | 16:35 | |
| *** david-lyle_Afk is now known as david-lyle_afk | 16:35 | |
| haleyb | ZZelle: yes, different, but i think it will still return req.host_url | 16:35 |
| armax | ChuckC: ? | 16:36 |
| *** manishg has joined #openstack-neutron | 16:37 | |
| *** manishg has quit IRC | 16:37 | |
| *** manishg has joined #openstack-neutron | 16:37 | |
| *** nlahouti has joined #openstack-neutron | 16:37 | |
| ChuckC | armax: I'm trying to write a scenario test to validate connectivity after changing a port's mac address | 16:37 |
| armax | ChuckC: gotcha | 16:38 |
| armax | ChuckC: for a virtual vm? | 16:38 |
| armax | s/vm/node | 16:38 |
| armax | :) | 16:38 |
| ChuckC | armax: yes, that's one of the 2 cases, the other is ironic | 16:38 |
| armax | so why do you think you need to modify the hypervisor? | 16:39 |
| ZZelle | gongysh, hi | 16:39 |
| *** rwsu-afk is now known as rwsu | 16:39 | |
| ChuckC | armax: the nic of the vm needs to have the same mac address as the neutron port | 16:40 |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: initialize policy in BaseTestCase https://review.openstack.org/159863 | 16:41 |
| ChuckC | armax: if I change one, I have to change the other | 16:41 |
| armax | ChuckC: so how do you envision this work in reality? | 16:41 |
| openstackgerrit | Pranav Salunke proposed openstack/neutron: Add non-isolated network metadata server route https://review.openstack.org/159580 | 16:43 |
| armax | ChuckC: it sounds to me that the ability to update a nic attribute is something that should come from Nova | 16:43 |
| ChuckC | armax: I don't have a strong use case for non-ironic virtual machines | 16:43 |
| armax | or Ironic | 16:43 |
| *** jobewan has quit IRC | 16:43 | |
| ChuckC | armax: but in the tempest test runs, even ironic servers are vms | 16:44 |
| ChuckC | armax: sounds like this may require changes in nova/ironic, then... | 16:45 |
| armax | have you considered using nova interface/attach-detach? | 16:45 |
| armax | ChuckC: I wonder if that can preserve the port | 16:45 |
| armax | ChuckC: if I look at the help inline it seems it does | 16:47 |
| armax | so the test could do: 0) test connectivity; 1) detach interface; 2) update port mac; 3) attach interface; 4) test connectivity | 16:48 |
| ChuckC | armax: 'help inline'? | 16:48 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Transform BaseLinuxTestCase methods in helpers (WIP) https://review.openstack.org/159852 | 16:48 |
| *** sballe__ has quit IRC | 16:48 | |
| armax | ChuckC: novaclient | 16:48 |
| *** anshul has quit IRC | 16:49 | |
| ChuckC | armax: thanks, the online doc was very brief on those commands | 16:49 |
| *** carl_baldwin has quit IRC | 16:49 | |
| *** tomoe_ has quit IRC | 16:50 | |
| ChuckC | armax: although since they both take port_id, I should have figured that out :P | 16:50 |
| armax | ChuckC: perhaps if you look at test_network_basic_ops | 16:51 |
| armax | https://github.com/openstack/tempest/blob/master/tempest/scenario/test_network_basic_ops.py#L390 | 16:51 |
| *** Marga_ has quit IRC | 16:51 | |
| ZZelle | haleyb, if i print request.host_url in https://review.openstack.org/#/c/157087/3/neutron/tests/unit/test_ssl_middleware.py, the scheme is correct | 16:51 |
| armax | and you take it as base for this test, you might get somewhere | 16:51 |
| *** Marga_ has joined #openstack-neutron | 16:51 | |
| *** moha_hunt has joined #openstack-neutron | 16:52 | |
| *** pask81 has quit IRC | 16:53 | |
| *** ivar-lazzaro has joined #openstack-neutron | 16:54 | |
| ChuckC | armax: yes, I had looked at that, but hadn't found attach/detach\ | 16:54 |
| ChuckC | armax: thanks again | 16:54 |
| armax | ChuckC: np | 16:55 |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: Basic subnetpool CRUD https://review.openstack.org/148698 | 16:55 |
| *** tflynn has joined #openstack-neutron | 16:56 | |
| openstackgerrit | Ryan Tidwell proposed openstack/neutron: WIP Subnet allocation from a subnet pool https://review.openstack.org/157597 | 16:56 |
| haleyb | ZZelle: neutron does use application_url, which seems to be the same as host_url, but i guess either way without the X-Forwarded header even heat prints http | 16:58 |
| *** tflynn has quit IRC | 16:58 | |
| ZZelle | haleyb, just to be sure, X-Forwarded-Proto header is added by your proxy ? | 16:59 |
| *** blues-man has quit IRC | 16:59 | |
| *** ivar-lazzaro has quit IRC | 16:59 | |
| openstackgerrit | Erik Colnick proposed openstack/neutron: Improve DVR scale performance https://review.openstack.org/150110 | 17:01 |
| *** Marga_ has quit IRC | 17:01 | |
| haleyb | ZZelle: i'm not using a proxy, i was just tasked with making this https, which might not be quite correct | 17:01 |
| *** SumitNaiksatam has quit IRC | 17:02 | |
| haleyb | ZZelle: i will push-out an update to fix jenkins and do some more testing here | 17:02 |
| *** johnbelamaric1 has joined #openstack-neutron | 17:03 | |
| *** johnbelamaric has quit IRC | 17:03 | |
| ZZelle | haleyb, the aim of the ssl middleware is to use the scheme defined in the header X-Forwarded-Proto (when defined) | 17:03 |
| haleyb | ZZelle: yes, understood. This "always https" might just be something we need to configure differently internally. | 17:05 |
| openstackgerrit | Claudiu Belu proposed openstack/neutron: Hyper-V Agent decomposition https://review.openstack.org/153259 | 17:06 |
| *** jlanoux has quit IRC | 17:07 | |
| ZZelle | haleyb, it can be done in the ssl middleware but like public_endpoint_url it hardcodes the scheme instead of delegating the (written) scheme choice to the requester (ie: the ssl proxy) | 17:09 |
| *** annegentle has quit IRC | 17:09 | |
| haleyb | ZZelle: i will just leave it alone for now then, at least supporting the X- header is a step forward | 17:11 |
| *** Miouge has quit IRC | 17:11 | |
| openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: initialize policy in BaseTestCase https://review.openstack.org/159863 | 17:12 |
| *** matrohon has quit IRC | 17:12 | |
| ZZelle | haleyb, ok | 17:14 |
| *** amotoki has quit IRC | 17:14 | |
| openstackgerrit | Brian Haley proposed openstack/neutron: New middleware to handle SSL termination proxies https://review.openstack.org/157087 | 17:15 |
| *** _cjones_ has joined #openstack-neutron | 17:17 | |
| openstackgerrit | Rossella Sblendido proposed openstack/neutron: Set port in error status if operation fails twice https://review.openstack.org/157840 | 17:17 |
| *** johnbelamaric1 has quit IRC | 17:19 | |
| *** VijayB has joined #openstack-neutron | 17:21 | |
| *** shwetaap1 has quit IRC | 17:21 | |
| *** aranjan has joined #openstack-neutron | 17:22 | |
| *** VijayB has quit IRC | 17:23 | |
| *** reed has quit IRC | 17:24 | |
| *** ZZelle has quit IRC | 17:24 | |
| prometheanfire | can I get code review on this? https://review.openstack.org/#/c/154128/ | 17:24 |
| *** zerda has quit IRC | 17:24 | |
| *** jogo is now known as flashgordon | 17:25 | |
| *** jistr has quit IRC | 17:25 | |
| *** jckasper has quit IRC | 17:26 | |
| *** numan has quit IRC | 17:27 | |
| *** VijayB_ has joined #openstack-neutron | 17:28 | |
| *** SridharGaddam has joined #openstack-neutron | 17:29 | |
| *** Miouge has joined #openstack-neutron | 17:29 | |
| *** amuller has quit IRC | 17:31 | |
| *** ronis_ has joined #openstack-neutron | 17:32 | |
| *** jobewan has joined #openstack-neutron | 17:32 | |
| ChuckC | armax: sadly, interface-detach deleted the port | 17:32 |
| *** saikrishna has quit IRC | 17:33 | |
| *** saikrishna has joined #openstack-neutron | 17:34 | |
| *** SridharG has left #openstack-neutron | 17:35 | |
| *** belmoreira has quit IRC | 17:35 | |
| *** SridharG has joined #openstack-neutron | 17:35 | |
| *** mlavalle has joined #openstack-neutron | 17:35 | |
| *** VijayB_ has quit IRC | 17:39 | |
| *** jckasper has joined #openstack-neutron | 17:44 | |
| *** jckasper_ has joined #openstack-neutron | 17:44 | |
| *** VijayB_ has joined #openstack-neutron | 17:44 | |
| openstackgerrit | Manish Godara proposed openstack/neutron: Add filter for provider network attributes in ML2 https://review.openstack.org/124917 | 17:45 |
| *** banix has joined #openstack-neutron | 17:46 | |
| openstackgerrit | Brandon Logan proposed openstack/python-neutronclient: Fixed pool and health monitor create bugs https://review.openstack.org/159743 | 17:46 |
| *** salv-orlando has joined #openstack-neutron | 17:48 | |
| *** jckasper has quit IRC | 17:48 | |
| *** Miouge has quit IRC | 17:49 | |
| *** markvoelker has quit IRC | 17:51 | |
| *** ygbo has quit IRC | 17:57 | |
| *** manishg has quit IRC | 17:58 | |
| *** sbfox has joined #openstack-neutron | 17:58 | |
| *** manishg has joined #openstack-neutron | 17:58 | |
| *** johnbelamaric has joined #openstack-neutron | 17:58 | |
| *** johnbelamaric has quit IRC | 17:59 | |
| *** johnbelamaric has joined #openstack-neutron | 17:59 | |
| *** johnbelamaric has quit IRC | 18:00 | |
| *** johnbelamaric1 has joined #openstack-neutron | 18:00 | |
| *** linuxgeek_ has joined #openstack-neutron | 18:00 | |
| *** Marga_ has joined #openstack-neutron | 18:01 | |
| *** manishg_ has joined #openstack-neutron | 18:02 | |
| *** annegentle has joined #openstack-neutron | 18:02 | |
| *** manishg has quit IRC | 18:03 | |
| *** chlong has joined #openstack-neutron | 18:04 | |
| *** jaypipes has joined #openstack-neutron | 18:05 | |
| *** markvoelker has joined #openstack-neutron | 18:05 | |
| *** annegentle has quit IRC | 18:07 | |
| *** annegentle has joined #openstack-neutron | 18:07 | |
| *** jckasper__ has joined #openstack-neutron | 18:08 | |
| *** marun has joined #openstack-neutron | 18:09 | |
| ChuckC | armax: ^^ even if the port was added to the vm after the vm was created | 18:09 |
| openstackgerrit | Armando Migliaccio proposed openstack/neutron: Revert "Remove port from ovsdb after its deletion" https://review.openstack.org/159939 | 18:10 |
| *** jckasper_ has quit IRC | 18:11 | |
| *** chlong has quit IRC | 18:11 | |
| *** spandhe has joined #openstack-neutron | 18:11 | |
| *** spandhe has quit IRC | 18:11 | |
| *** shwetaap has joined #openstack-neutron | 18:12 | |
| linuxgeek_ | i have a openstack environment and few instances do not get a private ip. i checked neutron and syslog with the mac, private ip and port id but did not find anything. anyone has pointers for me | 18:15 |
| ChuckC | armax: any other thoughts? | 18:15 |
| *** s3wong has joined #openstack-neutron | 18:16 | |
| *** armax has quit IRC | 18:16 | |
| *** achanda has joined #openstack-neutron | 18:16 | |
| *** krtaylor has quit IRC | 18:16 | |
| *** sbfox has quit IRC | 18:17 | |
| *** achanda has quit IRC | 18:17 | |
| ChuckC | garyk: if you have some time, would you review the scrollback discussion armax and I had about trying to scenario test mac address update? | 18:17 |
| *** achanda has joined #openstack-neutron | 18:17 | |
| *** carl_baldwin has joined #openstack-neutron | 18:18 | |
| openstackgerrit | Rossella Sblendido proposed openstack/neutron: Add devices to update in RPC call security_groups_provider_updated https://review.openstack.org/148235 | 18:19 |
| *** sbfox has joined #openstack-neutron | 18:19 | |
| *** kawa2014 has quit IRC | 18:19 | |
| *** killer_prince has quit IRC | 18:20 | |
| *** rpothier has joined #openstack-neutron | 18:21 | |
| *** VijayB_ has quit IRC | 18:21 | |
| *** sbfox has quit IRC | 18:21 | |
| *** killer_prince has joined #openstack-neutron | 18:22 | |
| *** killer_prince is now known as lazy_prince | 18:22 | |
| *** spandhe has joined #openstack-neutron | 18:23 | |
| *** sbfox has joined #openstack-neutron | 18:23 | |
| *** leenheer has joined #openstack-neutron | 18:24 | |
| *** VijayB has joined #openstack-neutron | 18:25 | |
| *** ivar-lazzaro has joined #openstack-neutron | 18:27 | |
| *** jaypipes has quit IRC | 18:27 | |
| *** chlong has joined #openstack-neutron | 18:28 | |
| *** krtaylor has joined #openstack-neutron | 18:28 | |
| *** aranjan has quit IRC | 18:29 | |
| *** rms_13 has joined #openstack-neutron | 18:30 | |
| *** david-lyle_afk is now known as david-lyle | 18:35 | |
| *** amuller has joined #openstack-neutron | 18:36 | |
| *** Zemeio has quit IRC | 18:37 | |
| *** Marga_ has quit IRC | 18:37 | |
| *** Marga_ has joined #openstack-neutron | 18:38 | |
| *** Zemeio has joined #openstack-neutron | 18:38 | |
| amuller | marun: I don't think the non-test AsyncProcess.stop should have that parameter... | 18:38 |
| amuller | That safe_stop will be in two places: Where it is now, and in the ip_monitor test class | 18:38 |
| *** chlong has quit IRC | 18:38 | |
| amuller | I don't think it's a problem at all | 18:39 |
| openstackgerrit | Ronak Shah proposed openstack/neutron: Adding DB model changes for Nuage Plugin post decomposition https://review.openstack.org/159281 | 18:39 |
| *** pradip_vedams has quit IRC | 18:41 | |
| *** aepifanov has joined #openstack-neutron | 18:41 | |
| *** pradip_vedams has joined #openstack-neutron | 18:41 | |
| *** VijayB has quit IRC | 18:44 | |
| carl_baldwin | mlavalle: ping | 18:44 |
| *** bo-quan has joined #openstack-neutron | 18:46 | |
| *** VijayB has joined #openstack-neutron | 18:48 | |
| med_ | bo-quan, this is how I would do it | 18:50 |
| *** anish_ has quit IRC | 18:50 | |
| *** Marga_ has quit IRC | 18:52 | |
| *** Marga_ has joined #openstack-neutron | 18:53 | |
| *** yamahata has joined #openstack-neutron | 18:53 | |
| *** Miouge has joined #openstack-neutron | 18:53 | |
| *** Marga_ has quit IRC | 18:53 | |
| *** Miouge has quit IRC | 18:54 | |
| *** reed has joined #openstack-neutron | 18:54 | |
| *** SridharRamaswamy has joined #openstack-neutron | 18:55 | |
| *** Marga_ has joined #openstack-neutron | 18:55 | |
| *** jprovazn has joined #openstack-neutron | 18:57 | |
| *** markvoelker has quit IRC | 18:58 | |
| *** annegentle has quit IRC | 19:01 | |
| *** markvoelker has joined #openstack-neutron | 19:01 | |
| *** tflynn has joined #openstack-neutron | 19:02 | |
| *** SridharRamaswam1 has joined #openstack-neutron | 19:03 | |
| *** SridharRamaswamy has quit IRC | 19:04 | |
| *** tflynn has quit IRC | 19:06 | |
| *** manishg_ has quit IRC | 19:06 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: WIP: Mock RPC _send method https://review.openstack.org/159955 | 19:08 |
| *** radez has quit IRC | 19:11 | |
| *** SridharRamaswam1 has quit IRC | 19:12 | |
| *** bquan has joined #openstack-neutron | 19:13 | |
| openstackgerrit | Darragh O'Reilly proposed openstack/neutron: lb-agent: handle security group updates in main loop https://review.openstack.org/138512 | 19:13 |
| *** aix has quit IRC | 19:13 | |
| *** SridharRamaswamy has joined #openstack-neutron | 19:14 | |
| openstackgerrit | Terry Wilson proposed openstack/neutron: Add rootwrap daemon mode support https://review.openstack.org/158805 | 19:14 |
| pc_m | carl_baldwin: ping | 19:17 |
| carl_baldwin | pc_m: pong | 19:18 |
| pc_m | carl_baldwin: Wanted to talk about refactoring of the VPN code for L3. Wondering when we could get together to discuss? | 19:18 |
| pc_m | Have a few questions. | 19:18 |
| *** tflynn has joined #openstack-neutron | 19:19 | |
| *** jckasper__ has quit IRC | 19:19 | |
| *** _cjones_ has quit IRC | 19:20 | |
| carl_baldwin | I could discuss a bit here. | 19:21 |
| *** bquan has quit IRC | 19:21 | |
| pc_m | thanks. | 19:21 |
| *** csoukup has quit IRC | 19:22 | |
| pc_m | currently, the VPN device driver has several methods that (currently) call the vpn_service object, which in turn talks to the L3 agent to get the router_info for a specific router by ID. | 19:22 |
| flwang1 | ihrachyshka: ping? I think you're around :) | 19:22 |
| pc_m | Wondering, how can be get the router_info forward going? I don't see a method that gives a router based on router_id. Is there one? | 19:23 |
| *** _cjones_ has joined #openstack-neutron | 19:23 | |
| *** openstackgerrit has quit IRC | 19:24 | |
| *** openstackgerrit has joined #openstack-neutron | 19:24 | |
| *** bo-quan has quit IRC | 19:24 | |
| *** ajo has quit IRC | 19:25 | |
| amuller | pc_m: you look it up in the agenr routers dict | 19:26 |
| amuller | agent* | 19:26 |
| *** ihrachyshka has quit IRC | 19:26 | |
| *** tflynn has quit IRC | 19:26 | |
| pc_m | amuller: We've been trying to decouple the agent from the device driver. | 19:26 |
| *** csoukup has joined #openstack-neutron | 19:26 | |
| amuller | ok I don't have the full context, just rambling | 19:27 |
| pc_m | previously, the device driver had a reference to the agent. Refactoring goal was to separate that dependency. | 19:27 |
| *** ajo has joined #openstack-neutron | 19:27 | |
| pc_m | so the vpn_service object was created, so that the device driver only knew about it's "service" object.. | 19:28 |
| pc_m | carl_baldwin: Ref: https://github.com/openstack/neutron-vpnaas/blob/master/neutron_vpnaas/services/vpn/vpn_service.py#L111 | 19:28 |
| pc_m | That's a case where the service object goes to the L3 agent, which has a dict of routers. | 19:28 |
| *** yamamoto has joined #openstack-neutron | 19:33 | |
| carl_baldwin | pc_m: hi, I was just looking through code. | 19:33 |
| carl_baldwin | pc_m: Take a look at this example: https://github.com/openstack/neutron-vpnaas/blob/master/neutron_vpnaas/services/vpn/vpn_service.py#L61 | 19:33 |
| carl_baldwin | after_router_added passes in the router instance. Then, this code passes only the router_id to device.create_router(…) | 19:34 |
| *** radez has joined #openstack-neutron | 19:35 | |
| pc_m | Yeah, I had only two ideas... one was to somehow look up the router via ID (maybe can't). The other is to change the create and pass down a router_info, instead of the id (and save it) | 19:35 |
| *** rotbart has joined #openstack-neutron | 19:36 | |
| carl_baldwin | Then, create_router in a round-about way calls self.agent.remove_nat_rule which uses the router_id to look up the instance. But, the service was already passed the router instance to begin with. | 19:36 |
| pc_m | Not sure (yet) of the impact of the latter. | 19:36 |
| *** fifieldt_ has joined #openstack-neutron | 19:36 | |
| carl_baldwin | We can look up the router by id. That wouldn’t take much code. But, the service is passed the router instance. It shouldn’t need to look it up. | 19:37 |
| *** yamamoto has quit IRC | 19:37 | |
| *** manishg has joined #openstack-neutron | 19:38 | |
| pc_m | carl_baldwin: I need to look at the impact of that change. | 19:38 |
| pc_m | carl_baldwin: A lookup doesn't change the logic. | 19:38 |
| pc_m | Currently, when a router is created. Nothing is done in VPN. When the VPN connection is created, then the driver creates the OpenSwan process and saves away the VPN info (and router ID). | 19:40 |
| *** fifieldt has quit IRC | 19:40 | |
| *** aranjan has joined #openstack-neutron | 19:40 | |
| *** annegentle has joined #openstack-neutron | 19:40 | |
| *** VijayB has quit IRC | 19:41 | |
| *** leenheer has quit IRC | 19:41 | |
| pc_m | I'll have to look it through... some things I think would change are... would have to create the OpenSwan object, but defer the process create until VPN connection created; test for router in use, would have to check for process running vs existence of OpenSwan object. | 19:42 |
| *** leenheer has joined #openstack-neutron | 19:42 | |
| pc_m | Seems doable... let me look through and figure out the details to see what that would take. | 19:43 |
| pc_m | It would be better than doing lookups, I would think. | 19:43 |
| *** shwetaap1 has joined #openstack-neutron | 19:44 | |
| *** crose has quit IRC | 19:44 | |
| *** aranjan has quit IRC | 19:44 | |
| *** doude has quit IRC | 19:44 | |
| carl_baldwin | pc_m: There could be more ugly details under the hood that I’m not aware of. But, I think if it were me, I would chase down the option that removes the need for redundant lookups by id first. | 19:46 |
| *** Miouge has joined #openstack-neutron | 19:46 | |
| *** shwetaap has quit IRC | 19:46 | |
| *** doude has joined #openstack-neutron | 19:47 | |
| pc_m | carl_baldwin: Yeah seems cleaner. Just need to see how much that alters the design for effort. | 19:47 |
| carl_baldwin | pc_m: understood. | 19:47 |
| *** barra204 has joined #openstack-neutron | 19:48 | |
| openstackgerrit | Isaku Yamahata proposed openstack/neutron: ml2: use attributes.{NETWORK, SUBNET, PORT} consistently https://review.openstack.org/159966 | 19:48 |
| pc_m | carl_baldwin: Just for my education, how does one look up by router_id? | 19:48 |
| carl_baldwin | pc_m: Adding a lookup would be very easy. I think it would really just be adding a method to the agent that does what amuller described above. | 19:48 |
| pc_m | carl_baldwin: So rely on the L3 agent. | 19:49 |
| amuller | that information isn't saved anywhere else | 19:49 |
| pc_m | ? | 19:49 |
| amuller | unless you have a reference to a router, the only place routers are saved is in l3_agent.router_info | 19:49 |
| pc_m | It just maintains the coupling between driver and L3 agent. | 19:49 |
| carl_baldwin | pc_m: if it came down to it. But, I would still like to see the other way work because I it will result in a nicer overall design for the long-term. | 19:49 |
| pc_m | carl_baldwin: +1 | 19:50 |
| *** tomoe_ has joined #openstack-neutron | 19:51 | |
| pc_m | carl_baldwin: I'm thinking, if we can remove the coupling, and if Armando's callback mechanism can be used (not sure if that'll cause another singleton issue), then the only the adv service stuff does is loading device drivers. Maybe that could be done elsewhere. | 19:51 |
| *** ajo has quit IRC | 19:51 | |
| *** Marga_ has quit IRC | 19:52 | |
| *** rm_work|away is now known as rm_work | 19:52 | |
| *** Marga_ has joined #openstack-neutron | 19:52 | |
| *** Marga_ has quit IRC | 19:53 | |
| *** achanda has quit IRC | 19:53 | |
| pc_m | carl_baldwin: amuller: Thanks for the ideas/feedback. I'll start looking at the code. Will have a lot to do to get this in. | 19:54 |
| *** moha_hunt has quit IRC | 19:54 | |
| *** ajo has joined #openstack-neutron | 19:54 | |
| amuller | marun: carl_baldwin: I think grenade has a 100% or near 100% failure rate since this morning? | 19:54 |
| amuller | (it's voting) | 19:54 |
| *** mikeit has joined #openstack-neutron | 19:55 | |
| *** tomoe_ has quit IRC | 19:55 | |
| *** barra204 is now known as shakamunyi | 19:56 | |
| *** marun has quit IRC | 19:57 | |
| *** apuimedo has joined #openstack-neutron | 19:57 | |
| *** jckasper has joined #openstack-neutron | 19:58 | |
| *** pradip_vedams has quit IRC | 20:00 | |
| *** pradip_vedams has joined #openstack-neutron | 20:00 | |
| amuller | here's one error in a recent grenade run: | 20:01 |
| amuller | http://logs.openstack.org/17/124917/30/check/check-grenade-dsvm-neutron/77a84b2/logs/grenade.sh.txt.gz | 20:01 |
| amuller | 14be42f3d0a5_default_sec_group_table_py.DuplicateSecurityGroupsNamedDefault: Some tenants have more than one security group named 'default': tenant 06f26c6bb8fb47adbdbb3daa94fb2118: 48634d33-9553-4136-bb71-e9c2da1af5bc, 9006a6f4-f3ed-422a-97e9-206104103cfb. All duplicate 'default' security groups must be resolved before upgrading the database. | 20:01 |
| amuller | looks familiar :) | 20:01 |
| openstackgerrit | Merged openstack/neutron: wsgi: remove explicit monkey_patch() call https://review.openstack.org/157453 | 20:01 |
| *** marun has joined #openstack-neutron | 20:02 | |
| *** ChuckC has quit IRC | 20:02 | |
| *** ZZelle has joined #openstack-neutron | 20:02 | |
| *** ajo has quit IRC | 20:03 | |
| *** ChuckC has joined #openstack-neutron | 20:03 | |
| openstackgerrit | Zengfa Gao proposed openstack/python-neutronclient: Add Neutron subnetpool API https://review.openstack.org/159618 | 20:05 |
| amuller | marun: ok it's not near 100% failure though | 20:05 |
| *** VijayB_ has joined #openstack-neutron | 20:05 | |
| *** ajo has joined #openstack-neutron | 20:06 | |
| mlavalle | carl_baldwin: pong | 20:06 |
| carl_baldwin | mlavalle: hi | 20:07 |
| openstackgerrit | Merged openstack/neutron-vpnaas: Add test case for the 'Peer ID gets additional "@"' fix https://review.openstack.org/158074 | 20:07 |
| *** leenheer has quit IRC | 20:07 | |
| *** rotbart has quit IRC | 20:07 | |
| *** annegentle has quit IRC | 20:07 | |
| *** markvoelker has quit IRC | 20:08 | |
| *** annegentle has joined #openstack-neutron | 20:08 | |
| openstackgerrit | Merged openstack/neutron-fwaas: Migrate to oslo.log https://review.openstack.org/159891 | 20:08 |
| pc_m | marun: Is this review ready to come out of WIP? https://review.openstack.org/#/c/154213/ The dependency is upstreamed. Didn't know if there was another dependency (that should be added for this commit). | 20:08 |
| openstackgerrit | Timothy Swanson proposed openstack/neutron-specs: MTU selection spec update bridge_mappings new format https://review.openstack.org/159146 | 20:10 |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Mock RPC _send method in BaseTestCase https://review.openstack.org/159955 | 20:12 |
| *** markvoelker_ has joined #openstack-neutron | 20:12 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Mock RPC _send method in BaseTestCase https://review.openstack.org/159955 | 20:12 |
| *** ajo has quit IRC | 20:15 | |
| *** markvoelker_ has quit IRC | 20:16 | |
| mlavalle | carl_baldwin: I was respinding to a previous ping from you | 20:19 |
| *** ajo has joined #openstack-neutron | 20:19 | |
| carl_baldwin | mlavalle: Right, I got distracted, sorry about that. | 20:20 |
| mlavalle | carl_baldwin: np | 20:20 |
| carl_baldwin | mlavalle: was wondering if you’d noticed I rebased your patch. | 20:20 |
| carl_baldwin | Resolved a simple conflict. | 20:21 |
| mlavalle | carl_baldwin: I did, thanks. Not a big deal | 20:21 |
| carl_baldwin | mlavalle: I also was wondering if we could get it in shape to merge this week-end so that I could try to get it in over the week-end. | 20:21 |
| mlavalle | carl_baldwin: that is my plan | 20:22 |
| carl_baldwin | mlavalle: do you need any help? | 20:22 |
| mlavalle | carl_baldwin: not at this point | 20:22 |
| mlavalle | carl_baldwin: if I get stuck, are you going to be on irc. If not, I can email you | 20:22 |
| *** achanda has joined #openstack-neutron | 20:23 | |
| carl_baldwin | I’ll try to be on IRC as much as possible. I’ll be on for the next three to four hours at least. | 20:23 |
| *** jprovazn has quit IRC | 20:24 | |
| amuller | carl_baldwin: marun: https://review.openstack.org/#/c/158097/ | 20:24 |
| amuller | should be mergable today | 20:24 |
| *** bquan has joined #openstack-neutron | 20:24 | |
| amuller | I'd appreciate if you could take a look at the next patch in the series | 20:24 |
| mlavalle | carl_baldwin: tomorrow and sunday I will be on irc.... not necessarilly stuck to it. You can ping me if you want and I'll get back to you eventually | 20:25 |
| carl_baldwin | amuller: ack | 20:25 |
| *** banix has quit IRC | 20:25 | |
| amuller | carl_baldwin: I'd be happy to discuss bp/report-ha-router-master if you'd like context / a high overview of the design of the feature | 20:25 |
| *** jkraj has quit IRC | 20:25 | |
| carl_baldwin | amuller: I remember the bp actually pretty well. | 20:26 |
| amuller | alrighty :) | 20:26 |
| carl_baldwin | amuller: It is failing grenade. So, no go. | 20:27 |
| *** tflynn has joined #openstack-neutron | 20:27 | |
| * carl_baldwin just kidding | 20:27 | |
| amuller | :( | 20:27 |
| amuller | looks like an unrelated failure, one of many grenade failures | 20:27 |
| carl_baldwin | amuller: ;) | 20:27 |
| *** mikeit has quit IRC | 20:29 | |
| *** achanda has quit IRC | 20:30 | |
| *** csoukup has quit IRC | 20:30 | |
| *** ChuckC has quit IRC | 20:31 | |
| *** tflynn has quit IRC | 20:32 | |
| *** ChuckC has joined #openstack-neutron | 20:32 | |
| *** _cjones_ has quit IRC | 20:34 | |
| *** csoukup has joined #openstack-neutron | 20:34 | |
| *** vishwanathj has joined #openstack-neutron | 20:34 | |
| *** _cjones_ has joined #openstack-neutron | 20:34 | |
| mestery | carl_baldwin: CAn you pop into #openstack-qa? We're looking a DB deadlock there that is floating IP / L3 related | 20:34 |
| mestery | carl_baldwin: lets move it here | 20:34 |
| *** mriedem has joined #openstack-neutron | 20:35 | |
| mestery | amuller carl_baldwin: https://bugs.launchpad.net/neutron/+bug/1426543 | 20:35 |
| openstack | Launchpad bug 1426543 in OpenStack Compute (nova) "Spike in neutronclient connection failures due to read timeouts since 2/27" [Undecided,New] | 20:35 |
| *** vishwanathj has quit IRC | 20:35 | |
| mestery | Also: http://logs.openstack.org/40/122240/19/gate/gate-tempest-dsvm-neutron-full/4ef0a02/logs/screen-q-svc.txt.gz?level=TRACE | 20:35 |
| amuller | joining | 20:35 |
| *** leenheer has joined #openstack-neutron | 20:35 | |
| mestery | Sorry, it was #openstack-nova, but we can move it here. | 20:35 |
| mestery | amuller: Looks like a DB timeout | 20:35 |
| mestery | Floating IP related, spiked in the last 24 hours. | 20:36 |
| mestery | mriedem: ^^^^ | 20:36 |
| mriedem | http://logs.openstack.org/40/122240/19/gate/gate-tempest-dsvm-neutron-full/4ef0a02/logs/screen-q-svc.txt.gz?level=TRACE#_2015-02-27_18_05_43_389 | 20:36 |
| *** _cjones_ has quit IRC | 20:36 | |
| carl_baldwin | mestery: armax mentioned this one to me just a little while ago. | 20:36 |
| *** _cjones_ has joined #openstack-neutron | 20:36 | |
| mriedem | https://github.com/openstack/neutron/commit/911f8b57f80798ec8fe3c82282fb4c812cc9472c ? | 20:36 |
| mestery | carl_baldwin: armax is still awake? :) | 20:36 |
| carl_baldwin | mestery: Probably not anymore. | 20:36 |
| mestery | carl_baldwin: Heh :) | 20:36 |
| *** pradip_rawat has joined #openstack-neutron | 20:37 | |
| *** leenheer has quit IRC | 20:37 | |
| amuller | it's timing out when it receives a floating IP status updated from a L3 agent | 20:37 |
| * amuller looking at recently merged patches | 20:38 | |
| mriedem | amuller: so maybe https://github.com/openstack/neutron/commit/911f8b57f80798ec8fe3c82282fb4c812cc9472c caused this? | 20:38 |
| amuller | that patch is definitely unrelated | 20:38 |
| mriedem | given when that merged and this showed up http://goo.gl/h7y4MD | 20:38 |
| *** markvoelker has joined #openstack-neutron | 20:39 | |
| *** pradip_vedams has quit IRC | 20:39 | |
| *** pradip_rawat is now known as pradip_vedams | 20:39 | |
| *** melwitt has joined #openstack-neutron | 20:41 | |
| carl_baldwin | amuller: mriedem: mestery: The only patch to hit this before today was 143865 and it hit it repeatedly. It must be it. | 20:43 |
| carl_baldwin | I’m willing to call this a smoking gun. | 20:44 |
| carl_baldwin | amuller: mestery: What do you think? | 20:44 |
| mestery | carl_baldwin: Ack on that | 20:44 |
| amuller | Armando already has a revert up for review, let's run rechecks on that... | 20:44 |
| mestery | amuller: Link? | 20:44 |
| amuller | https://review.openstack.org/#/c/159939/ | 20:44 |
| carl_baldwin | amuller: I’m babysitting that patch. | 20:45 |
| *** mikeit has joined #openstack-neutron | 20:45 | |
| mestery | thanks amuller | 20:45 |
| mestery | mriedem: ^^^^ | 20:45 |
| *** markvoelker has quit IRC | 20:45 | |
| mriedem | mestery: yup | 20:45 |
| *** leenheer has joined #openstack-neutron | 20:45 | |
| mriedem | need the revert tagged to the bug | 20:45 |
| mestery | mriedem: Just did it | 20:46 |
| mestery | In LP | 20:46 |
| mestery | mriedem: In the commit message of the revert? | 20:46 |
| mriedem | yeah | 20:46 |
| mriedem | so if that gets merged it closes the bug | 20:46 |
| mestery | carl_baldwin: I can re-propose armax's revert with that added. | 20:46 |
| mestery | carl_baldwin: Shall I do it now? | 20:46 |
| carl_baldwin | mestery: If you’ve got it loaded, go for it. | 20:47 |
| mestery | carl_baldwin: Doing it now | 20:47 |
| amuller | this doesn't make sense though | 20:47 |
| amuller | I don't see how that patch is related | 20:47 |
| mriedem | hmm, there was an oslo.db release yesterday... | 20:47 |
| openstackgerrit | Kyle Mestery proposed openstack/neutron: Revert "Remove port from ovsdb after its deletion" https://review.openstack.org/159939 | 20:48 |
| amuller | that's right | 20:48 |
| mriedem | checking the git log of oslo.db | 20:48 |
| mriedem | http://paste.openstack.org/show/183153/ | 20:49 |
| mriedem | bam 1b7c295 | 20:50 |
| *** VijayB_ has quit IRC | 20:50 | |
| carl_baldwin | amuller: I have no idea how it is related. But, the evidence is pretty clear. The patch was the *only* one to hit the error before it merged. It hit the error 6 times before merge. | 20:50 |
| mriedem | 1b7c295 Retry query if db deadlock error is received | 20:50 |
| *** mikeit has quit IRC | 20:50 | |
| mriedem | carl_baldwin: could be a red herring given when oslo.db was released | 20:50 |
| mriedem | or this: | 20:51 |
| mriedem | eeb7ea2 Add retry decorator allowing to retry DB operations on request | 20:51 |
| amuller | that second patch is unsed in neutron | 20:51 |
| amuller | for now | 20:51 |
| amuller | the retry decorator | 20:51 |
| mriedem | unused | 20:51 |
| mriedem | ok | 20:51 |
| mriedem | so let's look at the other | 20:51 |
| carl_baldwin | amuller: It could just be that the patch just exposes some other problem that has existed. | 20:51 |
| *** markvoelker has joined #openstack-neutron | 20:52 | |
| openstackgerrit | Assaf Muller proposed openstack/neutron: Pin to Oslo DB 1.4.1 https://review.openstack.org/159997 | 20:53 |
| carl_baldwin | mriedem: mestery: Do you know how much we’re hitting this bug overall? | 20:54 |
| mestery | amuller: Good idea on the pinning patch | 20:54 |
| mriedem | carl_baldwin: 76% failure when this hits | 20:54 |
| mriedem | for the dbdeadlock in neutron logs - the neutronclient read timeout in the n-cpu logs is like 94% failure when that hits | 20:55 |
| mriedem | not sure why they wouldn't correlate better | 20:55 |
| mriedem | well, i suppose b/c of a db retry | 20:55 |
| mriedem | on deadlock | 20:55 |
| *** apuimedo has quit IRC | 20:55 | |
| mtreinish | mriedem: I still argue we probably should not be logging a raw DB error if it's inside of a retry loop | 20:56 |
| mriedem | mtreinish: was in the process of looking that up prior to the ping storm :) | 20:56 |
| openstackgerrit | Timothy Swanson proposed openstack/neutron-specs: MTU selection spec update bridge_mappings new format https://review.openstack.org/159146 | 20:57 |
| *** karimb has joined #openstack-neutron | 20:57 | |
| haleyb | carl_baldwin: I have a backtrace of this error also coming from the l3-agent | 20:57 |
| *** tsg has quit IRC | 20:57 | |
| amuller | haleyb: yeah if it errors out on the controller you'd get the same error in the agent | 20:58 |
| *** tsg has joined #openstack-neutron | 20:58 | |
| mlavalle | carl_baldwin: you seem to be busy now. When you get a chance, please ping me. I have a question. Nothing urgent or really important | 20:58 |
| *** SridharG has quit IRC | 20:58 | |
| haleyb | update_floatingip_statuses() was the call | 20:58 |
| *** karimb has quit IRC | 20:59 | |
| *** karimb has joined #openstack-neutron | 20:59 | |
| mriedem | haleyb: yes same here | 20:59 |
| carl_baldwin | mlavalle: ping | 20:59 |
| mriedem | mtreinish: i'm not finding the retry decorator in neutron | 20:59 |
| *** SridharG has joined #openstack-neutron | 20:59 | |
| *** tsg_ has joined #openstack-neutron | 21:00 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Transform Base(OVS)LinuxTestCase methods in helpers https://review.openstack.org/159852 | 21:00 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Simplify prepare_veth_pairs in functional tests https://review.openstack.org/160000 | 21:00 |
| mlavalle | carl_baldwin: that was fast :-).... In https://review.openstack.org/#/c/147744/26/neutron/agent/l3/agent.py, line 67 in the new patch, does the comment mean it should be self.conf.agent_mode == l3_constants.L3_AGENT_MODE_DVR_SNAT? | 21:00 |
| mtreinish | mriedem: hmm, that's weird we shouldn't be issuing a fatal error like that an having a successful run | 21:00 |
| *** ronis_ has quit IRC | 21:02 | |
| carl_baldwin | mlavalle: 670? Yes, it should use the constant like the old version does. Basically, just revert the change on those two lines. | 21:02 |
| *** SridharG has left #openstack-neutron | 21:03 | |
| *** tsg has quit IRC | 21:03 | |
| *** achanda has joined #openstack-neutron | 21:03 | |
| mlavalle | carl_baldwin: cool. I agree with all the other comments. Seem to be pretty straightforward | 21:04 |
| carl_baldwin | mlavalle: Yeah, nothing too crazy in there. I think it is pretty close. | 21:05 |
| mriedem | mtreinish: not sure i guess, i don't see retry_on_deadlock used anywhere in neutron | 21:05 |
| *** VijayB has joined #openstack-neutron | 21:05 | |
| *** achanda has quit IRC | 21:05 | |
| mriedem | mtreinish: nova has it's own retry_on_deadlock decorator | 21:06 |
| *** ajo has quit IRC | 21:06 | |
| *** marun has quit IRC | 21:06 | |
| *** nlahouti has quit IRC | 21:06 | |
| mlavalle | carl_baldwin: I especially liked your comment about adding a method to the namespace manager class. That way, the behavior is completly encapsulated :-) | 21:06 |
| carl_baldwin | mlavalle: :) | 21:07 |
| *** leenheer has quit IRC | 21:09 | |
| *** shwetaap has joined #openstack-neutron | 21:10 | |
| *** achanda has joined #openstack-neutron | 21:10 | |
| *** jckasper has quit IRC | 21:10 | |
| *** apuimedo has joined #openstack-neutron | 21:11 | |
| *** raildo has quit IRC | 21:11 | |
| *** shwetaap1 has quit IRC | 21:13 | |
| *** thedodd has joined #openstack-neutron | 21:14 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Transform Base(OVS)LinuxTestCase methods in helpers https://review.openstack.org/159852 | 21:18 |
| *** jckasper has joined #openstack-neutron | 21:19 | |
| *** Miouge has quit IRC | 21:20 | |
| *** jckasper_ has joined #openstack-neutron | 21:22 | |
| mtreinish | mriedem: I've quickly traced through the code and I haven't found anything in neutron which would cause that to not be fatal | 21:22 |
| mtreinish | my only thought now is that oslo messaging is handling it somehow | 21:23 |
| *** vivek-ebay has joined #openstack-neutron | 21:23 | |
| *** jckasper_ has quit IRC | 21:25 | |
| *** jckasper_ has joined #openstack-neutron | 21:25 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Simplify prepare_veth_pairs in functional tests https://review.openstack.org/160000 | 21:26 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Transform Base(OVS)LinuxTestCase methods in helpers https://review.openstack.org/159852 | 21:26 |
| *** jckasper has quit IRC | 21:26 | |
| *** Miouge has joined #openstack-neutron | 21:27 | |
| *** tflynn has joined #openstack-neutron | 21:27 | |
| *** sambetts has quit IRC | 21:28 | |
| openstackgerrit | Timothy Swanson proposed openstack/neutron-specs: MTU selection spec update bridge_mappings new format https://review.openstack.org/159146 | 21:28 |
| *** jckasper has joined #openstack-neutron | 21:28 | |
| *** nlahouti has joined #openstack-neutron | 21:30 | |
| *** sambetts has joined #openstack-neutron | 21:30 | |
| *** baoli has quit IRC | 21:31 | |
| *** tflynn has quit IRC | 21:31 | |
| *** jckasper_ has quit IRC | 21:32 | |
| *** marun has joined #openstack-neutron | 21:34 | |
| *** yamamoto has joined #openstack-neutron | 21:35 | |
| *** yamamoto has quit IRC | 21:39 | |
| *** baoli has joined #openstack-neutron | 21:39 | |
| *** SridharGaddam has quit IRC | 21:40 | |
| *** SridharG has joined #openstack-neutron | 21:41 | |
| *** achanda has quit IRC | 21:43 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Transform Base(OVS)LinuxTestCase methods in helpers https://review.openstack.org/159852 | 21:44 |
| *** achanda has joined #openstack-neutron | 21:44 | |
| *** yeungp has quit IRC | 21:46 | |
| *** shwetaap has quit IRC | 21:46 | |
| *** dboik_ has joined #openstack-neutron | 21:46 | |
| *** tiswanso_ has joined #openstack-neutron | 21:46 | |
| *** mriedem has left #openstack-neutron | 21:46 | |
| *** yeungp has joined #openstack-neutron | 21:46 | |
| ZZelle | marun, hi | 21:46 |
| marun | ZZelle: hi | 21:46 |
| *** sbfox has quit IRC | 21:46 | |
| ZZelle | why setUpClass is not working? iirc tempest is using it | 21:47 |
| marun | ZZelle: tempest should not be using it, but nobody has gone to the trouble of fixing | 21:47 |
| marun | ZZelle: it's another accident of history | 21:47 |
| *** shwetaap has joined #openstack-neutron | 21:47 | |
| marun | ZZelle: for setup that spans tests, fixtures are the way to go | 21:47 |
| ZZelle | marun, could you clarify? | 21:48 |
| *** dboik has quit IRC | 21:48 | |
| marun | ZZelle: You'll have to ask lifeless for specifics, I keep forgetting them. | 21:48 |
| marun | ZZelle: I think maybe it has something to do with concurrent execution? | 21:49 |
| *** prad has quit IRC | 21:49 | |
| *** dane_leblanc has quit IRC | 21:49 | |
| marun | ZZelle: i.e. how testr runs jobs in parallel | 21:49 |
| *** tiswanso has quit IRC | 21:50 | |
| ZZelle | marun, ok, so i move the check to setUp | 21:50 |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Check whether sudo is enabled in BaseSudoTestCase.setUpClass https://review.openstack.org/159193 | 21:51 |
| *** lukasa has quit IRC | 21:51 | |
| *** radez is now known as radez_g0n3 | 21:51 | |
| *** tiswanso_ has quit IRC | 21:51 | |
| marun | ZZelle: thanks! | 21:51 |
| *** ajo has joined #openstack-neutron | 21:52 | |
| marun | ZZelle: feel free to follow up with lifeless for details. We should probably add detail to TESTING.rst | 21:52 |
| ZZelle | marun, now the change has children! https://review.openstack.org/#/q/topic:functional-test-network-helpers,n,z | 21:53 |
| *** dims_ is now known as dimsum__ | 21:53 | |
| ZZelle | marun, do you have any idea why when a veth is bound to a namespace the namespace delete also deletes the veth? | 21:55 |
| *** leenheer has joined #openstack-neutron | 21:57 | |
| *** leenheer has quit IRC | 21:57 | |
| *** leenheer has joined #openstack-neutron | 21:58 | |
| *** dane_leblanc has joined #openstack-neutron | 21:58 | |
| *** leenheer1 has joined #openstack-neutron | 22:00 | |
| *** leenheer has quit IRC | 22:00 | |
| *** yeungp has quit IRC | 22:03 | |
| *** barra204_ has joined #openstack-neutron | 22:03 | |
| *** shakamunyi has quit IRC | 22:03 | |
| *** chuckC_ has joined #openstack-neutron | 22:06 | |
| *** barra204_ has quit IRC | 22:07 | |
| *** rpothier has quit IRC | 22:07 | |
| *** SridharG has quit IRC | 22:08 | |
| *** barra204_ has joined #openstack-neutron | 22:08 | |
| *** annegentle has quit IRC | 22:10 | |
| *** annegentle has joined #openstack-neutron | 22:11 | |
| *** karimb has quit IRC | 22:15 | |
| *** johnbelamaric1 has quit IRC | 22:15 | |
| openstackgerrit | Cedric Brandily proposed openstack/neutron: Check whether sudo is enabled in BaseSudoTestCase.setUpClass https://review.openstack.org/159193 | 22:17 |
| *** tim_o_ has quit IRC | 22:20 | |
| *** jpena has quit IRC | 22:20 | |
| *** thedodd has quit IRC | 22:21 | |
| *** jamielennox is now known as jamielennox|away | 22:23 | |
| *** TrevorV_ has joined #openstack-neutron | 22:24 | |
| *** leenheer1 has quit IRC | 22:27 | |
| *** pradip_rawat has joined #openstack-neutron | 22:27 | |
| *** TrevorV_ has quit IRC | 22:28 | |
| *** leenheer has joined #openstack-neutron | 22:29 | |
| *** jamielennox|away is now known as jamielennox | 22:30 | |
| *** pradip_vedams has quit IRC | 22:30 | |
| *** pradip_rawat_ has joined #openstack-neutron | 22:30 | |
| *** pradip_rawat_ is now known as pradip_vedams | 22:30 | |
| *** pc_m has quit IRC | 22:31 | |
| *** leenheer has quit IRC | 22:32 | |
| *** pradip_rawat has quit IRC | 22:34 | |
| *** leenheer has joined #openstack-neutron | 22:36 | |
| *** _cjones_ has quit IRC | 22:36 | |
| *** _cjones_ has joined #openstack-neutron | 22:38 | |
| openstackgerrit | Matthew Thode proposed openstack/neutron: replaces enumeration method used to get a list of interfaces https://review.openstack.org/154128 | 22:38 |
| kbringard | anyone have any thoughts on why this wasn't merged? https://review.openstack.org/#/c/157169/ | 22:38 |
| kbringard | it's got 2 +2s, was just wondering if there's something else I need to do, or just hang out and wait | 22:38 |
| *** jamielennox is now known as jamielennox|away | 22:39 | |
| *** rushil has quit IRC | 22:40 | |
| *** jamielennox|away is now known as jamielennox | 22:40 | |
| otherwiseguy | ZZelle: the addl_env is used in one place and it isn't with rootwrap because it *doesn't* have a use with rootwrap because sudo will strip the additional environment variables that are added. | 22:41 |
| mestery | kbringard: +A | 22:41 |
| *** chuckC_ has quit IRC | 22:41 | |
| kbringard | thanks mestery | 22:41 |
| ZZelle | otherwiseguy, so i would add an assert not (run_as_root and addl_env) | 22:42 |
| kbringard | being a mac user that was annoying to me :-D | 22:42 |
| *** ajo has quit IRC | 22:42 | |
| otherwiseguy | ZZelle: sounds reasonable to me. | 22:42 |
| ZZelle | otherwiseguy, it ensures it never appends during functional/tempests tests with daemon/legacy rootwrap | 22:43 |
| haleyb | kbringard: i actually have another patch that completely removes that code, but it hasn't merged yet | 22:43 |
| kbringard | haleyb: ah so | 22:43 |
| kbringard | well, maybe we can backport that too then, heh | 22:43 |
| kevinbenton | carl_baldwin: ping | 22:43 |
| kbringard | :-D | 22:44 |
| carl_baldwin | kevinbenton: pong | 22:44 |
| kevinbenton | deadlock | 22:44 |
| *** TrevorV_ has joined #openstack-neutron | 22:44 | |
| kevinbenton | i hear it's in style again :) | 22:44 |
| *** Zemeio has quit IRC | 22:44 | |
| kevinbenton | carl_baldwin: i think i've found the issue | 22:44 |
| carl_baldwin | kevinbenton: It is in something. | 22:44 |
| *** TrevorV_ has quit IRC | 22:44 | |
| haleyb | kbringard: it's a much bigger, messier change, that i wouldn't backport, https://review.openstack.org/#/c/157555/ | 22:44 |
| *** Miouge has quit IRC | 22:44 | |
| kevinbenton | carl_baldwin: _delete_floatingip starts a transaction and then calls core_plugin.delete_port | 22:45 |
| otherwiseguy | ZZelle: on the TODO vs NOTE thing, I used to have it as a TODO, but the original author didn't think oslo_rootwrap should convert the exceptions to return codes like the non-daemon mode did. And there is an argument to be made that we should throw an exception in this case because it is something that will never fix itself and *has* to be addressed by the admin to function correctly. That's why I put it as a | 22:45 |
| otherwiseguy | NOTE--just making sure people understand what's going on/that there is a difference. | 22:45 |
| kevinbenton | carl_baldwin: i think the recent notification change just changed the eventlet yield timing to expose it | 22:45 |
| kbringard | haleyb: ah so, in that case glad we didn't wait on it :-D | 22:45 |
| *** SridharRamaswamy has quit IRC | 22:46 | |
| carl_baldwin | kevinbenton: I thought maybe that patch just tickled something that was already there. | 22:46 |
| kevinbenton | carl_baldwin: right, an extra notification to trigger an extra yield | 22:46 |
| otherwiseguy | ZZelle: Though I'm pretty sure the env=None -> env = {} thing is a bug. | 22:47 |
| otherwiseguy | (in oslo_rootwrap) | 22:47 |
| kevinbenton | carl_baldwin: i can see that the deadlock happens when a floating ip is being deleted | 22:47 |
| ZZelle | otherwiseguy, it seems logic to have different behavior as oslo-rootwrap is a binary returning status code where daemon rootwrap is pure-python | 22:47 |
| kevinbenton | carl_baldwin: http://logs.openstack.org/97/158097/8/check/check-grenade-dsvm-neutron/4a60111/logs/new/screen-q-svc.txt.gz#_2015-02-27_21_27_53_549 | 22:48 |
| *** shwetaap has quit IRC | 22:48 | |
| ZZelle | but we should normalize things (in neutron or oslo.rootwrap) | 22:48 |
| kevinbenton | carl_baldwin: note that it took 52.26 seconds to fulfill that http request | 22:48 |
| kevinbenton | carl_baldwin: that indicates that that process was holding the lock | 22:48 |
| ZZelle | as some caller allows nonzero code as valid codes | 22:48 |
| kevinbenton | carl_baldwin: while the other one with the exception was the unlucky one that failed | 22:48 |
| *** ijw has quit IRC | 22:50 | |
| *** pradip_rawat has joined #openstack-neutron | 22:52 | |
| * carl_baldwin looking... | 22:52 | |
| kevinbenton | carl_baldwin: i have a fix that i want you to take a look at in a couple minutes here | 22:54 |
| *** pradip_rawat has quit IRC | 22:54 | |
| *** pradip_vedams has quit IRC | 22:54 | |
| carl_baldwin | kevinbenton: I’d be happy to. | 22:54 |
| *** annegentle has quit IRC | 22:56 | |
| *** pradip_rawat has joined #openstack-neutron | 22:56 | |
| *** pradip_rawat is now known as pradip_vedams | 22:56 | |
| *** hichtakk has joined #openstack-neutron | 22:57 | |
| *** barra204_ has quit IRC | 22:57 | |
| haleyb | I looked through the jenkins logs that were still there for that review, https://review.openstack.org/#/c/116924/ and didn't see any deadlock messages fwiw. So maybe the recent oslo_db change did tickle the code just so | 22:57 |
| *** spandhe has quit IRC | 22:58 | |
| *** manishg has quit IRC | 22:58 | |
| *** aepifanov has quit IRC | 22:58 | |
| *** manishg has joined #openstack-neutron | 22:59 | |
| carl_baldwin | I think kevinbenton is on to something. https://review.openstack.org/#/c/143865/10/neutron/plugins/ml2/plugin.py | 22:59 |
| *** flwang1 has quit IRC | 23:00 | |
| *** jgrimm is now known as zz_jgrimm | 23:01 | |
| openstackgerrit | Kevin Benton proposed openstack/neutron: Don't start transaction during floating IP delete https://review.openstack.org/160036 | 23:01 |
| carl_baldwin | haleyb: What about 116924? I’m not following. | 23:01 |
| haleyb | that was the change that added the core_plugin call | 23:02 |
| *** spandhe has joined #openstack-neutron | 23:02 | |
| *** manishg has quit IRC | 23:03 | |
| kevinbenton | haleyb: right, i think 116924 introduced the possibility | 23:03 |
| kevinbenton | carl_baldwin, haleyb: once that was introduced, it was just a matter of timing to trigger this | 23:04 |
| *** jamielennox is now known as jamielennox|away | 23:06 | |
| *** annegentle has joined #openstack-neutron | 23:06 | |
| *** setuid has joined #openstack-neutron | 23:06 | |
| kevinbenton | carl_baldwin: https://review.openstack.org/160036 | 23:06 |
| carl_baldwin | kevinbenton: Already looking. | 23:07 |
| carl_baldwin | haleyb: Right, I was looking at the other delete_port (from _delete_floatingip). | 23:07 |
| kevinbenton | carl_baldwin: i need to make a migration if we go that route, but i'm not sure how to get a migration just to change the cascade action | 23:07 |
| *** pradip_rawat has joined #openstack-neutron | 23:07 | |
| *** kbringard has quit IRC | 23:07 | |
| carl_baldwin | haleyb: kevinbenton: you could argue that the ticking timebomb has been in there much longer. | 23:09 |
| kevinbenton | haleyb, carl_baldwin: i don't see how 116924 changed it | 23:09 |
| kevinbenton | carl_baldwin: right, the floating IP starting a transaction i think has been there much longer, right? | 23:10 |
| *** pradip_vedams has quit IRC | 23:10 | |
| *** pradip_rawat is now known as pradip_vedams | 23:10 | |
| carl_baldwin | kevinbenton: I think 116924 adds the delete_port that is trying to get the lock, not the one holding the lock. Right haleyb? I don’t have my head totally wrapped around it yet. | 23:11 |
| openstackgerrit | Eric Brown proposed openstack/neutron: Use oslo_config choices support https://review.openstack.org/159288 | 23:11 |
| haleyb | kevinbenton: oh, that delete_port() call just got moved around, seemed to be the commit you were referencing | 23:12 |
| openstackgerrit | Eric Brown proposed openstack/neutron: Password config options should be marked secret https://review.openstack.org/159290 | 23:12 |
| carl_baldwin | kevinbenton: The start transaction was introduced in 2012. | 23:12 |
| carl_baldwin | kevinbenton: But, it takes two to tango. Someone else had to come in and request the lock while that code path had the lock. | 23:13 |
| carl_baldwin | Now I’m back to not knowing how 116924 fits in. | 23:14 |
| kevinbenton | carl_baldwin: it might not | 23:15 |
| openstackgerrit | Zengfa Gao proposed openstack/python-neutronclient: Add Neutron subnetpool API https://review.openstack.org/159618 | 23:16 |
| *** achanda has quit IRC | 23:16 | |
| *** achanda has joined #openstack-neutron | 23:20 | |
| *** SridharRamaswamy has joined #openstack-neutron | 23:20 | |
| *** SridharRamaswam1 has joined #openstack-neutron | 23:21 | |
| *** SridharRamaswamy has quit IRC | 23:24 | |
| carl_baldwin | kevinbenton: The cascade delete makes sense from a model perspective. I think it would be a good change anyway. But, that it allows us to avoid wrapping delete_port in a transaction makes it even better. | 23:25 |
| kevinbenton | carl_baldwin: ok. i'm fighting with the migration script right now | 23:25 |
| kevinbenton | carl_baldwin: i'll update the patch with that | 23:25 |
| carl_baldwin | kevinbenton: I don’t think I’ll be much help with the migration script. | 23:25 |
| kevinbenton | carl_baldwin: do you know who i could ping for a quick example of one that just updates a cascade? | 23:26 |
| *** tflynn has joined #openstack-neutron | 23:27 | |
| ZZelle | do anyone have a good knowledge of neutron.agent.firewall? | 23:30 |
| kevinbenton | HenryG: ping | 23:31 |
| carl_baldwin | kevinbenton: I was going to say HenryG . :) | 23:31 |
| ZZelle | haleyb, are you around? | 23:32 |
| *** tflynn has quit IRC | 23:32 | |
| carl_baldwin | kevinbenton: maybe akamyshnikova too | 23:33 |
| kevinbenton | carl_baldwin: thx | 23:33 |
| kevinbenton | akamyshnikova: i have an alembic migration script question if you are around | 23:33 |
| marun | HenryG: This looks ready to me: https://review.openstack.org/#/c/159193/ | 23:35 |
| *** dims_ has joined #openstack-neutron | 23:37 | |
| amuller | marun: https://review.openstack.org/#/c/158097/ has a clean Jenkins run | 23:37 |
| amuller | please approve before someone farts and it fails CI again | 23:37 |
| *** dimsum__ has quit IRC | 23:38 | |
| *** dims_ has quit IRC | 23:39 | |
| *** dimsum__ has joined #openstack-neutron | 23:39 | |
| *** _cjones_ has quit IRC | 23:40 | |
| *** _cjones_ has joined #openstack-neutron | 23:41 | |
| openstackgerrit | Sumit Naiksatam proposed openstack/neutron: Fix retrieval of shared firewall_policies https://review.openstack.org/160048 | 23:42 |
| *** dane_leblanc has quit IRC | 23:45 | |
| *** apuimedo has quit IRC | 23:45 | |
| *** jobewan has quit IRC | 23:46 | |
| *** pradip_rawat has joined #openstack-neutron | 23:48 | |
| marun | kevinbenton: coup de grace? https://review.openstack.org/#/c/158097/ | 23:49 |
| kevinbenton | marun: ready to go? | 23:50 |
| marun | kevinbenton: lgtm | 23:50 |
| *** dboik has joined #openstack-neutron | 23:51 | |
| *** pradip_vedams has quit IRC | 23:51 | |
| *** pradip_rawat_ has joined #openstack-neutron | 23:51 | |
| *** pradip_rawat_ is now known as pradip_vedams | 23:51 | |
| kevinbenton | marun: ack | 23:52 |
| kevinbenton | marun: do you know how to have an alembic migration script that just changes cascade behavior? | 23:52 |
| *** chuckC_ has joined #openstack-neutron | 23:52 | |
| *** Marga_ has joined #openstack-neutron | 23:52 | |
| *** Marga_ has quit IRC | 23:53 | |
| *** Marga_ has joined #openstack-neutron | 23:53 | |
| *** bquan has quit IRC | 23:53 | |
| *** dboik_ has quit IRC | 23:54 | |
| *** pradip_rawat has quit IRC | 23:55 | |
| *** dboik has quit IRC | 23:55 | |
| *** ajmiller has quit IRC | 23:57 | |
| *** baoli has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!