Thursday, 2014-05-08

*** manishg has quit IRC00:00
*** WackoRobie has joined #openstack-neutron00:01
*** manishg has joined #openstack-neutron00:01
*** sbfox has joined #openstack-neutron00:02
*** geekinutah has quit IRC00:04
openstackgerritoda-g proposed a change to openstack/neutron-specs: Enable to set DHCP port attributes  https://review.openstack.org/8996900:04
*** manishg has quit IRC00:05
*** oda-g has joined #openstack-neutron00:05
*** manishg has joined #openstack-neutron00:06
*** matsuhashi has joined #openstack-neutron00:07
*** yamahata has joined #openstack-neutron00:08
*** SumitNaiksatam has quit IRC00:08
*** manishg has quit IRC00:10
*** manishg has joined #openstack-neutron00:10
*** crc32 has quit IRC00:13
*** manishg has quit IRC00:15
*** manishg has joined #openstack-neutron00:15
*** gdubreui has quit IRC00:19
*** overlayer has joined #openstack-neutron00:19
*** manishg has quit IRC00:20
*** manishg has joined #openstack-neutron00:20
*** rwsu has joined #openstack-neutron00:20
*** overlayer has quit IRC00:23
*** manishg has quit IRC00:25
*** overlayer has joined #openstack-neutron00:25
*** manishg has joined #openstack-neutron00:26
*** overlayer has quit IRC00:26
*** banix has joined #openstack-neutron00:28
*** matsuhashi has quit IRC00:28
*** dvorkinista has quit IRC00:29
*** manishg has quit IRC00:30
*** dvorkini_ has joined #openstack-neutron00:30
*** manishg has joined #openstack-neutron00:31
*** matsuhas_ has joined #openstack-neutron00:31
*** chuckC has quit IRC00:32
*** jreypo has quit IRC00:34
*** manishg has quit IRC00:35
*** manishg has joined #openstack-neutron00:36
*** yamamoto has joined #openstack-neutron00:38
mesteryrm_work: You don't need to post here, but it doesn't hurt. The queue is large, but the core reviewers do their best to whittle it down. :)00:38
*** prad_ has quit IRC00:39
*** manishg has quit IRC00:40
*** matsuhas_ has quit IRC00:40
*** matsuhashi has joined #openstack-neutron00:41
*** manishg has joined #openstack-neutron00:41
*** manishg has quit IRC00:45
*** manishg has joined #openstack-neutron00:46
*** networkstatic has joined #openstack-neutron00:47
*** manishg has quit IRC00:50
*** nplanel_ has quit IRC00:51
*** manishg has joined #openstack-neutron00:51
*** markmcclain1 has quit IRC00:52
*** manishg has quit IRC00:55
*** WackoRobie has quit IRC00:56
*** WackoRobie has joined #openstack-neutron00:56
*** WackoRob_ has joined #openstack-neutron00:58
*** gdubreui has joined #openstack-neutron00:59
*** WackoRob_ has quit IRC01:01
*** WackoRob_ has joined #openstack-neutron01:01
*** WackoRobie has quit IRC01:01
*** dvorkinista has joined #openstack-neutron01:07
*** mestery has quit IRC01:08
*** dvorkini_ has quit IRC01:10
*** SumitNaiksatam has joined #openstack-neutron01:10
*** dims has quit IRC01:11
*** dims has joined #openstack-neutron01:11
*** dvorkinista has quit IRC01:13
*** dims has quit IRC01:13
*** armax has left #openstack-neutron01:14
*** dims has joined #openstack-neutron01:15
*** dims has quit IRC01:15
*** xianghui has joined #openstack-neutron01:15
*** dims has joined #openstack-neutron01:15
*** dims has quit IRC01:16
*** dims has joined #openstack-neutron01:18
*** LeileiZhou has joined #openstack-neutron01:18
*** sbfox has quit IRC01:19
*** sbalukoff has quit IRC01:20
*** dims has quit IRC01:20
*** dims has joined #openstack-neutron01:21
*** dims has quit IRC01:22
*** iwamoto has joined #openstack-neutron01:22
*** dims has joined #openstack-neutron01:22
*** zhipeng has quit IRC01:23
*** mestery has joined #openstack-neutron01:25
*** shakamunyi has joined #openstack-neutron01:27
*** ramishra has joined #openstack-neutron01:27
*** jaypipes has quit IRC01:28
*** sballe has quit IRC01:28
*** jecarey has joined #openstack-neutron01:29
*** gdubreui has quit IRC01:29
*** sballe has joined #openstack-neutron01:29
*** gdubreui has joined #openstack-neutron01:30
*** blogan has joined #openstack-neutron01:30
*** mestery has quit IRC01:34
*** LeileiZhou_ has joined #openstack-neutron01:35
*** LeileiZhou has quit IRC01:35
*** _cjones_ has quit IRC01:40
*** _cjones_ has joined #openstack-neutron01:41
*** arnaud has joined #openstack-neutron01:41
*** shakamunyi has quit IRC01:42
*** _cjones_ has quit IRC01:45
*** yamamoto has quit IRC01:47
*** mestery has joined #openstack-neutron01:48
*** xuhanp has joined #openstack-neutron01:57
*** shakamunyi has joined #openstack-neutron01:57
*** LeileiZhou has joined #openstack-neutron02:01
*** LeileiZhou_ has quit IRC02:02
*** harlowja has quit IRC02:03
*** fifieldt has joined #openstack-neutron02:03
*** harlowja has joined #openstack-neutron02:04
*** mengxd has joined #openstack-neutron02:04
*** arnaud has quit IRC02:05
*** sballe has quit IRC02:05
*** WackoRob_ has quit IRC02:06
*** sballe has joined #openstack-neutron02:06
*** baoli has joined #openstack-neutron02:14
*** shakayumi has joined #openstack-neutron02:15
*** gdubreui has quit IRC02:15
*** dims has quit IRC02:16
*** gdubreui has joined #openstack-neutron02:16
*** dims has joined #openstack-neutron02:16
*** shakamunyi has quit IRC02:19
*** blogan has quit IRC02:21
*** amcrn has joined #openstack-neutron02:31
*** nlahouti has quit IRC02:31
*** chuckC has joined #openstack-neutron02:34
*** spandhe has quit IRC02:35
*** dims has quit IRC02:37
*** dims has joined #openstack-neutron02:38
*** dims has quit IRC02:40
*** harlowja has quit IRC02:44
*** harlowja has joined #openstack-neutron02:44
*** mestery has quit IRC02:49
*** a_le has quit IRC02:50
*** otherwiseguy has joined #openstack-neutron02:52
*** dims has joined #openstack-neutron02:54
*** shakayumi has quit IRC03:01
*** dims has quit IRC03:05
*** gus has quit IRC03:09
*** otherwiseguy has quit IRC03:10
*** dkehn_ has joined #openstack-neutron03:12
*** alagalah has joined #openstack-neutron03:15
*** dkehn has quit IRC03:15
*** dkehnx has quit IRC03:15
*** yamamoto has joined #openstack-neutron03:15
*** yamamoto has quit IRC03:15
*** yamamoto has joined #openstack-neutron03:16
*** dkehn has joined #openstack-neutron03:17
*** otherwiseguy has joined #openstack-neutron03:19
*** geekinutah has joined #openstack-neutron03:21
*** changbl has quit IRC03:21
*** singhs has joined #openstack-neutron03:21
*** jecarey has quit IRC03:22
*** matsuhashi has quit IRC03:24
*** a_le has joined #openstack-neutron03:28
*** shakayumi has joined #openstack-neutron03:31
*** SridharG has joined #openstack-neutron03:33
*** krtaylor has joined #openstack-neutron03:33
*** coolsvap|afk is now known as coolsvap03:35
*** gus has joined #openstack-neutron03:36
*** geekinutah has quit IRC03:39
*** geekinutah has joined #openstack-neutron03:39
*** armax has joined #openstack-neutron03:40
*** ams0 has quit IRC03:44
*** ams0 has joined #openstack-neutron03:44
*** a_le has quit IRC03:48
*** arnaud has joined #openstack-neutron03:50
*** alex_klimov has joined #openstack-neutron03:55
*** BuSerD_ has quit IRC03:56
*** armax has quit IRC03:56
*** baoli has quit IRC03:58
*** alex_klimov has quit IRC04:00
*** otherwiseguy has quit IRC04:01
*** puck has quit IRC04:04
*** shakayumi has quit IRC04:08
*** yfried has quit IRC04:23
*** mestery has joined #openstack-neutron04:24
*** dgollub has quit IRC04:24
*** mengxd has quit IRC04:28
*** ramishra has quit IRC04:30
*** puck has joined #openstack-neutron04:30
*** alagalah has quit IRC04:31
*** alex_klimov has joined #openstack-neutron04:31
*** puck` has joined #openstack-neutron04:32
*** arnaud has quit IRC04:33
*** puck has quit IRC04:33
*** sbalukoff has joined #openstack-neutron04:35
*** matsuhashi has joined #openstack-neutron04:37
*** alagalah has joined #openstack-neutron04:40
*** puck` has quit IRC04:41
*** puck has joined #openstack-neutron04:44
*** puck has quit IRC04:46
*** puck has joined #openstack-neutron04:46
*** puck has quit IRC04:50
*** armax has joined #openstack-neutron04:53
*** Longgeek has joined #openstack-neutron04:55
*** dave_tucker is now known as dave_tucker_zzz05:00
*** puck has joined #openstack-neutron05:00
*** WackoRobie has joined #openstack-neutron05:05
*** WackoRobie has quit IRC05:06
*** WackoRobie has joined #openstack-neutron05:06
*** ams0 has quit IRC05:10
*** WackoRobie has quit IRC05:11
*** ams0 has joined #openstack-neutron05:14
*** ams0 has quit IRC05:14
*** ams0 has joined #openstack-neutron05:16
*** ams0 has quit IRC05:16
*** banix has quit IRC05:18
*** salv-orlando has quit IRC05:18
*** ams0 has joined #openstack-neutron05:19
*** amotoki has joined #openstack-neutron05:19
*** matsuhashi has quit IRC05:19
*** ams0 has quit IRC05:20
*** matsuhashi has joined #openstack-neutron05:20
openstackgerritLi Ma proposed a change to openstack/neutron: Race condition of L3-agent to add/remove routers  https://review.openstack.org/7323405:21
*** ams0 has joined #openstack-neutron05:21
*** ams0 has quit IRC05:21
*** ams0 has joined #openstack-neutron05:22
*** ams0 has quit IRC05:22
*** armax has quit IRC05:26
*** ams0 has joined #openstack-neutron05:27
*** ams0 has quit IRC05:27
*** ams0 has joined #openstack-neutron05:28
*** ams0 has quit IRC05:29
*** dgollub has joined #openstack-neutron05:31
*** alagalah has quit IRC05:32
openstackgerritArtem Dmytrenko proposed a change to openstack/neutron-specs: BGP dynamic routing  https://review.openstack.org/9083305:35
*** chandan_kumar has joined #openstack-neutron05:37
*** shakayumi has joined #openstack-neutron05:52
*** a_le has joined #openstack-neutron05:54
*** yfried has joined #openstack-neutron05:56
*** shakayumi has quit IRC05:57
*** alagalah has joined #openstack-neutron06:03
*** WackoRobie has joined #openstack-neutron06:05
*** morganfainberg is now known as morganfainberg_Z06:05
*** harlowja is now known as harlowja_away06:08
*** WackoRobie has quit IRC06:09
*** singhs has quit IRC06:10
*** alagalah has quit IRC06:11
*** uaberme has joined #openstack-neutron06:12
*** WaltNik has joined #openstack-neutron06:15
*** dvorkinista has joined #openstack-neutron06:26
*** dvorkini_ has joined #openstack-neutron06:30
*** dvorkinista has quit IRC06:30
*** SridharG has quit IRC06:30
*** SridharG has joined #openstack-neutron06:35
*** dgollub has quit IRC06:35
*** alagalah has joined #openstack-neutron06:38
*** salv-orlando has joined #openstack-neutron06:47
*** a_le has quit IRC06:49
*** amuller has joined #openstack-neutron06:49
*** bashok has joined #openstack-neutron06:51
*** SridharG has quit IRC06:53
*** shakayumi has joined #openstack-neutron06:53
*** amarao has joined #openstack-neutron06:55
*** alagalah has quit IRC06:57
*** shakayumi has quit IRC06:58
*** devvesa has joined #openstack-neutron06:59
*** dvorkinista has joined #openstack-neutron07:04
*** uaberme has quit IRC07:04
*** WackoRobie has joined #openstack-neutron07:05
*** LeileiZhou has quit IRC07:05
*** LeileiZhou_ has joined #openstack-neutron07:06
*** evgenyf has joined #openstack-neutron07:06
*** amcrn has quit IRC07:06
*** dvorkini_ has quit IRC07:07
*** oda-g has quit IRC07:08
*** LeileiZhou has joined #openstack-neutron07:09
*** WackoRobie has quit IRC07:09
*** LeileiZhou_ has quit IRC07:10
*** SumitNaiksatam_ has joined #openstack-neutron07:11
*** SumitNaiksatam has quit IRC07:13
*** SumitNaiksatam_ has quit IRC07:17
*** alagalah has joined #openstack-neutron07:22
openstackgerritYAMAMOTO Takashi proposed a change to openstack/neutron: ofagent: Add a missing push_vlan action  https://review.openstack.org/8822407:30
*** gdubreui has quit IRC07:32
*** LeileiZhou_ has joined #openstack-neutron07:40
*** alagalah has quit IRC07:40
*** LeileiZhou has quit IRC07:40
*** dvorkinista has quit IRC07:41
openstackgerritA change was merged to openstack/neutron: Database exception causes UnboundLocalError in linuxbridge-agent  https://review.openstack.org/9030007:43
*** yamamoto has quit IRC07:44
*** uaberme has joined #openstack-neutron07:48
*** a_le has joined #openstack-neutron07:50
*** LeileiZhou_ has quit IRC07:50
*** gus has quit IRC07:51
*** gus has joined #openstack-neutron07:52
*** shakayumi has joined #openstack-neutron07:54
*** matsuhashi has quit IRC07:54
*** matsuhashi has joined #openstack-neutron07:55
*** veena has joined #openstack-neutron07:58
*** shakayumi has quit IRC07:58
veenaVMs are not reachable via GRE tunnel using openvswitch. Stderr: 'ovs-ofctl: -1: negative values not supported for in_port\n'08:00
*** jpich has joined #openstack-neutron08:00
*** alagalah has joined #openstack-neutron08:06
*** a_le has quit IRC08:10
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: Return a 404 on quota delete if entry not found  https://review.openstack.org/9279008:16
*** dkehn__ has joined #openstack-neutron08:22
*** alagalah has quit IRC08:24
*** dkehn__ has quit IRC08:24
*** dkehn_ has quit IRC08:25
*** dkehn__ has joined #openstack-neutron08:25
*** dkehn has quit IRC08:25
*** dkehn has joined #openstack-neutron08:27
*** salv-orlando_ has joined #openstack-neutron08:27
*** salv-orlando has quit IRC08:29
*** salv-orlando_ is now known as salv-orlando08:29
*** gus has quit IRC08:30
*** LeileiZhou has joined #openstack-neutron08:30
openstackgerritAnn Kamyshnikova proposed a change to openstack/neutron: Test2  https://review.openstack.org/9279108:34
*** veena has quit IRC08:36
*** dkehn_ has joined #openstack-neutron08:38
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: Start ping listener also for postgresql  https://review.openstack.org/9279208:39
*** dkehn_ has quit IRC08:40
*** dkehn has quit IRC08:40
*** dkehn__ has quit IRC08:41
*** dkehn_ has joined #openstack-neutron08:41
openstackgerritMaru Newby proposed a change to openstack/neutron: Ensure core plugin deallocation after every test  https://review.openstack.org/9279308:42
kevinbentonmarun: ping08:42
marunpong08:42
marunkevinbenton: https://review.openstack.org/#/c/92793/08:42
marunthis is the real fix08:42
*** dkehn has joined #openstack-neutron08:42
marunreview welcome :)08:42
marunkevinbenton: I like your intent, but I think we need to focus on big problems rather than nibbling away.08:43
marunkevinbenton: otherwise we're adding complexity without much benefit08:43
marunkevinbenton: I see very little memory being consumed by the mocks that you're replacing08:44
marunkevinbenton: My next target is sqlalchemy - after that patch it's 40% of the remaining leakage.08:45
marunkevinbenton: does that make sense?08:46
kevinbentonmarun: so I shouldn't even bother correcting them?08:46
marunkevinbenton: to what end?08:46
marunkevinbenton: do you have a measure for the impact you're addressing?08:46
marunkevinbenton: have you been using tracemalloc?08:47
marunkevinbenton: there are a crapload of things to fix in neutron, especially the tests.  it's easy to work on things that don't matter if we don't measure first.08:47
kevinbentonmarun: no, I modified mock to watch for persistence across tests08:48
marunkevinbenton: That is a starting point, for sure.08:48
marunkevinbenton: But without visibility on how much that persistence actually costs, how do you know that it's important to work on?08:49
openstackgerritAnn Kamyshnikova proposed a change to openstack/neutron: Test2  https://review.openstack.org/9279108:49
kevinbentonmarun: I already worked on it. The fixes are in there. I can strip out the forgetfulmock bit08:49
marunkevinbenton: I'm game if you want to focus on ensuring that tests don't share mocks.08:50
*** alagalah has joined #openstack-neutron08:50
marunkevinbenton: I do think that's important - too many test dependencies are due to inadvertent sharing.08:50
kevinbentonmarun: i was looking at that plugin caching too, why was that done in the first place? Will your change come at a time cost?08:52
marunkevinbenton: no, there is no penalty in time08:52
marunkevinbenton: it takes less tiem08:52
marunkevinbenton: and if we do want to share, we need to use the fixtures library to do it properly08:53
marunkevinbenton: I think it was done out of ignorance, frankly.08:53
kevinbentonmarun: share what?08:53
marunkevinbenton: share state08:54
marunkevinbenton: e.g. share instantiated plugins between tests08:54
marunkevinbenton: I don't think it was plugin 'caching' so much as carelessness.08:54
*** shakayumi has joined #openstack-neutron08:55
kevinbentonmarun: oh. I saw the code for it and assumed that someone had to have a reason to jump through those hoops.08:56
*** salv-orlando has quit IRC08:56
marunkevinbenton: I think I had the same reaction at one point, but 3gb+ of memory usage said otherwise ;)08:57
marunkevinbenton: incidentally, I had to change a couple of tests in ml2 that you worked on08:57
kevinbentonmarun: yeah, I noticed the sqlalchemy usage when I was poking around with objgraph and pdb08:58
marunkevinbenton: sqlalchemy is still a problem, but I think we're just doing it wrong.08:58
marunkevinbenton: we shouldn't be building db state and throwing it away on each test.08:59
*** shakayumi has quit IRC08:59
marunkevinbenton: we should be able to use fixtures and transactions instead and I think that will reduce the memory usage dramatically08:59
*** uaberme has quit IRC09:00
kevinbentonmarun: but why would that lead to high memory usage?09:02
marunkevinbenton: I don't actually know, I've been focused on the mock leakage up until now09:03
marunkevinbenton: but it sure as heck has a huge speed penalty09:03
openstackgerritMaru Newby proposed a change to openstack/neutron: Ensure core plugin deallocation after every test  https://review.openstack.org/9279309:04
*** WackoRobie has joined #openstack-neutron09:05
kevinbentonmarun: so why did that test have to change to avoid tearDown and setup?09:07
marunkevinbenton: why would you want to setup/teardown unnecessarily?09:07
marunkevinbenton: every time it happens, all the db models have to be created and then thrown away09:07
openstackgerritYongli He proposed a change to openstack/python-neutronclient: Use six.moves cStringIO instead of cStringIO  https://review.openstack.org/7393709:07
kevinbentonmarun: oh, I assumed something I your change broke it so it had to be fixed in this patch09:08
marunkevinbenton: it did break, actually09:08
marunkevinbenton: and the fix was making it more sane09:09
marunkevinbenton: by chance :)09:09
*** alagalah has quit IRC09:09
kevinbentonmarun: the fix is fine, I was just curious why it broke09:10
marunkevinbenton: feel free to apply the fix and revert :)09:10
*** WackoRobie has quit IRC09:10
marun(revert that file I mean)09:10
kevinbentonmarun: I'm on a tablet at the moment09:11
marunkevinbenton: maybe I screwed up?09:11
marunkevinbenton: nope, they are broken without persistent plugin instances09:12
marunkevinbenton: out of curiosity, why did you think that the best way to test things would be to teardown and setup again?:09:12
kevinbentonmarun: I'm incompetent :-)09:13
marunkevinbenton: :p09:13
marunkevinbenton: nonsense.  we all make mistakes - the only way to learn09:14
kevinbentonmarun: i recall thinking it would be good to have them in the same class for nice organization09:14
marunkevinbenton: fair enough09:14
marunkevinbenton: hard to tell if something is wrong when unit tests execution time is commonly in the seconds09:15
marunkevinbenton: (a good unit test should be in the hundredths of a second btw)09:15
kevinbentonmarun: I don't see why that test requires persistence in the old state, what am I missing?09:21
marunkevinbenton: I have to sleep09:21
marunkevinbenton: Feel free to investigate, but the fix is required to get the tests working properly.09:22
marunkevinbenton: actually, I do know why...09:33
marunkevinbenton: the problem is that teardown is not sufficient to wipe things clean09:34
marunkevinbenton: the test machinery ensures that other cleanup methods are run in addition to tearDown09:34
*** alagalah has joined #openstack-neutron09:35
*** marun is now known as marun_afk09:35
*** alagalah_ has joined #openstack-neutron09:37
*** alagalah has quit IRC09:37
*** xuhanp has quit IRC09:40
*** iwamoto has quit IRC09:41
*** dkehn__ has joined #openstack-neutron09:42
*** dkehn_ has quit IRC09:45
*** alagalah_ has quit IRC09:53
*** evgenyf has quit IRC09:55
*** shakayumi has joined #openstack-neutron09:55
*** shakayumi has quit IRC10:00
*** WackoRobie has joined #openstack-neutron10:05
*** WackoRobie has quit IRC10:10
*** evgenyf has joined #openstack-neutron10:12
*** alagalah has joined #openstack-neutron10:19
*** alagalah_ has joined #openstack-neutron10:21
*** alagalah has quit IRC10:21
openstackgerritAnn Kamyshnikova proposed a change to openstack/neutron: Test2  https://review.openstack.org/9279110:24
*** matsuhashi has quit IRC10:27
*** amuller has quit IRC10:37
*** coolsvap is now known as coolsvap|afk10:37
*** matsuhashi has joined #openstack-neutron10:40
*** alagalah_ has quit IRC10:40
*** rkukura_ has joined #openstack-neutron10:48
*** YorikSar_ has joined #openstack-neutron10:51
*** gmurphy_ has joined #openstack-neutron10:54
*** coolsvapl has joined #openstack-neutron10:54
*** rkukura has quit IRC10:55
*** coolsvap|afk has quit IRC10:55
*** gmurphy has quit IRC10:55
*** Matt3 has quit IRC10:55
*** pasquier-s has quit IRC10:55
*** ToM has quit IRC10:55
*** YorikSar has quit IRC10:55
*** rkukura_ is now known as rkukura10:55
*** pasquier-s has joined #openstack-neutron10:56
*** ToM-- has joined #openstack-neutron10:56
*** ToM-- is now known as ToM10:56
*** Matt2 has joined #openstack-neutron10:56
*** jroovers|afk has joined #openstack-neutron11:02
*** amuller has joined #openstack-neutron11:02
*** YorikSar has joined #openstack-neutron11:04
*** christop1eraedo has joined #openstack-neutron11:04
*** alagalah has joined #openstack-neutron11:04
*** WackoRobie has joined #openstack-neutron11:05
*** alagalah_ has joined #openstack-neutron11:07
*** alagalah has quit IRC11:07
*** WackoRobie has quit IRC11:10
*** dims has joined #openstack-neutron11:12
*** pcm_ has joined #openstack-neutron11:19
*** alagalah_ has quit IRC11:20
*** alagalah has joined #openstack-neutron11:20
*** baoli has joined #openstack-neutron11:22
*** matsuhas_ has joined #openstack-neutron11:22
*** YorikSar_ has quit IRC11:23
*** matsuhashi has quit IRC11:23
*** jroovers has quit IRC11:23
*** erecio has quit IRC11:23
*** christopheraedo has quit IRC11:23
*** haleyb has quit IRC11:23
openstackgerritenikanorov proposed a change to openstack/neutron: ML2 VxlanTypeDriver: Synchronize of VxlanAllocation table  https://review.openstack.org/9281111:24
*** baoli has quit IRC11:33
*** baoli has joined #openstack-neutron11:33
*** haleyb has joined #openstack-neutron11:38
*** erecio has joined #openstack-neutron11:47
*** evgenyf has quit IRC12:04
*** gizmoguy has quit IRC12:04
*** insequent has quit IRC12:04
*** mancdaz has quit IRC12:04
*** WackoRobie has joined #openstack-neutron12:05
*** WackoRobie has quit IRC12:10
*** markvoelker has joined #openstack-neutron12:13
*** evgenyf has joined #openstack-neutron12:18
*** gizmoguy has joined #openstack-neutron12:18
*** insequent has joined #openstack-neutron12:18
*** mancdaz has joined #openstack-neutron12:18
*** julim has joined #openstack-neutron12:33
*** devvesa has quit IRC12:37
*** beagles has quit IRC13:00
*** ramishra has joined #openstack-neutron13:01
*** WackoRobie has joined #openstack-neutron13:05
*** fifieldt has quit IRC13:06
*** b3nt_pin has joined #openstack-neutron13:06
*** b3nt_pin is now known as beagles13:06
*** xianghui has quit IRC13:07
*** ramishra_ has joined #openstack-neutron13:08
*** WackoRobie has quit IRC13:09
*** ramishra has quit IRC13:10
*** dgollub has joined #openstack-neutron13:12
*** sballe_ has joined #openstack-neutron13:16
*** sballe has quit IRC13:17
*** changbl has joined #openstack-neutron13:18
*** amuller has quit IRC13:21
*** mflobo has joined #openstack-neutron13:22
*** coolsvapl is now known as coolsvap|afk13:22
*** jobewan has joined #openstack-neutron13:23
*** amuller has joined #openstack-neutron13:25
*** cgascoig has joined #openstack-neutron13:27
*** chandan_kumar has quit IRC13:28
*** cgascoig has quit IRC13:29
*** coolsvap|afk is now known as coolsvap13:29
*** cgascoig has joined #openstack-neutron13:29
*** mwagner_ has quit IRC13:29
*** banix has joined #openstack-neutron13:30
*** lukego has quit IRC13:31
*** xuhanp has joined #openstack-neutron13:33
*** ramishra_ has quit IRC13:33
*** cgascoig has quit IRC13:33
*** ramishra has joined #openstack-neutron13:34
*** lukego has joined #openstack-neutron13:34
*** dkehn__ is now known as dkehnx13:35
openstackgerritA change was merged to openstack/neutron: Start ping listener also for postgresql  https://review.openstack.org/9279213:37
*** devvesa has joined #openstack-neutron13:38
*** carl_baldwin has joined #openstack-neutron13:40
*** changbl has quit IRC13:42
*** changbl has joined #openstack-neutron13:43
*** chandan_kumar has joined #openstack-neutron13:45
*** dave_tucker_zzz is now known as dave_tucker13:48
*** yamahata has quit IRC13:50
*** yamahata has joined #openstack-neutron13:51
*** markwash has joined #openstack-neutron13:52
*** changbl has quit IRC13:54
*** TrevorV has joined #openstack-neutron13:54
*** salv-orlando has joined #openstack-neutron13:57
openstackgerritErik Colnick proposed a change to openstack/neutron: Support 'infinite' dhcp_lease_duration  https://review.openstack.org/9245313:57
*** arnaud has joined #openstack-neutron13:59
*** otherwiseguy has joined #openstack-neutron14:00
*** prad_ has joined #openstack-neutron14:01
*** networkstatic has quit IRC14:02
HenryGakamyshnikova: hi14:02
*** kbringard has joined #openstack-neutron14:02
HenryGamotoki: hi14:02
*** networkstatic has joined #openstack-neutron14:02
*** WackoRobie has joined #openstack-neutron14:02
*** terryw has joined #openstack-neutron14:03
*** otherwiseguy has quit IRC14:03
*** samuelbercovici has joined #openstack-neutron14:03
openstackgerritA change was merged to openstack/neutron: Remove explicit dependency on amqplib  https://review.openstack.org/9214914:03
prad_can i get some core reviews on this please https://review.openstack.org/#/c/91474/14:04
*** julim has quit IRC14:06
*** changbl has joined #openstack-neutron14:06
*** jorgem has joined #openstack-neutron14:10
openstackgerritArmando Migliaccio proposed a change to openstack/neutron: Return a 404 on quota delete if entry not found  https://review.openstack.org/9279014:10
*** overlayer has joined #openstack-neutron14:10
*** jgrimm has joined #openstack-neutron14:12
*** blogan has joined #openstack-neutron14:14
*** coolsvap is now known as coolsvap|afk14:15
*** armax has joined #openstack-neutron14:15
HenryGsalv-orlando: hi14:17
salv-orlando=hi NeryG14:18
salv-orlandohi HenryG14:18
*** tziOm has quit IRC14:19
*** prad__ has joined #openstack-neutron14:19
HenryGsalv-orlando: I know you won't be at the summit, but I want to try and meet up with some people there who are working on the DB migration efforts. We could try to get closer to converging on a solution.14:20
HenryGsalv-orlando: So I was wondering if you have any updates on your thoughts for a solution?14:20
salv-orlandoDefinetely. That would be great.14:20
salv-orlandoI think Anna shared something today. She's the one who's being most of the work so far14:21
salv-orlandoI have not yet read her email.14:21
HenryGWhich email is that?14:21
*** prad_ has quit IRC14:22
*** evgenyf has quit IRC14:23
*** ramishra_ has joined #openstack-neutron14:24
*** felux has joined #openstack-neutron14:25
*** ramishra has quit IRC14:25
*** alagalah has quit IRC14:26
*** ramishra_ has quit IRC14:26
*** peristeri has joined #openstack-neutron14:27
*** coolsvap|afk is now known as coolsvap14:27
*** dgollub has quit IRC14:28
*** avishnoi has joined #openstack-neutron14:30
avishnoianybody up for query related to lbaas ?14:30
*** tziOm has joined #openstack-neutron14:32
*** ramishra has joined #openstack-neutron14:33
*** chandan_kumar has quit IRC14:34
*** chandan_kumar has joined #openstack-neutron14:34
*** terryw has quit IRC14:36
*** otherwiseguy has joined #openstack-neutron14:36
*** markmcclain has joined #openstack-neutron14:37
*** thedodd has joined #openstack-neutron14:38
*** dgollub has joined #openstack-neutron14:40
*** mengxd has joined #openstack-neutron14:41
pcm_avishnoi: FYI most of the LB team is in a LBaaS IRC meeting right now,14:41
avishnoipcm_: thanks!, will ping after some time then14:42
*** markmcclain has quit IRC14:42
pcm_avishnoi: Try at the top of the hour (20 mins)14:42
*** bashok has quit IRC14:42
avishnoipcm_: sure14:43
*** ramishra_ has joined #openstack-neutron14:44
*** ramishra has quit IRC14:45
*** ramishra_ has quit IRC14:49
*** jecarey has joined #openstack-neutron14:49
larsksHas anyone seen the error "NameError: global name 'DEVICE_OWNER_ROUTER_INTF' is not defined" coming from neutron-metadata-agent?14:53
*** mayu has joined #openstack-neutron14:54
*** alex_klimov has quit IRC14:55
*** mengxd has quit IRC14:55
*** mengxd has joined #openstack-neutron14:55
*** mengxd has quit IRC14:55
HenryGsalv-orlando: Just to be clear, do we still want to eventually remove auto-generation of DB? (review 40296)14:55
*** mengxd has joined #openstack-neutron14:56
salv-orlandoHenryG: totally.14:56
HenryGsalv-orlando: ok, good14:57
mayusalv-orlando: hi, Is there extra requirement for third-party ml2 driver except for tempest ?14:58
HenryGsalv-orlando: Do you know how bad (expensive?) it is to have empty/unused tables in the DB? This could be a factor in deciding the solution, and I don't know the answer.14:58
samuelbercoviciblogan: ping15:01
salv-orlandoTo my knowledge an empty unused table is not causing any problem.15:01
blogansamuelbercovici: here15:01
samuelbercoviciis it ok here or we can move to neutron-lbaas15:02
blogansure15:02
rm_workis there a #neutron-lbaas ?15:02
mayuanteaya: ping15:03
mayuanteaya: Is there extra requirement for third-party ml2 driver except for tempest ?15:03
*** yfried has quit IRC15:03
anteayahello15:03
mayuanteaya: it's a long time since last meet15:04
enikanorovavishnoi: what's up?15:04
avishnoienikanorov: Hii15:04
*** dims has quit IRC15:04
enikanorovavishnoi: do you have questions about lbaas?15:05
*** kbringard has quit IRC15:05
avishnoienikanorov: have one query about lbaas15:05
enikanorovselect * from pools ?15:05
avishnoiso i am developing lbaas plugin driver for sdn controller15:05
enikanorovcool15:05
kevinbentonsalv-orlando: ping15:05
mayuanteaya: cool15:05
*** dims has joined #openstack-neutron15:05
salv-orlandohi kevinbenton15:05
kevinbentonsalv-orlando: you marked this bug as ‘fix committed’ https://bugs.launchpad.net/neutron/+bug/131485015:06
avishnoicurrent design is kind of async design, where we create resources (like pool etc) and if that fails we later update the status right ?15:06
kevinbentonsalv-orlando: patch is still in review!15:06
kevinbentonsalv-orlando: too optimistic15:06
anteayamayu: yes it has been a while15:06
kevinbentonsalv-orlando: https://review.openstack.org/#/c/91497/15:06
anteayamayu: have you read this file? http://git.openstack.org/cgit/openstack-infra/config/tree/doc/source/third_party.rst15:06
*** amuller has quit IRC15:07
*** blogan_ has joined #openstack-neutron15:07
salv-orlandoI made a mix up with the other patch in the bug report. Thanks for telling me.15:07
anteayamayu: and I have a change up that we will be discussing at summit before it is included: https://review.openstack.org/#/c/77376/115:07
mayuanteaya: how to make a seesion persistent to a specific site ?15:07
*** blogan has quit IRC15:07
*** dfarrell07 has joined #openstack-neutron15:07
*** mrsnivvel has joined #openstack-neutron15:08
kevinbentonsalv-orlando: i wouldn’t be apposed to you reviewing that patch so it could get committed… :-)15:08
kevinbentonsalv-orlando: 2-line change15:09
*** julim has joined #openstack-neutron15:09
salv-orlandokevinbenton: doing that now15:09
anteayamayu: http://ci.openstack.org/third_party.html15:09
anteayamayu: what do you mean?15:09
*** csd has joined #openstack-neutron15:11
kevinbentonsalv-orlando: thanks15:12
mayuanteaya: my ci is almost ready, I don't know whether extra requirements had been added since I have been here for a long time15:13
*** spligak has quit IRC15:13
*** radez_g0n3 is now known as radez15:13
mayuanteaya: I have not been here for a long time15:13
*** nlahouti has joined #openstack-neutron15:14
mayuanteaya: I agree with you that third-party ci should using utc time for real status15:14
anteayamayu: the requirements were added the 16th of January: http://git.openstack.org/cgit/openstack-infra/config/log/doc/source/third_party.rst15:14
*** mengxd has quit IRC15:14
*** mengxd has joined #openstack-neutron15:15
anteayamayu: thanks, but it isn't a requirement yet15:15
anteayabut I thought I would let you know that the change is in review15:15
anteayamayu: I'm guessing you won't be at summit?15:15
*** arnaud has quit IRC15:16
mayuanteaya: yes15:16
anteayathat is a shame15:16
anteayaI'm looking forward to meeting you15:16
mayuanteaya: welcome to china15:17
anteaya:D15:18
anteayahaven't been out of kowloon yet15:18
*** WaltNik has quit IRC15:18
mayuanteaya: you mean that you stay in hongkong ?15:20
*** cdub has joined #openstack-neutron15:21
*** overlayer has quit IRC15:22
*** markmcclain has joined #openstack-neutron15:22
*** overlayer has joined #openstack-neutron15:24
anteayamayu: yes, for the icehouse summit15:25
*** matsuhas_ has quit IRC15:25
anteayaand I have been to hkg airport several times since15:25
*** matsuhashi has joined #openstack-neutron15:25
anteayait is becoming one of my favourite airports15:25
mayuanteaya: too many people15:26
mayuanteaya: actually I have never been there hk.15:27
anteayathre are a lot of people that is true15:28
anteayaI don't expect every person in china to have been to hk15:28
anteaya:D15:28
*** jaypipes has joined #openstack-neutron15:29
*** terryw has joined #openstack-neutron15:30
mayuanteaya: it is late, see you15:30
*** matsuhashi has quit IRC15:31
*** amarao has quit IRC15:32
anteayamayu: see you15:32
*** _cjones_ has joined #openstack-neutron15:32
anteayamayu: nice to chat15:32
*** otherwiseguy has quit IRC15:33
*** changbl has quit IRC15:33
*** chandan_kumar has quit IRC15:34
*** avishnoi has quit IRC15:35
*** geekinutah has quit IRC15:42
*** amuller has joined #openstack-neutron15:42
*** coolsvap is now known as coolsvap|afk15:43
*** rudrarugge has joined #openstack-neutron15:44
*** alagalah has joined #openstack-neutron15:44
openstackgerritMohammad Banikazemi proposed a change to openstack/neutron: Fixes bugs for requests sent to SDN-VE controller  https://review.openstack.org/8963715:45
*** mayu has quit IRC15:45
HenryGmarkmcclain: hi15:45
*** ramishra has joined #openstack-neutron15:46
*** _cjones_ has quit IRC15:48
*** changbl has joined #openstack-neutron15:48
*** samuelbercovici has quit IRC15:50
*** _cjones_ has joined #openstack-neutron15:53
*** overlayer has quit IRC15:57
*** ramishra has quit IRC15:59
*** sbalukoff has quit IRC15:59
*** dave_tucker is now known as dave_tucker_zzz16:00
*** sbalukoff has joined #openstack-neutron16:00
*** marun_afk is now known as marun16:01
*** markmcclain has quit IRC16:02
marunarmax: ping16:04
marunarmax: I've left a comment on the review.  Feel free to ping me if you'd like to discuss.16:10
marunkevinbenton: ping16:13
*** changbl has quit IRC16:16
*** a_le has joined #openstack-neutron16:18
*** chuckC has quit IRC16:18
*** xuhanp has quit IRC16:18
openstackgerritenikanorov proposed a change to openstack/python-neutronclient: Remove httplib2 from requirements  https://review.openstack.org/9287016:19
*** spandhe has joined #openstack-neutron16:22
*** radez is now known as radez_g0n316:24
kevinbentonmarun: pong16:25
marunkevinbenton: Hi Kevin16:25
marunkevinbenton: I'd like to apologize for being grumpy last night.16:26
kevinbentonmarun: what’s up?16:26
marunkevinbenton: I was wondering if you're interested in using tracemalloc to doublecheck my assumptions about memory usage.16:26
*** ramishra has joined #openstack-neutron16:26
kevinbentonmarun: no need to apologize, you were right about it not being that important16:27
kevinbentonmarun: I won’t be able to over the next couple of days (getting ready for the summit)16:28
kevinbentonmarun: but after that, yes16:28
marunkevinbenton: ok, fair enough.16:28
marunkevinbenton: whenever you'd like.   It took me a little while to get my head around it, but I'm pretty slow.16:28
*** manishg has joined #openstack-neutron16:28
kevinbentonmarun: i just got up, i will try your patch shortly and give feedback16:28
marunkevinbenton: appreciated!16:29
kevinbentonmarun: last time i tried tracemalloc, i was having issues getting it installed on my dev machine16:29
*** radez_g0n3 is now known as radez16:29
marunkevinbenton: ubuntu or fedora?16:29
*** changbl has joined #openstack-neutron16:29
kevinbentonmarun: ubuntu16:29
kevinbentonmarun: 12.0416:29
marunkevinbenton: were you using the ppa or attempting to install from source?16:29
marunkevinbenton: ubuntu's packaged python deviates enough from source python that the ppa is the way to go.  Fedora is saner.16:31
marunthat -> so that16:31
kevinbentonmarun: i think it was ppa and i ran into an error16:31
kevinbentonmarun: let me look16:31
marunkevinbenton: no rush, don't mean to distract.16:32
marunkevinbenton: btw, I found docker really helpful in getting a working system.16:32
*** Longgeek has quit IRC16:32
kevinbentonmarun: i think it was this one https://launchpad.net/~ionel-mc/+archive/pytracemalloc-1.016:32
openstackgerritAssaf Muller proposed a change to openstack/neutron: [2/3] Clean up Neutron resources upon tenant deletion  https://review.openstack.org/9260016:32
openstackgerritAssaf Muller proposed a change to openstack/neutron: [1/3] Clean up Neutron resources upon tenant deletion  https://review.openstack.org/9259916:32
marunkevinbenton: I think that's the one in the docs.16:33
marunkevinbenton: well, no need to debug now but happy to help post-summit.16:33
*** devvesa has quit IRC16:33
kevinbentonmarun: probably conflicting with the other stuff i’ve done to this development machine over the last few months :-)16:33
marunkevinbenton: yeah, docker makes that easier :)16:34
*** geekinutah has joined #openstack-neutron16:34
kevinbentonmarun: i do need to switch to docker16:34
kevinbentonmarun: it’s in a vm now, but that doesn’t really help when i have so many useful things built up on it that i can’t replace it easily16:34
marunkevinbenton: yeah, that's a tricky thing.16:34
marunkevinbenton: transitioning to docker wasn't too hard for me since I've been using puppet+vagrant for a while now to manage disposable vm's16:35
marunkevinbenton: i was flushing vm's with enough regularity that I got in the habit of capturing persistent changes in git or puppet scripts to survive rebuilds16:35
marunkevinbenton: docker just makes the rebuilds cheaper (and execution much faster)16:36
kevinbentonmarun: does it work with OSX as the parent?16:36
marunkevinbenton: there's something called boot2docker that uses a minimal docker-only vm16:36
marunkevinbenton: there's still a speed penalty but it's as good as you can get on os x16:37
marunkevinbenton: I have a beefy server to run docker for now, but honestly I want to move it into the cloud before too long.16:37
marunkevinbenton: now that everyone's going aws the speed penalty of virtualization io might actually be bearable there16:37
marunaws -> ssd16:38
openstackgerritAssaf Muller proposed a change to openstack/neutron: [2/3] Clean up Neutron resources upon tenant deletion  https://review.openstack.org/9260016:38
openstackgerritAssaf Muller proposed a change to openstack/neutron: [1/3] Clean up Neutron resources upon tenant deletion  https://review.openstack.org/9259916:38
*** singhs has joined #openstack-neutron16:38
kevinbentonmarun: doesn’t it get kinda pricey to run a decent instance in AWS all of the time?16:39
marunkevinbenton: i don't work all the time, so don't need to run it all the time :)16:39
*** amuller has quit IRC16:39
*** BillTheKat has joined #openstack-neutron16:40
kevinbentonmarun: that’s what i do when i need to run a full set of tests in a hurry16:40
marunkevinbenton: I'm not saying we're there yet - a home hex core server is definitely faster and cheaper for now.16:41
marunkevinbenton: but I don't think we're that far off.16:41
kevinbentonmarun: i start up the biggest instance possible16:41
marunkevinbenton: tests for neutron?16:41
kevinbentonmarun: and it can chew threw the neutron unit tests in a few minutes16:42
kevinbentonmarun: yeah16:42
marunkevinbenton: a few minutes? wow16:42
marunkevinbenton: it still takes ~11m on my local server16:42
kevinbentonmarun: 32 vcpus and 60GB ram :-)16:42
marunwhat's the hourly cost?16:43
kevinbentonmarun: $1.68. don’t want to forget to stop that one :-)16:43
marunhah16:43
marunkevinbenton: if only they'd start billing by partial hours...16:43
kevinbentonmarun: largest compute instance16:43
*** jpich has quit IRC16:44
kevinbentonmarun: yeah16:44
kevinbentonmarun: just break your work into nice hour-sized chunks ;-)16:45
marunkevinbenton: hah16:45
*** crc32 has joined #openstack-neutron16:45
*** dvorkinista has joined #openstack-neutron16:46
*** dgrig has quit IRC16:48
armaxmarun: here16:49
openstackgerritErik Colnick proposed a change to openstack/neutron: Support 'infinite' dhcp_lease_duration  https://review.openstack.org/9245316:49
marunarmax: does the comment on https://review.openstack.org/#/c/92793/ make sense?16:51
armaxhang on replying...16:51
armaxwouldn't we need to pass self.safe_reference instead?16:52
*** dgollub has quit IRC16:52
armaxmarun: I think I found a few other16:52
armaxs16:52
marunarmax: So cases where the plugin reference is being passed around, potentially creating circular references?16:53
marunarmax: it doesn't appear to be causing problems, but I'm guessing those references don't16:54
marun involve mocking.16:54
openstackgerritA change was merged to openstack/neutron: Fix H302 violations  https://review.openstack.org/8857816:54
armaxmarun: that's what I figured16:54
armaxbut I wonder if it'd be good to sweep them regardles16:55
armaxs16:55
marunarmax: I think it would be good, yes.  Maybe as a follow-up?16:55
armaxmarun: sounds good16:55
armaxmarun: I'll take care of those16:55
marunarmax: do you want to submit it?16:55
marunarmax: great. :)16:55
*** mlavalle has joined #openstack-neutron16:55
*** yfried has joined #openstack-neutron16:56
marunarmax: and if you want to +2 my patch to speed yours along, so much the better ;)16:56
BillTheKatI am trying to get IPV6 working in havana and I am starting with modifiing dhcp.py. I notice that whenever a network contains a subnet with ip_version = 6, the spawn_process in dhcp.py does not get called for that network. Can anyone explain why?16:56
*** banix has quit IRC16:58
openstackgerritA change was merged to openstack/neutron: lbaas on a network without gateway  https://review.openstack.org/8405816:58
*** markmcclain has joined #openstack-neutron16:58
*** chuckC has joined #openstack-neutron17:01
*** harlowja_away is now known as harlowja17:01
*** ramishra has quit IRC17:03
*** rudrarug_ has joined #openstack-neutron17:03
openstackgerritGary Duan proposed a change to openstack/neutron-specs: FWaaS integration with service type framewrok  https://review.openstack.org/9287417:04
*** rudrarugge has quit IRC17:06
*** felux has left #openstack-neutron17:06
*** catohornet1 has joined #openstack-neutron17:06
*** catohornet1 has quit IRC17:07
*** dvorkinista has quit IRC17:09
*** catohornet1 has joined #openstack-neutron17:09
*** dvorkinista has joined #openstack-neutron17:09
*** arnaud has joined #openstack-neutron17:10
*** banix has joined #openstack-neutron17:10
*** catohornet2 has joined #openstack-neutron17:13
*** catohornet1 has quit IRC17:13
*** mestery_ has joined #openstack-neutron17:14
*** mestery has quit IRC17:14
*** mestery_ is now known as mestery17:16
*** terryw is now known as otherwiseguy17:16
*** amcrn has joined #openstack-neutron17:21
*** pcm_ has quit IRC17:26
*** pcm_ has joined #openstack-neutron17:27
openstackgerritA change was merged to openstack/neutron: Reference new get_engine() method from wsgi.py  https://review.openstack.org/9149717:29
*** chuckC has quit IRC17:32
*** kbringard has joined #openstack-neutron17:32
kevinbentonmarun: ping17:38
openstackgerritA change was merged to openstack/neutron: Remove duplicate module-rgx line in .pylintrc  https://review.openstack.org/9222417:39
marunkevinbenton: pong17:42
kevinbentonmarun: found why that UT quit working17:43
kevinbentonmarun: left a comment on the review17:43
marunkevinbenton: looking...17:43
*** dgrig has joined #openstack-neutron17:44
marunkevinbenton: uh17:44
marunkevinbenton: can you explain why it's necessary to add a cleanup when it's already done for every test?17:44
marunkevinbenton: cleanups are only ever run on unittest teardown, so adding an explicit call would just duplicate what is already being done.17:45
kevinbentonmarun: calling self.tearDown() from that test didn’t seem to be invoking it17:46
marunkevinbenton: of course it wasn't invoking it17:46
kevinbentonmarun: why?17:46
marunkevinbenton: functions registered by addCleanup are called after teardown by the test infrastructure17:47
marunkevinbenton: they are never invoked simply because tearDown is called17:47
marunkevinbenton: (another reason explicitly invoking tearDown to try to mimic test tearDown isn't particularly useful)17:47
kevinbentonmarun: i see17:47
*** BuSerD has joined #openstack-neutron17:47
*** spandhe has quit IRC17:48
marunkevinbenton: https://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py#L27617:48
*** spandhe has joined #openstack-neutron17:48
*** chuckC has joined #openstack-neutron17:50
*** thedodd has quit IRC17:50
kevinbentonmarun: so where are those _cleanups called?17:53
*** SumitNaiksatam has joined #openstack-neutron17:53
*** thedodd has joined #openstack-neutron17:54
*** amcrn_ has joined #openstack-neutron17:54
*** mandeep has joined #openstack-neutron17:54
*** mestery has quit IRC17:55
marunkevinbenton: https://github.com/testing-cabal/testtools/blob/master/testtools/runtest.py#L11317:55
*** mestery has joined #openstack-neutron17:55
marunkevinbenton: so, setUp, test method, teardown, then cleanups17:55
*** amcrn has quit IRC17:56
marun_run_setup, _run_test_method, _run_teardown, _run_cleanups17:57
marunkevinbenton: I'm sure there are better docs, I'm just used to looking at the source17:57
kevinbentonmarun: i see. i didn’t even notice we were using unittest17:57
kevinbentonmarun: the similar api fooled me17:57
kevinbentonmarun: https://docs.python.org/2/library/unittest.html#unittest.TestCase.doCleanups17:57
kevinbentonmarun: weren’t*17:57
kevinbentonmarun: didn’t notice we weren’t* using unittest17:58
marunkevinbenton: the behavior is largely the same though the test methods may differ17:58
marunkevinbenton: the cleanup behavior doesn't differ17:59
*** Sukhdev has joined #openstack-neutron17:59
kevinbentonmarun: well that is an important difference17:59
marunkevinbenton: the testtools docs aren't bad actually17:59
kevinbentonmarun: “This method is called unconditionally after tearDown(),”17:59
marunhttp://testtools.readthedocs.org/en/latest/for-test-authors.html17:59
marunkevinbenton: what is an  important difference?17:59
kevinbentonmarun: invoking tearDown() with unit test calls the cleanups18:00
marunkevinbenton: why do you think they differ in that regard?18:00
marunkevinbenton: does 'called unconditionally' imply that calling tearDown calls the cleanups?18:00
kevinbentonmarun: doesn’t it?18:01
marunkevinbenton: to me that reads 'called unconditionally by unittest after unittest calls tearDown'18:01
*** yfried has quit IRC18:02
kevinbentonmarun:18:04
kevinbentonhttp://paste.openstack.org/show/79630/18:05
kevinbentonmarun: here is the output http://paste.openstack.org/show/79632/18:06
marunkevinbenton: huh18:07
*** dgollub has joined #openstack-neutron18:07
marunkevinbenton: good to know18:08
kevinbentonmarun: so i suppose we just can’t support that workflow really at all using testtools18:09
kevinbentonmarun: which is okay becuase it’s kind of hacky18:09
*** BuSerD has quit IRC18:09
*** networks_ has joined #openstack-neutron18:10
*** networks_ has quit IRC18:10
marunkevinbenton: yeah, if I was the reviewer on that patch, where setup and teardown were called in a method, I would not have approved.18:11
kevinbentonmarun: and it looks like my garbagey unit tests  were the only place where self.tearDown() is called18:11
kevinbentonmarun: so all is well18:11
*** BuSerD has joined #openstack-neutron18:11
marunkevinbenton: but I can see why you thought it was safe.  as you've pointed out, unittest and testtools differ fundamentally on this issue18:12
*** beagles is now known as beagles_brb18:12
*** B_Smith__ has joined #openstack-neutron18:13
*** a_le has quit IRC18:13
marunkevinbenton: all being a relative term ;)18:13
*** B_Smith has quit IRC18:13
marunkevinbenton: or well, for that matter18:13
kevinbentonmarun: so back to your patch… is it safe to assume the previous test will have correctly cleaned up the core plugin?18:13
kevinbentonmarun: what if someone overrides setup and doesn’t call super?18:13
*** rudrarug_ has quit IRC18:13
*** tziOm has quit IRC18:13
kevinbentonmarun: so their plugin isn’t cleaned up at teardown18:13
openstackgerritA change was merged to openstack/neutron: Drop service* tables only if they exist  https://review.openstack.org/6943318:14
marunkevinbenton: if the plugin isn't cleared, the test will fail.18:14
*** dgrig has quit IRC18:14
*** mwagner_ has joined #openstack-neutron18:14
marunkevinbenton:18:14
*** markmcclain has quit IRC18:14
marunhttps://review.openstack.org/#/c/92793/2/neutron/tests/base.py18:14
kevinbentonmarun: i’m looking at it18:15
marunsee line 7818:15
kevinbentonmarun: thinking if someone overrides setup18:15
kevinbentonmarun: doesn’t call the super function18:15
kevinbentonmarun: cleanup_core_plugin won’t be added18:15
*** dgrig has joined #openstack-neutron18:16
kevinbentonmarun: or would the unit test not even work since it didn’t call setup up to the base?18:16
marunkevinbenton: but really, line 73 should do it.18:17
*** tziOm has joined #openstack-neutron18:17
marunkevinbenton: line 73 ensures that the manager's reference to the plugin is nullified, as the old setup used to do.18:17
marunkevinbenton: line 78 is the check for whether the plugin was gc'd18:17
marunkevinbenton: if they don't call base setup an error will be raised18:17
*** rudrarugge has joined #openstack-neutron18:17
kevinbentonmarun: ok, so the test would have to be pretty strange to avoid calling cleanup_core_plugin18:19
marunkevinbenton: it would have to try really hard.18:19
marunkevinbenton: and core reviewers should hopefully be able to catch that.18:19
kevinbentonmarun: well you did remove the underscore implying that cleanup_core_plugin is free game for overriding ;-)18:19
*** blogan_ has quit IRC18:19
*** blogan has joined #openstack-neutron18:22
*** morganfainberg_Z is now known as morganfainberg18:22
kevinbentoncarl_baldwin: ping18:22
*** blogan has quit IRC18:22
carl_baldwinkevinbenton: pong18:23
marunkevinbenton: I don't think underscore vs non-underscore make a difference in python18:23
kevinbentoncarl_baldwin: that string you are asking for is already dumped because it’s the exception18:23
marunkevinbenton: at least where external clients are not involved, as in testing.18:24
kevinbentonmarun: it’s a social contract18:24
kevinbentonmarun: otherwise meaningless :-)18:24
marunkevinbenton: single underscore implies that subclasses can override18:24
marunkevinbenton: no underscore implies a public contract18:24
carl_baldwinkevinbenton: Right, because you reraise the exception.  Okay.18:24
marunkevinbenton: since when does it make sense to have a public contract for a test case/18:24
marun?18:24
*** blogan has joined #openstack-neutron18:25
kevinbentonmarun: i misunderstood the underscore then18:25
kevinbentonmarun: i thought it implied you shouldn’t override it because the signature could change later18:25
marunkevinbenton: there is no restriction in python on overriding18:26
marunkevinbenton: at least not from what i understand18:26
marunkevinbenton: but maybe I'm just calcified the wrong way :/18:26
marunkevinbenton: feel free to comment on the review and I'll fix.18:26
kevinbentonmarun: i know that. but i thought the underscores were just used as cues that you are embarking on a dangerous journey18:26
marunkevinbenton: what you say makes sense in general.  I'm not sure how important it is to follow in test cases given that reuse is not a focus, but as you say it probably makes sense to be consistent.18:27
kevinbentonmarun: PEP8 - _single_leading_underscore: weak "internal use" indicator. E.g. from M import * does not import objects whose name starts with an underscore.18:28
kevinbentonmarun: doesn’t say anything about subclassing18:28
kevinbentonmarun: so i misunderstood it18:28
*** yfried has joined #openstack-neutron18:28
kevinbentoncarl_baldwin: how do i do a fixed width column?18:28
*** blogan_ has joined #openstack-neutron18:29
carl_baldwinkevinbenton: I think something like %07d would work.  I won’t hold you to that thought.  Just a thought.18:29
kevinbentonmarun: if you wanted to deter subclasses from override, i suppose you would do the double-underscore for name mangling18:29
carl_baldwinkevinbenton: make that %7d so that it doesn’t include leading zeroes.18:30
kevinbentoncarl_baldwin: so that means take up 7 spaces, right?18:30
carl_baldwinAnd I just pulled 7 out of thin air.18:30
carl_baldwinkevinbenton: right.18:31
carl_baldwinIt will be right-justified as well.18:31
*** markmcclain has joined #openstack-neutron18:31
*** manishg has quit IRC18:34
*** catohornet2 has quit IRC18:34
kevinbentonsalv-orlando: ping18:34
*** catohornet1 has joined #openstack-neutron18:34
*** thedodd has quit IRC18:41
salv-orlandohi kevinbenton18:43
kevinbentonsalv-orlando: i was thinking about the truncated iptables-output. is there a case where the failing line number could be because of a previous line18:44
kevinbentonsalv-orlando: like a chain that was incorrectly defined or something?18:44
*** avishnoi has joined #openstack-neutron18:44
salv-orlandokevinbenton: idk about any of this cases, but there are people who get to such a level a complexity tha thousand of rules go into the chain. anyway I think printing line numbers at least might be useful.18:45
*** otherwiseguy has quit IRC18:45
kevinbentonsalv-orlando: well i already have the truncating logic in there. might as well start with that18:45
salv-orlandok18:46
kevinbentonsalv-orlando: just wanted to see if you knew of any cases off the top of your head that would suck there18:46
kevinbentoncarl_baldwin: do you know of any? ^^18:46
salv-orlandoidk… maybe a -j to a non-existing chain… but you might then argue that the issue is not the rule, but the non-existing chain. Still, there would be nothing to gain there by printing everything18:48
openstackgerritKevin Benton proposed a change to openstack/neutron: Log iptables rules when they fail to apply  https://review.openstack.org/8681018:48
*** dvorkinista has quit IRC18:48
kevinbentonsalv-orlando, carl_baldwin: ok. latest is there ^^18:48
carl_baldwinkevinbenton: running out to lunch.  I will have a look later.18:49
kevinbentoncarl_baldwin: no hurry18:49
openstackgerritArmando Migliaccio proposed a change to openstack/python-neutronclient: blueprint tls-verify replaces httplib2 with requests  https://review.openstack.org/9289218:52
*** leseb has joined #openstack-neutron18:52
*** baoli has quit IRC18:54
*** arnaud has quit IRC18:55
*** xdmeng has joined #openstack-neutron18:57
*** mengxd has quit IRC18:57
*** dvorkinista has joined #openstack-neutron18:59
*** jckasper_ has joined #openstack-neutron19:01
*** jgrimm has quit IRC19:01
*** mandeep has quit IRC19:01
*** jckasper_ has quit IRC19:02
*** dvorkinista has quit IRC19:02
*** openstackgerrit has quit IRC19:04
*** a_le has joined #openstack-neutron19:05
*** openstackgerrit has joined #openstack-neutron19:06
*** amcrn_ has quit IRC19:07
*** dvorkinista has joined #openstack-neutron19:08
*** nplanel has quit IRC19:09
*** mlavalle has quit IRC19:09
haleybkevinbenton: re iptables, if you have a rule like "-A foo -j bar" that causes a failure, it could be because either of those chains don't exist.  If you only print what's around the failure you might not see the chain part19:11
*** nplanel has joined #openstack-neutron19:13
*** dvorkinista has quit IRC19:14
*** rpothier_ has joined #openstack-neutron19:15
*** peristeri has quit IRC19:15
*** arnaud has joined #openstack-neutron19:17
*** leseb has quit IRC19:17
openstackgerritArmando Migliaccio proposed a change to openstack/python-neutronclient: Make neutronclient parse keystone v3 endpoints correctly  https://review.openstack.org/8176719:17
anteayamarun: is this patch https://review.openstack.org/#/c/88289/ related to the patch you were discussing earlier?19:18
openstackgerritArmando Migliaccio proposed a change to openstack/python-neutronclient: Make neutronclient parse keystone v3 endpoints correctly  https://review.openstack.org/8176719:18
*** nplanel has quit IRC19:18
marunanteaya: that's separate - the full tempest run19:19
anteayaokay, just wondering since that patch seems to have stalled19:20
*** arnaud has quit IRC19:21
*** beagles_brb is now known as beagles19:24
*** nplanel has joined #openstack-neutron19:28
*** thedodd has joined #openstack-neutron19:31
*** leseb has joined #openstack-neutron19:32
kevinbentonhaleyb: yeah, that’s what I was thinking. but i suppose for now we can just print what’s around it to see what type of failures we are getting19:47
kevinbentonhaleyb: completely missing chains are so bad that I would hope that scenario would be caught in unit tests before it made it to deployments :-)19:48
haleybkevinbenton: you would think, yes.  Sorry, I did just -1 because of the scope thing, more to get some feedback on your thoughts there19:49
*** nlahouti has quit IRC19:50
*** chuckC has quit IRC19:54
*** leseb has quit IRC19:54
kevinbentonhaleyb: no prob. we’ll see what other feedback comes along19:56
*** otherwiseguy has joined #openstack-neutron19:56
*** markmcclain has quit IRC19:58
*** marun is now known as maru_afk19:58
*** pcm_ has quit IRC19:58
*** pcm_ has joined #openstack-neutron19:58
*** Sukhdev has quit IRC19:59
*** pcm_ has quit IRC19:59
salv-orlandovpn team… this is for you: http://paste.openstack.org/show/79643/20:00
salv-orlandoa long list of bugs to triage20:00
*** nplanel has quit IRC20:00
*** spandhe has quit IRC20:00
*** dave_tucker_zzz is now known as dave_tucker20:01
*** catohornet1 has quit IRC20:01
*** markmcclain has joined #openstack-neutron20:01
*** markmcclain1 has joined #openstack-neutron20:03
*** manishg has joined #openstack-neutron20:04
enikanorovsalv-orlando: i wonder if I am the chosen one by paste.openstack.org to show me 503...20:06
*** markmcclain has quit IRC20:06
*** dgollub has quit IRC20:06
salv-orlandoI'm getting errors as well20:06
salv-orlandoI had to try twice before creating the paste20:06
*** dgollub has joined #openstack-neutron20:06
*** julim has quit IRC20:08
*** spandhe has joined #openstack-neutron20:08
*** arborism has joined #openstack-neutron20:16
*** alex_klimov has joined #openstack-neutron20:19
*** baoli has joined #openstack-neutron20:21
*** rkukura has quit IRC20:22
*** jgrimm has joined #openstack-neutron20:26
*** avishnoi has quit IRC20:26
*** rkukura has joined #openstack-neutron20:26
salv-orlandorandom question: do we have a RPC versioning protocol for removing methods20:30
salv-orlandothis is re bug: 131453420:30
*** arborism is now known as amcrn20:30
*** scotty95747 has joined #openstack-neutron20:32
*** dgollub1 has joined #openstack-neutron20:32
*** dgollub1 has quit IRC20:33
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: Ensure changed_device_id is initialized in update_port  https://review.openstack.org/9290920:34
*** scott-millward has quit IRC20:34
*** dgollub has quit IRC20:34
*** lukego has quit IRC20:42
*** avishnoi has joined #openstack-neutron20:42
*** dave_tucker is now known as dave_tucker_zzz20:43
*** jecarey has quit IRC20:44
*** doude has joined #openstack-neutron20:50
*** christophk_ has quit IRC20:52
*** arnaud has joined #openstack-neutron20:55
*** jecarey has joined #openstack-neutron20:56
*** mlavalle has joined #openstack-neutron20:58
*** avishnoi has quit IRC21:01
openstackgerritPierre Rognant proposed a change to openstack/neutron: Add an option to turn off DF for GRE and VXLAN tunnels  https://review.openstack.org/7528121:07
openstackgerritCarl Baldwin proposed a change to openstack/neutron-specs: DNS resolution inside of Neutron using Nova instance name  https://review.openstack.org/8862321:08
*** lukego has joined #openstack-neutron21:09
*** mwagner_ has quit IRC21:10
*** alagalah has quit IRC21:11
*** evilstephen has quit IRC21:11
*** puck has quit IRC21:11
openstackgerritPierre Rognant proposed a change to openstack/neutron: Add an option to turn off DF for GRE and VXLAN tunnels  https://review.openstack.org/7528121:15
*** TrevorV has quit IRC21:19
*** doude has quit IRC21:22
*** baoli has quit IRC21:24
*** baoli has joined #openstack-neutron21:25
*** dgollub has joined #openstack-neutron21:26
*** evilstephen has joined #openstack-neutron21:27
*** lukego has quit IRC21:30
*** alagalah has joined #openstack-neutron21:32
*** gdubreui has joined #openstack-neutron21:33
*** rpothier_ has quit IRC21:34
*** puck has joined #openstack-neutron21:38
*** beagles has quit IRC21:38
*** WackoRobie has quit IRC21:38
*** b3nt_pin has joined #openstack-neutron21:42
*** dave_tucker_zzz is now known as dave_tucker21:42
*** kfox1111 has joined #openstack-neutron21:43
kfox1111running into a strange problem. I have to restart the l3-agent before floating-ip changes take affect. Know what might cause this?21:43
*** xdmeng has quit IRC21:44
*** mengxd has joined #openstack-neutron21:44
*** mrsnivvel has quit IRC21:45
*** b3nt_pin is now known as beagles21:53
*** catohornet1 has joined #openstack-neutron21:54
*** alagalah has quit IRC21:57
*** terryw has joined #openstack-neutron21:58
*** gus_ has joined #openstack-neutron21:59
*** otherwiseguy has quit IRC22:00
*** jobewan has quit IRC22:05
*** markmcclain1 has quit IRC22:06
*** kbringard has quit IRC22:06
*** dvorkinista has joined #openstack-neutron22:06
*** rudrarugge has quit IRC22:12
*** dvorkinista has quit IRC22:12
*** chuckC has joined #openstack-neutron22:14
*** oda-g has joined #openstack-neutron22:14
*** gus_ has quit IRC22:14
*** gus_ has joined #openstack-neutron22:18
*** jorgem has quit IRC22:20
*** dims has quit IRC22:23
*** jgrimm has quit IRC22:24
*** cgascoig has joined #openstack-neutron22:25
*** prad__ has left #openstack-neutron22:27
*** jckasper has joined #openstack-neutron22:28
*** BillTheKat has quit IRC22:28
*** baoli has quit IRC22:28
*** cgascoig has quit IRC22:29
*** arnaud has quit IRC22:30
*** nplanel_ has joined #openstack-neutron22:30
*** maru_afk is now known as marun22:32
*** mwagner_ has joined #openstack-neutron22:35
*** markmcclain has joined #openstack-neutron22:36
*** banix has quit IRC22:36
*** alex_klimov has quit IRC22:37
*** gizmoguy has quit IRC22:39
*** terryw has quit IRC22:40
*** erecio has quit IRC22:42
*** arnaud has joined #openstack-neutron22:42
*** catohornet2 has joined #openstack-neutron22:45
*** armax has left #openstack-neutron22:45
*** alagalah has joined #openstack-neutron22:46
*** catohornet1 has quit IRC22:47
openstackgerritKevin Benton proposed a change to openstack/neutron: Revert "Big Switch: Check source_address attribute exists"  https://review.openstack.org/9293022:50
openstackgerritPierre Rognant proposed a change to openstack/neutron: Add an option to turn off DF for GRE and VXLAN tunnels  https://review.openstack.org/7528122:51
openstackgerritKevin Benton proposed a change to openstack/neutron: Revert "Big Switch: Check source_address attribute exists"  https://review.openstack.org/9293022:52
*** catohornet1 has joined #openstack-neutron22:53
*** catohornet2 has quit IRC22:56
*** gizmoguy has joined #openstack-neutron22:57
*** cgascoig has joined #openstack-neutron23:00
*** markmcclain has quit IRC23:02
*** WackoRobie has joined #openstack-neutron23:02
*** mengxd has quit IRC23:03
*** blogan has quit IRC23:03
*** WackoRob_ has joined #openstack-neutron23:04
*** cgascoig has quit IRC23:05
*** WackoRobie has quit IRC23:06
*** arnaud has quit IRC23:09
*** radez is now known as radez_g0n323:11
*** markmcclain has joined #openstack-neutron23:17
*** carl_baldwin has quit IRC23:23
*** radez_g0n3 is now known as radez23:24
*** marun is now known as maru_afk23:24
*** maru_afk has quit IRC23:25
*** marun has joined #openstack-neutron23:25
*** marun has quit IRC23:26
*** marun has joined #openstack-neutron23:27
*** cgascoig has joined #openstack-neutron23:28
*** gus_ has quit IRC23:30
*** gus_ has joined #openstack-neutron23:32
*** cgascoig has quit IRC23:33
*** alagalah has quit IRC23:34
openstackgerritKevin Benton proposed a change to openstack/neutron: Big Switch: Check source_address attribute exists  https://review.openstack.org/9293823:34
*** jckasper_ has joined #openstack-neutron23:37
*** jckasper has quit IRC23:37
*** morganfainberg is now known as morganfainberg_Z23:38
*** alagalah has joined #openstack-neutron23:42
*** alagalah has joined #openstack-neutron23:43
openstackgerritRyan Moe proposed a change to openstack/neutron: Make pid file locking non-blocking  https://review.openstack.org/9189023:45
*** arnaud has joined #openstack-neutron23:45
*** thedodd has quit IRC23:47
*** iwamoto has joined #openstack-neutron23:47
*** morganfainberg_Z is now known as morganfainberg23:49
*** WackoRob_ has quit IRC23:50
*** WackoRobie has joined #openstack-neutron23:52
openstackgerritSumit Naiksatam proposed a change to openstack/neutron-specs: Advanced Services Common Framework  https://review.openstack.org/9220023:53
*** markmcclain has quit IRC23:54
openstackgerritSumit Naiksatam proposed a change to openstack/neutron-specs: Advanced Network Services Common Framework  https://review.openstack.org/9220023:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!