Wednesday, 2014-03-19

*** spandhe has quit IRC00:03
*** SridharG has quit IRC00:04
*** jorgem has quit IRC00:11
*** matsuhashi has joined #openstack-neutron00:20
openstackgerritDane LeBlanc proposed a change to openstack/neutron: Cisco Nexus: maximum recursion error in ConnectionContext.__del__  https://review.openstack.org/8073700:20
*** mwagner_lap has joined #openstack-neutron00:21
openstackgerritDane LeBlanc proposed a change to openstack/neutron: Cisco plugin fails with ParseError no elem found  https://review.openstack.org/8130400:21
*** leseb_ has joined #openstack-neutron00:22
openstackgerritEvgeny Fedoruk proposed a change to openstack/neutron: Cancelling thread start while unit tests running  https://review.openstack.org/8132300:23
*** ijw has joined #openstack-neutron00:23
*** zhipeng has quit IRC00:24
*** SumitNaiksatam has quit IRC00:24
*** alagalah has quit IRC00:25
*** hogepodge has joined #openstack-neutron00:25
hogepodgeI have a python neutron client question.00:25
*** ijw_ has joined #openstack-neutron00:26
hogepodgeWhat input is the client expecting for this command: /usr/bin/neutron subnet-update 192.168.22.0/24 --host-routes list=true {'destination': '10.10.10.10/24','nexthop': '8.8.8.8'} 192.168.22.0/2400:26
hogepodgeIt returns  Invalid input for host_routes. Reason: Invalid input. '{'destination': '10.10.10.10/24','nexthop': '8.8.8.8'}' must be a dictionary with keys: ['destination', 'nexthop'].00:27
hogepodgeI can't for the life of me figure out how to enter a dictionary on the command line.00:27
*** leseb_ has quit IRC00:27
*** yfried1 has quit IRC00:27
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: NSX plugin: return 400 for invalid gw certificate  https://review.openstack.org/8094800:28
*** ijw has quit IRC00:29
oda-ghogepodge: --host_routes type=dict list=true distination=10.10.10.10/24,nexthop=8.8.8.8 distination=11.11.11.11/24,nexthop=9.9.9.900:33
hogepodgeThanks! oda-g00:35
*** manishg has quit IRC00:35
*** dvorkini_ has quit IRC00:37
*** overlayer has quit IRC00:39
*** samuelbercovici has quit IRC00:40
*** blogan has quit IRC00:40
*** thuc has quit IRC00:42
*** thuc has joined #openstack-neutron00:42
*** blogan_ has joined #openstack-neutron00:46
*** thuc has quit IRC00:47
*** yamahata has quit IRC00:47
*** devlaps has quit IRC00:52
*** mwagner__ has joined #openstack-neutron00:56
*** spandhe has joined #openstack-neutron00:56
*** dguitarbite has quit IRC01:09
*** bada has quit IRC01:25
*** bada has joined #openstack-neutron01:26
*** alagalah has joined #openstack-neutron01:35
*** sfox has joined #openstack-neutron01:36
openstackgerritAkihiro Motoki proposed a change to openstack/python-neutronclient: Work around pypy testing issue  https://review.openstack.org/8141301:38
*** amotoki has joined #openstack-neutron01:38
*** xuhanp has joined #openstack-neutron01:38
*** _cjones_ has quit IRC01:39
*** _cjones_ has joined #openstack-neutron01:39
*** alagalah has quit IRC01:40
*** blogan_ has quit IRC01:41
*** _cjones_ has quit IRC01:44
oda-gamotoki: ping01:45
*** ijw_ has quit IRC01:45
*** thuc has joined #openstack-neutron01:52
*** thuc_ has joined #openstack-neutron01:57
*** dkehn has quit IRC01:58
*** thuc has quit IRC01:59
*** dave_tucker is now known as dave_tucker_zzz02:03
*** sfox has quit IRC02:06
*** dkehn has joined #openstack-neutron02:07
*** yamahata has joined #openstack-neutron02:07
openstackgerritAbhishek Raut proposed a change to openstack/neutron: Add missing ondelete option to Cisco N1kv tables  https://review.openstack.org/8141902:11
*** thuc has joined #openstack-neutron02:11
*** thuc_ has quit IRC02:12
*** thuc_ has joined #openstack-neutron02:12
amotokioda-g: pong02:14
oda-gamotoki: would you pick up to review https://review.openstack.org/#/c/79858/ which needs one more +2 ?02:15
*** thuc_ has quit IRC02:15
*** thuc has quit IRC02:16
*** thuc has joined #openstack-neutron02:16
oda-gamotoki: generally speaking, when a fix is not reviewed for a long time, what should I do ?02:16
*** sweston has quit IRC02:17
amotokioda-g: just looked at it. I have one question.02:21
amotokioda-g: can't metaplugin terminate RPC call and redispatch it to each plugin? I am not sure we can.02:21
oda-gamotoki: it is possible technically, but need large amount of code writing.02:23
*** thuc_ has joined #openstack-neutron02:24
*** sfox has joined #openstack-neutron02:26
amotokioda-g: I am not sure what is "many environment". Do you assume a case where the one plugin is agent-based plugin and the other is controller-based plugin?02:26
amotokioda-g: if so this looks reasonable.02:26
oda-gamotoki: and need to modify each plugin, so that it is not comsume rpc queue.02:27
*** thuc has quit IRC02:27
*** sbalukoff has quit IRC02:28
*** shakamunyi has joined #openstack-neutron02:28
amotokioda-g: I understand it. to do so, we need to take care of sending RPC from plugin to agent.02:28
*** devlaps has joined #openstack-neutron02:29
*** thuc_ has quit IRC02:29
amotokioda-g: At least "many env" is a bit confusing. I would suggest on what case this solution works more precisely.02:29
amotokioda-g: i will add a comment on your review.02:29
*** singhs has joined #openstack-neutron02:30
oda-gamotoki: "many environment": yes, you mentioned is one example.02:30
oda-gamotoki: thanks for your review.02:31
openstackgerritIan Wienand proposed a change to openstack/neutron: Record and log reason for dhcp agent resync  https://review.openstack.org/8117302:32
*** sfox has quit IRC02:34
*** chandan_kumar has joined #openstack-neutron02:37
*** coolsvap has quit IRC02:39
*** SridharG has joined #openstack-neutron02:43
*** suresh12 has quit IRC02:43
*** markwash has quit IRC02:45
*** Jianyong has joined #openstack-neutron02:48
openstackgerritXu Han Peng proposed a change to openstack/neutron: Permit ICMPv6 RAs only from known routers  https://review.openstack.org/7225202:51
*** jecarey has joined #openstack-neutron02:52
*** gdubreui has quit IRC02:53
openstackgerritAkihiro Motoki proposed a change to openstack/neutron: Mock agent RPC for FWaaS tests to delete DB objs  https://review.openstack.org/7845702:58
openstackgerritAkihiro Motoki proposed a change to openstack/neutron: Ensure to count firewalls in target tenant  https://review.openstack.org/8071502:58
*** dguitarbite has joined #openstack-neutron03:08
*** thuc has joined #openstack-neutron03:12
*** matsuhashi has quit IRC03:13
*** changbl has joined #openstack-neutron03:17
*** sweston has joined #openstack-neutron03:17
*** matsuhashi has joined #openstack-neutron03:20
*** SumitNaiksatam has joined #openstack-neutron03:22
*** sfox has joined #openstack-neutron03:23
*** harlowja is now known as harlowja_away03:23
*** matsuhashi has quit IRC03:25
*** jecarey has quit IRC03:26
*** yfried has joined #openstack-neutron03:26
*** sfox1 has joined #openstack-neutron03:29
*** devlaps has quit IRC03:30
*** sfox has quit IRC03:32
openstackgerritoda-g proposed a change to openstack/neutron: Enable to select an RPC handling plugin under Metaplugin  https://review.openstack.org/7985803:34
*** thuc has quit IRC03:35
*** thuc has joined #openstack-neutron03:35
*** thuc has quit IRC03:40
*** chandan_kumar has quit IRC03:41
*** SridharG has quit IRC03:43
*** spandhe has quit IRC03:45
*** spandhe has joined #openstack-neutron03:47
*** spandhe has quit IRC03:48
*** banix has joined #openstack-neutron03:50
*** spandhe has joined #openstack-neutron03:51
*** dguitarbite has quit IRC03:52
*** spandhe has quit IRC03:54
*** vkozhukalov_ has joined #openstack-neutron03:55
*** matrohon has quit IRC03:58
*** matrohon has joined #openstack-neutron03:59
*** ramishra has joined #openstack-neutron04:00
*** thuc has joined #openstack-neutron04:03
openstackgerritshihanzhang proposed a change to openstack/neutron: Prevent dhcp port deletion from the API  https://review.openstack.org/7380204:08
*** blogan has joined #openstack-neutron04:18
*** matsuhashi has joined #openstack-neutron04:23
*** _cjones_ has joined #openstack-neutron04:31
*** _cjones_ has quit IRC04:35
*** banix has quit IRC04:36
*** thuc has quit IRC04:37
*** thuc has joined #openstack-neutron04:38
*** blogan has quit IRC04:39
*** thuc has quit IRC04:42
*** networkstatic has quit IRC04:48
*** sbalukoff has joined #openstack-neutron04:48
*** dguitarbite has joined #openstack-neutron04:57
openstackgerritfumihiko kakuma proposed a change to openstack/neutron: OFA agent: use hexadecimal IP address in tunnel port name  https://review.openstack.org/8143604:57
*** arosen1 has quit IRC05:01
*** _cjones_ has joined #openstack-neutron05:03
openstackgerritA change was merged to openstack/neutron: Kill 'Skipping unknown group key: firewall_driver' log trace  https://review.openstack.org/8037905:04
*** _cjones_ has quit IRC05:10
*** sbalukoff1 has joined #openstack-neutron05:20
*** sbalukoff has quit IRC05:20
*** arosen1 has joined #openstack-neutron05:21
*** xianghui has joined #openstack-neutron05:26
*** yfried has quit IRC05:30
openstackgerritAkihiro Motoki proposed a change to openstack/python-neutronclient: Support packet_filter extension in NEC plugin  https://review.openstack.org/4986905:32
*** irenab has joined #openstack-neutron05:33
*** dguitarbite has quit IRC05:40
*** thuc has joined #openstack-neutron05:48
*** pradipta_away is now known as pradipta05:51
*** thuc has quit IRC05:53
*** tomoe_ has joined #openstack-neutron05:53
*** saju_m has joined #openstack-neutron05:58
*** matsuhashi has quit IRC05:59
*** matsuhashi has joined #openstack-neutron06:01
*** nati_ueno has joined #openstack-neutron06:03
*** ramishra has quit IRC06:03
*** _cjones_ has joined #openstack-neutron06:04
*** Jabadia has joined #openstack-neutron06:07
*** gdubreui has joined #openstack-neutron06:08
*** _cjones_ has quit IRC06:09
*** SridharG has joined #openstack-neutron06:10
*** ramishra has joined #openstack-neutron06:12
*** tomoe_ has quit IRC06:12
oda-gamotoki: I fixed the commit message of https://review.openstack.org/#/c/79858/ please check.06:13
openstackgerritfumihiko kakuma proposed a change to openstack/neutron: OFA agent: use hexadecimal IP address in tunnel port name  https://review.openstack.org/8143606:15
*** arosen1 has quit IRC06:15
openstackgerritshihanzhang proposed a change to openstack/neutron: Prevent dhcp port deletion from the API  https://review.openstack.org/7380206:16
openstackgerritKevin Benton proposed a change to openstack/neutron: Allow CIDRs with non-zero masked portions  https://review.openstack.org/8113706:26
*** nati_uen_ has joined #openstack-neutron06:28
*** nati_ueno has quit IRC06:31
*** yfried has joined #openstack-neutron06:32
*** gongysh has joined #openstack-neutron06:33
*** nati_uen_ has quit IRC06:38
*** arosen1 has joined #openstack-neutron06:40
openstackgerritfumihiko kakuma proposed a change to openstack/neutron: Fix the "OVS agent loop slowdown" problem for OFAgent  https://review.openstack.org/8086406:44
openstackgerritgongysh proposed a change to openstack/neutron: return false or true according to binding result  https://review.openstack.org/8145706:45
*** matsuhashi has quit IRC06:47
openstackgerritliusheng proposed a change to openstack/neutron: Remove vi modelines  https://review.openstack.org/8021306:48
*** gdubreui has quit IRC06:48
*** tomoe_ has joined #openstack-neutron06:49
*** matsuhashi has joined #openstack-neutron06:50
*** amritanshu_RnD has joined #openstack-neutron06:50
*** amritanshu_RnD is now known as Guest7227706:50
*** irenab has quit IRC06:51
*** ramishra has quit IRC06:52
*** _cjones_ has joined #openstack-neutron06:52
*** _cjones_ has quit IRC06:56
*** _cjones_ has joined #openstack-neutron06:56
*** singhs has quit IRC07:00
*** irenab has joined #openstack-neutron07:00
*** _cjones_ has quit IRC07:01
*** gongysh has quit IRC07:04
*** gongysh has joined #openstack-neutron07:04
*** oda-g has quit IRC07:07
*** arosen1 has quit IRC07:13
*** Akshik_ has joined #openstack-neutron07:14
Akshik_are there any troubleshooting guide for fixing the vm ips reachability issue with neutron07:14
*** ramishra has joined #openstack-neutron07:15
*** arosen1 has joined #openstack-neutron07:19
*** bada has quit IRC07:25
*** bada has joined #openstack-neutron07:26
gongyshAkshik: are u using openvswitch?07:26
*** ramishra has quit IRC07:29
*** matsuhashi has quit IRC07:30
*** gongysh has quit IRC07:30
*** matsuhashi has joined #openstack-neutron07:31
*** gongysh has joined #openstack-neutron07:31
*** carl_baldwin has joined #openstack-neutron07:36
*** morganfainberg is now known as morganfainberg_Z07:43
*** arosen1 has quit IRC07:44
*** tomoe_ has quit IRC07:47
openstackgerritXu Han Peng proposed a change to openstack/python-neutronclient: Create new IPv6 attributes for Subnets by client  https://review.openstack.org/7587107:48
*** ramishra has joined #openstack-neutron07:52
*** nati_ueno has joined #openstack-neutron07:55
openstackgerritNachi Ueno proposed a change to openstack/neutron: Add enable_security_group option  https://review.openstack.org/6728107:55
*** tomoe_ has joined #openstack-neutron07:57
*** ajo has joined #openstack-neutron08:00
*** gongysh has quit IRC08:01
*** gongysh has joined #openstack-neutron08:01
*** ajo has quit IRC08:04
*** ajo has joined #openstack-neutron08:04
*** shakamunyi has quit IRC08:07
*** tomoe_ has quit IRC08:07
openstackgerritBerezovsky Irena proposed a change to openstack/neutron: Add update binding:profile with physical_network  https://review.openstack.org/8128108:09
openstackgerritAkihiro Motoki proposed a change to openstack/neutron: NEC plugin: Honor Retry-After response from OFC  https://review.openstack.org/8147208:10
*** leseb_ has joined #openstack-neutron08:15
openstackgerritgongysh proposed a change to openstack/neutron: use floatingip's ID as key instead of itself  https://review.openstack.org/8147408:17
*** jgallard has joined #openstack-neutron08:21
*** leseb_ has quit IRC08:22
*** leseb_ has joined #openstack-neutron08:22
openstackgerritDarragh O'Reilly proposed a change to openstack/neutron: lb-agent: reduce delete_vlan_bridge() logging severity  https://review.openstack.org/7599308:24
*** leseb_ has quit IRC08:27
*** tomoe_ has joined #openstack-neutron08:29
*** gongysh has quit IRC08:32
*** gongysh has joined #openstack-neutron08:33
*** shakamunyi has joined #openstack-neutron08:33
openstackgerritZang MingJie proposed a change to openstack/neutron: Ensure host_routes order in subnet  https://review.openstack.org/7894608:35
*** chandankumar_ has quit IRC08:37
*** shakamunyi has quit IRC08:38
openstackgerritOleg Bondarev proposed a change to openstack/neutron: Sync excutils from oslo  https://review.openstack.org/8148008:39
*** chandan_kumar has joined #openstack-neutron08:39
*** tomoe_ has quit IRC08:41
*** jlibosva has joined #openstack-neutron08:44
*** jlibosva has quit IRC08:45
*** tomoe_ has joined #openstack-neutron08:46
*** djoreilly has joined #openstack-neutron08:50
*** yamahata has quit IRC08:51
Akshik_gongysh: yes I'm using openvswitch only08:51
*** vkozhukalov_ has quit IRC08:55
*** tomoe_ has quit IRC08:55
gongyshAkshik: first make sure the GRE is passing through ok if you are using GRE08:56
*** afazekas has joined #openstack-neutron08:56
gongyshAkshik:  then make sure  all ovs tag and ofport are configured well. no ovs ports are tagged as 4095, and ovs ports starting with 'tap' and 'qr-' must have ofport set well08:58
gongyshAkshik: then make sure the number of interfaces in qdhcp name spaces should be one except the 'lo'.08:59
gongyshAkshik: then check the dnsmasq is running08:59
*** safchain has joined #openstack-neutron09:01
openstackgerritOleg Bondarev proposed a change to openstack/neutron: Sync excutils from oslo  https://review.openstack.org/8148009:03
*** markmcclain has joined #openstack-neutron09:03
*** jlibosva has joined #openstack-neutron09:04
obondarevamotoki:  ping09:06
*** ygbo has joined #openstack-neutron09:06
amotokiobondarev: pong09:07
obondarevamotoki: fixed commit message in https://review.openstack.org/#/c/81480/ Can you pleae check?09:07
obondarevamotoki: Thanks!09:07
amotokiobondarev: i just checked it and +2'ed :-)09:07
obondarevamotoki: yeah :)09:08
amotokiobondarev: we can clean up log messages now :)09:08
obondarevamotoki: what do you mean?09:08
amotokiobondarev: what I mean is that some save_and_reraise need to be update to pass reraise=False in constructors09:10
amotokito avoid unintended log message (drop the original exceptions).09:11
obondarevamotoki: ah, gotcha. Yes, this is what I'm going to do next09:11
obondarevamotoki: for some reason I read 'log messages' as 'commit messages' in your message :)09:13
*** roeyc has joined #openstack-neutron09:13
*** carl_baldwin has quit IRC09:14
*** tomoe_ has joined #openstack-neutron09:19
*** gongysh has quit IRC09:22
openstackgerritIhar Hrachyshka proposed a change to openstack/neutron: Synced rpc and gettextutils modules from oslo-incubator  https://review.openstack.org/8099809:23
*** gongysh has joined #openstack-neutron09:23
*** jgallard has quit IRC09:23
*** jgallard has joined #openstack-neutron09:24
*** amotoki has quit IRC09:26
*** tomoe_ has quit IRC09:29
*** leseb_ has joined #openstack-neutron09:33
*** nati_ueno has quit IRC09:33
*** nati_ueno has joined #openstack-neutron09:34
*** shakamunyi has joined #openstack-neutron09:34
*** leseb_ has quit IRC09:37
*** jp_at_hp has joined #openstack-neutron09:38
*** shakamunyi has quit IRC09:38
*** nati_ueno has quit IRC09:38
*** gongysh has quit IRC09:41
*** tomoe_ has joined #openstack-neutron09:44
*** nati_ueno has joined #openstack-neutron09:47
*** overlayer has joined #openstack-neutron09:49
openstackgerritA change was merged to openstack/neutron: Stop removing ip allocations on port delete  https://review.openstack.org/8119609:52
*** Jabadia_ has joined #openstack-neutron09:54
*** Matt2 has quit IRC09:55
*** Jabadia has quit IRC09:57
openstackgerritClaudiu Belu proposed a change to openstack/neutron: Fixes the Hyper-V agent individual ports metrics  https://review.openstack.org/7879509:57
*** tomoe_ has quit IRC10:02
openstackgerritjun xie proposed a change to openstack/neutron: Use different name for the same constraint  https://review.openstack.org/8148810:07
*** roeyc has quit IRC10:09
openstackgerritjun xie proposed a change to openstack/neutron: Use different name for the same constraint  https://review.openstack.org/8148810:10
*** pcm_ has joined #openstack-neutron10:12
*** pcm_ has quit IRC10:13
*** tomoe_ has joined #openstack-neutron10:14
*** pcm_ has joined #openstack-neutron10:14
*** ramishra has quit IRC10:21
*** ramishra has joined #openstack-neutron10:22
*** ramishra has quit IRC10:22
*** Jianyong has quit IRC10:26
*** gdubreui has joined #openstack-neutron10:33
*** vkozhukalov_ has joined #openstack-neutron10:33
*** shakamunyi has joined #openstack-neutron10:35
*** shakamunyi has quit IRC10:39
*** ramishra has joined #openstack-neutron10:42
obondarevamotoki: ping10:46
*** rotbeard has joined #openstack-neutron10:50
*** bada_ has joined #openstack-neutron10:58
*** bada has quit IRC11:00
markmcclainsdague: this merged about an hour ago https://review.openstack.org/81196 should address top bug in gate11:02
sdaguemarkmcclain: great11:02
markmcclainI am concerned about 124875711:05
markmcclainsdague: ^ has seen a sharp increase in last 24hrs11:06
*** nati_ueno has quit IRC11:06
*** ramishra has quit IRC11:07
*** baoli has quit IRC11:08
*** baoli has joined #openstack-neutron11:13
*** baoli has quit IRC11:14
*** tomoe_ has quit IRC11:15
openstackgerritLi Ma proposed a change to openstack/neutron: Race condition of L3-agent to add/remove routers  https://review.openstack.org/7323411:16
openstackgerritLi Ma proposed a change to openstack/neutron: Race condition of L3-agent to add/remove routers  https://review.openstack.org/7323411:18
*** jgallard has quit IRC11:18
obondarevmarkmcclain: per Salvatore's comment on 1248757  it has a chance to be fixed with  https://review.openstack.org/81196 as well.11:19
markmcclainobondarev: right just concerned that it reappeared11:19
*** matsuhashi has quit IRC11:22
*** matsuhashi has joined #openstack-neutron11:24
*** Jabadia has joined #openstack-neutron11:31
*** Jabadia_ has quit IRC11:31
*** Matt2 has joined #openstack-neutron11:31
*** Jabadia has quit IRC11:34
*** safchain has quit IRC11:35
*** Jabadia has joined #openstack-neutron11:35
*** shakamunyi has joined #openstack-neutron11:36
*** markmcclain has quit IRC11:36
*** matsuhashi has quit IRC11:37
*** shakamunyi has quit IRC11:40
*** Jabadia has quit IRC11:40
openstackgerritLi Ma proposed a change to openstack/neutron: Race condition of L3-agent to add/remove routers  https://review.openstack.org/7323411:40
*** Jabadia has joined #openstack-neutron11:41
*** Jabadia_ has joined #openstack-neutron11:41
*** xuhanp has quit IRC11:42
*** Jabadia has quit IRC11:45
*** yfried has quit IRC11:46
*** rook has joined #openstack-neutron11:46
*** overlayer has quit IRC11:53
*** yfried has joined #openstack-neutron12:03
openstackgerritLi Ma proposed a change to openstack/neutron: Race condition of L3-agent to add/remove routers  https://review.openstack.org/7323412:07
*** roeyc has joined #openstack-neutron12:11
*** Guest72277 has quit IRC12:12
*** Atti has joined #openstack-neutron12:14
*** pradipta is now known as pradipta_away12:14
sdagueso that fingerprint is actually kind of terrible, because it's not the issue12:19
openstackgerritPaul Michali proposed a change to openstack/neutron: Cisco VPN device driver post-merge cleanup  https://review.openstack.org/8006212:19
*** salv-orlando has quit IRC12:21
*** chandan_kumar has quit IRC12:23
*** gdubreui has quit IRC12:23
*** Akshik_ has quit IRC12:26
*** Jabadia has joined #openstack-neutron12:29
*** Jabadia_ has quit IRC12:29
*** jecarey has joined #openstack-neutron12:33
*** leseb_ has joined #openstack-neutron12:33
*** shakamunyi has joined #openstack-neutron12:36
*** Jabadia has quit IRC12:38
*** Jabadia has joined #openstack-neutron12:39
*** leseb_ has quit IRC12:40
*** leseb_ has joined #openstack-neutron12:41
*** shakamunyi has quit IRC12:41
*** leseb_ has quit IRC12:42
*** leseb_ has joined #openstack-neutron12:42
*** Jabadia has quit IRC12:43
*** Jabadia has joined #openstack-neutron12:44
*** xianghui has quit IRC12:46
*** subhranshu has joined #openstack-neutron12:48
subhranshuHi team,  need some help in neutron scalability12:49
*** amuller has joined #openstack-neutron12:50
subhranshuWe are planning to deploy 1000 VM with FWaaS and LBaaS using Neuton and not sure how shall we calculate how many neutron network nodes would we be needing to start with12:50
*** dims has quit IRC12:50
subhranshuhelp on this will be highly appreciated12:50
*** chandan_kumar has joined #openstack-neutron12:56
*** thuc has joined #openstack-neutron12:57
*** thuc_ has joined #openstack-neutron12:58
*** tomoe_ has joined #openstack-neutron13:00
*** thuc has quit IRC13:01
subhranshuCould some one have any Idea how can we do calculations for neutron scaling13:02
*** baoli has joined #openstack-neutron13:04
*** salv-orlando has joined #openstack-neutron13:11
*** julim has joined #openstack-neutron13:12
*** safchain has joined #openstack-neutron13:13
*** jgallard has joined #openstack-neutron13:15
*** xuhanp has joined #openstack-neutron13:15
*** yfried has quit IRC13:17
*** subhranshu has quit IRC13:21
*** mwagner_lap is now known as mwagner_dontUseM13:25
*** yfried has joined #openstack-neutron13:26
*** mwagner__ has quit IRC13:30
*** Atti has quit IRC13:35
openstackgerritAnn Kamyshnikova proposed a change to openstack/neutron: WIP Implement test  https://review.openstack.org/7652013:35
openstackgerritAnn Kamyshnikova proposed a change to openstack/neutron: WIP Add testing for database from oslo  https://review.openstack.org/7651913:35
*** safchain has quit IRC13:37
*** safchain has joined #openstack-neutron13:40
*** thuc has joined #openstack-neutron13:41
*** dave_tucker_zzz is now known as dave_tucker13:42
*** peristeri has joined #openstack-neutron13:44
*** alagalah has joined #openstack-neutron13:44
*** thuc_ has quit IRC13:44
*** thuc has quit IRC13:45
*** alexpilotti has joined #openstack-neutron13:47
xuhanpsalv-orlando, ping13:49
salv-orlandoxi xuhanp13:49
xuhanpwill you have time to review my patch https://review.openstack.org/#/c/76125/ again. It has been approved by you previously but get conflicted during merge :-)13:49
*** nati_ueno has joined #openstack-neutron13:50
*** jgrimm has joined #openstack-neutron13:53
*** thuc has joined #openstack-neutron13:54
*** carlp has joined #openstack-neutron13:54
*** irenab has quit IRC13:55
*** alagalah has quit IRC13:55
salv-orlandoxuhanp: sure13:57
*** jecarey has quit IRC13:57
xuhanpsalv-orlando, thanks a lot!13:57
*** thuc has quit IRC13:57
*** salv-orlando_ has joined #openstack-neutron13:59
*** sneezewort has joined #openstack-neutron13:59
*** salv-orlando has quit IRC14:01
sneezewortWhy does turning off TCP segmentation offload on the virtual NICs increase network performance from an instance?14:03
*** nati_ueno has quit IRC14:03
*** salv-orlando_ has quit IRC14:03
*** vkozhukalov_ has quit IRC14:05
*** thuc has joined #openstack-neutron14:07
*** vkozhukalov_ has joined #openstack-neutron14:08
*** safchain has quit IRC14:08
*** markmcclain has joined #openstack-neutron14:10
*** markmcclain1 has joined #openstack-neutron14:12
openstackgerritJakub Libosvar proposed a change to openstack/neutron: Add support for https requests on nova metadata  https://review.openstack.org/8153514:13
*** chandan_kumar has quit IRC14:13
openstackgerritdongfeng proposed a change to openstack/neutron: add support for huawei snc  https://review.openstack.org/8153614:15
*** markmcclain has quit IRC14:15
openstackgerritenikanorov proposed a change to openstack/neutron: Fix namespace existence check method for it shall not be called with a namespace  https://review.openstack.org/8153714:15
*** chandan_kumar has joined #openstack-neutron14:17
openstackgerritJakub Libosvar proposed a change to openstack/neutron: Add support for https requests on nova metadata  https://review.openstack.org/8153514:18
*** shakamunyi has joined #openstack-neutron14:18
openstackgerritdongfeng proposed a change to openstack/neutron: remove errors  https://review.openstack.org/8154014:22
*** alagalah has joined #openstack-neutron14:25
openstackgerritdongfeng proposed a change to openstack/neutron: remove whitespace  https://review.openstack.org/8154314:26
*** Jianyong has joined #openstack-neutron14:27
*** thuc_ has joined #openstack-neutron14:28
*** thuc has quit IRC14:30
*** thuc_ has quit IRC14:32
*** markmcclain1 has quit IRC14:40
*** jobewan has joined #openstack-neutron14:40
*** dims has joined #openstack-neutron14:43
*** thedodd has joined #openstack-neutron14:49
*** SridharG has quit IRC14:49
openstackgerritOleg Bondarev proposed a change to openstack/neutron: Fix usage of save_and_reraise_exception  https://review.openstack.org/8154914:50
*** devlaps has joined #openstack-neutron14:51
openstackgerritJakub Libosvar proposed a change to openstack/neutron: Sync service and systemd modules from oslo-incubator  https://review.openstack.org/8121114:52
*** shakamunyi has quit IRC14:52
*** shakamunyi has joined #openstack-neutron14:52
*** thuc has joined #openstack-neutron14:53
*** markmcclain has joined #openstack-neutron14:54
*** salv-orlando has joined #openstack-neutron14:54
*** Jianyong has quit IRC14:55
*** alagalah has quit IRC14:55
*** pcm_ has quit IRC14:56
*** roeyc has quit IRC14:58
*** carl_baldwin has joined #openstack-neutron14:59
*** dvorkinista has joined #openstack-neutron15:00
*** mwagner__ has joined #openstack-neutron15:05
*** yamahata has joined #openstack-neutron15:07
*** networkstatic has joined #openstack-neutron15:07
HenryGmarkmcclain: hi, do you have a few minutes to discuss https://bugs.launchpad.net/neutron/+bug/1292114 ?15:09
*** jecarey has joined #openstack-neutron15:09
openstackgerritJakub Libosvar proposed a change to openstack/neutron: Sync service and systemd modules from oslo-incubator  https://review.openstack.org/8121115:15
markmcclainHenryG: sure.. what's up?15:16
HenryGmarkmcclain: one way to fix it is rather cringe-worthy:  https://review.openstack.org/8040615:17
HenryGmarkmcclain: is there a better way?15:18
markmcclainyeah not excited about surprise append to the list of plugins15:20
*** networkstatic_ has joined #openstack-neutron15:21
*** tvardeman has joined #openstack-neutron15:21
HenryGmarkmcclain: I guess we could add it to each individual migration where it is missing15:22
HenryGmarkmcclain: problem is, it will happen again15:23
*** dvorkinista has quit IRC15:23
*** admin0 has joined #openstack-neutron15:24
admin0hi all15:24
*** blogan has joined #openstack-neutron15:24
admin0in icehouse, will the neutron l3 agent be in high availability ?15:24
HenryGmarkmcclain: that patch does not affect other plugins, and we have tested it with ours - it solves all the migration problems15:26
*** dvorkinista has joined #openstack-neutron15:26
*** banix has joined #openstack-neutron15:26
*** networkstatic_ has quit IRC15:26
markmcclainIt's not ideal, but does make sense15:26
*** arosen1 has joined #openstack-neutron15:27
amulleradmin0: What Neutron agent? There are many... L2 on each compute node, then there's L3, DHCP and metadata15:28
amulleradmin0: That's ignoring the advanced services15:28
amulleradmin0: The Neutron service itself will have no HA capabilities in Icehouse (That would require an external took like Pacemaker)15:30
*** sbalukoff1 has quit IRC15:30
HenryGmarkmcclain: thanks for understanding. It still makes me go 'ewww' though, and what's worse is there is a need to backport it to Havana. :(15:30
amulleradmin0: As for the agents: DHCP agent supports active/active, by installing it on multiple nodes, and changing /etc/neutron.conf to allow multiple dhcp agents per network15:31
markmcclainyeah15:31
amulleradmin0: L3 agent will have HA for routers (Not for advanced services like FW, VPN, LB) in Juno it looks like, not Icehouse15:31
*** leseb_ has quit IRC15:32
*** leseb has joined #openstack-neutron15:32
HenryGmarkmcclain: the problem is showing up in deployments. Not sure why us devs don't see it with devstack? Would we need some kind of grenade testing to invoke more migration scenarios?15:34
markmcclainwell it won't show up in the gate because the cisco migrations are not run15:34
markmcclainideally the 3rd party system should catch this15:35
HenryGmarkmcclain: I understand that, but we run the cisco plugin with devstack all the time and don't see migration problems.15:35
markmcclainis create_all() "fixing" the issue for you?15:35
HenryGmarkmcclain: where is that?15:36
HenryGmarkmcclain: found it, looking ...15:36
markmcclainit should be in the db code15:36
HenryGTrying to understand when it gets run ...15:38
markmcclainwhen the db connection is instantiated15:38
*** jecarey has quit IRC15:38
markmcclainlook at 4029615:39
*** jecarey has joined #openstack-neutron15:39
markmcclainsalv-orlando worked to remove create_all15:39
markmcclainyou'll probably need to rebase and adapt for new plugins15:39
*** leseb has quit IRC15:39
*** leseb has joined #openstack-neutron15:40
*** dfarrell07 has joined #openstack-neutron15:40
*** overlayer has joined #openstack-neutron15:41
*** admin0 has quit IRC15:41
*** otherwiseguy has joined #openstack-neutron15:41
HenryGyou've lost me. That patch is abandoned?15:43
openstackgerritJakub Libosvar proposed a change to openstack/neutron: Add support for https requests on nova metadata  https://review.openstack.org/8153515:43
*** leseb has quit IRC15:44
*** sbalukoff has joined #openstack-neutron15:45
HenryGmarkmcclain: is it something that is still planned to go ahead? If so I will try to follow the progress and understand it better.15:49
*** admin0 has joined #openstack-neutron15:50
markmcclainit might still be revived15:50
markmcclainif you want to revive it15:50
HenryGok. Thanks for the help and info!15:50
markmcclainsalv-orlando says that would be ok15:51
*** _cjones_ has joined #openstack-neutron15:52
salv-orlandoHenryG: I can click restore… and they you can keep working on it?15:52
salv-orlandoI might have the time for doing that if I give up on eating or sleeping15:52
salv-orlandoI wouldn't do that however15:52
HenryGsalv-orlando: ok, but I will need help15:53
salv-orlandoHenryG: I already clicked restore, what other help you might need? ;)15:53
HenryGsalv-orlando: markmcclain: we're talking juno for that, right?15:53
salv-orlandoI'm here to explain the logic of the change, and the review history15:53
markmcclainI'd be interested in it for Icehouse15:54
*** coolsvap has joined #openstack-neutron15:54
*** kevinbenton has left #openstack-neutron15:54
*** chandankumar_ has joined #openstack-neutron15:54
markmcclainbecause create_all() seems to do cover up bad migrations15:54
*** kevinbenton has joined #openstack-neutron15:55
*** chandan_kumar has quit IRC15:56
*** yfried has quit IRC15:56
*** amuller has quit IRC15:56
*** carl_baldwin has quit IRC15:56
*** rossella_s has quit IRC15:57
*** jorgem has joined #openstack-neutron15:57
*** rossella_s has joined #openstack-neutron15:57
*** rcurran has joined #openstack-neutron15:58
*** irenab has joined #openstack-neutron15:58
*** Jabadia has quit IRC15:58
*** dims has quit IRC15:59
HenryGok, I'll see what I can do. I am really not familiar with databases just so you know.15:59
*** admin0 has left #openstack-neutron15:59
*** Jabadia has joined #openstack-neutron15:59
*** _cjones_ has quit IRC15:59
*** sbalukoff has quit IRC15:59
*** _cjones_ has joined #openstack-neutron15:59
*** sbalukoff has joined #openstack-neutron15:59
*** jorgem1 has joined #openstack-neutron16:00
*** jorgem has quit IRC16:01
HenryGsalv-orlando: when would be a good time to go through the explaining?16:02
*** Jabadia has quit IRC16:03
salv-orlandoHenryG: We're a bit busy now, so responses might be delayed…16:04
HenryGsalv-orlando: understood. let me rebase and test, then I will ping you again16:04
salv-orlandoHenryG: you can perhaps just try running unit tests after rebasing. Most will fail as they rely on auto-generation of schemas16:05
salv-orlandofor those failing you can then look at how they were fixed in that patch.16:05
salv-orlandoI'm sorry it's been almost 6 months since I did it. I already struggle trying to remember what I had yesterday for dinner16:06
*** alagalah has joined #openstack-neutron16:06
HenryGbangers and mash16:06
*** ijw has joined #openstack-neutron16:07
*** thuc has quit IRC16:07
*** thuc has joined #openstack-neutron16:08
*** dvorkinista has quit IRC16:08
*** Sukhdev has joined #openstack-neutron16:08
*** dfarrell07 has quit IRC16:10
arosen1and scones and tea for breakfast :)16:10
*** alagalah has quit IRC16:10
ihrachysarosen1: one of those missing changes to fix the patch is I3034fbb20e790f2d6f22c50b74a9f9dcdf9081aa16:12
*** thuc has quit IRC16:12
*** dfarrell07 has joined #openstack-neutron16:12
arosen1ihrachys: i think that was  a fix for a patch that we want to leave out : )16:13
arosen1err maybe not.16:14
ihrachysarosen1: I don't know, I just cherry-picked it, and now unit test that failed before succeeds :)16:16
arosen1ihrachys: great! Hopefully's the missing key16:17
*** armax has joined #openstack-neutron16:17
*** xuhanp has quit IRC16:17
*** blogan has quit IRC16:18
ihrachysarosen1: yeah, both unit tests are fixed by this. you should try to upload with this included, and we'll see whether tempest tests succeed too :)16:20
*** ihrachys is now known as ihrachys|afk16:20
*** bada_ has quit IRC16:21
*** singhs has joined #openstack-neutron16:21
*** bada_ has joined #openstack-neutron16:21
*** jlibosva has quit IRC16:22
openstackgerritBrandon Logan proposed a change to openstack/neutron: Added config value help text in ns metadata proxy  https://review.openstack.org/8081616:23
*** dvorkinista has joined #openstack-neutron16:30
*** leseb has joined #openstack-neutron16:33
*** SumitNaiksatam has quit IRC16:33
*** sbalukoff has quit IRC16:33
*** blogan has joined #openstack-neutron16:34
*** thuc_ has joined #openstack-neutron16:36
marunsalv-orlando: it looks like we are seeing more lock timeouts rather than fewer.   :/16:36
marunsalv-orlando: most seem to be on ports16:36
*** thuc__ has joined #openstack-neutron16:37
salv-orlandomarun: rebasing my patch and reputing right now.16:37
salv-orlandoI analysed gate failure since your patch merged.16:37
salv-orlandoit's still a bit early but it seems failure rate reduced by 15%16:37
marunI have to wonder we should be doing something other than 'for update' everywhere16:37
marunsalv-orlando: when I run the logstash query with the bug, the simple graph at the top suggests that incidence is significantly worse than yesterday16:38
marun(although maybe simply more jobs are running)16:38
openstackgerritSalvatore Orlando proposed a change to openstack/neutron: Add a semaphore to some ML2 operations  https://review.openstack.org/8041316:39
*** rcurran has quit IRC16:40
*** shakamunyi has quit IRC16:40
*** thuc_ has quit IRC16:40
*** salv-orlando has quit IRC16:40
openstackgerritmark mcclain proposed a change to openstack/neutron: add HEAD sentinel file that contains migration revision  https://review.openstack.org/7937716:40
*** hogepodge has quit IRC16:41
*** dvorkinista has quit IRC16:41
marunwtf, a semaphore??16:41
marunthat's not going to help us when multiple servers are in play16:41
*** spandhe has joined #openstack-neutron16:42
*** salv-orlando has joined #openstack-neutron16:42
marunsalv-orlando: to repeat myself - wtf, a semaphore??16:42
marunarosen: why on earth are you +2ing https://review.openstack.org/#/c/80413/16:43
*** hogepodge has joined #openstack-neutron16:43
salv-orlandomarun: oh I feel you are intimidating me. ;)16:43
salv-orlandothat was agreed with comstud16:43
marunreally?16:43
maruncomstud: do you want to explain?16:43
salv-orlandoyeah I pointed to the eavesdrop logs on the review16:43
salv-orlandoyou'll find everything there16:44
marunhow does that help if someone has multiple neutron servers?16:44
salv-orlandomarun: but if you come up with a plan to remove all the select..for update queries, that would solve the problem16:44
marunor is the idea that multiple neutron servers effectively have to use multiple masters?16:44
marunsalv-orlando: I think the big hole in what we're doing right now has to do with ml2 events16:45
marunsalv-orlando: it's pretty hard to have clean db interaction if there are going to be arbitrary code called from transactions16:45
marunrkukura, mestery: ^^16:45
*** markmcclain has quit IRC16:45
salv-orlandomarun: I unfortunately do not know ML2 enough.16:46
marunsalv-orlando: it's not complicated.16:46
salv-orlandoLet's then agree to forget about the patch I did16:46
salv-orlandoand you, rkukura and mastery will sort that out?16:46
salv-orlandosorry, I meant mestery16:46
marunsalv-orlando: there are [resource event]_precommit calls in transactions16:46
* mestery reads backscroll16:46
*** irenab has quit IRC16:46
marunmestery: I'm starting to think we need to remove precommit calls from transaction scope16:47
rkukurasalv-orlando, marun: The pre commit calls are intended to be within the transactions, and drivers are not supposed to do anything in these that could block.16:47
* mestery agrees this will cause problems with multiple servers.16:47
kevinbentonmarun: the deadlock the semaphore protects against doesn't affect multiple servers16:47
mestery+1 to what rkukura said16:47
*** salv-orlando has quit IRC16:47
marunkevinbenton: really?16:48
rkukuramarun: We already have post commit methods that are outside the transactions16:48
kevinbentonmarun: yes, the deadlock happens between coroutines in the same threadpool16:48
*** salv-orlando has joined #openstack-neutron16:48
rkukuraI'm working on a patch that moves the bind_port() methods outside transactions16:48
kevinbentonone gets the mysql lock for update and yields16:48
marunkevinbenton: I'm not sure deadlock is the problem so much as lock timeouts16:48
mesterykevinbenton: See rkukura's comments ^^^16:48
marunkevinbenton: which a semaphore does nothing to help16:48
kevinbentonthe lock timeout is the side effect of the deadlock16:48
salv-orlandoI am far from being an expert on ml2. However, we had several people including me at the logs, and concluding it's an eventlet issue, not a db issues.16:49
salv-orlandostill, I'm happy to see the interest from the core devs for ML2 is on this patch!16:49
marunsalv-orlando: so we're not working around bad db code, just eventlet misbehaviour?16:49
rkukurasalv-orlando: Which patch?16:49
kevinbentonthread1 gets mysql lock and yields. thread2 tries to get same mysql lock and blocks16:49
kevinbentondeadlock until sql lock timeout16:50
mesteryrkukura: https://review.openstack.org/#/c/80413/16:50
salv-orlandomarun: did you read the eavesdrop log I linked on gerrit?16:50
rkukuraWhy yield inside a transaction?16:50
marunsalv-orlando: If I could find human comments on reviews with all the auto-test chatter, I would :p16:50
rkukuraseems like that is asking for timeouts16:50
salv-orlandook16:50
*** leseb has quit IRC16:50
rkukuramarun: +1 on hiding the chatter16:50
marunsalv-orlando: I'll dig for it, sorry16:50
*** leseb has joined #openstack-neutron16:51
salv-orlandofinding that...16:51
* mestery can't find it either. #^@#@ auto comments on gerrit reviews.16:51
marunsalv-orlando: which day?16:52
*** tstevenson has quit IRC16:52
salv-orlandohttp://eavesdrop.openstack.org/irclogs/%23openstack-qa/%23openstack-qa.2014-03-13.log16:52
kevinbentonrkukura: right, we shouldn't yield in a transaction, but it seems to be difficult to guarantee that all of the eventlet yielding calls aren't inside of a transaction16:52
marunmestery, rkukura: there is a javascript bookmarklet to colorize auto chatter at least, but it should be enabled by default16:52
salv-orlandocheck for me, sdague, comstud and markmcclain chatting around 14:00GMT16:52
*** salv-orlando has quit IRC16:52
marunkevinbenton: is there any way to track yield points in eventlet so we can see if we can fix?16:53
*** ygbo has quit IRC16:53
kevinbentonmarun: not that i know of, but i'm far from an eventlet expert16:54
*** alagalah has joined #openstack-neutron16:54
kevinbentonsomething to consider is a LOG call in the transaction16:55
marunkevinbenton: Maybe it makes sense to optionally debug log transaction enter/exit.  So at least when we see a deadlock we'll know the source.16:55
*** SumitNaiksatam has joined #openstack-neutron16:55
marunkevinbenton: ah, I guess we're on the same page.16:55
kevinbentonmarun: not quite16:55
marunkevinbenton: do tell16:55
kevinbentonmarun: i was just going to say that even LOG calls could cause a yield16:55
kevinbentonmarun: if a file system call is configured16:56
marunkevinbenton: F$#@16:56
marunkevinbenton: so we'd need a logging mechanism that would would avoid yields in transactions.16:56
*** alagalah has quit IRC16:57
marunkevinbenton: i.e. flush to disk only when safe to do so16:57
mesterymarun: Thanks for the reminder of the bookmarklet! Works well. Should be default. :)16:57
kevinbentonmarun: yes16:57
kevinbentonmarun: and anyone that makes the mistake of logging the normal way in a transaction will have to be publicly chastised :-(16:57
marunkevinbenton: at least we'll know about it if we see a log for entry without a corresponding one for exit before the error is reported.16:58
marunkevinbenton: (in the context of a transaction I mean)16:58
*** dfarrell07 has quit IRC16:59
marunkevinbenton: The only problem is if the semaphore patch is merged we won't be able to find these problems anymore.16:59
marunkevinbenton: I'm not sure if that's desirable - do we want a bandaid or a real fix?16:59
kevinbentonmarun: yeah, it will help with debugging. because the current DB timeout exception isn't from the coroutine that mistakenly yielded16:59
kevinbentonmarun: right17:00
kevinbentonalways a real fix17:00
kevinbentonbut bandaids exist because the real fixes are painful :-)17:01
*** alagalah has joined #openstack-neutron17:01
kevinbentoni think for icehouse the semaphore would be good for stability17:01
marunkevinbenton: actually, we shouldn't have to worry about logging causing transaction problems..17:01
*** dfarrell07 has joined #openstack-neutron17:01
*** sweston has quit IRC17:01
kevinbentonmarun: why not?17:01
marunkevinbenton: My thought is to create a context manager that wraps the transaction one.17:01
marunkevinbenton: log before/after the transaction17:02
marunkevinbenton: search/replace everywhere17:02
*** dfarrell07 has quit IRC17:02
marunkevinbenton: do you see any issue with this approach?17:02
kevinbentonmarun: oh okay, just strip out anyone that logs inside the transaction?17:02
*** sweston has joined #openstack-neutron17:02
marunkevinbenton: oh!17:03
marunkevinbenton: I just got it, I'm dense/slow17:03
marunkevinbenton: So logging could be causing the deadlock?17:03
marunkevinbenton: and if we could capture the logs inside of a transaction we might be able to eliminate it?17:03
kevinbentonmarun: yeah17:04
*** dfarrell07 has joined #openstack-neutron17:04
marunkevinbenton: i was only thinking of logging transaction start/end so we could trace where the deadlock was coming from17:04
marunkevinbenton: both probably make sense17:04
kevinbentonmarun: actually this might not help find it17:05
Sukhdevsdague: Sean are you here?17:05
marunkevinbenton: no?17:05
kevinbentonmarun: the eventlet that mistakenly yields isn't the one that blows up with a timeout17:05
*** chandan_kumar has joined #openstack-neutron17:05
marunkevinbenton: maybe not, but couldn't we eliminate the yields?17:05
kevinbentonmarun: oh, never mind, it will still help because there would be a start and stop that enclose the exception from the yielding threa17:06
*** salv-orlando has joined #openstack-neutron17:07
kevinbentonmarun: so logging is a good start17:07
rkukuramarun, kevinbenton: I think we need to distinguish between two kinds of blocking in transactions17:07
rkukuraThere is external blocking, such as a driver talking to a controller within a transaction17:08
marunrkukura: which imho, should not be happening.17:08
marunrkukura: that pretty much guarantees a yield17:08
rkukuraThen there is internal stuff (local to the node) such as yields or logging that shouldn't block for long, but can cause green threads to context switch17:08
marunrkukura: if that's 'by design', we have to rethink.17:08
kevinbentonmarun, rkukura: in the eyes of eventlet, they are the same and both cause the coroutine to yield17:09
rkukuraOur design should be to avoid the external blocking within transactions completely.17:09
marunrkukura: right.17:09
*** harlowja_away is now known as harlowja17:09
marunrkukura: so we're focusing on the local stuff, which can include logging.17:09
rkukuraOur design should also minimize likelihood of context switches due to short term local blocking/yielding within transactions17:10
marunrkukura: my thought is that we need a wrapper for initiating transactions that collects logs so that no logging occurs during a transaction17:10
marunrkukura: because any file io can trigger a yield17:10
marunrkukura: and outputs the logs after transaction commit/rollback17:10
rkukuramarun: That might be worthwhile17:11
kevinbentonmarun, rkukura: any io *does* trigger a yield17:11
marunkevinbenton: right, thank you for the clarification17:11
rkukuraI like the idea of logging the beginning and end of each TX17:11
marunrkukura: yes, and if we do that as well, we'll figure out other sources of yields that we can fix.17:11
rkukuraMaking this collect logging would also reduce the chance of a yield17:11
rkukuraBut a yield should not normally be an issue, except when the server process (single thread) is overloaded and can't keep up17:12
marunrkukura: so we should be able to ensure that no yielding occurs during transactions and we can go back to fighting locks caused by trying to do too much in a given transaction.17:12
kevinbentonrkukura: the deadlock risk is still there though, just a narrower window17:12
kevinbentonrkukura: if there is any yielding17:12
*** hogepodge has quit IRC17:13
marunrkukura: I don't think we can protect against overloading in a production deployment.17:13
marunrkukura: so avoiding yields in transactions would seem the best option.17:13
marunsalv-orlando: ping17:13
marunsalv-orlando: have you been following any of this?17:13
comstudmarun: semaphore idea is a stop-gap until you can figure out a better way to not create deadlocks or lock wait timeouts17:14
*** vkozhukalov_ has quit IRC17:14
maruncomstud: I think we have a better way.17:14
comstudmarun: it will only work when running single process, but it was just an idea of a quick fix17:14
comstudthe other was retrying, which would work multi-process17:14
comstudNext step would be to fix the real problems17:14
comstudmarun: ok17:14
maruncomstud: We've been discussing creating a transaction wrapper that collects logs so that file io from logging can't happen inside the transaction (and outputs them after commit/rollback).17:15
*** morganfainberg_Z is now known as morganfainberg17:15
*** hogepodge has joined #openstack-neutron17:15
maruncomstud: the same wrapper would log transaction entry/exit so we could correlate deadlocks with yielding transaction to find other triggers for yields.17:15
comstudyeah, sounds like a good alternative17:16
comstudcool17:16
maruncomstud: are there other obvious sources for yields other than logging file io?17:16
*** leseb has quit IRC17:16
*** hogepodge has quit IRC17:16
*** leseb has joined #openstack-neutron17:16
*** SridharG has joined #openstack-neutron17:16
comstudno, unless you're doing crazy things like using queues inside of the transactions17:16
maruncomstud: I hope that's not the case, but I guess we'll find out.17:17
*** ijw has quit IRC17:17
*** chandan_kumar has quit IRC17:17
comstudor something other 3rd party module that would make use of threading.Lock17:17
comstud3rd party modules that use python logging module could be a problem17:17
comstudunfortunatley sqlalchemy itself falls into that category :)17:17
rkukuradoes access to config potentially yield?17:17
maruncomstud: What do you think of using mock?17:17
*** alagalah has quit IRC17:18
maruncomstud: since it should affect even instantiated objets.17:18
maruncomstud: I'm not sure I understand the problem with threading.Lock, could you elaborate?17:18
rkukurapython eventlet doesn't have any notion of thread priorities, does it? Would be nice if this transaction wrapper could bump the thread's priority up17:19
comstudmarun: sure17:19
comstudeventlet is not thread safe17:19
comstudoops, different problem17:19
comstudsorry, I'm confusing 2 different problems here17:19
comstudfor this problem, it's really not specific to threading.Lock17:19
comstudbut use of locks can cause a greenthread switch if the lock is locked by other greenthread17:20
rkukuracomstud: I meant bump up the current green thread priority, not the underlying OS thread17:20
comstudqueues and things apply as well because it'll switch greenthread if you try to block getting something from queue, but queue is empty17:20
comstudetc17:20
jogoany updates on bug Bug 1283522?17:20
comstudunfortunately the python logging module uses threading.Lock to serialize logging17:20
comstudwhich eventlet monkey patches17:21
jogoit accounts for roughly 30% of our known gate failures17:21
comstudand causes a greenthread switch if another greenthread has it locked17:21
maruncomstud: ah, so if a greenthread tries to acquire a lock that is already held, it has the same effect as io -> yield17:21
comstudright17:21
*** leseb has quit IRC17:22
marunjogo: we're disussing it now17:22
comstudotherwise you have a deadlock17:22
comstudit must switch to another greenthread to allow it to run17:22
comstudand unlock the lock17:22
*** mlavalle has joined #openstack-neutron17:22
marunjogo: we're considering ways to avoid yields in transactions17:22
maruncomstud: right.  so we need to avoid both io and lock contention to prevent yields17:23
comstudSo, one thing I tried before...17:23
*** dims has joined #openstack-neutron17:23
comstudis monkey patching the logging module to use the non-monkey patched threading.RLock17:23
comstudbut it proved to be rather ugly and difficult to do...17:23
comstudbut that's an option if you feel like trying that17:23
*** BillTheKat has joined #openstack-neutron17:24
*** BillTheKat is now known as Gil_McGrath17:24
maruncomstud: but does that avoid the potential for file io?17:24
comstudfile io does not cause switches17:24
maruncomstud: no?17:24
maruncomstud: *confused*17:24
comstudno, it should not.. eventlet won't poll on file i/o17:24
maruncomstud: only network io?17:24
comstudright17:25
comstud(I could be wrong... but I'm like 90%+ sure :)17:25
comstudthe reason I say so is...17:25
comstudeventlet tries to read() and write() to file first.17:25
comstudand only polls on EAGAIN17:25
maruncomstud: what is EAGAIN?17:25
comstudsyscall errno17:25
marun<- ignorant17:25
comstudEAGAIN is a syscall errno meaning "no data right now"17:26
comstudwhen using non-blocking I/O17:26
maruncomstud: so when reading in other words.17:26
maruncomstud: writing wouldn't yield, but reading could17:26
comstudand that never happens for file i/o17:26
marunah, ok.17:26
comstudnot from a file17:26
comstudthere's always data17:26
comstudor EOF17:26
*** harlowja has quit IRC17:26
comstudSo eventlet should never switch on file I/O17:26
maruncomstud: from a regular file, but what about something like stdout?17:26
comstudI think there was a misunderstanding about this before17:27
comstudbecause we knew that the logging module caused switches17:27
comstudand an assumption was made that it was from file io17:27
maruncomstud: ah, ok.17:27
comstudwhen it fact it's actually from the threading.RLock17:27
maruncomstud: so the problem is the same, I was just misunderstanding the cause.17:27
comstudcorrect17:27
kevinbentoncomstud: so file IO will never cause a yield on write?17:27
maruncomstud: ok, so collecting logs is still a good idea17:27
comstudkevinbenton: correct17:28
comstudepoll doesn't even support polling on file descriptors tied to files17:28
*** rotbeard has quit IRC17:28
*** yfried has joined #openstack-neutron17:28
comstudmarun: Yeah, I think that's reasonable17:28
jogomarun: so how come this bug started recently?17:28
marunjogo: I wish I knew.  I'm presuming we were masking it with other issues.17:29
comstudjogo: Could be getting more pseudo-parallelism somehow in DB queries17:29
comstudmore greenthreads doing DB calls, who knows17:29
marunjogo: it's pretty strange to see how much it's incidence has increased, even in the past day alone.17:29
comstudjust a guess.. I don't know a lot about neutron in general17:29
comstud:)17:29
*** hogepodge has joined #openstack-neutron17:29
rkukuraMore load on the server will cause more likely hood of DB timeouts17:29
jogomarun: have you gone through the openstack/openstack repo looking for suspects?17:29
jogobecause if we could revert the thing that broke us  and then fix the root cause that would make things run smoother17:30
marunjogo: openstack/openstack?17:30
jogohttp://git.openstack.org/cgit/openstack/openstack17:30
jogohas the full openstack git history accross all relavent repos17:30
kevinbentonhere is a diagram https://docs.google.com/drawings/d/13A2x4AWbf8zmzeGApUmYVlBrW8CMTPFTCBGSP_nTzDA/edit?usp=sharing17:31
marunjogo: why would I use that vs looking at the commit log for neutron?17:31
marunkevinbenton: is that what's happening here?17:31
comstudmarun: honestly, i'd probably just throw the semaphore decorator on for now17:32
maruncomstud: I was wondering how network io to mysql played into this...17:32
comstudbecause you can get a quick fix that way17:32
comstudAnd then work on a better fix17:32
maruncomstud: ok, fair enough.17:32
*** Gil_McGrath has quit IRC17:32
comstudYou really don't lose anything by doing so right now17:32
*** Gil_McGrath has joined #openstack-neutron17:32
comstudsince the DB queries all run serially anyway17:32
kevinbentonmarun: yeah, the trick is finding the yielding call17:32
comstudIe, you're not losing any parallelism17:32
maruncomstud: my visceral reaction to things like semaphores is 'fsck no!' but leaving the gate in bad shape is worse.17:32
comstudmarun: Yeah, I agree. :)17:33
comstudIn this case it probably looks worse than it really is17:33
comstudIt looks like a huge performance issue, but you're really not losing anything17:33
maruncomstud: I'm not worried about the performance so much as adding complexity instead of fixing things.17:33
comstudSure17:34
comstudbut this decorator is less complex than any of the real fixes, actually.17:34
comstud:)17:34
maruncomstud, kevinbenton: so does eventlet ever yield due to network io with mysql, inside a transaction?17:34
comstudBut I agree with your general sentiment :)17:34
comstudmarun: Not right now, no17:35
comstudor really not ever17:35
rkukuramarun: Is https://review.openstack.org/#/c/80413/ the patch being discussed here?17:35
comstudNot with the default mysql backend module17:35
comstudwhich uses sockets in C17:35
kevinbentonmarun: no i don't think so because at that point things are in the hands of the C lib17:35
marunrkukura: yes17:35
comstudeventlet can't wrap it... so they all just block17:35
maruncomstud: ah, ok.[17:35
marunkevinbenton: thanks for the clarification17:36
comstudWhich sucks, because we can't run DB calls in parallel...17:36
*** harlowja has joined #openstack-neutron17:36
comstudAnyway, longer term is we fix eventlet.. and run db calls in Thread pools17:37
rkukuracomstud: Are there any eventlet-friendly pure python mysql backends?17:37
openstackgerritA change was merged to openstack/neutron: Remove individual cfg.CONF.resets from tests  https://review.openstack.org/7984617:37
kevinbentonthe other option would be to avoid "lock for updates" like the plague17:37
marunfix eventlet? Or throw it under a bus? ;)17:37
marunkevinbenton: If only that were an option.17:37
marunkevinbenton: db consistency sometimes demands locking.17:38
kevinbentonrkukura: yes17:38
kevinbentonpymysql17:38
*** suresh12 has joined #openstack-neutron17:38
kevinbentoni tried it out17:38
rkukuraAnd?17:38
kevinbentonimmediately detects the deadlock and raises an exception17:38
kevinbentonso it doesn't automatically yield like i had hoped17:39
rkukurakevinbenton: Is this a specific deadlock?17:39
kevinbentonrkukura: it detects that it can't get a lock for update17:39
comstudmarun: One or the other. I have a replacement coming, actually. :)17:39
comstudwe'll see.17:39
maruncomstud: so salvatore's patch, is it ready to go as is?17:39
comstudi haven't seen it17:39
comstudand i'm in a 1 on 1 now17:40
comstudi can look in a bit17:40
rkukuramarun: If its https://review.openstack.org/#/c/80413/, I may change my -1 to a -217:40
marunrkukura: why?17:40
rkukuraIf anything, it will just move the problem around17:40
salv-orlandomarun: even if we agree that we want a semaphore I still need to address a comment to kevinbenton. Following his lead I found two more calls that need to be synchrinized17:40
marunrkukura: I think we may need to take this approach to appease the gate gods.17:40
marunrkukura: and then we can work on a real fix.17:41
marunrkukura: a -2 would be counterproductive17:41
kevinbentonrkukura: i don't think it moves the problem. it does fix it17:41
marunkevinbenton: it masks it.17:41
rkukuraWhat is the specific deadlock scenario that this avoids?17:41
marunkevinbenton: very effectively!17:41
kevinbentonrkukura: it's just a civil war era fix (amputate the leg to avoid infection)17:41
kevinbentonrkukura: the one i sent the diagram for17:42
marunrkukura: have you seen the logstash query?17:42
salv-orlandorkukura: it would be good if you can -2 the patch and add appropriate comments on it. I'm not able to participate in the discussion now, so I would be happy if we can move it to gerrit17:42
marunrkukura: jogo reports that 30% of gate failures are due to this issue17:42
kevinbentonrkukura: it will prevent the second thread from trying to get an SQL lock while the other has it17:42
marunrkukura: see the query link in the bug: https://bugs.launchpad.net/neutron/+bug/128352217:42
rkukurakevinbenton, marun: It would really help me to understand which threads are trying to do what when this deadlock occurs.17:43
marunrkukura: as far as we know logging could be the culprit17:43
marunrkukura: or any 3rd party library that uses threading locks17:43
*** ijw_ has joined #openstack-neutron17:44
marunrkukura: the point is, something is causing a yield.17:44
kevinbentonrkukura: usually it's simultaneous delete_ports17:44
rkukuraThe commit msg says "This semaphore has been introduced to avoid undesired eventlet17:44
rkukurayields...". How does locking a semaphore prevent yields?17:44
marunrkukura: because then only one thing can attempt to acquire a given lock at a time.17:44
kevinbentonrkukura: it doesn't, but it does make sure that the yields don't kill everything17:44
rkukuraWe cannot put the semaphore on get_device_details17:44
marunlock -L db lock17:45
marunoops, lock -> db lock17:45
rkukuraThe patch I'm working on will result in the possibility of transactions within that.17:45
marunrkukura: ??17:45
marunrkukura: but the issue isn't transactions17:45
marunrkukura: the issue is db locks17:45
marunrkukura: are you saying get_device_details would require locking??17:46
kevinbentonrkukura: the only things that need to be protected with a semaphore are the ones that lock the table for update17:46
rkukuraWhich table?17:46
marunrkukura: whichever ones are being locked for update.17:46
kevinbentonrkukura: the port table in this case is the problem child17:47
rkukuraMaybe we just want to put synchronizion at the very top level so the process only handles a single REST call or single RPC call at a time!17:48
marunuh, no17:48
maruni'm assuming you're being sarcastic17:48
rkukuraSlightly17:49
*** dfarrell07 has quit IRC17:49
*** sbalukoff has joined #openstack-neutron17:49
marunwithout eventlet we have to run lots of python processes to handle the same load17:49
marunthe memory overhead would be significant17:49
rkukuraWith my patch there will be a loop inside get_device_details that can do a transaction each iteration. A semaphore around this is not a good idea17:49
kevinbentondoes get_device_details lock the port table?17:50
marunrkukura: Please answer my question: Are you going to lock in said transactions?17:50
rkukuralock for update17:51
marunrkukura: and if so, why?17:51
*** dfarrell07 has joined #openstack-neutron17:51
rkukurathe lock for update is on the port binding table17:51
*** bada_ has quit IRC17:51
marunrkukura: why is a method called get_device_details writing to the table?17:51
marunrkukura: shouldn't it be set_device_details?  :p17:51
*** afazekas has quit IRC17:51
*** dvorkinista has joined #openstack-neutron17:51
*** bada_ has joined #openstack-neutron17:52
rkukuraWith my patch, get_device_details, get_port, create_port, update_port will call call a _bind_if_needed() function that does the binding.17:52
marun*sigh*17:52
marunso much for sanity17:52
marunthat voilates a pretty fundamental oo design principle17:53
maruni'm sure there's a good reason, but, oy!17:53
jogomarun: because perhaps there was a devstack or devstack-gate change that triggered this17:53
openstackgerritA change was merged to openstack/neutron: Mock agent RPC for FWaaS tests to delete DB objs  https://review.openstack.org/7845717:53
rkukuraSince the binding is no longer inside the transaction, after the binding completes, a truncation is started that locks the binding table for update, verifies that nothing effecting the binding (binding:host_id, binding:profile, binding:vnic_type) has changed, and then commit the binding result17:53
openstackgerritA change was merged to openstack/neutron: Ensure to count firewalls in target tenant  https://review.openstack.org/8071517:53
marunrkukura: Well, at least the lock isn't on the ports table.17:54
rkukuras/truncation/transaction/17:54
marunrkukura: We only need to synchronize for that table.17:54
marunrkukura: so you should be safe.17:55
rkukuraI still do not see why this semaphore is needed17:55
marunrkukura: cause: eventlet yields inside transaction holding lock against the ports table17:55
rkukuraIs it simply that our tests run the server in such an overloaded state that a yield inside a transaction is statistacally likely to result in a DB timeout?17:56
marunrkukura: bandaid solution: prevent entry to more than one function at a time that locks the ports table17:56
*** dvorkinista has quit IRC17:56
rkukuraSo the bandaid just moves the problem to some other locking of some other table17:56
marunrkukura: maybe, and we can revert it if so.17:56
marunrkukura: maybe the only hotspot is the ports table.17:57
kevinbentonrkukura: only if there are other tables that lock for update and yield17:57
marunrkukura: we won't know until we've tried.17:57
kevinbentonrkukura: there are like 4 functions that delete ports17:57
marunrkukura: we have the power of git!  nothing is permanent.17:57
kevinbentonrkukura: and it in testing they all happen close together17:57
kevinbentondelete_network, delete_subnet, delete_router, delete_port17:57
marunrkukura: we don't have the luxury of finding a perfect solution.  the negative impact is too great.17:58
marunrkukura: so long as we actively work on a real fix, a bandaid is a valuable option.17:59
*** spandhe has quit IRC17:59
marunrkukura: anyway, I was skeptical too until talking it over with comstud.  If you're still unsure, you may want to follow up with him.18:00
rkukuraI just gave it a -2. Maybe I don't understand the exact issue here, and I'm happy to discuss it, but I cannot see the semaphore around get_device_details() being acceptable. If this gets in, I need to abandon the patch I've been working on.18:01
*** RajeshMohan has joined #openstack-neutron18:02
marunrkukura: ??18:02
*** baoli has quit IRC18:02
marunrkukura: Didn't we just tell you that the patch in question does not affect your patch unless you are locking the ports table?18:03
marunrkukura: so you _are_ locking the ports table??18:03
*** baoli has joined #openstack-neutron18:03
*** kanzhe_ has joined #openstack-neutron18:03
marunrkukura: or is it the existing code that is doing so?18:04
rkukuraMy patch will drastically increase the length of time that the semaphore around get_device_details could remain locked.18:04
*** hemanthravi has joined #openstack-neutron18:04
enikanorov__kanzhe_: so...18:04
marunrkukura: *sigh*18:04
marunrkukura: my brain is confused18:05
enikanorov__how do you see inserting an LB into a router? can you specify the workflow?18:05
openstackgerritAbhishek Raut proposed a change to openstack/neutron: Fix segment allocation tables in Cisco N1kv plugin  https://review.openstack.org/7850618:05
*** s3wong_ has joined #openstack-neutron18:05
kanzhe_enikanorov__: I don't know how the provider knows the context?18:05
kevinbentonrkukura: a slowed down call that works is better than one that randomly deadlocks and explodes18:05
*** spandhe has joined #openstack-neutron18:05
marunkevinbenton: so I get using a semaphore when locking is involved...18:05
enikanorov__kanzhe_: well, there are options18:06
marunkevinbenton: but if there is a lock on a given table, how are reads affected?18:06
enikanorov__kanzhe_: opt #118:06
rkukuramarun: Most of get_device_details really should not be locking the port table for update. Is it just the update_port_status() call at the end that needs to lock it for update?18:06
marunrkukura: I would guess so, yeah.18:07
enikanorov__kanzhe_: you create LB specify a flavor that says 'routed insertion', then you need to pass router_id, or the provider derives router from the pool or vip subnet18:07
*** spandhe has quit IRC18:07
enikanorov__so user either provides insertion context (router_id), or it is implicitly used18:07
kevinbentonmarun: good question. there still may be an issue there18:07
enikanorov__kanzhe_: opt #2 - chain provider passes insertion context to LB plugin upon LB creation18:08
*** Sukhdev has quit IRC18:08
kevinbentonmarun: lock for update only blocks reads of that row, right?18:08
SumitNaiksatamenikanorov: i think ideally we should use a generic mechanism for the latter (that is passing the router_id)18:08
marunrkukura: it may make sense to isolate the write from the read18:08
rkukuramarun: All three of the RPC methods to which the semaphore is being added call update_port_status(), which is actually updating the port table. Maybe we can just put the semaphore in that function?18:08
*** peristeri has quit IRC18:08
marunkevinbenton: I think so18:08
marunrkukura: that sounds reasonable18:09
enikanorov__SumitNaiksatam: the thing is that even passing router_id is not very good. it's better if provider could derive router based on existing information18:09
SumitNaiksatamenikanorov__: that part i think we agree, it should not be a requirement18:09
kevinbentonmarun: so it is possible that a deadlock would occur if something tried to read a port that is locked for update18:09
marunkevinbenton: arg++18:10
rkukuramarun: I'm looking into it, and will update the review if it seems to make sense.18:10
marunrkukura: thank you for digging, your concerns are certainly valid.18:11
kanzhe_enikanorov__: If there are more than one router, router_id may need to be explicitly defined. In the case of L2 devices, the context is getting more complicated.18:11
enikanorov__kanzhe_: right, and then i wonder how a tenant can specify such context...18:11
marunkevinbenton: in a perfect world we could hook into eventlet's machinery to trigger an exception if a yield occurred when it shouldn't...18:12
rkukuramarun: Even update_port_status calls into mechanism drivers' pre and post commit methods, and the post commit methods could make remote calls.18:12
kanzhe_enikanorov__: tenant knows where the service is needed Since he is the one asking for it.18:12
comstudmarun: mock greenthread.getcurrent().switch() method to trap :)18:12
maruncomstud: so there is a way?  yay!18:13
kevinbentonmarun: i was joking with markmcclain that eventlet just needs a @roadrage decorator where it refuses to yield18:13
comstudyep18:13
*** pradipta_away is now known as pradipta18:13
comstudkinda hacky, but if that's what you want, yeah18:13
comstudwell18:13
maruncomstud: I think that's what we need.18:13
comstudActually, I guess that's not quite what you want18:13
enikanorov__kanzhe_: that is understood, i mean how it's defined, literally. router_id is a single parameter to a API call/CLI command18:13
comstudbecause that traps the switch BACK to current greenthread18:13
maruncomstud: why not?18:13
enikanorov__insertion_context is a complex object18:13
maruncomstud: ah, nope.18:13
kanzhe_enikanorov__: If the tenant needs the service for a subnet, then subnet is the context. same for network. If the service applies to all traffic at the default gateway, then router is the context.18:13
comstudmarun: ya, more difficult to trap what you really want18:14
maruncomstud: I think this capability is essential to our use case.18:14
enikanorov__kanzhe_: ok, i see18:14
kevinbentoncomstud: actually that's what i just described isn't it?18:14
maruncomstud: if we have to avoid yield, we should be told explicitely how it happens so we can work to avoid.18:14
kevinbentoncomstud: blocking eventlet from yielding18:14
kanzhe_enikanorov__: The serviceContext is meant to address it. I agree it is a bit confusing at its current state.18:14
maruncomstud: or as kevinbenton suggests, could we simply not block the yield?18:15
*** yfried has quit IRC18:15
marunsorry, not block -> block.18:15
kevinbentoncomstud: package it up into a decorator we can slap on transactions18:15
kanzhe_enikanorov__: glad to see that you are agree on the importance of serviceContext18:15
comstudeventlet internally, depending on what it does, plucks a greenthread off a list18:15
comstudand does a .switch() on it18:15
comstudbut you have way to really trap that18:15
comstudyou have no idea what it'll select18:15
comstudand where the list comes from depends on what's causing the switch18:16
enikanorov__kanzhe_: ok. would be great if you could show the workflow of 1-2 examples for loadbalancer service18:16
maruncomstud: but isn't that for entering rather than yielding?18:16
comstudthat's what a yield really is18:16
maruncomstud: or is the idea that the switch is an interrupt that we can't turn off selectively?18:16
comstudit's a switch to another greenthread18:16
comstudbe it the eventlet hub or another greenthread18:16
enikanorov__kanzhe_: i mean literally cli commands that need to be executed to create LB inserted in routed mode18:16
maruncomstud: sorry for my ignorance of eventlet internals :/18:16
rkukuramarun, kevinbenton, salv-orlando: Would it be possible to move the semaphore locking to basically the same scope as the "with session.begin():" statement that contains the "with_lockmode('update')"?18:16
enikanorov__kanzhe_: we can continue this over ML18:17
kanzhe_enikanorov__: Sure. For the one-arm mode LB, the router where the LB needs to be attached should be the context. Hence, the serviceContext.routers=[router_id], where the router_id is the router of interest.18:17
comstudmarun: no worries!  you don't really want to know the internals18:17
comstud:)18:17
comstudunfortunately i've looked too much at it18:17
kevinbentonyes18:17
kevinbentonrkukura: yes18:17
enikanorov__kanzhe_: my question is mostly about API and user experience. I understand how that could look in the code. but how will that look from API/CLI perspective?18:17
kanzhe_enikanorov__: For one-arm with DSR case, serviceContext should have a router and subnet, where the router is the same as one-arm mode, the subnet is the one where server-pools are.18:18
maruncomstud: so would it be possible to do either of a. prevent yield or b. raise exception on yield?18:18
rkukurakevinbenton: Do you think those semaphores at that scope would still avoid the deadlocks?18:18
maruncomstud: just want to clarify whether our best option is still logging transaction entry/exit and then having to correlate deadlocks with missing exist.18:18
marunexits18:18
kevinbentonrkukura: with lockutils.lock(name, lock_file_prefix, external, lock_path)18:18
kanzhe_enikanorov__: I am not familiar with CLI syntax, Sumit, can you help here?18:18
kevinbentonrkukura: yes, as long as they occur before the lock for update18:18
enikanorov__kanzhe_: let me explain18:19
comstudmarun: I can't think of a clean way to do it18:19
comstudoffhand18:19
SumitNaiksatamenikanorov__: go ahead18:19
SumitNaiksatamkanzhe_: i am around :-)18:19
maruncomstud: :(18:19
kevinbentoncomstud: do you have a link to the yielding logic you are referring to?18:19
enikanorov__kanzhe_: you're saying for DSR it's router_id and subnet_id, so service context is two parameters. do we pass them directly to API or we create separate object, and then provide it's ID to a create_loadbalancer?18:20
enikanorov__kanzhe_: so basically it's a choise between:18:20
kanzhe_SumitNaiksatam: Is CLI or API regarding serviceContext captured in the design spec?18:20
SumitNaiksatamenikanorov__: we may not need to create a new object18:20
enikanorov__#1 create-loadbalancer --flavor flavor-dsr --router-id id1 --subnet-id id218:21
marunI have to grab some food18:21
*** bada_ has quit IRC18:21
SumitNaiksatamenikanorov__: essentially what kanzhe is saying is exactly what is proposed in the service_context18:21
maruncomstud: thank you for your patience in explaining things to me!18:21
comstudkevinbenton: give me 10 minutes.. still on a call, actually18:21
comstudno problem18:21
enikanorov__#2 create-service-context  --router-id id1 --subnet-id id218:21
*** bada_ has joined #openstack-neutron18:21
enikanorov__#2.1 create_loadbalancer --flavor flavor-dsr --context context_id18:21
SumitNaiksatamenikanorov__: we are using #1 currently to go with the service_context patch18:22
kanzhe_enikanorov__: either approach is ok. Creating a object will permit the context to be used by other service. For FW case, the context may be large. So it may be a good reason to be an object.18:23
enikanorov__SumitNaiksatam: i see, thanks18:23
SumitNaiksatamenikanorov__: so there is no new resource or object that needs to be created18:23
*** otherwiseguy has quit IRC18:23
SumitNaiksatamkanzhe_: i agree, however enikanorov__ and nachi had reservations about having to create another object18:23
SumitNaiksatamkanzhe_: and it would add another step to the workflow18:23
SumitNaiksatamenikanorov__ kanzhe_: so we have a compromise18:23
enikanorov__yes, i'd prefer #118:23
kanzhe_SumitNaiksatam: understood. I am fine with either approach.18:24
SumitNaiksatamenikanorov__ kanzhe_: we define the notion of a service_context with the expectation that each service understands it18:24
kanzhe_enikanorov__: whichever one is easier to consume by the user.18:24
enikanorov__SumitNaiksatam: kanzhe_: so my initial confusion was about the fact that we're not actually adding 'service context' in API as an attribute.18:24
SumitNaiksatamenikanorov__: the service context is an optinal attribute to each service18:24
enikanorov__instead it's  just a noition that could be some subset of parameters18:24
enikanorov__like router_id, subnet_id, etc18:25
SumitNaiksatamenikanorov__: it is indeed an optional attribute18:25
SumitNaiksatamenikanorov__: but its optional18:25
enikanorov__well, you mean the context itself is an attribute?18:25
*** Adri2000 has quit IRC18:26
enikanorov__or any attrs that i've mentioned are optional?18:26
kanzhe_SumitNaiksatam: enikanorov__ I would argue to make the serviceContext as a required parameter for each service. How a service can be inserted with a context? There is not default insertion.18:26
enikanorov__kanzhe_: right now every service has it's default insertion18:26
enikanorov__we only need context when there is a choice, right?18:27
SumitNaiksatamenikanorov__: yes18:27
*** s3wong_ is now known as s3wong18:27
SumitNaiksatamenikanorov__: the mechanism to specify the choice should ideally be uniform across services18:27
SumitNaiksatamenikanorov__: the service_context aims to do that18:27
kanzhe_enikanorov__: Why can't we capture the default insertion in the context?18:27
SumitNaiksatamenikanorov__: in a backward compatible and non-intrusive manner18:28
*** ijw_ has quit IRC18:28
enikanorov__kanzhe_: then what is a 'required attribute'?18:28
*** alagalah has joined #openstack-neutron18:28
enikanorov__if i don't care about the insertion mode, should i specify it?18:28
kanzhe_enikanorov__: !None18:28
enikanorov__then why do you say it's a required attr?18:29
kanzhe_enikanorov__: Required attribute doesn't mean a required parameter in CLI/API.18:29
kanzhe_enikanorov__: Each service has a default serviceContext if not explicitly overwritten.18:30
*** salv-orlando has quit IRC18:31
*** leseb has joined #openstack-neutron18:31
kanzhe_enikanorov__: For LB and FW, it may be a router. Maybe for VPN too.18:31
enikanorov__kanzhe_: ok, i need probably to read the code. I think i don't fully understand the idea18:32
enikanorov__i need to go now, thanks for the discussion18:32
*** alagalah has quit IRC18:32
kanzhe_enikanorov__: Ok.18:33
enikanorov__let's continue it in the next days18:33
enikanorov__ttyl!18:33
kanzhe_enikanorov__: I think we are on the same page for the need for service context, but differ on how to express it.18:33
enikanorov__may be18:33
kanzhe_Let's discuss more next time. :-)18:34
*** jgallard has quit IRC18:36
*** irenab has joined #openstack-neutron18:38
openstackgerritTomoe Sugihara proposed a change to openstack/neutron: Implement MidoNet plugin for Icehouse (Part 1)  https://review.openstack.org/7854318:38
*** irenab has quit IRC18:44
*** blogan has quit IRC18:45
*** shakayumi has joined #openstack-neutron18:47
*** shakayumi has quit IRC18:47
*** julim has quit IRC18:47
*** mmmucky has joined #openstack-neutron18:48
*** Adri2000 has joined #openstack-neutron18:48
*** Adri2000 has joined #openstack-neutron18:48
*** hemanthravi has quit IRC18:48
*** yfried1 has joined #openstack-neutron18:51
*** blogan has joined #openstack-neutron18:51
*** Gil_McGrath has quit IRC18:54
hogepodgeso pardon my ignorance here, but is nested neutron possible using gre on havana?18:56
*** bada_ has quit IRC18:57
*** jp_at_hp has quit IRC18:58
*** bada_ has joined #openstack-neutron18:58
*** shakayumi has joined #openstack-neutron18:58
*** shakayumi has quit IRC18:58
*** alagalah has joined #openstack-neutron18:59
*** jecarey_ has joined #openstack-neutron19:01
*** dvorkinista has joined #openstack-neutron19:01
*** s3wong has quit IRC19:01
rkukuramarun, kevinbenton, comstud: Please see my comments in https://review.openstack.org/#/c/80413/, and let me know if you think the suggested improvement would still address the issue.19:01
*** jecarey has quit IRC19:01
*** shakayumi has joined #openstack-neutron19:02
*** shakayumi has quit IRC19:02
*** hemanthravi has joined #openstack-neutron19:02
*** hemanthravi has quit IRC19:02
*** jorgem has joined #openstack-neutron19:03
*** jorgem has quit IRC19:03
*** jorgem has joined #openstack-neutron19:03
*** shakayumi has joined #openstack-neutron19:04
*** jorgem1 has quit IRC19:04
kevinbentonrkukura: that should work. i replied inline19:11
rkukurathanks19:11
*** singhs_ has joined #openstack-neutron19:11
rkukurakevinbenton: In https://review.openstack.org/#/c/81367/2/neutron/tests/unit/bigswitch/test_base.py, I don't see self.httpMock being used anywhere.19:12
kevinbentonrkukura: salv-orlando is offline. since this seems to be causing a problem, should i push a new one up for you to review?19:12
*** singhs has quit IRC19:12
*** singhs_ is now known as singhs19:12
kevinbentonrkukura: i reference it in a child class when i need to verify a mock call19:13
kevinbentonrkukura: oh sorry, you're right19:13
kevinbentonrkukura: i forgot i decided to mock the rest method19:13
kevinbentonrkukura: -1 it please and i'll fix it19:14
rkukurakevinbenton: Not really sure about updating salv-orlando's patch. Might be worth trying if he's gone for the day.19:15
rkukurakevinbenton: -1'ed it19:15
openstackgerritKevin Benton proposed a change to openstack/neutron: BigSwitch ML2: Include bound_segment in port  https://review.openstack.org/8136719:16
*** leseb has quit IRC19:17
*** dvorkinista has quit IRC19:18
*** shakayumi has quit IRC19:19
*** rook has quit IRC19:19
*** saju_m has quit IRC19:21
*** saju_m has joined #openstack-neutron19:22
*** vkozhukalov_ has joined #openstack-neutron19:23
*** suresh12 has quit IRC19:25
*** bada_ has quit IRC19:25
*** bada_ has joined #openstack-neutron19:26
*** leseb has joined #openstack-neutron19:26
*** sfox1 has quit IRC19:31
openstackgerritKevin Benton proposed a change to openstack/neutron: Add a semaphore to some ML2 operations  https://review.openstack.org/8041319:32
*** otherwiseguy has joined #openstack-neutron19:34
kevinbentonrkukura, marun: ^^19:34
*** leseb has quit IRC19:36
*** suresh12 has joined #openstack-neutron19:37
*** zzelle has joined #openstack-neutron19:38
*** suresh12 has quit IRC19:38
*** julim has joined #openstack-neutron19:38
*** suresh12 has joined #openstack-neutron19:39
*** alagalah has quit IRC19:40
*** petertoft has joined #openstack-neutron19:42
*** pradipta is now known as pradipta_away19:42
*** petertoft has quit IRC19:43
*** devlaps has quit IRC19:53
*** muhanpong has joined #openstack-neutron19:53
openstackgerritTomoe Sugihara proposed a change to openstack/neutron: Implement MidoNet plugin for Icehouse (Part 1)  https://review.openstack.org/7854319:54
*** otherwiseguy has quit IRC19:54
*** leseb has joined #openstack-neutron19:55
*** tomoe_ has quit IRC19:56
*** jorgem has quit IRC19:58
rkukurakevinbenton, marun: The updated patch looks good to me. Do we want to merge this ASAP, or just test it a few times?19:59
openstackgerritEvgeny Fedoruk proposed a change to openstack/neutron: New SSL extension  https://review.openstack.org/8161219:59
*** jorgem has joined #openstack-neutron20:00
*** muhanpon1 has joined #openstack-neutron20:01
*** kanzhe_ has quit IRC20:01
*** dfarrell17 has joined #openstack-neutron20:02
openstackgerritEvgeny Fedoruk proposed a change to openstack/neutron: New SSL extension  https://review.openstack.org/7403120:05
*** jorgem1 has joined #openstack-neutron20:06
*** dvorkinista has joined #openstack-neutron20:06
*** dfarrell07 has quit IRC20:06
*** muhanpong has quit IRC20:06
*** jorgem has quit IRC20:07
*** devlaps has joined #openstack-neutron20:07
*** saju_m has quit IRC20:08
*** dave_tucker is now known as dave_tucker_zzz20:08
*** saju_m has joined #openstack-neutron20:08
*** samuelbercovici has joined #openstack-neutron20:09
*** tongli has joined #openstack-neutron20:09
*** djoreilly has quit IRC20:09
*** dave_tucker_zzz is now known as dave_tucker20:10
*** dave_tucker is now known as dave_tucker_zzz20:17
*** dfarrell17 has quit IRC20:25
*** baoli has quit IRC20:26
*** alagalah has joined #openstack-neutron20:26
*** dfarrell07 has joined #openstack-neutron20:27
*** alagalah has quit IRC20:32
*** alagalah has joined #openstack-neutron20:34
marunrkukura: Probably makes sense to run some check jobs at least.20:37
rkukuramarun: Makes sense.20:37
*** otherwiseguy has joined #openstack-neutron20:39
comstudkevinbenton, marun: actually, you can probably catch eventlet.hubs.get_hub.switch()20:43
comstudthat is what the current greenthread will call to switch to the hub (scheduler)20:43
comstudto schedule the next greenthread20:43
maruncomstud: can you give a code pointer?20:43
comstudyeah, sec20:44
comstudhttps://github.com/eventlet/eventlet/blob/master/eventlet/hubs/__init__.py#L12120:45
comstudthat is what all of the IO calls hit when they get EAGAIN20:45
comstudyou can see an example of it switching out to the hub here:20:45
comstudhttps://github.com/eventlet/eventlet/blob/master/eventlet/hubs/__init__.py#L15520:45
comstudbut there are cases where the current greenthread will directly switch to another, bypassing the hub20:46
comstudQueue is a case20:46
comstudhttps://github.com/eventlet/eventlet/blob/master/eventlet/queue.py#L28820:46
comstudbut most cases, like if queue is empty and there are no current putters, you'll hit this:20:47
comstudhttps://github.com/eventlet/eventlet/blob/master/eventlet/queue.py#L29920:47
comstudwhich hits this: https://github.com/eventlet/eventlet/blob/master/eventlet/queue.py#L13020:47
comstudwhich is the switch back to the hub, like the trampoline case20:47
*** banix has quit IRC20:47
comstudso get_hub().switch is the most common way the current greenthread yields20:48
maruncomstud: so monkey patching that and then raising an exception when the switch occurs when not wanted?20:49
comstudyeah, that'll hit most cases20:50
maruncomstud: ok, great.20:50
maruncomstud: I was previously thinking that this had to be on all transactions, but maybe it needs to be more selective...20:50
comstudsomething using a Queue could hit edge cases where the current greenthread switches directly to another greenthread20:50
comstudwhere you can't really easily predict which one, so you can't really catch it20:51
maruncomstud: so that's where logging might come in handy so we can trace things manually.20:51
comstudI can't see why trapping a switch *back* to the current greenthread wouldn't also give you what you want, though20:51
*** coolsvap has quit IRC20:51
comstudI mean, you detect it late, but you'll detect it 100% of the time20:51
*** dvorkinista has quit IRC20:51
*** harlowja is now known as harlowja_away20:52
maruncomstud: So long as it's detected, yeah.20:52
maruncomstud: and what's the call to switch back?20:52
comstudthe problem is the traceback would be the other greenthread, so you can't see exactly what caused the switch in the first place20:52
maruncomstud: maybe we need the option of both, then.20:53
sdaguethe neutron deadlock bug still seems to be a problem20:53
sdaguenot sure who's tracking that one now20:53
comstudeventlet.greenthread.getcurrent() would be your current greenthread20:53
*** vkozhukalov_ has quit IRC20:54
*** arosen1 has quit IRC20:54
*** ajo has quit IRC20:54
comstuda .switch() on it is what should switch back20:54
marunsdague: we have a patch in play we want to run check jobs to make sure it's sane20:54
marunsdague: https://review.openstack.org/#/c/80413/20:54
sdaguemarun: great20:54
marunsdague: also we're discussing a more general fix for eventlet yield in transaction w/lock20:54
comstudmarun: yeah, both might be best.. so you get a more useful traceback 99% of the time..20:54
kevinbentoncomstud: thanks for the pointer. do you know what happens if one greenthread spawns another?20:55
comstudthe current greenthread stays active20:55
kevinbentoncomstud: will that just queue it20:55
comstudthe new greenthread gets put on the scheduling list20:55
comstudyeah20:55
kevinbentoncomstud: ok20:55
sdaguemarun: well 80413 seems to have failed the neutron tests, though I don't see the deadlock in the logs20:56
maruncomstud: so the other question, is there any harm in yielding in a transaction that holds no explicit lock?20:56
marunsdague: patch set 2 failed20:56
marunsdague: 3 is still running20:56
sdagueoh, I missed that, sorry20:56
kevinbentonmarun: i think it just failed 6 mins ago, didn't it?20:56
marunkevinbenton: the check job for the previous patch reported 6m ago20:57
marunkevinbenton: still waiting on the results for the current patch20:57
kevinbentonoh, the with statement i used doesn't work in py2620:57
comstudmarun: if there happens to be no DB lock acquired before the yield, i would think it would be fine20:57
maruncomstud: ok, so initially it probably makes sense to prevent yields always20:58
comstudbut i'm not sure you can predict that without knowledge of the DB backend20:58
kevinbentonhttp://logs.openstack.org/13/80413/3/check/gate-neutron-python26/5e589f5/console.html20:58
comstudwhich seems like a bad assumption20:58
maruncomstud: then we'll probably want to see about tieing into sqlalchemy so that only explicity locking prevents yield20:58
comstudthis problem goes completely away when we use Thread pools for DB calls20:58
marun(both in a transaction, of course)20:58
comstudbut we need an eventlet fix for that too20:59
maruncomstud: when is that scheduled to happen?20:59
comstudthey have a patch, i question whether it performs well20:59
maruncomstud: who has a patch?  I'm unclear as to where this work would be done (library, project, etc)21:00
comstudeventlet21:00
comstudi think it's issue 13721:00
comstud*cehecks*21:00
comstudhttps://bitbucket.org/eventlet/eventlet/issue/137/21:01
comstudit's a long read21:01
*** nati_ueno has joined #openstack-neutron21:01
comstudor actually, my proposed fix: https://bitbucket.org/eventlet/eventlet/pull-request/29/fix-use-of-semaphore-with-tpool-issue-137/diff21:01
comstudis a long read21:01
comstudmy proposed fix is not quite fool proof, so it didn't merge21:01
maruncomstud: so timeline for a proper fix is indeterminate, gotcha21:02
comstudcorrect21:02
comstudwe've been using my patch on a limted basis in public cloud21:03
maruncomstud: just checking whether it makes sense to put effort into the workaround, it sounds like it is worthwhile.21:03
comstudbut it's not perfect21:03
comstudanyway, this is what caused me to look at alternatives to eventlet21:03
marunand are there any?21:04
comstudgevent is based on eventlet so has the same issues21:04
marunjava/go/node.js? :p21:04
comstudanything else is a radical change in how we do things21:04
marun(i kid, i love python)21:04
comstudhaha21:04
kevinbentonperl21:04
marunlol21:04
comstudanyway, so I have something that's thread safe that has a compatible API21:05
comstudwritten in C21:05
marunan eventlet replacement?21:05
comstudso it also happens to be much faster than eventlet21:05
comstudyeah21:05
marunand why aren't we using it?21:05
*** manishg has joined #openstack-neutron21:05
comstudit's not quite done... and i was deciding on a name..  I need to put it up on github now that I have one21:05
comstudit's like 90% usable probably21:05
*** leseb has quit IRC21:05
kevinbentonrestricted to a single thread? :-)21:05
comstudno, completely thread safe!21:06
comstudit actually uses threads internally to get some more parallelism wrt doing I/O21:06
comstudbut even without that, most operations take about 10% of the time of eventlet21:07
comstudlike greenthread switching/scheduling21:07
maruncomstud: and what's the catch?  :)21:07
comstudkinda started out as a fun side project, but I think it's proven to me so far it could be a replacement21:07
maruncomstud: It sounds great.21:07
comstudcatch is it's not quite done and probably has unknown bugs!21:07
comstud:)21:07
comstudanyway, Coming Soon (tm).21:08
maruncomstud: ah, fair enough.21:08
maruncomstud: look forward to seeing it!21:08
openstackgerritKevin Benton proposed a change to openstack/neutron: Add a semaphore to some ML2 operations  https://review.openstack.org/8041321:08
kevinbentonmarun: ^^21:08
kevinbentonsyntax i used was not py26 acceptable21:09
kevinbentonrkukura: ^^21:09
marunkevinbenton: let's make sure it passes the check jobs consistently at least a couple of times and then we can merge and see if it improves the gate failure rate21:10
comstudbbs, late food break21:11
maruncomstud: ciao21:11
kevinbentonmarun: can you re-assign the parent bug to salv-orlando? https://bugs.launchpad.net/neutron/+bug/128352221:11
kevinbentonmarun: every time i patch it re-assigns it21:12
jogofor the lastest neutron bug: its older then we thought https://review.openstack.org/#/c/81604/21:13
*** thuc__ has quit IRC21:14
*** harlowja_away is now known as harlowja21:14
*** thuc has joined #openstack-neutron21:15
*** thuc_ has joined #openstack-neutron21:17
*** RajeshMohan has quit IRC21:17
*** thuc_ has quit IRC21:17
jogolooks like there was a big spike on 3/1221:17
jogomarun: ^21:17
*** mwagner__ has quit IRC21:17
*** carlp has quit IRC21:17
*** baoli has joined #openstack-neutron21:17
*** thuc_ has joined #openstack-neutron21:18
*** RajeshMohan has joined #openstack-neutron21:18
*** thuc_ has quit IRC21:18
*** thuc_ has joined #openstack-neutron21:18
*** thuc_ has quit IRC21:19
*** thuc has quit IRC21:19
*** tvardeman has quit IRC21:20
*** thuc has joined #openstack-neutron21:20
*** mlavalle has quit IRC21:25
*** bvandenh has quit IRC21:27
*** sweston has quit IRC21:27
*** saju_m has quit IRC21:28
openstackgerritDhanashree Gosavi proposed a change to openstack/neutron: Add support for router scheduling in Cisco N1kv Plugin  https://review.openstack.org/7732321:30
marunjogo: danke21:31
marunkevinbenton: if you're working on it, you can own it for now :)21:31
marunsalv-orlando is probably happy to not have responsibility for it.  he's always stepping up because somebody has to, but he's also chronically overworked.  (though feel free to correct me, salv-orlando, if I'm wrong!)21:32
kevinbentonmarun: i think he's offline for the night (~UTC), which is why i proposed a new patch21:33
kevinbentonmarun: since this seems to be painful in the gate21:33
kevinbentonmarun: it's selfish as much as anything. i have 8 patches doing battle in the gate :-)21:34
marunkevinbenton: for critical bugs, I don't think patch ownership really comes into it.  If you can move things forward, great.21:34
*** skath has quit IRC21:35
*** suresh12 has quit IRC21:37
*** BuSerD has joined #openstack-neutron21:39
*** suresh12 has joined #openstack-neutron21:39
*** suresh12 has quit IRC21:40
rkukuramarun, kevinbenton: Did we decide whether to do a few rechecks with this first, or just merge it ASAP?21:43
kevinbentonrkukura: with the currently failure rate, i suggest we merge now21:44
kevinbentonrkukura: it will implicitly get checked many times due to the gate resets21:44
kevinbentonrkukura: and if one of them fails it will get dumped back to us21:45
rkukurakevinbenton: true21:45
*** SumitNaiksatam has quit IRC21:46
*** krtaylor has quit IRC21:46
*** suresh12 has joined #openstack-neutron21:47
*** dguitarbite_ has joined #openstack-neutron21:48
rkukurakevinbenton: gave it my +2, will be AFK for a while21:48
kevinbentonrkukura: sounds good21:48
*** oda-g has joined #openstack-neutron21:49
*** leseb has joined #openstack-neutron21:49
*** networkstatic is now known as networkstatic_zZ21:52
*** krtaylor has joined #openstack-neutron21:52
oda-gnati_ueno: ping21:54
*** zzelle has quit IRC21:56
*** jobewan has quit IRC22:00
*** dvorkinista has joined #openstack-neutron22:01
*** jecarey_ has quit IRC22:02
*** devlaps has quit IRC22:03
marunkevinbenton: I can approve then22:08
marunkevinbenton: as soon as gate check passes22:09
*** gdubreui has joined #openstack-neutron22:09
kevinbentonmarun: ok22:11
*** ijw has joined #openstack-neutron22:13
*** devlaps has joined #openstack-neutron22:18
*** armax has quit IRC22:19
*** sweston has joined #openstack-neutron22:26
openstackgerritA change was merged to openstack/neutron: BigSwitch: Watchdog thread start after servers  https://review.openstack.org/8109022:29
openstackgerritA change was merged to openstack/neutron: Add session persistence support for NVP advanced LBaaS  https://review.openstack.org/5914622:29
*** dfarrell07 has quit IRC22:30
*** thuc has quit IRC22:33
*** thuc has joined #openstack-neutron22:33
*** arosen1 has joined #openstack-neutron22:36
*** thuc has quit IRC22:38
*** SridharG has quit IRC22:39
marunkevinbenton: still py26 error?22:39
*** _cjones_ has quit IRC22:42
*** thedodd has quit IRC22:42
*** mwagner__ has joined #openstack-neutron22:42
*** _cjones_ has joined #openstack-neutron22:42
openstackgerritIan Wienand proposed a change to openstack/neutron: Record and log reason for dhcp agent resync  https://review.openstack.org/8117322:45
*** jorgem1 has quit IRC22:45
*** ijw has quit IRC22:49
*** dims has quit IRC22:51
*** ijw has joined #openstack-neutron22:53
*** SumitNaiksatam has joined #openstack-neutron22:53
*** armax has joined #openstack-neutron22:58
*** harlowja is now known as harlowja_away22:59
kevinbentonmarun: no, that was a timeout error23:02
kevinbentonmarun: that hit on some other patches too23:02
marunkevinbenton: so problem on the infra side?23:02
kevinbentonmarun: i think something changed in the gate on the limit23:02
kevinbentonmarun: yeah23:02
kevinbentonmarun: i filed the bug i referenced, but it might be invalid because i filed it in the neutron project23:03
*** sneezewort has quit IRC23:03
marunkevinbenton: hmmm.  so a timeout as in the job took too long?23:04
kevinbentonmarun: yeah23:04
*** yamahata has quit IRC23:04
marunyee.  our unit tests suck23:04
kevinbentonmarun: they are just really extensive23:04
kevinbentonmarun: :-)23:04
marunkevinbenton: no, they suck :)23:04
marunkevinbenton: It's my priority to fix them as of last week, but I keep getting sidelined.23:05
kevinbentonmarun: to know if the XML encoding REALLY works, you must run all of the unit tests twice ;-)23:05
marunkevinbenton: ….and tempest, don't forget tempest23:05
marunkevinbenton: without running the same code paths at least 1000 times we have no guarantee that things will work!23:05
*** nati_ueno has quit IRC23:07
*** dims has joined #openstack-neutron23:07
kevinbentonmarun: new lines of code are like new shoes. you have to break them in before you can find out if they will work23:08
marunkevinbenton: i mean, just because a statement worked one way, doesn't mean it will work another.23:08
*** otherwiseguy has quit IRC23:13
*** ijw has quit IRC23:13
*** tongli has quit IRC23:13
*** blogan has quit IRC23:18
openstackgerritIan Wienand proposed a change to openstack/neutron: Log dnsmasq host file generation  https://review.openstack.org/7984323:19
*** armax has quit IRC23:20
openstackgerritA change was merged to openstack/neutron: API layer documentation  https://review.openstack.org/7967523:20
openstackgerritIan Wienand proposed a change to openstack/neutron: Log dnsmasq host file generation  https://review.openstack.org/7984323:20
*** zhipeng has joined #openstack-neutron23:26
*** thuc has joined #openstack-neutron23:28
*** sweston has quit IRC23:34
*** overlayer has quit IRC23:36
*** harlowja_away is now known as harlowja23:38
*** kfox1111 has joined #openstack-neutron23:41
kfox1111So... About once a day, I'm seeing qpid-stat show:23:41
kfox1111q-plugin                                                      5.81k  1.72m  1.72m   3.76m  1.11g    1.11g        1     223:42
kfox11115.81 thousand stuck messages. restarting neutron-server causes it to drain the queue.23:42
kfox1111what could cause this?23:42
openstackgerritDhanashree Gosavi proposed a change to openstack/neutron: Add support for router scheduling in Cisco N1kv Plugin  https://review.openstack.org/7732323:43
*** singhs has quit IRC23:43
*** networkstatic_zZ is now known as networkstatic23:44
kevinbentonmarun: still around?23:53
marunkevinbenton: yes23:53
openstackgerritEvgeny Fedoruk proposed a change to openstack/neutron: Cancelling thread start while unit tests running  https://review.openstack.org/8132323:53
*** armax has joined #openstack-neutron23:54
kevinbentonmarun: should be receiving a verdict from jenkins on the ML2 patch shortly23:54
*** leseb has quit IRC23:54
kevinbentonmarun: if it passes it would be good to send it to war with the gate for the evening23:54
kevinbentonmarun: well it looks like it will pass, only job is non-voting23:55
marunkevinbenton: ok23:55
*** mwagner_dontUseM is now known as mwagner23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!