| openstackgerrit | A change was merged to openstack/neutron: Fix downgrade in migration https://review.openstack.org/53091 | 00:00 |
|---|---|---|
| *** jianingy_afk is now known as jianingy | 00:16 | |
| *** dims has quit IRC | 00:21 | |
| openstackgerrit | Salvatore Orlando proposed a change to openstack/neutron: Test commit for testing parallel job in experimental queue https://review.openstack.org/57420 | 00:23 |
| *** Abhishek_ has quit IRC | 00:31 | |
| *** dims has joined #openstack-neutron | 00:33 | |
| *** Abhishek has joined #openstack-neutron | 00:34 | |
| *** SridarK has quit IRC | 00:38 | |
| *** aymenfrikha has quit IRC | 00:40 | |
| *** banix has quit IRC | 00:40 | |
| *** harlowja has quit IRC | 00:40 | |
| *** harlowja has joined #openstack-neutron | 00:42 | |
| openstackgerrit | Jianing Yang proposed a change to openstack/neutron: Fix str2dict and dict2str's incorrect behavior https://review.openstack.org/60195 | 00:46 |
| *** Abhishek has quit IRC | 00:49 | |
| openstackgerrit | Edgar Magana proposed a change to openstack/neutron: Implements provider network support in PLUMgrid plugin https://review.openstack.org/60383 | 00:50 |
| *** mestery has quit IRC | 01:04 | |
| *** mestery has joined #openstack-neutron | 01:05 | |
| *** Abhishek has joined #openstack-neutron | 01:07 | |
| *** Abhishek has quit IRC | 01:11 | |
| *** annegentle has quit IRC | 01:18 | |
| *** mengxd has joined #openstack-neutron | 01:20 | |
| *** annegentle has joined #openstack-neutron | 01:25 | |
| *** dzyu has joined #openstack-neutron | 01:48 | |
| openstackgerrit | berlin proposed a change to openstack/neutron: Add Error Handling to NVP advanced LBaaS/FWaaS https://review.openstack.org/59625 | 01:53 |
| *** marun has joined #openstack-neutron | 01:59 | |
| *** dzyu_ has joined #openstack-neutron | 02:00 | |
| *** dzyu has quit IRC | 02:01 | |
| *** dzyu_ is now known as dzyu | 02:01 | |
| *** julim has quit IRC | 02:06 | |
| *** Jianyong has joined #openstack-neutron | 02:14 | |
| *** changbl has joined #openstack-neutron | 02:16 | |
| *** rkukura has joined #openstack-neutron | 02:21 | |
| *** yamahata_ has joined #openstack-neutron | 02:28 | |
| *** mestery has quit IRC | 02:30 | |
| *** djbkd has joined #openstack-neutron | 02:30 | |
| *** mestery has joined #openstack-neutron | 02:33 | |
| openstackgerrit | gongysh proposed a change to openstack/python-neutronclient: refactor showcommand and RetrivePoolStats command https://review.openstack.org/47292 | 02:34 |
| marun | salv-orlando: ping | 02:38 |
| salv-orlando | marun: pong | 02:39 |
| marun | salv-orlando: my, you're up early? | 02:40 |
| salv-orlando | marun: nope about to go to bed (2.40 am) | 02:40 |
| marun | salv-orlando: ah, uk? | 02:40 |
| marun | salv-orlando: I'll make it quick, sorry. | 02:40 |
| salv-orlando | marun: correct. | 02:40 |
| salv-orlando | go ahead. Don't give me the nightmares please | 02:40 |
| marun | salv-orlando: if the neutron service is restarted, does it notify the agents? | 02:40 |
| salv-orlando | it does not. | 02:41 |
| salv-orlando | I don't think the agents get any notification when a neutron server goes down/up | 02:41 |
| salv-orlando | indeed they keep sending state reports even if nobody listens | 02:41 |
| marun | salv-orlando: Someone on the mailing list was asking about that in regards to the agents staying in sync if the service goes down | 02:41 |
| marun | salv-orlando: but when I think about it, if the service is down no changes are going to be made until it starts again anyway | 02:42 |
| marun | salv-orlando: so, null question. don't let me keep you any longer. :) | 02:42 |
| salv-orlando | indeed, this is why I am struggling to understand the question | 02:42 |
| salv-orlando | I don't think there's any need for agent-2-agent synchronization | 02:42 |
| marun | salv-orlando: his email wasn't entirely coherent. | 02:42 |
| marun | salv-orlando: and my questions reflects that. I'm sorted now. | 02:42 |
| salv-orlando | btw, question for you, before I head to bed | 02:42 |
| marun | shoot | 02:42 |
| salv-orlando | ovs commands; I'm seeing them timing out | 02:43 |
| salv-orlando | locally and on the gate - a lot | 02:43 |
| marun | yee | 02:43 |
| *** SumitNaiksatam has quit IRC | 02:43 | |
| salv-orlando | is this new to you? | 02:43 |
| marun | yes, new to me | 02:43 |
| *** devlaps has quit IRC | 02:43 | |
| *** alagalah_ has joined #openstack-neutron | 02:43 | |
| marun | does that imply that ovs is overloaded? | 02:44 |
| *** djbkd has quit IRC | 02:44 | |
| salv-orlando | my guess is that we did not go a good thing by parallelising operations which interacted with ovs | 02:44 |
| salv-orlando | I'm not talking about the ovs db monitor | 02:44 |
| marun | Right | 02:44 |
| salv-orlando | but other things such as process_routers | 02:44 |
| marun | Is this a new move to parallize? | 02:44 |
| salv-orlando | recent move. The problem is that ovs-vswitchd is single-threaded in the version we run on the gate; and only the most recent version (2.0) is multithreaded | 02:45 |
| marun | I think we're running into a pretty serious problem of contention for CPU resources. | 02:45 |
| salv-orlando | or perhaps we're just asking too much to the agents when running gate tests with tenant isolation, parallelism and so on | 02:46 |
| marun | Well, I'm betting the cpu on a given devstack test instance is pegged 100% all the time. | 02:46 |
| marun | Maybe we need to start fiddling with priority? | 02:46 |
| salv-orlando | actually they log sysstat le me check | 02:46 |
| salv-orlando | yeah during high stress period cpu_idle is pretty much 0 | 02:48 |
| marun | salv-orlando: So, priority? | 02:49 |
| marun | salv-orlando: I mean, ovs > neutron service > agents | 02:49 |
| salv-orlando | Yes tomorrow among the other things I will try and nice ovs commands | 02:49 |
| marun | salv-orlando: I'm not sure this is a problem in the real world, frankly. Operators don't let hosts run at 100%, they know better. | 02:49 |
| marun | (at least, I hope they do) | 02:50 |
| salv-orlando | marun: I agree with you, this is why I said we're asking too much from the gate | 02:50 |
| marun | salv-orlando: I would tend to agree. Mind you, we'd have to do this eventually anyway (make sure services play nice). It just sucks that it's all coming at us at once right now. | 02:50 |
| salv-orlando | Another thing we should consider is to change the "tenant isolation" rules to avoid creating network/subnet/router pretty much for each test | 02:51 |
| marun | salv-orlando: ok, sleep well! | 02:51 |
| marun | salv-orlando: hmmm. right, the setup/teardown is pretty crazy | 02:51 |
| salv-orlando | At some point I got the l3 agents processing 40 routers in a minute | 02:52 |
| marun | salv-orlando: ! | 02:52 |
| marun | salv-orlando: that's pretty much insance | 02:52 |
| salv-orlando | I mean receiving 40 notification to process routers | 02:52 |
| salv-orlando | it took 114 seconds to process them | 02:52 |
| marun | salv-orlando: sorry, insane | 02:52 |
| marun | Well, we should raise the issue with qa. They seem to be of the opinion that stress testing like this is a good thing. | 02:53 |
| salv-orlando | yup, this is stress testing; in the case of nova-network, I think they exercise in a flat scenarion | 02:53 |
| marun | But dealing with unrealistic scenarios is keeping us from focusing on actual use cases. | 02:53 |
| salv-orlando | and the flat scenario is nowhere that demanding in terms of operation for implementing the network | 02:53 |
| marun | right | 02:53 |
| *** banix has joined #openstack-neutron | 02:54 | |
| salv-orlando | ok, let's say if I don't get anywhere by nicing ovs and ip commands I will resort to revisiting how tempest sets up the network | 02:54 |
| marun | Sounds good. | 02:54 |
| salv-orlando | goodnight! | 02:55 |
| marun | 'nite! | 02:55 |
| salv-orlando | or good morning to you | 02:55 |
| *** salv-orlando has quit IRC | 02:55 | |
| *** csd has quit IRC | 02:57 | |
| mestery | marun: Sorry, back reading your discussion with salv-orlando, you still here? | 02:58 |
| marun | mestery: yes. you're up early! | 02:58 |
| marun | (or late?) | 02:58 |
| *** csd has joined #openstack-neutron | 02:58 | |
| mestery | marun: 9PM in Minnesota. :) Where are you at? | 02:58 |
| marun | JST - high noon | 02:59 |
| mestery | marun: So, after reading the back scroll, one thing that occurs to me is this: What version of OVS are we using in the gate? | 02:59 |
| marun | mestery: not 2.0, sadly | 02:59 |
| mestery | marun: That's where I was headed. | 02:59 |
| mestery | But even worse, is it version 1.4 we're using in the gate? | 02:59 |
| mestery | Because that is incredibly old. :( | 02:59 |
| marun | mestery: maybe? I'm guessing it's whatever shipped with 12.04 | 03:00 |
| mestery | Good Lord, then it's 1.4. | 03:00 |
| mestery | We need to change that somehow. | 03:00 |
| mestery | Nobody in their right mind would run 1.4 in production. | 03:00 |
| mestery | Or anything close to production. | 03:00 |
| marun | mestery: I'm afraid I'm ignorant as to why 1.4 is a problem, can you please enlighten me? | 03:00 |
| mestery | marun: Running OVS 1.4 in the gate would be like trying to test OVS with OpenStack Diablo. | 03:00 |
| mestery | Lots of things have been fixed since then, performance enhancements made, etc. | 03:01 |
| mestery | Anyways, just a thought as I read the back scroll. | 03:01 |
| marun | mestery: well, to be honest we're not doing anything complicated in the gate (yet) | 03:01 |
| mestery | I agree, I think we're somewhat limited by the agents at this point, I guess I'm just thinking ahead here. | 03:02 |
| marun | mestery: provisioning ports and adding simple flows is about the extent of it. Agreed that this is not representative of production, but it might still do for now. | 03:02 |
| marun | mestery: I think the fact that it's single-threaded is the biggest issue that might require updating. As per salv-orlando's comment, the current tenant isolation scheme puts excessive load on ovs. | 03:02 |
| * mestery nods in agreement. | 03:03 | |
| marun | mestery: but we're going to be fighting for cpu regardless :( | 03:03 |
| mestery | marun: Yes, that's true either way. | 03:03 |
| marun | mestery: My recent experiences with high load suggest that our current testing single-node testing strategy isn't really sustainable. | 03:03 |
| marun | mestery: we end up hitting bugs that aren't really problems. Everything falls over eventually (short of running on a mainframe, and even then) | 03:04 |
| marun | mestery: (not that we don't have bugs that are really problems, of course) | 03:04 |
| mestery | marun: Agreed, so even without Neutron things woudl tip over eventually in that scenario. | 03:04 |
| marun | mestery: I think so, yes. There is only so much cpu to go around and we are running more and more services on that single node. Something has to give eventually. | 03:04 |
| marun | mestery: neutron is just the canary in the coal mine | 03:05 |
| mestery | marun: I agree. | 03:05 |
| mestery | marun: And even the multi-node gate stuff I'm looking at for ML2 won't help, as it still leaves all control code on a single node. | 03:05 |
| marun | mestery: something tells me tripleo and heat might be necessary and soon | 03:07 |
| mestery | marun: Agreed. | 03:07 |
| mestery | marun: OK, I need to take off for a bit now. | 03:07 |
| mestery | marun: Thanks for the chat! | 03:07 |
| marun | mestery: either that or we look at making the default tempest gate less of a stress test to focus on the functional. | 03:07 |
| marun | mestery: thanks to you as well, take care! | 03:07 |
| *** SumitNaiksatam has joined #openstack-neutron | 03:10 | |
| *** dzyu has quit IRC | 03:11 | |
| *** dzyu has joined #openstack-neutron | 03:16 | |
| *** jp_at_hp has quit IRC | 03:20 | |
| *** nati_ueno has quit IRC | 03:24 | |
| *** alagalah_ has left #openstack-neutron | 03:29 | |
| *** amotoki_ has quit IRC | 03:37 | |
| openstackgerrit | John Dewey proposed a change to openstack/neutron: Removed erronus config file comment https://review.openstack.org/60413 | 03:38 |
| *** dzyu has quit IRC | 03:40 | |
| *** julim has joined #openstack-neutron | 03:41 | |
| *** nati_ueno has joined #openstack-neutron | 03:41 | |
| openstackgerrit | A change was merged to openstack/neutron: Change to improve dhcp-agent sync_state https://review.openstack.org/59863 | 03:42 |
| *** julim has quit IRC | 03:45 | |
| *** nati_uen_ has joined #openstack-neutron | 03:54 | |
| *** nati_ueno has quit IRC | 03:57 | |
| *** suresh12 has quit IRC | 04:01 | |
| *** banix has quit IRC | 04:03 | |
| *** banix has joined #openstack-neutron | 04:08 | |
| *** yamahata_ has quit IRC | 04:17 | |
| *** nati_uen_ has quit IRC | 04:22 | |
| *** gongysh has joined #openstack-neutron | 04:23 | |
| *** banix has quit IRC | 04:40 | |
| *** networkstatic has joined #openstack-neutron | 04:42 | |
| *** csd has quit IRC | 04:57 | |
| *** csd has joined #openstack-neutron | 04:58 | |
| *** mengxd has quit IRC | 05:02 | |
| *** ljjjustin has joined #openstack-neutron | 05:07 | |
| *** suresh12 has joined #openstack-neutron | 05:12 | |
| *** suresh12 has quit IRC | 05:16 | |
| *** x86brandon has quit IRC | 05:26 | |
| openstackgerrit | John Dewey proposed a change to openstack/neutron: Removed erronus config file comment https://review.openstack.org/60413 | 05:30 |
| *** chandankumar has joined #openstack-neutron | 05:34 | |
| *** bvandenh has joined #openstack-neutron | 05:36 | |
| *** yfried has joined #openstack-neutron | 05:40 | |
| marun | fark | 06:03 |
| *** suresh12 has joined #openstack-neutron | 06:05 | |
| *** nati_ueno has joined #openstack-neutron | 06:08 | |
| *** amotoki has quit IRC | 06:28 | |
| openstackgerrit | Jenkins proposed a change to openstack/neutron: Imported Translations from Transifex https://review.openstack.org/60430 | 06:32 |
| *** alex_klimov has joined #openstack-neutron | 06:36 | |
| *** alex_klimov has quit IRC | 06:42 | |
| *** alex_klimov has joined #openstack-neutron | 06:43 | |
| *** alex_klimov has quit IRC | 06:43 | |
| *** alex_klimov has joined #openstack-neutron | 06:44 | |
| *** alex_klimov has quit IRC | 06:46 | |
| openstackgerrit | Aaron Rosen proposed a change to openstack/neutron: Bump api_workers from 0 to 4 https://review.openstack.org/59787 | 06:56 |
| *** Jianyong has quit IRC | 07:06 | |
| *** Jianyong has joined #openstack-neutron | 07:09 | |
| *** gdubreui has quit IRC | 07:21 | |
| *** yfried has quit IRC | 07:30 | |
| *** ihrachyska has joined #openstack-neutron | 07:45 | |
| *** yfried has joined #openstack-neutron | 07:45 | |
| *** afazekas_ has joined #openstack-neutron | 07:49 | |
| *** suresh12 has quit IRC | 07:52 | |
| *** suresh12 has joined #openstack-neutron | 07:52 | |
| *** suresh12 has quit IRC | 07:53 | |
| *** nati_uen_ has joined #openstack-neutron | 07:54 | |
| *** nati_ueno has quit IRC | 07:58 | |
| *** alagalah has joined #openstack-neutron | 08:01 | |
| *** alagalah has quit IRC | 08:02 | |
| *** SumitNaiksatam has quit IRC | 08:03 | |
| *** gongysh has quit IRC | 08:03 | |
| *** Alien__ has joined #openstack-neutron | 08:05 | |
| *** csd has quit IRC | 08:08 | |
| *** jlibosva has joined #openstack-neutron | 08:08 | |
| *** csd has joined #openstack-neutron | 08:09 | |
| *** amritanshu_RnD has joined #openstack-neutron | 08:17 | |
| anteaya | jog0: yeah, if I can get a logstash url for https://bugs.launchpad.net/neutron/+bug/1210483 in the bug report, it would help me track the ongoing current status of the bug, and help me recruit someone to champion the bug | 08:19 |
| anteaya | so far, noone in -neutron is working on it, that I know of | 08:19 |
| anteaya | how do I get you an entry in a neutron service? I can look for it if I can learn how. | 08:20 |
| anteaya | Yes, I was hearing about the reduction for large-ops tests, thanks for that. | 08:20 |
| *** nati_uen_ has quit IRC | 08:20 | |
| anteaya | and I am glad 1250168 was due to host issues and is no longer a bug for us, yay | 08:21 |
| anteaya | marun: I asked your cpu usage on a devstack test instance question in -infra | 08:24 |
| anteaya | you are welcome to follow up or I will relay back if/when I get a response | 08:24 |
| *** beagles has quit IRC | 08:26 | |
| *** pete5_ has joined #openstack-neutron | 08:28 | |
| *** ivoks_ has joined #openstack-neutron | 08:29 | |
| *** beagles has joined #openstack-neutron | 08:29 | |
| *** mtreinish_ has joined #openstack-neutron | 08:34 | |
| *** pete5 has quit IRC | 08:34 | |
| *** lifeless has quit IRC | 08:34 | |
| *** ivoks has quit IRC | 08:34 | |
| *** Qlawy has quit IRC | 08:34 | |
| *** Qlawy has joined #openstack-neutron | 08:34 | |
| *** mtreinish has quit IRC | 08:34 | |
| *** mtreinish_ is now known as mtreinish | 08:35 | |
| *** pete5_ is now known as pete5 | 08:35 | |
| *** Qlawy has quit IRC | 08:35 | |
| *** Qlawy has joined #openstack-neutron | 08:35 | |
| *** networkstatic has quit IRC | 08:35 | |
| *** networks_ has joined #openstack-neutron | 08:35 | |
| *** jprovazn has joined #openstack-neutron | 08:35 | |
| *** lifeless has joined #openstack-neutron | 08:36 | |
| *** Jianyong has quit IRC | 08:37 | |
| *** ljjjustin has quit IRC | 08:37 | |
| *** ljjjustin has joined #openstack-neutron | 08:39 | |
| *** networks_ has quit IRC | 08:43 | |
| *** ygbo has joined #openstack-neutron | 08:43 | |
| *** networkstatic has joined #openstack-neutron | 08:45 | |
| *** jistr has joined #openstack-neutron | 08:48 | |
| *** jp_at_hp has joined #openstack-neutron | 08:54 | |
| *** suresh12 has joined #openstack-neutron | 09:04 | |
| *** networkstatic has quit IRC | 09:05 | |
| *** jlibosva has quit IRC | 09:05 | |
| *** networkstatic has joined #openstack-neutron | 09:06 | |
| *** jlibosva has joined #openstack-neutron | 09:06 | |
| marun | anteaya: ok, thank you | 09:07 |
| openstackgerrit | Oleg Bondarev proposed a change to openstack/neutron: Mark dhcp ports as pending delete on subnet deletion https://review.openstack.org/46496 | 09:07 |
| openstackgerrit | A change was merged to openstack/neutron: Imported Translations from Transifex https://review.openstack.org/60430 | 09:07 |
| *** suresh12 has quit IRC | 09:08 | |
| *** jpich has joined #openstack-neutron | 09:11 | |
| *** fouxm has joined #openstack-neutron | 09:11 | |
| openstackgerrit | Marios Andreou proposed a change to openstack/neutron: Validate CIDR given as ip-prefix in security-group-rule-create https://review.openstack.org/59212 | 09:16 |
| anteaya | :D | 09:16 |
| *** jlibosva has quit IRC | 09:24 | |
| *** jlibosva has joined #openstack-neutron | 09:24 | |
| *** jlibosva has joined #openstack-neutron | 09:25 | |
| *** ljjjustin has quit IRC | 09:27 | |
| *** Alien__ has quit IRC | 09:35 | |
| *** Sreedhar has joined #openstack-neutron | 09:39 | |
| Sreedhar | Marun: Hi | 09:45 |
| marun | Sreedhar: hi | 09:45 |
| *** HenryG has quit IRC | 09:47 | |
| *** HenryG has joined #openstack-neutron | 09:47 | |
| Sreedhar | Marun: I am planning to test with the patch you have created https://review.openstack.org/#/c/45678/ to reduce the polling by OVS agents. Just want to check whether the patch need to be installed only network node (where DHCP agent is running) or on all the compute nodes as well | 09:47 |
| marun | Sreedhar: it reduces l2 polling, so anywhere the l2 agent runs would benefit. that said, it's not necessary unless cpu load is important, which is certainly the case for a network control node. | 09:49 |
| Sreedhar | My Network node has 6 cores/12 threads. I don't see any high cpu utilization during the instance creation and when instances are booting on network node | 09:50 |
| *** pashi has quit IRC | 09:51 | |
| *** rdo has quit IRC | 09:51 | |
| *** pashi_ has joined #openstack-neutron | 09:51 | |
| *** rdo has joined #openstack-neutron | 09:51 | |
| marun | Sreedhar: you're unlikely to see any benefit, then. | 09:53 |
| marun | Sreedhar: I'm assuming the node running the neutron service is the bottleneck then? | 09:53 |
| Sreedhar | Marun: What i observed, during the instance creation even though we have 8 neutron API server process, only single neutron-server was very busy and running close to 100% cpu | 09:54 |
| marun | Sreedhar: right. | 09:54 |
| marun | Sreedhar: the rpc-initiated db queries | 09:55 |
| marun | Sreedhar: That's the thing to profile | 09:55 |
| *** steven-weston has joined #openstack-neutron | 09:55 | |
| Sreedhar | Marun: can you guide me how to profile that so that i can enable the profiling and collect the data | 09:56 |
| marun | Sreedhar: Sure | 09:56 |
| marun | Sreedhar: Here is a good guide on stackoverflow: http://stackoverflow.com/questions/582336/how-can-you-profile-a-python-script | 09:56 |
| marun | Sreedhar: The idea is that you would run the neutron service with the profiler. | 09:56 |
| marun | Sreedhar: Then boot a single vm through nova and be able to ping it, and then shutdown the service to collect those results. | 09:57 |
| marun | Sreedhar: Are you running from source or packages? | 09:57 |
| Sreedhar | Marun: From the Packages (have installed it from Ubuntu Cloud Ring) | 09:58 |
| *** safchain has joined #openstack-neutron | 09:59 | |
| marun | Sreedhar: you'll need to dig into the daemon script that starts the neutron service to figure out what to invoke with the profiler. | 09:59 |
| *** alex_klimov has joined #openstack-neutron | 10:00 | |
| Sreedhar | Marun: Thanks. I will check on this | 10:00 |
| marun | Sreedhar: I'll be interested in seeing the results. I'm pretty sure there will be some easy stuff to optimize. | 10:01 |
| Sreedhar | marun: I will share the results once i am to collect the data | 10:03 |
| *** networkstatic has quit IRC | 10:03 | |
| marun | Sreedhar: my only request is that you profile only a single vm boot. a profiler slows things down tremendously and it would bottleneck in ways inconsistent with regular use. | 10:05 |
| *** netavenger-jr has joined #openstack-neutron | 10:05 | |
| Sreedhar | marun: ok | 10:05 |
| openstackgerrit | Ann Kamyshnikova proposed a change to openstack/neutron: Update lockutils and fixture in openstack.common https://review.openstack.org/47557 | 10:08 |
| openstackgerrit | berlin proposed a change to openstack/neutron: Fix VPNaaS Service driver should check whether router has gateway https://review.openstack.org/60461 | 10:08 |
| *** steven-weston has quit IRC | 10:18 | |
| *** salv-orlando has joined #openstack-neutron | 10:27 | |
| *** Sreedhar has quit IRC | 10:36 | |
| openstackgerrit | Salvatore Orlando proposed a change to openstack/neutron: Test commit for testing parallel job in experimental queue https://review.openstack.org/57420 | 10:38 |
| *** yfujioka has joined #openstack-neutron | 10:58 | |
| *** Sreedhar has joined #openstack-neutron | 11:01 | |
| openstackgerrit | Salvatore Orlando proposed a change to openstack/neutron: Test commit for testing parallel job in experimental queue https://review.openstack.org/57420 | 11:04 |
| *** heyongli has joined #openstack-neutron | 11:08 | |
| *** yfujioka has quit IRC | 11:12 | |
| *** yamahata_ has joined #openstack-neutron | 11:21 | |
| *** pcm_ has joined #openstack-neutron | 11:22 | |
| *** pcm_ has quit IRC | 11:23 | |
| *** pcm_ has joined #openstack-neutron | 11:23 | |
| *** armax has joined #openstack-neutron | 11:25 | |
| openstackgerrit | Ann Kamyshnikova proposed a change to openstack/neutron: Add testing of migrations from oslo https://review.openstack.org/46927 | 11:46 |
| *** yamahata_ has quit IRC | 11:48 | |
| *** ivoks_ is now known as ivoks | 11:55 | |
| *** ivoks has joined #openstack-neutron | 11:55 | |
| *** nati_ueno has joined #openstack-neutron | 12:14 | |
| *** banix has joined #openstack-neutron | 12:16 | |
| *** jp_at_hp1 has joined #openstack-neutron | 12:27 | |
| *** jp_at_hp has quit IRC | 12:30 | |
| openstackgerrit | Dirk Mueller proposed a change to openstack/neutron: Do not concatenate localized strings https://review.openstack.org/52895 | 12:30 |
| *** alex_klimov has quit IRC | 12:33 | |
| *** Sreedhar has quit IRC | 12:34 | |
| marios_ | enikanorov__: enikanorov_ ping - if you get 5 mins - revision better? https://review.openstack.org/#/c/59212/ tx! | 12:41 |
| enikanorov_ | marios_: just left a comment. generally ok except a minor nit | 12:43 |
| *** Sreedhar has joined #openstack-neutron | 12:46 | |
| *** nati_ueno has quit IRC | 12:49 | |
| openstackgerrit | A change was merged to openstack/neutron: Sync dhcp_agent.ini with the codes https://review.openstack.org/59118 | 12:49 |
| marios_ | enikanorov_: ta very much ! | 12:50 |
| *** alex_klimov has joined #openstack-neutron | 12:51 | |
| *** banix has quit IRC | 12:53 | |
| *** yamahata_ has joined #openstack-neutron | 12:59 | |
| *** salv-orlando has quit IRC | 13:06 | |
| *** salv-orlando has joined #openstack-neutron | 13:07 | |
| *** beagles has quit IRC | 13:11 | |
| openstackgerrit | Marios Andreou proposed a change to openstack/neutron: Validate CIDR given as ip-prefix in security-group-rule-create https://review.openstack.org/59212 | 13:15 |
| openstackgerrit | Sylvain Afchain proposed a change to openstack/neutron: Fix a typo in log exception in the metering agent https://review.openstack.org/59058 | 13:19 |
| HenryG | In the neutron project, are we requiring every review request to reference a bug/BP? How strict is this requirement? | 13:19 |
| openstackgerrit | A change was merged to openstack/neutron: Handle failures on update_dhcp_port https://review.openstack.org/59664 | 13:26 |
| *** beagles has joined #openstack-neutron | 13:26 | |
| *** csd has quit IRC | 13:34 | |
| *** csd has joined #openstack-neutron | 13:35 | |
| *** heyongli has quit IRC | 13:40 | |
| openstackgerrit | Evgeny Fedoruk proposed a change to openstack/neutron: Extending quota support for neutron LBaaS entities https://review.openstack.org/58720 | 13:46 |
| openstackgerrit | Oleg Bondarev proposed a change to openstack/neutron: LBaaS: unify haproxy-on-host plugin driver and agent https://review.openstack.org/40381 | 13:59 |
| *** armax has quit IRC | 14:01 | |
| *** armax has joined #openstack-neutron | 14:02 | |
| jog0 | anteaya: so we could use 'self.assertTrue(len(addresses) >= 1)' in console.html but that may be too general | 14:02 |
| jog0 | anteaya: to find a query for bug https://bugs.launchpad.net/neutron/+bug/1210483 we need a good line in the logs to use as a fingerprint | 14:03 |
| openstackgerrit | Jianing Yang proposed a change to openstack/neutron: Implement basic functionalities for port forwarding https://review.openstack.org/60512 | 14:04 |
| *** beagles is now known as beagles_brb | 14:06 | |
| *** armax has quit IRC | 14:09 | |
| *** jianingy is now known as jianingy_afk | 14:11 | |
| *** armax has joined #openstack-neutron | 14:19 | |
| *** banix has joined #openstack-neutron | 14:21 | |
| *** alagalah has joined #openstack-neutron | 14:27 | |
| *** alagalah has left #openstack-neutron | 14:28 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/neutron: Sync rpc fix from oslo-incubator https://review.openstack.org/60524 | 14:35 |
| *** peristeri has joined #openstack-neutron | 14:36 | |
| *** russellb is now known as rustlebee | 14:38 | |
| openstackgerrit | Oleg Bondarev proposed a change to openstack/neutron: LBaaS: unify haproxy-on-host plugin driver and agent https://review.openstack.org/40381 | 14:38 |
| *** alex_klimov has quit IRC | 14:41 | |
| obondarev | hi all, looking for opinions on Akihiro's comment on https://review.openstack.org/#/c/53364/ | 14:42 |
| *** otherwiseguy has quit IRC | 14:44 | |
| *** sbasam has joined #openstack-neutron | 14:51 | |
| *** mestery_ has joined #openstack-neutron | 14:53 | |
| *** chandankumar has quit IRC | 14:53 | |
| *** mestery has quit IRC | 14:57 | |
| *** mestery has joined #openstack-neutron | 14:57 | |
| *** mestery_ has quit IRC | 14:58 | |
| *** jecarey has joined #openstack-neutron | 15:01 | |
| *** netavenger-jr has quit IRC | 15:02 | |
| *** netavenger-jr has joined #openstack-neutron | 15:02 | |
| *** clev has joined #openstack-neutron | 15:03 | |
| *** mestery has quit IRC | 15:05 | |
| peristeri | #info peristeri continue working on https://bugs.launchpad.net/horizon/+bug/1241709 | 15:09 |
| marios_ | enikanorov_: thanks bud: https://review.openstack.org/#/c/59212/ | 15:11 |
| *** mestery has joined #openstack-neutron | 15:13 | |
| enikanorov_ | my +1 | 15:15 |
| *** jprovazn has quit IRC | 15:18 | |
| marios_ | enikanorov_: thanks | 15:18 |
| openstackgerrit | Sylvain Afchain proposed a change to openstack/neutron: Fix a typo in log exception in the metering agent https://review.openstack.org/59058 | 15:24 |
| *** otherwiseguy has joined #openstack-neutron | 15:33 | |
| *** Qlawy has quit IRC | 15:35 | |
| *** Qlawy has joined #openstack-neutron | 15:36 | |
| *** Qlawy has joined #openstack-neutron | 15:36 | |
| *** devlaps has joined #openstack-neutron | 15:37 | |
| *** SushilKM has joined #openstack-neutron | 15:38 | |
| *** amritanshu_RnD has quit IRC | 15:39 | |
| *** jlibosva has quit IRC | 15:41 | |
| *** Mr_W has quit IRC | 15:41 | |
| *** beagles_brb is now known as beagles | 15:49 | |
| *** SushilKM has quit IRC | 15:50 | |
| *** dims has quit IRC | 15:58 | |
| *** djbkd has joined #openstack-neutron | 16:03 | |
| *** dims has joined #openstack-neutron | 16:03 | |
| marios_ | happy friday neutron | 16:03 |
| * marios_ weekend | 16:03 | |
| *** carl_baldwin has joined #openstack-neutron | 16:16 | |
| *** Abhishek has joined #openstack-neutron | 16:26 | |
| *** suresh12 has joined #openstack-neutron | 16:28 | |
| *** suresh12 has quit IRC | 16:30 | |
| *** safchain has quit IRC | 16:39 | |
| *** markmcclain has joined #openstack-neutron | 16:42 | |
| *** Abhishek has quit IRC | 16:46 | |
| mestery | marios_: Yay, Friday! | 16:51 |
| *** scotty916 has joined #openstack-neutron | 16:53 | |
| *** scotty916 has quit IRC | 16:56 | |
| *** Sreedhar has quit IRC | 16:59 | |
| *** pete5 has quit IRC | 17:00 | |
| *** alagalah has joined #openstack-neutron | 17:00 | |
| *** nati_ueno has joined #openstack-neutron | 17:01 | |
| *** fouxm has quit IRC | 17:02 | |
| *** alagalah has quit IRC | 17:02 | |
| *** rossella_s has joined #openstack-neutron | 17:06 | |
| *** pasquier-s has quit IRC | 17:06 | |
| *** jpich has quit IRC | 17:11 | |
| *** nati_ueno has quit IRC | 17:13 | |
| openstackgerrit | Terry Wilson proposed a change to openstack/neutron: Add fwaas_driver.ini to setup.cfg https://review.openstack.org/60562 | 17:14 |
| EmilienM | marun: ping | 17:14 |
| marun | EmilienM: pong | 17:17 |
| *** ygbo has quit IRC | 17:18 | |
| *** suresh12 has joined #openstack-neutron | 17:26 | |
| marun | EmilienM: sorry, I have to sleep. | 17:29 |
| *** SushilKM has joined #openstack-neutron | 17:30 | |
| *** marun has quit IRC | 17:30 | |
| *** Qlawy has quit IRC | 17:37 | |
| *** alagalah has joined #openstack-neutron | 17:40 | |
| *** markmcclain has quit IRC | 17:42 | |
| *** markmcclain has joined #openstack-neutron | 17:43 | |
| *** Qlawy has joined #openstack-neutron | 17:45 | |
| *** markmcclain has quit IRC | 17:46 | |
| *** nati_ueno has joined #openstack-neutron | 17:51 | |
| *** armax has quit IRC | 18:01 | |
| *** armax has joined #openstack-neutron | 18:02 | |
| *** SushilKM has quit IRC | 18:05 | |
| *** suresh12 has quit IRC | 18:08 | |
| openstackgerrit | Nachi Ueno proposed a change to openstack/neutron: API Extension for SSL-VPN services https://review.openstack.org/58897 | 18:11 |
| *** armax has quit IRC | 18:14 | |
| *** sbasam has quit IRC | 18:17 | |
| *** rossella_s has quit IRC | 18:17 | |
| *** alagalah has left #openstack-neutron | 18:19 | |
| *** armax has joined #openstack-neutron | 18:20 | |
| *** afazekas_ has quit IRC | 18:32 | |
| *** suresh12 has joined #openstack-neutron | 18:38 | |
| *** jistr has quit IRC | 18:45 | |
| *** alagalah has joined #openstack-neutron | 18:50 | |
| *** Qlawy has quit IRC | 18:53 | |
| *** Qlawy has joined #openstack-neutron | 18:53 | |
| openstackgerrit | Nachi Ueno proposed a change to openstack/neutron: API Extension for SSL-VPN services https://review.openstack.org/58897 | 18:58 |
| openstackgerrit | A change was merged to openstack/neutron: Fix a typo in log exception in the metering agent https://review.openstack.org/59058 | 19:13 |
| openstackgerrit | A change was merged to openstack/neutron: Sync rpc fix from oslo-incubator https://review.openstack.org/60524 | 19:13 |
| openstackgerrit | A change was merged to openstack/neutron: Do not concatenate localized strings https://review.openstack.org/52895 | 19:13 |
| openstackgerrit | A change was merged to openstack/neutron: Fix unable to add allow all IPv4/6 security group rule https://review.openstack.org/57670 | 19:14 |
| *** pete5 has joined #openstack-neutron | 19:23 | |
| openstackgerrit | Aaron Rosen proposed a change to openstack/neutron: Remove dead code _arp_spoofing_rule() https://review.openstack.org/60601 | 19:27 |
| *** armax has left #openstack-neutron | 19:27 | |
| openstackgerrit | A change was merged to openstack/neutron: Improve unit test coverage for Cisco plugin common code https://review.openstack.org/60370 | 19:28 |
| *** jecarey has quit IRC | 19:41 | |
| *** suresh12 has quit IRC | 19:42 | |
| *** suresh12 has joined #openstack-neutron | 19:54 | |
| *** otherwiseguy has quit IRC | 19:58 | |
| *** yamahata_ has quit IRC | 19:59 | |
| *** pasquier-s has joined #openstack-neutron | 20:07 | |
| *** Sreedhar has joined #openstack-neutron | 20:07 | |
| *** mwagner_lap has joined #openstack-neutron | 20:11 | |
| *** suresh12 has quit IRC | 20:14 | |
| asadoughi | arosen: around? had a question about security groups and source_port_range_min/source_port_range_max | 20:14 |
| arosen | asadoughi: yep | 20:14 |
| arosen | shoot | 20:14 |
| asadoughi | so, it's in the rpc api (not sure if that's the right term), but not in the server facing api | 20:15 |
| arosen | asadoughi: was there a question in there? | 20:16 |
| asadoughi | arosen: any reason why it's like that? | 20:16 |
| arosen | asadoughi: I didn't do the security group rpc interface. I also thought this was odd. As far as security groups go the direction ingress/egress could have been used instead of introduction source/destination_port_range_min/max. | 20:18 |
| arosen | Though source/destination_port_range/min/max is used in the fwaas stuff though because the api allows you to enforce both source and dest TCP ports. | 20:19 |
| asadoughi | right | 20:19 |
| arosen | so in that case it makes sense. | 20:19 |
| *** pasquier-s has quit IRC | 20:20 | |
| asadoughi | iptables is stateful, open vswitch is stateless which is i started the question, because the server api as it stands is not rich enough to express all rules | 20:20 |
| asadoughi | which is why i* | 20:20 |
| asadoughi | however, if i added --source-port-min --source-port-max to the api or additional directions: ingress-src, egress-src it would be complete for openvswitch | 20:21 |
| asadoughi | arosen: did you follow that? i wanted to just ping you before i wrote a longer explanation for the blueprint to test feasibility of expanding the security groups api | 20:22 |
| *** harlowja has quit IRC | 20:23 | |
| *** harlowja has joined #openstack-neutron | 20:23 | |
| arosen | asadoughi: not quite sorry :/ | 20:25 |
| arosen | asadoughi: I don't think our API states the behavior if something is stateful or stateless though. | 20:26 |
| asadoughi | arosen: ok. i'll just do the write up and ping you when it seems coherent | 20:26 |
| arosen | that said EC2/security_groups currently do operate as stateful | 20:26 |
| arosen | asadoughi: it's hard to implement statefullness in ovs flows though. | 20:27 |
| arosen | When a flow comes in you'll need to then install a flow in the other direction patching the reverse of the fields to make it statefull | 20:28 |
| asadoughi | arosen: right so my implementation of ovs-firewall-driver will be stateless until ovs has connection tracking | 20:28 |
| arosen | asadoughi: sounds good keep me posted. Definitely interested in your findings. | 20:28 |
| *** x86brandon has joined #openstack-neutron | 20:28 | |
| arosen | Makes sense. | 20:29 |
| asadoughi | arosen: from my notes https://etherpad.openstack.org/p/ovs-firewall-driver-stateless | 20:30 |
| arosen | asadoughi: when you say ingress(src) or egress(src) what do you mean? | 20:32 |
| arosen | src != remove_ip right | 20:32 |
| arosen | remote* | 20:33 |
| arosen | asadoughi: what is the difference between line 1 and line 5? | 20:33 |
| asadoughi | arosen: in this context, direction is ip based and src/dst is how the security group rule would be applied to tp_src or tp_dst | 20:33 |
| openstackgerrit | Sean M. Collins proposed a change to openstack/neutron: Create a new attribute for subnets, to store v6 dhcp options https://review.openstack.org/52983 | 20:34 |
| arosen | Hrm, I think if i understand the different between line 1 and line 5 in your etherpad i'll understand. | 20:34 |
| asadoughi | arosen: each of A. B. C. D. are different flows | 20:34 |
| arosen | OHH | 20:35 |
| arosen | i miss read something | 20:35 |
| arosen | i didn't see you changed nw_sec*** | 20:35 |
| arosen | nw_src | 20:35 |
| arosen | okay let me look at this again sorry. | 20:35 |
| *** networkstatic has joined #openstack-neutron | 20:39 | |
| asadoughi | arosen: making more sense now? | 20:39 |
| arosen | asadoughi: yup i need to think about it for a sec. | 20:39 |
| *** mlavalle has joined #openstack-neutron | 20:43 | |
| arosen | what do you mean by acknowledge B&C ? | 20:44 |
| openstackgerrit | Nachi Ueno proposed a change to openstack/neutron: API Extension for SSL-VPN services https://review.openstack.org/58897 | 20:44 |
| arosen | When you say not possible do you mean there is no neutron api to: # Allows instance_ip to serve ssh to client remote_ip (other half of D) | 20:44 |
| asadoughi | other words i could have chosen for acknoweldge: grok, accept, learn | 20:45 |
| arosen | With is the other half of D not possible? | 20:45 |
| arosen | why is* | 20:45 |
| arosen | which part? It's not possible to write flows to support this? | 20:46 |
| asadoughi | security groups api is not rich enough to express this, it only expresses destination ports | 20:46 |
| asadoughi | no, i've written all 4 possible flows with 2 ips and 2 ports. | 20:47 |
| arosen | asadoughi: I think i see what you are saying. | 20:49 |
| arosen | asadoughi: so it looks like security groups are explicitly stateful. | 20:49 |
| arosen | i.e: | 20:49 |
| arosen | if you do: | 20:49 |
| arosen | # Allow remote_ip to ssh to vm | 20:49 |
| arosen | neutron security-group-rule-create --protocol tcp --port-range-min 22 --port-range-max 22 --direction ingress --remote-ip-prefix $remote_ip/32 default | 20:49 |
| arosen | that means that the instance will be able to respond to that. | 20:50 |
| arosen | you don't need to explicitly have a security group rule to allow the instance to respond. | 20:50 |
| arosen | That's what you are talking about right? | 20:50 |
| openstackgerrit | Nachi Ueno proposed a change to openstack/neutron: API Extension for SSL-VPN services https://review.openstack.org/58897 | 20:53 |
| arosen | When the api call on line 10 is done you would have to install flows in the reverse that you have on line 15 | 20:53 |
| asadoughi | arosen: sure, in explicit situations it's possible to have two flows per rule. | 20:54 |
| openstackgerrit | Nachi Ueno proposed a change to openstack/neutron: Improve vif attributes related with firewalling https://review.openstack.org/21946 | 20:55 |
| *** rossella_s has joined #openstack-neutron | 20:55 | |
| asadoughi | however, for example with default security groups and a vm wanting to ssh out into remote, it's not possible to have flows implied (state) in that situation, so a need for one rule: one flow | 20:55 |
| dkehn | arosen: would you have a minute for an issue I'm having with unit test? | 20:56 |
| arosen | asadoughi: ah okay so by default an instance can send out to anything. THough the tricky part is the reverse flow in the other direction to allow it to receive back ? | 20:58 |
| asadoughi | arosen: because otherwise the pairing of allow all egress flow would be allow all ingress flow in a stateless context ;) | 20:58 |
| arosen | dkehn: shoot | 20:58 |
| dkehn | arosen: let me put some of this in a paste | 20:58 |
| asadoughi | arosen: right so that reverse flow would need to be explicit and i would like to change the security groups frontend api/db to handle it | 20:59 |
| asadoughi | arosen: using one of the two suggestions i've made. i have it in code already if that would make things clearer for you. | 20:59 |
| arosen | asadoughi: i'm confused how line 26/27 would solve this? | 21:01 |
| dkehn | arosen: http://paste.openstack.org/show/54623/, basically I'm wondering how to get around the MisMatchError | 21:01 |
| *** rossella_s has quit IRC | 21:02 | |
| dkehn | arosen: one would assume that I would put the assertRaises on the self.new_update_request, which gave a MismatchError, but the actual tb occurrs on the get_response | 21:03 |
| dkehn | I'm figuring its something simple that I'm overlooking | 21:03 |
| arosen | dkehn: give me a few min i'm thinking about what asadoughi has brought up. | 21:03 |
| *** dkranz has joined #openstack-neutron | 21:03 | |
| dkehn | arosen: np | 21:04 |
| asadoughi | well, it would be 26 or 27. not both. my prototype is here https://github.com/asadoughi/neutron/compare/master...ovs_firewall_driver and the last 3 changes are relevant to how it works | 21:04 |
| arosen | asadoughi: so what would you want the api call to look like to implement: # Allow remote_ip to ssh to vm | 21:05 |
| asadoughi | in the patch, i've gone with adding new directions , but the source-port-range-min,-max seems cleaner | 21:05 |
| dkranz | Would it be possible for a neutron dev to review "Adds test external/internal network connectivity" https://review.openstack.org/#/c/55146/ | 21:06 |
| asadoughi | arosen: updated etherpad with command line examples | 21:07 |
| arosen | asadoughi: so it looks like direction can now be : ['ingress', 'egress', 'ingress-src', 'egress-src']}}, | 21:08 |
| arosen | What's the difference between ingress and ingress-src? | 21:08 |
| asadoughi | the code that hijacks the port to change the rpc message: https://github.com/asadoughi/neutron/compare/master...ovs_firewall_driver#diff-78a89e0759aeb12cb44fc995d4ea7331R311 | 21:09 |
| asadoughi | again, the other way would be cleaner | 21:09 |
| arosen | asadoughi: wait so are you saying you want to remove this explicit handing in security groups that when you do : --port-range-min 22 --port-range-max 22 --direction 22; that you also need to specify the flow in the other way? | 21:09 |
| asadoughi | but hacky things pop into my mind first sometimes for some reason :) | 21:09 |
| asadoughi | arosen: could you rephrase that | 21:09 |
| asadoughi | oh handling got it | 21:10 |
| *** rossella_s has joined #openstack-neutron | 21:15 | |
| *** otherwiseguy has joined #openstack-neutron | 21:17 | |
| *** suresh12 has joined #openstack-neutron | 21:24 | |
| dkehn | arosen: any time to look at it? | 21:26 |
| arosen | dkehn: one sec looking now. | 21:27 |
| dkehn | arosen: thx tons | 21:27 |
| arosen | dkehn: are you asking why this is occuring? | 21:29 |
| arosen | File "neutron/extensions/extra_dhcp_opt.py", line 42, in _validate_list_of_dict_or_none | 21:29 |
| arosen | raise ExtraDhcpOptBadData(data='blank string(s) not allowed') | 21:29 |
| *** suresh12 has quit IRC | 21:29 | |
| arosen | seems because of the ' ' here: | 21:29 |
| arosen | upd_opts = [{'opt_name': 'bootfile-name', 'opt_value': ' '}] | 21:29 |
| arosen | opt_value | 21:29 |
| dkehn | arosen: no I'm basically wonder the right way to put a assertRaises in such that when the ExtraDhcpOptBadData occurrs I catch it, it seems that I'm getting a MismatchError instead | 21:30 |
| *** carl_baldwin has quit IRC | 21:31 | |
| arosen | dkehn: can you pastebin neutron/extensions/extra_dhcp_opt.py | 21:32 |
| *** rossella_s has quit IRC | 21:33 | |
| dkehn | arosen: http://paste.openstack.org/show/54626/ its at the end, I'm trying to pass in a ' ' string that should raise the validator exception | 21:34 |
| arosen | dkehn: okay okay so the self.assertRaises is what is raising this mismatch error | 21:36 |
| *** pasquier-s has joined #openstack-neutron | 21:36 | |
| arosen | what does print eq give you | 21:36 |
| arosen | print req * when the the return from new_update_request('ports' | 21:37 |
| arosen | Oh | 21:37 |
| arosen | the API isn't going to raise ExtraDhcpOptBadData there it is going to raise BadRequest | 21:37 |
| dkehn | arosen: > /home/dkehn/devl/neutron-empty-string/neutron/tests/unit/test_extension_extradhcpopts.py(275)test_update_port_with_blank_string_extradhcpopt() | 21:37 |
| dkehn | -> self.assertRaises(edo_ext.ExtraDhcpOptBadData, | 21:37 |
| dkehn | (Pdb) p req | 21:37 |
| dkehn | <Request at 0x39509d0 PUT http://localhost/ports/a4515651-8e42-4491-a09a-e09ac51203c4.json> | 21:37 |
| dkehn | arosen: http://paste.openstack.org/show/54628/ | 21:38 |
| dkehn | arosen: at the very bottom | 21:38 |
| *** suresh12 has joined #openstack-neutron | 21:39 | |
| arosen | usually we do something like this: | 21:39 |
| arosen | req = self.new_update_request('ports', update_port, | 21:39 |
| arosen | port['port']['id']) | 21:39 |
| arosen | res = req.get_response(self.api) | 21:39 |
| arosen | self.assertEqual(res.status_int, webob.exc.HTTPOk.code) | 21:39 |
| dkehn | arosen: let me try that | 21:40 |
| arosen | You won't get an edo_ext.ExtraDhcpOptBadData exception from the api. One sec i can show you where the exceptions are converted. | 21:40 |
| *** pasquier-s has quit IRC | 21:42 | |
| arosen | dkehn: yea if you look in neutron/api/v2/base.py FAULT_MAP the api will only raise those exceptions. | 21:43 |
| dkehn | arosen: The issue is that the res = req.get_response...... produces a tb | 21:43 |
| arosen | what's the tb? | 21:44 |
| dkehn | tb = traceback | 21:44 |
| arosen | i got that :) what does it say :) | 21:44 |
| *** aymenfrikha has joined #openstack-neutron | 21:44 | |
| dkehn | arosen: ExtraDhcpOptBadData: Invalid data format for extra-dhcp-opt: blank string(s) not allowed | 21:46 |
| dkehn | which is what I'm looking for | 21:46 |
| arosen | dkehn: It must print an http response though not just that? | 21:47 |
| dkehn | one sec | 21:47 |
| arosen | i think that's just in the body of the request that it is returning. | 21:48 |
| dkehn | arosen: http://paste.openstack.org/show/54630/ | 21:48 |
| dkehn | arosen: pdb session | 21:48 |
| *** aymenfrikha has quit IRC | 21:49 | |
| arosen | dkehn: it looks like this is raising an error right: res = req.get_response(self.api) you can't even print res ? | 21:51 |
| dkehn | arosen: <Response at 0x3f2de50 400 Bad Request> | 21:52 |
| openstackgerrit | Sean M. Collins proposed a change to openstack/neutron: Create a new attribute for subnets, to store v6 dhcp options https://review.openstack.org/52983 | 21:52 |
| dkehn | arosen: (Pdb) p res.__dict__ | 21:53 |
| dkehn | {'_app_iter': ['{"NeutronError": {"message": "Invalid data format for extra-dhcp-opt: blank string(s) not allowed", "type": "ExtraDhcpOptBadData", "detail": ""}}'], '_status': '400 Bad Request', '_headerlist': [('Content-Type', 'application/json; charset=UTF-8'), ('Content-Length', '145')], 'conditional_response': False, '_headers': None} | 21:53 |
| arosen | type(res) | 21:53 |
| arosen | print type(res) | 21:54 |
| openstackgerrit | Nachi Ueno proposed a change to openstack/neutron: API Extension for SSL-VPN services https://review.openstack.org/58897 | 21:55 |
| arosen | I'm wondering if it's been deserialized yet it doesn't look like it. | 21:55 |
| dkehn | no, | 21:56 |
| dkehn | there hassn't | 21:56 |
| arosen | it's a string right? | 21:56 |
| dkehn | right | 21:56 |
| arosen | Cool, can you paste the updated testcase ? | 21:56 |
| arosen | Just want to take a look what it is now. | 21:56 |
| dkehn | http://paste.openstack.org/show/54628/ | 21:57 |
| dkehn | arosen: sorry that old | 21:57 |
| dkehn | arosen: http://paste.openstack.org/show/54631/ | 21:58 |
| arosen | dkehn: hrm what you have looks like it should work though i see in different places we call deserialize and not in others. | 22:02 |
| *** aymenfrikha has joined #openstack-neutron | 22:02 | |
| arosen | If you add this it should work though I think: | 22:02 |
| arosen | res = self.deserialize('json', req.get_response(self.api)) | 22:03 |
| arosen | I'd give that a shot. The assertEqual will fail though as it's returning a webob.exc.HTTPBadRequest.code; | 22:04 |
| dkehn | port = self.deserialize('json', req.get_response(self.api)) | 22:04 |
| dkehn | # res = req.get_response(self.api) | 22:04 |
| arosen | also 'json' should be replaced with self.fmt but that can call happen later. | 22:04 |
| dkehn | self.assertEqual(port.status.int, webob.exc.HTTPOk.code) | 22:04 |
| arosen | yup | 22:04 |
| dkehn | this is what I've started with | 22:04 |
| dkehn | I've kind of been regressing | 22:04 |
| arosen | what was port then? | 22:04 |
| dkehn | (Pdb) | 22:05 |
| dkehn | > /home/dkehn/devl/neutron-empty-string/neutron/tests/unit/test_extension_extradhcpopts.py(275)test_update_port_with_blank_string_extradhcpopt() | 22:05 |
| dkehn | -> port = self.deserialize('json', req.get_response(self.api)) | 22:05 |
| dkehn | (Pdb) | 22:05 |
| dkehn | 2013-12-06 14:59:52,077 ERROR [neutron.api.v2.resource] update failed | 22:05 |
| dkehn | Traceback (most recent call last): File "neutron/api/v2/resource.py", line 84, in resource | 22:05 |
| dkehn | result = method(request=request, **args) | 22:05 |
| dkehn | File "neutron/api/v2/base.py", line 466, in update | 22:05 |
| dkehn | allow_bulk=self._allow_bulk) | 22:05 |
| dkehn | File "neutron/api/v2/base.py", line 595, in prepare_request_body | 22:05 |
| dkehn | attr_vals['validate'][rule]) | 22:05 |
| dkehn | File "neutron/extensions/extra_dhcp_opt.py", line 42, in _validate_list_of_dict_or_none | 22:05 |
| dkehn | raise ExtraDhcpOptBadData(data='blank string(s) not allowed') | 22:05 |
| dkehn | ExtraDhcpOptBadData: Invalid data format for extra-dhcp-opt: blank string(s) not allowed | 22:05 |
| arosen | lets probably switch to private message so we don't spam everyone in here | 22:05 |
| dkehn | > /home/dkehn/devl/neutron-empty-string/neutron/tests/unit/test_extension_extradhcpopts.py(277)test_update_port_with_blank_string_extradhcpopt() | 22:05 |
| dkehn | -> self.assertEqual(port.status.int, webob.exc.HTTPOk.code) | 22:05 |
| dkehn | (Pdb) | 22:05 |
| dkehn | AttributeError: "'dict' object has no attribute 'status'" | 22:05 |
| dkehn | > /home/dkehn/devl/neutron-empty-string/neutron/tests/unit/test_extension_extradhcpopts.py(277)test_update_port_with_blank_string_extradhcpopt() | 22:05 |
| dkehn | -> self.assertEqual(port.status.int, webob.exc.HTTPOk.code) | 22:06 |
| dkehn | (Pdb) p port | 22:06 |
| dkehn | {u'NeutronError': {u'message': u'Invalid data format for extra-dhcp-opt: blank string(s) not allowed', u'type': u'ExtraDhcpOptBadData', u'detail': u''}} | 22:06 |
| dkehn | (Pdb) | 22:06 |
| dkehn | arosen: k | 22:06 |
| *** networkstatic has quit IRC | 22:07 | |
| *** Sreedhar has quit IRC | 22:07 | |
| *** pcm_ has quit IRC | 22:12 | |
| *** networkstatic has joined #openstack-neutron | 22:20 | |
| *** harlowja has quit IRC | 22:21 | |
| *** networkstatic has quit IRC | 22:22 | |
| *** dims has quit IRC | 22:25 | |
| *** jecarey has joined #openstack-neutron | 22:31 | |
| *** alagalah has left #openstack-neutron | 22:31 | |
| *** dims has joined #openstack-neutron | 22:40 | |
| *** peristeri has quit IRC | 22:52 | |
| *** pasquier-s has joined #openstack-neutron | 22:53 | |
| *** clev has quit IRC | 23:02 | |
| *** aymenfrikha has quit IRC | 23:10 | |
| *** aymenfrikha has joined #openstack-neutron | 23:11 | |
| *** pasquier-s has quit IRC | 23:11 | |
| *** pasquier-s has joined #openstack-neutron | 23:35 | |
| *** x86brandon has quit IRC | 23:44 | |
| *** banix has quit IRC | 23:44 | |
| *** otherwiseguy has quit IRC | 23:51 | |
| *** arosen has left #openstack-neutron | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!