| *** carl_baldwin has joined #openstack-neutron-release | 01:59 | |
| *** carl_baldwin has quit IRC | 03:28 | |
| *** amuller has joined #openstack-neutron-release | 13:35 | |
| *** carl_baldwin has joined #openstack-neutron-release | 14:57 | |
| *** amuller is now known as amuller_afk | 17:41 | |
| *** amuller_afk is now known as amuller | 18:04 | |
| amuller | mestery: I wanted to discuss cores merging patches without another +2, taking this patch as an example: https://review.openstack.org/#/c/191156/ | 18:19 |
|---|---|---|
| amuller | Other examples would be fixing spelling mistakes in green text | 18:20 |
| amuller | I argue that we should do more of that | 18:20 |
| amuller | dougwig: HenryG: kevinbenton: carl_baldwin: thoughts? | 18:22 |
| carl_baldwin | Ah, the “ninja merge”. | 18:24 |
| kevinbenton | i can see maybe spelling mistakes, but i don't think we should go down that path for ones that touch real code should | 18:24 |
| carl_baldwin | I’ve personally been careful with ninja merging. | 18:24 |
| carl_baldwin | I agree about touching real code in general. Even simple looking changes can sometimes benefit from a second eye. | 18:25 |
| kevinbenton | i don't see why this needs to merge so quickly | 18:26 |
| amuller | Need is a strong word :) | 18:27 |
| HenryG | I do like to see trivial patches merge quickly and not waste too many people's time | 18:30 |
| kevinbenton | that only took me like 30 seconds to review, not worth changing process | 18:31 |
| HenryG | However, I feel better with the 2-person safety check most of the time | 18:31 |
| carl_baldwin | I’ll admit to a handful of ninja merges when a patch already had another +2 and I wanted a trivial change to commit message or comment or something. I generally note in the gerrit comment why I merged without a second +2. | 18:31 |
| carl_baldwin | But, I do agree in general with the 2-person safety check too. | 18:32 |
| HenryG | With more core reviewers coming on board I think we can get 2 eyes on trivial changes more quickly more often now | 18:33 |
| carl_baldwin | HenryG: ++ | 18:33 |
| HenryG | And like kevinbenton said, 30 seconds x 2 is not a big deal | 18:34 |
| amuller | That is true Henry | 18:34 |
| * amuller is reading Nova vif drivers code. Bleargh. | 18:35 | |
| dougwig | Bots, trivial, or rebases, I only do one. But trivial for me means typos or white space. I'm open to other. | 19:15 |
| dougwig | Or less | 19:15 |
| mestery | I'm not in favor of having a single +2 for even simple merges | 19:29 |
| mestery | My reasoning is it's never hard to find someone else to do the second +2 :) | 19:29 |
| mestery | At least, I've not had a problem. | 19:29 |
| mestery | But that may just be me | 19:29 |
| HenryG | The only thing worse than having your +2 on a patch that breaks the gate is having the only +2 on the patch that breaks the gate. ;) | 19:46 |
| * carl_baldwin was thinking the same thing. | 19:54 | |
| mestery | +1000 | 20:40 |
| amuller | kevinbenton: I'm starting to think that 'RFE' is like a red hat thing or something | 22:49 |
| amuller | everyone I work with use it a lot | 22:49 |
| amuller | no one else seems to know what it means | 22:49 |
| kevinbenton | i think so | 22:49 |
| kevinbenton | i had never heard it before you folks infected neutron with it :) | 22:49 |
| amuller | hah | 22:49 |
| amuller | mission accomplished | 22:49 |
| *** amuller has quit IRC | 22:59 | |
| *** carl_baldwin has quit IRC | 23:14 | |
| HenryG | What is the state for an RFE bug before the drivers team discusses it? | 23:41 |
| HenryG | Ah "confirmed" (found it in the "blueprints" policies :) | 23:42 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!