| *** salv-orlando has quit IRC | 00:22 | |
| *** jerrygb has joined #openstack-neutron-ovn | 00:45 | |
| *** jerrygb has quit IRC | 00:52 | |
| *** jerrygb has joined #openstack-neutron-ovn | 01:04 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 01:19 | |
| *** fzdarsky_ has joined #openstack-neutron-ovn | 01:21 | |
| *** fzdarsky has quit IRC | 01:24 | |
| *** salv-orlando has quit IRC | 01:48 | |
| *** s3wong has quit IRC | 01:54 | |
| openstackgerrit | Merged openstack/networking-ovn master: Disable new N537 hacking check from next neutron-lib https://review.openstack.org/457109 | 02:09 |
|---|---|---|
| *** gongysh has joined #openstack-neutron-ovn | 02:22 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 02:45 | |
| *** mickeys has quit IRC | 02:50 | |
| *** mickeys has joined #openstack-neutron-ovn | 03:02 | |
| *** salv-orl_ has joined #openstack-neutron-ovn | 03:03 | |
| *** salv-orlando has quit IRC | 03:03 | |
| *** salv-orl_ has quit IRC | 03:16 | |
| *** arslanq has quit IRC | 04:04 | |
| *** mickeys has quit IRC | 04:11 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 04:13 | |
| *** gongysh has quit IRC | 04:14 | |
| *** salv-orlando has quit IRC | 04:41 | |
| *** gongysh has joined #openstack-neutron-ovn | 04:42 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 04:46 | |
| *** anilvenkata has joined #openstack-neutron-ovn | 05:06 | |
| *** gongysh has quit IRC | 05:09 | |
| *** mickeys has joined #openstack-neutron-ovn | 05:12 | |
| *** mickeys has quit IRC | 05:16 | |
| *** mickeys has joined #openstack-neutron-ovn | 05:36 | |
| *** janki has joined #openstack-neutron-ovn | 05:48 | |
| *** gongysh has joined #openstack-neutron-ovn | 05:59 | |
| *** salv-orlando has quit IRC | 06:11 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 06:11 | |
| *** salv-orlando has quit IRC | 06:16 | |
| *** pcaruana has joined #openstack-neutron-ovn | 06:18 | |
| *** ltomasbo|away is now known as ltomasbo | 06:42 | |
| *** janki has quit IRC | 06:49 | |
| *** janki has joined #openstack-neutron-ovn | 06:50 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 07:01 | |
| *** gongysh has quit IRC | 07:18 | |
| *** janki has quit IRC | 07:53 | |
| *** lucas-afk is now known as lucasagomes | 08:07 | |
| *** gongysh has joined #openstack-neutron-ovn | 08:09 | |
| *** jerrygb_ has joined #openstack-neutron-ovn | 08:11 | |
| *** janki has joined #openstack-neutron-ovn | 08:11 | |
| *** jerrygb has quit IRC | 08:11 | |
| *** jerrygb_ has quit IRC | 08:21 | |
| *** jerrygb has joined #openstack-neutron-ovn | 08:22 | |
| *** mickeys has quit IRC | 08:38 | |
| *** gongysh has quit IRC | 08:51 | |
| *** fzdarsky_ is now known as fzdarsky|afk | 08:55 | |
| *** dongjun has quit IRC | 09:33 | |
| *** mickeys has joined #openstack-neutron-ovn | 09:38 | |
| *** arslanq has joined #openstack-neutron-ovn | 09:43 | |
| *** mickeys has quit IRC | 09:45 | |
| *** salv-orl_ has joined #openstack-neutron-ovn | 09:48 | |
| *** salv-orlando has quit IRC | 09:51 | |
| *** yamamoto has quit IRC | 10:25 | |
| *** mickeys has joined #openstack-neutron-ovn | 10:41 | |
| *** mickeys has quit IRC | 10:46 | |
| *** anilvenkata has quit IRC | 11:09 | |
| *** lucasagomes is now known as lucas-afk | 11:25 | |
| *** yamamoto has joined #openstack-neutron-ovn | 11:33 | |
| *** yamamoto has quit IRC | 11:35 | |
| *** yamamoto has joined #openstack-neutron-ovn | 11:39 | |
| *** salv-orl_ has quit IRC | 11:40 | |
| *** mickeys has joined #openstack-neutron-ovn | 11:42 | |
| *** mickeys has quit IRC | 11:47 | |
| *** fzdarsky|afk is now known as fzdarsky | 11:48 | |
| *** yamamoto has quit IRC | 11:52 | |
| *** dongjun has joined #openstack-neutron-ovn | 12:15 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 12:17 | |
| dongjun | numans: Hi, switching to ovsdbapp in neutron breaks our gate | 12:17 |
| numans | dongjun, oh | 12:18 |
| numans | dongjun, i haven't looked at ovsdbapp closely, is the ovn code merged there ? | 12:19 |
| numans | dongjun, eventually all the code in commands.py (and may be impl_idl_ovn.py) should be moved to ovsdbapp | 12:20 |
| numans | and ovn would consume it | 12:21 |
| dongjun | numans: No, no ovn code was merged to ovsdbapp | 12:21 |
| numans | also other projects which wants to use ovn can directly use them | 12:21 |
| numans | dongjun, i think that would be next step | 12:21 |
| numans | i may be wrong, probably need to check with otherwiseguy and russellb | 12:21 |
| numans | dongjun, now i got you :) you mean neutron switching to ovsdbapp and the native folder in neutron getting deleted ? | 12:22 |
| dongjun | numans: Not deleted, use this instead | 12:23 |
| dongjun | from ovsdbapp.backend.ovs_idl import idlutils | 12:23 |
| dongjun | there is a attributeErr | 12:24 |
| dongjun | looks like some attribute was removed | 12:24 |
| numans | dongjun, you are seeing this error when networking-ovn imports idlutils from ovsdbapp ? | 12:24 |
| dongjun | Neutron clear the code in idlutils, using from ovsdbapp.backend.ovs_idl import idlutils instead. | 12:25 |
| *** dalvarez has quit IRC | 12:25 | |
| *** ajo has quit IRC | 12:25 | |
| dongjun | It's redirected to ovsdbapp | 12:25 |
| *** ltomasbo has quit IRC | 12:25 | |
| *** dmellado has quit IRC | 12:26 | |
| *** lucas-afk is now known as lucasagomes | 12:26 | |
| dongjun | numans: http://logs.openstack.org/18/457518/4/gate/gate-networking-ovn-python27-ubuntu-xenial/a95c87e/console.html#_2017-04-21_11_54_26_283387 | 12:27 |
| lucasagomes | dongjun, ++ it just failed on my local devstack setup | 12:28 |
| lucasagomes | 2017-04-21 12:36:44.810 CRITICAL neutron.plugins.ml2.managers [-] The 'ovn = networking_ovn.ml2.mech_driver:OVNMechanismDriver' entrypoint could not be loaded for the following reason: 'no such option ovs_vsctl_timeout in group [DEFAULT]'. | 12:28 |
| lucasagomes | this is what I get from the q-svc logs | 12:28 |
| *** dalvarez has joined #openstack-neutron-ovn | 12:28 | |
| dongjun | Oops | 12:29 |
| numans | lucasagomes, dongjun both of them related ? | 12:29 |
| lucasagomes | numans, not sure yet, but apparently so | 12:30 |
| lucasagomes | I will investigate, I literraly just bumped into that problem | 12:30 |
| dongjun | lucasagomes: I have no idea. | 12:30 |
| lucasagomes | so I haven't dug at all | 12:30 |
| otherwiseguy | yeah, i didn't really expect the neutron ovsdbapp patch to merge as soon as I pulled it out of WIP. I'd tested functional tests with ovn before and they passed, but apparently a new iteration of the patch broke those. the unit tests are because mocking 'moved' objects doesn't work well. | 12:32 |
| otherwiseguy | should be easy to fix. i'm on it. | 12:33 |
| *** ajo has joined #openstack-neutron-ovn | 12:33 | |
| numans | otherwiseguy, that's cool | 12:34 |
| numans | thanks | 12:34 |
| otherwiseguy | sorry i broke the world! | 12:34 |
| *** jchhatbar has joined #openstack-neutron-ovn | 12:34 | |
| numans | that's fine :) its all part of what we do | 12:35 |
| *** janki has quit IRC | 12:38 | |
| dongjun | otherwiseguy: thanks | 12:39 |
| dongjun | Is the reason "_tables" renamed to "tables"? | 12:39 |
| otherwiseguy | I don't remember renaming _tables. | 12:41 |
| otherwiseguy | (though it should be) | 12:41 |
| lucasagomes | otherwiseguy, it's all good, apparently we are just mocking the wrong row_by_values | 12:41 |
| lucasagomes | we should mock the one from ovsdbapp in networking-ovn | 12:41 |
| * lucasagomes will put a patch, 1 sec | 12:42 | |
| otherwiseguy | I did rename _get_shcmea_helper to get_schema_helper though. | 12:42 |
| *** mickeys has joined #openstack-neutron-ovn | 12:43 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/networking-ovn master: WIP: Fix unittests breakage https://review.openstack.org/458818 | 12:44 |
| * lucasagomes testing locally ^ | 12:44 | |
| *** mickeys has quit IRC | 12:47 | |
| *** dmellado has joined #openstack-neutron-ovn | 12:48 | |
| *** ltomasbo has joined #openstack-neutron-ovn | 12:49 | |
| lucasagomes | yeah, there are other bits too | 12:51 |
| otherwiseguy | have some fixes coming. | 12:53 |
| otherwiseguy | just running tests | 12:53 |
| otherwiseguy | down to one failed unit test. | 12:53 |
| otherwiseguy | tests passing, checking pep8 (functional test I think I'll have to fix in neutron) | 12:56 |
| *** yamamoto has joined #openstack-neutron-ovn | 12:57 | |
| *** yamamoto has quit IRC | 12:58 | |
| lucasagomes | otherwiseguy, cool, did you replace the get_idl_schema from the neutron tree with the ovsdbapp one ? | 12:58 |
| *** yamamoto has joined #openstack-neutron-ovn | 12:58 | |
| openstackgerrit | Terry Wilson proposed openstack/networking-ovn master: Fix unit tests related to Neutron ovsdbapp use https://review.openstack.org/458821 | 13:00 |
| otherwiseguy | lucasagomes, that and fixed the _get_schema_helper() call. | 13:01 |
| lucasagomes | yeah | 13:01 |
| otherwiseguy | now to fix the functional tests. | 13:01 |
| *** yamamoto has quit IRC | 13:15 | |
| *** yamamoto has joined #openstack-neutron-ovn | 13:16 | |
| *** yamamoto has quit IRC | 13:16 | |
| *** yamamoto has joined #openstack-neutron-ovn | 13:16 | |
| *** yamamoto has quit IRC | 13:25 | |
| *** yamamoto has joined #openstack-neutron-ovn | 13:26 | |
| otherwiseguy | lucasagomes, hopefully https://review.openstack.org/458841 will fix the functional tests. | 13:28 |
| lucasagomes | otherwiseguy, yeah | 13:28 |
| lucasagomes | otherwiseguy, https://review.openstack.org/458835 | 13:28 |
| lucasagomes | I've put a fix for that too, diff approach tho | 13:28 |
| * lucasagomes tests | 13:29 | |
| otherwiseguy | I like yours better. | 13:29 |
| otherwiseguy | At least, while importing from neutron. I like mine a little better once nothing imports from neutron. :D | 13:30 |
| *** yamamoto has quit IRC | 13:30 | |
| lucasagomes | otherwiseguy, yeah | 13:30 |
| otherwiseguy | And it really is good form to register the option before using it I suppose. :) | 13:32 |
| lucasagomes | otherwiseguy, yeah, evaluating config at important time is kinda tricky... We had some problems with that when using configs in decorators | 13:33 |
| lucasagomes | like for periodic tasks | 13:33 |
| openstackgerrit | Terry Wilson proposed openstack/networking-ovn master: Fix unit tests related to Neutron ovsdbapp use https://review.openstack.org/458821 | 13:38 |
| otherwiseguy | lucasagomes, it makes me happy that ovsdbapp has no config. :p | 13:46 |
| lucasagomes | otherwiseguy, ++ | 13:47 |
| lucasagomes | otherwiseguy, btw, the Transaction class was removed from neutron ovsdbapp | 13:47 |
| lucasagomes | and networking-ovn uses it | 13:47 |
| lucasagomes | hmm... I think we will need to add ovsdbapp as a dependnecy for networking-ovn | 13:47 |
| otherwiseguy | transaction class is moved. | 13:47 |
| lucasagomes | otherwiseguy, can you think about another way of replacing that Transaction class ? | 13:48 |
| lucasagomes | otherwiseguy, oh right | 13:48 |
| otherwiseguy | lucasagomes, it will be a dependency very soon. As soon as the gate is definitely fixed, I'm back to the "make networking-ovn use ovsdbapp" branch I'm working on. :) | 13:48 |
| lucasagomes | otherwiseguy, cool | 13:49 |
| otherwiseguy | At least, I think I am. I guess I really should start the packaging process for ovsdbapp before someone stabs me for introducing a new dependency and not taking care of that. | 13:49 |
| *** jchhatbar has quit IRC | 13:50 | |
| otherwiseguy | I just thought I had more time. Oh well, less excuses more working. :p | 13:50 |
| lucasagomes | yeah, we need to avoid merging such patches on friday too :-P | 13:51 |
| lucasagomes | it's never a good idea to merge big refactors at the end of the week | 13:51 |
| otherwiseguy | there was apparently much optimism in the world last night. | 13:51 |
| lucasagomes | hah | 13:55 |
| *** mlavalle has joined #openstack-neutron-ovn | 14:03 | |
| *** yamamoto has joined #openstack-neutron-ovn | 14:27 | |
| *** salv-orlando has quit IRC | 14:28 | |
| *** mickeys has joined #openstack-neutron-ovn | 14:32 | |
| *** mickeys has quit IRC | 14:36 | |
| *** gongysh has joined #openstack-neutron-ovn | 14:41 | |
| *** yamamoto has quit IRC | 14:53 | |
| *** erhudy has left #openstack-neutron-ovn | 15:01 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/networking-ovn master: Uses Transaction from ovsdbapp https://review.openstack.org/458872 | 15:07 |
| lucasagomes | otherwiseguy, ^ maybe we need squash that with ur patch for the unittests btw | 15:07 |
| russellb | please ping me when patches need to be approved :) | 15:08 |
| otherwiseguy | russellb, https://review.openstack.org/#/c/458841/ has ihar's +2 do you still have neutron +2 powers? | 15:08 |
| russellb | no | 15:09 |
| otherwiseguy | sad | 15:09 |
| otherwiseguy | russellb, after ^ merges, I think https://review.openstack.org/#/c/458821/ will pass and everything will be happy. | 15:11 |
| russellb | otherwiseguy: OK, how about adding that as Depends-On? | 15:11 |
| lucasagomes | otherwiseguy, it won't, it needs the Transaction thing | 15:11 |
| lucasagomes | russellb, ++ | 15:11 |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/networking-ovn master: Uses Transaction from ovsdbapp https://review.openstack.org/458872 | 15:12 |
| russellb | lucasagomes: you could squash it into otherwiseguy's patch and add depends-on while you're at it? | 15:12 |
| lucasagomes | russellb, yeah, lemme do it | 15:12 |
| lucasagomes | I just didn't want to put a new patch-set on his own patch, otherwiseguy you ok with it ? | 15:13 |
| otherwiseguy | lucasagomes, oh, i see. I needed to add a moved_class for Transaction in neutron as well. | 15:14 |
| lucasagomes | otherwiseguy, yeah, or we can just use it from ovsdbapp | 15:15 |
| otherwiseguy | (in case someone else is using it) | 15:15 |
| lucasagomes | we are moving to it anyway | 15:15 |
| lucasagomes | otherwiseguy, oh yeah, in that case yes | 15:15 |
| otherwiseguy | like dragonflow | 15:15 |
| otherwiseguy | I don't think they do, though. | 15:15 |
| otherwiseguy | lucasagomes, Feel free to merge it into my patch or whatever. | 15:15 |
| otherwiseguy | All I care about is "shit gets fixed" :D | 15:16 |
| lucasagomes | otherwiseguy, will do, also, one thing about that patch in neutron... I don't I think I prefer to have the function around that configuration option | 15:16 |
| lucasagomes | instead of calling register_opts | 15:16 |
| otherwiseguy | I'm not sure which you meant "I don't I think I prefer" :D | 15:16 |
| lucasagomes | cause usually register_opts is called in one place only, spreading it around in multiple calls makes the code more spaghetti | 15:16 |
| lucasagomes | hah I mean, I don't like that approach | 15:17 |
| *** dongjun has quit IRC | 15:17 | |
| otherwiseguy | lucasagomes, I think the whole point of making an importable place to call register_ovs_options() or whatever is so that you *can* do it from multiple places. | 15:18 |
| otherwiseguy | otherwise you'd just define the opt and register it in the same place, right? | 15:18 |
| otherwiseguy | ovs_conf.register_ovs_agent_opts() is already called in multiople places in the neutron tree for instance. | 15:21 |
| lucasagomes | otherwiseguy, maybe we have different approaches, I don't know neutron enough... but in ironic we just register it prior in a common service module | 15:21 |
| lucasagomes | which is used for all services (api, conductor) etc | 15:21 |
| lucasagomes | so we make sure the order is applied | 15:21 |
| lucasagomes | if you call register_opts on different places where more modules have been important it can be problematic | 15:22 |
| lucasagomes | because some configs needs to be evaluated at import time, like for decorators | 15:22 |
| lucasagomes | so registering it after the fact doesn't work | 15:22 |
| lucasagomes | it seems broken in neutron anyway | 15:22 |
| *** gongysh has quit IRC | 15:33 | |
| openstackgerrit | Lucas Alvares Gomes proposed openstack/networking-ovn master: Fix unit/functional tests related to Neutron ovsdbapp use https://review.openstack.org/458821 | 15:37 |
| lucasagomes | otherwiseguy, ^ squashed the transaction thing and added the depends-on in the neutron patch | 15:37 |
| *** mickeys has joined #openstack-neutron-ovn | 15:40 | |
| *** yamamoto has joined #openstack-neutron-ovn | 15:51 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 16:00 | |
| *** salv-orlando has quit IRC | 16:04 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 16:05 | |
| *** mlavalle has quit IRC | 16:11 | |
| *** lucasagomes is now known as lucas-afk | 16:36 | |
| *** ltomasbo is now known as ltomasbo|away | 16:40 | |
| *** mlavalle has joined #openstack-neutron-ovn | 16:47 | |
| *** dmellado has quit IRC | 16:52 | |
| *** ltomasbo|away has quit IRC | 16:52 | |
| *** dalvarez has quit IRC | 16:53 | |
| *** ajo has quit IRC | 16:54 | |
| *** yamamoto has quit IRC | 16:55 | |
| *** dalvarez has joined #openstack-neutron-ovn | 17:00 | |
| *** salv-orlando has quit IRC | 17:00 | |
| *** ajo has joined #openstack-neutron-ovn | 17:00 | |
| *** ltomasbo|away has joined #openstack-neutron-ovn | 17:02 | |
| *** dmellado has joined #openstack-neutron-ovn | 17:06 | |
| *** ThiagoCMC has joined #openstack-neutron-ovn | 17:21 | |
| *** ig0r_ has quit IRC | 17:24 | |
| *** ig0r_ has joined #openstack-neutron-ovn | 17:28 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 17:34 | |
| *** s3wong has joined #openstack-neutron-ovn | 18:01 | |
| russellb | otherwiseguy: lucas-afk functional jobs still appear to be broken | 18:08 |
| otherwiseguy | russellb, looking. | 18:10 |
| otherwiseguy | would be nice if a timed-out test would still display the details of tests that failed. | 18:10 |
| * otherwiseguy reruns locally | 18:10 | |
| * otherwiseguy waits on devstack | 18:25 | |
| *** salv-orlando has quit IRC | 18:29 | |
| * otherwiseguy screams as devstack failed on a volume group error | 18:33 | |
| *** jerrygb has quit IRC | 18:40 | |
| *** jerrygb has joined #openstack-neutron-ovn | 18:49 | |
| *** pcaruana has quit IRC | 19:02 | |
| *** mlavalle has quit IRC | 19:14 | |
| otherwiseguy | russellb, just another instance of importing impl_idl Transaction it looks like. Fixing it in neutron itself. | 19:21 |
| russellb | OK | 19:21 |
| *** mlavalle has joined #openstack-neutron-ovn | 19:22 | |
| openstackgerrit | Terry Wilson proposed openstack/networking-ovn master: Fix unit/functional tests related to Neutron ovsdbapp use https://review.openstack.org/458821 | 19:27 |
| -openstackstatus- NOTICE: Gerrit will be offline briefly starting at 20:00 for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html | 19:42 | |
| otherwiseguy | russellb, is "Running tests" the python version of "Compiling"? (https://xkcd.com/303/) | 19:55 |
| *** ig0r_ has quit IRC | 19:55 | |
| otherwiseguy | fyi, it looks like the new neutron patch is fixing the tests. | 19:55 |
| -openstackstatus- NOTICE: Gerrit is offline briefly for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html | 20:03 | |
| *** ChanServ changes topic to "Gerrit is offline briefly for scheduled maintenance http://lists.openstack.org/pipermail/openstack-dev/2017-April/115702.html" | 20:03 | |
| *** jerrygb has quit IRC | 20:10 | |
| *** jerrygb has joined #openstack-neutron-ovn | 20:25 | |
| *** ChanServ changes topic to "http://docs.openstack.org/developer/networking-ovn/ -=- OVN meeting Thursdays 10:15am Pacific / 1:15pm Eastern #openvswitch -=- Tempest health: http://goo.gl/9MaBJC" | 20:36 | |
| -openstackstatus- NOTICE: Gerrit is back in service and generally usable, though remote Git replicas (git.openstack.org and github.com) will be stale for the next few hours until online reindexing completes | 20:36 | |
| *** openstackgerrit has quit IRC | 20:48 | |
| *** openstackgerrit has joined #openstack-neutron-ovn | 20:52 | |
| openstackgerrit | Terry Wilson proposed openstack/networking-ovn master: Use the ovsdbapp library https://review.openstack.org/458967 | 20:52 |
| *** yamamoto has joined #openstack-neutron-ovn | 20:54 | |
| *** mickeys has quit IRC | 20:58 | |
| *** yamamoto has quit IRC | 20:58 | |
| otherwiseguy | russellb, should we do for ovsdbapp in tox_install.sh something similar to what is done for neutron so that we just test against master? | 21:02 |
| otherwiseguy | is that also the code that makes Depends-On actually use patches that are up for review? | 21:03 |
| otherwiseguy | (for neutron) | 21:03 |
| *** mickeys has joined #openstack-neutron-ovn | 21:14 | |
| *** fzdarsky has quit IRC | 21:20 | |
| *** salv-orlando has joined #openstack-neutron-ovn | 21:38 | |
| *** salv-orl_ has joined #openstack-neutron-ovn | 21:49 | |
| *** salv-orlando has quit IRC | 21:52 | |
| *** mickeys has quit IRC | 22:45 | |
| *** salv-orl_ has quit IRC | 22:48 | |
| *** masber has quit IRC | 23:02 | |
| *** masber has joined #openstack-neutron-ovn | 23:04 | |
| *** mickeys has joined #openstack-neutron-ovn | 23:31 | |
| *** yamamoto has joined #openstack-neutron-ovn | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!