*** shettyg has quit IRC | 01:20 | |
*** s3wong has quit IRC | 02:04 | |
*** armax has quit IRC | 07:48 | |
*** gsagie has joined #openstack-neutron-ovn | 08:44 | |
*** roeyc has joined #openstack-neutron-ovn | 09:14 | |
*** roeyc has quit IRC | 09:45 | |
*** fzdarsky has joined #openstack-neutron-ovn | 10:13 | |
*** gsagie has quit IRC | 10:17 | |
*** roeyc has joined #openstack-neutron-ovn | 10:29 | |
*** fzdarsky has quit IRC | 11:01 | |
*** fzdarsky has joined #openstack-neutron-ovn | 12:19 | |
*** cascardo_ has joined #openstack-neutron-ovn | 13:29 | |
openstackgerrit | Russell Bryant proposed openstack/networking-ovn: Add check for port_security_enabled attribute https://review.openstack.org/196366 | 13:44 |
---|---|---|
openstackgerrit | Russell Bryant proposed openstack/networking-ovn: Remove blank lines from requirements.txt https://review.openstack.org/197097 | 14:06 |
*** roeyc has quit IRC | 14:07 | |
*** roeyc has joined #openstack-neutron-ovn | 14:08 | |
*** gsagie has joined #openstack-neutron-ovn | 14:45 | |
gsagie | otherwiseguy: here? | 14:46 |
otherwiseguy | gsagie: i am | 14:46 |
gsagie | i have some question for you regarding ovs_lib | 14:47 |
gsagie | i noticed that in my setup _set_colval_args_dict() doesnt work so well when i try to set dictionary | 14:48 |
gsagie | as values | 14:48 |
gsagie | but sec, i will post some patch and show you | 14:48 |
gsagie | i might be miss using it | 14:48 |
* otherwiseguy looks | 14:48 | |
otherwiseguy | gsagie: I don't see a _set_colval_args_dict(), just _set_colval_args()? | 15:00 |
gsagie | yeah, sorry i m adding it :) | 15:00 |
gsagie | but i think i found it | 15:01 |
otherwiseguy | ah, then you just need to convert a dict to *((key, val), ..), right? | 15:01 |
gsagie | i think, it didnt work before but let me try it | 15:02 |
gsagie | how will you write it in a pythonic way? you are the expert with this :) | 15:03 |
otherwiseguy | I think just passing a *d.items() to the existing function, maybe? | 15:04 |
otherwiseguy | It's been a while since I wrote that function...and I documented it so well... :p | 15:04 |
gsagie | yeah it works :) | 15:05 |
gsagie | thanks | 15:05 |
otherwiseguy | Cool. :D | 15:06 |
otherwiseguy | and you're welcome! | 15:06 |
gsagie | otherwiseguy: i do see problem when i try to use db_set on ('key', []) for example: | 15:11 |
gsagie | self.set_db_attribute('Port', port_name, 'qos', [], check_error=True) | 15:11 |
gsagie | Stderr: ovs-vsctl: qos=: argument does not end in "=" followed by a value. | 15:11 |
gsagie | let me debug | 15:12 |
gsagie | yeah doesnt work for that case | 15:13 |
gsagie | btw, for the allowed address pairs in ovn, i think currently we only need to add the allowed MAC's to the port mac list, right? | 15:13 |
otherwiseguy | gsagie: You might need to add a [] case to neutron.agent.ovsdb.api.py_to_val. | 15:15 |
otherwiseguy | Not sure, though. | 15:15 |
gsagie | will fix it | 15:16 |
gsagie | or try to :) | 15:16 |
otherwiseguy | re: allowed address pairs in ovn, I don't really know. I've been pretty narrowly focused so far. | 15:17 |
otherwiseguy | I seem to remember py_to_val() being the function I added to "fix broken values that showed up". Sounds like there is another. ;) | 15:18 |
gsagie | its not in it, because its not even being called here | 15:21 |
gsagie | join(map(ovsdb.py_to_val, val not called for empty list | 15:21 |
gsagie | i guess | 15:21 |
openstackgerrit | Merged openstack/networking-ovn: Add check for port_security_enabled attribute https://review.openstack.org/196366 | 15:23 |
gsagie | yeah fixed i think, will add you to review | 15:26 |
openstackgerrit | Gal Sagie proposed openstack/networking-ovn: Add unit tests for allowed_address_pairs port security part https://review.openstack.org/196435 | 15:26 |
*** armax has joined #openstack-neutron-ovn | 15:27 | |
openstackgerrit | Merged openstack/networking-ovn: Remove blank lines from requirements.txt https://review.openstack.org/197097 | 15:36 |
*** roeyc has quit IRC | 15:36 | |
*** roeyc has joined #openstack-neutron-ovn | 15:44 | |
*** fzdarsky has quit IRC | 16:04 | |
*** roeyc has quit IRC | 16:34 | |
gsagie | russellb: wondering if you heard anything regarding the L3 design by any chance :) | 16:37 |
*** openstackgerrit has quit IRC | 16:50 | |
*** openstackgerrit has joined #openstack-neutron-ovn | 16:51 | |
russellb | gsagie: no | 17:17 |
openstackgerrit | Russell Bryant proposed openstack/networking-ovn: Add support for port admin_state_up https://review.openstack.org/195703 | 17:19 |
openstackgerrit | Merged openstack/networking-ovn: Add unit tests for allowed_address_pairs port security part https://review.openstack.org/196435 | 18:58 |
gsagie | russellb : jenkins is running on WIP marked patches? | 19:03 |
russellb | gsagie: yes, it should be | 19:03 |
*** armax has quit IRC | 19:34 | |
*** armax has joined #openstack-neutron-ovn | 20:07 | |
openstackgerrit | Terry Wilson proposed openstack/networking-ovn: Add port 'up' notification https://review.openstack.org/178826 | 20:20 |
*** armax has quit IRC | 21:03 | |
*** armax has joined #openstack-neutron-ovn | 21:11 | |
*** cascardo_ has quit IRC | 22:05 | |
openstackgerrit | Terry Wilson proposed openstack/networking-ovn: Add port 'up' notification https://review.openstack.org/178826 | 22:19 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!