openstackgerrit | gengchc2 proposed openstack/networking-cisco master: Remove support for py34 for networking-cisco https://review.openstack.org/430651 | 00:36 |
---|---|---|
*** bobmel has joined #openstack-networking-cisco | 02:34 | |
*** bobmel has quit IRC | 02:39 | |
*** robcresswell_ has joined #openstack-networking-cisco | 03:04 | |
*** robcresswell has quit IRC | 03:07 | |
*** robcresswell_ is now known as robcresswell | 03:09 | |
*** bobmel has joined #openstack-networking-cisco | 05:01 | |
*** bobmel has quit IRC | 05:06 | |
*** bobmel has joined #openstack-networking-cisco | 07:29 | |
*** bobmel has quit IRC | 07:33 | |
openstackgerrit | Paolo Zarpellon proposed openstack/networking-cisco master: Migration support for saf database https://review.openstack.org/424655 | 08:50 |
*** sambetts|afk is now known as sambetts | 10:19 | |
*** tbachman has quit IRC | 11:45 | |
*** tbachman has joined #openstack-networking-cisco | 13:15 | |
*** tbachman has quit IRC | 13:29 | |
*** tbachman has joined #openstack-networking-cisco | 13:30 | |
*** bobmel has joined #openstack-networking-cisco | 14:42 | |
*** bobmel_ has joined #openstack-networking-cisco | 14:49 | |
*** bobmel has quit IRC | 14:50 | |
bobmel_ | tbachman: You here? | 15:01 |
tbachman | bobmel_: ack :) | 15:01 |
bobmel_ | Great! | 15:01 |
tbachman | bobmel_: what’s up? | 15:01 |
bobmel_ | So regarding that patch | 15:01 |
* tbachman listens in | 15:02 | |
bobmel_ | In the ACI version of the _process_new_ports you | 15:02 |
bobmel_ | only call the parent if the ext gw port is set | 15:02 |
bobmel_ | I'm wondering now, that function is also called for the global router | 15:03 |
tbachman | yeah | 15:03 |
bobmel_ | which will never have the gateway port set | 15:03 |
bobmel_ | but rather will have regular router ports for the external networks | 15:03 |
tbachman | right | 15:03 |
tbachman | so, the ACI stuff is definitely different :) | 15:03 |
tbachman | the GW still gets set with the global router | 15:03 |
tbachman | I ported that to our branch | 15:04 |
tbachman | (or fork, really) | 15:04 |
tbachman | but, there was already code there to set the GW using the global router | 15:04 |
tbachman | (in the original ASR1k stuff) | 15:04 |
tbachman | I think that’s how it’s getting passed now | 15:04 |
tbachman | there’s code in the internal network added code path to check for a global router | 15:05 |
tbachman | and if so, add it as though it were an external network | 15:05 |
tbachman | so, even though the service helper doesn’t call this to set the gateway | 15:05 |
tbachman | it happens | 15:05 |
* tbachman knows this, b/c he’s tested it :) | 15:05 | |
tbachman | bobmel_: is that what you were wondering about? | 15:05 |
tbachman | I’d have to go back and look to remember exactly how this works, but it is indeed working | 15:06 |
bobmel_ | Yeah, I think so | 15:06 |
tbachman | k | 15:06 |
tbachman | bobmel_: in short, I’d go ahead and do what you need in order to get your patch through | 15:06 |
tbachman | I have some “catching up” to do with my ASR + ACI stuff for upstream | 15:06 |
bobmel_ | Ok | 15:06 |
bobmel_ | Do you have a pointer to your internal branch which is the most up to date? | 15:07 |
tbachman | my config agent and l3 drivers still need to go upstream, so you wont’ have to worry about any corresponding code changes there | 15:07 |
tbachman | yeah | 15:07 |
tbachman | just a sec.... | 15:07 |
tbachman | this one: https://github.com/noironetworks/networking-cisco/tree/master-branch | 15:08 |
bobmel_ | Ok, but I can have a look at it anyway for my own understanding. | 15:08 |
tbachman | it’s not completely on par with upstream networking-cisco | 15:08 |
bobmel_ | No worries :-) | 15:08 |
* tbachman is embarrased about his hack in order to get multiple external subnets working, using secondary IPs | 15:08 | |
tbachman | it works, but it’s not what we want for production | 15:09 |
tbachman | b/c neutron doesn’t know about the secondary IPs | 15:09 |
tbachman | and they aren’t managed dynamically | 15:09 |
tbachman | this area needs a lot of work | 15:09 |
tbachman | so I’ll probably leverage what you’ve created | 15:09 |
tbachman | and do it “right” :) | 15:09 |
bobmel_ | No reason to feel embarrased :-) | 15:10 |
tbachman | lol | 15:10 |
tbachman | oh, you haven’t seen it yet ;) | 15:10 |
tbachman | lol | 15:10 |
bobmel_ | Glad to hear I've managed to fool you into thinking I know how to do the right thing :-) | 15:11 |
tbachman | lok | 15:11 |
tbachman | lol | 15:11 |
tbachman | it has to be better than what I have | 15:11 |
tbachman | will look at your patch later today as well | 15:11 |
bobmel_ | Anyway, thanks for the pointer, and also any feedback on the patch. | 15:12 |
tbachman | bobmel_: np! | 15:12 |
*** bobmel_ has quit IRC | 15:19 | |
*** bobmel has joined #openstack-networking-cisco | 15:21 | |
*** tbachman has quit IRC | 15:50 | |
*** tbachman has joined #openstack-networking-cisco | 15:52 | |
*** bobmel has quit IRC | 15:53 | |
*** tbachman has quit IRC | 15:57 | |
*** vhosakot has joined #openstack-networking-cisco | 16:00 | |
*** tbachman has joined #openstack-networking-cisco | 16:32 | |
*** vhosakot has quit IRC | 16:33 | |
*** bobmel has joined #openstack-networking-cisco | 17:11 | |
*** bobmel has quit IRC | 17:12 | |
*** bobmel has joined #openstack-networking-cisco | 17:18 | |
openstackgerrit | Sandhya Dasu proposed openstack/networking-cisco master: UCSM Driver retry Port Profile deletes https://review.openstack.org/327946 | 17:38 |
*** vhosakot has joined #openstack-networking-cisco | 17:53 | |
*** sambetts is now known as sambetts|afk | 18:04 | |
openstackgerrit | Bob Melander proposed openstack/networking-cisco master: Adds support for multiple subnets per external network https://review.openstack.org/424486 | 18:15 |
openstackgerrit | Sandhya Dasu proposed openstack/networking-cisco master: UCSM Driver retry Port Profile deletes https://review.openstack.org/327946 | 19:08 |
openstackgerrit | Bob Melander proposed openstack/networking-cisco master: Adds support for multiple subnets per external network https://review.openstack.org/424486 | 19:57 |
*** bobmel has quit IRC | 20:12 | |
*** tbachman has quit IRC | 21:08 | |
*** tbachman has joined #openstack-networking-cisco | 21:08 | |
*** bobmel has joined #openstack-networking-cisco | 21:13 | |
*** tbachman has quit IRC | 21:13 | |
*** tbachman has joined #openstack-networking-cisco | 21:15 | |
openstackgerrit | Carol Bouchard proposed openstack/networking-cisco master: Implement Rest API in ML2 Nexus Driver https://review.openstack.org/432329 | 21:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!