| openstackgerrit | OpenStack Proposal Bot proposed openstack/networking-bgpvpn master: Updated from global requirements https://review.openstack.org/533902 | 04:14 |
|---|---|---|
| openstackgerrit | OpenStack Proposal Bot proposed openstack/networking-bgpvpn master: Updated from global requirements https://review.openstack.org/533902 | 04:15 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/networking-bgpvpn master: Updated from global requirements https://review.openstack.org/533902 | 04:15 |
| *** vthapar has joined #openstack-net-bgpvpn | 04:57 | |
| *** blake has joined #openstack-net-bgpvpn | 04:59 | |
| *** blake has quit IRC | 06:36 | |
| openstackgerrit | zhaojingjing proposed openstack/networking-bgpvpn master: Keep the consistency of the field "tenant_id" for comparison in "create_bgpvpn_port_association()". https://review.openstack.org/534125 | 06:39 |
| openstackgerrit | Merged openstack/networking-bgpvpn master: Updated from global requirements https://review.openstack.org/533902 | 07:52 |
| *** vthapar has quit IRC | 08:06 | |
| *** matrohon has joined #openstack-net-bgpvpn | 08:21 | |
| *** tmorin has joined #openstack-net-bgpvpn | 08:23 | |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn master: routes-control: add advertise_extra_routes to router_association https://review.openstack.org/507173 | 08:31 |
| openstackgerrit | Łukasz Rajewski proposed openstack/networking-bgpvpn master: Utility functions for port association tests in tempest https://review.openstack.org/534186 | 08:43 |
| openstackgerrit | Łukasz Rajewski proposed openstack/networking-bgpvpn master: Basic tempest tests for port associations https://review.openstack.org/534187 | 08:44 |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn master: bagpipe v2 driver https://review.openstack.org/533143 | 08:46 |
| *** bfernando has joined #openstack-net-bgpvpn | 09:17 | |
| *** matrohon has quit IRC | 09:17 | |
| *** matrohon has joined #openstack-net-bgpvpn | 10:02 | |
| *** vthapar has joined #openstack-net-bgpvpn | 10:14 | |
| *** matrohon has quit IRC | 10:23 | |
| *** matrohon has joined #openstack-net-bgpvpn | 10:24 | |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn master: bagpipe v2 driver https://review.openstack.org/533143 | 11:05 |
| *** matrohon has quit IRC | 11:28 | |
| openstackgerrit | Łukasz Rajewski proposed openstack/networking-bgpvpn master: Utility functions for port association tests in tempest https://review.openstack.org/534186 | 11:47 |
| openstackgerrit | Łukasz Rajewski proposed openstack/networking-bgpvpn master: Basic tempest tests for port associations https://review.openstack.org/534187 | 11:47 |
| *** bfernando has quit IRC | 12:14 | |
| *** matrohon has joined #openstack-net-bgpvpn | 13:35 | |
| *** bfernando has joined #openstack-net-bgpvpn | 13:47 | |
| doude | tmorin Hi saw your last comment I'll push a new patch set | 13:53 |
| tmorin | hi doude | 13:53 |
| tmorin | ok, great | 13:53 |
| doude | about the default value for advertised route, you prefer I set in the help message? | 13:53 |
| tmorin | yes, that would be my preference | 13:54 |
| doude | I missed that comment in my last PS | 13:54 |
| doude | ok | 13:54 |
| tmorin | so that CLI users know what will happen if they do not choose | 13:54 |
| tmorin | without having to look at the API doc | 13:54 |
| doude | but I cannot use any deffined value to build the help message | 13:55 |
| tmorin | I though that doing the following would work: | 14:02 |
| tmorin | - remove store_true for --no-advertise-fixed-ips | 14:02 |
| tmorin | - add " (default:%default)" at the end of the help string for both options | 14:02 |
| doude | I'll set 'help=_("Fixed IPs of the port will be advertised to the BGP VPN (default)")' for command args --advertise-fixed-ips | 14:02 |
| doude | but tmorin it's a boolean set to true if --advertise-fixed-ips and to false if --no-advertise-fixed-ips | 14:04 |
| *** matrohon has quit IRC | 14:05 | |
| doude | that have no sense to set an help message that said for --advertise-fixed-ips 'Fixed IPs of the port will be advertised to the BGP VPN (default: True)' | 14:05 |
| tmorin | yes, this help text is better than what I propose | 14:05 |
| doude | ok let's do that | 14:06 |
| *** matrohon has joined #openstack-net-bgpvpn | 14:20 | |
| *** vthapar has quit IRC | 14:50 | |
| openstackgerrit | Łukasz Rajewski proposed openstack/networking-bgpvpn master: Utility functions for port association tests in tempest https://review.openstack.org/534186 | 15:13 |
| openstackgerrit | Łukasz Rajewski proposed openstack/networking-bgpvpn master: Basic tempest tests for port associations https://review.openstack.org/534187 | 15:15 |
| *** matrohon has quit IRC | 16:58 | |
| openstackgerrit | Merged openstack/networking-bgpvpn master: Updated from global requirements https://review.openstack.org/534274 | 17:03 |
| *** tmorin has quit IRC | 17:20 | |
| *** zigo has quit IRC | 17:33 | |
| *** openstackgerrit has quit IRC | 17:33 | |
| *** bfernando has quit IRC | 17:36 | |
| *** zigo has joined #openstack-net-bgpvpn | 17:37 | |
| *** matrohon has joined #openstack-net-bgpvpn | 20:06 | |
| *** tmorin has joined #openstack-net-bgpvpn | 21:29 | |
| *** tmorin has quit IRC | 22:36 | |
| *** matrohon has quit IRC | 22:45 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!