| *** mickeys has joined #openstack-net-bgpvpn | 00:54 | |
| *** mickeys has quit IRC | 00:58 | |
| *** mickeys has joined #openstack-net-bgpvpn | 01:55 | |
| *** mickeys has quit IRC | 01:59 | |
| *** mickeys has joined #openstack-net-bgpvpn | 02:55 | |
| *** mickeys has quit IRC | 03:00 | |
| *** mickeys has joined #openstack-net-bgpvpn | 03:56 | |
| *** mickeys has quit IRC | 04:00 | |
| *** mickeys has joined #openstack-net-bgpvpn | 04:57 | |
| *** mickeys has quit IRC | 05:01 | |
| *** mickeys has joined #openstack-net-bgpvpn | 05:58 | |
| *** mickeys has quit IRC | 06:02 | |
| *** matrohon has quit IRC | 06:35 | |
| *** matrohon has joined #openstack-net-bgpvpn | 06:54 | |
| *** mickeys has joined #openstack-net-bgpvpn | 06:59 | |
| *** mickeys has quit IRC | 07:03 | |
| *** tmorin has joined #openstack-net-bgpvpn | 07:06 | |
| *** bfernando has joined #openstack-net-bgpvpn | 07:09 | |
| *** bfernando has quit IRC | 07:21 | |
| *** mickeys has joined #openstack-net-bgpvpn | 07:59 | |
| *** mickeys has quit IRC | 08:04 | |
| *** mickeys has joined #openstack-net-bgpvpn | 09:00 | |
| *** mickeys has quit IRC | 09:05 | |
| *** mickeys has joined #openstack-net-bgpvpn | 10:00 | |
| *** mickeys has quit IRC | 10:05 | |
| *** mickeys has joined #openstack-net-bgpvpn | 11:01 | |
| *** mickeys has quit IRC | 11:06 | |
| *** mickeys has joined #openstack-net-bgpvpn | 12:02 | |
| *** mickeys has quit IRC | 12:07 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 12:54 | |
| openstackgerrit | Cedric Savignan proposed openstack/networking-bgpvpn master: [WIP]Add unit tests for bgpvpn_dashboard https://review.openstack.org/469463 | 12:54 |
|---|---|---|
| openstackgerrit | Cedric Savignan proposed openstack/networking-bgpvpn master: [WIP]Add unit tests for bgpvpn_dashboard https://review.openstack.org/469463 | 12:56 |
| *** bobmel has quit IRC | 13:01 | |
| *** mickeys has joined #openstack-net-bgpvpn | 13:03 | |
| *** mickeys has quit IRC | 13:08 | |
| doude | Hi tmorin! How are you doing? | 13:42 |
| tmorin | hi doude! | 13:42 |
| tmorin | fine :) | 13:42 |
| tmorin | you ? | 13:42 |
| doude | i had a look to your bgpvpn-routes-control review | 13:43 |
| doude | lgtm | 13:43 |
| *** bfernando has joined #openstack-net-bgpvpn | 13:43 | |
| doude | just you did not specified the new router association attribut 'route' in the api definition. Is that voluntary? | 13:44 |
| doude | tmorin: I'm good, thx | 13:44 |
| tmorin | doude: I'm not sure which attribute you are talking about | 13:47 |
| tmorin | maybe the documentation explanation is not clear enough | 13:48 |
| tmorin | the 'advertise_extra_route' boolean means "advertise the routes defined in the 'routes' attribute" of the router" | 13:48 |
| tmorin | this is an existing attribute of router | 13:48 |
| tmorin | not a new 'routes' attribute of a router association | 13:49 |
| doude | tmorin: sorry I mean 'advertise_extra_routes' | 13:50 |
| tmorin | ah, did I forget that ? | 13:50 |
| tmorin | it is defined at line 139, isn't it ? | 13:51 |
| tmorin | (of neutron_lib/api/definitions/bgpvpn_routes_control.py) | 13:53 |
| doude | tmorin: sorry I'm lost. 'advertise_extra_routes' is an existing attribute a router extension? | 13:54 |
| tmorin | no, a new one (defined line 139 of eutron_lib/api/definitions/bgpvpn_routes_control.py) | 13:55 |
| doude | ok so you correctly defined it in neutron_lib/api/definitions/bgpvpn_routes_control.py but I cannot see it in request samples here http://docs-draft.openstack.org/77/467277/14/check/gate-neutron-lib-api-ref/dfbe2c9//api-ref/build/html/v2/index.html?expanded=create-router-association-detail,create-port-association-detail#router-associations | 13:57 |
| doude | is it normal/not necessary? | 13:57 |
| *** tmorin1 has joined #openstack-net-bgpvpn | 14:01 | |
| tmorin1 | ah, ok, good point | 14:02 |
| doude | I'll comment that in my review | 14:02 |
| *** tmorin has quit IRC | 14:03 | |
| doude | tmorin1: I think you already discussed that but the host_route subnet attribut could not be tke in account here? | 14:03 |
| tmorin1 | ideally we would give an example of router associations API requests for both the plain 'bgpvpn' case, and for the 'bgpvpn + bgpvpn-routes-control' case | 14:03 |
| doude | perhaphs you can just add the attribut with its default value on the response | 14:03 |
| tmorin1 | not wanting to duplicate things, I did not extend the router association example to include this | 14:03 |
| *** mickeys has joined #openstack-net-bgpvpn | 14:04 | |
| doude | it's a very simple attr, not sure you need to give an exemple how to switch a boolean | 14:04 |
| tmorin1 | I can definitly add it as you suggest, in replies, and add text saying this is absent when the bgpvpn-routes-control extension is not enabled | 14:04 |
| tmorin1 | yes :) | 14:04 |
| doude | yes | 14:04 |
| *** mickeys has quit IRC | 14:08 | |
| doude | tmorin1: I've got another question, I think you already discussed that but the host_route subnet attribut could not be take in account here? | 14:09 |
| *** tmorin has joined #openstack-net-bgpvpn | 14:13 | |
| *** tmorin1 has quit IRC | 14:13 | |
| tmorin | sorry, I was disconnected | 14:18 |
| tmorin | it might have been, but me and Jan when discussing that, we were not liking the idea of overloading the current semantic of this field (which is used to populate VM routing tables, rather than what has to be advertised) | 14:19 |
| doude | ok, thanks | 14:20 |
| doude | I think the routes attr could be easily implemented in Contrail for 'prefix' type. For type 'bgpvpn' I'm not sure how to do that for the moment | 14:23 |
| tmorin | doude: I would think contrail would have a way to leak/readvertise routes from one VPN into another one, because (at least earlier implementation of) the service-chaining implemention was relying on that | 14:55 |
| *** mickeys has joined #openstack-net-bgpvpn | 15:04 | |
| *** mickeys has quit IRC | 15:09 | |
| *** mickeys has joined #openstack-net-bgpvpn | 15:28 | |
| *** mickeys has quit IRC | 15:32 | |
| *** matrohon has quit IRC | 15:44 | |
| *** tmorin has quit IRC | 16:12 | |
| *** bobmel has joined #openstack-net-bgpvpn | 16:49 | |
| *** bfernando has quit IRC | 17:04 | |
| *** eon` has quit IRC | 22:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!