| *** mickeys has quit IRC | 00:04 | |
| *** mickeys has joined #openstack-net-bgpvpn | 00:20 | |
| *** openstackgerrit has quit IRC | 05:48 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 05:48 | |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 07:48 | |
| openstackgerrit | Pierre Crégut proposed openstack/networking-bgpvpn: migration tests as functional tests. https://review.openstack.org/387885 | 07:51 |
|---|---|---|
| openstackgerrit | Pierre Crégut proposed openstack/networking-bgpvpn: migration tests as functional tests. https://review.openstack.org/387885 | 07:54 |
| *** matrohon has joined #openstack-net-bgpvpn | 08:29 | |
| *** mickeys has quit IRC | 09:15 | |
| *** bfernando has joined #openstack-net-bgpvpn | 09:24 | |
| *** mickeys has joined #openstack-net-bgpvpn | 10:16 | |
| *** mickeys has quit IRC | 10:20 | |
| *** bfernando has quit IRC | 10:29 | |
| *** bfernando has joined #openstack-net-bgpvpn | 10:41 | |
| *** tmorin has joined #openstack-net-bgpvpn | 12:25 | |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn: Fix tox cover target https://review.openstack.org/393335 | 14:06 |
| openstackgerrit | Merged openstack/networking-bgpvpn: migration tests as functional tests. https://review.openstack.org/387885 | 14:24 |
| *** mickeys has joined #openstack-net-bgpvpn | 15:03 | |
| openstackgerrit | Édouard Thuleau proposed openstack/networking-bgpvpn: Add OpenStack client BGP VPN extension https://review.openstack.org/388870 | 16:07 |
| matrohon | doude : hi | 16:09 |
| doude | matrohon: yo | 16:09 |
| matrohon | doude : your patch is ready for review? | 16:09 |
| doude | yes | 16:09 |
| doude | I factorized code for router and network associations | 16:10 |
| doude | and wrote unit tests for all commands | 16:10 |
| matrohon | doude : sounds great | 16:11 |
| doude | matrohon, tmorin : we should add some gate check to be sure the commands are not used by another project | 16:11 |
| doude | http://docs.openstack.org/developer/python-openstackclient/plugins.html#checklist-for-adding-new-openstack-plugins | 16:11 |
| matrohon | doude, is it still compatible with neutron classical CLI? | 16:12 |
| doude | but I don't know on wich openstack repo we should summit the patch | 16:12 |
| doude | any clue? | 16:12 |
| doude | matrohon: I did not touch the neutron extension cli | 16:12 |
| matrohon | doude, ack | 16:12 |
| doude | I wrote the osc extension completly independent to the neutron one | 16:13 |
| matrohon | doude, I thinks those steps will be needed once the patch is merged | 16:14 |
| matrohon | dude, don't you think? | 16:14 |
| doude | we could push a review which depends on that patch | 16:14 |
| matrohon | the repo is project-config | 16:15 |
| matrohon | http://git.openstack.org/cgit/openstack-infra/project-config/ | 16:15 |
| matrohon | doude ^ | 16:15 |
| doude | thanks, do you want I propose the patch? | 16:16 |
| matrohon | doude, as you want | 16:16 |
| matrohon | doude, if you don't I'll add it to my todo list | 16:17 |
| doude | I do it to lighten your todo list ;) | 16:17 |
| matrohon | doude, ok thanks, but it is not so full :) | 16:18 |
| doude | :) | 16:18 |
| matrohon | doude, you'll become the first commiter in terms of LOC in net-bgpvpn, congrats! | 16:19 |
| doude | really? | 16:19 |
| matrohon | doude, well I didn't checked, but I wuld not be suprised :) | 16:20 |
| doude | https://review.openstack.org/#/c/393403/ | 16:40 |
| matrohon | doude, the second item is missing in your patch, am I wrong? | 16:46 |
| matrohon | Update jenkins/scripts/check-osc-plugins.sh... | 16:46 |
| doude | matrohon: not sure us necessary | 16:48 |
| doude | but I realize, we don't need to add that gate check | 16:49 |
| matrohon | doude, http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/check-osc-plugins.sh#n49 | 16:49 |
| doude | it's only available for python client I think | 16:49 |
| matrohon | doude, ^ is enough? | 16:49 |
| doude | yes, I think | 16:50 |
| matrohon | doude, actually we should have a job that test changes made to python-neutronclient instead | 16:51 |
| doude | no in fact it should work, but the script only check duplicate between python-[whatever]clients and osc extension installed by the tested project (in our case networking bgpvpn) | 16:54 |
| matrohon | doude at least have our gate testing against the master branch of python-neutronclient | 16:54 |
| doude | so it will not validate overlap between all osc extensions of all openstack project (ie. networking sfc) | 16:55 |
| matrohon | doude does it take the master branch of clients? | 16:56 |
| doude | yes | 16:57 |
| tmorin | doude: the code factoring between the different kind of extensions looks very good :) | 17:00 |
| tmorin | matrohon: I don't think we have to remove the previous CLI ; perhaps we will deprecate it, but we don't have to do that before the neutron client is advertised as deprecated | 17:01 |
| tmorin | doude, matrohon: on the OSC project-config check: let's see what the infra-liaison say, since we will have to move the client definition to python-neutronclient, perhaps it's less useful to define this job in n8g-bgpvpn ... | 17:02 |
| *** matrohon has quit IRC | 17:03 | |
| *** tmorin has quit IRC | 17:09 | |
| *** bfernando has quit IRC | 17:19 | |
| *** mickeys has quit IRC | 22:42 | |
| *** mickeys has joined #openstack-net-bgpvpn | 22:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!