*** mickeys has quit IRC | 00:33 | |
*** mickeys has joined #openstack-net-bgpvpn | 00:34 | |
*** mickeys has quit IRC | 00:38 | |
*** vthapar has joined #openstack-net-bgpvpn | 04:48 | |
*** mickeys has joined #openstack-net-bgpvpn | 04:55 | |
*** vthapar has quit IRC | 05:18 | |
*** mickeys has quit IRC | 05:51 | |
*** mickeys has joined #openstack-net-bgpvpn | 06:32 | |
*** tmorin has joined #openstack-net-bgpvpn | 07:36 | |
*** matrohon has joined #openstack-net-bgpvpn | 07:42 | |
*** mickeys has quit IRC | 08:01 | |
matrohon | hi tmorin | 08:02 |
---|---|---|
*** tmorin has quit IRC | 08:14 | |
*** mickeys has joined #openstack-net-bgpvpn | 08:16 | |
*** mickeys has quit IRC | 08:17 | |
*** mickeys has joined #openstack-net-bgpvpn | 08:17 | |
*** mickeys has quit IRC | 08:21 | |
*** tmorin has joined #openstack-net-bgpvpn | 09:17 | |
tmorin | hi matrohon, what's up ? | 09:17 |
matrohon | tmorin, I started working on https://bugs.launchpad.net/bgpvpn/+bug/1537067 | 09:18 |
openstack | Launchpad bug 1537067 in networking-bgpvpn "enforce constraints on "neutron router-interface-add"" [High,Confirmed] - Assigned to Mathieu Rohon (mathieu-rohon) | 09:18 |
tmorin | good! | 09:18 |
matrohon | tmorin, unfortunately neutron entered the feature freeze window | 09:18 |
tmorin | do we need something new in Neutron to fix this bug ? | 09:19 |
matrohon | https://bugs.launchpad.net/neutron/+bug/1537091 | 09:19 |
openstack | Launchpad bug 1537091 in neutron "Prevent the attachment of a subnet to a router" [Wishlist,Confirmed] - Assigned to Mathieu Rohon (mathieu-rohon) | 09:19 |
tmorin | hmmm | 09:26 |
tmorin | in this bug, armax is saying "If all you need is a callback hook, this does not need an RFE", so maybe this can be added even after feature freeze | 09:26 |
tmorin | I'd say that the best would be to push the required change to neutron, if it does not land in Newton, that's not ideal, but at least it will have been done | 09:27 |
matrohon | yep, that's y plan | 09:27 |
matrohon | but i don't expect my neutron patch to land in newton.. | 09:28 |
tmorin | I'm thinking that the fact that its a requirement to fix a bug in a stadium project, may be a valid reason to accept it for Newton as a bugfix ...? | 09:28 |
tmorin | matrohon: ^^ | 09:28 |
matrohon | we'll try! | 09:28 |
tmorin | I haven't checked, but maybe the root problem can also possibly be solved by listening on a BEFORE_xxx event from the L3plugin | 09:32 |
matrohon | not sure such a event exist! | 09:34 |
tmorin | not sure | 09:51 |
tmorin | but maybe this one https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L485 | 09:51 |
tmorin | the question I have is whether or not it's triggered in all cases (add interface by subnet, add interface by port) | 09:52 |
eon` | tmorin: hello | 12:08 |
eon` | is there already a way to define config options for a particular driver ? | 12:09 |
eon` | in etc/neutron/networking_bgpvpn.conf for example | 12:09 |
tmorin | salut eon` | 12:18 |
tmorin | we don't use any at this point | 12:18 |
tmorin | I would expect that you should be able to put something in /etc/neutron/networking_bgpvpn.conf and have this reached by the service plugin, but I haven't checked | 12:19 |
eon` | tmorin: ok thanks | 12:19 |
tmorin | and assuming this is possible, we certainly don't have anything in place to make this accessible to drivers | 12:19 |
tmorin | sounds like something that some other service plugins may already be doing | 12:20 |
tmorin | neutron-lbaas is usually a good source of inspiration | 12:20 |
eon` | not sure if I will need it. I'm opening a bug and maybe we can discuss on it | 12:21 |
matrohon | eon : i think that you can put any variable in bgpvpn.conf and access it the usual way (with oslo.config) | 12:26 |
eon` | https://bugs.launchpad.net/bgpvpn/+bug/1619651 | 12:36 |
openstack | Launchpad bug 1619651 in networking-bgpvpn "OC driver: use VN api to associate RTs" [Undecided,New] | 12:36 |
eon` | doude: ^^ WDYT ? | 12:36 |
matrohon | it's friday, bgpvpn day for eon :) | 12:37 |
doude | eon`: I like it! +1 | 12:38 |
matrohon | eon`, so what do you want to ad din the conf? the version? | 12:39 |
doude | eon`: why you though to define a config flag for the contrail plugin? | 12:39 |
doude | matrohon, eon` : that could be auto-discovered? | 12:40 |
eon` | something like association_method=v1|v2 | 12:40 |
eon` | I don't know | 12:40 |
eon` | doude: maybe, that would be better | 12:40 |
doude | if you try to update a network for import rt list, you should receive an error for older version | 12:41 |
doude | that could be done during the initialization but the drawback of that is if contrail API is not ready to answer your driver will not succed to start | 12:42 |
eon` | well neutron ifself doesn't start if the API is not responding | 12:42 |
doude | if think a patch was merged on the contrail neutron plugin to prevent that | 12:43 |
doude | let me check | 12:43 |
eon` | maybe on V2 then | 12:43 |
eon` | but we are cool kids, we use V3 :) | 12:43 |
matrohon | tmorin, https://github.com/openstack/neutron/blob/master/neutron/db/l3_db.py#L824 | 12:44 |
matrohon | l3 just notify that an interace has been added | 12:44 |
matrohon | tmorin, no BEFORE_CREATE event | 12:45 |
doude | eon`: yes on v2 is fixed but not on v2 | 12:45 |
doude | *v3 | 12:45 |
eon` | doude: do you have the link ? | 12:45 |
doude | eon`: https://github.com/Juniper/contrail-neutron-plugin/commit/7b319bf17cbe1abf27ef671f428870253b83e5bd | 12:47 |
tmorin | matrohon: I was hoping that _add_interface_by_port and _add_interface_by_subnet may end up calling _create_gw_port that does generate a ROUTER_GATEWAY BEFORE_CREATE event | 12:48 |
tmorin | but I'm multitasking too much and did not dig deeper yet | 12:48 |
matrohon | _create_gw_port is not for internal port | 12:48 |
matrohon | tmorin, but I would better add code in l3_db, we'll be much less notified than with update_port usage | 12:55 |
tmorin | matrohon: yes, true | 12:58 |
*** mickeys has joined #openstack-net-bgpvpn | 14:04 | |
*** mickeys has quit IRC | 14:20 | |
*** matrohon has quit IRC | 15:18 | |
*** mickeys has joined #openstack-net-bgpvpn | 15:38 | |
*** mickeys has quit IRC | 15:49 | |
*** matrohon has joined #openstack-net-bgpvpn | 15:56 | |
*** matrohon has quit IRC | 15:58 | |
*** matrohon has joined #openstack-net-bgpvpn | 15:59 | |
*** tmorin has quit IRC | 16:17 | |
*** matrohon has quit IRC | 16:20 | |
*** mickeys has joined #openstack-net-bgpvpn | 17:09 | |
*** mickeys has quit IRC | 17:10 | |
*** openstackgerrit has quit IRC | 20:04 | |
*** openstackgerrit has joined #openstack-net-bgpvpn | 20:04 | |
*** openstackgerrit has quit IRC | 23:18 | |
*** openstackgerrit has joined #openstack-net-bgpvpn | 23:18 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!