| *** mickeys has quit IRC | 00:43 | |
| *** mickeys has joined #openstack-net-bgpvpn | 00:46 | |
| *** mickeys has quit IRC | 00:51 | |
| *** mickeys has joined #openstack-net-bgpvpn | 02:12 | |
| *** mickeys has joined #openstack-net-bgpvpn | 02:13 | |
| *** mickeys has quit IRC | 02:17 | |
| *** tmorin has joined #openstack-net-bgpvpn | 07:27 | |
| *** enikher has joined #openstack-net-bgpvpn | 07:36 | |
| *** doude has quit IRC | 09:08 | |
| *** doude has joined #openstack-net-bgpvpn | 09:08 | |
| *** matrohon has joined #openstack-net-bgpvpn | 09:20 | |
| matrohon | hi doude | 09:20 |
|---|---|---|
| doude | hi matrohon | 09:23 |
| matrohon | did you see : https://bugs.launchpad.net/bgpvpn/+bug/1596962 ? | 09:24 |
| openstack | Launchpad bug 1596962 in networking-bgpvpn "opencontrail driver issue with a particular network association" [Medium,Confirmed] | 09:24 |
| matrohon | doude, ^ | 09:24 |
| doude | no, I did not | 09:24 |
| matrohon | doude, if you can provide us a fedback? | 09:25 |
| doude | matrohon: I take a look | 09:29 |
| *** enikher has quit IRC | 09:32 | |
| doude | matrohon: seems an issue with networking_bgpvpn/neutron/services/plugin.py code that checks if a network is not linked to a router which is already associated to a bgpvpn | 09:40 |
| matrohon | doude : an issue with net-bgpvpn.... never! :) | 09:41 |
| doude | it expects to find 'routers' attribute in bgpvpn resource but in cas a a service driver which not support the router association, that 'routers' attribut does not exist | 09:41 |
| doude | so KeyError | 09:41 |
| matrohon | ok | 09:43 |
| doude | matrohon: :) | 09:43 |
| matrohon | doude I'll have a closer look | 09:44 |
| matrohon | doude, sorry :) | 09:44 |
| doude | np | 09:44 |
| *** enikher has joined #openstack-net-bgpvpn | 10:03 | |
| *** enikher has left #openstack-net-bgpvpn | 10:08 | |
| *** enikher1 has joined #openstack-net-bgpvpn | 10:19 | |
| *** enikher1 has quit IRC | 10:23 | |
| matrohon | doude, re | 11:36 |
| matrohon | doude, around? | 11:36 |
| *** enikher has joined #openstack-net-bgpvpn | 11:37 | |
| matrohon | doude ? | 12:12 |
| enikher | yes | 12:33 |
| enikher | no I am Nikolas Hermanns | 12:33 |
| enikher | oops | 12:33 |
| enikher | I though you ping me | 12:33 |
| matrohon | enikher :) | 12:37 |
| matrohon | np | 12:37 |
| *** mickeys has joined #openstack-net-bgpvpn | 13:40 | |
| *** mickeys has quit IRC | 13:44 | |
| doude | matrohon: yes (sorry for the delay) | 14:28 |
| matrohon | doude, actually, I think the bug https://bugs.launchpad.net/bgpvpn/+bug/1596962 can be fixed from both sides :) | 14:30 |
| openstack | Launchpad bug 1596962 in networking-bgpvpn "opencontrail driver issue with a particular network association" [Medium,Confirmed] | 14:30 |
| matrohon | doude : for the contrail part, why the driver doesn't add the router if one is attached? | 14:32 |
| doude | matrohon: contrail driver does not support to attach router with bgpvpn | 14:33 |
| matrohon | doude, yep I know, however it supports having a network attached to a router | 14:33 |
| doude | yes | 14:33 |
| doude | but that's not the issue here, no? | 14:35 |
| doude | the core plugin can list router interface on a network | 14:35 |
| doude | and ontrail driver support it | 14:36 |
| matrohon | well, actually I'm concerned since the signature of the get_bgpvpn depends on the used driver | 14:36 |
| doude | but after, the bgpvpn driver code list all bgpvpn of the tenant and checks if one of them is already associated to the router attached to the network | 14:37 |
| doude | ut bgpvpn resources returned by contrail bgpvpn driver does not provide the 'routers' attribute of bgpvpn resource | 14:37 |
| doude | in fact, '_validate_network_has_router_assoc' method is not usefull for service driver which not support router association | 14:39 |
| doude | https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/neutron/services/plugin.py#L71 | 14:39 |
| matrohon | doude, yep I know... but we want to host some generic in here | 14:39 |
| matrohon | hopefully you will implement the router assoc with contrail soon :) | 14:40 |
| doude | in that case, we can fix the contrail driver to return an empty list for the 'routers' attribute of bgpvpn resource | 14:40 |
| doude | certainly :) | 14:40 |
| matrohon | using _make_bgpvpn_dict would be awesome : https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/neutron/db/bgpvpn_db.py#L106 | 14:41 |
| matrohon | we already though about it I think? | 14:41 |
| doude | is there an easy way to knwo if a service driver support the x association, | 14:42 |
| matrohon | no.... | 14:42 |
| doude | because it'll be moreefficient to not call '_validate_network_has_router_assoc' if the driver does not support router association for example | 14:42 |
| matrohon | I understand, going through every bgpvpn is useless in this case | 14:43 |
| doude | for '_validate_network_has_router_assoc', one call to read the network, one call to list the gw port of that network and then one call to list all bgpvpn of the tenant | 14:44 |
| doude | perhaps we can define a list of `feature` supported by the driver | 14:45 |
| doude | that permits to escape cases like this | 14:45 |
| doude | like extensions in the neutron core plugin | 14:45 |
| matrohon | yep, but it'a diplomatic issue : what would eb the sense of the bgpvpn-api, if not every driver implement the define "common" API... | 14:48 |
| matrohon | doude ^ | 14:49 |
| *** enikher has quit IRC | 14:49 | |
| doude | yes, so that meens a bgpvpn driver must implement all bgpvpn API like router association or in the future port association? | 14:50 |
| matrohon | we accept driver to not implement part of the API, temporarily... :) | 14:50 |
| doude | ok | 14:50 |
| matrohon | doude the idea is giving the same API from one deployment to another, regardless what sdn controller is under the hood. | 14:52 |
| doude | there is no `extesnions` like for service provider | 14:53 |
| doude | ? | 14:53 |
| matrohon | doude, we try to avoid extensions... | 14:57 |
| doude | you leean 'we' == 'neutron community' ? | 14:57 |
| doude | s/leean/mean | 14:58 |
| matrohon | doude, however | 15:00 |
| matrohon | doude, yes that's what I mean... | 15:00 |
| matrohon | doude, however I'm not even sure that the nuage driver support the net assoc... | 15:02 |
| matrohon | :) | 15:02 |
| doude | matrohon: ok, so do you want I propose a patch on contrail driver to return an empty list? | 15:02 |
| matrohon | doude, It's a patch in your driver or you want to store a dedicated value in the contrail kvs? | 15:07 |
| matrohon | doude the always empty value, for now :) | 15:07 |
| doude | matrohon: I think just patch common method 'make_bgpvpn_dict' to set 'routers' attribute | 15:08 |
| doude | like it's already done for 'networks' attribute https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/neutron/services/common/utils.py#L71 | 15:08 |
| matrohon | doude, ha! that's the part of the code I was looking for | 15:10 |
| matrohon | thanks | 15:10 |
| matrohon | doude, It's a pity taht we don't use this method in db based dirvers : https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/neutron/db/bgpvpn_db.py#L106 | 15:18 |
| doude | do you seen any diffrences? | 15:18 |
| *** mickeys has joined #openstack-net-bgpvpn | 15:19 | |
| doude | that could be factorizes | 15:22 |
| *** tmorin has quit IRC | 15:55 | |
| *** matrohon has quit IRC | 16:05 | |
| *** mickeys has quit IRC | 20:57 | |
| *** mickeys has joined #openstack-net-bgpvpn | 21:28 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!