| *** vthapar has joined #openstack-net-bgpvpn | 03:37 | |
| *** tmorin has joined #openstack-net-bgpvpn | 08:05 | |
| *** matrohon has joined #openstack-net-bgpvpn | 08:14 | |
| *** openstackgerrit has quit IRC | 08:33 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 08:34 | |
| matrohon | vthapar, hi | 08:53 |
|---|---|---|
| vthapar | matrohon, hello | 08:53 |
| matrohon | vthapar, I started to implement the precommit calls | 08:53 |
| matrohon | vthapar, did you notice? | 08:53 |
| vthapar | matrohon, yeah, saw that. couldn't wait for me to get started ;) | 08:53 |
| matrohon | vthapar, We'd like to have it as fast as possible to be able to tag the mitaka release | 08:54 |
| vthapar | matrohon, let me know how can I help. | 08:54 |
| matrohon | can you start to implement the ODL part, based on my patch? | 08:54 |
| matrohon | vthapar, ^ | 08:54 |
| vthapar | matrohon, thank you. I would've struggled to get it done myself. | 08:54 |
| vthapar | matrohon, yes. was about to ask you if it is good enough to start work on driver | 08:55 |
| matrohon | vthapar, the precommit for the bgpvpn_create is ready I think, I'll upstream the bgpvpn_update part asap | 08:56 |
| vthapar | matrohon, planning to add precommit for net/router associate/disassociate also? or would go for it when we add some more attributes to them? | 08:56 |
| matrohon | vthapar, If you don't need it for mitaka, I'll leave this part for future releases I think | 08:57 |
| matrohon | vthapar, tmorin : we'll discuss that on today's meeting | 08:58 |
| vthapar | matrohon, I don't think we'll need it for mitaka so should be fine. create/update are more important. | 08:58 |
| matrohon | vthapar, will you attend? | 08:58 |
| matrohon | vthapar, fine | 08:58 |
| vthapar | matrohon, yes. with daylight savings it doesn't conflict with my ODL meeting anymore. | 08:58 |
| matrohon | vthapar, the precommit code is very thin in bgpvpn, most of the work will be in drivers | 08:59 |
| vthapar | matrohon, agree. I'm collating information about all the validations that can be done in precommit and once have will add it to driver code. | 09:00 |
| matrohon | vthapar, great | 09:00 |
| tmorin | matrohon: yes, we'll discuss it this afternoon | 09:01 |
| *** tmorin has quit IRC | 09:05 | |
| *** tmorin has joined #openstack-net-bgpvpn | 10:00 | |
| tmorin | sorry folks, I was away | 10:03 |
| openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: Add precommit to the driver create/update_bgpvpn API https://review.openstack.org/295406 | 11:06 |
| *** tmorin has quit IRC | 11:46 | |
| *** tmorin has joined #openstack-net-bgpvpn | 13:35 | |
| tmorin | matrohon: https://review.openstack.org/295406 -> the code looks good | 13:45 |
| tmorin | matrohon: did you do a simple devstack test to confirm that nothing breaks ? | 13:45 |
| tmorin | matrohon: until our gate does more, I prefer to check before merging :) | 13:46 |
| matrohon | tmorin, I understand, but no I didn't :) | 13:46 |
| tmorin | ah ! | 13:46 |
| matrohon | tmorin, I would be very surprised that anything gets broken with this patch, but you're right that deserves a test | 13:47 |
| tmorin | yes, the code looks sane, and the unit test pass, but... | 13:47 |
| matrohon | tmorin, btw, mestery just merge your patch on stable/liberty | 13:47 |
| tmorin | ah good! | 13:47 |
| tmorin | the project-config change is ready to be merged ! | 13:48 |
| matrohon | yep | 13:48 |
| tmorin | the project config change has just merged ! | 13:54 |
| tmorin | *now* we can play with our gate !! :) | 13:54 |
| tmorin | matrohon: ^^ | 13:54 |
| matrohon | tmorin, great news! | 14:02 |
| matrohon | let's try it with 295406 | 14:03 |
| tmorin | yes, why not | 14:04 |
| matrohon | we just need a check-ecperimental, as usual? | 14:04 |
| tmorin | we'd need: (a) bagpipe driver to raise an exception on create (e.g. when RD are specified) and (b) enable bgpvpn tempest tests in the bagpipe creating a bgpvpn with the problematic case (rd specified) | 14:05 |
| tmorin | to simply check that 295406 does not break existing code, we can skip (a), but we need to enable bgpvpn tempest in our bagpipe dsvm job | 14:06 |
| matrohon | tmorin, it's only a matter of setting DEVSTACK_GATE_TEMPEST to 1 and enabling tempest? | 14:11 |
| tmorin | maybe, but I'm not sure that DEVSTACK_GATE_TEMPEST=1 triggers all tempest tests including the one in our plugin | 14:11 |
| tmorin | but we can try | 14:11 |
| tmorin | that's easy | 14:11 |
| matrohon | the patch is ready on my side :) | 14:12 |
| openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: Enabling tempest tests in our bagpipe job https://review.openstack.org/295849 | 14:13 |
| matrohon | tmorin : ^ | 14:14 |
| tmorin | yep | 14:14 |
| tmorin | just seen it | 14:14 |
| tmorin | let's try ! | 14:14 |
| matrohon | it's ongoing! | 14:14 |
| matrohon | tmorin, very useful those rc files! | 14:14 |
| openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: Enabling tempest tests in our bagpipe job https://review.openstack.org/295849 | 14:15 |
| tmorin | matrohon: yes, but I've no merit, just mimick'ed what other jobs do | 14:18 |
| matrohon | tmorin, I'm looking for a projects that already wrote some tempest scenarion tests... to mimick again :) | 14:19 |
| tmorin | net-ovn jobs have things we could immitate to finely select what tempest jobs we enable | 14:20 |
| tmorin | and maybe (I'm not sure) neutron-lbaas has specific tempest jobs in their repo | 14:20 |
| matrohon | ok i'll have a look | 14:20 |
| matrohon | ovn doesn't enable tempest | 14:23 |
| matrohon | they seem to use tempest test but run rally with them | 14:23 |
| matrohon | oh i'm wrong : https://github.com/openstack/networking-ovn/blob/605f5d1d5c56c0f596d97d07d6dd00f2288aa923/devstack/devstackgaterc#L24 | 14:24 |
| *** openstackgerrit has quit IRC | 14:33 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 14:34 | |
| tmorin | matrohon: about https://review.openstack.org/295406 | 14:54 |
| tmorin | I've tested it in my devstack and the bagpipe driver does not break | 14:54 |
| tmorin | quick test with the heat templates | 14:54 |
| tmorin | so I will +2+A the change | 14:55 |
| tmorin | without waiting for a devstack job to confirm the inocuity of the change | 14:55 |
| tmorin | the results of the experimental job test are in | 14:58 |
| tmorin | http://logs.openstack.org/49/295849/2/experimental/gate-install-dsvm-networking-bgpvpn-bagpipe/fa019af/ | 14:58 |
| vthapar | tmorin, matrohon: I still haven't got all the data I need for odl driver validations but looks like we will need precommit for router/net association. | 14:59 |
| tmorin | vthapar: it is not unreasonable at all | 15:00 |
| tmorin | vthapar: out of curiosity, would you mind being more explicit about why this is useful for assocations as well ? | 15:01 |
| vthapar | tmorin, we currently don't support associating given router and network to be associated to multiple bgpvpns. | 15:01 |
| tmorin | (meeting on #openstack-meeting-alt now) | 15:01 |
| tmorin | vthapar: ah, I see | 15:01 |
| openstackgerrit | Merged openstack/networking-bgpvpn: Add precommit to the driver create/update_bgpvpn API https://review.openstack.org/295406 | 15:16 |
| *** vthapar has quit IRC | 16:05 | |
| *** tmorin has quit IRC | 16:07 | |
| *** matrohon has quit IRC | 16:37 | |
| *** tmorin has joined #openstack-net-bgpvpn | 16:55 | |
| *** tmorin has quit IRC | 17:16 | |
| *** openstackgerrit has quit IRC | 21:48 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 21:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!