| openstackgerrit | Delcourt Claire proposed openstack/networking-bgpvpn: correcting url for nuage website https://review.openstack.org/294351 | 01:14 |
|---|---|---|
| *** tmorin has joined #openstack-net-bgpvpn | 08:04 | |
| *** enikher has joined #openstack-net-bgpvpn | 08:15 | |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn: Update and improve bagpipe driver documentation https://review.openstack.org/291226 | 08:36 |
| openstackgerrit | Merged openstack/networking-bgpvpn: correcting url for nuage website https://review.openstack.org/294351 | 08:43 |
| enikher | tmorin: Hey Thomas, do you have time to have a look at my tempest commits? | 08:46 |
| *** matrohon has joined #openstack-net-bgpvpn | 09:34 | |
| tmorin | enikher: ^^ having a look yes, but not more | 09:57 |
| tmorin | matrohon and me, we usually try to spin the change in a devstack before merging | 09:58 |
| tmorin | enikher: but the changes look relevant for sure | 09:58 |
| matrohon | enikher, I'll try it in a minute | 10:11 |
| matrohon | this remind me that we should enable tempest in our job | 10:11 |
| matrohon | enikher, oh I see you already updated our jobs | 10:12 |
| matrohon | tmorin ^ | 10:12 |
| matrohon | https://review.openstack.org/#/c/258522/ | 10:12 |
| tmorin | yes | 10:12 |
| tmorin | I need to check that it's consistent with the job change I made | 10:13 |
| tmorin | it seems like it is, I have one thing to check | 10:13 |
| matrohon | tmorin, not sure i'ts a good idea to merge this considering your current work | 10:13 |
| matrohon | tmorin, ++ | 10:13 |
| tmorin | one question is: | 10:15 |
| tmorin | do we want to enable tempest on all jobs ? (if yes, we don't need a new job) | 10:16 |
| tmorin | maybe it's good to have tempest + non-tempest jobs, but then we may want a tempest job for the dummy driver, and a tempest job for the bagpipe driver ? | 10:16 |
| matrohon | why not enbling tempest for every jobs? | 10:17 |
| tmorin | matrohon: maybe we can, if we run only the bgpvpn tempest test, this shouldn't delay too much the merges (once we make the jobs non-experimental) | 10:18 |
| openstackgerrit | Merged openstack/networking-bgpvpn: Update and improve bagpipe driver documentation https://review.openstack.org/291226 | 10:20 |
| matrohon | tmorin : I think what makes more sense is to enable tempest for bgpvn-bagpipe, to ensure that everything is working correctly, even when bagpipe is on | 10:22 |
| matrohon | tmorin, this is the only interesting job to me | 10:23 |
| tmorin | matrohon: do you mean that enabling tempest on a setup with the dummy driver is not useful ? | 10:23 |
| tmorin | ok... | 10:23 |
| matrohon | this kind of test is already done by the bagpipe test : check that devstack plugin works, and that the service plugin can be set up in neutron | 10:24 |
| matrohon | tmorin, ^ | 10:24 |
| tmorin | agreed | 10:26 |
| tmorin | enikher: ^^ | 10:26 |
| enikher | sorry I am here | 10:26 |
| enikher | I am reading | 10:26 |
| tmorin | enikher: we tend to think that we should enable tempest via a change of the existing jobs | 10:26 |
| tmorin | enikher: this would be done via rcfiles in networking-bagpipe once https://review.openstack.org/#/c/291103/ is merged | 10:27 |
| tmorin | enikher: sorry to have let you work on reviving the tempest job | 10:27 |
| enikher | mhhh | 10:28 |
| tmorin | do you agree ? does that makes sense to you ? | 10:28 |
| enikher | yes it make sence to have not 2 jobs | 10:28 |
| enikher | but we got already a +2 for my commit | 10:29 |
| enikher | why don't we remove the bagpipe job in the other commit | 10:29 |
| enikher | that will be much faster | 10:29 |
| enikher | or? | 10:29 |
| matrohon | tmorin, enikher : enikher's job looks like the only job that we need | 10:31 |
| tmorin | I'm thinking | 10:31 |
| tmorin | :) | 10:31 |
| enikher | mhh | 10:31 |
| tmorin | let's see: it may require some time before we have tempest stuff working nicely in the gate | 10:31 |
| enikher | me as well | 10:31 |
| tmorin | having different jobs may be useful in the meantime | 10:31 |
| enikher | I think a dummy job is still ok or? | 10:31 |
| matrohon | I'm lookingg for a way to experiment that job in the gate before merging it... | 10:32 |
| enikher | ok | 10:32 |
| tmorin | it would allow us to refine the tempest job and move other jobs to non-experimental | 10:32 |
| tmorin | matrohon: to experiment, it's easier with a distinct job | 10:33 |
| enikher | I am ok with that as well | 10:33 |
| matrohon | I'm not sure to follow, tmorin what do you want to experiment? | 10:34 |
| tmorin | matrohon: experiment with a tempest job, to make it work and do everything we need (and not more) | 10:35 |
| *** enikher has quit IRC | 11:05 | |
| *** enikher has joined #openstack-net-bgpvpn | 11:05 | |
| enikher | tmorin: matrohon: we need this commit before tempest can run successfull | 11:07 |
| enikher | https://review.openstack.org/#/c/294166/ | 11:07 |
| tmorin | yes | 11:07 |
| enikher | just to make that clear :-) | 11:08 |
| tmorin | can you add a "Depends-on:" to track this ? | 11:08 |
| tmorin | can you also add a "Depends-on: <change id of https://review.openstack.org/#/c/291103/ >" ? | 11:08 |
| enikher | to my infra commit? | 11:37 |
| enikher | tmorin: ^^ | 11:38 |
| matrohon | enikher, to your infra commit, yep | 12:40 |
| enikher | mmmhh, but it has not a dependence or? | 12:41 |
| enikher | tmorin: ^ | 12:41 |
| enikher | I mean it could be merged without the commit 291103 | 12:41 |
| enikher | I have not pushed them in dependence so that both commits can go in when ever they are ready. | 12:42 |
| enikher | I don't think that we will have a merge conflict. there are some lines in between | 12:43 |
| *** openstackgerrit has quit IRC | 12:48 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 12:49 | |
| tmorin | enikher: it's not a question of mergle conflict, it's just to track that for instance, merging one depending on the rcfiles before the change adding the rcfiles will result in a non-working job | 12:59 |
| openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: Remove bagpipe related code in setup.cfg and devstack plugin https://review.openstack.org/294623 | 14:46 |
| openstackgerrit | Merged openstack/networking-bgpvpn: Uplift to latest Tempest https://review.openstack.org/294166 | 14:48 |
| openstackgerrit | Merged openstack/networking-bgpvpn: [Tempest] test_create_bgpvpn_as_non_admin_fail https://review.openstack.org/294194 | 15:14 |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn: Depend on the right networking-bagpipe branch https://review.openstack.org/294659 | 15:17 |
| *** enikher has left #openstack-net-bgpvpn | 15:27 | |
| *** enikher1 has joined #openstack-net-bgpvpn | 15:29 | |
| *** enikher1 has left #openstack-net-bgpvpn | 15:29 | |
| *** michchap has quit IRC | 15:51 | |
| *** michchap has joined #openstack-net-bgpvpn | 16:00 | |
| *** tmorin has quit IRC | 16:26 | |
| *** matrohon has quit IRC | 16:31 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!