| opendevreview | Takashi Kajinami proposed openstack/monasca-agent master: Revert "Replace fnmatch with oslo.utils.fnmatch" https://review.opendev.org/c/openstack/monasca-agent/+/799585 | 12:25 |
|---|---|---|
| chaconpiza | #startmeeting monasca | 13:01 |
| opendevmeet | Meeting started Tue Jul 6 13:01:35 2021 UTC and is due to finish in 60 minutes. The chair is chaconpiza. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:01 |
| opendevmeet | The meeting name has been set to 'monasca' | 13:01 |
| adriancz | Hi | 13:01 |
| chaconpiza | Hi adriancz | 13:01 |
| chaconpiza | The agenda as usual https://etherpad.opendev.org/p/monasca-team-meeting-agenda | 13:02 |
| chaconpiza | Let's start | 13:03 |
| chaconpiza | #topic [Ceilometer Monasca Client] Lots of warnings and stack traces during test runs | 13:03 |
| chaconpiza | https://bugs.launchpad.net/ceilometer/+bug/1934220 | 13:04 |
| chaconpiza | created by Matthias Runge | 13:04 |
| chaconpiza | I investigated the issue | 13:05 |
| chaconpiza | and was able to reproduce it | 13:05 |
| chaconpiza | In Ceilometer there are unittests related to Monasca, basically monasca-publisher, monasca-data-filter and monasca-client | 13:06 |
| chaconpiza | The issue reported in Launchpad is from monasca-client | 13:07 |
| chaconpiza | There are 8 unittest of Ceilometer's monasca-client | 13:07 |
| chaconpiza | some of these tests check scenarios with a mocked wrong response | 13:09 |
| chaconpiza | for example, unauthenticated user | 13:09 |
| chaconpiza | all those tests work ok. But of course the stacktracke of the exception is displayed in the output | 13:10 |
| chaconpiza | This is what Matthias don't like | 13:10 |
| chaconpiza | What do you think Adrian? | 13:11 |
| adriancz | also I don't like this | 13:12 |
| chaconpiza | The question, is it ok to display in the output of the tests stack traces of the mocked exceptions? | 13:13 |
| adriancz | i don't like this exception in the output | 13:14 |
| adriancz | in my opinion this look ugly and sometimes is hard to read test result because of that. | 13:16 |
| adriancz | we should see exception only when test fails | 13:16 |
| chaconpiza | Check this unittest from Nova: | 13:17 |
| chaconpiza | https://zuul.opendev.org/t/openstack/build/85f0fc646ca949a3a07649cc26dcb5df/log/job-output.txt | 13:17 |
| chaconpiza | Line No. 51901 | 13:17 |
| chaconpiza | (It takes a little bit to load) | 13:17 |
| chaconpiza | Can you see that? | 13:18 |
| adriancz | yes, I can | 13:19 |
| adriancz | i don't like this output | 13:19 |
| chaconpiza | So, it is a similar situation: A mocked exception or mocked class that leads to the exception, as expected | 13:20 |
| adriancz | imagine this output when you try to run tests in your local machine | 13:20 |
| adriancz | and one test fail | 13:20 |
| chaconpiza | and then the test finishes with the `{4} nova.tests.unit.network.test_network_info.NetworkInfoTests.test_hydrate [0.031209s] ... ok` | 13:20 |
| adriancz | and you try to search for exception | 13:20 |
| chaconpiza | Yes, I think this is the point of Matthias. | 13:21 |
| chaconpiza | in the other hand, all unittests in OpenStack present this behavior | 13:21 |
| chaconpiza | I tried inside of the test to Try&Catch the exception and then Log some text about it. To replace the Traceback with the a Log file | 13:23 |
| chaconpiza | But, unfortunately without success. | 13:23 |
| chaconpiza | even Try&Catch with general Exception and BaseException doesn't work. | 13:23 |
| chaconpiza | Adrian do you have any idea? | 13:24 |
| adriancz | at this pond I have no idea | 13:24 |
| adriancz | i would need check the code | 13:25 |
| adriancz | and play with this unit tests | 13:25 |
| chaconpiza | I will take a look on the monasca-client unittests from the monasca-pythonclient repo. And compare them with the monasca-client unittests from the Ceilometer. | 13:26 |
| adriancz | +1 | 13:26 |
| chaconpiza | alright, anyways I will treat it with low priority, since nothing is really broken. | 13:26 |
| chaconpiza | let's move forward | 13:27 |
| chaconpiza | #topic [Monasca-Agent] Revert "Replace fnmatch with oslo.utils.fnmatch" | 13:28 |
| chaconpiza | https://review.opendev.org/c/openstack/monasca-agent/+/799585 | 13:28 |
| adriancz | +2 from me | 13:29 |
| chaconpiza | Because of some issues in PY2 with the standard fnmatch library, the oslo.utils.fnmach was used | 13:29 |
| adriancz | i think we should merge this | 13:30 |
| chaconpiza | Yes, I am agreed. | 13:30 |
| chaconpiza | Same change is on Ceilometer, Barbican, etc. | 13:31 |
| adriancz | do we need to cherry pick this to stable branches ? | 13:32 |
| chaconpiza | I was thinking on that, because Wallaby, Victoria and Ussuri are PY3 only | 13:32 |
| chaconpiza | I will wait a little bit before to merge it into master, to see if somebody from the other projects complains on that change. | 13:33 |
| *** osmanlicilegi is now known as Guest4 | 13:34 | |
| adriancz | Good idea | 13:35 |
| chaconpiza | But I am almost sure that the change will be accepted. | 13:35 |
| chaconpiza | Ok | 13:35 |
| chaconpiza | #topic Monasca Images Build (Stable Branches) | 13:35 |
| chaconpiza | Here as mentioned before, let's stop building everyday Train | 13:36 |
| chaconpiza | Train is already in EM stage | 13:37 |
| adriancz | I agree | 13:37 |
| chaconpiza | https://review.opendev.org/c/openstack/releases/+/790758 | 13:37 |
| chaconpiza | No need to build it everyday | 13:37 |
| chaconpiza | Beside of the Train branch, we have issue in the other stable branches | 13:38 |
| chaconpiza | Wallaby ,Victoria and Ussuri | 13:38 |
| chaconpiza | The only one that is ok (with exception of Train) is Monasca-Notification | 13:39 |
| chaconpiza | Let's start to fix them, Adrian do you have any preference? | 13:40 |
| chaconpiza | Persister, Api, Agent, Common, etc... | 13:40 |
| adriancz | i think i can start with api or persister | 13:41 |
| chaconpiza | Alright, take please persister I will take Api | 13:41 |
| adriancz | I think w should first check common | 13:42 |
| adriancz | because all image depend on this | 13:42 |
| chaconpiza | Monasca-Common is building ok from master branch | 13:42 |
| adriancz | perfect | 13:42 |
| adriancz | Ok, I will take persister | 13:43 |
| chaconpiza | persister from master use as a base image monasca-common from master | 13:43 |
| chaconpiza | persister from Wallaby use as a base image monasca-common from master too | 13:43 |
| chaconpiza | persister from Victoria use as a base image monasca-common from master too | 13:44 |
| chaconpiza | etc... | 13:44 |
| chaconpiza | this is a second change we need to do after fixing the images: | 13:44 |
| chaconpiza | persister from Wallaby SHOULD use as a base image monasca-common from Wallaby | 13:45 |
| chaconpiza | and so on | 13:45 |
| chaconpiza | ok, those are all topic from the agenda | 13:46 |
| chaconpiza | Do you have any other topic to discuss today? | 13:46 |
| adriancz | No | 13:48 |
| adriancz | i have no topic | 13:48 |
| chaconpiza | Then let's close the meeting | 13:48 |
| chaconpiza | Thanks see you next week | 13:48 |
| adriancz | Thanks Martin | 13:48 |
| adriancz | bye | 13:49 |
| chaconpiza | #endmeeting | 13:49 |
| opendevmeet | Meeting ended Tue Jul 6 13:49:32 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 13:49 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/monasca/2021/monasca.2021-07-06-13.01.html | 13:49 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/monasca/2021/monasca.2021-07-06-13.01.txt | 13:49 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/monasca/2021/monasca.2021-07-06-13.01.log.html | 13:49 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!