| *** k_mouza has joined #openstack-monasca | 00:37 | |
| *** k_mouza has quit IRC | 00:41 | |
| openstackgerrit | Yanos Angelopoulos proposed openstack/monasca-agent master: Set 'libvirt_type' and 'libvirt_uri' options in the 'libvirt' plugin to be defined in conf.d/libvirt.yaml https://review.opendev.org/762221 | 00:51 |
|---|---|---|
| *** k_mouza has joined #openstack-monasca | 00:51 | |
| *** yan0s has joined #openstack-monasca | 00:52 | |
| yan0s | Hello, could someone have a look at this? | 00:53 |
| yan0s | https://review.opendev.org/#/c/762221/ | 00:53 |
| *** k_mouza has quit IRC | 01:45 | |
| *** yan0s has quit IRC | 03:16 | |
| *** nikparasyr has joined #openstack-monasca | 06:47 | |
| *** tosky has joined #openstack-monasca | 07:23 | |
| *** witek has joined #openstack-monasca | 08:07 | |
| *** dougsz has joined #openstack-monasca | 08:58 | |
| *** k_mouza has joined #openstack-monasca | 10:09 | |
| chaconpiza | yan0s: I have commented at https://review.opendev.org/#/c/762221/ | 10:34 |
| chaconpiza | Hi Yanos, thanks for your investigation and thanks for the fix. | 10:34 |
| chaconpiza | At first glance it looks like we are using oslo-config [1] to handle the configuration like in the rest of Monasca modules. But you are right, monasca-agent is still using .yaml files instead of oslo-config .conf files. | 10:34 |
| chaconpiza | The code in monasca_agent/collector/virt was derived from Ceilometer, and these are "loose ends". | 10:34 |
| chaconpiza | Yanos, would you like to lead the migration to oslo-config? | 10:34 |
| chaconpiza | It should be similar to this changes in Monasca-notification [2] | 10:34 |
| chaconpiza | Of course we will help you if you decide to take the migration. | 10:34 |
| chaconpiza | [1] https://opendev.org/openstack/monasca-agent/src/branch/master/monasca_agent/collector/virt/libvirt/inspector.py#L21 | 10:34 |
| chaconpiza | [2] https://storyboard.openstack.org/#!/story/2000959 | 10:34 |
| *** yan0s has joined #openstack-monasca | 10:45 | |
| yan0s | Hi chaconpiza, so the yaml files are deprecated and everything should be defined in a config file like "/etc/monasca/monasca-agent.conf"? | 11:12 |
| *** witek has quit IRC | 11:25 | |
| chaconpiza | Hi yan0s, yes yaml configuration are considered deprecated. Not all configuration parameters should land into a single .con file, they can have be separated like /etc/monasca/monasca-agent.conf (main parameters) /etc/monasca/conf.d/libvirt.conf , etc | 11:42 |
| yan0s | ok got it, should I make the changes on the same PR (https://review.opendev.org/#/c/762221/)? | 11:50 |
| chaconpiza | No | 11:50 |
| chaconpiza | better let's go step by step | 11:50 |
| chaconpiza | I would like to merge your change to fix the issue and keep using yaml for now | 11:50 |
| chaconpiza | I am waiting for my other colleagues to take a look on the change | 11:51 |
| chaconpiza | Then, let's create a Storyboard and then create a new change for the migration ;-) | 11:51 |
| chaconpiza | I will add this topic to the weekly meeting | 11:54 |
| yan0s | when is the next meeting? | 11:55 |
| chaconpiza | Tuesday November 17th 2020 (13:00 UTC) | 11:57 |
| chaconpiza | let me copy the etherpad | 11:57 |
| chaconpiza | https://etherpad.opendev.org/p/monasca-team-meeting-agenda | 11:57 |
| openstackgerrit | Martin Chacon Piza proposed openstack/monasca-notification master: Fixed docker configuration template https://review.opendev.org/760081 | 12:00 |
| openstackgerrit | Merged openstack/monasca-notification master: Fixed docker configuration template https://review.opendev.org/760081 | 13:35 |
| *** yan0s has quit IRC | 13:57 | |
| *** witek has joined #openstack-monasca | 15:33 | |
| *** witek has quit IRC | 17:17 | |
| *** dougsz has quit IRC | 17:31 | |
| *** k_mouza has quit IRC | 17:40 | |
| *** k_mouza has joined #openstack-monasca | 17:40 | |
| *** k_mouza has quit IRC | 17:45 | |
| *** nikparasyr has left #openstack-monasca | 17:49 | |
| *** dougsz has joined #openstack-monasca | 19:32 | |
| *** dougsz has quit IRC | 19:37 | |
| *** chaconpiza has quit IRC | 21:10 | |
| *** osmanlicilegi has quit IRC | 21:37 | |
| *** osmanlicilegi has joined #openstack-monasca | 21:37 | |
| *** tosky has quit IRC | 21:40 | |
| *** elod has quit IRC | 21:40 | |
| *** EarlEuene_ has quit IRC | 21:40 | |
| *** tosky has joined #openstack-monasca | 21:41 | |
| *** elod has joined #openstack-monasca | 21:41 | |
| *** EarlEuene_ has joined #openstack-monasca | 21:41 | |
| *** tobberydberg_ has quit IRC | 21:46 | |
| *** johanssone has quit IRC | 21:46 | |
| *** trident has quit IRC | 21:46 | |
| *** tobberydberg_ has joined #openstack-monasca | 21:47 | |
| *** fungi has quit IRC | 21:48 | |
| *** johanssone has joined #openstack-monasca | 21:50 | |
| *** trident has joined #openstack-monasca | 21:50 | |
| *** fungi has joined #openstack-monasca | 21:51 | |
| *** Wasaac has quit IRC | 21:51 | |
| *** Wasaac has joined #openstack-monasca | 21:53 | |
| *** bbezak has quit IRC | 21:53 | |
| *** bbezak has joined #openstack-monasca | 21:53 | |
| *** bbezak has quit IRC | 21:53 | |
| *** Wasaac has quit IRC | 21:53 | |
| *** johanssone has quit IRC | 21:53 | |
| *** trident has quit IRC | 21:53 | |
| *** fungi has quit IRC | 21:53 | |
| *** tobberydberg_ has quit IRC | 21:53 | |
| *** elod has quit IRC | 21:53 | |
| *** EarlEuene_ has quit IRC | 21:53 | |
| *** tosky has quit IRC | 21:53 | |
| *** osmanlicilegi has quit IRC | 21:53 | |
| *** irclogbot_3 has quit IRC | 21:53 | |
| *** coreycb has quit IRC | 21:53 | |
| *** gmann has quit IRC | 21:53 | |
| *** openstackgerrit has quit IRC | 21:53 | |
| *** guilhermesp has quit IRC | 21:53 | |
| *** srwilkers has quit IRC | 21:53 | |
| *** sc has quit IRC | 21:53 | |
| *** bbezak has joined #openstack-monasca | 21:54 | |
| *** Wasaac has joined #openstack-monasca | 21:54 | |
| *** fungi has joined #openstack-monasca | 21:54 | |
| *** trident has joined #openstack-monasca | 21:54 | |
| *** johanssone has joined #openstack-monasca | 21:54 | |
| *** tobberydberg_ has joined #openstack-monasca | 21:54 | |
| *** EarlEuene_ has joined #openstack-monasca | 21:54 | |
| *** elod has joined #openstack-monasca | 21:54 | |
| *** tosky has joined #openstack-monasca | 21:54 | |
| *** osmanlicilegi has joined #openstack-monasca | 21:54 | |
| *** guilhermesp has joined #openstack-monasca | 21:54 | |
| *** srwilkers has joined #openstack-monasca | 21:54 | |
| *** coreycb has joined #openstack-monasca | 21:54 | |
| *** gmann has joined #openstack-monasca | 21:54 | |
| *** irclogbot_3 has joined #openstack-monasca | 21:54 | |
| *** openstackgerrit has joined #openstack-monasca | 21:54 | |
| *** sc has joined #openstack-monasca | 21:54 | |
| *** sc has quit IRC | 21:54 | |
| *** trident has quit IRC | 21:54 | |
| *** sc has joined #openstack-monasca | 21:54 | |
| *** trident has joined #openstack-monasca | 21:55 | |
| *** k_mouza has joined #openstack-monasca | 22:15 | |
| *** k_mouza has quit IRC | 22:20 | |
| *** tosky has quit IRC | 23:08 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!