| *** k_mouza has joined #openstack-monasca | 00:09 | |
| *** k_mouza has quit IRC | 00:14 | |
| *** elod has quit IRC | 01:35 | |
| *** elod has joined #openstack-monasca | 01:37 | |
| *** mbindlish has joined #openstack-monasca | 05:26 | |
| *** mbindlish has quit IRC | 05:27 | |
| *** mbindlish has joined #openstack-monasca | 05:29 | |
| *** vishalmanchanda has joined #openstack-monasca | 06:06 | |
| *** ezech has joined #openstack-monasca | 06:40 | |
| *** tosky has joined #openstack-monasca | 07:25 | |
| *** dougsz has joined #openstack-monasca | 07:39 | |
| dougsz | mkarpiarz: To be honest, I don't understand why those options aren't part of the libvirt plugin config. | 07:47 |
|---|---|---|
| dougsz | You could set them via the [DEFAULT] section? | 07:48 |
| dougsz | Statsd has a section in there because the Monasca Agent hosts a statsd server for things like application monitoring, and self monitoring of some Monasca components. | 07:50 |
| dougsz | Good working digging into it! | 07:57 |
| dougsz | s/working/work | 07:58 |
| *** dougsz has quit IRC | 09:22 | |
| mkarpiarz | Ah, but Monasca Agent config is a yaml with dicts like "Main" and "Logging", not an ini file. | 09:38 |
| *** dougsz has joined #openstack-monasca | 09:38 | |
| mkarpiarz | See here: https://github.com/openstack/kolla-ansible/blob/stable/train/ansible/roles/monasca/templates/monasca-agent-statsd/agent-statsd.yml.j2 | 09:38 |
| mkarpiarz | Or for the config file used by the libvirt agent: https://github.com/openstack/kolla-ansible/blob/stable/train/ansible/roles/monasca/templates/monasca-agent-collector/agent-collector.yml.j2 | 09:39 |
| mkarpiarz | Do you want me to add these options to the API config file? | 09:40 |
| mkarpiarz | https://github.com/openstack/kolla-ansible/blob/stable/train/ansible/roles/monasca/templates/monasca-api/api.conf.j2 | 09:40 |
| mkarpiarz | Bear in mind that kolla-ansible only mounts the agent-collector.yml and yamls for plugins in the collector container. | 09:42 |
| mkarpiarz | https://github.com/openstack/kolla-ansible/blob/stable/train/ansible/roles/monasca/templates/monasca-agent-collector/monasca-agent-collector.json.j2 | 09:42 |
| mkarpiarz | It feels to me like 'libvirt_uri' belongs to the main agent's yaml in a separate dict (like for statsd) or in the libvirt plugin config. | 09:45 |
| dougsz | mkarpiarz: I agree, I think all configuration for the libvirt plugin should be in the libvirt plugin config file. | 09:50 |
| dougsz | You have confirmed that the libvirt plugin will read those options (libvirt_uri etc) from agent-collector.yml [DEFAULT] section? | 09:52 |
| dougsz | Without looking in close detail it would seem reasonable to deprecate those options and add support for reading them from the libvirt plugin config. | 09:53 |
| mkarpiarz | There is no [DEFAULT] section in agent-collector.yml. Do you mean the "Main" dict? | 09:53 |
| dougsz | yeah, sorry | 09:53 |
| mkarpiarz | I can definitely see the agent-collector.yaml is read by the main monasca-agent code. | 09:59 |
| mkarpiarz | This agent config is the passed to the constructor of the libvirt check collector. | 10:00 |
| mkarpiarz | https://opendev.org/openstack/monasca-agent/src/branch/stable/train/monasca_agent/collector/checks_d/libvirt.py#L77 | 10:01 |
| mkarpiarz | Both "agent_config" (agent-collector.yml) and "init_config" (the "init_config" section of plugins/libvirt.yaml) should be available to this check then. | 10:03 |
| dougsz | No mention of those oslo config options in: https://github.com/openstack/monasca-agent/blob/master/docs/Libvirt.md | 10:05 |
| mkarpiarz | However the 'libvirt_uri' parameter is registered in this "inspector" module, not in the check itself. | 10:08 |
| mkarpiarz | https://opendev.org/openstack/monasca-agent/src/branch/stable/train/monasca_agent/collector/virt/libvirt/inspector.py#L37 | 10:08 |
| dougsz | Yeah - just looking at some of the other inspector components - for Xen they at least use an opt group when registering the conf options: opt_group = cfg.OptGroup(name='xenapi') | 10:10 |
| mkarpiarz | So I'm assuming either agent_config or init_config would have to be passed to monasca_agent.collector.virt.inspector or monasca_agent.collector.virt.libvirt.inspector first. | 10:10 |
| mkarpiarz | Ah, OK, so maybe the same should be done for the libvirt inspector. | 10:12 |
| *** dougsz has quit IRC | 10:14 | |
| *** dougsz has joined #openstack-monasca | 10:30 | |
| *** nikparasyr has joined #openstack-monasca | 12:15 | |
| *** vishalmanchanda has quit IRC | 13:29 | |
| *** mbindlish has quit IRC | 13:55 | |
| *** nikparasyr has left #openstack-monasca | 16:11 | |
| *** dougsz has quit IRC | 16:33 | |
| *** ezech has quit IRC | 18:06 | |
| *** tosky has quit IRC | 23:07 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!