Tuesday, 2020-05-12

« Monday, 2020-05-11 Index Wednesday, 2020-05-13 »
*** k_mouza has joined #openstack-monasca01:02
*** k_mouza has quit IRC01:10
*** viks____ has joined #openstack-monasca02:25
*** k_mouza has joined #openstack-monasca03:11
*** k_mouza has quit IRC03:16
*** k_mouza has joined #openstack-monasca06:11
*** k_mouza has quit IRC06:16
openstackgerritMichał Piotrowski proposed openstack/monasca-kibana-plugin master: [WiP] Adding .zuul job for building plugin  https://review.opendev.org/72520006:46
openstackgerritMichał Piotrowski proposed openstack/monasca-kibana-plugin master: [WiP] Adding .zuul job for building plugin  https://review.opendev.org/72520007:23
*** witek_ has joined #openstack-monasca08:03
openstackgerritMartin Chacon Piza proposed openstack/monasca-log-api master: Migrate from ujson to simplejson  https://review.opendev.org/72711909:03
openstackgerritMartin Chacon Piza proposed openstack/monasca-log-api master: Migrate from ujson to simplejson  https://review.opendev.org/72711909:07
openstackgerritMartin Chacon Piza proposed openstack/monasca-log-api master: Migrate from ujson to simplejson  https://review.opendev.org/72465809:10
*** k_mouza has joined #openstack-monasca09:21
*** k_mouza has quit IRC09:42
*** k_mouza has joined #openstack-monasca09:47
*** adriancz has joined #openstack-monasca09:50
openstackgerritMartin Chacon Piza proposed openstack/monasca-log-api master: Migrate from ujson to simplejson  https://review.opendev.org/72711909:54
*** vishalmanchanda has quit IRC12:07
*** vishalmanchanda has joined #openstack-monasca12:41
*** elod_pto is now known as elod12:42
chaconpizaCourtesy Monasca meeting reminder in #openstack-monasca: witek, jayahn,iurygregory,ezpz,igorn,haad,sc,joadavis, akiraY,tobiajo,dougsz,fouadben, amofakhar, haru5ny (haruki),kaiokmo,pandiyan,guilhermesp,chaconpiza,hosanai,Wasaac,brtknr,bandorf,witek_12:51
chaconpiza#startmeeting monasca13:00
openstackMeeting started Tue May 12 13:00:05 2020 UTC and is due to finish in 60 minutes.  The chair is chaconpiza. Information about MeetBot at http://wiki.debian.org/MeetBot.13:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.13:00
*** openstack changes topic to " (Meeting topic: monasca)"13:00
openstackThe meeting name has been set to 'monasca'13:00
chaconpizaHello everyone13:00
piotrowskimhi13:00
witek_hi13:00
adrianczhello13:00
chaconpizaHi Michal, Adrian and Witek13:00
chaconpizaThe agenda as usual https://etherpad.opendev.org/p/monasca-team-meeting-agenda13:00
chaconpizaLet's start13:01
chaconpiza#topic Follow-up on influxdb=5.3.013:01
*** openstack changes topic to "Follow-up on influxdb=5.3.0 (Meeting topic: monasca)"13:01
chaconpizaIt seems that the version 5.3.0 of influxdb-python-client isn't able to handle requests with long output.13:02
chaconpizaA simple call like 'SHOW DIAGNOSTICS' raises an exception.13:02
chaconpizahttps://github.com/influxdata/influxdb-python/issues/82013:02
witek_what about actual measurement queries?13:02
chaconpizaI workarounded the call of SHOW DIAGNOSTICS, then Tempest test fails in 5 test cases.13:03
chaconpizahttps://zuul.opendev.org/t/openstack/build/5f8c3bcaa971462f80c0097267c0dbe9/log/job-output.txt13:04
witek_https://review.opendev.org/72577913:04
chaconpizaI sent a change to openstack/requirements for block that version. https://review.opendev.org/#/c/725824/13:05
witek_but the client isn't throwing any exception for these tests, is it?13:06
chaconpizaI didn't go deep for other calls13:07
witek_I think it's good we blocked this version, as apparently there are some problems with it13:09
witek_but we may need to look closer at these failing tests13:09
chaconpizaand let's keep track on the open bug in https://github.com/influxdata/influxdb-python/issues/82013:09
witek_+113:09
chaconpizaalright, then we notice that:13:10
chaconpiza#topic Define minimum versions for InfluxDB and Influxdb-python-client13:10
*** openstack changes topic to "Define minimum versions for InfluxDB and Influxdb-python-client (Meeting topic: monasca)"13:10
chaconpizaIn monasca_api/common/repositories/influxdb/metrics_repository.py13:11
chaconpizaThe code handles InfluxDB version older than 0.11.0 and newer with different methods.13:11
chaconpizaInfluxDB 0.11.0 is quite old.13:11
chaconpizaAs well, the code don't use the new methods from influxdb-python-client.13:12
chaconpizaFor example, in order to get the version of InfluxDB it queries 'SHOW DIAGNOSTICS' and parses the output.13:12
chaconpizasince version 5.0.0 of influxdb-python-client there is present a method that returns the version.13:13
chaconpizahttps://github.com/influxdata/influxdb-python/blob/master/CHANGELOG.md#v500---2017-11-2013:13
chaconpizaI would like to propose:13:13
chaconpiza1. Set InfluxDB 0.11.0 as the oldest supported.13:14
chaconpiza2. Set influxdb-python-client 5.0.0 as the minimum version13:14
chaconpiza3. refactor the code monasca_api/common/repositories/influxdb/metrics_repository.py13:15
chaconpizawhat do you think piotrowskim, witek_ and adriancz?13:15
witek_fully agree on 113:15
witek_for 2 and 3, I'm not sure if we need to check the version at all, but indeed could be useful in future13:16
piotrowskim1, unless we have time for 313:16
chaconpizaThe refactor is not difficult, is more like cut-here, trimm-there and prunning-over-there13:17
chaconpizalet's keep track on this topic in this change https://review.opendev.org/#/c/725824/ I will set a new patch set13:19
adrianczagree with pireowskim13:19
witek_chaconpiza: will you be working on this?13:19
chaconpizayes13:19
chaconpizalet's move forward to the next topic13:20
witek_I'm OK with the approach13:20
chaconpiza#topic Adding project-template for nodejs1013:20
*** openstack changes topic to "Adding project-template for nodejs10 (Meeting topic: monasca)"13:20
chaconpizapiotrkowskim, could you please give us a brief context?13:21
piotrowskimok, so as Arseni updated monasca-kibana-plugin and now it needs node in version 10, I belive we should check lint etc. for proper version13:21
piotrowskimbefore it was version 413:21
witek_+113:21
piotrowskimright now, tests for monasca-kibana-plugin are switch off, it good to have working tests for project13:22
chaconpizaBesides of the lint, do the unit test of monasca-kibana-plugin need a refactor ?13:23
chaconpizaAre there in the new monasca-kibana-plugin unit test ?13:24
chaconpiza*tests13:24
piotrowskimi belive yes, cause a lot of changed in plugin itself13:24
chaconpizahttps://github.com/openstack/monasca-kibana-plugin/tree/master/server/__tests__13:25
chaconpizaI am not sure if these unittest are compatible with the new monasca-kibana-plugin13:26
chaconpizapiotrowskim could you take a look?13:26
piotrowskimprobably not, also I think is good to have much more information in README, for example how to run tests etc.. I am not familiar with NodeJS at all so it is more time consuming13:27
piotrowskimyeah i will look at it13:27
chaconpizathanks13:28
chaconpiza#topic Migrate from ujson to simplejson13:28
*** openstack changes topic to "Migrate from ujson to simplejson (Meeting topic: monasca)"13:28
chaconpizaI propose two options to handle the migration of ujson in onasca-log-api13:29
witek_I think going with https://review.opendev.org/727119 is safer13:30
chaconpizaIn the first option I set the newest version of monasca-common in lower-constraints, since monasca-common has already the change ujson to simplejson13:30
witek_as we decouple from new version of monasca-common13:30
witek_and we aim to support train in monasca-log-api13:31
chaconpizaAs Witek just mention, the second option doesnt touch monasca-common, but instead copies the code from monasca-common into monasca-log-api13:31
chaconpizaOk, lets go for https://review.opendev.org/72711913:32
witek_adriancz: opinion?13:33
adrianczagree with Witek13:33
chaconpizaadriancz, you would need to rebase on this one  https://review.opendev.org/72711913:33
witek_nice, so we know how to proceed here13:34
chaconpizait is a little bit more work for you, but safer as witek_ mentioned13:34
chaconpiza+113:34
chaconpizaI will then abandon the other change and set a -1 workflow13:34
adrianczmonasca-log-api is deprecated so we should go with safer option13:34
chaconpiza+!13:35
adrianczand we should not  invest to much time13:35
chaconpizaOk, we have an agreement.13:36
chaconpiza#topic AOB13:36
*** openstack changes topic to "AOB (Meeting topic: monasca)"13:36
chaconpizaIs there any other topic you would like to disscus today?13:37
witek_I'd like to start working on Contributor Documentation goal this week13:37
witek_https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html13:37
chaconpizaSpeaking about documentation...13:39
chaconpizahttps://review.opendev.org/#/c/722666/13:39
chaconpizaThe change that modifies the code is merged and cherry-picked until stable/pike13:39
chaconpizait is from Keith13:40
witek_right, I've helped on this a little in the last days13:40
chaconpizaIt looks good to me, lets then merge and cherry-pick until pike as well13:40
witek_my change is documentation only, so I think we don't need to cherry-pick13:41
chaconpizathe documentation isn't handle by releases?13:41
witek_let me look it up13:42
witek_https://docs.openstack.org/project-team-guide/stable-branches.html#review-guidelines13:43
chaconpizaKeithMnemonic are you around?13:43
witek_don't see anything about docs13:43
chaconpizaOk, thanks for the guidelines13:44
witek_we can cherry-pick, doesn't hurt after all13:44
chaconpiza+113:44
chaconpizaAll right. These were all topics in the agenda for today.13:45
witek_nothing else from my side13:46
chaconpizaThanks for coming  and let's gather next week. Goodbye.13:46
witek_thanks chaconpiza13:46
witek_thanks everyone13:46
witek_and bye13:46
piotrowskimbye13:47
adrianczthanks bye13:47
chaconpiza#endmeeting13:47
*** openstack changes topic to "OpenStack Monitoring as a Service | https://wiki.openstack.org/wiki/Monasca"13:47
openstackMeeting ended Tue May 12 13:47:20 2020 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)13:47
openstackMinutes:        http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-05-12-13.00.html13:47
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-05-12-13.00.txt13:47
openstackLog:            http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-05-12-13.00.log.html13:47
witek_piotrowskim: you can add Depends-On tag in the commit message to include new job definitions in your change13:49
witek_like here: https://review.opendev.org/72674713:49
*** openstackstatus has quit IRC13:53
*** openstackstatus has joined #openstack-monasca13:54
*** ChanServ sets mode: +v openstackstatus13:54
witek_piotrowskim: the new template just merged14:05
piotrowskimgreat14:14
openstackgerritMichał Piotrowski proposed openstack/monasca-kibana-plugin master: [WiP] Adding .zuul job for building plugin  https://review.opendev.org/72520014:18
KeithMnemonicchaconpiza i am now14:37
chaconpizaKeithMnemonic hi, as you see in the weekly monasca meeting logs we disscused about merging https://review.opendev.org/#/c/722666/ and cherry pick it backwards.14:43
KeithMnemonicok thanks for the update14:44
*** witek_ has quit IRC16:18
*** vishalmanchanda has quit IRC16:57
*** viks____ has quit IRC17:43
*** vishalmanchanda has joined #openstack-monasca18:04
*** k_mouza has quit IRC19:44
*** k_mouza has joined #openstack-monasca19:51
*** k_mouza has quit IRC20:20
*** k_mouza has joined #openstack-monasca20:35
*** vishalmanchanda has quit IRC20:37
*** k_mouza has quit IRC20:59
*** k_mouza has joined #openstack-monasca21:00
*** k_mouza has quit IRC21:25
*** k_mouza has joined #openstack-monasca21:28
*** k_mouza has quit IRC21:50
*** k_mouza has joined #openstack-monasca21:57
*** k_mouza has quit IRC22:21
*** k_mouza has joined #openstack-monasca22:22
*** k_mouza has quit IRC22:35
*** k_mouza has joined #openstack-monasca22:35
*** k_mouza has quit IRC22:45
*** k_mouza has joined #openstack-monasca22:50
*** k_mouza has quit IRC23:47
*** k_mouza has joined #openstack-monasca23:50
« Monday, 2020-05-11 Index Wednesday, 2020-05-13 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!