*** k_mouza has joined #openstack-monasca | 04:17 | |
*** k_mouza has quit IRC | 04:21 | |
*** vishalmanchanda has joined #openstack-monasca | 05:09 | |
*** mensis has joined #openstack-monasca | 07:06 | |
*** witek_ has joined #openstack-monasca | 08:41 | |
*** k_mouza has joined #openstack-monasca | 09:02 | |
*** vishalmanchanda has quit IRC | 09:09 | |
*** k_mouza has quit IRC | 09:41 | |
openstackgerrit | Witold Bedyk proposed openstack/monasca-persister master: Migrate from ujson to simplejson https://review.opendev.org/719989 | 10:36 |
---|---|---|
*** witek_ is now known as witek | 10:36 | |
witek | chaconpiza: I've updated https://review.opendev.org/719989 | 11:29 |
witek | please review | 11:29 |
chaconpiza | Hi, sure. | 11:29 |
chaconpiza | I see you are using the std mock. | 11:30 |
witek | yes, coverage tests were failing otherwise | 11:30 |
witek | https://zuul.opendev.org/t/openstack/build/e857b2a9218446bcb020bca2aec06778 | 11:30 |
chaconpiza | I can't find what have changed that now it fails | 11:31 |
chaconpiza | This is a previous one that finished successfully https://zuul.opendev.org/t/openstack/build/21348d014fde4f70976fc12ffd39fc64/log/job-output.txt | 11:31 |
chaconpiza | the version of the libraries seems to be the same | 11:32 |
witek | nothing changed in our code, some dependency has changed probably | 11:32 |
chaconpiza | right | 11:33 |
witek | but mock is being removed in other projects as well as part of dropping Python 2 support | 11:33 |
chaconpiza | I have added this topic to today's meeting | 11:36 |
*** k_mouza has joined #openstack-monasca | 11:42 | |
*** k_mouza has quit IRC | 11:46 | |
*** dougsz has joined #openstack-monasca | 12:14 | |
*** k_mouza has joined #openstack-monasca | 12:16 | |
dougsz | Apologies I missed the meeting earlier, looks like this is the final patch for the ujson work? https://review.opendev.org/#/c/720879/ | 12:36 |
openstackgerrit | Merged openstack/python-monascaclient master: Fix mock import statements https://review.opendev.org/717779 | 12:44 |
witek | dougsz: you haven't, we've got summer time | 12:53 |
dougsz | doh, yes of course, need to fix my reminder :) | 12:53 |
witek | Courtesy Monasca meeting reminder in 5 minutes in #openstack-monasca: witek, jayahn,iurygregory,ezpz,igorn,haad,sc,joadavis, akiraY,tobiajo,dougsz,fouadben, amofakhar, haru5ny (haruki),kaiokmo,pandiyan,guilhermesp,chaconpiza,hosanai,Wasaac,brtknr,bandorf | 12:53 |
*** bandorf has joined #openstack-monasca | 12:54 | |
*** bandorf has quit IRC | 13:01 | |
witek | #startmeeting monasca | 13:01 |
openstack | Meeting started Tue Apr 21 13:01:10 2020 UTC and is due to finish in 60 minutes. The chair is witek. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:01 |
*** openstack changes topic to " (Meeting topic: monasca)" | 13:01 | |
openstack | The meeting name has been set to 'monasca' | 13:01 |
witek | hello everyone | 13:01 |
chaconpiza | Hi | 13:01 |
adriancz | HI | 13:01 |
dougsz | hi all | 13:01 |
*** bandorf has joined #openstack-monasca | 13:01 | |
witek | the agenda for today: | 13:01 |
witek | https://etherpad.opendev.org/p/monasca-team-meeting-agenda | 13:01 |
witek | we've got a number of items to discuss, let's start | 13:02 |
witek | #topic virtual PTG | 13:02 |
*** openstack changes topic to "virtual PTG (Meeting topic: monasca)" | 13:02 | |
witek | it has been decided the PTG will be held virtually this time around | 13:02 |
witek | in the week 1-5 June | 13:03 |
chaconpiza | The original schedule before the covid pandemic was 8-11 June | 13:04 |
witek | really, haven't realized that | 13:04 |
chaconpiza | I have vacations exactly 1-5 June, but of course I can join one day | 13:05 |
witek | anyway, all the teams have been asked to decide how many sessions they'd like to hold and when | 13:05 |
witek | that's unfortunate, indeed | 13:05 |
witek | also 1 June is holiday in Germany | 13:05 |
openstackgerrit | Merged openstack/monasca-persister master: Migrate from ujson to simplejson https://review.opendev.org/719989 | 13:06 |
witek | I've looked up the notes from our previous PTGs | 13:07 |
witek | in Denver we had 3 slots 3,5 hours each | 13:07 |
witek | https://wiki.openstack.org/wiki/MonascaTrainPTG | 13:07 |
witek | but the last session has ended very early from what I recall | 13:08 |
witek | then the Ussuri planning meeting was virtual | 13:10 |
witek | https://etherpad.opendev.org/p/monasca-planning-ussuri | 13:10 |
witek | it was one slot of 4 hours | 13:10 |
witek | any preferences for this time? | 13:11 |
witek | the organizers have suggested to not put more than 4 hours on a single day | 13:12 |
chaconpiza | Tuesday in the morning | 13:12 |
dougsz | I'm pretty flexible. Tuesday in the morning would work. | 13:13 |
witek | morning could be difficult for US | 13:14 |
chaconpiza | that's right | 13:14 |
witek | does Tuesday afternoon work for you? | 13:15 |
witek | not many projects have declared their slot yet | 13:15 |
witek | https://ethercalc.openstack.org/126u8ek25noy | 13:16 |
witek | do you know what ECG stands for? | 13:16 |
chaconpiza | Edge Computing Group - OpenStack | 13:16 |
witek | thanks | 13:16 |
chaconpiza | (I just google it : ) ) | 13:17 |
dougsz | :) Afternoon is good too | 13:17 |
witek | the proposed afternoon slot is 13-17 UTC | 13:17 |
chaconpiza | Ok, what about Tuesday 13:00 UTC to keep the habit | 13:18 |
chaconpiza | yes | 13:18 |
adriancz | +1 | 13:18 |
witek | wow, indeed, that's out time! :) | 13:18 |
chaconpiza | :) | 13:18 |
witek | let's start with that then | 13:19 |
bandorf | ok with me | 13:19 |
witek | great, thanks | 13:19 |
witek | I'll also create an etherpad to start collecting topics | 13:19 |
witek | and if we feel like we're running out of time we can decide to extend | 13:20 |
witek | even in the following week | 13:20 |
witek | we haven't book any convention center ;P | 13:20 |
witek | we could also hold a cross-project monitoring session | 13:21 |
witek | perhaps as part of automation SIG? | 13:22 |
witek | I could talk with Rico if you like the idea | 13:22 |
witek | #action witek create etherpad for PTG planning | 13:23 |
chaconpiza | +1 | 13:24 |
witek | #action witek book a slot for Monasca session at PTG | 13:24 |
witek | if there are no other comments, I guess we can move on | 13:25 |
witek | ? | 13:25 |
*** toabctl has quit IRC | 13:25 | |
witek | #topic updating alarm definitions | 13:26 |
*** openstack changes topic to "updating alarm definitions (Meeting topic: monasca)" | 13:26 | |
bandorf | OK | 13:26 |
*** toabctl has joined #openstack-monasca | 13:27 | |
bandorf | Topic 2.1.1: acceptance criteria: This was a difficult one, but I found some schema that is "good enough" for the specific purpose | 13:27 |
bandorf | 2.1.3 Execute reference tests: Basically, validation of acceptance criteria | 13:27 |
bandorf | Worked ok without issues (exception, valid for most of the test cases: time it takes to change to "UNDETERMINED". But this is not considered for now) | 13:28 |
bandorf | 2.1.4: Execute tests with alarm definition update, but no existing alarms: | 13:28 |
bandorf | Again, everything worked ok - as expected. | 13:29 |
bandorf | 2.1.5 Tests with update alarm definitions, alarms exist: | 13:29 |
bandorf | changing time period definitely doesn't work as expected | 13:29 |
bandorf | chaning number of time period might work, I need to execute further tests | 13:30 |
bandorf | As a note: I executed a subset of tests of 2.1.5, stopping/restarting monasca-thresh. | 13:30 |
bandorf | Then, test results are as expected. | 13:31 |
bandorf | No big surprise, but I wanted to be sure. | 13:31 |
witek | you're testing your updated API calls, is that correct? | 13:31 |
bandorf | Yes, correct. I fixed monasca-api, nothing else. And then, I executed the tests. | 13:31 |
witek | thanks, wanted to be sure | 13:31 |
bandorf | 2.2 Current status: | 13:32 |
bandorf | 2.2.1.1 update of FUNCTION: I executed some quick tests some time ago. These worked. But I still have to do "proper testing" | 13:33 |
bandorf | 2.3 Next steps: | 13:33 |
bandorf | 2.3.1 and 2.3.2 are clear. | 13:33 |
bandorf | I'm curious: Assuming that test results would be time cannot be updated, times can be updated. | 13:34 |
bandorf | What would be your opinion? Allow update for times or not? | 13:34 |
witek | if it works as expected, I'd allow it | 13:35 |
bandorf | OK. | 13:35 |
chaconpiza | +1 | 13:35 |
witek | and the rest we could document as the limitation | 13:35 |
witek | I mean, as the workaround we still could recreate the alarm definition, right? | 13:35 |
bandorf | Well, we can restrict in the API as well, like other params. | 13:35 |
witek | +1 | 13:36 |
bandorf | Recreation of alarm definition of course always works. That's the work-around we used for our customer | 13:36 |
bandorf | I will add one more "next step": Elfriede has just extended system test with alarms. | 13:37 |
chaconpiza | yeah! | 13:37 |
witek | nice work, thanks | 13:37 |
bandorf | When I come to the conclusion that some parameters can be updated, we will test this as well with system test | 13:37 |
witek | good to have it tested in a systematic way, should we extend tempest as well? | 13:38 |
bandorf | Yes, of course. But I haven't gone into this topic. | 13:39 |
witek | fair enough, thanks for the update | 13:39 |
bandorf | I'll provide an update next week. System test execution for update AD might not be ready then | 13:39 |
witek | nice | 13:40 |
dougsz | Thanks bandorf. +1 for extending tempest / upstream coverage if possible. | 13:40 |
bandorf | Yes, I have it on my list. But this will take some more time, due to other internal priorities | 13:40 |
dougsz | understood | 13:41 |
witek | OK, should we move on? | 13:41 |
bandorf | I' done :-) | 13:42 |
witek | thanks bandorf | 13:42 |
witek | #topic reviews | 13:42 |
*** openstack changes topic to "reviews (Meeting topic: monasca)" | 13:42 | |
witek | we've struggled with CI in the last time | 13:42 |
chaconpiza | The ripple effect | 13:43 |
witek | but we managed to get ujson->simplejson finally merged | 13:43 |
witek | it should be possible to merge other changes now | 13:44 |
dougsz | thanks for that effort! | 13:44 |
witek | like topic:periodic_notifications | 13:44 |
witek | https://storyboard.openstack.org/#!/story/2006837 | 13:45 |
witek | or topic:update-hacking | 13:45 |
witek | https://review.opendev.org/#/q/projects:openstack/monasca+is:open+topic:update-hacking | 13:45 |
witek | I'm not sure how to proceed for monasca-log-api repository | 13:46 |
witek | https://review.opendev.org/716408 | 13:46 |
witek | we actually have said, we don't want new code merged there, just bug fixes for old API | 13:46 |
dougsz | I see your point | 13:48 |
witek | on the other hand Python 2 is deprecated anyway, so we should probably use Python 3 for old API as well | 13:49 |
dougsz | It's a can of worms | 13:50 |
witek | how do you mean that? | 13:50 |
dougsz | Sorry, just thinking about Kolla not using Python 3 in older releases | 13:51 |
witek | yeah, get it | 13:51 |
witek | hm, I guess we should comment on review and see what AJaeger thinks of it | 13:51 |
dougsz | Agreed, seems likely he will have some wisdom to share | 13:52 |
witek | another set of reviews up there is topic:unittest.mock | 13:53 |
witek | it's replacing third party lib with Python 2 support included | 13:53 |
witek | with standard library's unittest.mock | 13:53 |
chaconpiza | where monasca-log-api is in the list | 13:54 |
witek | https://review.opendev.org/#/q/(projects:openstack/monasca+OR+project:openstack/python-monascaclient)+is:open+topic:unittest.mock | 13:54 |
witek | chaconpiza: https://review.opendev.org/716408 | 13:54 |
witek | and https://review.opendev.org/720943 | 13:55 |
chaconpiza | yes, it was a statement ;) | 13:55 |
witek | oh, I see | 13:55 |
chaconpiza | About the list related to the mock, it is strange that monasca-persister was not there | 13:56 |
chaconpiza | do you know why? | 13:56 |
witek | indeed, don't know | 13:56 |
chaconpiza | and exactly that blocked us | 13:57 |
witek | OK, please spend some time on these reviews, should be easy in most cases | 13:57 |
chaconpiza | +1 | 13:57 |
witek | before we end, last topic | 13:57 |
witek | #topic RC1 | 13:58 |
*** openstack changes topic to "RC1 (Meeting topic: monasca)" | 13:58 | |
witek | this week is deadline for RC1 release | 13:58 |
witek | please ping me if there is something which should be included in Ussuri | 13:59 |
*** dougsz has quit IRC | 13:59 | |
witek | after RC1 the stable branch will be created and only bug fixes are allowed to be cherry-picked | 13:59 |
chaconpiza | ok | 13:59 |
witek | for other changes feature freeze exempts have to be created | 14:00 |
witek | that's a new process for us but we moved to release-with-rc model in this cycle | 14:01 |
witek | all from me | 14:01 |
witek | thanks for joining | 14:01 |
witek | and see you next week | 14:01 |
bandorf | What does that mean for threshold replacement? | 14:01 |
witek | not ready in Ussuri | 14:01 |
bandorf | ok | 14:01 |
bandorf | thanks everybody, bye | 14:02 |
chaconpiza | thanks, bye! | 14:02 |
witek | bye bye | 14:02 |
witek | #endmeeting | 14:02 |
*** openstack changes topic to "OpenStack Monitoring as a Service | https://wiki.openstack.org/wiki/Monasca" | 14:02 | |
openstack | Meeting ended Tue Apr 21 14:02:28 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:02 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-04-21-13.01.html | 14:02 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-04-21-13.01.txt | 14:02 |
openstack | Log: http://eavesdrop.openstack.org/meetings/monasca/2020/monasca.2020-04-21-13.01.log.html | 14:02 |
AJaeger | what was the question on python2 and kolla? Sorry, just coming back online and didn't get the statement | 14:02 |
witek | well, we have a kind of special situation with monasca-log-api repo | 14:03 |
witek | we've moved the code to monasca-api, but want to keep the old repository for maintanance purposes | 14:04 |
witek | cherry-picking to stable branches | 14:04 |
witek | now, we're wondering how to handle the dropping Python 2 support changes in that maintanance repository (monasca-log-api) | 14:05 |
witek | for Kolla context, that would be best when dougsz is online again | 14:08 |
witek | but from what I understood the older versions run with Python 2 only | 14:08 |
AJaeger | witek, monasca-log-api has stable branches | 14:11 |
witek | yes | 14:11 |
AJaeger | a backport should work just fine - that's something every project faces. You might need to re-add six py2 but that should be it. | 14:11 |
AJaeger | witek: the dropping python 2 change is not really changing code, so should not affect it. | 14:12 |
witek | yeah, you're probably right, and python2 jobs have been disabled already on master | 14:15 |
*** dougsz has joined #openstack-monasca | 14:16 | |
witek | dougsz: do you have some more context on Python 2 and Kolla? | 14:17 |
AJaeger | all other repos are gone python3, so monasca is not special here for Kolla | 14:17 |
dougsz | I think Train onwards will support Py3, but no plans to backport before that. | 14:19 |
dougsz | Sorry, I think my IRC client disconnected | 14:19 |
dougsz | AJaeger: This is in reference to how far to back port py3 patches | 14:20 |
AJaeger | dougsz: why do you want to backport py3 patches? | 14:23 |
AJaeger | perhaps we have a different definition on py3 patches - train is supporting both py2 and py3, ussuri is supporting only py3 | 14:23 |
witek | that's indeed strange situation with monasca-log-api, we actually don't need the master branch anymore, but want to have functional CI | 14:27 |
witek | dougsz: different question, do you have any problems in Kolla with building Docker images with newest confluent-kafka? | 14:29 |
witek | here the context: https://github.com/confluentinc/confluent-kafka-python/issues/830 | 14:29 |
*** KeithMnemonic has joined #openstack-monasca | 14:32 | |
dougsz | hmm, haven't hit it yet, but will keep an eye out | 14:32 |
KeithMnemonic | reviews please when you have time https://review.opendev.org/#/c/719982/3 Thank you! | 14:32 |
AJaeger | witek: do it like networking-ovn and retire master | 14:34 |
AJaeger | http://lists.openstack.org/pipermail/openstack-discuss/2020-April/014308.html | 14:34 |
witek | AJaeger: thanks for the reference! | 14:35 |
*** bandorf has left #openstack-monasca | 14:52 | |
*** viks____ has quit IRC | 15:07 | |
joadavis | Regarding removing agent configuration, this may be helpful - https://review.opendev.org/#/c/623611/ | 15:25 |
joadavis | I apologize for not adding it to the agenda for today, it needs review and merge | 15:26 |
witek | thanks, adding to my list | 15:27 |
joadavis | thank you | 15:33 |
openstackgerrit | Witold Bedyk proposed openstack/monasca-agent master: Temporarily disable building Docker images https://review.opendev.org/721671 | 15:35 |
*** adriancz has quit IRC | 16:26 | |
*** adriancz has joined #openstack-monasca | 16:26 | |
*** srwilkers has quit IRC | 16:39 | |
*** piotrowskim has quit IRC | 16:40 | |
*** srwilkers has joined #openstack-monasca | 16:42 | |
*** piotrowskim has joined #openstack-monasca | 16:44 | |
*** srwilkers has quit IRC | 16:48 | |
*** srwilkers has joined #openstack-monasca | 16:51 | |
*** witek has quit IRC | 17:03 | |
*** dougsz has quit IRC | 17:03 | |
*** k_mouza has quit IRC | 17:22 | |
openstackgerrit | Andreas Jaeger proposed openstack/monasca-persister master: Update hacking for Python3 https://review.opendev.org/716521 | 17:27 |
*** gmann is now known as gmann_lunch | 18:31 | |
*** gmann_lunch is now known as gmann | 18:51 | |
*** k_mouza has joined #openstack-monasca | 19:23 | |
*** k_mouza has quit IRC | 19:28 | |
*** dougsz has joined #openstack-monasca | 19:53 | |
*** dougsz has quit IRC | 20:35 | |
*** mensis has quit IRC | 21:12 | |
*** k_mouza has joined #openstack-monasca | 21:25 | |
*** k_mouza has quit IRC | 21:29 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!