| *** mensis has quit IRC | 01:47 | |
| *** k_mouza has joined #openstack-monasca | 02:23 | |
| *** k_mouza has quit IRC | 02:27 | |
| *** KeithMnemonic has quit IRC | 04:30 | |
| *** joadavis has quit IRC | 04:51 | |
| *** vishalmanchanda has joined #openstack-monasca | 05:40 | |
| *** tobberydberg has joined #openstack-monasca | 05:45 | |
| *** witek_ has joined #openstack-monasca | 08:24 | |
| *** k_mouza has joined #openstack-monasca | 09:01 | |
| *** viks____ has joined #openstack-monasca | 10:03 | |
| *** witek_ has quit IRC | 11:30 | |
| *** witek_ has joined #openstack-monasca | 11:32 | |
| openstackgerrit | Witold Bedyk proposed openstack/monasca-notification master: Migrate from ujson to simplejson https://review.opendev.org/720188 | 12:07 |
|---|---|---|
| openstackgerrit | Witold Bedyk proposed openstack/monasca-persister master: Migrate from ujson to simplejson https://review.opendev.org/719989 | 12:08 |
| openstackgerrit | Merged openstack/monasca-statsd master: Cleanup py27 support https://review.opendev.org/717558 | 12:34 |
| *** witek_ is now known as witek | 12:41 | |
| openstackgerrit | Andreas Jaeger proposed openstack/monasca-ui master: Add pytest requirement https://review.opendev.org/720200 | 13:21 |
| AJaeger | monasca team, https://review.opendev.org/720200 is needed to unbreak monasca-ui, could you review, please? | 13:46 |
| *** KeithMnemonic has joined #openstack-monasca | 13:56 | |
| KeithMnemonic | is anyone here working on the broken monasca-agent and monasca-common due to confluent-kafka being upgraded to 1.4? | 13:57 |
| KeithMnemonic | this is what broke everything https://github.com/confluentinc/confluent-kafka-python/issues/830 | 14:16 |
| KeithMnemonic | there is not a .tar for confluent-kafka 1.4, it was there for 1.3 | 14:16 |
| KeithMnemonic | this is disscused in detail in openstack-requirements | 14:32 |
| KeithMnemonic | basically the suggestion is a patch to monasca-common,... to use the whl and not the tar | 14:32 |
| witek | I'm not sure that was possible | 14:37 |
| witek | I'd rather cap u-c for now and ping confluent-kafka guys to publish the source package | 14:37 |
| AJaeger | monasca team, https://review.opendev.org/720200 is needed to unbreak monasca-ui, could you review, please? | 14:38 |
| KeithMnemonic | cap u-c in monasca? | 14:39 |
| witek | in openstack/requirements | 14:39 |
| KeithMnemonic | ok ask in requirement as smcginnis was not loving that idea | 14:42 |
| KeithMnemonic | or propose a patch | 14:42 |
| AJaeger | smcginnes was not aware why the wheels do not work, so if you sent a patch, give the full picture | 14:45 |
| witek | I'll take care of this | 14:48 |
| KeithMnemonic | also what is "interesting" before it fails, the previous packages (kazoo,...) are all pulled as .whl | 14:49 |
| witek | that's probably because they publish py2.py3-none-any.whl | 14:52 |
| openstackgerrit | Adrian Czarnecki proposed openstack/monasca-api master: Fix incorrect old log-api tempest test configuration https://review.opendev.org/718512 | 15:43 |
| witek | chaconpiza: ujson-replacement https://review.opendev.org/719989 passes all the tests | 15:58 |
| witek | we'll have to disable tempest tests job in API or persister to let the changes merge | 15:59 |
| chaconpiza | great, I saw you set simplejson==3.8.1 as the lower version | 16:00 |
| witek | do we have any issues with that? | 16:01 |
| chaconpiza | I don't think so | 16:01 |
| chaconpiza | http://codesearch.openstack.org/?q=simplejson%3D%3D&i=nope&files=&repos= | 16:02 |
| chaconpiza | around the projects I think the version simplejson==3.13.2 is more popular | 16:02 |
| witek | no strong preference there but Ubuntu Xenial ships 3.8.1 | 16:03 |
| chaconpiza | I see | 16:04 |
| chaconpiza | Bionic 3.13.2 | 16:04 |
| witek | right, so anyone running Xenial (which still provides support) won't be able to install | 16:05 |
| chaconpiza | let's go for 3.8.1 then | 16:06 |
| witek | not a big deal probably, but if there are no other reasons, I'd prefer this older one | 16:07 |
| chaconpiza | Finally I understood the issue in monasca-api, previously monasca-api used the json from monasca-common. | 16:07 |
| chaconpiza | then, the test py37 will use the latest monasca-common (with simplejson) and the lower-constraint test will use an old monasca-common (with ujson) | 16:08 |
| witek | outch | 16:09 |
| chaconpiza | But, time ago I sent a change to move the rest part from monasca-common to monasca-api, because of the api merging | 16:09 |
| chaconpiza | by mistake I left in monasca-api some imports pointing to monasca-common | 16:10 |
| chaconpiza | but we have the rest code in both | 16:10 |
| chaconpiza | so, I will fix those imports in monasca-api: | 16:10 |
| chaconpiza | -from monasca_common.rest import utils as rest_utils | 16:10 |
| chaconpiza | +from monasca_api.common.rest import utils as rest_utils | 16:10 |
| chaconpiza | it should work | 16:11 |
| witek | thanks, seems we're close to cleaning it up | 16:11 |
| chaconpiza | yeah | 16:11 |
| chaconpiza | One more think a Zuul test related to docker is failing | 16:12 |
| chaconpiza | but I will first fix the json stuff | 16:13 |
| witek | I've seen that, it's related to https://github.com/confluentinc/confluent-kafka-python/issues/830 | 16:13 |
| chaconpiza | it is what KeithMnemonic commented, right? | 16:13 |
| witek | right | 16:13 |
| chaconpiza | ok | 16:13 |
| witek | let's wait until tomorrow and see if Confluent guys can fix it | 16:14 |
| chaconpiza | ok | 16:14 |
| witek | otherwise I'll ask for feature freeze exemption and lower upper-constraint for confluent-kafka | 16:15 |
| KeithMnemonic | ok thanks guys for looking at this | 16:16 |
| witek | thanks for you bugfixes in libvirt plugin KeithMnemonic | 16:17 |
| chaconpiza | yeah! | 16:17 |
| KeithMnemonic | glad to be able to help | 16:20 |
| *** witek has quit IRC | 16:23 | |
| openstackgerrit | Adrian Czarnecki proposed openstack/monasca-log-api master: Replace deprecated log api test with up-to-date version https://review.opendev.org/720240 | 16:29 |
| *** k_mouza has quit IRC | 16:55 | |
| openstackgerrit | Merged openstack/monasca-ui master: Add pytest requirement https://review.opendev.org/720200 | 16:59 |
| openstackgerrit | Andreas Jaeger proposed openstack/monasca-ui master: Cleanup py27 support https://review.opendev.org/717560 | 17:01 |
| openstackgerrit | Martin Chacon Piza proposed openstack/monasca-api master: Migrate from ujson to simplejson https://review.opendev.org/718014 | 17:16 |
| openstackgerrit | Vishal Manchanda proposed openstack/monasca-ui master: Fix pyScss version in lower-constraints.txt https://review.opendev.org/716714 | 17:48 |
| openstackgerrit | Merged openstack/monasca-ui master: Cleanup py27 support https://review.opendev.org/717560 | 18:06 |
| *** joadavis has joined #openstack-monasca | 19:30 | |
| *** vishalmanchanda has quit IRC | 19:54 | |
| *** k_mouza has joined #openstack-monasca | 20:56 | |
| *** k_mouza has quit IRC | 21:00 | |
| openstackgerrit | Merged openstack/monasca-ceilometer master: Update hacking for Python3 https://review.opendev.org/715603 | 21:48 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!