| *** openstack has joined #openstack-monasca | 16:17 | |
| *** openstackstatus has joined #openstack-monasca | 16:18 | |
| *** raymondr has quit IRC | 16:24 | |
| *** raymondr has joined #openstack-monasca | 16:25 | |
| *** raymondr has quit IRC | 16:30 | |
| *** ddieterly has quit IRC | 16:45 | |
| openstackgerrit | Cindy O'Neill proposed a change to stackforge/monasca-ui: fix max size of autocomplete parameter https://review.openstack.org/112093 | 17:48 |
|---|---|---|
| *** aviau has quit IRC | 17:53 | |
| *** theresa_ has joined #openstack-monasca | 18:05 | |
| *** raymondr_ has joined #openstack-monasca | 18:16 | |
| openstackgerrit | Christian Berendt proposed a change to stackforge/monasca-agent: Enable hacking check H233 https://review.openstack.org/110126 | 18:22 |
| cindyo | tongli: I’m having our UI expert take a look. He is the one that implemented the angular JS. I thought that is a mvc framework that horizon has accepted | 18:50 |
| tongli | @cindyo, horizon is using django framework. | 18:50 |
| tongli | I am pretty sure that the views should not mix with python code. | 18:51 |
| cindyo | yes django with client side angular JS. We are doing both | 18:51 |
| tongli | I mean html code should not mix with python. | 18:51 |
| tongli | from the form.py, I see python and html code all mixed. the output is clearly html code. seems to me that should be in the view. | 18:53 |
| cindyo | this has been done in the custom widgets | 18:53 |
| cindyo | I didnt’ write them initially, so we’ll have rob take a look | 18:53 |
| tongli | ok. please reply to the comment I put up, I probably just miss something here. | 18:54 |
| cindyo | tongli: not sure, it is a valid point | 18:55 |
| tongli | certainly. | 18:55 |
| cindyo | tongli I am just helping on the ui, I am not a UI developer so not sure what is correct when working with django. | 18:56 |
| tongli | @cindyo, understood. | 18:57 |
| cindyo | raymondr_: is it bad practice to mix html in the custom widgets? Should this be changed? Please see https://review.openstack.org/#/c/112093/ | 18:59 |
| openstackgerrit | Christian Berendt proposed a change to stackforge/monasca-agent: Enable hacking check H234 https://review.openstack.org/112113 | 19:00 |
| raymondr_ | the alternative would be to move this html into a Django template. | 19:01 |
| cindyo | raymondr_: would that be the _create.html (etc) templates that we have provided? | 19:02 |
| raymondr_ | Django's widgets generated HTML directly though https://github.com/django/django/blob/master/django/forms/forms.py | 19:06 |
| raymondr_ | cindyo_: Django itself is an MVC toolkit using templates. In this case we would move the HTML to it's own template and then have the widget apply the template. But I would not recommend this in this cas. | 19:09 |
| cindyo | raymondr_: yeah seems to add another layer of complexity | 19:10 |
| raymondr_ | let's move this discussion to review system | 19:11 |
| cindyo | sounds good | 19:11 |
| *** aviau has joined #openstack-monasca | 19:19 | |
| *** theresa_ has quit IRC | 19:25 | |
| *** aviau has quit IRC | 19:25 | |
| *** theresa_ has joined #openstack-monasca | 19:26 | |
| *** jodah has joined #openstack-monasca | 19:37 | |
| *** raymondr_ has quit IRC | 19:58 | |
| *** raymondr_ has joined #openstack-monasca | 20:01 | |
| *** openstackgerrit has quit IRC | 21:16 | |
| *** openstackgerrit has joined #openstack-monasca | 21:17 | |
| *** theresa_ has quit IRC | 21:43 | |
| *** jhalterm- has quit IRC | 22:12 | |
| *** jhalterman has joined #openstack-monasca | 22:14 | |
| *** jodah has quit IRC | 22:36 | |
| *** raymondr_ has quit IRC | 23:05 | |
| *** jodah has joined #openstack-monasca | 23:21 | |
| *** cindyo has quit IRC | 23:23 | |
| *** jodah has quit IRC | 23:31 | |
| *** theresa_ has joined #openstack-monasca | 23:31 | |
| *** th_ has joined #openstack-monasca | 23:34 | |
| *** theresa_ has quit IRC | 23:37 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!