| *** wanghao has joined #openstack-mogan | 00:24 | |
| wanghao | morning! | 00:41 |
|---|---|---|
| zhenguo | morning! | 00:49 |
| litao__ | morning | 00:55 |
| zhenguo | liusheng: hi, our physical env is dead? | 01:09 |
| liusheng | zhenguo: hmm, I don't know what happend | 01:09 |
| zhenguo | liusheng: hah, seems it restarted | 01:10 |
| zhenguo | liusheng: I just found all services are down | 01:10 |
| liusheng | zhenguo: oh, may all the servers have been shutted off last weekend | 01:10 |
| zhenguo | liusheng: seems yes | 01:10 |
| litao__ | I found the my devstack is always bad these days | 01:23 |
| zhenguo | litao__: just update it and restack | 01:23 |
| *** openstackgerrit has joined #openstack-mogan | 01:25 | |
| openstackgerrit | liusheng proposed openstack/mogan master: Tempest: add tempest test for server floatingip association/disassociation https://review.openstack.org/475302 | 01:25 |
| litao__ | zhenguo: ok | 01:25 |
| *** liujiong has joined #openstack-mogan | 01:31 | |
| litao__ | zhenguo: Do you know this issue when mogan create network | 01:34 |
| litao__ | The reason is Remote error: DiscoveryFailure Could not determine a suitable URL for the plugin | 01:34 |
| zhenguo | litao__: no, I didn't see that before | 01:34 |
| litao__ | zhenguo: ok | 01:34 |
| shaohe_feng | zhenguo: morning | 01:37 |
| zhenguo | shaohe_feng: o/ | 01:37 |
| * zhenguo brb | 01:37 | |
| zhenguo | hi all, the weekly meeting will happen soon, please move to #openstack-meeting | 01:59 |
| *** liujiong_lj has joined #openstack-mogan | 02:10 | |
| *** liujiong has quit IRC | 02:12 | |
| *** liujiong_lj is now known as liujiong | 02:27 | |
| wanghao | zhenguo: there is a question left, that how and who will decide our bug priority in bug review hour? | 03:03 |
| zhenguo | wanghao: every one could be | 03:03 |
| zhenguo | wanghao: the list there is not by priority | 03:03 |
| zhenguo | everyone can +1 after a patch | 03:04 |
| zhenguo | which one got more +1 it need to be reviewed more | 03:04 |
| wanghao | zhenguo: okay great | 03:04 |
| wanghao | cool | 03:04 |
| zhenguo | hah, we wil leave a few minutes for everyone to +1 at the beginning of the time | 03:05 |
| * zhenguo brb | 03:06 | |
| wanghao | liusheng: I didn't find that openstack didn't allow to use six. So I think it's fine? | 03:13 |
| wanghao | liusheng: maybe just some functions. | 03:13 |
| liusheng | wanghao: yes, it is ok | 03:14 |
| wanghao | liusheng: I found some patch that replace unicode with six.text_type for py3. haha | 03:14 |
| wanghao | liusheng: sure | 03:14 |
| liusheng | zhenguo: yes, and please confirm my first comment | 03:15 |
| liusheng | wanghao: sorry ,wrong person, ^^ | 03:16 |
| wanghao | liusheng: haha | 03:17 |
| wanghao | sure | 03:17 |
| openstackgerrit | wanghao proposed openstack/mogan master: Refactor exception raise by using mogan exception https://review.openstack.org/475971 | 03:21 |
| wanghao | guys, I'm sorry that I have a internal meeting 16:00-17:30, so I will begin my review hour early~ | 03:24 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Adds `resources` field for flavors. https://review.openstack.org/475626 | 03:28 |
| zhenguo | wanghao: hah, maybe we can change the review hour everyday to fit for most of us' time | 03:29 |
| zhenguo | hi guys, for the new flavor spec, do you think we need to add a resource_traits filed as well to pass traits information | 03:31 |
| zhenguo | maybe later when we really need it | 03:33 |
| zhenguo | liusheng: hi, for the POC, how about sending the patches out, then we can do it together | 03:36 |
| liusheng | zhenguo: ok, sure | 03:36 |
| zhenguo | liusheng: thanks | 03:36 |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: import placement service https://review.openstack.org/476325 | 03:37 |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: import placement service https://review.openstack.org/476325 | 03:51 |
| zhenguo | FYI https://bugs.launchpad.net/mogan/+bug/1699662 | 04:44 |
| openstack | Launchpad bug 1699662 in Mogan "mogan.tests.unit.db.test_compute_nodes.DbComputeNodeTestCase.test_compute_node_get_all accasionally faield" [Medium,New] | 04:44 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 05:08 |
| zhenguo | liusheng: gate is broken? | 05:10 |
| liusheng | zhenguo: seems yes | 06:03 |
| zhenguo | liusheng: but seems not related to us | 06:06 |
| liusheng | zhenguo: yes | 06:08 |
| *** liusheng has quit IRC | 07:36 | |
| *** liusheng has joined #openstack-mogan | 07:37 | |
| zhenguo | liusheng, shaohe_feng, wanghao, litao__: gates are broken, cancel today's review hour? | 07:44 |
| liusheng | zhenguo: we cannot merge any patch :( | 07:45 |
| zhenguo | but specs are fine | 07:45 |
| liusheng | zhenguo: hah, yes | 07:45 |
| zhenguo | how about specs review hour | 07:45 |
| litao__ | zhenguo: fine | 07:46 |
| zhenguo | ok | 07:46 |
| zhenguo | liusheng: yes, move az to aggregate seems a good idea | 07:52 |
| zhenguo | liusheng: we will not get az information from ironic node's properties/placement resource providors | 07:53 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 07:58 |
| *** wanghao_ has joined #openstack-mogan | 08:00 | |
| zhenguo | liusheng: but placement aggregate doesn't have a notion like metadata | 08:00 |
| zhenguo | liusheng: it only contains a uuid | 08:00 |
| *** wanghao has quit IRC | 08:03 | |
| liusheng | zhenguo: I think the placement started not a long time, may they will consider this if they want to meat full Nova's requirement | 08:08 |
| zhenguo | liusheng: so if we move to placement how to handle the aggregate requirement? | 08:08 |
| liusheng | zhenguo: you mean aggragate or az ? | 08:12 |
| zhenguo | liusheng: aggregate | 08:12 |
| zhenguo | liusheng: the placement_aggregate is very simple | 08:12 |
| zhenguo | liusheng: but we need a aggregate metadata which include key value pairs to match with flavors' | 08:12 |
| zhenguo | liusheng: I will be away for a few mins, ttyl? | 08:13 |
| zhenguo | liusheng: you can start to review if I don't come back | 08:13 |
| * zhenguo brb | 08:13 | |
| liusheng | zhenguo: ok, sure | 08:13 |
| zhenguo | liusheng: I'm back | 08:39 |
| liusheng | zhenguo: welcome :), I have left 3 comments of your spec | 08:40 |
| zhenguo | liusheng: hah, thanks | 08:41 |
| zhenguo | liusheng: wrt flavor description, maybe we can just get rid of the max lenght check on JSON chema? | 08:51 |
| liusheng | zhenguo: yes, I think so | 08:53 |
| shaohe_feng | what's wrong with gate? | 08:53 |
| zhenguo | shaohe_feng: not sure, but seems not related to us | 08:54 |
| liusheng | zhenguo: wdyt about another comment of description ? | 08:54 |
| zhenguo | liusheng: you mean allow users to update it? | 08:54 |
| liusheng | zhenguo: not sure, but is it possible operator change the hardware of a specific resource class ? | 08:55 |
| liusheng | zhenguo: if so ,the description including hardware profile may cannot exactly reflect the hardware info | 08:55 |
| zhenguo | liusheng: you mean after the node deployed? | 08:56 |
| liusheng | zhenguo: no, I mean we have a set of nodes with specific hardware standard may have resource class of "gold" | 08:57 |
| zhenguo | liusheng: in a production env, I don't think it make sense to update the hardware spec after it sold to users | 08:57 |
| liusheng | zhenguo: and we may change the "gold" meaning | 08:57 |
| zhenguo | liusheng: if you want to change the gold meaning, better to add a new flavor | 08:58 |
| zhenguo | liusheng: as if you change the meaning, users who use the flavor deployed servers before may confuse | 08:58 |
| liusheng | zhenguo: yes, that is a way | 08:58 |
| zhenguo | liusheng: as they use the old meaning to require a server, hah | 08:58 |
| liusheng | zhenguo: I am just consider the possibilities users will ask why the hardware info is not equal what I saw in the flavor's profile. lol | 08:59 |
| zhenguo | liusheng: that's need a new flavor | 09:00 |
| liusheng | zhenguo: hah | 09:00 |
| liusheng | zhenguo: ok, lets operators to ensure that | 09:01 |
| zhenguo | liusheng: yes, hah | 09:01 |
| zhenguo | liusheng: do you think we still need minLength for description field | 09:05 |
| liusheng | zhenguo: may don't need | 09:06 |
| zhenguo | liusheng: so when creating flavor they can specify a '' for description? | 09:07 |
| liusheng | zhenguo: your required properties only include name and resources. hah | 09:08 |
| zhenguo | liusheng: hah | 09:09 |
| zhenguo | liusheng: I prefer to add description there as well, wdyt? | 09:09 |
| liusheng | zhenguo: agree, let force the operater to add flavor with hardware profile. hah | 09:12 |
| zhenguo | liusheng: ok, will update the spec | 09:12 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 09:13 |
| zhenguo | liusheng: ok, let's talk about the placement? | 09:14 |
| liusheng | zhenguo: ok | 09:15 |
| zhenguo | liusheng: still not very clear about the aggregates | 09:16 |
| zhenguo | in nova host aggregates, we can set any metadata there witch can match with flavor extra spec | 09:17 |
| liusheng | zhenguo: may need more knowledge about placement's implementation :) | 09:17 |
| zhenguo | yes | 09:18 |
| liusheng | yes | 09:18 |
| zhenguo | az also in aggregates metadata | 09:18 |
| liusheng | zhenguo: yes, seems az contains host aggregate | 09:19 |
| zhenguo | yes, so if we don't set any az to aggregate, we just got a default az | 09:21 |
| zhenguo | we don't need to set az for every node | 09:21 |
| zhenguo | you need to create a aggregate with a group of node and set the aggregate metadata with az=xxx to indicate these nodes are in that az | 09:21 |
| liusheng | zhenguo: yes, hope placement can provide the capability | 09:24 |
| liusheng | zhenguo: maybe we can just wait, may placement will add that support, since Nova may also have the requirement ?> | 09:25 |
| zhenguo | liusheng: nova has a host notion, so they don't need placement | 09:26 |
| zhenguo | host and node a different things in nova | 09:26 |
| liusheng | zhenguo: yes | 09:27 |
| liusheng | zhenguo: oh, maybe | 09:27 |
| liusheng | zhenguo: how about we try to add like traits for aggregate of placemnt ? | 09:27 |
| zhenguo | liusheng: placement only allow set traits to resource providers | 09:29 |
| zhenguo | liusheng: so maybe we have a aggregate of nodes, then set taits like metadata to all resource provider in it. hah | 09:30 |
| zhenguo | liusheng: seems it can work | 09:30 |
| liusheng | zhenguo: I mean we can try to implement that in the future | 09:30 |
| liusheng | zhenguo: hah | 09:31 |
| zhenguo | liusheng: yes, maybe | 09:31 |
| zhenguo | liusheng: before Pike release we should get rid of things that we are not sure and APIs that node defined | 09:31 |
| liusheng | zhenguo: yes, sure | 09:32 |
| zhenguo | liusheng: we can enrich features in next release | 09:32 |
| zhenguo | liusheng: we just need a set of APIs/features that are stable and we are sure it's well defined with Pike release, | 09:33 |
| *** wanghao_ has quit IRC | 09:34 | |
| liusheng | zhenguo: hah, that is ture | 09:34 |
| zhenguo | liusheng: so, please feel free to get rid of things you don't like | 09:34 |
| liusheng | zhenguo: lol, yes | 09:34 |
| liusheng | zhenguo: will look the new spec | 09:35 |
| zhenguo | liusheng: thanks | 09:35 |
| zhenguo | shaohe_feng: please also help to review the specs if you got time | 09:35 |
| zhenguo | shaohe_feng: new flavors, palcement, and adopting servers | 09:36 |
| *** wanghao has joined #openstack-mogan | 09:36 | |
| *** wanghao has quit IRC | 09:37 | |
| *** liujiong has quit IRC | 09:59 | |
| * zhenguo away | 11:13 | |
| *** litao__ has quit IRC | 11:54 | |
| zhenguo | liusheng: how about getting rid of the flavor extra specs and add a resource_traits field instead | 12:04 |
| liusheng | zhenguo: what's the relationship between it with traits in placement ? | 12:05 |
| zhenguo | liusheng: reference to that traits | 12:05 |
| liusheng | zhenguo: so how to use it? pass it as the query filters to placement api ? | 12:06 |
| zhenguo | liusheng: yes | 12:06 |
| zhenguo | liusheng: extra_specs also aims to do that | 12:07 |
| zhenguo | liusheng: resources: {CUSTOM_BAREMETAL_GOLD: 1}, resource_traits: {CUSTOM_BAREMETAL_GOLD: rack1} | 12:08 |
| zhenguo | liusheng: one is for quantity and the other is for qulitity | 12:08 |
| liusheng | zhenguo: oh, I thought you want to user extra_spec to filter the specific requirement of nodes, e.g. node with particular net card | 12:10 |
| zhenguo | liusheng: just wan to change to notion from extra_specs to resource_traits | 12:11 |
| liusheng | zhenguo: and also may we will put the az requirement in extra_spec/ resource_traits ? | 12:11 |
| liusheng | zhenguo: yes, it is more explict | 12:11 |
| zhenguo | liusheng:yes | 12:12 |
| liusheng | zhenguo: i like this :D | 12:12 |
| zhenguo | liusheng; like resource_traits: {CUSTOM_BAREMETAL_GOLD: az1} | 12:12 |
| zhenguo | liusheng: everything is ok | 12:12 |
| liusheng | zhenguo: hah | 12:12 |
| zhenguo | liusheng: as operators using placement notion to manage resources with traits and resource classes | 12:13 |
| zhenguo | liusheng: they also define flavors, so use traits is more consistent | 12:13 |
| liusheng | zhenguo: yes, make sense to me | 12:13 |
| zhenguo | liusheng: hah, so I will update the spec | 12:13 |
| liusheng | zhenguo: thanks for your efforts! | 12:14 |
| liusheng | zhenguo: our gate still broken ? | 12:14 |
| zhenguo | liusheng: not sure, but seems ironic gate is still broken, you can recheck one to see | 12:15 |
| liusheng | zhenguo: let me recheck | 12:15 |
| zhenguo | liusheng: okay | 12:15 |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: import placement service https://review.openstack.org/476325 | 12:28 |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: import placement service https://review.openstack.org/476325 | 12:40 |
| openstackgerrit | liusheng proposed openstack/mogan master: WIP: import placement service https://review.openstack.org/476325 | 12:42 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 12:45 |
| *** liujiong has joined #openstack-mogan | 13:31 | |
| *** liujiong has quit IRC | 14:18 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!