| *** wanghao has joined #openstack-mogan | 00:31 | |
| zhenguo | morning mogan! | 00:58 |
|---|---|---|
| *** litao__ has joined #openstack-mogan | 01:19 | |
| liusheng | zhenguo: morning, do we have meeting later ? | 01:49 |
| zhenguo | liusheng: sure | 01:50 |
| liusheng | zhenguo: got it | 01:51 |
| zhenguo | hi all, please move to #openstack-meeting, the weekly meeting will happen soon! | 02:00 |
| shaohe_feng | zhenguo: morning | 02:33 |
| *** liusheng has quit IRC | 02:46 | |
| *** liusheng has joined #openstack-mogan | 02:46 | |
| * zhenguo brb | 02:59 | |
| wanghao | zhenguo: need to leave for a while, so you can send me the ironic's report, I will check it out. | 03:00 |
| zhenguo | wanghao: ok | 03:00 |
| wanghao | zhenguo: I will write a draft and we can discuss it afternoon | 03:01 |
| wanghao | zhenguo: thanks | 03:01 |
| * wanghao leave for a while | 03:02 | |
| *** luyao has quit IRC | 03:12 | |
| *** luyao has joined #openstack-mogan | 03:13 | |
| openstackgerrit | liusheng proposed openstack/mogan master: DOCS: add documentation about testing https://review.openstack.org/472028 | 03:20 |
| zhenguo | liusheng: just talked with liudong, he will prepare the server group bp | 03:34 |
| liusheng | zhenguo: cool, thanks liudong | 03:36 |
| liusheng | zhenguo: so maybe just leave the scheduler_hints patch to wait liudong's patch, in case I need to do some adjustments | 03:37 |
| zhenguo | liusheng: ok, you can talk with him | 03:38 |
| liusheng | zhenguo:ok | 03:39 |
| zhenguo | hi all, there are still some bugs open, please feel free to take | 03:42 |
| zhenguo | https://bugs.launchpad.net/mogan/+bugs?field.searchtext=&orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&assignee_option=none&field.assignee=&field.bug_reporter=&field.bug_commenter=&field.subscriber=&field.structural_subscriber=&field.tag=&field.tags_combinator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch | 03:42 |
| zhenguo | .used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on&search=Search | 03:42 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: Node aggregates https://review.openstack.org/470927 | 06:49 |
| zhenguo | liusheng: for flavor extra specs, I think we don't need a separated endpoint, how about just patch the flavor? | 07:06 |
| zhenguo | it's really weird of the flavor API, we use put to update the flavor, and patch to update the extra specs but it's not a real patch | 07:07 |
| liusheng | zhenguo: yes, I also think so | 07:12 |
| liusheng | zhenguo: looks weird | 07:12 |
| zhenguo | liusheng: I find this https://review.openstack.org/#/c/463308/ | 07:13 |
| zhenguo | liusheng: maybe we can just remove the extraspec and access endpoints | 07:13 |
| zhenguo | liusheng: and maybe we can control only return flavor access info to admin? | 07:15 |
| liusheng | zhenguo: don't we need a deprecation cycle. lol | 07:16 |
| liusheng | zhenguo: just kidding | 07:16 |
| zhenguo | liusheng: hah | 07:16 |
| zhenguo | liusheng: all flavor implementation seems a bit a weird including the object function | 07:16 |
| liusheng | zhenguo: I am ok to remove thoese | 07:16 |
| zhenguo | liusheng: need a refactor to all flavor things | 07:17 |
| * zhenguo brb | 07:20 | |
| liusheng | zhenguo: yes, maybe we can keep the flavor api more simple | 07:20 |
| liusheng | zhenguo: I can abandon the patch if you want to start to refactor the flavor implementation | 07:21 |
| zhenguo | liusheng: I can just get rid of the extra spec endpoint as first patch | 07:32 |
| liusheng | zhenguo: ok | 07:32 |
| zhenguo | liusheng: I remember we discussed the node_uuid with server return before | 07:33 |
| zhenguo | liusheng: how about just return it to admin? | 07:33 |
| liusheng | zhenguo: control that by policy check ? | 07:33 |
| zhenguo | liusheng: does nova do that based on policy? | 07:34 |
| zhenguo | liusheng: or by the role | 07:34 |
| zhenguo | liusheng: we don't need to return a hash value to normal users like nova, just to admin is enough | 07:34 |
| liusheng | zhenguo: ok, I am not sure if there is use cacse that normal users need that info | 07:35 |
| liusheng | zhenguo: I am ok | 07:35 |
| zhenguo | liusheng: ok | 07:36 |
| zhenguo | liusheng: another strange thing, why we use rpc_server everywhere in server api, why call it rpc_server instead of db_server? | 07:56 |
| liusheng | zhenguo: where we use rpc_server if we can only need to acess db ? | 07:58 |
| zhenguo | liusheng: you can search the server api file, at the beginning of every method, we get a rpc_server | 07:59 |
| zhenguo | liusheng: but in fact, it only call server.get, not sure why named it as rpc_server, not related to rpc | 07:59 |
| liusheng | zhenguo: maybe that is just a wrong name of a server | 08:01 |
| liusheng | zhenguo: rpc_server = self._resource or self._get_resource(server_uuid) | 08:01 |
| zhenguo | liusheng: hah | 08:02 |
| zhenguo | liusheng: maybe db_server is better | 08:02 |
| liusheng | zhenguo: it is not the rpc server | 08:02 |
| liusheng | zhenguo: yes | 08:02 |
| zhenguo | liusheng: mind to help clean it up? | 08:02 |
| liusheng | zhenguo: my pleasure :D | 08:02 |
| zhenguo | liusheng: thanks, hah | 08:02 |
| openstackgerrit | liusheng proposed openstack/mogan master: Rename the rpc_server variable with db_server https://review.openstack.org/472133 | 08:08 |
| zhenguo | liusheng: cool | 08:08 |
| liusheng | zhenguo: lol | 08:09 |
| zhenguo | liushegn: aha, also find in flavor api file, also contain such rpc_xxx, maybe also in other apis | 08:10 |
| *** litao__ has quit IRC | 08:13 | |
| *** litao__ has joined #openstack-mogan | 08:23 | |
| zhenguo | liusheng, shaohe_feng: please have a look at this https://review.openstack.org/#/c/471637/ when you got time, in fact I alrady updated the document http://111.20.68.219:7950/docs/ :D | 08:27 |
| liusheng | zhenguo: cool!, looks good | 08:31 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Use PATCH method for flavor update https://review.openstack.org/472157 | 08:49 |
| zhenguo | liusheng: FYI, during the period you were on vacation, I built a ubuntu whole disk image in our lab, you can try to provison a server through mogan with that image. | 08:51 |
| liusheng | zhenguo: cool, let me try | 08:51 |
| zhenguo | liusheng: hah | 08:51 |
| * zhenguo brb | 08:52 | |
| shaohe_feng | zhenguo: OK. | 08:56 |
| zhenguo | liusheng, shaohe_feng: please help to do more reviews on specs, in order to not block the following coding work, thanks | 09:20 |
| liusheng | zhenguo: ok | 09:21 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Use PATCH method for flavor update https://review.openstack.org/472157 | 09:23 |
| openstackgerrit | liusheng proposed openstack/mogan master: Rename the rpc_server variable with db_server https://review.openstack.org/472133 | 09:25 |
| *** wanghao has quit IRC | 10:04 | |
| *** litao__ has quit IRC | 11:53 | |
| *** harlowja has quit IRC | 20:08 | |
| *** harlowja has joined #openstack-mogan | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!