| *** wanghao has joined #openstack-mogan | 00:32 | |
| *** wanghao has quit IRC | 00:49 | |
| *** wanghao has joined #openstack-mogan | 00:49 | |
| zhenguo | morning mogan! | 00:57 |
|---|---|---|
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add requested neworks check with the specified flavor https://review.openstack.org/466694 | 05:36 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add requested neworks check with the specified flavor https://review.openstack.org/466694 | 06:21 |
| *** shaohe_feng has quit IRC | 07:17 | |
| *** shaohe_feng has joined #openstack-mogan | 07:40 | |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** wanghao_ has joined #openstack-mogan | 07:51 | |
| *** wanghao has quit IRC | 07:55 | |
| *** wanghao_ has quit IRC | 07:57 | |
| *** wanghao has joined #openstack-mogan | 07:58 | |
| *** openstackgerrit has joined #openstack-mogan | 07:59 | |
| openstackgerrit | Xinran WANG proposed openstack/mogan master: Detach interface for server https://review.openstack.org/461767 | 07:59 |
| *** wanghao has quit IRC | 08:09 | |
| *** wanghao has joined #openstack-mogan | 08:10 | |
| *** wanghao has quit IRC | 08:12 | |
| *** wanghao has joined #openstack-mogan | 08:12 | |
| *** shaohe_feng has quit IRC | 08:23 | |
| *** shaohe_feng has joined #openstack-mogan | 08:32 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add requested neworks check with the specified flavor https://review.openstack.org/466694 | 08:59 |
| zhenguo | shaohe_feng: hah, really thanks for your reviews. | 09:07 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add requested neworks check with the specified flavor https://review.openstack.org/466694 | 09:20 |
| *** wanghao has quit IRC | 09:35 | |
| zhenguo | luyao: I just tested attach interface, seems it's not trigger the real port configuration of the target switch port | 09:44 |
| shaohe_feng | zhenguo: we should do more reviews: :( | 10:01 |
| luyao | zhenguo, can you give some details? | 10:24 |
| luyao | zhenguo, did you test it on the real hardware env? | 10:30 |
| zhenguo | shaohe_feng: sure | 10:58 |
| zhenguo | luyao: yes, I test it on my physical env, the switch port vlan doens't changed. | 10:59 |
| luyao | zhenguo, i don't have physical env,how can i fix this bug | 11:01 |
| zhenguo | luyao: did you test it in vm before? after attach interface, can it get an ip? | 11:02 |
| zhenguo | luyao: you can change to use another network when doing attach action to see whether the ip changed or use dhclient to force get a new ip | 11:03 |
| luyao | zhenguo, yes, i show you on bug smash | 11:03 |
| zhenguo | luyao: you can show the two neutron ports to see the difference | 11:06 |
| luyao | zhenguo, ok | 11:07 |
| zhenguo | luyao: this may help https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/network/common.py#L183-L210 | 11:15 |
| zhenguo | luyao: maybe it's better to call ironic vif_attach instead of doing it ourselves | 11:19 |
| zhenguo | Xinran: also the detach interface | 11:20 |
| luyao | zhenguo, ok, thank you for your comments. I will try again : ) | 11:20 |
| zhenguo | luayo: thanks, I just checked the ironic attach/detach vif api will do neutron port update, we can leverage it | 11:21 |
| Xinran | zhenguo, any problem with detach? | 11:22 |
| zhenguo | Xinran: not sure if our detach will trigger the switch port changing it's configuration | 11:23 |
| zhenguo | Xinran: maybe also switch to call ironic detach_vif API | 11:24 |
| Xinran | detach switch port will call unplug_vifs in ironic driver and in unplug_vifs , it will call port.updata | 11:27 |
| zhenguo | Xinran: currently we call ironic unplug vif for detach interface? | 11:28 |
| Xinran | zhenguo, for detach ironic port but there are also neutron port to detach | 11:29 |
| zhenguo | Xinran: ironic will handle that, we don't manually call ironic port update, just use detach vif instead | 11:30 |
| Xinran | zhenguo, In engine.manager, we call unplug_vifs to detach ironic we dont call port update | 11:33 |
| Xinran | zhenguo, port update is in unplug_vif | 11:33 |
| zhenguo | Xinran: aha, yes, but I dont' mean the driver.unplug_vif, you can refer to ironic code to see the vif_attach API | 11:36 |
| zhenguo | Xinran: I propose to add a new driver interface vif_attach and vif_detach | 11:36 |
| Xinran | zhenguo, do you mean : in the vif_detach to be added, we can call ironic vif_detach to detach a neutron port from node | 11:45 |
| zhenguo | Xinran: the ironic vif_detach will update it's own port and unbind the neutron port, we also need to remove the neutron port afterwards | 11:46 |
| Xinran | zhenguo, yes agrees with you | 11:47 |
| zhenguo | Xinran: we need the unbin neutron port action to make the port cant access to the network | 11:47 |
| zhenguo | s/unbin/unbind | 11:47 |
| zhenguo | shaohe_feng, luyao, Xinran: why are you intel guys still in office now? | 11:48 |
| Xinran | zhenguo, so first unbind neutron port then remove neutron port? | 11:48 |
| zhenguo | Xinran: I think so, only remove neutron port can't trigger switch configuration changed | 11:49 |
| Xinran | zhenguo, ok i know | 11:50 |
| zhenguo | Xinran: call this https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1287 | 11:50 |
| Xinran | zhenguo, question: why dont use unplug_vif , it doesnt change the configuration ? | 11:51 |
| *** litao__ has quit IRC | 11:55 | |
| zhenguo | Xinran: yes we inplemented unplug_vif ourselves, it only call ironic port update :( | 11:56 |
| Xinran | zhenguo, haha ok i know | 11:56 |
| zhenguo | Xinran: ironic detach_vif includes port update and neutron port unbind | 11:56 |
| zhenguo | Xinran: ^^ | 11:56 |
| shaohe_feng | zhenguo: I go to office very late these days. I need to care my baby. I love my baby. Baby first. | 11:57 |
| zhenguo | Xinran: you can change our unplug_vif to this https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1274-L1291 | 11:58 |
| shaohe_feng | zhenguo: I need to make up my work. | 11:58 |
| zhenguo | shaohe_feng: hah, fair enough | 11:58 |
| shaohe_feng | zhenguo: I'm going through the multi server patch. | 11:59 |
| zhenguo | shaohe_feng: do you find something wrong expect the gate issue? | 12:00 |
| *** luyao has left #openstack-mogan | 12:00 | |
| Xinran | zhenguo, ok will fix it soon | 12:00 |
| Xinran | zhenguo, thanks for the infos | 12:00 |
| shaohe_feng | zhenguo: not finished. try to find. | 12:00 |
| zhenguo | Xiran: thanks, I would encourage you go home early :D | 12:01 |
| zhenguo | shaohe_feng: hah, thanks for go back to review patches :) | 12:01 |
| zhenguo | s/go/come | 12:02 |
| Xinran | zhenguo, hah I accept you encouragement ... | 12:02 |
| zhenguo | Xinran: lol | 12:02 |
| zhenguo | shaohe_feng: I also have to go home, see you tomorrow | 12:03 |
| *** luyao has joined #openstack-mogan | 12:03 | |
| shaohe_feng | zhenguo: But I have less time to take care my baby. | 12:03 |
| shaohe_feng | zhenguo: see you tomorrow. | 12:04 |
| zhenguo | shaohe_feng: hah | 12:04 |
| zhenguo | luyao, Xinran: see you | 12:04 |
| shaohe_feng | zhenguo: let do our best to push mogan in big tent | 12:04 |
| zhenguo | shaohe_feng: thanks, hah | 12:04 |
| zhenguo | I have to go | 12:05 |
| luyao | see you. :D | 12:05 |
| * zhenguo disappeared | 12:05 | |
| *** dims has quit IRC | 13:07 | |
| *** dims has joined #openstack-mogan | 14:04 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!