| *** ricolin has joined #openstack-mistral | 02:53 | |
| *** apetrich has quit IRC | 03:08 | |
| *** ricolin has quit IRC | 03:35 | |
| *** ricolin has joined #openstack-mistral | 03:41 | |
| *** ricolin has quit IRC | 03:57 | |
| *** ricolin has joined #openstack-mistral | 03:57 | |
| *** ricolin has quit IRC | 04:13 | |
| *** ricolin has joined #openstack-mistral | 05:23 | |
| *** ricolin has quit IRC | 05:50 | |
| *** pgaxatte has joined #openstack-mistral | 07:11 | |
| *** ricolin has joined #openstack-mistral | 07:17 | |
| openstackgerrit | Merged openstack/mistral-lib master: Switch to Ussuri jobs https://review.opendev.org/689944 | 07:20 |
|---|---|---|
| openstackgerrit | Merged openstack/mistral-extra master: Switch to Ussuri jobs https://review.opendev.org/689941 | 07:24 |
| openstackgerrit | Merged openstack/mistral master: Add release note for fix error of cron trigger run https://review.opendev.org/688965 | 07:25 |
| openstackgerrit | Merged openstack/mistral-extra master: tox: Keeping going with docs https://review.opendev.org/690969 | 07:25 |
| openstackgerrit | Merged openstack/mistral-lib master: tox: Keeping going with docs https://review.opendev.org/690968 | 07:27 |
| openstackgerrit | Merged openstack/mistral-dashboard master: Switch to Ussuri jobs https://review.opendev.org/689937 | 07:33 |
| *** rakhmerov has joined #openstack-mistral | 07:37 | |
| *** ricolin_ has joined #openstack-mistral | 07:45 | |
| *** ricolin has quit IRC | 07:47 | |
| *** eyalb1 has joined #openstack-mistral | 08:04 | |
| *** ricolin_ has quit IRC | 08:04 | |
| *** ricolin_ has joined #openstack-mistral | 08:04 | |
| *** ricolin_ has quit IRC | 08:37 | |
| *** apetrich has joined #openstack-mistral | 08:41 | |
| openstackgerrit | Merged openstack/mistral master: Switch to Ussuri jobs https://review.opendev.org/689951 | 09:11 |
| openstackgerrit | Merged openstack/mistral-tempest-plugin master: tox: Keeping going with docs https://review.opendev.org/690967 | 09:11 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib master: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692967 | 10:04 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib stable/train: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692970 | 10:05 |
| rakhmerov | d0ugal: hi :) | 10:13 |
| rakhmerov | I'm looking at https://review.opendev.org/#/c/692967 | 10:13 |
| d0ugal | rakhmerov: Hey, thanks | 10:13 |
| rakhmerov | can you please explain briefly how this masking function works? | 10:13 |
| rakhmerov | how doesn't know what to mask? | 10:13 |
| eyalb1 | it has _SANITIZE_KEYS | 10:14 |
| d0ugal | rakhmerov: basically it uses a bunch of keys and patterns | 10:14 |
| d0ugal | https://github.com/openstack/oslo.utils/blob/master/oslo_utils/strutils.py#L58 | 10:14 |
| rakhmerov | aah, ok | 10:14 |
| rakhmerov | just hardcoded stuff | 10:14 |
| rakhmerov | ok | 10:14 |
| d0ugal | It is used on all logging already, but it isn't correctly detecting the structure that mistral is outputting. So masking the dict sorts it out | 10:15 |
| d0ugal | Yeah, it is pretty simple thankfully | 10:15 |
| rakhmerov | ok | 10:15 |
| rakhmerov | ok with me | 10:15 |
| d0ugal | I need to backport it to Rocky | 10:15 |
| d0ugal | Thanks! | 10:15 |
| rakhmerov | take a look, it failed on pep8 | 10:15 |
| d0ugal | You'll see it depends on a oslo-utils patch | 10:15 |
| d0ugal | oh really, crap I forgot to test that | 10:15 |
| d0ugal | thanks | 10:15 |
| rakhmerov | ok :) | 10:15 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib master: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692967 | 10:22 |
| openstackgerrit | Merged openstack/python-mistralclient master: Switch to Ussuri jobs https://review.opendev.org/689964 | 10:22 |
| openstackgerrit | Merged openstack/python-mistralclient master: tox: Keeping going with docs https://review.opendev.org/690970 | 10:22 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib master: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692967 | 10:32 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib master: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692967 | 10:37 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib stable/train: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692970 | 10:37 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib stable/stein: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692974 | 10:41 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib stable/rocky: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692975 | 10:43 |
| rakhmerov | d0ugal: lgtm, may be apetrich can also take a look for the second +2 | 10:57 |
| d0ugal | rakhmerov: thanks, he is out now but I'll ask him this afternoon | 10:57 |
| rakhmerov | ok | 10:57 |
| d0ugal | I removed the depends-on btw - it isn't technically need | 10:57 |
| d0ugal | we need both, but it works fine without it | 10:57 |
| d0ugal | (we just added more keywords to check for) | 10:58 |
| openstackgerrit | Merged openstack/mistral master: tox: Keeping going with docs https://review.opendev.org/690972 | 11:07 |
| *** pgaxatte has quit IRC | 11:12 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib stable/stein: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692974 | 11:12 |
| *** pgaxatte has joined #openstack-mistral | 11:14 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib stable/rocky: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692975 | 11:15 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib stable/rocky: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692975 | 12:30 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib stable/stein: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692974 | 12:31 |
| apetrich | d0ugal, rakhmerov I'm still sick. I hoped I would get better. is there anything that I should review before I leave? | 13:57 |
| d0ugal | apetrich: it is fine, it can wait most likely | 13:58 |
| d0ugal | but thanks! | 13:58 |
| openstackgerrit | Merged openstack/mistral-lib master: Ensure we mask sensitive data from Mistral Action logs https://review.opendev.org/692967 | 14:05 |
| openstackgerrit | Oleh Huzei proposed openstack/mistral stable/rocky: Add release note for fix error of cron trigger run https://review.opendev.org/693019 | 14:37 |
| *** pgaxatte has quit IRC | 15:46 | |
| *** eyalb1 has quit IRC | 16:30 | |
| *** d0ugal has quit IRC | 16:53 | |
| *** d0ugal has joined #openstack-mistral | 17:09 | |
| *** jtomasek_ has quit IRC | 17:22 | |
| *** eyalb1 has joined #openstack-mistral | 17:45 | |
| *** jtomasek has joined #openstack-mistral | 18:54 | |
| *** eyalb1 has quit IRC | 18:54 | |
| *** jtomasek has quit IRC | 19:12 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!