| *** ricolin has joined #openstack-mistral | 02:48 | |
| *** boxiang has joined #openstack-mistral | 02:53 | |
| *** zhubx has quit IRC | 02:55 | |
| *** jtomasek has joined #openstack-mistral | 05:30 | |
| *** eyalb has joined #openstack-mistral | 05:52 | |
| *** vgvoleg has joined #openstack-mistral | 06:21 | |
| *** pgaxatte has joined #openstack-mistral | 06:31 | |
| rakhmerov | vgvoleg: hi, already discussed it, yes. | 07:00 |
|---|---|---|
| vgvoleg | Excuse me | 07:00 |
| rakhmerov | it now looks OK, I just asked to change the format of the commit message a bit | 07:00 |
| vgvoleg | I have no history in this window, what are you talking about? :D | 07:00 |
| rakhmerov | vgvoleg: I'm talking about https://review.opendev.org/#/c/675361 | 07:00 |
| rakhmerov | the migration patch | 07:01 |
| vgvoleg | okay | 07:01 |
| rakhmerov | our CI is now broken though | 07:02 |
| rakhmerov | can anybody investigate if you have time? | 07:02 |
| rakhmerov | I won't be able to do it in the next few hours | 07:02 |
| rakhmerov | apetrich: hi, may be you | 07:02 |
| rakhmerov | eyalb: hi ^ | 07:02 |
| eyalb | hi | 07:03 |
| rakhmerov | boxiang: ^ | 07:03 |
| eyalb | rakhmerov: ironicclient 3.0.0 was released it breaks the gate I think | 07:12 |
| eyalb | you can see the changes here https://docs.openstack.org/releasenotes/python-ironicclient/train.html | 07:13 |
| rakhmerov | ok | 07:13 |
| eyalb | should use endpoint_override instead of endpoint in c'tor | 07:15 |
| rakhmerov | eyalb: so you know how to fix it? | 07:34 |
| eyalb | not really | 07:34 |
| rakhmerov | ok | 07:34 |
| eyalb | it looks ok when I look at the code | 07:34 |
| eyalb | maybe you need to fake like you did in designate | 07:34 |
| eyalb | to mock | 07:34 |
| apetrich | rakhmerov, I will poke around in a bit | 07:42 |
| rakhmerov | thanks ) | 07:46 |
| eyalb | File "/workspace/git/openstack/mistral/mistral/actions/openstack/base.py", line 75, in get_fake_client_method | 07:48 |
| eyalb | return cls._get_client_method(cls._get_fake_client()) | 07:48 |
| eyalb | File "/workspace/git/openstack/mistral/mistral/actions/openstack/actions.py", line 365, in _get_fake_client | 07:48 |
| eyalb | session={"fake": "session"} | 07:48 |
| eyalb | File "/usr/local/lib/python3.7/dist-packages/ironicclient/v1/client.py", line 86, in __init__ | 07:48 |
| eyalb | self.http_client = http._construct_http_client(*args, **kwargs) | 07:48 |
| eyalb | File "/usr/local/lib/python3.7/dist-packages/ironicclient/common/http.py", line 519, in _construct_http_client | 07:48 |
| eyalb | **kwargs) | 07:48 |
| eyalb | File "/usr/local/lib/python3.7/dist-packages/ironicclient/common/http.py", line 386, in __init__ | 07:48 |
| eyalb | endpoint = self.session.get_endpoint(**endpoint_filter) | 07:48 |
| eyalb | rakhmerov: It tryes to get an endpoint from the fake session | 07:49 |
| eyalb | rakhmerov: I see that they fixed the get_endpoint to use the one provided instead of the session if exists | 07:57 |
| eyalb | https://github.com/openstack/python-ironicclient/commit/7f003e1e045e3e20b824a94676310315f8fef9fc | 07:58 |
| eyalb | but its is not released yet | 07:58 |
| *** apetrich has quit IRC | 08:12 | |
| *** apetrich has joined #openstack-mistral | 08:22 | |
| rakhmerov | eyalb: ok, I see | 08:34 |
| rakhmerov | then probably we need to do the same as with designate | 08:34 |
| rakhmerov | it's very very stupid but it is what it is for now.. | 08:34 |
| *** amorin has quit IRC | 08:44 | |
| *** amorin has joined #openstack-mistral | 08:45 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add an ability to disable workflow text validation https://review.opendev.org/683344 | 08:48 |
| eyalb | rakhmerov: you want me to fix it like designate ? | 08:56 |
| rakhmerov | eyalb: ok, yes, if you can | 08:57 |
| rakhmerov | if you have time | 08:57 |
| eyalb | ok | 08:57 |
| *** ricolin_ has joined #openstack-mistral | 09:05 | |
| *** ricolin has quit IRC | 09:08 | |
| *** ricolin_ is now known as ricolin | 09:23 | |
| openstackgerrit | Eyal proposed openstack/mistral master: Mock the ironic client so not to need a real session https://review.opendev.org/684261 | 09:26 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add an ability to disable workflow text validation https://review.opendev.org/683344 | 09:53 |
| openstackgerrit | Artem Lapin proposed openstack/mistral master: New alembic migration to support namespaces in postgresql https://review.opendev.org/675361 | 09:53 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add an ability to disable workflow text validation https://review.opendev.org/683344 | 09:56 |
| *** openstack has joined #openstack-mistral | 10:15 | |
| *** ChanServ sets mode: +o openstack | 10:15 | |
| *** boxiang has quit IRC | 13:49 | |
| *** boxiang has joined #openstack-mistral | 13:49 | |
| *** pgaxatte has quit IRC | 14:38 | |
| *** vgvoleg has quit IRC | 15:04 | |
| *** eyalb has quit IRC | 15:42 | |
| *** ricolin has quit IRC | 17:03 | |
| *** boxiang has quit IRC | 17:11 | |
| *** boxiang has joined #openstack-mistral | 17:11 | |
| *** jtomasek has quit IRC | 18:21 | |
| *** d0ugal has quit IRC | 18:37 | |
| *** d0ugal has joined #openstack-mistral | 19:02 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!