| *** _mmethot_ has joined #openstack-mistral | 01:02 | |
| *** ricolin has joined #openstack-mistral | 01:03 | |
| *** mmethot_ has quit IRC | 01:07 | |
| *** apetrich has quit IRC | 02:08 | |
| *** gkadam has joined #openstack-mistral | 03:31 | |
| *** gkadam has quit IRC | 03:40 | |
| rakhmerov | d0ugal: hi, if you ever have a chance: https://review.opendev.org/#/c/674781 | 04:55 |
|---|---|---|
| *** eyalb1 has joined #openstack-mistral | 06:14 | |
| *** pgaxatte has joined #openstack-mistral | 06:40 | |
| *** jtomasek has joined #openstack-mistral | 07:01 | |
| openstackgerrit | ali proposed openstack/mistral-lib master: moved generic util functions from mistral to mistral-lib https://review.opendev.org/675086 | 07:35 |
| *** abdelal has joined #openstack-mistral | 07:42 | |
| *** apetrich has joined #openstack-mistral | 07:44 | |
| d0ugal | rakhmerov: I wouldn't move over anything new if it isn't needed in mistral-lib or to write actions | 07:53 |
| d0ugal | Just remove them from mistral itself | 07:53 |
| d0ugal | moving code just for moving it seems silly | 07:53 |
| d0ugal | It just makes it harder to change in the future | 07:53 |
| rakhmerov | d0ugal: so our thinking here is the following: we want to move only something that's 1) very generic (not specific to Mistral) 2) very stable 3) it's a preparation for later refactoring related to actions etc. etc. that left over from the previous cycles. Lots of things that we wanna have in mistral-extra will need some of those utilities and we won't be able to use mistral as a dependency | 07:56 |
| d0ugal | Right, so I would add them as needed | 07:56 |
| d0ugal | not just add them now | 07:56 |
| d0ugal | I don't like it, but I don't have much vested interest anymore... so :) | 07:57 |
| rakhmerov | :) | 07:57 |
| rakhmerov | so you insist? :) | 07:57 |
| d0ugal | No, I mean I don't like it but you should do whatever you want | 07:58 |
| rakhmerov | I thought it'd be good task for abdelal because he's now starting with the project and needs to learn all the procedures and project structure | 07:58 |
| rakhmerov | :) | 07:58 |
| rakhmerov | ok | 07:58 |
| rakhmerov | d0ugal: we'll be careful with that, I understand your reasoning, of course | 07:58 |
| d0ugal | Sounds good | 08:00 |
| d0ugal | rakhmerov: I don't like that now mistral-lib depends on two new packages for no reason | 08:00 |
| rakhmerov | d0ugal: these functions will be removed from mistral | 08:00 |
| rakhmerov | there won't be duplications | 08:01 |
| d0ugal | I understand that, they will be removed from mistral but only used by mistral | 08:01 |
| d0ugal | mistral-lib is for shared code | 08:01 |
| d0ugal | not code that might be shared :) | 08:01 |
| rakhmerov | yes | 08:01 |
| rakhmerov | d0ugal: so wait, we actually already had situations when we stopped working on something (related to security I guess, Ryan was on it) just because we couldn't use stuff from Mistral and we didn't want to duplicate code | 08:02 |
| rakhmerov | it will be used not only Mistral | 08:03 |
| d0ugal | I understand that | 08:03 |
| rakhmerov | if it's something generic and stable, why not move it | 08:03 |
| d0ugal | My problem is with "will be" - there isn't a current use case for it | 08:03 |
| d0ugal | so you are moving it just because you think it might be used | 08:03 |
| rakhmerov | but I know I know.. you're saying that "not right now" | 08:03 |
| rakhmerov | will be used for sure | 08:03 |
| rakhmerov | it's a library | 08:04 |
| d0ugal | I look forward to seeing what code needs random_sleep | 08:04 |
| rakhmerov | it opens opportunities to be used by many other things | 08:04 |
| rakhmerov | :) | 08:04 |
| d0ugal | If the code is going into mistral-lib it should be documented and part of the stable python API | 08:04 |
| rakhmerov | tests, for example | 08:04 |
| rakhmerov | yeah, I totally agree | 08:04 |
| rakhmerov | good docs are needed | 08:05 |
| d0ugal | I still don't like it | 08:05 |
| d0ugal | but it is fine | 08:05 |
| rakhmerov | but we don't have 100 hands at the moment to keep up with everything | 08:05 |
| rakhmerov | step by step | 08:05 |
| d0ugal | sure | 08:05 |
| rakhmerov | :) | 08:05 |
| d0ugal | this is just a strange step IMO | 08:05 |
| d0ugal | :P | 08:05 |
| rakhmerov | ok | 08:05 |
| d0ugal | It would be better if the code felt "designed" | 08:06 |
| d0ugal | Not just one large utils file | 08:06 |
| d0ugal | i.e. there could be utils/threadlocal.py for some of | 08:06 |
| rakhmerov | Dougal, I understand exactly why you don't like it. But I believe this "don't have it if you don't use it" rule can be broken in case of libraries | 08:07 |
| d0ugal | at the moment it is just a collection of "stuff" | 08:07 |
| d0ugal | which doesn't feel like a library you are sharing | 08:07 |
| d0ugal | Right, that is fine. I guess we have a differing view on this | 08:07 |
| rakhmerov | until we released it we may change a structure | 08:07 |
| rakhmerov | np | 08:07 |
| rakhmerov | feel free to provide you suggestions on that | 08:08 |
| rakhmerov | your | 08:08 |
| d0ugal | Okay, I'll give it some thought | 08:08 |
| rakhmerov | thanks | 08:08 |
| apetrich | I don't know how I feel about it. Those util functions don't seem that interesting to be added to a lib but I like that someone new is giving the time to mistral | 08:19 |
| openstackgerrit | Merged openstack/mistral master: Allow to filter event notifications by their type https://review.opendev.org/670417 | 09:02 |
| openstackgerrit | Merged openstack/mistral master: Fix invalid assert states https://review.opendev.org/667814 | 09:31 |
| openstackgerrit | Merged openstack/mistral master: Create docs for the workflow namespaces feature https://review.opendev.org/674781 | 09:31 |
| *** pgaxatte has quit IRC | 10:32 | |
| openstackgerrit | Eyal proposed openstack/mistral master: Fail-on policy https://review.opendev.org/663776 | 11:51 |
| *** ricolin_ has joined #openstack-mistral | 12:05 | |
| *** ricolin has quit IRC | 12:07 | |
| *** pgaxatte has joined #openstack-mistral | 12:49 | |
| openstackgerrit | Eyal proposed openstack/mistral master: Fail-on policy https://review.opendev.org/663776 | 13:10 |
| *** ricolin_ is now known as ricolin | 13:55 | |
| *** abdelal has quit IRC | 14:05 | |
| *** eyalb1 has quit IRC | 14:22 | |
| *** pgaxatte has quit IRC | 14:29 | |
| openstackgerrit | Artem Lapin proposed openstack/mistral master: New alembic migration to support namespaces in postgresql https://review.opendev.org/675361 | 14:43 |
| *** ricolin_ has joined #openstack-mistral | 15:43 | |
| *** ricolin_ has quit IRC | 15:45 | |
| *** ricolin has quit IRC | 15:46 | |
| *** ricolin_ has joined #openstack-mistral | 15:46 | |
| *** ricolin_ is now known as ricolin | 15:47 | |
| *** ricolin_ has joined #openstack-mistral | 17:16 | |
| *** ricolin has quit IRC | 17:19 | |
| *** ricolin_ is now known as ricolin | 17:32 | |
| *** bobh has joined #openstack-mistral | 18:35 | |
| *** bobh has quit IRC | 19:06 | |
| *** bobh has joined #openstack-mistral | 19:19 | |
| *** bobh has quit IRC | 19:56 | |
| *** bobh has joined #openstack-mistral | 19:56 | |
| *** bobh has quit IRC | 20:01 | |
| *** jtomasek has quit IRC | 20:31 | |
| *** jtomasek has joined #openstack-mistral | 21:36 | |
| *** ricolin_ has joined #openstack-mistral | 23:02 | |
| *** ricolin has quit IRC | 23:05 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!