| *** apetrich has quit IRC | 01:57 | |
| *** irclogbot_0 has quit IRC | 03:01 | |
| *** irclogbot_0 has joined #openstack-mistral | 03:02 | |
| rakhmerov | vgvoleg, mgariepy: no bureaucracy at all, just send a patch :) | 05:02 |
|---|---|---|
| rakhmerov | if it's something more complicated then a bug at Launchpad may be needed, especially if you want to backport it | 05:02 |
| rakhmerov | mgariepy: the patch looks good to me | 05:04 |
| rakhmerov | thanks | 05:04 |
| *** vvrpradeep has joined #openstack-mistral | 05:35 | |
| *** jtomasek has joined #openstack-mistral | 05:39 | |
| openstackgerrit | Merged openstack/mistral master: Fix doc https://review.openstack.org/651589 | 05:59 |
| *** vvrpradeep has quit IRC | 06:00 | |
| *** pgaxatte has joined #openstack-mistral | 06:20 | |
| *** mnaser has quit IRC | 07:06 | |
| *** mnaser has joined #openstack-mistral | 07:07 | |
| *** apetrich has joined #openstack-mistral | 07:42 | |
| *** vgvoleg_ has joined #openstack-mistral | 07:48 | |
| openstackgerrit | Merged openstack/mistral stable/stein: Fix an expression context for all_errors_handled() https://review.openstack.org/651717 | 07:57 |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Fix E305 codestyle errors https://review.openstack.org/652002 | 08:07 |
| vgvoleg_ | Hi all, I have a question about https://review.openstack.org/#/c/636583/ | 08:52 |
| vgvoleg_ | The latest PyYAML introduced a new key to save key order during dump | 08:53 |
| vgvoleg_ | https://github.com/yaml/pyyaml/commit/07c88c6c1bee51439a00bc07827980fbb161a1ad | 08:54 |
| vgvoleg_ | So, it could be used to resolve the problem | 08:55 |
| vgvoleg_ | but | 08:55 |
| vgvoleg_ | in case of python < 3.6 sorting occurs earlier - in load | 08:56 |
| vgvoleg_ | because python dicts keep key ordering only since python 3.6 | 08:57 |
| vgvoleg_ | the question is simple | 08:57 |
| vgvoleg_ | is it OK to upload the patch with this new key and let this fail on python < 3.6? | 08:58 |
| rakhmerov | vgvoleg_: aah.. you mean you can modify that test so it checks the python version? | 10:25 |
| rakhmerov | the code and the test | 10:25 |
| vgvoleg_ | omg.. I forgot about tests | 10:26 |
| vgvoleg_ | Is there any mechanism to run a test only in specific python? :D | 10:27 |
| apetrich | vgvoleg_, tox -e py27 for example | 10:29 |
| vgvoleg_ | no, I mean what if one test would be good only in python >= 3.6 | 10:30 |
| vgvoleg_ | what should I do to not fail 2.7 and 3.5 jobs | 10:31 |
| apetrich | vgvoleg_, oh sorry | 10:39 |
| apetrich | one minute | 10:39 |
| apetrich | vgvoleg_, (sys.version_info[0] < 3) is what I used in the past | 10:39 |
| apetrich | but that tests only py3 or not | 10:40 |
| apetrich | I don't know of a decorator or something else that could be useful | 10:40 |
| vgvoleg_ | ok thanks I'll try to come up with sothing suitable | 10:47 |
| vgvoleg_ | [11:58] <vgvoleg_> is it OK to upload the patch with this new key and let this fail on python < 3.6? | 10:49 |
| apetrich | vgvoleg_, I'm not a huge fan of that. | 10:57 |
| vgvoleg_ | ok, I'll try something else | 11:00 |
| *** vgvoleg_ has quit IRC | 11:05 | |
| openstackgerrit | Merged openstack/mistral master: Fix E305 codestyle errors https://review.openstack.org/652002 | 11:51 |
| *** altlogbot_2 has joined #openstack-mistral | 13:04 | |
| *** altlogbot_2 has quit IRC | 13:32 | |
| *** altlogbot_0 has joined #openstack-mistral | 13:33 | |
| *** altlogbot_0 has quit IRC | 13:38 | |
| *** altlogbot_0 has joined #openstack-mistral | 13:39 | |
| *** altlogbot_0 has quit IRC | 14:00 | |
| *** altlogbot_2 has joined #openstack-mistral | 14:26 | |
| *** altlogbot_2 has quit IRC | 14:29 | |
| *** altlogbot_2 has joined #openstack-mistral | 14:30 | |
| *** altlogbot_2 has quit IRC | 14:33 | |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Add delay option to std.echo to emulate external lags. https://review.openstack.org/652086 | 14:34 |
| *** altlogbot_1 has joined #openstack-mistral | 14:48 | |
| *** altlogbot_1 has quit IRC | 14:51 | |
| *** altlogbot_2 has joined #openstack-mistral | 14:53 | |
| *** altlogbot_2 has quit IRC | 14:55 | |
| *** altlogbot_3 has joined #openstack-mistral | 14:59 | |
| *** pgaxatte has quit IRC | 15:09 | |
| *** bobh has joined #openstack-mistral | 17:10 | |
| *** irclogbot_0 has quit IRC | 18:08 | |
| *** irclogbot_2 has joined #openstack-mistral | 18:11 | |
| *** livelace has joined #openstack-mistral | 18:52 | |
| *** apetrich has quit IRC | 19:00 | |
| *** bobh has quit IRC | 19:02 | |
| *** livelace has quit IRC | 20:52 | |
| *** jtomasek has quit IRC | 21:14 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!