| *** mmethot has quit IRC | 01:19 | |
| *** nguyenhai has joined #openstack-mistral | 02:09 | |
| *** gkadam has joined #openstack-mistral | 02:37 | |
| rakhmerov | vgvoleg: no, there aren't any known memory leaks. All we have found in the past are fixed | 04:38 |
|---|---|---|
| *** pgaxatte has joined #openstack-mistral | 06:44 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Setting the lower version of sphinxcontrib-pecanwsme to 0.10.0 https://review.openstack.org/649270 | 07:04 |
| *** akovi has joined #openstack-mistral | 07:05 | |
| *** jistr is now known as jistr|afk | 07:22 | |
| rakhmerov | d0ugal, apetrich, akovi: hi, please approve https://review.openstack.org/649270 | 07:23 |
| rakhmerov | it fixes the problem with Sphinx | 07:23 |
| rakhmerov | in a nutshell, a new version (0.10.0) of sphinxcontrib-pecanwsme was released yesterday per my request that makes it compatible with Sphinx 2.0.0 | 07:24 |
| rakhmerov | so we have to pin the lower constraint now | 07:24 |
| apetrich | rakhmerov, sure do | 07:25 |
| rakhmerov | thnx | 07:25 |
| *** akovi has quit IRC | 08:16 | |
| *** akovi has joined #openstack-mistral | 08:17 | |
| rakhmerov | apetrich, d0ugal, akovi: devstack jobs are failing because of the two tests related to SSH | 08:47 |
| rakhmerov | do you think it's ok if I switch them off for now? | 08:47 |
| rakhmerov | we always have issues with them | 08:47 |
| apetrich | I was about to say that | 08:47 |
| rakhmerov | I'd turn them off now and create a ticket to fix them later | 08:47 |
| rakhmerov | apetrich: yeah.. | 08:48 |
| d0ugal | Sure | 08:48 |
| d0ugal | I don't think we use them anyway :) | 08:48 |
| rakhmerov | I believe we simply don't have time to fix them now | 08:48 |
| rakhmerov | d0ugal: exactly | 08:48 |
| akovi | ok | 08:48 |
| rakhmerov | ok, I'll fix that patch now.. | 08:48 |
| apetrich | I'm fine with them being off for a while, but I don't know enough about them | 08:48 |
| akovi | we should skip them with a skipif(date() < '2019-07-01') kind of expression | 08:52 |
| akovi | this way they will turn on after a while | 08:52 |
| akovi | and we can decide to postpone fixing again :) | 08:52 |
| rakhmerov | hah, interesting: https://github.com/openstack/mistral-tempest-plugin/blob/master/mistral_tempest_tests/tests/scenario/engine/actions/v2/test_ssh_actions.py#L258 | 08:53 |
| rakhmerov | at least the second one should be skipped | 08:53 |
| rakhmerov | akovi: or may be it's not disabled correctly? | 08:54 |
| *** dkushwaha has joined #openstack-mistral | 08:54 | |
| rakhmerov | those decorators come form tempest and I'm not well familiar with them | 08:54 |
| akovi | I have no clue what skip_because does | 08:54 |
| rakhmerov | yeah.. ok | 08:54 |
| akovi | seems like a bad idea that running a test requires upstream connection anyway | 08:56 |
| akovi | it's been changed to Won't Fix | 08:58 |
| akovi | so it's done and the test could run again :) | 08:58 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral-tempest-plugin master: Disable SSH actions tests till they are stable https://review.openstack.org/649541 | 09:03 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Set the lower version of sphinxcontrib-pecanwsme to 0.10.0 https://review.openstack.org/649270 | 09:06 |
| rakhmerov | akovi: yes, right | 09:06 |
| rakhmerov | I filed a new bug and specified its number in the test | 09:06 |
| *** akovi has quit IRC | 09:14 | |
| *** akovi has joined #openstack-mistral | 09:15 | |
| *** akovi has joined #openstack-mistral | 09:16 | |
| *** dkushwaha has quit IRC | 09:18 | |
| *** mr_joom has joined #openstack-mistral | 09:43 | |
| *** mr_joom is now known as merdman | 09:45 | |
| rakhmerov | damn.. apetrich, akovi: seems like this decorator has no effect | 10:02 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral-tempest-plugin master: Disable SSH actions tests till they are stable https://review.openstack.org/649541 | 10:06 |
| *** dkushwaha has joined #openstack-mistral | 10:56 | |
| *** jistr|afk is now known as jistr | 11:02 | |
| *** akovi has quit IRC | 11:45 | |
| *** akovi has joined #openstack-mistral | 11:46 | |
| *** apetrich has quit IRC | 11:48 | |
| *** apetrich has joined #openstack-mistral | 11:49 | |
| *** apetrich has quit IRC | 12:05 | |
| rakhmerov | d0ugal: have you ever dealt with these decorators? | 12:13 |
| rakhmerov | do you see maybe what's wrong with them in https://review.openstack.org/#/c/649541/2/mistral_tempest_tests/tests/scenario/engine/actions/v2/test_ssh_actions.py | 12:13 |
| d0ugal | rakhmerov: I remember trying to use the skip bugs before - but I don't remember much about them :) | 12:17 |
| d0ugal | What does the "condition=True" mean? | 12:17 |
| rakhmerov | a condition when the test should be skipped :) | 12:18 |
| rakhmerov | but, in fact, it doesn't make any difference | 12:18 |
| rakhmerov | I'm also looking at the tempest code now and see that.. | 12:18 |
| rakhmerov | I wonder if the order of the decorators matters | 12:20 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral-tempest-plugin master: Disable SSH actions tests till they are stable https://review.openstack.org/649541 | 12:22 |
| *** apetrich has joined #openstack-mistral | 12:23 | |
| *** akovi has quit IRC | 12:28 | |
| *** akovi has joined #openstack-mistral | 12:28 | |
| *** nguyenhai has quit IRC | 12:33 | |
| *** mmethot has joined #openstack-mistral | 12:36 | |
| *** akovi has quit IRC | 13:07 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral-tempest-plugin master: Disable SSH actions tests till they are stable https://review.openstack.org/649541 | 15:09 |
| *** pgaxatte has quit IRC | 15:50 | |
| rakhmerov | d0ugal, apetrich: can you please approve https://review.openstack.org/649541 | 16:10 |
| rakhmerov | I simply used testtools.skip() | 16:10 |
| *** gkadam has quit IRC | 16:42 | |
| *** apetrich has quit IRC | 17:46 | |
| *** bobh has joined #openstack-mistral | 20:08 | |
| *** mmethot has quit IRC | 21:00 | |
| *** bobh has quit IRC | 21:17 | |
| *** bobh has joined #openstack-mistral | 22:33 | |
| *** bobh has quit IRC | 22:47 | |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Stop sending workflow output to on_action_complete https://review.openstack.org/649761 | 23:11 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!