| *** irclogbot_1 has joined #openstack-mistral | 00:17 | |
| *** apetrich has quit IRC | 03:15 | |
| *** jtomasek has joined #openstack-mistral | 06:17 | |
| rakhmerov | d0ughi all, does it look familiar to you? http://logs.openstack.org/47/643847/2/check/openstack-tox-py37/e0438d8/testr_results.html.gz | 06:35 |
|---|---|---|
| rakhmerov | d0ugal: ^ | 06:36 |
| rakhmerov | trying to understand what is happening (not every time!) | 06:36 |
| *** pgaxatte has joined #openstack-mistral | 07:05 | |
| *** apetrich has joined #openstack-mistral | 07:43 | |
| rakhmerov | apetrich: hi | 07:51 |
| rakhmerov | did you happen to come across this error? | 07:51 |
| apetrich | rakhmerov, hey. | 07:51 |
| rakhmerov | what's really weird is that it's sporadic | 07:51 |
| apetrich | rakhmerov, which one? | 07:51 |
| rakhmerov | I'm failing to understand its nature | 07:51 |
| apetrich | just logged in | 07:51 |
| rakhmerov | http://logs.openstack.org/47/643847/2/check/openstack-tox-py37/e0438d8/testr_results.html.gz | 07:51 |
| rakhmerov | ok | 07:51 |
| rakhmerov | it happens only on py37 | 07:51 |
| rakhmerov | and not every time! | 07:52 |
| apetrich | oh bugger | 07:52 |
| apetrich | I think I saw that once and then when rechecked it didn't trigger | 07:52 |
| apetrich | so I didn't worry too much | 07:53 |
| apetrich | the traceback helps so little in this case | 07:55 |
| apetrich | I'm looking a bit into it | 07:55 |
| rakhmerov | yeah | 07:59 |
| rakhmerov | traceback seem to be completely irrelevant | 08:00 |
| rakhmerov | some magic | 08:00 |
| rakhmerov | apetrich: I'd like to ask you to remove WIP for that patch | 08:00 |
| rakhmerov | and actually merge it | 08:00 |
| rakhmerov | we're running out of time with RC1 | 08:00 |
| rakhmerov | and I'd like that patch in master very much | 08:00 |
| apetrich | sure | 08:00 |
| rakhmerov | hopefully by rechecking we can merge it today | 08:01 |
| rakhmerov | in the mean time we'll figure out how to address that | 08:01 |
| apetrich | Cool. I'm happy with that | 08:01 |
| rakhmerov | it's really also hard to understand why this is sporadic | 08:01 |
| rakhmerov | no concurrency, nothing | 08:02 |
| rakhmerov | apetrich: thanks a lot | 08:03 |
| rakhmerov | apetrich, d0ugal: can you also look at https://review.openstack.org/#/c/643907/ | 08:05 |
| rakhmerov | it fails with the same error but it's not related to the patch | 08:05 |
| apetrich | rakhmerov, good news is that I can reproduce locally. not always but sometimes | 08:13 |
| apetrich | 2 runs and it happened in one | 08:14 |
| rakhmerov | me too | 08:14 |
| rakhmerov | yes | 08:14 |
| rakhmerov | I guess it's related with some native code | 08:14 |
| rakhmerov | but looks really weird | 08:15 |
| rakhmerov | apetrich: do you have any idea how "return _iterencode(o, 0)" can throw this exception? | 08:28 |
| rakhmerov | I don't :) | 08:28 |
| apetrich | rakhmerov, I think it will try to read o as an interable. it will try _get_item if that doesn't work it will try something else that I don't remember and then it will try .items() and that where it is failing | 08:29 |
| apetrich | rakhmerov, guess only btw | 08:29 |
| rakhmerov | hm.. | 08:30 |
| rakhmerov | I mean that at this exact place nothing like you just described happens | 08:30 |
| rakhmerov | it's just a method call | 08:30 |
| rakhmerov | I guess here comes a native C code that's why traceback doesn't tell much | 08:31 |
| *** vgvoleg has joined #openstack-mistral | 08:37 | |
| d0ugal | rakhmerov: Taking a look now. | 08:51 |
| d0ugal | It is a bit strange, the mocking on that failing test isn't great tho | 08:55 |
| d0ugal | Giving the get_all mock a return arg might solve it | 08:56 |
| d0ugal | The test wont fail for me. | 09:03 |
| rakhmerov | d0ugal: try many times under py37 | 09:17 |
| rakhmerov | for me it fails about once of ten times | 09:18 |
| d0ugal | I tried quite a large number, but I can try some more :) | 09:36 |
| rakhmerov | :) | 09:42 |
| rakhmerov | you sure you run on py37? | 09:42 |
| d0ugal | yup | 09:46 |
| d0ugal | I did notice that we need to update tox :) | 09:47 |
| d0ugal | okay, just got the error | 09:50 |
| d0ugal | and now it wants to happen more often | 09:50 |
| d0ugal | seems like the obvious issue is that patch is not good :) | 09:50 |
| d0ugal | so I would make the get_all mock patch something real and not just a mock | 09:51 |
| d0ugal | It is surprising to me that simplejson managed to serialise it before? | 09:51 |
| *** openstackgerrit has joined #openstack-mistral | 09:51 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Improve profiler logging https://review.openstack.org/643907 | 09:51 |
| rakhmerov | d0ugal: | 09:52 |
| rakhmerov | yeah | 09:52 |
| rakhmerov | right | 09:52 |
| d0ugal | When was the 37 gate added? I guess it is fairly new and we just have not had enough patches to see it | 09:53 |
| rakhmerov | d0ugal, apetrich: would you be able to keep an eye on this? I have to disappear for a few hours. Now the patch failed with a tripleO error. | 09:53 |
| rakhmerov | d0ugal: recently | 09:53 |
| rakhmerov | yes | 09:53 |
| rakhmerov | as a temporary dirty hack we can even exclude this test | 09:54 |
| rakhmerov | or change a mock somehow, yes | 09:54 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Add Python 3.7 to tox https://review.openstack.org/645536 | 11:11 |
| *** csatari_ has joined #openstack-mistral | 12:07 | |
| *** csatari has quit IRC | 12:14 | |
| *** csatari_ is now known as csatari | 12:14 | |
| *** rakhmerov has quit IRC | 12:17 | |
| *** altlogbot_0 has quit IRC | 13:01 | |
| *** irclogbot_1 has quit IRC | 13:01 | |
| *** irclogbot_2 has joined #openstack-mistral | 13:02 | |
| *** altlogbot_3 has joined #openstack-mistral | 13:02 | |
| vgvoleg | Does anyone see this error ? | 13:11 |
| vgvoleg | TypeError: You cannot set the body to a text value without a charset | 13:11 |
| vgvoleg | I'm trying to create wf and can't get what's wrong with my request | 13:17 |
| openstackgerrit | Merged openstack/mistral master: Add "root_execution" mapped property to WorkflowExecution model https://review.openstack.org/643847 | 13:23 |
| *** altlogbot_3 has quit IRC | 15:21 | |
| *** altlogbot_1 has joined #openstack-mistral | 15:25 | |
| *** irclogbot_2 has quit IRC | 15:30 | |
| *** irclogbot_3 has joined #openstack-mistral | 15:32 | |
| *** irclogbot_3 has quit IRC | 15:36 | |
| *** irclogbot_2 has joined #openstack-mistral | 15:37 | |
| *** pgaxatte has quit IRC | 15:52 | |
| *** smrcascao has quit IRC | 16:09 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/mistral stable/stein: Update .gitreview for stable/stein https://review.openstack.org/645839 | 18:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/mistral stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/645841 | 18:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/mistral master: Update master for stable/stein https://review.openstack.org/645842 | 18:48 |
| openstackgerrit | OpenStack Release Bot proposed openstack/mistral-dashboard stable/stein: Update .gitreview for stable/stein https://review.openstack.org/645844 | 18:49 |
| openstackgerrit | OpenStack Release Bot proposed openstack/mistral-dashboard stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/645845 | 18:49 |
| openstackgerrit | OpenStack Release Bot proposed openstack/mistral-dashboard master: Update master for stable/stein https://review.openstack.org/645846 | 18:49 |
| openstackgerrit | OpenStack Release Bot proposed openstack/mistral-extra stable/stein: Update .gitreview for stable/stein https://review.openstack.org/645847 | 18:49 |
| openstackgerrit | OpenStack Release Bot proposed openstack/mistral-extra stable/stein: Update UPPER_CONSTRAINTS_FILE for stable/stein https://review.openstack.org/645848 | 18:49 |
| *** jtomasek has quit IRC | 19:23 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!