| rakhmerov | d0ugal: aah, I see | 04:10 |
|---|---|---|
| rakhmerov | s10: ok | 04:10 |
| *** jtomasek has joined #openstack-mistral | 06:15 | |
| *** shardy has quit IRC | 06:44 | |
| *** shardy has joined #openstack-mistral | 06:52 | |
| *** pgaxatte has joined #openstack-mistral | 07:25 | |
| *** akovi has joined #openstack-mistral | 07:37 | |
| *** akovi has quit IRC | 07:46 | |
| *** gkadam_ has joined #openstack-mistral | 07:50 | |
| rakhmerov | d0ugal: I'm not sure though how to fix it correctly | 08:24 |
| d0ugal | rakhmerov: we just need to change it back to calling self.list() | 08:28 |
| rakhmerov | are you sure? | 08:30 |
| d0ugal | rakhmerov: Yup, I think so | 08:30 |
| d0ugal | it wasn't broken before the most recent release :) | 08:30 |
| rakhmerov | and where do you see the "list()" method in this class? :) | 08:31 |
| d0ugal | rakhmerov: in subclasses | 08:31 |
| rakhmerov | I don't | 08:31 |
| rakhmerov | aaah... | 08:31 |
| rakhmerov | true | 08:31 |
| d0ugal | it is a pretend abstract method | 08:31 |
| rakhmerov | yes | 08:31 |
| rakhmerov | yes, f.. python.. | 08:31 |
| d0ugal | really we should also add def list(self): raise NotImplementedError | 08:31 |
| rakhmerov | yes | 08:31 |
| d0ugal | to make that clearer in the future | 08:31 |
| rakhmerov | that would be right | 08:31 |
| rakhmerov | 100% agree | 08:31 |
| rakhmerov | that's why I was actually confused | 08:32 |
| rakhmerov | because I put those "abstract" methods everywhere | 08:32 |
| rakhmerov | d0ugal: I tried to reach out to Bob but he seems to have disappeared ) | 08:36 |
| d0ugal | damn | 08:36 |
| d0ugal | That is a shame | 08:37 |
| d0ugal | it is much quieter in here lately | 08:37 |
| rakhmerov | if you need it urgently, please send a patch yourself | 08:37 |
| rakhmerov | I can do it later | 08:37 |
| rakhmerov | very busy for now.. | 08:37 |
| d0ugal | ok | 08:37 |
| rakhmerov | d0ugal: yeah, but I'm working on making it louder again ) | 08:37 |
| d0ugal | Good good | 08:37 |
| rakhmerov | I don't expect it will happen very soon but we'll see | 08:38 |
| d0ugal | Fingers crossed | 08:38 |
| rakhmerov | :) | 08:38 |
| *** shardy has quit IRC | 11:11 | |
| *** smrcascao has joined #openstack-mistral | 11:12 | |
| *** smrcascao has quit IRC | 11:40 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/python-mistralclient master: Fix typo for self.list https://review.openstack.org/643304 | 11:54 |
| *** sshnaidm|rover has joined #openstack-mistral | 12:38 | |
| openstackgerrit | Sagi Shnaidman proposed openstack/python-mistralclient master: Change tripleo job to multinode-containers job https://review.openstack.org/643319 | 12:49 |
| sshnaidm|rover | apetrich, d0ugal ^^ | 12:50 |
| openstackgerrit | Adriano Petrich proposed openstack/python-mistralclient master: Fix typo for self.list https://review.openstack.org/643304 | 13:10 |
| apetrich | sshnaidm|rover, ^^ | 13:13 |
| *** smrcascao has joined #openstack-mistral | 13:15 | |
| sshnaidm|rover | apetrich, cool, thanks | 13:21 |
| d0ugal | +2'ed both. Thanks! | 13:26 |
| *** apetrich has quit IRC | 15:10 | |
| *** jtomasek has quit IRC | 16:35 | |
| *** pgaxatte has quit IRC | 16:39 | |
| *** gkadam_ has quit IRC | 16:50 | |
| *** sshnaidm|rover is now known as sshnaidm|afk | 17:02 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!