| *** toure is now known as toure|gone | 00:30 | |
| openstackgerrit | zhufl proposed openstack/mistral master: Add missing ws separator between words https://review.openstack.org/619140 | 03:18 |
|---|---|---|
| *** hardikjasani has joined #openstack-mistral | 04:43 | |
| *** akovi has joined #openstack-mistral | 05:39 | |
| *** d0ugal has quit IRC | 06:05 | |
| *** apetrich has joined #openstack-mistral | 06:40 | |
| *** gkadam has joined #openstack-mistral | 07:25 | |
| *** jtomasek has joined #openstack-mistral | 07:59 | |
| *** shardy has joined #openstack-mistral | 08:35 | |
| *** shardy has quit IRC | 08:39 | |
| *** bobh has joined #openstack-mistral | 08:43 | |
| *** d0ugal has joined #openstack-mistral | 09:11 | |
| *** d0ugal has quit IRC | 09:22 | |
| akovi | josecastroleon: I think you can't do this. The workflow execution has some parameters that cannot be generalized. You should authenticate outside Mistral and target your executions separately. New execution for each target. There is no way to iterate through endpoints/regions/tenants. | 09:24 |
| *** jaosorior has quit IRC | 09:26 | |
| *** d0ugal has joined #openstack-mistral | 09:26 | |
| *** shardy has joined #openstack-mistral | 09:51 | |
| openstackgerrit | Kupai József proposed openstack/mistral master: Eliminating datetime.now() https://review.openstack.org/619189 | 10:00 |
| *** bobh has quit IRC | 10:01 | |
| *** jaosorior has joined #openstack-mistral | 10:03 | |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Sending TASK_FAILED event in case of MistralException https://review.openstack.org/619192 | 10:03 |
| vgvoleg | Guys, hi all, I need your help with this ^^^^^ | 10:10 |
| vgvoleg | I can't get how to test another cases with some natural mistral workflow | 10:10 |
| vgvoleg | Not sure that using stubs is correct | 10:11 |
| vgvoleg | Just mocking functions from try section doesn't describe sensitive use cases | 10:12 |
| *** shardy has quit IRC | 10:52 | |
| *** shardy has joined #openstack-mistral | 10:53 | |
| akovi | vgvoleg: it seems like this is practically copy-paste everywhere. It may be better extracted to a function. As a matter of fact, if events must be generated o state change, then this should be weaved into the state change logic instead of littering the code everywhere with notify calls. Reactive programming principles could help here but it would be a large change. | 11:38 |
| akovi | If you ensure that the state change is always done through your extracted logic, then it should be enough to test the new function only. | 11:39 |
| akovi | Please don't try to mock everything, that's a very unreliable way of solving testability issues. | 11:40 |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Refactor size limit check mechanism https://review.openstack.org/608469 | 11:44 |
| vgvoleg | akovi: as I said, I don't want to use mocks there, but I have no idea about any other ways to provoke this exception | 11:47 |
| akovi | vgvoleg: well if there are no tests for these cases now, then it would be an improvement to have but I feel like it is not completely necessary for you to test all these | 11:57 |
| akovi | it's stateful code, embedded in the business logic | 11:57 |
| akovi | noone will crucify you for doing this | 11:58 |
| akovi | :) | 11:58 |
| vgvoleg | ok, I got it :D | 11:58 |
| openstackgerrit | Oleg Ovcharuk proposed openstack/mistral master: Sending TASK_FAILED event in case of MistralException https://review.openstack.org/619192 | 12:17 |
| vgvoleg | akovi: refactored ^^^ | 12:19 |
| vgvoleg | https://review.openstack.org/#/c/616693 anyone, need your opinion | 12:54 |
| *** hardikjasani has quit IRC | 13:42 | |
| *** toure|gone is now known as toure | 14:17 | |
| *** bobh has joined #openstack-mistral | 14:21 | |
| *** jaosorior has quit IRC | 14:25 | |
| *** jaosorior has joined #openstack-mistral | 15:24 | |
| *** bobh has quit IRC | 16:19 | |
| *** gkadam has quit IRC | 16:40 | |
| *** akovi has quit IRC | 16:54 | |
| *** shardy has quit IRC | 17:01 | |
| *** shardy has joined #openstack-mistral | 17:07 | |
| *** jaosorior has quit IRC | 17:41 | |
| *** shardy has quit IRC | 18:34 | |
| *** shardy has joined #openstack-mistral | 18:36 | |
| *** shardy has quit IRC | 18:56 | |
| *** apetrich has quit IRC | 19:00 | |
| *** apetrich has joined #openstack-mistral | 19:15 | |
| *** bobh has joined #openstack-mistral | 19:35 | |
| *** apetrich has quit IRC | 20:01 | |
| *** bobh has quit IRC | 20:29 | |
| *** bobh has joined #openstack-mistral | 20:39 | |
| *** bobh has quit IRC | 21:28 | |
| *** toure is now known as toure|gone | 23:03 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!