| *** apetrich has quit IRC | 03:15 | |
| *** hardikjasani has joined #openstack-mistral | 04:07 | |
| *** threestrands has joined #openstack-mistral | 05:02 | |
| *** akovi has joined #openstack-mistral | 05:30 | |
| rakhmerov | d0ugal: yes | 05:41 |
|---|---|---|
| *** shardy has joined #openstack-mistral | 06:19 | |
| *** shardy has quit IRC | 06:37 | |
| *** gkadam has joined #openstack-mistral | 07:46 | |
| *** threestrands has quit IRC | 08:04 | |
| rakhmerov | d0ugal, akovi: can you please review a number of small infrastructural reviews? https://review.openstack.org/614254, https://review.openstack.org/614256, https://review.openstack.org/614287, https://review.openstack.org/614255, https://review.openstack.org/614999, https://review.openstack.org/614993, https://review.openstack.org/615220 | 08:34 |
| rakhmerov | they are small and have been there for a while | 08:35 |
| rakhmerov | also: https://review.openstack.org/610553, https://review.openstack.org/610551 | 08:35 |
| *** ykarel has joined #openstack-mistral | 08:36 | |
| ykarel | d0ugal, u around? | 08:42 |
| ykarel | d0ugal, remember the failure in python3? https://logs.rdoproject.org/82/613282/14/openstack-check-rdo/puppet-openstack-integration-5-scenario-py3-tempest-fedora-28/a5d584d/logs/testr_results.html.gz | 08:43 |
| ykarel | d0ugal, i tried to reproduce it with pytho2 and python3 locally and here is the output:- CentOS python2: http://paste.openstack.org/show/734744/, Fedora python3: http://paste.openstack.org/show/734743/ | 08:47 |
| ykarel | d0ugal, can u check and see why it's different order | 08:48 |
| *** shardy has joined #openstack-mistral | 09:02 | |
| *** ykarel is now known as ykarel|lunch | 09:10 | |
| d0ugal | ykarel|lunch: Here now. Looking. | 09:10 |
| ykarel|lunch | d0ugal, ack | 09:11 |
| d0ugal | ykarel|lunch: Where are you based? | 09:11 |
| ykarel|lunch | d0ugal, let me know if u need access to my local reproducer | 09:11 |
| ykarel|lunch | d0ugal, India | 09:11 |
| d0ugal | It is 9am here, but I am hungry for lunch already - so maybe I should move :) | 09:11 |
| ykarel|lunch | d0ugal, ack go ahead :) | 09:12 |
| openstackgerrit | Merged openstack/mistral-specs master: Update min tox version to 2.0 https://review.openstack.org/614993 | 09:18 |
| openstackgerrit | Merged openstack/mistral-dashboard master: Remove setup.py check from pep8 job https://review.openstack.org/614255 | 09:20 |
| openstackgerrit | guotao proposed openstack/mistral master: Omit the twice occured words in index.rst https://review.openstack.org/617537 | 09:21 |
| openstackgerrit | Merged openstack/mistral-extra master: Remove setup.py check from pep8 job https://review.openstack.org/614256 | 09:22 |
| openstackgerrit | Merged openstack/mistral-dashboard master: Update min tox version to 2.0 https://review.openstack.org/615220 | 09:23 |
| rakhmerov | d0ugal: also https://review.openstack.org/612118 | 09:23 |
| rakhmerov | thanks! | 09:23 |
| d0ugal | rakhmerov: Thank you for the reminder | 09:24 |
| openstackgerrit | Merged openstack/mistral-extra master: Increment versioning with pbr instruction https://review.openstack.org/610551 | 09:24 |
| d0ugal | I have been terrible at reviewing lately, too distracted by other stuff. | 09:24 |
| *** bobh has joined #openstack-mistral | 09:26 | |
| openstackgerrit | guotao proposed openstack/mistral master: Remove those copy words occured twice times in wf_lang_v2.rst https://review.openstack.org/617540 | 09:27 |
| *** shardy has quit IRC | 09:27 | |
| rakhmerov | d0ugal: np | 09:34 |
| rakhmerov | d0ugal: please also approve these two: https://review.openstack.org/616735, https://review.openstack.org/616731 | 09:35 |
| d0ugal | Done! | 09:37 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Use SessionClient for Ironic actions https://review.openstack.org/607974 | 09:44 |
| openstackgerrit | Merged openstack/mistral-lib master: Add python 3.6 unit test job https://review.openstack.org/616735 | 09:44 |
| *** ykarel|lunch is now known as ykarel | 09:45 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Use eventlet-aware threading events https://review.openstack.org/557487 | 09:47 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-tempest-plugin master: Add sorting to the "in list filter" test https://review.openstack.org/617547 | 09:56 |
| d0ugal | ykarel: ^ I think that will fix that error | 09:58 |
| ykarel | d0ugal, yup that might solve it, but i was trying to understand why it happened with python3 | 09:59 |
| *** bobh has quit IRC | 09:59 | |
| *** jtomasek has joined #openstack-mistral | 10:00 | |
| *** bobh has joined #openstack-mistral | 10:00 | |
| *** jtomasek has quit IRC | 10:01 | |
| d0ugal | ykarel: Hard to tell, but I don't think it is a bug in the code. Just in the test. | 10:01 |
| openstackgerrit | Merged openstack/python-mistralclient master: Remove setup.py check from pep8 job https://review.openstack.org/614287 | 10:01 |
| d0ugal | The test assumes an order but doesn't apply one | 10:01 |
| d0ugal | I guess it could be related to the sorting changes in dicts for example. | 10:01 |
| *** bobh has quit IRC | 10:02 | |
| openstackgerrit | Merged openstack/python-mistralclient master: Update min tox version to 2.0 https://review.openstack.org/612118 | 10:03 |
| ykarel | d0ugal, ack Thanks | 10:03 |
| openstackgerrit | Merged openstack/mistral master: Remove setup.py check from pep8 job https://review.openstack.org/614254 | 10:05 |
| openstackgerrit | Merged openstack/mistral master: Update min tox version to 2.0 https://review.openstack.org/614999 | 10:05 |
| ykarel | d0ugal, i tried ur patch but it didn't worked | 10:35 |
| d0ugal | ykarel: Interesting. Same error? | 10:36 |
| ykarel | d0ugal, yes | 10:36 |
| d0ugal | okay, I'll look again | 10:36 |
| ykarel | d0ugal, instead of action_names.sort(), created_acts.sort() worked | 10:36 |
| ykarel | so the initial paste i shared the order differs in response of create | 10:37 |
| ykarel | http://paste.openstack.org/show/734744/, vs http://paste.openstack.org/show/734743/ | 10:37 |
| d0ugal | ykarel: Yeah, I know | 10:41 |
| d0ugal | ykarel: but that is fine. They have the same created at, so it's just a race condition really - either could be first | 10:41 |
| ykarel | d0ugal, ack so will u update patch to do created_acts.sort()? | 10:42 |
| ykarel | as at the end lists are compared | 10:43 |
| ykarel | self.assertListEqual(created_acts, action_names) | 10:43 |
| *** shardy has joined #openstack-mistral | 10:43 | |
| d0ugal | ah, I see | 10:44 |
| d0ugal | I sorted the same one twice | 10:44 |
| d0ugal | oops | 10:44 |
| ykarel | yes | 10:44 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-tempest-plugin master: Add sorting to the "in list filter" test https://review.openstack.org/617547 | 10:45 |
| d0ugal | ykarel: Can you let me know if that works? ^ | 10:45 |
| ykarel | i tried similar and it worked but will try exact ^^ | 10:46 |
| d0ugal | Thanks | 10:46 |
| ykarel | d0ugal, local test passed for me | 10:48 |
| ykarel | Thanks | 10:48 |
| d0ugal | Great, thank you for the help! | 10:48 |
| openstackgerrit | Merged openstack/mistral master: Increment versioning with pbr instruction https://review.openstack.org/610553 | 10:48 |
| openstackgerrit | Merged openstack/mistral-tempest-plugin master: Add python 3.6 unit test job https://review.openstack.org/616731 | 10:48 |
| *** apetrich has joined #openstack-mistral | 11:02 | |
| *** shardy has quit IRC | 11:24 | |
| *** apetrich has quit IRC | 11:26 | |
| *** ykarel_ has joined #openstack-mistral | 11:30 | |
| *** ykarel has quit IRC | 11:33 | |
| *** ykarel_ is now known as ykarel | 11:45 | |
| *** bobh has joined #openstack-mistral | 12:22 | |
| bobh | d0ugal: rakhmerov - can you take a look at https://review.openstack.org/#/c/554950/14 when you get a chance? | 12:23 |
| *** apetrich has joined #openstack-mistral | 12:29 | |
| *** bobh has quit IRC | 12:44 | |
| *** apetrich has quit IRC | 12:47 | |
| *** ykarel_ has joined #openstack-mistral | 12:59 | |
| *** bobh has joined #openstack-mistral | 12:59 | |
| *** ykarel has quit IRC | 13:02 | |
| *** ykarel_ is now known as ykarel | 13:05 | |
| *** bobh has quit IRC | 13:29 | |
| *** bobh has joined #openstack-mistral | 13:34 | |
| *** apetrich has joined #openstack-mistral | 13:38 | |
| therve | bobh: It should really be 10 patches | 13:45 |
| bobh | therve: I agree - it started small and grew to be much bigger than I originally planned | 13:46 |
| bobh | therve: I can refactor into smaller patchsets if needed | 13:48 |
| therve | bobh: Not a core, so my opinion has little value :). Also I probably won't have time to review either way, just thought I'll mention it | 13:49 |
| bobh | therve: not little, just relative :-) | 13:49 |
| bobh | d0ugal: thanks for the feedback Any thoughts on https://bugs.launchpad.net/mistral/+bug/1800322 ? | 13:59 |
| openstack | Launchpad bug 1800322 in Mistral "ActionExecution task_name field cannot be used in a fields= query parameter" [Undecided,New] | 13:59 |
| *** toure is now known as toure|biab | 14:00 | |
| *** apetrich has quit IRC | 14:06 | |
| *** bobh has quit IRC | 14:10 | |
| *** toure|biab is now known as toure | 14:19 | |
| *** bobh has joined #openstack-mistral | 14:22 | |
| *** bobh has quit IRC | 14:25 | |
| *** ykarel has quit IRC | 14:38 | |
| *** ykarel has joined #openstack-mistral | 14:39 | |
| *** bobh has joined #openstack-mistral | 14:40 | |
| *** ykarel_ has joined #openstack-mistral | 14:41 | |
| *** ykarel has quit IRC | 14:44 | |
| *** hardikjasani has quit IRC | 14:47 | |
| *** ykarel__ has joined #openstack-mistral | 14:52 | |
| *** ykarel_ has quit IRC | 14:55 | |
| *** jistr is now known as jistr|mtg | 14:57 | |
| *** ykarel__ is now known as ykarel | 15:03 | |
| *** ykarel is now known as ykarel|away | 15:05 | |
| *** bobh has quit IRC | 15:23 | |
| *** akovi has quit IRC | 15:24 | |
| *** apetrich has joined #openstack-mistral | 15:27 | |
| *** apetrich has quit IRC | 15:35 | |
| *** jistr|mtg is now known as jistr | 15:59 | |
| *** gkadam has quit IRC | 16:23 | |
| *** ykarel_ has joined #openstack-mistral | 16:27 | |
| *** ykarel|away has quit IRC | 16:30 | |
| *** irclogbot_1 has joined #openstack-mistral | 16:42 | |
| *** irclogbot_1 has quit IRC | 16:43 | |
| *** d0ugal has quit IRC | 16:57 | |
| *** bobh has joined #openstack-mistral | 17:28 | |
| *** ykarel_ is now known as ykarel|pto | 17:36 | |
| *** apetrich has joined #openstack-mistral | 17:41 | |
| *** jtomasek has joined #openstack-mistral | 17:41 | |
| *** jtomasek has quit IRC | 17:51 | |
| openstackgerrit | Bob Haddleton proposed openstack/python-mistralclient master: Provide consistent options and return latest execution entries https://review.openstack.org/554950 | 17:52 |
| *** ykarel|pto has quit IRC | 17:59 | |
| *** toure is now known as toure|food | 18:10 | |
| *** apetrich has quit IRC | 18:11 | |
| *** apetrich has joined #openstack-mistral | 18:11 | |
| *** bobh has quit IRC | 18:29 | |
| *** toure|food is now known as toure | 18:51 | |
| *** bobh has joined #openstack-mistral | 19:08 | |
| *** bobh has quit IRC | 19:08 | |
| *** bobh has joined #openstack-mistral | 19:11 | |
| *** irclogbot_1 has joined #openstack-mistral | 19:12 | |
| *** apetrich has quit IRC | 19:36 | |
| *** apetrich has joined #openstack-mistral | 19:49 | |
| *** bobh has quit IRC | 20:08 | |
| *** irclogbot_1 has quit IRC | 20:09 | |
| *** bobh has joined #openstack-mistral | 20:12 | |
| *** bobh has quit IRC | 20:12 | |
| *** bobh has joined #openstack-mistral | 20:13 | |
| *** irclogbot_1 has joined #openstack-mistral | 20:14 | |
| *** d0ugal has joined #openstack-mistral | 21:23 | |
| *** d0ugal has quit IRC | 21:24 | |
| *** d0ugal has joined #openstack-mistral | 21:24 | |
| *** bobh has quit IRC | 21:24 | |
| *** jtomasek has joined #openstack-mistral | 21:49 | |
| *** jtomasek has quit IRC | 21:50 | |
| *** toure is now known as toure|gone | 22:33 | |
| *** nguyenhai93 has joined #openstack-mistral | 22:36 | |
| *** nguyenhai_ has quit IRC | 22:40 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!