*** hardikjasani has joined #openstack-mistral | 04:26 | |
*** openstackgerrit has quit IRC | 04:52 | |
*** d0ugal has quit IRC | 04:52 | |
*** openstackgerrit has joined #openstack-mistral | 04:57 | |
*** d0ugal has joined #openstack-mistral | 04:57 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 05:20 |
---|---|---|
*** jtomasek has joined #openstack-mistral | 05:45 | |
*** pgaxatte has quit IRC | 06:21 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: change workflow completion logic https://review.openstack.org/607807 | 06:22 |
*** shardy has joined #openstack-mistral | 07:28 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add sqlalchemy.exc.OperationalError to the retry decorator https://review.openstack.org/608171 | 07:30 |
*** pgaxatte has joined #openstack-mistral | 07:36 | |
rakhmerov | hi, can anybody look at http://logs.openstack.org/71/608171/1/check/openstack-tox-py27/2cd5c83/job-output.txt.gz#_2018-10-05_07_41_46_803612 | 07:45 |
rakhmerov | it happens only on py27 | 07:45 |
rakhmerov | seems like some problem with dependencies but I can't understand what's wrong | 07:46 |
rakhmerov | this module exists | 07:46 |
rakhmerov | d0ugal: ^ | 07:47 |
rakhmerov | d0ugal: btw, I haven't seen apetrich for a while. Is he on vacation? | 07:47 |
therve | rakhmerov: Relative import. In mistral.db.utils you import "sqlalchemy", it thinks you try "mistral.db.sqlalchemy" | 08:02 |
d0ugal | #startmeeting | 08:02 |
openstack | d0ugal: Error: Can't start another meeting, one is in progress. Use #endmeeting first. | 08:02 |
d0ugal | #startmeeting mistral | 08:02 |
openstack | d0ugal: Error: Can't start another meeting, one is in progress. Use #endmeeting first. | 08:02 |
d0ugal | oops! | 08:03 |
d0ugal | #endmeeting | 08:03 |
*** openstack changes topic to "Mistral the Workflow Service for OpenStack. https://docs.openstack.org/mistral/latest/" | 08:03 | |
openstack | Meeting ended Fri Oct 5 08:03:37 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 08:03 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-10-01-15.00.html | 08:03 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-10-01-15.00.txt | 08:03 |
openstack | Log: http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-10-01-15.00.log.html | 08:03 |
d0ugal | How long has that been running... | 08:03 |
d0ugal | #startmeeting mistral | 08:03 |
openstack | Meeting started Fri Oct 5 08:03:46 2018 UTC and is due to finish in 60 minutes. The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:03 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:03 |
*** openstack changes topic to " (Meeting topic: mistral)" | 08:03 | |
openstack | The meeting name has been set to 'mistral' | 08:03 |
d0ugal | Morning everyone! It's the Friday office hour. | 08:03 |
d0ugal | ^ rakhmerov, apetrich, bobh, mcdoker181818, akovi, hardikjasani | 08:04 |
d0ugal | rakhmerov: apetrich is on vacation this week - he is finally moving into a flat in Berlin. He has some trouble with his move which has taken up lots of his time lately | 08:04 |
rakhmerov | hey | 08:05 |
rakhmerov | ok | 08:05 |
rakhmerov | therve: not sure I understand.. Why does it think I try "mistral.db.sqlalchemy" ? | 08:06 |
d0ugal | rakhmerov: because python 2 does relative imports by default | 08:06 |
rakhmerov | having a hard time to understand really.. | 08:06 |
d0ugal | rakhmerov: I guess you must be importing from mistral.db.something? | 08:06 |
rakhmerov | aah... | 08:06 |
rakhmerov | gosh | 08:07 |
rakhmerov | so what is the right way? | 08:07 |
d0ugal | Looking at the patch... | 08:07 |
d0ugal | rakhmerov: from __future__ import absolute_imports | 08:08 |
d0ugal | rakhmerov: from __future__ import absolute_import | 08:08 |
d0ugal | https://www.python.org/dev/peps/pep-0328/ | 08:09 |
rakhmerov | what's this? :) | 08:09 |
d0ugal | If you want more details | 08:09 |
rakhmerov | ok, I'll read it | 08:09 |
rakhmerov | thanks a lot | 08:09 |
d0ugal | rakhmerov: That will make the importing behaviour like it is in Python 3 - absolute by default | 08:09 |
d0ugal | You don't really need to read it :) | 08:09 |
rakhmerov | interesting.. | 08:10 |
d0ugal | but basically, that means "sqlalchemy" will only ever be the top level package and not one relative to your location | 08:10 |
rakhmerov | I feel very uneducated now ) | 08:10 |
d0ugal | lol | 08:10 |
d0ugal | I guess you have been lucky to not hit this before :) | 08:10 |
rakhmerov | yes, that's why I'm so confused | 08:11 |
rakhmerov | so where do you think I need to insert this thing? | 08:11 |
d0ugal | rakhmerov: at the top of the utils.py | 08:11 |
rakhmerov | somewhere in the initialization of the application? | 08:11 |
rakhmerov | ooh, the module where I do import? | 08:11 |
rakhmerov | ok | 08:11 |
d0ugal | I added a comment :) | 08:12 |
rakhmerov | ok | 08:12 |
rakhmerov | thanks | 08:12 |
d0ugal | It's a file specific change, it doesn't impact anywhere else | 08:12 |
rakhmerov | ooh, funny :) | 08:12 |
rakhmerov | "HERE" :)) | 08:12 |
d0ugal | lol | 08:12 |
d0ugal | Like other __future__ imports it needs to happen before any other import | 08:12 |
rakhmerov | d0ugal: I'm ready to discuss anything else | 08:14 |
d0ugal | rakhmerov: Great, I'm not sure I have anything specific | 08:14 |
d0ugal | I have just been catching up this week | 08:14 |
therve | rakhmerov: Or __import__("sqlalchemy") | 08:14 |
rakhmerov | ok | 08:14 |
d0ugal | therve: ugly :) | 08:14 |
rakhmerov | therve: ok | 08:14 |
therve | Meh :) | 08:14 |
rakhmerov | ok, anyway, thanks to both :) | 08:15 |
rakhmerov | d0ugal: just FYI, working on https://review.openstack.org/607807. Very good change. But I'll have to postpone it for now and get back to it slightly later. | 08:16 |
rakhmerov | d0ugal: my goal is now to fix "join" logic because it's very very slow on some use cases | 08:16 |
d0ugal | rakhmerov: sounds good, I'll take a look at that change | 08:22 |
d0ugal | We have no new bugs this week :) | 08:27 |
rakhmerov | d0ugal: I created one today but assigned it to myself immediately | 08:28 |
d0ugal | oh, good | 08:28 |
d0ugal | I did mean "untriaged" bugs | 08:28 |
rakhmerov | https://bugs.launchpad.net/mistral/+bug/1796242 | 08:29 |
openstack | Launchpad bug 1796242 in Mistral "Retry DB transactions on sqlalchemy.exc.OperationalError" [High,In progress] - Assigned to Renat Akhmerov (rakhmerov) | 08:29 |
rakhmerov | yep | 08:29 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add sqlalchemy.exc.OperationalError to the retry decorator https://review.openstack.org/608171 | 08:29 |
rakhmerov | d0ugal: also one thing, we need to do something to make CI more stable | 08:29 |
rakhmerov | it's painful now to push patches through | 08:29 |
rakhmerov | d0ugal: please also review https://review.openstack.org/#/c/603593/, very small | 08:30 |
d0ugal | will do! | 08:30 |
rakhmerov | ok | 08:31 |
d0ugal | Is it the mysql and rally CI jobs that fail most? | 08:31 |
d0ugal | or something else? | 08:31 |
d0ugal | oh, I see a tripleo failure on one... | 08:32 |
rakhmerov | yeah :) | 08:32 |
rakhmerov | rally too, yes | 08:32 |
rakhmerov | another thing: https://review.openstack.org/#/c/607974/ | 08:32 |
rakhmerov | POST_FAILURE on devstack-kombu | 08:32 |
d0ugal | I never understand the POST_FAILURE result | 08:33 |
rakhmerov | it seems kind of sporadic | 08:33 |
rakhmerov | here and there pretty often | 08:33 |
rakhmerov | maybe there's a general issue with the CI infra | 08:33 |
rakhmerov | dunno | 08:33 |
d0ugal | The tripleo failure I see on thrash|g0ne's patch seems legit | 08:35 |
d0ugal | actually, I'm not sure now | 08:35 |
d0ugal | I wish these logs were earlier to read. | 08:35 |
d0ugal | http://zuul.openstack.org/builds.html?project=openstack%2Fmistral | 08:36 |
d0ugal | The failures do indeed seem sporadic | 08:37 |
d0ugal | Lots of failures on different jobs. | 08:37 |
rakhmerov | yes | 08:39 |
*** gkadam has joined #openstack-mistral | 09:43 | |
d0ugal | #endmeeting | 10:04 |
*** openstack changes topic to "Mistral the Workflow Service for OpenStack. https://docs.openstack.org/mistral/latest/" | 10:04 | |
openstack | Meeting ended Fri Oct 5 10:04:00 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 10:04 |
d0ugal | oops :) | 10:04 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-10-05-08.03.html | 10:04 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-10-05-08.03.txt | 10:04 |
openstack | Log: http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-10-05-08.03.log.html | 10:04 |
*** jtomasek has quit IRC | 10:43 | |
*** jtomasek has joined #openstack-mistral | 11:07 | |
*** jtomasek has quit IRC | 11:48 | |
*** jtomasek has joined #openstack-mistral | 12:00 | |
*** jtomasek has quit IRC | 12:01 | |
*** jtomasek has joined #openstack-mistral | 12:01 | |
*** hardikjasani has quit IRC | 12:36 | |
*** toure|gone is now known as toure | 13:05 | |
*** rbrady has joined #openstack-mistral | 14:59 | |
*** mmethot_ has quit IRC | 15:08 | |
*** mmethot has joined #openstack-mistral | 15:10 | |
*** pgaxatte has quit IRC | 15:53 | |
*** gkadam has quit IRC | 16:21 | |
*** jtomasek has quit IRC | 16:21 | |
*** jtomasek has joined #openstack-mistral | 16:52 | |
*** shardy has quit IRC | 17:31 | |
*** toure is now known as toure|gone | 21:15 | |
*** bobh has joined #openstack-mistral | 21:23 | |
*** bobh has quit IRC | 22:04 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!