| *** bobh has joined #openstack-mistral | 01:32 | |
| *** apetrich has quit IRC | 02:09 | |
| *** bobh has quit IRC | 02:15 | |
| *** rbrady-afk has quit IRC | 02:45 | |
| *** gkadam has joined #openstack-mistral | 03:21 | |
| *** gkadam has quit IRC | 04:10 | |
| *** gkadam has joined #openstack-mistral | 04:10 | |
| *** bobh has joined #openstack-mistral | 04:12 | |
| *** bobh has quit IRC | 04:18 | |
| *** hardikjasani has joined #openstack-mistral | 04:41 | |
| *** apetrich has joined #openstack-mistral | 05:46 | |
| *** akovi has joined #openstack-mistral | 05:52 | |
| pgaxatte | d0ugal: I checked and stable/rocky was up-to-date in terms of migrations (rocky is at #29 and I want to backport #30) so it should be fine | 06:26 |
|---|---|---|
| pgaxatte | d0ugal: I just saw rakhmerov's answer on the change, if you need some context I can help. We have a large number of regions so if we enable too many regions for a customer, this bug prevents him to use mistral completely | 06:36 |
| rakhmerov | pgaxatte: I believe we can get approval from the stable branch team if we provide a good justification | 06:38 |
| pgaxatte | rakhmerov: I hope so :) | 06:38 |
| rakhmerov | :) | 06:38 |
| pgaxatte | I just realized how fast the catalog grows when you add a region, especially if you use long FQDN for the endpoints | 06:41 |
| pgaxatte | rakhmerov: a standard region for us (with neutron,heat-cfn,keystone,nova,mistral,glance,cinderv2,heat,swift,cinder endpoints) takes around 3kB in the catalog and I stripped the url and region name. So you have to add to that the size of each service URL x3 (admin, public and internal endpoints) and the (size of the region name) x (number of service) x 3 | 07:13 |
| pgaxatte | a single region takes ~5kB in the catalog for us | 07:13 |
| pgaxatte | a typical client has around 6 regions in his catalog (he can have more or less depending if asked support to have more or has an old project that had less...) | 07:15 |
| pgaxatte | that's about as much details as I can provide :D | 07:16 |
| pgaxatte | the service URL can get pretty as many of them also include the project ID | 07:17 |
| rakhmerov | yes, that's ok | 07:45 |
| rakhmerov | please write to the mailing list and explain briefly that it's very important for you in production | 07:46 |
| rakhmerov | etc. etc | 07:46 |
| mcdoker18 | Hi, are there any ideas about how we should test the ssh action properly? https://review.openstack.org/#/c/599862/ | 07:53 |
| hardikjasani | mcdocker18: I've been thinking about it. Apart from mocking (which is of no use), there seems to be no way to have meaningful unit test. | 07:55 |
| hardikjasani | Isn't run_test.sh run only in functional-tests? | 07:55 |
| mcdoker18 | hardikjasani: Yes, you are right :( | 07:58 |
| *** jaosorior has quit IRC | 08:03 | |
| *** jaosorior has joined #openstack-mistral | 08:05 | |
| rakhmerov | hardikjasani: run_test.sh yes, as far as I know. It used to be used at least in functional tests | 08:17 |
| *** gkadam_ has joined #openstack-mistral | 08:23 | |
| *** gkadam has quit IRC | 08:27 | |
| pgaxatte | rakhmerov: I'm writing the email to openstack-dev to ask for permission. We need approval from whom exactly to cherry pick the migration? | 09:22 |
| rakhmerov | from the stable branch team | 09:22 |
| rakhmerov | I guess that's how they're called | 09:22 |
| pgaxatte | ok. I cited your name in the email saying you advised me to ask there for permission, is this ok? | 09:24 |
| pgaxatte | rakhmerov ^ | 09:25 |
| rakhmerov | pgaxatte: sure, no problem | 09:25 |
| pgaxatte | rakhmerov: great, email sent | 09:27 |
| rakhmerov | 👍 | 09:27 |
| rakhmerov | thumbs up | 09:27 |
| rakhmerov | Unicode: U+1F44D, UTF-8: F0 9F 91 8D | 09:27 |
| rakhmerov | oops... some redundant info was printed ) | 09:27 |
| d0ugal | lol | 09:29 |
| d0ugal | rakhmerov: I like my emoji to come with additional metadata :-D | 09:30 |
| rakhmerov | yeah | 09:32 |
| rakhmerov | so that people know how to reproduce them ) | 09:32 |
| pgaxatte | rakhmerov: nice :) | 09:40 |
| d0ugal | pgaxatte: I guess a release note would be a good addition. | 09:44 |
| d0ugal | Just to let operators know that a migration needs to run. | 09:44 |
| pgaxatte | d0ugal: oh yeah good catch but can I add it to the cherry pick itself? | 09:45 |
| d0ugal | pgaxatte: You would need to add it to master first, and then backport it. | 09:45 |
| pgaxatte | or should I do another change and cherry pick it to stable/rocky after? | 09:45 |
| pgaxatte | ok | 09:46 |
| pgaxatte | thought so | 09:46 |
| d0ugal | If you like, you can squash the backport into one commit - but I don't mind much about that. | 09:46 |
| pgaxatte | d0ugal: I don't know how to do that | 09:46 |
| d0ugal | pgaxatte: don't worry, just do it as two commits :) | 09:46 |
| pgaxatte | alright :) | 09:47 |
| d0ugal | I can show you if you are cuious | 09:47 |
| d0ugal | curious | 09:47 |
| pgaxatte | d0ugal: yeah sure because I don't see if this is more on git side or on gerrit | 09:56 |
| d0ugal | pgaxatte: The git side | 09:56 |
| pgaxatte | so it's like a cherry pick of two commit in a new branch that are squashed togeter? | 09:57 |
| d0ugal | pgaxatte: yup | 09:57 |
| pgaxatte | d0ugal: sounds dangerous :D | 09:57 |
| d0ugal | pgaxatte: Once you have both commits, you can use "git rebase HEAD~2" and then change "pick" to "squash" on the second commit | 09:57 |
| d0ugal | oops | 09:58 |
| d0ugal | That should be "git rebase HEAD~2 -i" | 09:58 |
| d0ugal | without "-i" it wont do anything | 09:58 |
| pgaxatte | yeah to have the interactive selection | 09:58 |
| d0ugal | yup | 09:58 |
| pgaxatte | but I still need to create a new change for the release note anyway right ? | 09:59 |
| d0ugal | pgaxatte: but if you are happier doing it as two commits, please do that :) | 09:59 |
| d0ugal | pgaxatte: Yeah, you do | 09:59 |
| d0ugal | pgaxatte: we need two commits in master because the first merged already | 09:59 |
| *** mcdoker18 has quit IRC | 10:00 | |
| pgaxatte | d0ugal: ok I thought there would some gerrit magic in all this but no this is entirely a git manoeuvre. I'll stick to the separate commits :D | 10:01 |
| d0ugal | :) | 10:01 |
| *** zigo has joined #openstack-mistral | 10:03 | |
| *** zigo has quit IRC | 11:45 | |
| *** gkadam_ has quit IRC | 11:54 | |
| openstackgerrit | Adriano Petrich proposed openstack/mistral master: Remove extra information from std.ssh action https://review.openstack.org/599363 | 12:01 |
| openstackgerrit | Pierre Gaxatte proposed openstack/mistral master: Add release note for auth_context bugfix https://review.openstack.org/600018 | 12:14 |
| pgaxatte | d0ugal, rakhmerov: the release note for the auth_context bugfix: https://review.openstack.org/600018 | 12:15 |
| pgaxatte | not sure if it needs an upgrade section or if the migration instructions should be elsewhere | 12:16 |
| d0ugal | pgaxatte: I think that looks good, thanks! | 12:19 |
| openstackgerrit | Andras Kovi proposed openstack/mistral master: Remove extra information from std.ssh action https://review.openstack.org/599363 | 12:40 |
| *** toure|gone is now known as toure | 13:04 | |
| *** hardikjasani has quit IRC | 13:18 | |
| openstackgerrit | Merged openstack/mistral master: Minor bug of _assert_multiple_items function https://review.openstack.org/599296 | 13:38 |
| *** akovi has quit IRC | 13:55 | |
| *** d0ugal has quit IRC | 13:58 | |
| *** jaosorior has quit IRC | 14:06 | |
| *** jtomasek has quit IRC | 14:15 | |
| *** d0ugal has joined #openstack-mistral | 14:57 | |
| *** bobh has joined #openstack-mistral | 14:58 | |
| *** jtomasek has joined #openstack-mistral | 15:14 | |
| *** bobh has quit IRC | 15:38 | |
| *** bobh has joined #openstack-mistral | 15:56 | |
| *** jaosorior has joined #openstack-mistral | 15:57 | |
| *** bobh has quit IRC | 16:19 | |
| *** shardy has quit IRC | 16:28 | |
| *** bobh has joined #openstack-mistral | 16:35 | |
| *** thrash is now known as thrash|biab | 16:35 | |
| *** openstackgerrit has quit IRC | 18:00 | |
| *** thrash|biab is now known as thrash | 18:01 | |
| *** d0ugal has quit IRC | 18:10 | |
| *** jtomasek has quit IRC | 19:04 | |
| *** bobh has quit IRC | 20:44 | |
| *** bobh has joined #openstack-mistral | 20:44 | |
| *** bobh has quit IRC | 21:03 | |
| *** bobh has joined #openstack-mistral | 21:43 | |
| *** toure is now known as toure|gone | 21:53 | |
| *** bobh has quit IRC | 22:06 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!