| *** livelace has quit IRC | 00:43 | |
| *** livelace has joined #openstack-mistral | 00:43 | |
| *** apetrich has quit IRC | 02:27 | |
| *** hardikjasani has joined #openstack-mistral | 04:53 | |
| openstackgerrit | Nguyen Hai proposed openstack/mistral stable/rocky: import zuul job settings from project-config https://review.openstack.org/593259 | 05:34 |
|---|---|---|
| openstackgerrit | Nguyen Hai proposed openstack/mistral master: import zuul job settings from project-config https://review.openstack.org/593232 | 05:34 |
| *** jaosorior has quit IRC | 05:45 | |
| *** jaosorior has joined #openstack-mistral | 05:47 | |
| *** jtomasek has joined #openstack-mistral | 07:24 | |
| *** gkadam has joined #openstack-mistral | 07:25 | |
| *** jtomasek has quit IRC | 07:33 | |
| *** jtomasek has joined #openstack-mistral | 07:33 | |
| *** shardy has joined #openstack-mistral | 08:00 | |
| *** shardy has quit IRC | 08:43 | |
| *** shardy has joined #openstack-mistral | 08:44 | |
| *** akovi has joined #openstack-mistral | 08:54 | |
| *** apetrich has joined #openstack-mistral | 09:23 | |
| *** pdr_ has quit IRC | 09:58 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: switch documentation job to new PTI https://review.openstack.org/593233 | 11:20 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: add python 3.6 unit test job https://review.openstack.org/593234 | 11:20 |
| openstackgerrit | Nguyen Hai proposed openstack/mistral stable/rocky: import zuul job settings from project-config https://review.openstack.org/593259 | 11:45 |
| openstackgerrit | Nguyen Hai proposed openstack/mistral master: import zuul job settings from project-config https://review.openstack.org/593232 | 11:45 |
| openstackgerrit | Nguyen Hai proposed openstack/mistral master: add python 3.6 unit test job https://review.openstack.org/593234 | 11:46 |
| openstackgerrit | Nguyen Hai proposed openstack/mistral master: switch documentation job to new PTI https://review.openstack.org/593233 | 11:46 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Remove -u root as mysql is executed with root user https://review.openstack.org/593400 | 11:47 |
| openstackgerrit | Merged openstack/python-mistralclient stable/rocky: import zuul job settings from project-config https://review.openstack.org/593263 | 11:59 |
| *** thrash|g0ne is now known as thrash | 12:18 | |
| *** josecastroleon has joined #openstack-mistral | 13:05 | |
| *** s10 has joined #openstack-mistral | 13:08 | |
| s10 | Please confirm bug https://bugs.launchpad.net/mistral/+bug/1788174 | 13:09 |
| openstack | Launchpad bug 1788174 in Mistral "Mistral uses deprecated option keystone_authtoken/auth_uri for keystoneclient creation" [Undecided,New] | 13:09 |
| *** rbrady has joined #openstack-mistral | 13:25 | |
| *** apetrich has quit IRC | 13:33 | |
| d0ugal | thrash: I feel like we had a change related to ^ recently, do you know what I am thinking of? | 13:44 |
| thrash | d0ugal: if nothing else, the patch that started moving away from keystone_authtoken. | 13:45 |
| d0ugal | hmm | 13:47 |
| d0ugal | Not sure | 13:47 |
| d0ugal | Anyway, seems like something we need to sort out! | 13:47 |
| thrash | d0ugal: yes. I'll take a look. | 13:47 |
| d0ugal | oh, thanks :) | 13:47 |
| d0ugal | rakhmerov: https://review.openstack.org/#/c/592945/ | 13:52 |
| rakhmerov | d0ugal: ok | 13:54 |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Stop using deprecated keystone_authtoken/auth_uri https://review.openstack.org/594187 | 14:02 |
| rakhmerov | d0ugal: actually bool("False") returns True :) | 14:03 |
| *** hardikjasani has quit IRC | 14:03 | |
| akovi | rakhmerov: yeah, that's a bummer :) the client code does not change, though, as the param is not passed at all if false | 14:06 |
| rakhmerov | yes | 14:08 |
| d0ugal | rakhmerov: Yeah, I get that. Any non-empty string is True. | 14:10 |
| d0ugal | but I don't want to start checking the string contents, do I? | 14:11 |
| d0ugal | I guess I can do | 14:11 |
| d0ugal | actually, yeah, it makes more sense | 14:11 |
| d0ugal | I think I miss-understood our original conversation. | 14:12 |
| d0ugal | so I think we should just accept either "True" or "False" and error on anything else | 14:12 |
| akovi | can we handle this parameter rather the way it is in the client: if present, True, False otherwise | 14:12 |
| d0ugal | akovi: That is essentially what we do now, right? | 14:13 |
| d0ugal | If it is present and a non-empty string it is True | 14:13 |
| akovi | yes, the client does not add the parameter to the request unless it is true | 14:13 |
| rakhmerov | d0ugal: yeah, I remember I agreed with bool() but I guess I wasn't too careful | 14:13 |
| rakhmerov | akovi: you're talking about our client, right? | 14:14 |
| akovi | if we go for "False", then accept only that | 14:14 |
| akovi | yes | 14:14 |
| rakhmerov | ok | 14:14 |
| akovi | everything else should be error | 14:14 |
| rakhmerov | I can assume another client (this is REST after all) that will be passing "False" | 14:15 |
| akovi | sorry, "True" + "False" | 14:15 |
| d0ugal | so - "True", "False" or exception? | 14:15 |
| akovi | yes | 14:15 |
| rakhmerov | I'd say yes | 14:15 |
| rakhmerov | or lower case may be | 14:15 |
| d0ugal | haha | 14:15 |
| rakhmerov | :))) | 14:15 |
| akovi | nonono | 14:16 |
| d0ugal | I'd be okay with lowercasing it | 14:16 |
| d0ugal | Alright | 14:16 |
| d0ugal | I wont | 14:16 |
| akovi | make is as simple as possible | 14:16 |
| akovi | the more restrictive, the easier to document | 14:16 |
| d0ugal | Yeah, lets keep it strict and see if somebody complains later | 14:16 |
| rakhmerov | щл | 14:16 |
| rakhmerov | ok | 14:16 |
| d0ugal | Thanks! | 14:17 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Explicitly convert X-Target-Insecure to a boolean https://review.openstack.org/592945 | 14:25 |
| *** s10 has quit IRC | 15:18 | |
| *** akovi has quit IRC | 15:26 | |
| *** jtomasek_ has joined #openstack-mistral | 16:25 | |
| *** jtomasek has quit IRC | 16:26 | |
| *** s10 has joined #openstack-mistral | 16:39 | |
| *** s10 has quit IRC | 16:46 | |
| *** rbrady is now known as rbrady-afk | 16:56 | |
| *** shardy has quit IRC | 16:57 | |
| *** portdirect has quit IRC | 17:54 | |
| *** apetrich has joined #openstack-mistral | 18:02 | |
| *** thrash has quit IRC | 18:37 | |
| *** thrash has joined #openstack-mistral | 18:41 | |
| *** hrybacki has quit IRC | 18:42 | |
| *** doriftoshoes____ has quit IRC | 18:42 | |
| *** therve has quit IRC | 18:42 | |
| *** jrist has quit IRC | 18:46 | |
| *** rbrady-afk is now known as rbrady | 19:21 | |
| *** igormarnat has quit IRC | 19:34 | |
| *** jenner_ has quit IRC | 19:34 | |
| *** jenner has joined #openstack-mistral | 19:37 | |
| *** jistr|off has quit IRC | 19:39 | |
| *** jistr has joined #openstack-mistral | 19:47 | |
| *** jaosorior_ has joined #openstack-mistral | 20:14 | |
| *** jaosorior has quit IRC | 20:17 | |
| *** gkadam has quit IRC | 20:27 | |
| *** gkadam has joined #openstack-mistral | 20:43 | |
| *** harlowja has joined #openstack-mistral | 21:02 | |
| *** thrash is now known as thrash|g0ne | 21:07 | |
| *** gkadam has quit IRC | 21:26 | |
| *** jtomasek_ has quit IRC | 22:47 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!