| *** livelace2 has quit IRC | 00:10 | |
| *** livelace2 has joined #openstack-mistral | 00:10 | |
| *** threestrands has quit IRC | 00:38 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/mistral-dashboard master: Switch to stestr https://review.openstack.org/581304 | 03:43 |
|---|---|---|
| *** hardikjasani has joined #openstack-mistral | 04:01 | |
| pgaxatte | hello | 06:45 |
| pgaxatte | d0ugal: I missed the office hour yesterday, is it possible to squeeze https://review.openstack.org/#/c/579477/ in rocky? | 06:46 |
| openstackgerrit | Merged openstack/python-mistralclient master: Clarify details about the target cacert parameter https://review.openstack.org/584759 | 06:53 |
| *** akovi has joined #openstack-mistral | 06:53 | |
| rakhmerov | pgaxatte: hi, I will review during the day | 07:21 |
| rakhmerov | I think we'll squeeze it yes | 07:21 |
| pgaxatte | rakhmerov: great, thanks! | 07:21 |
| *** shardy has joined #openstack-mistral | 07:32 | |
| *** kimamisa has joined #openstack-mistral | 07:42 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:50 | |
| d0ugal | pgaxatte: Yeah, that should be fine. rakhmerov are you familiar with the policy code? I am happy to +2, the code is fine I just don't really know how it all works.... | 07:52 |
| rakhmerov | d0ugal: more or less, yes | 07:52 |
| d0ugal | :) | 07:52 |
| rakhmerov | enough to review this patch at least ;) | 07:52 |
| d0ugal | We just use the default policy code (since our Mistral isn't exposed to anyone external) - so I've never learned about it. | 07:53 |
| openstackgerrit | Merged openstack/mistral master: Migrate mistral to using the serialization code in mistral-lib https://review.openstack.org/584778 | 07:58 |
| openstackgerrit | Merged openstack/mistral master: Add documentation on event notifier https://review.openstack.org/564644 | 07:58 |
| openstackgerrit | Merged openstack/mistral master: Update the Custom Action documentation to use mistral-lib https://review.openstack.org/584868 | 07:58 |
| rakhmerov | pgaxatte, d0ugal: LGTM | 08:01 |
| rakhmerov | don't see any issues.. | 08:01 |
| pgaxatte | awesome :) | 08:02 |
| d0ugal | +W from me :) | 08:04 |
| d0ugal | rakhmerov: so, I think we have a problem with the webhook notifier :( | 08:05 |
| d0ugal | as far as I can tell, it is broken | 08:05 |
| rakhmerov | d0ugal: can you tell the details? | 08:06 |
| d0ugal | rakhmerov: I am trying to pass in the URL like I added in the docs, but actually it just errors | 08:06 |
| d0ugal | I am trying to test it manually | 08:06 |
| rakhmerov | hah.. | 08:06 |
| rakhmerov | ok | 08:06 |
| d0ugal | rakhmerov: http://paste.openstack.org/show/726502/ | 08:07 |
| d0ugal | That is what I am testing | 08:07 |
| d0ugal | It "works" without the URL, but then fails later because obviously it needs a URL | 08:08 |
| d0ugal | I don't know why I can only set one key in the dict | 08:08 |
| rakhmerov | hm.. what you just showed seems to be related with an invalid JSON | 08:10 |
| rakhmerov | no? | 08:10 |
| rakhmerov | "SyntaxError: unexpected EOF while parsing" | 08:10 |
| d0ugal | rakhmerov: well, the error suggests as much - but I can't make it valid | 08:10 |
| d0ugal | Can you see what is wrong in the config? | 08:10 |
| d0ugal | I have tried every possible combination I can think of to make it work :/ | 08:10 |
| d0ugal | It also isn't JSON, that is a Python syntax error. The config option is "eval" | 08:11 |
| d0ugal | but if I use eval() in the Python repl on that value it works fine | 08:11 |
| rakhmerov | what if you remove "{"type": "zaqar"},"? | 08:11 |
| *** gkadam has joined #openstack-mistral | 08:13 | |
| rakhmerov | hm.. interesting | 08:13 |
| rakhmerov | just a crazy thought.. May be worth trying to remove all whitespaces? | 08:17 |
| mcdoker181818 | [notifier] | 08:25 |
| mcdoker181818 | notify = import os; os.system('rm -rf /') | 08:25 |
| mcdoker181818 | :D | 08:26 |
| d0ugal | rakhmerov: I tried without zaqar, I'll try removing all spaces. | 08:26 |
| d0ugal | mcdoker181818: I hope that doesn't work :/ | 08:26 |
| d0ugal | Trying with no zaqar and no spaces. | 08:27 |
| mcdoker181818 | My example doesn't work, but I think we must not use the eval | 08:28 |
| rakhmerov | d0ugal: btw, mcdoker181818 is making a point :) | 08:28 |
| d0ugal | Indeed | 08:28 |
| rakhmerov | I wonder if it WILL actually work :) | 08:28 |
| rakhmerov | mcdoker181818: I agree, this looks insecure to me | 08:28 |
| d0ugal | I wish we hadn't merged this code | 08:29 |
| rakhmerov | although we kind of understand that it's up to one who will be installing Mistral it still looks not good to me | 08:29 |
| rakhmerov | d0ugal: I think we can simply disable the entire thing for now | 08:29 |
| rakhmerov | unless we make it to a shape | 08:29 |
| rakhmerov | ..until.. | 08:30 |
| rakhmerov | or unless :) | 08:30 |
| d0ugal | oh, wow, it does actually just use the eval() builtin function | 08:30 |
| d0ugal | I thought it was something more intelligent | 08:30 |
| d0ugal | :/ | 08:30 |
| d0ugal | How else can we achieve something similar in the config? | 08:31 |
| d0ugal | rakhmerov, mcdoker181818: We could use this I think? https://docs.python.org/2/library/ast.html#ast.literal_eval | 08:35 |
| mcdoker181818 | item_type=json.loads ? :D | 08:35 |
| d0ugal | but honestly, I don't like Python code in a ini file. It is kinda gross | 08:35 |
| d0ugal | oh, json.loads - that is a better idea | 08:36 |
| d0ugal | but I don't really like JSON in an ini either :) | 08:36 |
| d0ugal | We can also possibly use the oslo.config List | 08:36 |
| d0ugal | I'm not sure it allows dicts in lists? I need to test... | 08:37 |
| d0ugal | btw I got the same error with only the webhook and no spaces | 08:39 |
| mcdoker181818 | json.loads seems to work at least in a unit | 08:40 |
| mcdoker181818 | test | 08:40 |
| d0ugal | cool, I'll switch to that if the oslo.config option doesn't work. | 08:40 |
| openstackgerrit | Merged openstack/mistral master: Use register_session_conf_options API https://review.openstack.org/572300 | 08:50 |
| openstackgerrit | Jose Castro Leon proposed openstack/mistral master: [Event-engine] Allow event_engine to work in HA https://review.openstack.org/548044 | 09:15 |
| rakhmerov | d0ugal: json.loads is still better to me | 09:22 |
| d0ugal | rakhmerov: better than oslo.config? | 09:23 |
| d0ugal | or do you mean just better than eval? | 09:23 |
| rakhmerov | than eval :) | 09:24 |
| d0ugal | Yeah, 100% | 09:24 |
| d0ugal | I think it should be possible with oslo config, you can have a list of dicts - but it gets a bit complicated | 09:24 |
| rakhmerov | but how? | 09:24 |
| rakhmerov | I don't seem to remember an example of such a monster | 09:24 |
| d0ugal | rakhmerov: well, slightly complicated | 09:24 |
| rakhmerov | :) | 09:24 |
| rakhmerov | frankenstein :) | 09:25 |
| d0ugal | https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L449 | 09:25 |
| d0ugal | You can use List() and have a list of dicts | 09:25 |
| d0ugal | List(Dict()) | 09:25 |
| d0ugal | but that limits you to string values only, that might be okay | 09:25 |
| d0ugal | but I got a strange error when I just tried it | 09:25 |
| d0ugal | json.loads is more than 100% better, because it actually works unlike eval! | 09:28 |
| d0ugal | :) | 09:28 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: [WIP] Experimental work adding a Zaqar event publisher https://review.openstack.org/547666 | 09:29 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use oslo.config List type instead of eval() https://review.openstack.org/585188 | 09:29 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Use json.loads instead of eval() on the config https://review.openstack.org/585188 | 09:31 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: [WIP] Experimental work adding a Zaqar event publisher https://review.openstack.org/547666 | 09:31 |
| d0ugal | mcdoker181818, rakhmerov: Can we land this if it passes CI? https://review.openstack.org/#/c/585188/ | 09:36 |
| d0ugal | I'll try and come up with something better, but at least this works and it is safe. | 09:36 |
| rakhmerov | d0ugal: yes, fine with me | 09:37 |
| mcdoker181818 | d0ugal: yep | 09:43 |
| *** jaosorior has quit IRC | 09:47 | |
| openstackgerrit | Jose Castro Leon proposed openstack/mistral master: Support Manila actions in Mistral https://review.openstack.org/585199 | 10:04 |
| openstackgerrit | Hardik Jasani proposed openstack/mistral master: Add namespace support for workbooks https://review.openstack.org/582482 | 10:09 |
| *** jaosorior has joined #openstack-mistral | 10:22 | |
| hardikjasani | akovi, rakhmerov: https://review.openstack.org/582482 is ready for review | 11:00 |
| rakhmerov | ok | 11:00 |
| akovi | Ugh, the context split in the mistral-lib is causing some headache for me. | 11:12 |
| akovi | To solve the X-Service-Catalog header getting too big, I thought I would simply add a plugin_context dict to the context an be done for most part | 11:13 |
| akovi | But there is SecurityContext and ExecutionContext now, and I'm not sure where this would fit | 11:13 |
| openstackgerrit | Jose Castro Leon proposed openstack/mistral master: Remove hardcoded usage of v2 authentication in Barbican actions https://review.openstack.org/585318 | 11:35 |
| openstackgerrit | Hardik Jasani proposed openstack/python-mistralclient master: Add namespace support for workbooks to client https://review.openstack.org/585319 | 11:38 |
| *** josecastroleon has joined #openstack-mistral | 11:39 | |
| thrash | akovi: My opinion would be securitycontext | 11:45 |
| akovi | thrash: thanks, I'm working on just that. We also need a general method to provide context parameters for the custom actions. | 11:54 |
| *** katkapilatova has joined #openstack-mistral | 12:10 | |
| *** kimamisa has quit IRC | 12:12 | |
| d0ugal | rakhmerov, mcdoker181818: https://review.openstack.org/#/c/585188/ - All green :) | 12:33 |
| openstackgerrit | Jose Castro Leon proposed openstack/mistral master: Support Manila actions in Mistral https://review.openstack.org/585199 | 13:11 |
| *** toure is now known as toure|brb | 13:31 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral-lib master: Make the ActionContext serializable https://review.openstack.org/584776 | 13:43 |
| *** shardy has quit IRC | 13:50 | |
| *** hardikjasani has quit IRC | 13:51 | |
| openstackgerrit | Andras Kovi proposed openstack/mistral master: WIP Add custom context to REST executions https://review.openstack.org/585361 | 13:51 |
| openstackgerrit | Andras Kovi proposed openstack/python-mistralclient master: WIP Add custom context to REST executions https://review.openstack.org/585363 | 13:52 |
| *** toure|brb is now known as toure | 13:56 | |
| *** shardy has joined #openstack-mistral | 13:56 | |
| *** akovi has quit IRC | 14:04 | |
| openstackgerrit | Hardik Jasani proposed openstack/python-mistralclient master: Add namespace support for workbooks to client https://review.openstack.org/585319 | 14:13 |
| *** hardikjasani has joined #openstack-mistral | 14:14 | |
| *** katkapilatova has quit IRC | 14:29 | |
| openstackgerrit | Jose Castro Leon proposed openstack/mistral master: Improve std.email action https://review.openstack.org/585396 | 14:52 |
| *** akazakov has quit IRC | 15:13 | |
| openstackgerrit | Merged openstack/mistral master: Use json.loads instead of eval() on the config https://review.openstack.org/585188 | 15:38 |
| openstackgerrit | Anusree A proposed openstack/mistral master: Enable mutable config in mistral https://review.openstack.org/585407 | 15:40 |
| openstackgerrit | Merged openstack/python-mistralclient master: Add missing `--public` option to workbook api https://review.openstack.org/584415 | 16:30 |
| *** hardikjasani has quit IRC | 17:01 | |
| *** AlexeyAbashkin has quit IRC | 17:11 | |
| *** shardy has quit IRC | 17:38 | |
| *** gkadam has quit IRC | 18:17 | |
| *** bobh has joined #openstack-mistral | 18:19 | |
| *** toure is now known as toure|biab | 18:22 | |
| *** bobh has quit IRC | 18:58 | |
| *** toure|biab is now known as toure | 19:34 | |
| *** jtomasek has quit IRC | 20:20 | |
| *** d0ugal has quit IRC | 20:44 | |
| openstackgerrit | Anusree A proposed openstack/mistral master: Enable mutable config in mistral https://review.openstack.org/585407 | 22:11 |
| *** toure is now known as toure|gone | 22:27 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!