| *** yangyapeng has joined #openstack-mistral | 01:15 | |
| *** bobh has joined #openstack-mistral | 01:26 | |
| *** pgaxatte has joined #openstack-mistral | 01:56 | |
| *** nguyenhai has joined #openstack-mistral | 01:59 | |
| *** bobh has quit IRC | 02:27 | |
| *** pgaxatte has quit IRC | 04:43 | |
| *** pgaxatte has joined #openstack-mistral | 05:01 | |
| *** hardikjasani has joined #openstack-mistral | 05:20 | |
| *** quiquell|off is now known as quiquell | 05:31 | |
| *** josecastroleon has joined #openstack-mistral | 06:10 | |
| *** pgaxatte has left #openstack-mistral | 06:17 | |
| *** quiquell is now known as quiquell|bbl | 06:35 | |
| *** pgaxatte has joined #openstack-mistral | 06:53 | |
| rakhmerov | apetrich: yeah, this all looks weird a little bit | 06:53 |
|---|---|---|
| rakhmerov | apetrich: I'd recommend to talk to Andras | 06:54 |
| rakhmerov | he's not in IRC unfortunately | 06:54 |
| rakhmerov | you can send him an email | 06:54 |
| rakhmerov | he knows this part well | 06:54 |
| pgaxatte | hello | 06:58 |
| pgaxatte | rakhmerov: I think I have something worth merging with https://review.openstack.org/#/c/579477/ | 06:58 |
| pgaxatte | I was thinking about refactoring the policy tests and covering all policies | 06:59 |
| rakhmerov | pgaxatte: hey | 07:00 |
| rakhmerov | ok | 07:00 |
| pgaxatte | but I should do this in a different change | 07:01 |
| pgaxatte | should I open a bug for this? | 07:02 |
| pgaxatte | rakhmerov: also I'd like to backport my change down to pike and I have no idea how to do this :) | 07:03 |
| rakhmerov | pgaxatte: bug for what? I see that you already put a link to a LP bug | 07:04 |
| rakhmerov | it's enough | 07:04 |
| pgaxatte | rakhmerov: I meant to work on a refactor of the policy tests for all the policies | 07:05 |
| rakhmerov | but I don't think we can backport it, it doesn't look to be compliant with stable branch policy | 07:05 |
| rakhmerov | only if we treat it as a security bug or something.. | 07:05 |
| rakhmerov | so the flow is: 1) we need to review and merge it into master 2) then we discuss if we can backport it (better wait till Dougal is back from vacation) 3) cherry pick the patch to needed branches | 07:06 |
| pgaxatte | oh damn I really need this and I'm in pike :D | 07:06 |
| rakhmerov | pgaxatte: ooh, yes, for tests it's better to file a bug | 07:06 |
| rakhmerov | sure | 07:06 |
| rakhmerov | pgaxatte: no panic :) Let's first make it work and merge it and discuss the further steps with the team | 07:07 |
| rakhmerov | btw, it still gives -1 on CI | 07:07 |
| pgaxatte | rakhmerov: ok no problem I'll be patient :) | 07:07 |
| rakhmerov | pgaxatte: yeah, I think we'll solve it one way or another ) | 07:07 |
| pgaxatte | meanwhile I hope I can continue spending time working on upstream code, I really enjoy this :) | 07:08 |
| rakhmerov | pgaxatte: awesome! | 07:10 |
| rakhmerov | great to have you with us | 07:10 |
| *** yangyapeng has quit IRC | 07:10 | |
| pgaxatte | :) | 07:11 |
| *** gkadam has joined #openstack-mistral | 07:11 | |
| *** quiquell|bbl is now known as quiquell | 07:16 | |
| pgaxatte | rakhmerov: should my change carry a releasenote? | 07:30 |
| rakhmerov | 100% | 07:31 |
| rakhmerov | yes | 07:31 |
| rakhmerov | when we backport something it's mandatory | 07:31 |
| rakhmerov | pgaxatte: well, you can send a release note separately if you want | 07:31 |
| rakhmerov | but it should exist | 07:31 |
| *** yangyapeng has joined #openstack-mistral | 07:32 | |
| pgaxatte | I'll add it now | 07:32 |
| *** yangyapeng has quit IRC | 07:34 | |
| openstackgerrit | Pierre Gaxatte proposed openstack/mistral master: Add a policy to control the right to publish resources https://review.openstack.org/579477 | 09:47 |
| *** _Adary has joined #openstack-mistral | 10:08 | |
| *** _Adary has quit IRC | 10:17 | |
| *** _Adary has joined #openstack-mistral | 10:18 | |
| *** amorin has joined #openstack-mistral | 10:32 | |
| *** jlejeune has joined #openstack-mistral | 10:32 | |
| openstackgerrit | Adriano Petrich proposed openstack/python-mistralclient master: WIP Better output when not sourcing auth https://review.openstack.org/580340 | 10:38 |
| *** thrash|g0ne is now known as thrash | 12:12 | |
| *** quiquell is now known as quiquell|lunch | 12:27 | |
| *** quiquell|lunch is now known as quiquell | 12:52 | |
| jlejeune | hi all | 12:57 |
| jlejeune | I'm start using mistral and I have some questions about custom actions | 12:57 |
| jlejeune | reading the doc, I see that we need to package our customs actions in mistral package and to reinstall it | 12:58 |
| jlejeune | am I right ? | 12:58 |
| jlejeune | I wanted to build a new package to deploy my own actions and to manually define them in database using register_action_class() function | 13:01 |
| jlejeune | actually it works, my new action is correctly inserted in database and mistral client see it | 13:02 |
| jlejeune | but to be usable, my custom class action need to be in /usr/lib/python2.7/dist-packages/mistral/actions folder | 13:04 |
| jlejeune | otherwise mistral fails to import my class | 13:05 |
| jlejeune | is there any way to define the PATH where mistral looks for defined actions ? | 13:05 |
| jlejeune | is this blueprint still relevant : https://blueprints.launchpad.net/mistral/+spec/mistral-action-providers ? | 13:09 |
| jlejeune | rakhmerov: ^ | 13:09 |
| thrash | jlejeune: Not necessary to put in mistal package | 13:12 |
| therve | jlejeune: https://docs.openstack.org/mistral/latest/contributor/creating_custom_action.html have you read this? | 13:13 |
| therve | The bit about setup.cfg in particular | 13:13 |
| jlejeune | of course | 13:13 |
| therve | Well that tells you how to package your actions | 13:13 |
| thrash | jlejeune: Not sure you want to get down the path of manual registration... Better to use mistral-db-manage populate | 13:14 |
| thrash | jlejeune: For instance, tripleo-common uses a bunch of custom actions... https://github.com/openstack/tripleo-common/blob/master/setup.cfg#L71-L154 | 13:15 |
| jlejeune | actually we use python-mistral debian package | 13:15 |
| thrash | jlejeune: That shouldn't matter. | 13:15 |
| jlejeune | hm ok | 13:16 |
| thrash | The keys are using setup.cfg, restarting mistral services, then mistral-db-manage populate | 13:16 |
| jlejeune | and we can put our custom actions anywhere ? | 13:21 |
| thrash | jlejeune: By anywhere, do you mean in any python path? | 13:21 |
| jlejeune | yep | 13:21 |
| thrash | You can have a separate python module, yes. | 13:21 |
| jlejeune | \o/ | 13:21 |
| jlejeune | interesting | 13:22 |
| thrash | We do that very thing with tripleo-common | 13:22 |
| thrash | I think you're having an issue by trying to call register_action_class directly | 13:22 |
| thrash | At the very least, you should call sync_db instead of register_action_class directly. | 13:22 |
| jlejeune | no actually it works, I' ve just an error when mistral call this new action | 13:22 |
| thrash | But as long as your python module is installed in the system properly, with a proper setup.cfg, then mistral-db-manage populate should find it. | 13:23 |
| jlejeune | but maybe it's related | 13:23 |
| jlejeune | ok | 13:23 |
| jlejeune | testing it | 13:23 |
| thrash | Maybe try with the mistral-db-manage populate first before trying to do it yourself. :) | 13:23 |
| jlejeune | you're right | 13:23 |
| *** hardikjasani has quit IRC | 13:30 | |
| *** quiquell is now known as quiquell|mtg | 13:53 | |
| openstackgerrit | ayyob proposed openstack/mistral master: add docs for states https://review.openstack.org/580389 | 14:07 |
| jlejeune | so thrash, it just works :) | 14:11 |
| thrash | jlejeune: :) | 14:11 |
| jlejeune | many thanks ! | 14:11 |
| thrash | jlejeune: no worries! Glad it worked for you! | 14:12 |
| openstackgerrit | ayyob proposed openstack/mistral master: add docs for states https://review.openstack.org/580389 | 14:13 |
| *** toure|gone is now known as toure | 14:17 | |
| openstackgerrit | Adriano Petrich proposed openstack/mistral master: Autogenerate configuration documentation https://review.openstack.org/577157 | 14:50 |
| *** quiquell|mtg is now known as quiquell|off | 15:26 | |
| openstackgerrit | jacky06 proposed openstack/mistral master: Pin get-pip.py to 3.2 https://review.openstack.org/580429 | 15:49 |
| *** bobh has joined #openstack-mistral | 16:17 | |
| *** bobh has quit IRC | 16:41 | |
| *** bobh has joined #openstack-mistral | 16:43 | |
| *** bobh has quit IRC | 16:47 | |
| *** thrash is now known as thrash|biab | 16:58 | |
| *** thrash|biab is now known as thrash | 17:35 | |
| *** FL1SK has joined #openstack-mistral | 17:44 | |
| *** gkadam has quit IRC | 19:32 | |
| *** toure is now known as toure|gone | 21:35 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!