| *** csatari_ has joined #openstack-mistral | 00:05 | |
| *** csatari has quit IRC | 00:05 | |
| *** csatari_ is now known as csatari | 00:05 | |
| *** zigo has quit IRC | 00:06 | |
| *** zigo_ has joined #openstack-mistral | 00:06 | |
| *** harlowja has quit IRC | 01:00 | |
| *** thrash is now known as thrash|g0ne | 02:47 | |
| *** harlowja has joined #openstack-mistral | 03:29 | |
| *** harlowja has quit IRC | 04:14 | |
| *** hardikjasani has joined #openstack-mistral | 04:29 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Use yaql_utils.convert_input_data() when creating a child YAQL context https://review.openstack.org/570712 | 04:40 |
|---|---|---|
| rakhmerov | d0ugal, apetrich: hi, can you please look at https://review.openstack.org/#/c/477816/ and https://review.openstack.org/#/c/570712/ ? | 04:41 |
| *** rakhmerov has quit IRC | 04:51 | |
| *** igormarnat has quit IRC | 04:51 | |
| *** akuznetsova has quit IRC | 04:51 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add a test that checks that YAQL engine options work https://review.openstack.org/571091 | 05:03 |
| *** akuznetsova has joined #openstack-mistral | 05:15 | |
| *** rakhmerov has joined #openstack-mistral | 05:16 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add a test that checks that YAQL engine options work https://review.openstack.org/571091 | 05:22 |
| *** igormarnat has joined #openstack-mistral | 05:25 | |
| *** akuznetsova has quit IRC | 05:58 | |
| *** igormarnat has quit IRC | 05:59 | |
| *** rakhmerov has quit IRC | 05:59 | |
| *** akuznetsova has joined #openstack-mistral | 06:16 | |
| *** rakhmerov has joined #openstack-mistral | 06:19 | |
| *** igormarnat has joined #openstack-mistral | 06:22 | |
| *** jtomasek has joined #openstack-mistral | 06:25 | |
| *** jtomasek has quit IRC | 06:28 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 06:32 | |
| apetrich | rakhmerov, about I https://review.openstack.org/#/c/477816/ kind of agree with Andras that some options might make the workflow definitions not portable. and I can't see the bug #1700572 | 07:12 |
| apetrich | rakhmerov, so my question is do we need all of those? | 07:12 |
| rakhmerov | apetrich: the defaults are not broken | 07:13 |
| rakhmerov | but we already faced a case when a customer wants to apply some options per Mistral installation | 07:13 |
| rakhmerov | being completely aware of the consequences | 07:13 |
| rakhmerov | apetrich, d0ugal: do you know what it is? http://logs.openstack.org/12/570712/2/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/6f15073/job-output.txt.gz#_2018-05-30_06_44_51_859804 | 07:13 |
| *** jaosorior has joined #openstack-mistral | 07:15 | |
| *** apetrich has quit IRC | 07:21 | |
| *** apetrich has joined #openstack-mistral | 07:23 | |
| *** jtomasek has joined #openstack-mistral | 07:25 | |
| *** jtomasek has quit IRC | 07:31 | |
| *** jpich has joined #openstack-mistral | 07:53 | |
| * d0ugal will be here to look soon | 08:00 | |
| rakhmerov | apetrich: again, https://review.openstack.org/#/c/477816/ doesn't break compatibility because the default values of these options are still the same. Only people who need a slightly different behaviour will consciously change them | 08:12 |
| apetrich | rakhmerov, yeah I get that but workflows done with that settings in mind are not portable, are they not? | 08:13 |
| apetrich | btw I'm fine with adding those I just want a bit of a cli output and a log with the settings | 08:14 |
| rakhmerov | most likely they are but if someone sets a value of one of these options they will probably know what they want | 08:14 |
| rakhmerov | log? | 08:15 |
| rakhmerov | what do you mean? | 08:15 |
| apetrich | just a LOG.info with those settings. when we instanciate the yaql factory | 08:17 |
| apetrich | so we can look what the settings were when they were running it | 08:17 |
| rakhmerov | apetrich: ok, I can add that | 08:18 |
| rakhmerov | no problem | 08:18 |
| d0ugal | rakhmerov: I find these options weird too | 08:32 |
| d0ugal | I understand limit_iterators and memory_quota | 08:32 |
| d0ugal | but what is the use-case for the others? | 08:32 |
| rakhmerov | d0ugal: one of our customer found that, for example, <% $.my_params.toSet().difference($.another_set) %> works in YAQL CLI and Yaqluator but doesn't work in Mistral's YAQL | 08:33 |
| rakhmerov | setting "convert_sets_to_lists" solves this problem | 08:33 |
| d0ugal | Interesting | 08:33 |
| rakhmerov | that's why I remembered about this patch | 08:34 |
| d0ugal | So that means it is the default in other places but not in Mistral? | 08:34 |
| d0ugal | rakhmerov: a release note would be also super great :) | 08:34 |
| rakhmerov | that has been on review for a while now and thought it's totally ok to add these options (with the same defaults) | 08:34 |
| rakhmerov | d0ugal: yes, seems like. | 08:34 |
| d0ugal | It is strange to me that the YAQL cli changes the defaults. | 08:34 |
| rakhmerov | But my argument here: we're not breaking anything, the defaults are the same. We just add more flexibility | 08:35 |
| d0ugal | but that is a good enough reason for me. | 08:35 |
| d0ugal | Sure, just making sure I understand the motivation. | 08:35 |
| rakhmerov | d0ugal: I'm still against of changing this option's value by default because it may not be backwards compatible | 08:35 |
| d0ugal | rakhmerov: Agreed, I wouldn't support changing the default either. | 08:36 |
| rakhmerov | but giving such a possibility for those who know exactly that they need it seems OK to me | 08:36 |
| d0ugal | It is just surprising to me that our default is different to the other defaults. | 08:36 |
| rakhmerov | d0ugal: sure, agree on 100% | 08:36 |
| d0ugal | Sure | 08:36 |
| rakhmerov | yeah, for me too | 08:36 |
| rakhmerov | but I did investigation last week and it turned to be true | 08:36 |
| d0ugal | So just a realse note please when you make the other changes :-D | 08:36 |
| rakhmerov | absolutely, yes | 08:37 |
| d0ugal | It is useful to know. I often use the YAQL cli to test expressions | 08:37 |
| d0ugal | so now I know I can't fully trust that. | 08:37 |
| rakhmerov | and I'll add logging as well per apetrich's request | 08:37 |
| d0ugal | Great | 08:37 |
| apetrich | cheers | 08:40 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add YAQL engine options https://review.openstack.org/477816 | 08:49 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add a test that checks that YAQL engine options work https://review.openstack.org/571091 | 08:49 |
| *** Alexey_Abashkin has joined #openstack-mistral | 08:50 | |
| *** Alexey_Abashkin has quit IRC | 08:51 | |
| *** AlexeyAbashkin has quit IRC | 08:51 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 08:52 | |
| pgaxatte | hi | 09:04 |
| pgaxatte | I see a small problem in the mistralclient that bothers me and I can't seem to find the root cause | 09:05 |
| pgaxatte | the problem is that the workflow create call using the openstack client does not provider the json and shell formats | 09:06 |
| apetrich | pgaxatte, hey. can you give any details? | 09:06 |
| pgaxatte | although it should and all other create commands behave correctly | 09:06 |
| pgaxatte | here is an example | 09:06 |
| pgaxatte | ➜ openstack workflow create --help | grep -A4 '^output formatters:' output formatters: output formatter options -f {csv,json,table,value,yaml}, --format {csv,json,table,value,yaml} the output format, defaults to table | 09:07 |
| pgaxatte | damn formatting :) | 09:07 |
| pgaxatte | ➜ openstack workflow create --help | grep -A4 '^output formatters:' | 09:07 |
| pgaxatte | output formatters: | 09:07 |
| pgaxatte | output formatter options | 09:07 |
| pgaxatte | -f {csv,json,table,value,yaml}, --format {csv,json,table,value,yaml} | 09:07 |
| pgaxatte | the output format, defaults to table | 09:07 |
| pgaxatte | and this is the output for workbook (which has the correct behavior) | 09:08 |
| pgaxatte | ➜ openstack workbook create --help | grep -A4 '^output formatters:' | 09:08 |
| pgaxatte | output formatters: | 09:08 |
| pgaxatte | output formatter options | 09:08 |
| pgaxatte | -f {json,shell,table,value,yaml}, --format {json,shell,table,value,yaml} | 09:08 |
| pgaxatte | the output format, defaults to table | 09:08 |
| pgaxatte | I've been browsing through openstackclient, mistralclient, osc_lib, cliff, stevedore code for a day now and I don't see why this happens :) | 09:09 |
| apetrich | pgaxatte, do it in a http://paste.openstack.org | 09:09 |
| pgaxatte | yeah sure sorry :) | 09:09 |
| apetrich | no worries | 09:10 |
| pgaxatte | http://paste.openstack.org/show/722329/ | 09:10 |
| pgaxatte | this seems like a small bug without consequence, EXCEPT if you want to integrate the creation of workflows in puppet-mistral | 09:11 |
| pgaxatte | which i'm trying to do :D | 09:12 |
| pgaxatte | and it heavily relies on the output formatting of the openstack command | 09:12 |
| apetrich | pgaxatte, you said that it doesn't provide the json and shell format but I only see a the missing output shell. because there's a json option there, isn't it? | 09:16 |
| pgaxatte | oh yeah I had them mixed up | 09:16 |
| pgaxatte | i thought json was missing too | 09:16 |
| pgaxatte | but no it's just that csv is there instead of shell | 09:17 |
| pgaxatte | an of course puppet uses the shell output.... | 09:17 |
| pgaxatte | for all "create" commands | 09:17 |
| pgaxatte | and the "csv" output for list | 09:17 |
| apetrich | mmm | 09:18 |
| pgaxatte | apetrich, here is a reference that defines this behavior: https://github.com/openstack/python-openstackclient/blob/master/doc/source/contributor/humaninterfaceguide.rst | 09:19 |
| pgaxatte | specifically https://github.com/openstack/python-openstackclient/blob/master/doc/source/contributor/humaninterfaceguide.rst#command-output | 09:20 |
| pgaxatte | but it does not state what the create output formats should be | 09:20 |
| *** jtomasek has joined #openstack-mistral | 09:24 | |
| *** jtomasek has quit IRC | 09:25 | |
| mcdoker181818 | c | 09:33 |
| pgaxatte | apetrich: any idea where this behavior is defined? | 09:36 |
| apetrich | pgaxatte, thats the odd part. I'm trying to dig that. | 09:37 |
| *** mcdoker181818 has quit IRC | 09:37 | |
| apetrich | and comparing to heatclient because it has some handling when you ask the output to be shell | 09:38 |
| * apetrich scratches his head | 09:45 | |
| d0ugal | pgaxatte, apetrich: I would guess this is the issue... | 09:50 |
| d0ugal | https://github.com/openstack/python-mistralclient/blob/master/mistralclient/commands/v2/workbooks.py#L81 | 09:50 |
| d0ugal | vs | 09:50 |
| d0ugal | https://github.com/openstack/python-mistralclient/blob/master/mistralclient/commands/v2/workflows.py#L119 | 09:50 |
| d0ugal | Different base classes. | 09:50 |
| d0ugal | MistralLister is probably wrong? | 09:50 |
| pgaxatte | ah that seems like a good lead | 09:51 |
| apetrich | also heatclient has some custom handling here https://github.com/openstack/python-heatclient/blob/master/setup.cfg#L86-L100 | 09:52 |
| d0ugal | Funky | 09:52 |
| pgaxatte | the dot formatter could be interesting for the workflows :) | 09:55 |
| *** zigo_ is now known as zigo | 09:56 | |
| pgaxatte | d0ugal: in workflows, it uses the cliff modules directly instead of the osc_lib | 09:57 |
| pgaxatte | I'm gonna try to make all this more uniform and see what happens :) | 09:57 |
| pgaxatte | the same problem appears with "action definition create" since the create command uses MistralLister too | 09:59 |
| d0ugal | pgaxatte: cool, let me know if I can help at all :) | 10:04 |
| *** jaosorior has quit IRC | 10:14 | |
| rakhmerov | d0ugal, apetrich: just reminding about http://logs.openstack.org/12/570712/2/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/0cde120/job-output.txt.gz#_2018-05-30_10_10_33_109146 | 10:15 |
| rakhmerov | weird error | 10:15 |
| rakhmerov | and the patch itself doesn't seem to be related to it | 10:15 |
| rakhmerov | would appreciate if you give some clues.. | 10:15 |
| *** thrash|g0ne is now known as thrash | 10:15 | |
| d0ugal | The real error seems further up | 10:16 |
| d0ugal | http://logs.openstack.org/12/570712/2/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/0cde120/job-output.txt.gz#_2018-05-30_10_03_25_141678 | 10:16 |
| d0ugal | Looking for the cause | 10:17 |
| d0ugal | but I suspect it isn't related. | 10:18 |
| d0ugal | rakhmerov: I would just recheck it I think | 10:20 |
| rakhmerov | did, twice | 10:20 |
| d0ugal | apetrich: spotted this in the logs - looks like we have a bad action in tripleo-common? http://logs.openstack.org/12/570712/2/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/0cde120/logs/undercloud/var/log/mistral/mistral-db-manage.log.txt.gz#_2018-05-30_08_39_45_048 | 10:20 |
| *** AlexeyAbashkin has quit IRC | 10:30 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 10:31 | |
| *** jaosorior has joined #openstack-mistral | 10:31 | |
| *** AlexeyAbashkin has quit IRC | 10:36 | |
| rakhmerov | d0ugal: so will you investigate that? | 10:38 |
| d0ugal | rakhmerov: I can try | 10:39 |
| rakhmerov | d0ugal: please | 10:40 |
| d0ugal | rakhmerov: http://logs.openstack.org/12/570712/2/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/0cde120/logs/undercloud/var/log/mistral/engine.log.txt.gz#_2018-05-30_09_03_13_099 | 10:47 |
| d0ugal | The error may be legit | 10:47 |
| d0ugal | rakhmerov: fwiw that is here: https://github.com/openstack/tripleo-common/blob/master/workbooks/messaging.yaml#L126 | 10:50 |
| openstackgerrit | Merged openstack/mistral-lib master: Switch to using stestr https://review.openstack.org/569878 | 11:10 |
| *** AlexeyAbashkin has joined #openstack-mistral | 11:21 | |
| *** toure|gone is now known as toure | 12:26 | |
| *** hardikjasani has quit IRC | 12:28 | |
| *** AlexeyAbashkin has quit IRC | 14:02 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 14:04 | |
| *** EmilienM_PTO is now known as EmilienM | 14:08 | |
| openstackgerrit | Kupai József proposed openstack/mistral master: A mechanism to close stuck running action executions https://review.openstack.org/527085 | 14:31 |
| openstackgerrit | Merged openstack/mistral master: Add log message to log the stack trace in case failed to send an HTTP request https://review.openstack.org/570863 | 15:24 |
| rakhmerov | d0ugal: ok, what do we do with it? | 15:28 |
| rakhmerov | you mean it's a problem caused by some problem in Mistral? | 15:29 |
| rakhmerov | trying to understand :) | 15:29 |
| d0ugal | rakhmerov: It seems like it might be related to your patch? | 15:29 |
| d0ugal | but I am not sure | 15:29 |
| openstackgerrit | Merged openstack/mistral-extra master: Switch to using stestr https://review.openstack.org/569879 | 15:29 |
| d0ugal | The traceback makes it look related | 15:29 |
| d0ugal | and it has been working fine in other patches... | 15:30 |
| rakhmerov | d0ugal: haah... let me see. | 15:30 |
| d0ugal | thrash: I think I might have something | 15:32 |
| rakhmerov | d0ugal: yes, damn it.. | 15:32 |
| rakhmerov | it's caused by the patch, I now see that | 15:33 |
| rakhmerov | d0ugal: the problem is that it was definitely a bug that I fixed | 15:33 |
| thrash | d0ugal: damn, that was quick | 15:34 |
| rakhmerov | ok, I'll investigate that | 15:34 |
| d0ugal | thrash: still verifying. | 15:34 |
| d0ugal | thrash: https://github.com/openstack/python-mistralclient/blob/master/mistralclient/utils.py#L80-L81 | 15:34 |
| d0ugal | thrash: that is highly suspicious IMO. Any errors? nevermind, just use the path as the contents! | 15:35 |
| thrash | d0ugal: Yeah... So that's masking the actual error! | 15:35 |
| d0ugal | thrash: I believe so | 15:35 |
| d0ugal | thrash: but all I've done so far is re-raise that exception | 15:36 |
| d0ugal | rakhmerov: Maybe there is a bug with the yaml parse YAQL function we added to mistral? | 15:36 |
| thrash | there's still the underlying problem of why pkg.resource_filename is failing | 15:36 |
| d0ugal | thrash: yup, I'm not done yet :) | 15:36 |
| rakhmerov | d0ugal: yes, maybe. Ok, I'll check that | 15:37 |
| rakhmerov | put it into WIP for now | 15:37 |
| rakhmerov | d0ugal: thanks a lot | 15:37 |
| d0ugal | rakhmerov: You seen the link to the tripleo workflow? It should be easy to replicate that in a test to do something similar | 15:37 |
| rakhmerov | yep | 15:37 |
| rakhmerov | will do | 15:37 |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Switch to using stestr https://review.openstack.org/569876 | 15:41 |
| d0ugal | thrash: incoming | 16:02 |
| openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Make sure path is absolute https://review.openstack.org/571241 | 16:02 |
| d0ugal | ... slower than expected | 16:02 |
| d0ugal | thrash: ^ | 16:02 |
| d0ugal | That fixes one of the tests for me. | 16:02 |
| d0ugal | py27 was returning a relative path, which failed later | 16:03 |
| d0ugal | Using a file:// scheme doesn't work with relative paths iiuc | 16:03 |
| openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Make sure path is absolute https://review.openstack.org/571241 | 16:13 |
| d0ugal | thrash: should be all of them now ^ | 16:13 |
| d0ugal | should I just squash that into your patch? | 16:13 |
| d0ugal | I guess so... | 16:13 |
| openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Switch to using stestr https://review.openstack.org/569875 | 16:14 |
| d0ugal | thrash: so I assume with stestr eggs or zipped packages are either allowed (or not allowed) now. so then the path is different, which caused the change | 16:15 |
| d0ugal | but really I am not all that sure | 16:16 |
| d0ugal | Anyway, that'll do for now | 16:17 |
| * d0ugal wanders off for the day | 16:17 | |
| *** AlexeyAbashkin has quit IRC | 17:29 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 17:31 | |
| *** jpich has quit IRC | 17:31 | |
| thrash | d0ugal: odd. | 17:33 |
| *** AlexeyAbashkin has quit IRC | 17:36 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 17:57 | |
| *** Alexey_Abashkin has joined #openstack-mistral | 18:00 | |
| *** AlexeyAbashkin has quit IRC | 18:02 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 18:02 | |
| *** rbrady is now known as rbrady-afk | 18:10 | |
| *** AlexeyAbashkin has quit IRC | 18:40 | |
| *** harlowja has joined #openstack-mistral | 21:52 | |
| *** thrash is now known as thrash|g0ne | 23:06 | |
| *** toure is now known as toure|gone | 23:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!