| *** threestrands has joined #openstack-mistral | 00:05 | |
| *** threestrands has quit IRC | 00:05 | |
| *** threestrands has joined #openstack-mistral | 00:05 | |
| *** EmilienM is now known as EmilienM_PTO | 00:18 | |
| *** jtomasek has quit IRC | 00:25 | |
| *** jtomasek has joined #openstack-mistral | 00:29 | |
| *** jtomasek has quit IRC | 00:53 | |
| *** bobh has joined #openstack-mistral | 00:57 | |
| *** mmethot has quit IRC | 01:05 | |
| *** harlowja has quit IRC | 01:05 | |
| *** bobh has quit IRC | 01:05 | |
| *** jtomasek has joined #openstack-mistral | 01:15 | |
| *** jtomasek_ has joined #openstack-mistral | 01:27 | |
| *** jtomasek has quit IRC | 01:28 | |
| *** bobh has joined #openstack-mistral | 01:51 | |
| *** bobh has quit IRC | 02:04 | |
| *** rbrady-afk has quit IRC | 02:05 | |
| *** rbrady has joined #openstack-mistral | 02:07 | |
| *** rbrady is now known as Guest4803 | 02:07 | |
| *** threestrands has quit IRC | 03:10 | |
| *** threestrands has joined #openstack-mistral | 03:13 | |
| *** threestrands has quit IRC | 03:13 | |
| *** threestrands has joined #openstack-mistral | 03:14 | |
| *** threestrands has quit IRC | 03:15 | |
| *** threestrands has joined #openstack-mistral | 03:15 | |
| *** threestrands has quit IRC | 03:15 | |
| *** threestrands has joined #openstack-mistral | 03:15 | |
| *** jtomasek_ has quit IRC | 04:30 | |
| *** toure is now known as toure|gone | 04:45 | |
| *** harlowja has joined #openstack-mistral | 04:46 | |
| *** harlowja has quit IRC | 05:11 | |
| *** hardikjasani has joined #openstack-mistral | 05:20 | |
| *** Guest4803 has quit IRC | 06:30 | |
| *** shardy has quit IRC | 07:06 | |
| *** Guest4803 has joined #openstack-mistral | 07:15 | |
| *** threestrands has quit IRC | 07:18 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:23 | |
| *** Guest4803 has quit IRC | 07:25 | |
| *** Alexey_Abashkin has joined #openstack-mistral | 07:26 | |
| *** AlexeyAbashkin has quit IRC | 07:28 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 07:28 | |
| d0ugal | Morning folks! | 08:03 |
|---|---|---|
| d0ugal | #startmeeting mistral | 08:04 |
| openstack | Meeting started Fri May 25 08:04:05 2018 UTC and is due to finish in 60 minutes. The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:04 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:04 |
| *** openstack changes topic to " (Meeting topic: mistral)" | 08:04 | |
| openstack | The meeting name has been set to 'mistral' | 08:04 |
| d0ugal | It is the Friday office hour! :) | 08:04 |
| d0ugal | Who is around? | 08:04 |
| d0ugal | https://etherpad.openstack.org/p/mistral-office-hours | 08:04 |
| d0ugal | rakhmerov, apetrich, bobh, mcdoker181818: PING! :) | 08:05 |
| apetrich | o/ | 08:05 |
| apetrich | Morning folks | 08:05 |
| d0ugal | We have no "NEW" bugs | 08:14 |
| d0ugal | but we do have one "UNDECIDED" - https://bugs.launchpad.net/mistral/+bug/1772897 | 08:14 |
| openstack | Launchpad bug 1772897 in Mistral "Event-triggered workflows fail on start" [Undecided,Confirmed] | 08:14 |
| d0ugal | I have never actually used the event trigger stuff to start workflows. How does it work? | 08:15 |
| therve | d0ugal: AFAIU, it listens on rabbit notifications, and trigger workflows from them | 08:29 |
| d0ugal | therve: thanks, I'll try and grep for that | 08:30 |
| d0ugal | brb | 08:30 |
| therve | https://github.com/openstack/mistral/blob/master/mistral/event_engine/default_event_engine.py#L268 is the meat | 08:30 |
| therve | Probably none should use this :) | 08:31 |
| d0ugal | therve: Why not? | 08:37 |
| d0ugal | I guess nobody does if that bug is valid... | 08:37 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers https://review.openstack.org/570535 | 08:43 |
| d0ugal | I guess that might fix it ^ | 08:44 |
| apetrich | d0ugal, I agree with the solution. but there's no test to know if that will work, right? | 08:48 |
| d0ugal | apetrich: Just wondering that :) waiting for tox to finish. | 08:49 |
| d0ugal | Well, there is a crappy mock test | 08:50 |
| d0ugal | but that doesn't verify anything | 08:50 |
| apetrich | I was about to mention it | 08:50 |
| apetrich | :) | 08:50 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers https://review.openstack.org/570535 | 08:51 |
| d0ugal | apetrich: see ^ | 08:51 |
| * apetrich wonders how are still getting those errors related to that parameter | 08:51 | |
| d0ugal | lol | 08:52 |
| apetrich | is that still wfexecution_id thing right? | 08:52 |
| apetrich | it is | 08:52 |
| apetrich | :) that was fast | 08:52 |
| d0ugal | yeah | 08:52 |
| apetrich | thanks I'm happy with that | 08:53 |
| d0ugal | Really? | 08:53 |
| d0ugal | lol | 08:53 |
| apetrich | happy enough that the fix is valid | 08:53 |
| d0ugal | brb | 08:55 |
| d0ugal | I am going to end the meeting, but I'll still be around (in 5 mins) | 08:56 |
| d0ugal | #endmeeting | 08:56 |
| *** openstack changes topic to " (Meeting topic: test)" | 08:56 | |
| openstack | Meeting ended Fri May 25 08:56:10 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 08:56 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-05-25-08.04.html | 08:56 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-05-25-08.04.txt | 08:56 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-05-25-08.04.log.html | 08:56 |
| d0ugal | Back. | 09:06 |
| openstackgerrit | liuyamin proposed openstack/mistral master: Add .stestr.conf configuration https://review.openstack.org/567474 | 09:20 |
| *** AlexeyAbashkin has quit IRC | 09:27 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 09:30 | |
| *** mcdoker1818 has joined #openstack-mistral | 10:31 | |
| therve | d0ugal: I just don't think it's a particularly great fit for mistral | 10:32 |
| therve | In general listening to notifications isn't great anyway | 10:33 |
| d0ugal | therve: yeah :/ | 10:33 |
| d0ugal | There are a few half baked featured in Mistral that I kinda wish I could just remove | 10:34 |
| mcdoker1818 | Hi, all. Please, review https://review.openstack.org/#/c/569643/ and https://review.openstack.org/#/c/499790/ | 10:40 |
| mcdoker1818 | And also https://github.com/openstack/mistral/blob/master/mistral/auth/keycloak.py#L42 'X-Auth-Token' is Openstack header. What do you think if i add support `Authorization` Bearer header and make this https://github.com/openstack/mistral/blob/master/mistral/auth/keycloak.py#L82 optionally | 10:41 |
| *** AlexeyAbashkin has quit IRC | 10:44 | |
| opetrenko | Hi all, in mistral/actions/openstack/actions.py we have _try_import method, that tries to import and catches exception if could not import. But as I can see in oslo_utils.try_import, catches ImportError, and returns default object, that is set to None by default | 10:58 |
| opetrenko | Here is the question, why do we try to catch exception, that will be never thrown? | 10:58 |
| d0ugal | opetrenko: I guess the oslo function changed at some point and there was previously an exception | 10:59 |
| opetrenko | so maybe I can change to comparisson to None? | 11:00 |
| d0ugal | opetrenko: Oh, I think we have it for then the import fails | 11:00 |
| d0ugal | but not with an ImportError | 11:00 |
| d0ugal | so I think it is needed | 11:01 |
| *** mcdoker1818 has quit IRC | 11:02 | |
| opetrenko | Can we have any exceptions except from ImportError, when we use __import__ built in? | 11:03 |
| opetrenko | I think we cant | 11:04 |
| opetrenko | if exception is not raise specifically from module | 11:06 |
| opetrenko | I just guess, that our _try_import can fail only if the error not of type ImportError is raised, and therefore when we really cant import module(and we get ImportError) we will end up in not error state, but having None as module-object | 11:08 |
| opetrenko | is that what we except to have? | 11:09 |
| opetrenko | expect* | 11:09 |
| d0ugal | opetrenko: Yes, we can have other exceptions. | 11:11 |
| d0ugal | opetrenko: Imagine you import a file with just "raise Exception('broken')" in it. | 11:11 |
| d0ugal | I believe that is what was happening with Magnum client. So we don't want one broken client to block everything else. | 11:11 |
| opetrenko | yeah, so this behavior is expected | 11:12 |
| opetrenko | thx | 11:12 |
| *** AlexeyAbashkin has joined #openstack-mistral | 11:25 | |
| *** jaosorior has quit IRC | 11:47 | |
| *** jaosorior has joined #openstack-mistral | 11:48 | |
| *** jistr is now known as jistr|mtg | 11:58 | |
| opetrenko | please review https://review.openstack.org/#/c/570206/ | 11:59 |
| *** hardikjasani has quit IRC | 12:10 | |
| *** bobh has joined #openstack-mistral | 12:16 | |
| openstackgerrit | Oleksiy Petrenko proposed openstack/mistral master: Add test for _try_import https://review.openstack.org/570572 | 12:16 |
| *** bobh has quit IRC | 12:27 | |
| openstackgerrit | Oleksiy Petrenko proposed openstack/mistral master: Add test for _try_import https://review.openstack.org/570572 | 12:41 |
| openstackgerrit | Oleksiy Petrenko proposed openstack/mistral master: Add test for _try_import https://review.openstack.org/570572 | 12:52 |
| *** jaosorior has quit IRC | 12:55 | |
| *** jistr|mtg is now known as jistr | 12:57 | |
| *** toure|gone is now known as toure | 13:05 | |
| *** opetrenko has quit IRC | 13:36 | |
| *** d0ugal_ has joined #openstack-mistral | 13:50 | |
| *** d0ugal has quit IRC | 13:51 | |
| *** d0ugal_ has quit IRC | 14:11 | |
| *** d0ugal has joined #openstack-mistral | 14:11 | |
| *** AlexeyAbashkin has quit IRC | 14:19 | |
| *** jtomasek has joined #openstack-mistral | 14:50 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 14:56 | |
| *** jtomasek has quit IRC | 15:27 | |
| *** jtomasek has joined #openstack-mistral | 16:29 | |
| *** jtomasek has quit IRC | 16:37 | |
| *** mmethot has joined #openstack-mistral | 16:45 | |
| *** bobh has joined #openstack-mistral | 17:00 | |
| *** bobh has quit IRC | 17:03 | |
| *** bobh has joined #openstack-mistral | 17:26 | |
| *** mmethot_ has joined #openstack-mistral | 17:33 | |
| *** mmethot has quit IRC | 17:34 | |
| *** bobh has quit IRC | 17:45 | |
| *** AlexeyAbashkin has quit IRC | 18:10 | |
| *** bobh has joined #openstack-mistral | 18:43 | |
| *** bobh has quit IRC | 19:24 | |
| *** harlowja has joined #openstack-mistral | 20:16 | |
| *** mmethot_ has quit IRC | 20:23 | |
| *** toure is now known as toure|gone | 20:38 | |
| *** mmethot has joined #openstack-mistral | 21:11 | |
| *** mmethot_ has joined #openstack-mistral | 21:19 | |
| *** mmethot has quit IRC | 21:22 | |
| *** mmethot has joined #openstack-mistral | 21:35 | |
| *** mmethot_ has quit IRC | 21:38 | |
| *** mmethot_ has joined #openstack-mistral | 21:45 | |
| *** mmethot has quit IRC | 21:46 | |
| *** mmethot has joined #openstack-mistral | 21:52 | |
| *** mmethot_ has quit IRC | 21:56 | |
| *** harlowja has quit IRC | 22:02 | |
| *** pdr_ has quit IRC | 22:41 | |
| *** pdr has joined #openstack-mistral | 22:55 | |
| *** pdr is now known as Guest17437 | 22:55 | |
| *** mmethot has quit IRC | 23:03 | |
| *** mmethot has joined #openstack-mistral | 23:03 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!