| *** bobh has joined #openstack-mistral | 00:06 | |
| *** linhnm has joined #openstack-mistral | 00:33 | |
| *** bobh has quit IRC | 00:41 | |
| *** bobh has joined #openstack-mistral | 00:41 | |
| *** bobh has quit IRC | 00:46 | |
| *** toure is now known as toure|gone | 01:01 | |
| *** linhnm has quit IRC | 02:03 | |
| *** gkadam has joined #openstack-mistral | 02:36 | |
| *** gkadam has quit IRC | 03:07 | |
| rakhmerov | d0ugal: ok, I'll make a note | 04:34 |
|---|---|---|
| rakhmerov | apetrich, d0ugal: hi, need your help with understanding why devstack gates are failing in https://review.openstack.org/#/c/568566/ | 04:35 |
| rakhmerov | apetrich: you added the "force" argument but it's available only in master | 04:35 |
| rakhmerov | for some reason the tempest tests are running with this flag against stable/queens of mistral | 04:36 |
| rakhmerov | as far as I understand | 04:36 |
| *** jaosorior has quit IRC | 04:40 | |
| *** jaosorior has joined #openstack-mistral | 04:47 | |
| rakhmerov | yes, this is right: http://logs.openstack.org/66/568566/1/check/mistral-devstack/eddff55/job-output.txt.gz#_2018-05-15_18_50_00_463237 | 04:47 |
| *** jaosorior has quit IRC | 04:54 | |
| rakhmerov | oops, we don't even have stable branches for this repo :) | 05:01 |
| rakhmerov | d0ugal: so d0ugal, I guess the only way for now is to backport changes related to "force" parameter | 05:02 |
| *** jaosorior has joined #openstack-mistral | 05:02 | |
| *** hardikjasani has joined #openstack-mistral | 05:04 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral stable/queens: Only allow for deleting completed executions https://review.openstack.org/568749 | 05:12 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral stable/queens: Use "passive_deletes=True" in ORM relationships https://review.openstack.org/568566 | 05:15 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral stable/queens: Improve Mistral API DB error handling https://review.openstack.org/568752 | 05:27 |
| *** jtomasek has joined #openstack-mistral | 05:36 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral stable/queens: Only allow for deleting completed executions https://review.openstack.org/568749 | 05:39 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral stable/queens: Use "passive_deletes=True" in ORM relationships https://review.openstack.org/568566 | 05:39 |
| *** livelace has joined #openstack-mistral | 06:26 | |
| openstackgerrit | Lingxian Kong proposed openstack/mistral master: Support Qinling actions in Mistral https://review.openstack.org/567974 | 06:32 |
| *** apetrich has quit IRC | 06:38 | |
| *** apetrich has joined #openstack-mistral | 06:50 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Release note for using "passive_deletes=True" https://review.openstack.org/568762 | 06:59 |
| rakhmerov | apetrich, d0ugal: ok, I had to backport one more patch to make it pass but I think we have a general issue with tempest tests. We probably need to have stable branch management for them too | 07:14 |
| apetrich | rakhmerov, ouch | 07:15 |
| rakhmerov | :) | 07:15 |
| apetrich | rakhmerov, so it is running master tempest against queens? | 07:15 |
| apetrich | is that it? | 07:16 |
| rakhmerov | yes | 07:16 |
| apetrich | that sounds good #not | 07:16 |
| rakhmerov | in mistral-tempest-plugin repo we simply don't have stable/queens branch :) | 07:16 |
| apetrich | I see. yeah we need a stable branch | 07:17 |
| apetrich | be back in a bit | 07:17 |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:42 | |
| apetrich | rakhmerov, do you know how we create a branch? | 07:51 |
| rakhmerov | now we can request to create a stable branch when we send a release patch | 07:53 |
| rakhmerov | so it's done by release management team | 07:54 |
| rakhmerov | may be I'm wrong but I think we'll be able to make a stable branch only when releasing the next major version (Rocky) | 07:54 |
| apetrich | meh. that means backporting the force patch | 07:55 |
| d0ugal | I am not sure how I feel about that. | 07:56 |
| apetrich | I know that I don't feel ultrahappy about that | 07:56 |
| d0ugal | The thing is, it makes sense to run master tempest against queens | 07:56 |
| d0ugal | tempest should be version independant | 07:56 |
| d0ugal | the problem is that our tempest is wrong | 07:56 |
| d0ugal | at least, that is my understanding of how tempest should be used | 07:57 |
| d0ugal | it should be written in such a way that it can handle the different versions - enabling and disabling tests depending on what is available | 07:57 |
| apetrich | for the force issue we could revert the last tempest patch and let the try catch in place | 07:57 |
| apetrich | that means not backporting the force | 07:58 |
| d0ugal | I think that makes more sense than backporting and releasing a feature :) | 07:58 |
| apetrich | I'm +1 on that. rakhmerov what do you think? | 07:58 |
| d0ugal | We should do that, then try and get some advice on how we should do this correctly. | 07:58 |
| apetrich | the bad thing is that it includes the stestr fix :( but that does not affect tempest somehow | 07:59 |
| *** shardy has joined #openstack-mistral | 08:00 | |
| openstackgerrit | Merged openstack/mistral master: Release note for using "passive_deletes=True" https://review.openstack.org/568762 | 08:00 |
| openstackgerrit | Adriano Petrich proposed openstack/mistral-tempest-plugin master: Revert "Fix todo that is not needed anymore stestr conf" https://review.openstack.org/568777 | 08:00 |
| apetrich | I will do the stestr on its onw. as it should have been done in the first place | 08:01 |
| d0ugal | apetrich: What is the stestr fix? | 08:01 |
| d0ugal | oh, the conf file? | 08:01 |
| apetrich | besides being dead wrong | 08:01 |
| apetrich | it allows for tox to work when testing in a suitable env | 08:01 |
| apetrich | otherwise I had to do a lot of bodges to make it wun | 08:02 |
| apetrich | run | 08:02 |
| rakhmerov | d0ugal, apetrich: here | 08:03 |
| rakhmerov | not sure what you want to revert? | 08:04 |
| rakhmerov | d0ugal: your words about being version agnostic make sense, yes.. | 08:04 |
| rakhmerov | btw, the needed patch to mistral is on its way to stable/queens | 08:05 |
| rakhmerov | and soon will be merged | 08:05 |
| rakhmerov | sorry, I had to make a decision quickly because we need my latest passive deletes patch in stable/queens today | 08:06 |
| apetrich | rakhmerov, to get the force patch on I did a try except the call with force and after it went in I removed that. removing that makes the force option required for all versions. | 08:06 |
| rakhmerov | so you're talking about reverting only the patch to mistral-tempest-plugin? | 08:06 |
| apetrich | aye | 08:07 |
| rakhmerov | ok | 08:07 |
| apetrich | https://review.openstack.org/568777 | 08:07 |
| rakhmerov | but do we need it now given that I've already backported the corresponding patch to 'mistral'? | 08:07 |
| rakhmerov | now it's going to be fine | 08:07 |
| rakhmerov | I know it was kind of bad that it happened but now it's already fixed | 08:08 |
| rakhmerov | IMO, all is fixed now, we just need to keep in mind that tempest tests should be version agnostic | 08:08 |
| rakhmerov | and be careful about such changes in future | 08:08 |
| rakhmerov | d0ugal: what do you think? | 08:08 |
| rakhmerov | on the other hand, yes, we can revert it.. | 08:09 |
| rakhmerov | seemingly, no harm in that too | 08:09 |
| apetrich | rakhmerov, he just message me he will be right back. I think he might be having internet issues | 08:09 |
| rakhmerov | ok | 08:10 |
| rakhmerov | np | 08:10 |
| d0ugal | rakhmerov: Which needed patch will soon be merged? | 08:20 |
| d0ugal | What has been backported? | 08:20 |
| rakhmerov | https://review.openstack.org/#/c/568749/ | 08:21 |
| rakhmerov | that adds the "force" flag | 08:21 |
| d0ugal | apetrich: actually, I got a delivery which would have been quick ... but I managed to smash some glass :/ | 08:21 |
| apetrich | ouch | 08:21 |
| rakhmerov | the problem was that in the tempest repo we use this flag (which is not so good, I understand because it's incompatible) | 08:22 |
| d0ugal | Yeah, we made a mistake with the tempest patch. | 08:22 |
| rakhmerov | but I didn't realise in time that the problem was in the tempest repo, not in mistral | 08:22 |
| rakhmerov | so I quickly backported the mistral patch | 08:22 |
| rakhmerov | yeah, kind of | 08:22 |
| rakhmerov | I'm just saying that may be we don't need to revert anything now? | 08:22 |
| d0ugal | Which mistral patch? | 08:22 |
| rakhmerov | https://review.openstack.org/#/c/568749/ | 08:23 |
| rakhmerov | :) | 08:23 |
| rakhmerov | that adds the "force" flag | 08:23 |
| d0ugal | rakhmerov: we shouldn't do that | 08:23 |
| rakhmerov | why? | 08:23 |
| rakhmerov | because it's a feature? | 08:23 |
| d0ugal | Yes | 08:23 |
| d0ugal | and because it wasn't discussed :/ | 08:23 |
| rakhmerov | I know, my apologies for that. I was in a rush | 08:24 |
| rakhmerov | and that seemed to be the right solution to me | 08:24 |
| rakhmerov | despite it's slightly against the stable branch policy | 08:24 |
| d0ugal | it is also a backwards incompatible feature | 08:25 |
| d0ugal | I am going to block it, sorry. | 08:25 |
| rakhmerov | it's not incompatible | 08:25 |
| rakhmerov | why? | 08:26 |
| rakhmerov | this is an addition of a parameter | 08:26 |
| *** livelace has quit IRC | 08:26 | |
| d0ugal | Because users can't delete running executions anymore | 08:26 |
| rakhmerov | aaah... | 08:26 |
| rakhmerov | ok | 08:26 |
| rakhmerov | then let's revert two patches: https://review.openstack.org/#/c/568749/ and https://review.openstack.org/#/q/35d94fd6093edfb80283d43e819bcba7c75bedbf | 08:27 |
| rakhmerov | would that be right? | 08:27 |
| rakhmerov | the second one is already being reverted | 08:27 |
| rakhmerov | d0ugal: ^ | 08:27 |
| d0ugal | I think we only need to revert the revert | 08:27 |
| d0ugal | This one: https://review.openstack.org/#/c/568777/ | 08:27 |
| d0ugal | apetrich: Is that correct? | 08:27 |
| d0ugal | rakhmerov: there was a workaround for the tempest tests that was reverted after - I think we still need it | 08:28 |
| d0ugal | so we either need to add it again or revert the revert :) | 08:28 |
| rakhmerov | d0ugal: no | 08:28 |
| rakhmerov | tests will be failing | 08:28 |
| apetrich | d0ugal, aye | 08:28 |
| rakhmerov | that's what I'm saying to you | 08:29 |
| rakhmerov | that was the reason I backported that mistral patch | 08:29 |
| d0ugal | rakhmerov: I understand that. | 08:29 |
| rakhmerov | so we need to block my backport (you just did) and approve the revert made by apetrich | 08:30 |
| rakhmerov | right? | 08:30 |
| apetrich | if we revert this https://review.openstack.org/#/c/568777/ tests should pass on queens and master | 08:30 |
| d0ugal | Right | 08:30 |
| apetrich | right | 08:30 |
| rakhmerov | ok | 08:30 |
| apetrich | approve the revert I mean | 08:30 |
| apetrich | that is bad language sorry | 08:30 |
| d0ugal | no, I was being confusing too | 08:31 |
| d0ugal | Too much rushing for this time of day. | 08:31 |
| rakhmerov | then I'll need to rebase https://review.openstack.org/#/c/568566/ which was the reason of the whole thing | 08:31 |
| d0ugal | Sounds good. | 08:31 |
| d0ugal | Thanks! | 08:31 |
| rakhmerov | d0ugal: https://review.openstack.org/#/c/568749/ has almost gone through the "gate" queue but you just blocked it | 08:32 |
| rakhmerov | what's going to happen with it? | 08:32 |
| rakhmerov | is it still gonna be merged? | 08:32 |
| rakhmerov | or not | 08:32 |
| *** mcdoker1818 has quit IRC | 08:32 | |
| d0ugal | rakhmerov: I hope not :) I guess we will find out soon. | 08:37 |
| rakhmerov | if it's merged, we'll revert it anyway | 08:37 |
| d0ugal | rakhmerov: I abandoned the patch. I think that might kill the CI job. | 08:37 |
| rakhmerov | no worries | 08:37 |
| d0ugal | ok | 08:37 |
| d0ugal | rakhmerov: I don't see it in the gate queue now. So I guess abandoning is a quick way to stop it | 08:39 |
| rakhmerov | yes | 08:39 |
| rakhmerov | thanks | 08:39 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral stable/queens: Use "passive_deletes=True" in ORM relationships https://review.openstack.org/568566 | 08:40 |
| rakhmerov | d0ugal: please look if https://review.openstack.org/#/c/568566/ is ok to backport | 08:40 |
| rakhmerov | it's already a backport actually | 08:40 |
| d0ugal | lol | 08:40 |
| d0ugal | Yes, that is fine | 08:40 |
| rakhmerov | thanks | 08:43 |
| openstackgerrit | Kupai József proposed openstack/mistral master: A mechanism to close stuck running action executions https://review.openstack.org/527085 | 08:44 |
| d0ugal | rakhmerov: btw, we have some unreleased backports in pike and queens. | 08:45 |
| d0ugal | I'll do the pike release now, after this patch lands I'll release queens | 08:45 |
| rakhmerov | yes, I know | 08:45 |
| rakhmerov | thanks | 08:45 |
| d0ugal | or are there any other backports coming soon? | 08:45 |
| rakhmerov | for us it just wasn't so important | 08:45 |
| rakhmerov | nope, that's all we need for now | 08:45 |
| d0ugal | apetrich: did your mistralclient release merge? | 08:46 |
| apetrich | aye | 08:46 |
| d0ugal | cool | 08:46 |
| d0ugal | oh yeah, I found it :) | 08:46 |
| apetrich | https://review.openstack.org/#/c/568530/ | 08:47 |
| apetrich | too late. sorry | 08:47 |
| d0ugal | np | 08:47 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Support Qinling actions in Mistral https://review.openstack.org/567974 | 08:51 |
| *** gkadam has joined #openstack-mistral | 08:53 | |
| *** jistr has quit IRC | 09:09 | |
| *** jistr has joined #openstack-mistral | 09:12 | |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Added test to update the database schema to the latest revision https://review.openstack.org/568140 | 09:25 |
| openstackgerrit | Lingxian Kong proposed openstack/mistral master: Support Qinling actions in Mistral https://review.openstack.org/567974 | 09:28 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral master: Add .stestr.conf configuration https://review.openstack.org/567474 | 09:33 |
| openstackgerrit | Merged openstack/mistral-tempest-plugin master: Revert "Fix todo that is not needed anymore stestr conf" https://review.openstack.org/568777 | 09:36 |
| rakhmerov | d0ugal: I think we can close https://bugs.launchpad.net/mistral/+bug/1757966 | 11:11 |
| openstack | Launchpad bug 1757966 in Mistral "Mistral server consumes more memory over time" [Critical,In progress] - Assigned to Renat Akhmerov (rakhmerov) | 11:11 |
| rakhmerov | we fixed what we've found so far | 11:11 |
| rakhmerov | d0ugal: ok with you? | 11:13 |
| openstackgerrit | Merged openstack/mistral master: Use partial loading of workflow execution in the controller https://review.openstack.org/568556 | 11:21 |
| openstackgerrit | Merged openstack/mistral master: Purge README.rst in favor of the generated documentation https://review.openstack.org/565562 | 11:21 |
| *** jaosorior has quit IRC | 11:23 | |
| openstackgerrit | Kupai József proposed openstack/mistral master: A mechanism to close stuck running action executions https://review.openstack.org/527085 | 11:35 |
| *** jaosorior has joined #openstack-mistral | 11:42 | |
| *** gkadam has quit IRC | 11:43 | |
| *** gkadam has joined #openstack-mistral | 11:43 | |
| openstackgerrit | Merged openstack/python-mistralclient master: Add namespace parameter to workflow-get and workflow-get-definition https://review.openstack.org/566792 | 11:54 |
| openstackgerrit | Merged openstack/python-mistralclient master: Adding environment-get-definition for easy environment-update https://review.openstack.org/566469 | 11:54 |
| *** shardy_ has joined #openstack-mistral | 12:11 | |
| *** shardy has quit IRC | 12:13 | |
| d0ugal | rakhmerov: sure, sounds good! | 12:26 |
| *** toure|gone is now known as toure | 13:01 | |
| *** shardy_ is now known as shardy | 13:38 | |
| openstackgerrit | Kupai József proposed openstack/mistral master: A mechanism to close stuck running action executions https://review.openstack.org/527085 | 13:51 |
| *** bobh has joined #openstack-mistral | 14:12 | |
| *** hardikjasani has quit IRC | 14:32 | |
| *** Alexey_Abashkin has joined #openstack-mistral | 14:44 | |
| *** AlexeyAbashkin has quit IRC | 14:46 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 14:46 | |
| rakhmerov | d0ugal: ok, closed it | 15:23 |
| d0ugal | rakhmerov: Thanks | 15:23 |
| rakhmerov | d0ugal: btw, I don't see rocky-1 milestone in LP for some reason | 15:23 |
| rakhmerov | was it removed? | 15:23 |
| d0ugal | rakhmerov: I think that is because it is closed? | 15:23 |
| d0ugal | It shouldn't be removed... | 15:23 |
| rakhmerov | nope, I see others that are closed as well | 15:23 |
| d0ugal | hmm, weird | 15:24 |
| d0ugal | https://launchpad.net/mistral/+milestone/rocky-1 | 15:24 |
| d0ugal | rakhmerov: ^ I still see it there. | 15:24 |
| rakhmerov | yeah, weird | 15:24 |
| rakhmerov | ok, np | 15:24 |
| d0ugal | I guess I done something wrong... I'll take a look | 15:24 |
| rakhmerov | d0ugal: I noticed that a release wasn't created for it | 15:25 |
| rakhmerov | if you open it you'll see active "Create release" link | 15:26 |
| d0ugal | oh | 15:26 |
| rakhmerov | yeah | 15:26 |
| d0ugal | I didn't even know launchpad had such a thing | 15:26 |
| rakhmerov | :) | 15:26 |
| rakhmerov | now you know ) | 15:27 |
| openstackgerrit | Merged openstack/mistral stable/queens: Use "passive_deletes=True" in ORM relationships https://review.openstack.org/568566 | 15:28 |
| d0ugal | Finally ^ | 15:29 |
| *** gkadam has quit IRC | 16:46 | |
| *** shardy has quit IRC | 16:50 | |
| *** AlexeyAbashkin has quit IRC | 17:16 | |
| openstackgerrit | Matthew Thode proposed openstack/mistral master: uncap networkx https://review.openstack.org/568911 | 17:36 |
| *** bobh has quit IRC | 18:04 | |
| *** bobh has joined #openstack-mistral | 18:05 | |
| openstackgerrit | Matthew Thode proposed openstack/mistral master: uncap networkx https://review.openstack.org/568911 | 18:56 |
| *** livelace has joined #openstack-mistral | 19:12 | |
| *** d0ugal_ has joined #openstack-mistral | 21:40 | |
| *** d0ugal has quit IRC | 21:41 | |
| *** livelace has quit IRC | 21:52 | |
| *** weshay has quit IRC | 22:17 | |
| *** weshay has joined #openstack-mistral | 22:22 | |
| *** weshay has quit IRC | 22:26 | |
| *** bobh has quit IRC | 22:27 | |
| *** bobh has joined #openstack-mistral | 22:28 | |
| *** bobh has quit IRC | 22:32 | |
| *** weshay has joined #openstack-mistral | 22:34 | |
| *** d0ugal__ has joined #openstack-mistral | 22:40 | |
| *** d0ugal_ has quit IRC | 22:41 | |
| *** weshay has quit IRC | 23:17 | |
| *** weshay has joined #openstack-mistral | 23:21 | |
| *** bobh has joined #openstack-mistral | 23:58 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!