Monday, 2018-04-23

openstackgerritQi Peng proposed openstack/mistral master: Update mistral upgrade guide  https://review.openstack.org/56349103:10
*** hardikjasani has joined #openstack-mistral04:55
*** jtomasek has joined #openstack-mistral05:13
*** apetrich has joined #openstack-mistral06:46
*** apetrich has quit IRC06:46
*** jaewook_oh has joined #openstack-mistral06:50
jaewook_ohHello Mistral Team! This is Jaewook, I'd like to add Vitrage actions to the Mistral.06:52
*** mcdoker181818 has joined #openstack-mistral07:01
*** apetrich has joined #openstack-mistral07:02
mcdoker181818Hi, all. Can you please review my small set of bugfixes\improvements? https://review.openstack.org/#/q/owner:Mcdkr%2540yandex.ru+status:open07:10
mcdoker181818Can you confirm that this bug? https://review.openstack.org/#/c/563479/1/mistral/tests/unit/engine/test_direct_workflow.py07:13
mcdoker181818IMHO, the task must be in SUCCESS state in this case, but it is in ERROR state by timeout.07:13
mcdoker181818What do you think if i bind a timeout delayed calls with actions, not with tasks?07:13
*** hardikjasani has quit IRC07:25
jaewook_ohCan I upload the blueprint about "Adding Vitrage Action"?07:25
*** AlexeyAbashkin has joined #openstack-mistral07:36
*** hardikjasani has joined #openstack-mistral07:41
*** livelace has joined #openstack-mistral07:51
*** livelace has quit IRC07:51
*** nguyenhai has joined #openstack-mistral07:54
*** jpich has joined #openstack-mistral07:58
*** shardy has joined #openstack-mistral08:05
d0ugaljaewook_oh: Sure. That would be fine.08:09
d0ugalmcdoker181818: you have been busy :) I'll try and review some of them today08:10
d0ugaljaewook_oh: let me know if you need any help adding the actions.08:14
d0ugaljaewook_oh: oh, and if you can link me the blueprint once you have added it I can add it to Rocky - assuming that is your goal.08:15
*** jaosorior has joined #openstack-mistral08:15
*** threestrands has quit IRC08:17
openstackgerritRenat Akhmerov proposed openstack/mistral stable/queens: Release note for batched evaluation of final workflow context  https://review.openstack.org/56351108:21
jaewook_ohThanks d0ugal :) I'll do it08:24
*** jaosorior has quit IRC08:32
d0ugalrakhmerov: I am not convinced that this patch is worth the code churn. https://review.openstack.org/#/c/551437/08:33
rakhmerovd0ugal: hi08:33
rakhmerovd0ugal: what do you mean?08:34
rakhmerovyou like it or you don't? )08:34
d0ugalrakhmerov: It's a big change with little advantages IMO08:34
rakhmerovooh, yeah08:34
rakhmerovdid you see my comments?08:34
d0ugalYeah, I just noticed them actually08:34
rakhmerovI left them several minutes ago08:34
d0ugalThe only way to have it lint everything but allow id to be shadowed would be to add "NOQA: something" everywhere08:35
rakhmerovyes08:35
d0ugaland that would be ugly08:35
rakhmerovyep08:35
rakhmerovIMO it's never been an issue for us that we shadowed something08:35
rakhmerovI used id() function 2-3 time probably for debugging08:36
rakhmerovand then removed before commiting a change08:36
d0ugalYeah, I am not sure I have ever used it :)08:36
rakhmerov)08:36
d0ugalOther than to learn what it does08:36
*** Alexey_Abashkin has joined #openstack-mistral08:48
*** Alexey_Abashkin has quit IRC08:50
*** Alexey_Abashkin has joined #openstack-mistral08:50
*** AlexeyAbashkin has quit IRC08:51
*** AlexeyAbashkin has joined #openstack-mistral08:54
*** Alexey_Abashkin has quit IRC08:54
openstackgerritMerged openstack/mistral stable/queens: Adding WWW-Authenticate info.  https://review.openstack.org/56145408:55
*** Alexey_Abashkin has joined #openstack-mistral09:02
*** AlexeyAbashkin has quit IRC09:05
*** Alexey_Abashkin is now known as AlexeyAbashkin09:05
*** jaosorior has joined #openstack-mistral09:07
openstackgerritMerged openstack/mistral master: Added thread pool for eventlet executor mode  https://review.openstack.org/55957009:56
openstackgerritMerged openstack/mistral stable/queens: Release note for batched evaluation of final workflow context  https://review.openstack.org/56351109:56
openstackgerritVitalii Solodilov proposed openstack/mistral master: Fixed Jinja error handling  https://review.openstack.org/56342210:02
d0ugalmcdoker181818: Hey10:10
mcdoker181818d0ugal: I agree with you. When I finished patch with shadow builtin I didn't wanna push changes on review :D I didn't expect so much changes10:19
mcdoker181818thanks all for the reviews10:20
d0ugalmcdoker181818: regarding the mini racer review...10:20
d0ugalmcdoker181818: if you would prefer to add the releasenote in a follow on patch and mention the blueprint in that commit message I'd be happy to merge that now.10:20
d0ugalIt is all green and has another +2, so I'd prefer not to block it :)10:21
d0ugalbut I do want to get us into the habit of tracking things and having release notes.10:21
mcdoker181818There are no problems, give me 10 minutes. I will add release note10:23
d0ugalThanks!10:23
*** AlexeyAbashkin has quit IRC10:47
openstackgerritVitalii Solodilov proposed openstack/mistral master: Added JavaScript evaluator which doesn't require a compilation  https://review.openstack.org/56345810:47
*** AlexeyAbashkin has joined #openstack-mistral10:51
mcdoker181818d0ugal: Should i try to add py_mini_racer to https://github.com/openstack/requirements ? I want to make py_mini_racer as default javascript evaluator. Are you okay with idea? https://bugs.launchpad.net/mistral/+bug/155156110:58
openstackLaunchpad bug 1551561 in Mistral "pyv8 is not required by mistral but javascipt action is installed by default" [Medium,Triaged]10:58
d0ugalmcdoker181818: You can try. I don't know how easy it would be to add it to the global requirements.10:58
d0ugalmcdoker181818: why do you want to make it the default. Is it 100% compatible with V8? I wonder if changing the default could be backwards incompatible...10:58
d0ugalbut I agree, it would need to be in global requirements for it to be the default.10:59
d0ugalmcdoker181818: oh, I was going to approve that patch but I see Hardik spotted something we all missed :)11:01
openstackgerritVitalii Solodilov proposed openstack/mistral master: Added JavaScript evaluator which doesn't require a compilation  https://review.openstack.org/56345811:05
*** mfedosin has quit IRC11:08
mcdoker181818d0ugal: As I understand all of (pyv8, v8eval and py_mini_racer) just is wrapper of v8 engine. I think yes, the change will be backward compatible. The default py_mini_racer will be convinient for user.11:08
openstackgerritVitalii Solodilov proposed openstack/mistral master: Added JavaScript evaluator which doesn't require a compilation  https://review.openstack.org/56345811:09
d0ugalmcdoker181818: right, makes sense. If that is the case then we should try and switch the default.11:14
*** thrash|g0ne is now known as thrash11:15
*** mfedosin has joined #openstack-mistral11:37
*** bobh has joined #openstack-mistral11:59
*** bobh has quit IRC12:31
openstackgerritJaewook Oh proposed openstack/mistral master: Added Vitrage actions into Mistral Implements: blueprint mistral-vitrage-actions  https://review.openstack.org/56361313:00
*** jpich has quit IRC13:30
*** jpich has joined #openstack-mistral13:38
*** hardikjasani has quit IRC13:45
d0ugalthrash: http://logs.openstack.org/46/562046/1/check/build-openstack-sphinx-docs/739c127/job-output.txt.gz#_2018-04-18_13_10_04_71674414:05
d0ugalthrash: any ideas?14:05
d0ugaloh14:05
d0ugalhttp://logs.openstack.org/46/562046/1/check/build-openstack-sphinx-docs/739c127/job-output.txt.gz#_2018-04-18_13_10_10_34223914:05
d0ugalMaybe that is the real error.14:05
thrashd0ugal: looks like further up...14:09
thrashhttp://logs.openstack.org/46/562046/1/check/build-openstack-sphinx-docs/739c127/ara-report/14:10
thrashd0ugal: ^^^14:10
thrashThis neutron-horizon-hack.yaml... That's not us.14:10
*** bobh has joined #openstack-mistral14:11
thrashd0ugal: maybe need to use the "legacy" job for pike?14:11
thrashd0ugal: let me see if I can dig that up.14:11
d0ugalph14:15
d0ugaloh14:15
d0ugalfun14:15
openstackgerritMerged openstack/mistral master: add lower-constraints job  https://review.openstack.org/55582414:18
thrashd0ugal: there's this: https://review.openstack.org/#/c/561593/ but pabelanger doesn't like it. :)14:30
d0ugallol14:30
d0ugalback in 30, might be a few mins late for the office hours14:31
*** Alexey_Abashkin has joined #openstack-mistral14:50
*** AlexeyAbashkin has quit IRC14:54
*** Alexey_Abashkin is now known as AlexeyAbashkin14:54
d0ugal#startmeeting mistral15:08
openstackMeeting started Mon Apr 23 15:08:46 2018 UTC and is due to finish in 60 minutes.  The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot.15:08
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:08
*** openstack changes topic to " (Meeting topic: mistral)"15:08
openstackThe meeting name has been set to 'mistral'15:08
d0ugalHey folks, sorry for the late start.15:08
d0ugalI was a little ambitious in a 5km run.15:08
d0ugald0ugal, rakhmerov, apetrich, bobh, mcdoker181818 ^15:09
d0ugalWelcome to the Mistral office hour :)15:09
d0ugalor, the Mistral 50 mins really.15:09
bobho/15:10
mcdoker181818\ะพ15:10
apetricho/15:10
d0ugalAnyone got anything to discuss?15:10
bobhd0ugal: I'm working on this: https://review.openstack.org/#/c/554950/15:11
d0ugalthrash: I'd like chat about that CI issue... any idea how we can move forward with it?15:11
bobhand found an issue - there are two different sort_keys options15:11
bobhone by mistral API and one by cliff15:11
thrashd0ugal: not sure atm... is there any chatter on the ml?15:11
d0ugalbobh: looking, I hadn't seen this patch yet.15:11
d0ugalthrash: good question, I'll have a search.15:12
thrashd0ugal: looking too15:12
bobhd0ugal: also the fields option conflicts with the formatter - if you don't select the fields the formatter is expecting it complains15:12
d0ugalbobh: does this mean that we overwrite the cliff sort_keys?15:12
bobhno - they both get used15:12
bobhd0ugal: but they can conflict15:13
d0ugaloh, so they have different cli args?15:13
d0ugalsounds confusing :/15:13
bobhd0ugal: definitely15:13
bobhcliff provides -c and that gets applied after the formatter is done15:13
bobhfor field selection15:14
d0ugalright, I use -c all the time.15:14
bobhcliff is also providing a sort column option, which gets applied after the formatter as well15:14
bobhI'm not sure if it can do asc/desc - maybe with a - prefix15:15
d0ugalbobh: is the cliff sort client-side only?15:15
bobhyes15:15
bobhwhich actually makes my problem easier I think15:16
d0ugalyeah, and it could be possibly useful?15:16
bobhsince I'll tell the server to get the data I want then let cliff sort it15:16
d0ugali.e. I want to get the 100 newest from mistral but then sort them by status client side15:16
bobhexactly!15:16
d0ugalkinda weird, but almost makes sense.15:16
d0ugalalmost :)15:16
bobhI'll take almost15:16
d0ugalbobh: so do you think we need to change anything or it is okay?15:17
bobhassuming I can get a desc sort to work in cliff, I think it makes sense to remove the sort_keys and sort_dirs CLI options that operate on the server-side15:17
bobhand force the user to use the cliff options15:17
thrashd0ugal: there is a thread about it, but not much of a resolution.15:17
bobhit simplifies things and makes them work15:17
bobhsame with --fields - remove it for -c instead15:18
thrashd0ugal: let me see what it takes to fix on our end.15:18
d0ugalbobh: hmm, I think we need the server side sort.15:20
d0ugalthrash: thanks, I'll see if I can take a look later15:21
d0ugalbobh: I am trying to think of an example...15:21
bobhwe need it for retrieving oldest vs newest15:21
d0ugalbobh: not just oldest or newest - you could sort by other cols?15:21
bobhbut once you have the dataset you want, the sort can be handled on the client?15:21
d0ugalbobh: what if I want to get the 100 newest task's that are in ERROR state15:22
bobhthat's a filter - status=ERROR15:22
d0ugaloh yeah15:22
d0ugaldamn15:22
d0ugalMaybe I don't have a good example :)15:22
d0ugalI could just be wrong.15:22
bobhI'll play with it some more and update the patchset15:23
d0ugalbobh: but generally I agree, it would be good to make things simpler - we do need to take into account backwards compatability tho'15:23
bobhd0ugal: we could convert the sort_keys/sort_dirs options to the appropriate cliff input15:23
d0ugalyeah, that makes sense15:23
d0ugaland display a deprecation warning15:23
d0ugalthen remove them in the S or T cyclre15:24
d0ugalcycle*15:24
bobhd0ugal: yes15:24
d0ugalI'll look out for an update on the patch :)15:26
bobhd0ugal: thanks15:27
d0ugalWe still have 0 "NEW" bugs :)15:27
mcdoker181818I plan to create one :)15:27
mcdoker181818https://review.openstack.org/#/c/563479/1/mistral/tests/unit/engine/test_direct_workflow.py15:28
d0ugalmcdoker181818: oh yeah, I started looking at this :)15:29
d0ugalmcdoker181818: so the problem is that it should end with an error from the exception, not the timeout?15:29
mcdoker181818wf was failed by timeout but i think it was finished successfully15:29
d0ugalactually, no, you expect SUCCESS :)15:29
d0ugalI don't understand how it would be successful.15:30
d0ugalCan you walk me through it?15:30
mcdoker181818First timeout still works after retry but I expect that task will create a new timeout delayed call and previous timeout delayed call was skipped15:31
d0ugaloh, I see. So the task should only fail once.15:31
mcdoker181818yep15:31
d0ugalmcdoker181818: so you think it should have a timeout of 3 seconds for each action execution?15:32
mcdoker181818I expect this :)15:32
d0ugalInteresting.15:33
d0ugalI don't :)15:33
d0ugalI think the timeout is for the task itself.15:33
d0ugalWe use the timeout in quite a few places in tripleo15:33
d0ugalmcdoker181818: https://github.com/openstack/tripleo-common/blob/4739027b9eaf3dc895b29b67dbca0ffc79b36d4b/workbooks/stack.yaml#L18-L2415:34
mcdoker181818How should timeout work with retry?15:34
d0ugalmcdoker181818: in our use case, having the timeout be per-action-execution doesn't make sense :)15:34
d0ugalmcdoker181818: I think they are unrelated.15:35
d0ugalTo me the timeout is for how long the task tasks15:35
mcdoker181818But timeout will retry task15:35
d0ugalretry then means the task can take longer15:35
d0ugalmcdoker181818: really? so if you hit the timeout it will then trigger the retry?15:36
d0ugaland that retry will timeout instantly?15:36
mcdoker181818No15:36
mcdoker181818But you say that this is bug https://bugs.launchpad.net/mistral/+bug/176444115:37
openstackLaunchpad bug 1764441 in Mistral "Timeout policy doesn't work with retry policy properly" [High,In progress] - Assigned to Vitalii Solodilov (mcdoker18)15:37
mcdoker181818in previous meeting15:37
d0ugalmcdoker181818: workflows should never be stuck in RUNNING.15:38
d0ugalI believe that is a similar, but different issue.15:38
d0ugalIt might be a good idea to chat about this when rakhmerov is around - to get some historical perspective.15:39
mcdoker181818Maybe i create a email? [openstack-dev][mistral]15:40
d0ugalSure, good idea.15:41
openstackgerritBrad P. Crochet proposed openstack/mistral stable/pike: Avoid tox_install.sh for constraints support  https://review.openstack.org/56367415:41
thrashd0ugal: ^^^15:41
d0ugalooh15:41
thrashd0ugal: that might should do it. :)15:41
thrashd0ugal: if tox_install don't exist, it won't call it. :)15:42
d0ugalworks for me15:42
openstackgerritDougal Matthews proposed openstack/mistral stable/pike: Correct the string formatting in a info log message  https://review.openstack.org/56204615:48
d0ugalI gotta run and take care of a few things15:58
d0ugalSo I'm going to end the meeting bot.15:58
d0ugalOn Friday I plan to start going through the bugs and blueprints assigned to Rocky-2.15:59
d0ugalShould be fun :)15:59
d0ugalThanks everyone15:59
d0ugal#endmeeting15:59
*** openstack changes topic to " (Meeting topic: test)"15:59
openstackMeeting ended Mon Apr 23 15:59:39 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:59
openstackMinutes:        http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-23-15.08.html15:59
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-23-15.08.txt15:59
openstackLog:            http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-23-15.08.log.html15:59
d0ugalthrash: yay, it worked!16:05
d0ugalthrash: thank you!16:05
thrashwoot!16:05
*** hardikjasani has joined #openstack-mistral16:18
thrashd0ugal: however... it will never land.16:19
thrashd0ugal: at least not in it's current state.16:19
openstackgerritBrad P. Crochet proposed openstack/mistral stable/pike: Avoid tox_install.sh for constraints support  https://review.openstack.org/56367416:21
thrashd0ugal: that should fix it. I hope. :)16:21
d0ugalI'll be more patient :(16:21
openstackgerritVitalii Solodilov proposed openstack/mistral master: Minor `update_on_match` improvement  https://review.openstack.org/56149016:23
thrashd0ugal: Well crap. ALmost.16:27
thrashMight be another backport needed.16:28
*** bobh has quit IRC16:29
*** bobh_ has joined #openstack-mistral16:29
openstackgerritBrad P. Crochet proposed openstack/mistral stable/pike: Adding doc8 to test-requirements  https://review.openstack.org/56369416:30
*** jpich has quit IRC16:30
openstackgerritBrad P. Crochet proposed openstack/mistral stable/pike: Avoid tox_install.sh for constraints support  https://review.openstack.org/56367416:30
thrashd0ugal: that might work. :)16:30
*** Alexey_Abashkin has joined #openstack-mistral16:31
*** AlexeyAbashkin has quit IRC16:34
*** Alexey_Abashkin is now known as AlexeyAbashkin16:34
openstackgerritVitalii Solodilov proposed openstack/mistral master: Added 'safe-rerun' policy to task-defaults section  https://review.openstack.org/55957616:48
*** pabelanger has joined #openstack-mistral16:53
pabelangergreetings, could I get a few reviews of https://review.openstack.org/563225/ it would help the openstack-infra team. Thanks16:53
*** AlexeyAbashkin has quit IRC16:59
openstackgerritVitalii Solodilov proposed openstack/mistral master: Added JavaScript evaluator which doesn't require a compilation  https://review.openstack.org/56345817:04
*** jaosorior has quit IRC17:05
thrashd0ugal: that did it, it seems17:08
openstackgerritBrad P. Crochet proposed openstack/mistral stable/pike: Correct the string formatting in a info log message  https://review.openstack.org/56204617:10
*** mcdoker181818 has quit IRC17:25
*** jaosorior has joined #openstack-mistral17:49
d0ugalthrash: great, thanks!18:16
*** rbrady has joined #openstack-mistral18:30
*** rbrady has quit IRC18:30
*** rbrady has joined #openstack-mistral18:30
*** rbrady has quit IRC18:35
*** harlowja has joined #openstack-mistral18:44
toured0ugal you still up18:47
*** jaosorior has quit IRC18:55
*** bobh_ has quit IRC18:56
*** hardikjasani has quit IRC18:58
*** harlowja has quit IRC19:07
*** rbrady_ has joined #openstack-mistral19:12
*** bobh has joined #openstack-mistral19:27
*** rbrady_ has quit IRC19:30
*** bobh has quit IRC19:32
*** jtomasek has quit IRC20:43
openstackgerritVitalii Solodilov proposed openstack/mistral master: Example of retry and timeout  https://review.openstack.org/56375920:45
pabelangerI'm still looking for a final +3 on https://review.openstack.org/563225/ to help openstack-infra remove some legacy jenkins scripts20:50
*** bobh has joined #openstack-mistral20:56
*** jrist has quit IRC22:08
*** bobh has quit IRC22:09
*** jrist has joined #openstack-mistral22:12
*** jrist has quit IRC22:12
*** jrist has joined #openstack-mistral22:12
*** threestrands has joined #openstack-mistral22:41
*** threestrands has quit IRC22:41
*** threestrands has joined #openstack-mistral22:41
*** thrash is now known as thrash|g0ne23:13

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!