Wednesday, 2018-04-18

« Tuesday, 2018-04-17 Index Thursday, 2018-04-19 »
*** bobh has joined #openstack-mistral00:37
*** bobh has quit IRC01:09
*** bobh has joined #openstack-mistral01:09
*** bobh has quit IRC01:14
*** harlowja has quit IRC01:16
*** bobh has joined #openstack-mistral01:31
*** AlexeyAbashkin has joined #openstack-mistral01:39
*** bobh has quit IRC01:43
*** AlexeyAbashkin has quit IRC01:43
openstackgerritwangqi proposed openstack/mistral master: Update auth_uri option to www_authenticate_uri  https://review.openstack.org/56209201:58
*** thrash is now known as thrash|g0ne02:25
*** harlowja has joined #openstack-mistral03:43
*** harlowja has quit IRC04:12
*** hardikjasani has joined #openstack-mistral04:12
*** zhurong has joined #openstack-mistral05:36
openstackgerritRenat Akhmerov proposed openstack/mistral stable/queens: Optimizing big 'on-XXX' clauses  https://review.openstack.org/56211305:45
openstackgerritRenat Akhmerov proposed openstack/mistral master: Release note for not persisting '__task_execution' in DB  https://review.openstack.org/56211906:15
*** jtomasek has joined #openstack-mistral06:26
openstackgerritQi Peng proposed openstack/mistral master: Update install guide about running mistral by sysctl  https://review.openstack.org/56212106:31
openstackgerritQi Peng proposed openstack/mistral master: Update install guide about running mistral by sysctl  https://review.openstack.org/56212106:33
*** shardy has joined #openstack-mistral06:41
*** pgaxatte1 has quit IRC06:47
*** pgaxatte has joined #openstack-mistral06:47
openstackgerritQi Peng proposed openstack/mistral master: Update install guide about running mistral by sysctl  https://review.openstack.org/56212107:08
*** zigo has quit IRC07:11
*** zigo has joined #openstack-mistral07:14
*** jpich has joined #openstack-mistral07:25
*** AlexeyAbashkin has joined #openstack-mistral07:30
*** zhurong has quit IRC07:30
*** shardy has quit IRC07:39
*** shardy has joined #openstack-mistral07:39
d0ugalSeems out pike CI is completely broken08:01
d0ugalSeems our pike CI is completely broken08:01
rakhmerovd0ugal: yes08:02
rakhmerovit's bad08:02
d0ugalOh, most of it is non-voting08:02
d0ugalbut this is a problem: http://logs.openstack.org/46/562046/1/check/build-openstack-sphinx-docs/57c9625/job-output.txt.gz#_2018-04-18_06_40_04_52525008:02
rakhmerovd0ugal: btw, I'll need a number of patches in pike08:02
d0ugalrakhmerov: oh, good, then you can help me fix CI :-D08:03
rakhmerovd0ugal: can you aprove the backport https://review.openstack.org/#/c/562113/ for now? to queens08:03
d0ugalrakhmerov: sure08:03
rakhmerovd0ugal: yeah, I'll have to :) But later, still working on the issues themselves08:03
d0ugalk08:03
rakhmerovthanks08:03
d0ugalrakhmerov: btw I will be tagging Rocky-1 this week08:03
d0ugalProbably today or tomorrow so I don't forget08:03
rakhmerovno issue from my side08:04
d0ugalI guess nobody ever uses our 1st milestone tags :)08:04
rakhmerovyes )08:04
*** gkadam has joined #openstack-mistral08:07
openstackgerritMerged openstack/mistral stable/queens: Correct the string formatting in a info log message  https://review.openstack.org/56204508:35
*** zhurong has joined #openstack-mistral08:38
rakhmerovd0ugal, apetrich: please also review https://review.openstack.org/561899 https://review.openstack.org/56211909:03
rakhmerovit wasn't lucky with CI but now it passed09:03
d0ugal:)09:03
rakhmerov(failures weren't related to the patch)09:03
*** jtomasek has quit IRC09:07
*** itlinux has joined #openstack-mistral09:40
openstackgerritAdriano Petrich proposed openstack/python-mistralclient master: Do not let keystoneauth mask the errors  https://review.openstack.org/56173209:44
*** itlinux has quit IRC09:49
apetrichd0ugal, the even simpler solution ^^09:57
*** zhurong has quit IRC09:57
*** itlinux has joined #openstack-mistral10:01
therveapetrich, The commit message needs to be updated10:04
d0ugal^ what I was just typing10:04
apetrichoh true10:05
therveSo I'm pretty sure it has been introduced by https://review.openstack.org/#/c/455174/10:05
d0ugalI think the fix is fine, a little hacky, but I don't have a better idea10:05
apetrichcheers therve and d0ugal10:05
therveI thought I fixed it, but it probably got lost in the shuffle :/10:05
openstackgerritAdriano Petrich proposed openstack/python-mistralclient master: Do not let keystoneauth mask the errors  https://review.openstack.org/56173210:06
d0ugaltherve: is there another way to fix it?10:09
d0ugalWondering if I have the patience to trawl through that review and see if I can find it :)10:09
openstackgerritMerged openstack/mistral stable/queens: Optimizing big 'on-XXX' clauses  https://review.openstack.org/56211310:26
rakhmerovapetrich: pls https://review.openstack.org/#/c/561899/10:45
apetrichrakhmerov, I'm looking at it10:50
apetrichlgtm10:50
*** pgaxatte has quit IRC10:51
rakhmerovthanks )10:51
*** pgaxatte has joined #openstack-mistral11:02
*** itlinux has quit IRC11:34
*** thrash|g0ne is now known as thrash11:39
therved0ugal, I'm pretty sure my solution was different, but I can't find it11:44
apetrichd0ugal, I did that because that was a pattern we were already using in that file here https://github.com/openstack/python-mistralclient/blob/master/mistralclient/api/httpclient.py#L15011:48
d0ugalapetrich: right, makes sense11:49
d0ugalapetrich: I am mostly fine with it, I just want my errors back on the CLI :)11:49
* apetrich thinks how to add more errors in cli for d0ugal 11:50
d0ugalyes please11:50
apetrichshame this review process that makes it harder to do so11:50
d0ugalapetrich: we should backport it too11:50
apetrichd0ugal, agreed11:50
apetrichat least to pike11:51
apetrichright?11:51
apetrichmaybe not. when did that change got in. just rocky might do11:51
apetrichqueens*11:51
d0ugalapetrich: Yeah, I think just Queens11:52
openstackgerritDougal Matthews proposed openstack/python-mistralclient stable/pike: Do not let keystoneauth mask the errors  https://review.openstack.org/56225311:52
d0ugalInteresting, I wonderd if it would cleanly backport to pike - it does.11:52
apetrichit patches but does not make sense because we are not using keystone1 sessions there11:55
d0ugalTrue :)11:55
therveOh, hum11:56
therved0ugal, It should have been fixed by https://review.openstack.org/#/c/455174/4011:56
d0ugaltherve: with the try/excepts?11:57
d0ugalhttps://review.openstack.org/#/c/455174/40/mistralclient/api/base.py11:57
therved0ugal, Yeah, and the raise_api_exception stuff11:57
*** katkapilatova has joined #openstack-mistral11:57
d0ugalapetrich: ^ WDYT?11:57
d0ugalbbiab11:58
*** itlinux has joined #openstack-mistral11:59
apetrichtherve, oh11:59
apetrichtherve, d0ugal  I'm marking my patch as -W and going to investigate why that is not working12:01
*** katkapilatova has quit IRC12:02
therveapetrich, Ah, so it works if you use ResourceManager methods, but not if you use http_client directly12:11
apetrichtherve, I see. some api resource managers do not call the _methods12:11
therveYeah12:11
apetrichlol12:12
therveApparently those methods don't support some stuff12:12
therveLike lists of objects12:12
apetrichaye12:12
apetrichon the other hand this line should have done just that https://github.com/openstack/python-mistralclient/blob/master/mistralclient/api/v2/action_executions.py#L4712:13
therveapetrich, Right but you don't get here because you don't have https://github.com/openstack/python-mistralclient/blob/master/mistralclient/api/base.py#L9612:14
apetrichtrue12:15
*** jtomasek has joined #openstack-mistral12:15
therveIt'd be nice if the logic was in ResourceManager12:15
therveThey all inherit from it after all12:16
therveapetrich, http://paste.openstack.org/show/719462/ it should probably not there12:20
apetrichagreed12:20
*** rbrady has joined #openstack-mistral12:26
*** rbrady has quit IRC12:26
*** rbrady has joined #openstack-mistral12:26
*** Alexey_Abashkin has joined #openstack-mistral12:31
*** AlexeyAbashkin has quit IRC12:33
*** Alexey_Abashkin is now known as AlexeyAbashkin12:33
*** apetrich_ has joined #openstack-mistral12:48
*** itlinux has quit IRC12:51
*** apetrich_ has quit IRC12:55
*** hardikjasani has quit IRC13:22
*** toure|biab is now known as toure13:29
*** itlinux has joined #openstack-mistral13:32
*** itlinux has quit IRC13:40
*** itlinux has joined #openstack-mistral13:54
openstackgerritDoug Hellmann proposed openstack/mistral master: add lower-constraints job  https://review.openstack.org/55582413:55
openstackgerritAdriano Petrich proposed openstack/python-mistralclient master: Do not let keystoneauth mask the errors  https://review.openstack.org/56173214:03
apetrichtherve, d0ugal not the best solution but it is what I can come up for now. we might need to tech debt better resource manager base methods to deal better with that14:04
apetrich^^14:04
therveapetrich, That looks OK to me yeah14:05
*** bobh has joined #openstack-mistral14:13
*** itlinux has quit IRC14:15
*** gkadam has quit IRC14:16
*** itlinux has joined #openstack-mistral14:19
d0ugalapetrich: LTGM14:32
d0ugalapetrich: two things tho' ...14:32
d0ugalA release note would be super, particularly since we want to backport14:32
d0ugaland if you could open a bug for the remaining issue, that would be good - so we have a record of it14:33
d0ugalIt can probably just be a copy/paste of the commit message.14:33
apetrichd0ugal, aye14:33
apetrich2 minutes14:33
openstackgerritAdriano Petrich proposed openstack/python-mistralclient master: Do not let keystoneauth mask the errors  https://review.openstack.org/56173214:40
d0ugalta14:40
apetrichhttps://bugs.launchpad.net/mistral/+bug/176508714:43
openstackLaunchpad bug 1765087 in Mistral "Some resourcemanagers are not using the base underscore methods" [Low,Triaged]14:43
d0ugalapetrich: cheers!14:45
*** itlinux has quit IRC15:31
*** itlinux has joined #openstack-mistral15:58
*** harlowja has joined #openstack-mistral16:06
*** jpich has quit IRC16:07
*** AlexeyAbashkin has quit IRC16:23
*** shardy has quit IRC16:42
*** szaher has quit IRC16:53
*** szaher has joined #openstack-mistral17:04
*** thrash is now known as thrash|biab17:16
*** bobh has quit IRC17:41
*** harlowja has quit IRC17:44
*** AlexeyAbashkin has joined #openstack-mistral17:46
*** thrash|biab is now known as thrash17:47
*** itlinux has quit IRC17:48
*** AlexeyAbashkin has quit IRC17:51
*** itlinux has joined #openstack-mistral17:54
*** bobh has joined #openstack-mistral18:16
*** harlowja has joined #openstack-mistral18:18
*** harlowja_ has joined #openstack-mistral18:23
*** harlowja has quit IRC18:24
*** itlinux has quit IRC18:35
*** bobh has quit IRC18:39
*** bobh has joined #openstack-mistral18:40
*** itlinux has joined #openstack-mistral18:40
*** bobh has quit IRC19:04
*** bobh has joined #openstack-mistral19:35
*** apetrich_ has joined #openstack-mistral21:27
*** bobh has quit IRC21:44
*** bobh has joined #openstack-mistral21:44
*** apetrich_ has quit IRC21:49
*** itlinux has quit IRC22:32
*** thrash is now known as thrash|g0ne22:38
*** AlexeyAbashkin has joined #openstack-mistral22:45
*** bobh has quit IRC22:47
*** bobh has joined #openstack-mistral22:47
*** AlexeyAbashkin has quit IRC22:50
*** bobh has quit IRC22:55
« Tuesday, 2018-04-17 Index Thursday, 2018-04-19 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!