Friday, 2018-04-13

*** itlinux has quit IRC00:03
*** itlinux has joined #openstack-mistral00:06
*** itlinux has quit IRC00:41
*** itlinux has joined #openstack-mistral00:46
*** harlowja has quit IRC00:52
*** yangyape_ has quit IRC00:57
*** itlinux has quit IRC00:58
*** itlinux has joined #openstack-mistral01:08
*** itlinux has quit IRC01:10
*** itlinux has joined #openstack-mistral01:20
*** yangyapeng has joined #openstack-mistral01:33
*** itlinux has quit IRC01:35
*** yangyapeng has quit IRC01:39
*** yangyapeng has joined #openstack-mistral01:56
*** yangyapeng has quit IRC01:58
*** d0ugal has quit IRC02:43
*** d0ugal has joined #openstack-mistral02:50
*** itlinux has joined #openstack-mistral03:49
*** openstackgerrit has joined #openstack-mistral04:21
openstackgerritVitalii Solodilov proposed openstack/mistral master: Replaced action timeout with action deadline  https://review.openstack.org/56111804:21
*** itlinux has quit IRC04:23
*** hardikjasani has joined #openstack-mistral04:33
*** harlowja has joined #openstack-mistral04:44
*** harlowja has quit IRC05:39
*** jaosorior has joined #openstack-mistral06:21
*** AlexeyAbashkin has joined #openstack-mistral06:37
*** shardy has joined #openstack-mistral06:39
openstackgerritAdriano Petrich proposed openstack/mistral master: Only allow for deleting completed executions  https://review.openstack.org/56080206:42
*** AlexeyAbashkin has quit IRC06:58
*** jtomasek has joined #openstack-mistral07:13
rakhmerovd0ugal: hi, how is it going?07:22
rakhmerovI see that you're doing a lot in LP :)07:23
rakhmerovit's a good thing07:23
*** AlexeyAbashkin has joined #openstack-mistral07:41
*** AlexeyAbashkin has quit IRC07:46
d0ugalrakhmerov: Hey - doing well thanks, how are you?07:50
d0ugalrakhmerov: yeah, I think the bugs are slowly getting under control :)07:50
rakhmerovd0ugal: awesome!07:50
d0ugalI hope I am doing it correctly :)07:50
rakhmerovyeah07:51
rakhmerovI just wasn't sure about I think one bug that you closed yesterday07:51
rakhmerovlet me see07:51
rakhmerovoverall I'm good.. Making a change to optimize something again07:51
d0ugalI guessed if people cared about a bug they would tell me :-D07:51
rakhmerovMistral can devour a lot of memory if we have a big 'on-XXX' list07:52
rakhmerovyes )07:52
d0ugaloh, interesting07:52
d0ugalHow big is big?07:52
rakhmerovok07:53
rakhmerovfor example, if we have 500 tasks listed there I saw memory growth around 5 GB07:53
rakhmerovthe key thing is that task objects may be pretty heavy07:54
rakhmerovcontext, published and spec fields07:54
rakhmerovsome of the things get copied..07:54
rakhmerovand process them in a single loop within a single TX07:54
rakhmerov=> it consumes a huge amount of RAM and gets stuck for a while07:54
rakhmerovd0ugal: so https://bugs.launchpad.net/mistral/+bug/159366607:55
openstackLaunchpad bug 1593666 in Mistral "test_mistral_basic_v2.WorkflowTestsV2 causes DB deadlock sometimes" [High,Invalid]07:55
rakhmerovI really saw this deadlock not so long ago but as far as I remember Andras might have fixed it07:56
d0ugalrakhmerov: right07:56
rakhmerovso I'm just not sure about the status 'invalid' but the problem itself should be solved07:56
rakhmerovthis part is ok07:56
d0ugalI can change it to fixed released?07:56
rakhmerovyeah, but lemme check the history of commits first..07:56
d0ugalI just marked it as Invalid as there seemed to be bugs marked as "Incomplete" to close them, but they are not closed.07:56
d0ugalactually, no, Incomplete was probably correct for that07:57
d0ugalbug I figured if a bug is Incomplete for almost a year it can be closed :)07:57
rakhmerovhm..07:57
rakhmerovyes, that's right. I agree07:57
rakhmerovno need to keep them for so long07:58
d0ugalIncomplete means to me that we are waiting for more information to move the bug forward, but if we don't get it we should close it (we can always open again later)07:58
rakhmerovok, so07:59
rakhmerovI can't find a commit where this problem would be explicitly solved07:59
rakhmerovseems like it was a side effect of some of them07:59
d0ugalRight07:59
rakhmerovAndras told me which one but I forgot07:59
rakhmerovnevermind, it's not so important I guess08:00
d0ugal:)08:00
d0ugalI guess we can just leave the bug as it is and either reopen it or open a new bug if we find the problem again08:00
d0ugal#startmeeting mistral08:00
openstackMeeting started Fri Apr 13 08:00:50 2018 UTC and is due to finish in 60 minutes.  The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot.08:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.08:00
*** openstack changes topic to " (Meeting topic: mistral)"08:00
openstackThe meeting name has been set to 'mistral'08:00
d0ugalIt is the Friday office hour! \o/08:01
d0ugalI am probably going to try and do some more triage today. I have done quite a bit over the last week.08:01
d0ugalhttps://etherpad.openstack.org/p/mistral-office-hours08:01
d0ugalI added some useful lauchpad links to the etherpad to help with this.08:02
d0ugalBut also happy to discuss any topics that people might have.08:02
pgaxattehello, I happen to have a question :)08:02
d0ugalpgaxatte: sure, ask away!08:02
pgaxattei don't get the openstack action definition create08:03
pgaxattei haven't seen documentation on this and I don't see what I could create with this call08:03
pgaxattesince a new action would need a python module on the server08:03
d0ugalpgaxatte: Have you seen ad-hoc actions?08:04
d0ugalhttps://docs.openstack.org/mistral/mitaka/dsl/dsl_v2.html#ad-hoc-actions08:04
d0ugalI have never actually made them with this CLI command08:04
pgaxatteohhhh ok08:05
pgaxatteit is used to make custom actions that extend available actions08:06
d0ugalpgaxatte: yes, I believe so08:06
d0ugalI have only created ad-hoc actions with workbook files, but I believe that is what the CLI is for08:06
d0ugalrakhmerov: can you confirm?08:06
pgaxattethe reason I stumbled on this is that I need to remove some actions which we won't use / don't want to provide08:06
d0ugalpgaxatte: I see - which actions do you want to remove?08:07
*** gkadam has joined #openstack-mistral08:07
pgaxattestd.{email,js,javascript,http,ssh...} and the parts of the openstack api that we don't have08:08
d0ugalpgaxatte: there is no way that I know to remove the std.* actions, but you can remove the openstack actions.08:08
pgaxatteis there a way to make some actions admin only?08:09
d0ugalpgaxatte: You need to provide the populate command a custom mapping file: https://github.com/openstack/mistral/blob/master/mistral/actions/openstack/mapping.json08:09
d0ugalpgaxatte: I don't believe so.08:09
pgaxatted0ugal: thanks I'll check that out08:09
pgaxattewe are trying to see if we can safely provide mistral to our customers but we'd like to avoid people who spam/execute funny stuff through mistral08:10
d0ugalyeah, makes sense.08:10
rakhmerovhey08:10
rakhmerovgive me 1 min08:10
rakhmerovreading...08:11
pgaxattestd.email is easy to disable, I just need to not configure emails :)08:11
rakhmerovd0ugal: I confirm, yes08:12
rakhmerovthis CLI command is for uploading ad-hoc actions08:12
rakhmerovbecause for other actions there's more to do to make them work (server side code, plugin conf in setup.cfg etc.)08:12
d0ugalrakhmerov: is there a way to restrict the std.* actions? either to remove them or specific users only?08:14
rakhmerovd0ugal: btw, it's a really valid inquiry to be able to remove actions08:15
rakhmerovnope08:15
rakhmerovthe only way I could think of is just to delete lines from setup.cfg08:15
*** jpich has joined #openstack-mistral08:16
rakhmerovso that they don't get registered in DB during installation08:16
rakhmerovd0ugal: seems like it again falls into what we discussed at the PTG about refactoring of actions08:16
rakhmerovaction providers etc.08:16
d0ugalyeah08:16
d0ugalI want to try and look at that soon.08:16
rakhmerovwhen we get there we could include this requirement into the list of work items08:16
rakhmerovyeah08:17
rakhmerovit'd be awesome08:17
pgaxatterakhmerov: I guess that would mean building a custom mistral-common package (on ubuntu) with a modified setup.cfg08:17
rakhmerovd0ugal: I'll get to back to the community work I hope soon too. Once I fix some critical bugs08:17
d0ugal:)08:17
rakhmerovd0ugal: as far as the issue I described today with memory consumption, it's pretty interesting one. I think we'll have to change the architecture a little bit08:19
rakhmerovit'd be an interesting task08:20
d0ugalWhat change do you have in mind?08:20
apetrichrakhmerov, sorry for the empty release note template.. LOL I did that on my laptop and forgot to send it to this computer08:21
rakhmerovd0ugal: most likely we shouldn't process all tasks in "on-XXX" at once08:23
rakhmerovapetrich: that's fine ) No worries08:23
d0ugalrakhmerov: Maybe we could add a concurrency to it? or have it respect the task concurrency?08:25
d0ugalor do you just think they should be sequential?08:25
rakhmerovd0ugal: yeah, maybe08:25
rakhmerovI'm thinking about it now and doing some more experiments08:25
rakhmerovI think I'll roll out something early next week08:26
rakhmerovd0ugal: well, theoretically yes, we can process that in parallel08:26
rakhmerovto some extent at least08:26
rakhmerovok, that's just something I wanted to share a little bit08:26
rakhmerovhave been busy with it the whole week08:27
rakhmerovd0ugal: so what about bug triaging? )08:27
d0ugalSounds interesting!08:27
d0ugalrakhmerov: well, we still have 20 NEW bugs: https://bugs.launchpad.net/mistral/+bugs?search=Search&field.status=New&orderby=id&start=008:27
d0ugaland 19 UNDECIDED: https://bugs.launchpad.net/mistral/+bugs?search=Search&field.importance=Undecided&orderby=id&start=008:28
d0ugal(many of these overlap)08:28
rakhmerovyep08:28
rakhmerovI'm ready to discuss whatever is needed08:28
d0ugalso I think only 20 in total that need to be triaged08:28
rakhmerovok08:28
d0ugalrakhmerov: thanks08:28
d0ugalI don't know of any that need discussed yet, they just need processed :)08:28
d0ugalWe need to move them to triaged if they seem valid, set a priority and add any relevant tags.08:29
rakhmerovlet's do it then?08:29
d0ugalSure08:29
d0ugalrakhmerov: do you want to start at the top of the list?08:30
rakhmerovsure08:30
d0ugalhttps://bugs.launchpad.net/mistral/+bugs?search=Search&field.status=New&orderby=-date_last_updated&start=008:30
d0ugalThat is sorted by date, so should be a consistent view for both of us.08:30
rakhmerovhttps://bugs.launchpad.net/mistral/+bug/141353508:30
openstackLaunchpad bug 1413535 in Mistral "Method DbTestCase.heavy_init() gets called more than once if we run tests via tox" [Medium,New] - Assigned to Nikolay Makhotkin (nmakhotkin)08:30
rakhmerovthere was really a problem with this one08:30
rakhmerovwith tox08:30
rakhmerovseems like because of testr08:31
rakhmerovbecause it may run tests in parallel08:31
d0ugalInteresting.08:31
rakhmerovso it still looks valid for me but I have no idea how to fix it )08:31
d0ugalI don't really understand it.08:31
d0ugalhaha, I don't either.08:31
d0ugalOkay - I guess we can just mark it as triaged08:31
rakhmerovyes08:32
rakhmerovso, to be precise: not even just "in parallel" but, what's more important, in different processes08:32
d0ugalhttps://bugs.launchpad.net/mistral/+bug/155683908:33
openstackLaunchpad bug 1556839 in Mistral "can not generate a snapshot name include date" [Undecided,New] - Assigned to lvdongbing (dbcocle)08:33
d0ugalIn YAQL there is a date function, so I think this is invalid08:34
d0ugalMaybe there wasn't in 2016 :)08:34
*** shardy has quit IRC08:35
d0ugal<% "{0}/{1}.yaml".format($.type, now().format("%Y-%m-%d_%H:%M:%S")) %>08:35
rakhmerovyeah..08:35
d0ugal^ we use that in one of our workflows.08:35
rakhmerovI don't think it's a Mistral problem08:35
rakhmerovit's a matter of how to use it08:35
rakhmerovseems just invalid to me08:36
d0ugalI hope they were not waiting 2 years for that :)08:36
d0ugalhttps://bugs.launchpad.net/mistral/+bug/158321008:36
openstackLaunchpad bug 1583210 in Mistral "Mistral Step incorrectly reporting success" [Undecided,New] - Assigned to Hardik Parekh (hardik-parekh047)08:36
openstackgerritAdriano Petrich proposed openstack/mistral master: Only allow for deleting completed executions  https://review.openstack.org/56080208:36
d0ugalI think that bug is a confusion between action executions and tasks. In their case I think the action is successful but the task isn't.08:37
rakhmerovd0ugal: looking..08:37
rakhmerovyes, you're right08:38
d0ugalrakhmerov: and I think you said this in the comment :)08:39
rakhmerovyep )08:39
rakhmerovd0ugal: not even sure whether we need to be solving it somehow08:39
d0ugalI don't think so08:39
rakhmerovyes08:39
d0ugalHow can we solve it? if the task has an error it has an error and we need to show that :)08:40
rakhmerovwell, just a sec..08:40
d0ugalClosing it.08:40
d0ugaloh, okay08:40
d0ugalwaiting08:40
rakhmerovso08:40
rakhmerovI was just trying to understand precisely what the request was )08:40
openstackgerritAdriano Petrich proposed openstack/python-mistralclient master: WIP force delete executions  https://review.openstack.org/56115908:40
rakhmerovand seems like there's no request to change anything08:40
rakhmerovyeah, I think it was just wrong understanding of these mechanisms08:41
rakhmerovlet's close it, I agree08:41
d0ugalok08:42
d0ugalhttps://bugs.launchpad.net/mistral/+bug/162444508:42
openstackd0ugal: Error: malone bug 1624445 not found08:42
d0ugalhmm08:42
d0ugalhttps://bugs.launchpad.net/mistral/+bug/162444508:42
d0ugalNext bug ^ I'm still clsoing this one.08:42
d0ugaloh, it is private that is why openstack can't fetch it :)08:42
rakhmerovyes08:43
rakhmerovI see it08:43
rakhmerovd0ugal: why closing?08:43
rakhmerovyou mean https://bugs.launchpad.net/mistral/+bug/1624445 ?08:44
openstackrakhmerov: Error: malone bug 1624445 not found08:44
d0ugalrakhmerov: I am still closing the previous one (well, commenting to explain why)08:44
rakhmerovooh, ok08:44
d0ugalrakhmerov: I don't think this needs to be private?08:45
rakhmerovhm..08:46
rakhmerovnot sure either08:46
rakhmerovseems like yes, there's a problem but it can't be used to compromise something..08:46
d0ugalAgreed. I'll remove the private flag08:47
d0ugalI think there is enough information here, so I'll mark it as Triaged and Medium.08:47
rakhmerovyes08:47
rakhmerovlooking at https://bugs.launchpad.net/mistral/+bug/164047908:49
openstackLaunchpad bug 1640479 in Mistral "401 issue while installing mistral in Openstack" [Undecided,New]08:49
d0ugalHmm08:50
d0ugalThere is really not very much information there.08:50
rakhmerovd0ugal: "With Openstack mitaka setup" :)08:51
rakhmerovvery very old08:51
d0ugallol, yeah08:51
rakhmerovlet's close it08:51
d0ugalI have never even used that Mistral :)08:51
d0ugalAgreed08:51
rakhmerovI don't think it's relevant08:51
rakhmerovhttps://bugs.launchpad.net/mistral/+bug/164384008:52
openstackLaunchpad bug 1643840 in Mistral "How to check where are the bugs when the execution status is error" [Undecided,New]08:52
*** shardy has joined #openstack-mistral08:52
rakhmerovso, on that one: a known thing, yeah, and I already replied that we're working on making this kind of investigation easier08:53
rakhmerovI'd say we don't need to keep this 'bug', it's just another evidence for us that what we started doing in that direction is important for users08:54
d0ugalAgreed08:54
rakhmerovand revisit our activities on that08:54
rakhmerovhttps://bugs.launchpad.net/mistral/+bug/164864608:55
openstackLaunchpad bug 1648646 in Mistral "os_actions_endpoint_type not in generated config file" [Undecided,New]08:55
d0ugalInteresting.08:56
d0ugalI am sure I have seen the [api] section at least08:56
d0ugalI should try this...08:56
rakhmerov:)08:57
rakhmerovAndras also complained that some of the options didn't get to a generated config08:58
rakhmerovdon't remember though what they were08:58
d0ugalokay, so we should investigate this.08:59
d0ugalI remember Andras complaining about it too :)09:00
rakhmerovyeah09:00
d0ugalOkay, we are at the end of the hour.09:00
rakhmerovd0ugal: btw, it should get into the default group09:00
d0ugalI might do a little bit more, but I'll stop the bot before I forget.09:00
d0ugal#endmeeting09:00
*** openstack changes topic to " (Meeting topic: test)"09:00
openstackMeeting ended Fri Apr 13 09:00:28 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)09:00
openstackMinutes:        http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-13-08.00.html09:00
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-13-08.00.txt09:00
openstackLog:            http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-13-08.00.log.html09:00
d0ugalrakhmerov: Move what into the default group?09:00
rakhmerovd0ugal: this config option is not in the [api] group, it's in the default group09:00
d0ugaloh09:01
rakhmerovyep, I looked at the code09:02
rakhmerovd0ugal: so we'll stop with triaging for now?09:02
rakhmerovtill the next office hours?09:02
rakhmerov(which works for me, I just wanna clarify..)09:02
d0ugalrakhmerov: yeah, lets stop09:03
rakhmerovok09:03
d0ugalThere are only 13 left, so we should be finished by the end of next week :)09:03
rakhmerov13 bugs left09:03
d0ugalThen hopefully we can do it regularly and never let it build up again09:03
rakhmerovgood, yep09:03
d0ugalWe only have 116 bugs in total!09:03
rakhmerovtotally for it09:03
rakhmerov:)09:03
d0ugalrakhmerov: Thanks for your help.09:04
rakhmerovsure09:04
rakhmerovd0ugal: please ping me when you start office hours, I may just be focused on something and forget that we gather at that time )09:05
d0ugalrakhmerov: will do.09:06
openstackgerritRenat Akhmerov proposed openstack/mistral master: Adding a test for std.test_dict action  https://review.openstack.org/56117409:32
openstackgerritRenat Akhmerov proposed openstack/mistral master: WIP: Optimizing big 'on-XXX' clauses  https://review.openstack.org/56117509:32
*** katkapilatova has joined #openstack-mistral12:17
*** hardikjasani has quit IRC13:13
*** jaosorior has quit IRC13:27
*** bobh has joined #openstack-mistral14:05
*** katkapilatova has quit IRC14:41
*** AlexeyAbashkin has joined #openstack-mistral14:45
*** AlexeyAbashkin has quit IRC14:49
*** openstackgerrit has quit IRC14:50
*** livelace-link has joined #openstack-mistral15:10
*** pgaxatte has left #openstack-mistral15:33
*** itlinux has joined #openstack-mistral15:48
*** gkadam has quit IRC16:21
*** jpich has quit IRC16:57
*** shardy has quit IRC17:09
bobhd0ugal: can you take a look at https://review.openstack.org/#/c/553910/ when you get a chance?17:40
*** harlowja has joined #openstack-mistral19:10
*** bobh has quit IRC20:20
*** bobh_ has joined #openstack-mistral20:20
*** d0ugal has quit IRC20:59
*** d0ugal has joined #openstack-mistral21:26
*** gkadam has joined #openstack-mistral21:30
*** bobh_ has quit IRC21:45
*** openstackgerrit has joined #openstack-mistral21:57
openstackgerritMerged openstack/mistral master: Update Duplicate entry exceptions to provide more information  https://review.openstack.org/55391021:57
*** gkadam has quit IRC21:58
*** itlinux has quit IRC22:27

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!