*** itlinux has quit IRC | 00:03 | |
*** itlinux has joined #openstack-mistral | 00:06 | |
*** itlinux has quit IRC | 00:41 | |
*** itlinux has joined #openstack-mistral | 00:46 | |
*** harlowja has quit IRC | 00:52 | |
*** yangyape_ has quit IRC | 00:57 | |
*** itlinux has quit IRC | 00:58 | |
*** itlinux has joined #openstack-mistral | 01:08 | |
*** itlinux has quit IRC | 01:10 | |
*** itlinux has joined #openstack-mistral | 01:20 | |
*** yangyapeng has joined #openstack-mistral | 01:33 | |
*** itlinux has quit IRC | 01:35 | |
*** yangyapeng has quit IRC | 01:39 | |
*** yangyapeng has joined #openstack-mistral | 01:56 | |
*** yangyapeng has quit IRC | 01:58 | |
*** d0ugal has quit IRC | 02:43 | |
*** d0ugal has joined #openstack-mistral | 02:50 | |
*** itlinux has joined #openstack-mistral | 03:49 | |
*** openstackgerrit has joined #openstack-mistral | 04:21 | |
openstackgerrit | Vitalii Solodilov proposed openstack/mistral master: Replaced action timeout with action deadline https://review.openstack.org/561118 | 04:21 |
---|---|---|
*** itlinux has quit IRC | 04:23 | |
*** hardikjasani has joined #openstack-mistral | 04:33 | |
*** harlowja has joined #openstack-mistral | 04:44 | |
*** harlowja has quit IRC | 05:39 | |
*** jaosorior has joined #openstack-mistral | 06:21 | |
*** AlexeyAbashkin has joined #openstack-mistral | 06:37 | |
*** shardy has joined #openstack-mistral | 06:39 | |
openstackgerrit | Adriano Petrich proposed openstack/mistral master: Only allow for deleting completed executions https://review.openstack.org/560802 | 06:42 |
*** AlexeyAbashkin has quit IRC | 06:58 | |
*** jtomasek has joined #openstack-mistral | 07:13 | |
rakhmerov | d0ugal: hi, how is it going? | 07:22 |
rakhmerov | I see that you're doing a lot in LP :) | 07:23 |
rakhmerov | it's a good thing | 07:23 |
*** AlexeyAbashkin has joined #openstack-mistral | 07:41 | |
*** AlexeyAbashkin has quit IRC | 07:46 | |
d0ugal | rakhmerov: Hey - doing well thanks, how are you? | 07:50 |
d0ugal | rakhmerov: yeah, I think the bugs are slowly getting under control :) | 07:50 |
rakhmerov | d0ugal: awesome! | 07:50 |
d0ugal | I hope I am doing it correctly :) | 07:50 |
rakhmerov | yeah | 07:51 |
rakhmerov | I just wasn't sure about I think one bug that you closed yesterday | 07:51 |
rakhmerov | let me see | 07:51 |
rakhmerov | overall I'm good.. Making a change to optimize something again | 07:51 |
d0ugal | I guessed if people cared about a bug they would tell me :-D | 07:51 |
rakhmerov | Mistral can devour a lot of memory if we have a big 'on-XXX' list | 07:52 |
rakhmerov | yes ) | 07:52 |
d0ugal | oh, interesting | 07:52 |
d0ugal | How big is big? | 07:52 |
rakhmerov | ok | 07:53 |
rakhmerov | for example, if we have 500 tasks listed there I saw memory growth around 5 GB | 07:53 |
rakhmerov | the key thing is that task objects may be pretty heavy | 07:54 |
rakhmerov | context, published and spec fields | 07:54 |
rakhmerov | some of the things get copied.. | 07:54 |
rakhmerov | and process them in a single loop within a single TX | 07:54 |
rakhmerov | => it consumes a huge amount of RAM and gets stuck for a while | 07:54 |
rakhmerov | d0ugal: so https://bugs.launchpad.net/mistral/+bug/1593666 | 07:55 |
openstack | Launchpad bug 1593666 in Mistral "test_mistral_basic_v2.WorkflowTestsV2 causes DB deadlock sometimes" [High,Invalid] | 07:55 |
rakhmerov | I really saw this deadlock not so long ago but as far as I remember Andras might have fixed it | 07:56 |
d0ugal | rakhmerov: right | 07:56 |
rakhmerov | so I'm just not sure about the status 'invalid' but the problem itself should be solved | 07:56 |
rakhmerov | this part is ok | 07:56 |
d0ugal | I can change it to fixed released? | 07:56 |
rakhmerov | yeah, but lemme check the history of commits first.. | 07:56 |
d0ugal | I just marked it as Invalid as there seemed to be bugs marked as "Incomplete" to close them, but they are not closed. | 07:56 |
d0ugal | actually, no, Incomplete was probably correct for that | 07:57 |
d0ugal | bug I figured if a bug is Incomplete for almost a year it can be closed :) | 07:57 |
rakhmerov | hm.. | 07:57 |
rakhmerov | yes, that's right. I agree | 07:57 |
rakhmerov | no need to keep them for so long | 07:58 |
d0ugal | Incomplete means to me that we are waiting for more information to move the bug forward, but if we don't get it we should close it (we can always open again later) | 07:58 |
rakhmerov | ok, so | 07:59 |
rakhmerov | I can't find a commit where this problem would be explicitly solved | 07:59 |
rakhmerov | seems like it was a side effect of some of them | 07:59 |
d0ugal | Right | 07:59 |
rakhmerov | Andras told me which one but I forgot | 07:59 |
rakhmerov | nevermind, it's not so important I guess | 08:00 |
d0ugal | :) | 08:00 |
d0ugal | I guess we can just leave the bug as it is and either reopen it or open a new bug if we find the problem again | 08:00 |
d0ugal | #startmeeting mistral | 08:00 |
openstack | Meeting started Fri Apr 13 08:00:50 2018 UTC and is due to finish in 60 minutes. The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot. | 08:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 08:00 |
*** openstack changes topic to " (Meeting topic: mistral)" | 08:00 | |
openstack | The meeting name has been set to 'mistral' | 08:00 |
d0ugal | It is the Friday office hour! \o/ | 08:01 |
d0ugal | I am probably going to try and do some more triage today. I have done quite a bit over the last week. | 08:01 |
d0ugal | https://etherpad.openstack.org/p/mistral-office-hours | 08:01 |
d0ugal | I added some useful lauchpad links to the etherpad to help with this. | 08:02 |
d0ugal | But also happy to discuss any topics that people might have. | 08:02 |
pgaxatte | hello, I happen to have a question :) | 08:02 |
d0ugal | pgaxatte: sure, ask away! | 08:02 |
pgaxatte | i don't get the openstack action definition create | 08:03 |
pgaxatte | i haven't seen documentation on this and I don't see what I could create with this call | 08:03 |
pgaxatte | since a new action would need a python module on the server | 08:03 |
d0ugal | pgaxatte: Have you seen ad-hoc actions? | 08:04 |
d0ugal | https://docs.openstack.org/mistral/mitaka/dsl/dsl_v2.html#ad-hoc-actions | 08:04 |
d0ugal | I have never actually made them with this CLI command | 08:04 |
pgaxatte | ohhhh ok | 08:05 |
pgaxatte | it is used to make custom actions that extend available actions | 08:06 |
d0ugal | pgaxatte: yes, I believe so | 08:06 |
d0ugal | I have only created ad-hoc actions with workbook files, but I believe that is what the CLI is for | 08:06 |
d0ugal | rakhmerov: can you confirm? | 08:06 |
pgaxatte | the reason I stumbled on this is that I need to remove some actions which we won't use / don't want to provide | 08:06 |
d0ugal | pgaxatte: I see - which actions do you want to remove? | 08:07 |
*** gkadam has joined #openstack-mistral | 08:07 | |
pgaxatte | std.{email,js,javascript,http,ssh...} and the parts of the openstack api that we don't have | 08:08 |
d0ugal | pgaxatte: there is no way that I know to remove the std.* actions, but you can remove the openstack actions. | 08:08 |
pgaxatte | is there a way to make some actions admin only? | 08:09 |
d0ugal | pgaxatte: You need to provide the populate command a custom mapping file: https://github.com/openstack/mistral/blob/master/mistral/actions/openstack/mapping.json | 08:09 |
d0ugal | pgaxatte: I don't believe so. | 08:09 |
pgaxatte | d0ugal: thanks I'll check that out | 08:09 |
pgaxatte | we are trying to see if we can safely provide mistral to our customers but we'd like to avoid people who spam/execute funny stuff through mistral | 08:10 |
d0ugal | yeah, makes sense. | 08:10 |
rakhmerov | hey | 08:10 |
rakhmerov | give me 1 min | 08:10 |
rakhmerov | reading... | 08:11 |
pgaxatte | std.email is easy to disable, I just need to not configure emails :) | 08:11 |
rakhmerov | d0ugal: I confirm, yes | 08:12 |
rakhmerov | this CLI command is for uploading ad-hoc actions | 08:12 |
rakhmerov | because for other actions there's more to do to make them work (server side code, plugin conf in setup.cfg etc.) | 08:12 |
d0ugal | rakhmerov: is there a way to restrict the std.* actions? either to remove them or specific users only? | 08:14 |
rakhmerov | d0ugal: btw, it's a really valid inquiry to be able to remove actions | 08:15 |
rakhmerov | nope | 08:15 |
rakhmerov | the only way I could think of is just to delete lines from setup.cfg | 08:15 |
*** jpich has joined #openstack-mistral | 08:16 | |
rakhmerov | so that they don't get registered in DB during installation | 08:16 |
rakhmerov | d0ugal: seems like it again falls into what we discussed at the PTG about refactoring of actions | 08:16 |
rakhmerov | action providers etc. | 08:16 |
d0ugal | yeah | 08:16 |
d0ugal | I want to try and look at that soon. | 08:16 |
rakhmerov | when we get there we could include this requirement into the list of work items | 08:16 |
rakhmerov | yeah | 08:17 |
rakhmerov | it'd be awesome | 08:17 |
pgaxatte | rakhmerov: I guess that would mean building a custom mistral-common package (on ubuntu) with a modified setup.cfg | 08:17 |
rakhmerov | d0ugal: I'll get to back to the community work I hope soon too. Once I fix some critical bugs | 08:17 |
d0ugal | :) | 08:17 |
rakhmerov | d0ugal: as far as the issue I described today with memory consumption, it's pretty interesting one. I think we'll have to change the architecture a little bit | 08:19 |
rakhmerov | it'd be an interesting task | 08:20 |
d0ugal | What change do you have in mind? | 08:20 |
apetrich | rakhmerov, sorry for the empty release note template.. LOL I did that on my laptop and forgot to send it to this computer | 08:21 |
rakhmerov | d0ugal: most likely we shouldn't process all tasks in "on-XXX" at once | 08:23 |
rakhmerov | apetrich: that's fine ) No worries | 08:23 |
d0ugal | rakhmerov: Maybe we could add a concurrency to it? or have it respect the task concurrency? | 08:25 |
d0ugal | or do you just think they should be sequential? | 08:25 |
rakhmerov | d0ugal: yeah, maybe | 08:25 |
rakhmerov | I'm thinking about it now and doing some more experiments | 08:25 |
rakhmerov | I think I'll roll out something early next week | 08:26 |
rakhmerov | d0ugal: well, theoretically yes, we can process that in parallel | 08:26 |
rakhmerov | to some extent at least | 08:26 |
rakhmerov | ok, that's just something I wanted to share a little bit | 08:26 |
rakhmerov | have been busy with it the whole week | 08:27 |
rakhmerov | d0ugal: so what about bug triaging? ) | 08:27 |
d0ugal | Sounds interesting! | 08:27 |
d0ugal | rakhmerov: well, we still have 20 NEW bugs: https://bugs.launchpad.net/mistral/+bugs?search=Search&field.status=New&orderby=id&start=0 | 08:27 |
d0ugal | and 19 UNDECIDED: https://bugs.launchpad.net/mistral/+bugs?search=Search&field.importance=Undecided&orderby=id&start=0 | 08:28 |
d0ugal | (many of these overlap) | 08:28 |
rakhmerov | yep | 08:28 |
rakhmerov | I'm ready to discuss whatever is needed | 08:28 |
d0ugal | so I think only 20 in total that need to be triaged | 08:28 |
rakhmerov | ok | 08:28 |
d0ugal | rakhmerov: thanks | 08:28 |
d0ugal | I don't know of any that need discussed yet, they just need processed :) | 08:28 |
d0ugal | We need to move them to triaged if they seem valid, set a priority and add any relevant tags. | 08:29 |
rakhmerov | let's do it then? | 08:29 |
d0ugal | Sure | 08:29 |
d0ugal | rakhmerov: do you want to start at the top of the list? | 08:30 |
rakhmerov | sure | 08:30 |
d0ugal | https://bugs.launchpad.net/mistral/+bugs?search=Search&field.status=New&orderby=-date_last_updated&start=0 | 08:30 |
d0ugal | That is sorted by date, so should be a consistent view for both of us. | 08:30 |
rakhmerov | https://bugs.launchpad.net/mistral/+bug/1413535 | 08:30 |
openstack | Launchpad bug 1413535 in Mistral "Method DbTestCase.heavy_init() gets called more than once if we run tests via tox" [Medium,New] - Assigned to Nikolay Makhotkin (nmakhotkin) | 08:30 |
rakhmerov | there was really a problem with this one | 08:30 |
rakhmerov | with tox | 08:30 |
rakhmerov | seems like because of testr | 08:31 |
rakhmerov | because it may run tests in parallel | 08:31 |
d0ugal | Interesting. | 08:31 |
rakhmerov | so it still looks valid for me but I have no idea how to fix it ) | 08:31 |
d0ugal | I don't really understand it. | 08:31 |
d0ugal | haha, I don't either. | 08:31 |
d0ugal | Okay - I guess we can just mark it as triaged | 08:31 |
rakhmerov | yes | 08:32 |
rakhmerov | so, to be precise: not even just "in parallel" but, what's more important, in different processes | 08:32 |
d0ugal | https://bugs.launchpad.net/mistral/+bug/1556839 | 08:33 |
openstack | Launchpad bug 1556839 in Mistral "can not generate a snapshot name include date" [Undecided,New] - Assigned to lvdongbing (dbcocle) | 08:33 |
d0ugal | In YAQL there is a date function, so I think this is invalid | 08:34 |
d0ugal | Maybe there wasn't in 2016 :) | 08:34 |
*** shardy has quit IRC | 08:35 | |
d0ugal | <% "{0}/{1}.yaml".format($.type, now().format("%Y-%m-%d_%H:%M:%S")) %> | 08:35 |
rakhmerov | yeah.. | 08:35 |
d0ugal | ^ we use that in one of our workflows. | 08:35 |
rakhmerov | I don't think it's a Mistral problem | 08:35 |
rakhmerov | it's a matter of how to use it | 08:35 |
rakhmerov | seems just invalid to me | 08:36 |
d0ugal | I hope they were not waiting 2 years for that :) | 08:36 |
d0ugal | https://bugs.launchpad.net/mistral/+bug/1583210 | 08:36 |
openstack | Launchpad bug 1583210 in Mistral "Mistral Step incorrectly reporting success" [Undecided,New] - Assigned to Hardik Parekh (hardik-parekh047) | 08:36 |
openstackgerrit | Adriano Petrich proposed openstack/mistral master: Only allow for deleting completed executions https://review.openstack.org/560802 | 08:36 |
d0ugal | I think that bug is a confusion between action executions and tasks. In their case I think the action is successful but the task isn't. | 08:37 |
rakhmerov | d0ugal: looking.. | 08:37 |
rakhmerov | yes, you're right | 08:38 |
d0ugal | rakhmerov: and I think you said this in the comment :) | 08:39 |
rakhmerov | yep ) | 08:39 |
rakhmerov | d0ugal: not even sure whether we need to be solving it somehow | 08:39 |
d0ugal | I don't think so | 08:39 |
rakhmerov | yes | 08:39 |
d0ugal | How can we solve it? if the task has an error it has an error and we need to show that :) | 08:40 |
rakhmerov | well, just a sec.. | 08:40 |
d0ugal | Closing it. | 08:40 |
d0ugal | oh, okay | 08:40 |
d0ugal | waiting | 08:40 |
rakhmerov | so | 08:40 |
rakhmerov | I was just trying to understand precisely what the request was ) | 08:40 |
openstackgerrit | Adriano Petrich proposed openstack/python-mistralclient master: WIP force delete executions https://review.openstack.org/561159 | 08:40 |
rakhmerov | and seems like there's no request to change anything | 08:40 |
rakhmerov | yeah, I think it was just wrong understanding of these mechanisms | 08:41 |
rakhmerov | let's close it, I agree | 08:41 |
d0ugal | ok | 08:42 |
d0ugal | https://bugs.launchpad.net/mistral/+bug/1624445 | 08:42 |
openstack | d0ugal: Error: malone bug 1624445 not found | 08:42 |
d0ugal | hmm | 08:42 |
d0ugal | https://bugs.launchpad.net/mistral/+bug/1624445 | 08:42 |
d0ugal | Next bug ^ I'm still clsoing this one. | 08:42 |
d0ugal | oh, it is private that is why openstack can't fetch it :) | 08:42 |
rakhmerov | yes | 08:43 |
rakhmerov | I see it | 08:43 |
rakhmerov | d0ugal: why closing? | 08:43 |
rakhmerov | you mean https://bugs.launchpad.net/mistral/+bug/1624445 ? | 08:44 |
openstack | rakhmerov: Error: malone bug 1624445 not found | 08:44 |
d0ugal | rakhmerov: I am still closing the previous one (well, commenting to explain why) | 08:44 |
rakhmerov | ooh, ok | 08:44 |
d0ugal | rakhmerov: I don't think this needs to be private? | 08:45 |
rakhmerov | hm.. | 08:46 |
rakhmerov | not sure either | 08:46 |
rakhmerov | seems like yes, there's a problem but it can't be used to compromise something.. | 08:46 |
d0ugal | Agreed. I'll remove the private flag | 08:47 |
d0ugal | I think there is enough information here, so I'll mark it as Triaged and Medium. | 08:47 |
rakhmerov | yes | 08:47 |
rakhmerov | looking at https://bugs.launchpad.net/mistral/+bug/1640479 | 08:49 |
openstack | Launchpad bug 1640479 in Mistral "401 issue while installing mistral in Openstack" [Undecided,New] | 08:49 |
d0ugal | Hmm | 08:50 |
d0ugal | There is really not very much information there. | 08:50 |
rakhmerov | d0ugal: "With Openstack mitaka setup" :) | 08:51 |
rakhmerov | very very old | 08:51 |
d0ugal | lol, yeah | 08:51 |
rakhmerov | let's close it | 08:51 |
d0ugal | I have never even used that Mistral :) | 08:51 |
d0ugal | Agreed | 08:51 |
rakhmerov | I don't think it's relevant | 08:51 |
rakhmerov | https://bugs.launchpad.net/mistral/+bug/1643840 | 08:52 |
openstack | Launchpad bug 1643840 in Mistral "How to check where are the bugs when the execution status is error" [Undecided,New] | 08:52 |
*** shardy has joined #openstack-mistral | 08:52 | |
rakhmerov | so, on that one: a known thing, yeah, and I already replied that we're working on making this kind of investigation easier | 08:53 |
rakhmerov | I'd say we don't need to keep this 'bug', it's just another evidence for us that what we started doing in that direction is important for users | 08:54 |
d0ugal | Agreed | 08:54 |
rakhmerov | and revisit our activities on that | 08:54 |
rakhmerov | https://bugs.launchpad.net/mistral/+bug/1648646 | 08:55 |
openstack | Launchpad bug 1648646 in Mistral "os_actions_endpoint_type not in generated config file" [Undecided,New] | 08:55 |
d0ugal | Interesting. | 08:56 |
d0ugal | I am sure I have seen the [api] section at least | 08:56 |
d0ugal | I should try this... | 08:56 |
rakhmerov | :) | 08:57 |
rakhmerov | Andras also complained that some of the options didn't get to a generated config | 08:58 |
rakhmerov | don't remember though what they were | 08:58 |
d0ugal | okay, so we should investigate this. | 08:59 |
d0ugal | I remember Andras complaining about it too :) | 09:00 |
rakhmerov | yeah | 09:00 |
d0ugal | Okay, we are at the end of the hour. | 09:00 |
rakhmerov | d0ugal: btw, it should get into the default group | 09:00 |
d0ugal | I might do a little bit more, but I'll stop the bot before I forget. | 09:00 |
d0ugal | #endmeeting | 09:00 |
*** openstack changes topic to " (Meeting topic: test)" | 09:00 | |
openstack | Meeting ended Fri Apr 13 09:00:28 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 09:00 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-13-08.00.html | 09:00 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-13-08.00.txt | 09:00 |
openstack | Log: http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-04-13-08.00.log.html | 09:00 |
d0ugal | rakhmerov: Move what into the default group? | 09:00 |
rakhmerov | d0ugal: this config option is not in the [api] group, it's in the default group | 09:00 |
d0ugal | oh | 09:01 |
rakhmerov | yep, I looked at the code | 09:02 |
rakhmerov | d0ugal: so we'll stop with triaging for now? | 09:02 |
rakhmerov | till the next office hours? | 09:02 |
rakhmerov | (which works for me, I just wanna clarify..) | 09:02 |
d0ugal | rakhmerov: yeah, lets stop | 09:03 |
rakhmerov | ok | 09:03 |
d0ugal | There are only 13 left, so we should be finished by the end of next week :) | 09:03 |
rakhmerov | 13 bugs left | 09:03 |
d0ugal | Then hopefully we can do it regularly and never let it build up again | 09:03 |
rakhmerov | good, yep | 09:03 |
d0ugal | We only have 116 bugs in total! | 09:03 |
rakhmerov | totally for it | 09:03 |
rakhmerov | :) | 09:03 |
d0ugal | rakhmerov: Thanks for your help. | 09:04 |
rakhmerov | sure | 09:04 |
rakhmerov | d0ugal: please ping me when you start office hours, I may just be focused on something and forget that we gather at that time ) | 09:05 |
d0ugal | rakhmerov: will do. | 09:06 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Adding a test for std.test_dict action https://review.openstack.org/561174 | 09:32 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: Optimizing big 'on-XXX' clauses https://review.openstack.org/561175 | 09:32 |
*** katkapilatova has joined #openstack-mistral | 12:17 | |
*** hardikjasani has quit IRC | 13:13 | |
*** jaosorior has quit IRC | 13:27 | |
*** bobh has joined #openstack-mistral | 14:05 | |
*** katkapilatova has quit IRC | 14:41 | |
*** AlexeyAbashkin has joined #openstack-mistral | 14:45 | |
*** AlexeyAbashkin has quit IRC | 14:49 | |
*** openstackgerrit has quit IRC | 14:50 | |
*** livelace-link has joined #openstack-mistral | 15:10 | |
*** pgaxatte has left #openstack-mistral | 15:33 | |
*** itlinux has joined #openstack-mistral | 15:48 | |
*** gkadam has quit IRC | 16:21 | |
*** jpich has quit IRC | 16:57 | |
*** shardy has quit IRC | 17:09 | |
bobh | d0ugal: can you take a look at https://review.openstack.org/#/c/553910/ when you get a chance? | 17:40 |
*** harlowja has joined #openstack-mistral | 19:10 | |
*** bobh has quit IRC | 20:20 | |
*** bobh_ has joined #openstack-mistral | 20:20 | |
*** d0ugal has quit IRC | 20:59 | |
*** d0ugal has joined #openstack-mistral | 21:26 | |
*** gkadam has joined #openstack-mistral | 21:30 | |
*** bobh_ has quit IRC | 21:45 | |
*** openstackgerrit has joined #openstack-mistral | 21:57 | |
openstackgerrit | Merged openstack/mistral master: Update Duplicate entry exceptions to provide more information https://review.openstack.org/553910 | 21:57 |
*** gkadam has quit IRC | 21:58 | |
*** itlinux has quit IRC | 22:27 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!