| *** bobh has joined #openstack-mistral | 00:07 | |
| *** bobh has quit IRC | 00:22 | |
| *** itlinux has quit IRC | 01:12 | |
| *** bobh has joined #openstack-mistral | 01:13 | |
| *** harlowja has quit IRC | 01:20 | |
| *** yangyapeng has joined #openstack-mistral | 01:22 | |
| *** yangyapeng has quit IRC | 01:26 | |
| *** pengdake has joined #openstack-mistral | 01:32 | |
| *** yangyapeng has joined #openstack-mistral | 01:41 | |
| *** bobh has quit IRC | 01:42 | |
| *** bobh has joined #openstack-mistral | 02:05 | |
| *** bobh has quit IRC | 02:07 | |
| *** bobh has joined #openstack-mistral | 02:07 | |
| *** bobh has quit IRC | 02:12 | |
| *** yangyapeng has quit IRC | 02:25 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 02:36 | |
| *** AlexeyAbashkin has quit IRC | 02:40 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 03:36 | |
| *** AlexeyAbashkin has quit IRC | 03:40 | |
| *** gkadam has joined #openstack-mistral | 03:59 | |
| *** harlowja has joined #openstack-mistral | 04:12 | |
| *** pengdake has quit IRC | 04:18 | |
| *** harlowja has quit IRC | 04:40 | |
| *** hardikjasani has joined #openstack-mistral | 05:23 | |
| *** pengdake has joined #openstack-mistral | 05:51 | |
| *** gkadam has quit IRC | 06:50 | |
| *** chandankumar has joined #openstack-mistral | 06:51 | |
| chandankumar | d0ugal: rakhmerov hell | 06:52 |
|---|---|---|
| chandankumar | *hello | 06:52 |
| rakhmerov | :) | 06:52 |
| rakhmerov | hi | 06:52 |
| chandankumar | d0ugal: rakhmerov https://review.openstack.org/#/c/552635/ can we get this merged, I need to unblock rdo packages | 06:52 |
| rakhmerov | chandankumar: that's ok, I just want to understand how I can check this change | 06:53 |
| rakhmerov | I don't see any related CI jobs | 06:54 |
| chandankumar | rakhmerov: https://review.rdoproject.org/r/#/c/12883/ | 06:54 |
| rakhmerov | what exactly do I need to look at? | 06:55 |
| chandankumar | rakhmerov: let me add a job to check the job building | 06:56 |
| rakhmerov | it'd be helpful, yes | 06:56 |
| d0ugal | chandankumar: hi | 06:59 |
| openstackgerrit | Chandan Kumar proposed openstack/mistral-tempest-plugin master: Fix documentation build https://review.openstack.org/552635 | 06:59 |
| chandankumar | d0ugal: rakhmerov ^^ | 06:59 |
| rakhmerov | ok | 06:59 |
| d0ugal | Looking. | 07:00 |
| d0ugal | rakhmerov: Change looks good to me. I am just running "tox -e docs" locally | 07:05 |
| d0ugal | Waiting for my slow internet to install the deps | 07:05 |
| rakhmerov | ok | 07:05 |
| d0ugal | It worked. | 07:06 |
| d0ugal | and without that patch it failed | 07:06 |
| d0ugal | so I'll +2/+W | 07:06 |
| d0ugal | chandankumar: ^ | 07:06 |
| chandankumar | d0ugal: rakhmerov thanks :-) | 07:07 |
| rakhmerov | np | 07:07 |
| d0ugal | brb, coffee. | 07:07 |
| rakhmerov | d0ugal: please https://review.openstack.org/#/c/550399/ | 07:08 |
| rakhmerov | pretty important for us | 07:08 |
| d0ugal | rakhmerov: k | 07:13 |
| rakhmerov | thanks | 07:13 |
| *** gkadam has joined #openstack-mistral | 07:40 | |
| openstackgerrit | ShangXiao proposed openstack/mistral-tempest-plugin master: Update the old doc links https://review.openstack.org/552821 | 07:40 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add a unit test to check initializers of MistralException hierarcy https://review.openstack.org/552827 | 07:55 |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:57 | |
| *** shardy has joined #openstack-mistral | 08:03 | |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Add a unit test to check initializers of MistralException hierarcy https://review.openstack.org/552827 | 08:09 |
| d0ugal | rakhmerov: hmm, when I do a "mistral workbook-create file.yaml" now and there is a syntax issue - I don't get any errors anymore | 08:10 |
| d0ugal | :/ | 08:10 |
| d0ugal | Just this | 08:10 |
| d0ugal | $ mistral workbook-create test.workbook | 08:10 |
| d0ugal | ERROR (app) Bad Request (HTTP 400) | 08:10 |
| d0ugal | Any idea why/how that changed? | 08:10 |
| rakhmerov | hm.. really? | 08:10 |
| d0ugal | I had to go and find the error in the api log | 08:10 |
| rakhmerov | nope, I wasn't aware of this | 08:10 |
| rakhmerov | it might have been broken | 08:11 |
| d0ugal | Yeah, seems so. That is quite bad. | 08:11 |
| d0ugal | I'll open a bug. | 08:11 |
| rakhmerov | ok | 08:11 |
| openstackgerrit | Merged openstack/mistral master: Updated from global requirements https://review.openstack.org/552760 | 08:11 |
| openstackgerrit | Merged openstack/mistral-tempest-plugin master: Updated from global requirements https://review.openstack.org/552761 | 08:11 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Remove a redundant initializer of InvalidUnicodeAction in the tests https://review.openstack.org/552834 | 08:17 |
| d0ugal | rakhmerov: do you have a moment for a question? | 08:18 |
| rakhmerov | d0ugal: yes | 08:18 |
| d0ugal | rakhmerov: it seems I don't understand continue-on/break-on | 08:18 |
| d0ugal | rakhmerov: http://paste.openstack.org/show/700871/ | 08:18 |
| rakhmerov | ok, let me see.. | 08:18 |
| d0ugal | I thought that would keep repeating the action every 3 seconds up to 400 times | 08:18 |
| d0ugal | but it just goes straight to success | 08:18 |
| d0ugal | http://paste.openstack.org/show/700872/ | 08:20 |
| rakhmerov | ok | 08:20 |
| rakhmerov | 1 min.. | 08:20 |
| d0ugal | sure | 08:21 |
| rakhmerov | from our docs: "continue-on - Defines an expression that will continue iteration loop if it evaluates to ‘true’. If it fires then the task is considered successful. If it evaluates to ‘false’ then policy will break the iteration." | 08:22 |
| rakhmerov | so it's just a necessary condition to keep retrying | 08:23 |
| rakhmerov | it isn't used if the action successfully finished in the first place | 08:23 |
| rakhmerov | maybe the doc is not really accurate but that's the meaning | 08:23 |
| openstackgerrit | Merged openstack/mistral-tempest-plugin master: Fix documentation build https://review.openstack.org/552635 | 08:24 |
| rakhmerov | d0ugal: makes sense? | 08:24 |
| d0ugal | rakhmerov: ohhh | 08:24 |
| rakhmerov | yeah ) | 08:24 |
| rakhmerov | yeah, it's a little tricky | 08:24 |
| d0ugal | rakhmerov: so continue-on and break-on are never used if the action doesn't error? | 08:25 |
| rakhmerov | I keep forgetting myself | 08:25 |
| rakhmerov | yes, exactly | 08:25 |
| d0ugal | damn | 08:25 |
| d0ugal | that sucks | 08:25 |
| d0ugal | lol | 08:25 |
| rakhmerov | the retry mechanism comes into play only if the action failed at least once | 08:25 |
| d0ugal | Right | 08:25 |
| rakhmerov | it sucks? Why? :) | 08:25 |
| d0ugal | I guess that makes sense | 08:26 |
| d0ugal | well, it means we have lots of broken continue-on/break-on | 08:26 |
| rakhmerov | doesn't fir some of your use cases? | 08:26 |
| rakhmerov | aah | 08:26 |
| rakhmerov | I see ) | 08:26 |
| d0ugal | I'll show you an example, we have a pattern people have been using | 08:26 |
| d0ugal | which seemed nice | 08:26 |
| d0ugal | rakhmerov: https://github.com/openstack/tripleo-common/blob/master/workbooks/baremetal.yaml#L23-L29 | 08:26 |
| d0ugal | That was a nice way to keep calling a task if the node wasn't at the state we wanted yet | 08:27 |
| d0ugal | keep calling a action* | 08:27 |
| d0ugal | but the action shouldn't ever fail | 08:27 |
| rakhmerov | ooh ) | 08:27 |
| rakhmerov | yeah.. | 08:27 |
| d0ugal | I guess we can do something similar with on-success - but it will be harder to limit it | 08:28 |
| rakhmerov | lemme think.. | 08:28 |
| rakhmerov | I wonder how else it can be implemented | 08:28 |
| d0ugal | rakhmerov: I guess we could do a small sub-workflow that errors if the state isn't what we want | 08:31 |
| d0ugal | then retry will work with that | 08:32 |
| rakhmerov | yeah, that's probably the most obvious way to me | 08:32 |
| rakhmerov | our folks in CloudBand use this trick AFAIK | 08:32 |
| rakhmerov | yep | 08:32 |
| d0ugal | k, I'll try that out and see how it goes | 08:32 |
| d0ugal | Thanks | 08:32 |
| rakhmerov | the only two looping mechanisms are retry and with-items | 08:33 |
| rakhmerov | but with-items can't be used really | 08:33 |
| d0ugal | no, unless I make a list with the node uuid 400 times to represent how many times I want to try :) | 08:33 |
| d0ugal | I need to take my dog to the vet, bbiab | 08:34 |
| *** jpich has joined #openstack-mistral | 09:04 | |
| openstackgerrit | Merged openstack/mistral master: Make sure not to swallow original exceptions on handling remote errors https://review.openstack.org/550399 | 09:55 |
| openstackgerrit | Renat Akhmerov proposed openstack/mistral stable/queens: Make sure not to swallow original exceptions on handling remote errors https://review.openstack.org/552870 | 10:32 |
| rakhmerov | apetrich, d0ugal: please review https://review.openstack.org/#/c/547808/ | 10:34 |
| rakhmerov | mysql unit tests now don't run on mysql :) | 10:34 |
| d0ugal | rakhmerov: will do. I think apetrich is out today, he will be back tomorrow or Friday I think. | 10:34 |
| rakhmerov | this patch fixes it | 10:34 |
| rakhmerov | ok | 10:34 |
| *** pengdake has quit IRC | 10:46 | |
| *** bobh has joined #openstack-mistral | 11:19 | |
| *** bobh has quit IRC | 11:30 | |
| *** hardikjasani has left #openstack-mistral | 11:41 | |
| *** dprince has joined #openstack-mistral | 12:10 | |
| apetrich | d0ugal, thanks. rakhmerov: Probably tomorrow also, not sure yet. | 12:23 |
| *** bobh has joined #openstack-mistral | 12:27 | |
| *** bobh has quit IRC | 12:36 | |
| *** bobh has joined #openstack-mistral | 12:36 | |
| *** bobh has quit IRC | 12:41 | |
| *** katkapilatova has joined #openstack-mistral | 13:31 | |
| *** bobh has joined #openstack-mistral | 14:11 | |
| openstackgerrit | Andras Kovi proposed openstack/mistral master: WIP: Enable delayed call deletion responsibility on target method https://review.openstack.org/552911 | 14:14 |
| *** rbrady has joined #openstack-mistral | 14:22 | |
| *** itlinux has joined #openstack-mistral | 15:12 | |
| pgaxatte | Hi | 15:20 |
| pgaxatte | I'm a bit lost | 15:20 |
| pgaxatte | i can't find why my cron triggers are never run | 15:20 |
| pgaxatte | I'm running mistral pike (tag 5.2.2) on ubuntu 16.04 | 15:20 |
| pgaxatte | I am running api with wsgi, executor, engine and event-engine but I don't see errors in logs as to why the crons don't start | 15:21 |
| pgaxatte | any idea? | 15:21 |
| *** dprince has quit IRC | 16:13 | |
| *** AlexeyAbashkin has quit IRC | 16:30 | |
| *** dprince has joined #openstack-mistral | 16:32 | |
| openstackgerrit | Mike Fedosin proposed openstack/mistral master: Remove duplicate declaration of rpc_response_timeout https://review.openstack.org/552679 | 16:55 |
| *** gkadam has quit IRC | 17:05 | |
| *** jpich has quit IRC | 17:14 | |
| *** thrash is now known as thrash|biab | 17:30 | |
| *** itlinux has quit IRC | 17:50 | |
| *** itlinux has joined #openstack-mistral | 17:58 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 18:07 | |
| *** harlowja has joined #openstack-mistral | 18:11 | |
| *** AlexeyAbashkin has quit IRC | 18:11 | |
| *** thrash|biab is now known as thrash | 18:34 | |
| *** shardy has quit IRC | 18:48 | |
| *** itlinux_ has joined #openstack-mistral | 18:57 | |
| *** itlinux has quit IRC | 18:57 | |
| *** itlinux_ has quit IRC | 19:40 | |
| *** itlinux has joined #openstack-mistral | 19:53 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 20:36 | |
| *** AlexeyAbashkin has quit IRC | 20:40 | |
| *** dprince has quit IRC | 20:52 | |
| *** thrash is now known as thrash|g0ne | 21:36 | |
| *** itlinux has quit IRC | 21:40 | |
| *** bobh has quit IRC | 22:06 | |
| *** itlinux has joined #openstack-mistral | 23:47 | |
| *** dprince has joined #openstack-mistral | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!