Tuesday, 2018-02-13

*** bobh has joined #openstack-mistral00:04
*** weshay is now known as weshay_PTO00:04
*** openstackgerrit has quit IRC01:03
*** pengdake_ has joined #openstack-mistral01:04
*** yangyapeng has quit IRC01:12
*** yangyapeng has joined #openstack-mistral01:12
*** itlinux has joined #openstack-mistral01:15
*** mcdoker181818 has quit IRC01:27
*** mcdoker181818 has joined #openstack-mistral01:29
*** itlinux has quit IRC01:43
*** yangyapeng has quit IRC01:53
*** yangyapeng has joined #openstack-mistral01:54
*** bobh has quit IRC01:54
*** itlinux has joined #openstack-mistral01:56
*** mcdoker181818 has quit IRC01:57
*** mcdoker181818 has joined #openstack-mistral01:59
*** AlexeyAbashkin has joined #openstack-mistral02:21
*** itlinux has quit IRC02:22
*** AlexeyAbashkin has quit IRC02:25
*** itlinux has joined #openstack-mistral02:26
*** itlinux has quit IRC02:40
*** hardikjasani has joined #openstack-mistral02:46
*** thrash is now known as thrash|g0ne02:49
*** harlowja has quit IRC03:04
*** mcdoker181818 has quit IRC03:16
*** mcdoker181818 has joined #openstack-mistral03:18
*** yangyapeng has quit IRC03:28
*** yangyapeng has joined #openstack-mistral03:29
*** yangyapeng has quit IRC03:33
*** mcdoker181818 has quit IRC03:51
*** mcdoker181818 has joined #openstack-mistral03:53
*** nsingh has left #openstack-mistral03:56
*** gkadam has joined #openstack-mistral04:04
*** pengdake_ has quit IRC04:11
*** openstackgerrit has joined #openstack-mistral04:12
openstackgerritMerged openstack/python-mistralclient master: Fix a race condition with execution creation  https://review.openstack.org/54350104:12
openstackgerrityatin proposed openstack/python-mistralclient master: Don't override session during auth  https://review.openstack.org/54346004:30
*** pengdake_ has joined #openstack-mistral04:40
*** threestrands has quit IRC04:50
*** mcdoker181818 has quit IRC05:10
*** mcdoker181818 has joined #openstack-mistral05:13
*** pengdake_ has quit IRC05:15
*** mcdoker181818 has quit IRC05:21
*** mcdoker181818 has joined #openstack-mistral05:21
*** harlowja has joined #openstack-mistral05:52
*** pengdake_ has joined #openstack-mistral05:54
*** ykarel has joined #openstack-mistral05:57
ykarelHi, can we get +W on https://review.openstack.org/#/c/543460/05:58
*** itlinux has joined #openstack-mistral05:59
*** itlinux has quit IRC06:08
*** harlowja has quit IRC06:33
openstackgerritMerged openstack/python-mistralclient master: Don't override session during auth  https://review.openstack.org/54346007:42
*** AlexeyAbashkin has joined #openstack-mistral07:48
*** d0ugal has quit IRC07:52
*** apetrich has quit IRC07:55
*** apetrich has joined #openstack-mistral07:56
openstackgerritAdriano Petrich proposed openstack/python-mistralclient master: Add TripleO jobs for mistral client  https://review.openstack.org/54344707:57
*** d0ugal has joined #openstack-mistral08:02
*** jtomasek has joined #openstack-mistral08:05
*** oidgar has joined #openstack-mistral08:26
ykareld0ugal, hi08:30
ykarelhttps://review.openstack.org/#/c/543846/08:31
ykarelcan ^^ be considered for release: https://review.openstack.org/#/c/54340208:31
therveykarel, I think we need a 3.2.1 no?08:42
therved0ugal, ^^08:43
ykarelboth works for me08:43
ykarelsooner is better08:44
apetrichI thought we needed a to bump to 3.3 for some reason08:44
apetrichrakhmerov, do you recall?08:44
therveIf we release master, maybe, but we should probably backport and release that instead08:45
apetrichtherve, oh I see. Agreed08:45
apetrichwhy can't I +2 the backport?08:46
thervestable policy08:48
apetrichoh I didn't know that08:48
ykarelbut i can see a +2 in https://review.openstack.org/#/c/539553/, is some policy changed recently08:51
ykarelor it's because of branching requirements projects08:51
rakhmerovapetrich: hi09:06
rakhmerovI was at the meeting09:06
rakhmerovreading..09:06
*** kong has quit IRC09:07
apetrichrakhmerov, nothing to it. just that we need to backport the session fix to 3.2.1 on python-mistralclient09:07
rakhmerovok09:08
*** jpich has joined #openstack-mistral09:09
rakhmerovapetrich: approved09:10
apetrichrakhmerov, cheers!09:11
rakhmerovI just wonder whether we need to hold on with merging https://review.openstack.org/#/c/543402/ )09:11
rakhmerovand instead just change the hash in it09:11
rakhmerovd0ugal: what do you think?09:11
apetrichrakhmerov, d0ugal will bbiab09:17
rakhmerov?09:17
rakhmerovnot sure what that means )09:18
*** ykarel is now known as ykarel|lunch09:22
apetrichrakhmerov, sorry he's out and be back later09:28
apetrichor in a bit09:28
rakhmerovok09:31
*** gkadam_ has joined #openstack-mistral09:34
*** gkadam has quit IRC09:36
*** pengdake_ has quit IRC10:05
*** ykarel|lunch is now known as ykarel10:13
*** shardy has quit IRC10:19
*** shardy has joined #openstack-mistral10:21
*** thrash|g0ne is now known as thrash11:06
d0ugalrakhmerov, apetrich - back now.11:11
rakhmerovyep11:11
d0ugalapetrich, therve - 3.3 was because there is a feature addition11:12
d0ugalI am not sure if we should release 3.3.0 and 3.2.111:13
d0ugalor just 3.3.011:13
d0ugalapetrich: https://review.openstack.org/#/c/543447/11:14
d0ugalLooks like we still have a tripleo failure, so lets see if that is legit first11:14
d0ugalInteresting. Not seen this before.11:15
d0ugalhttp://logs.openstack.org/47/543447/3/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/4036573/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2018-02-13_08_49_2711:15
*** shardy has quit IRC11:20
*** shardy has joined #openstack-mistral11:21
*** shardy has quit IRC11:35
*** ykarel is now known as ykarel|afk11:36
*** mwhahaha has quit IRC11:51
*** mwhahaha has joined #openstack-mistral11:52
*** shardy has joined #openstack-mistral11:52
d0ugalI think the refactor that landed changed the exception that is raised by mistralclient, which is a big issue.11:57
d0ugalhttps://github.com/openstack/instack-undercloud/blob/master/instack_undercloud/undercloud.py#L176511:57
d0ugalThat is where tripleo is failing now, but the exception isn't handled, because it is wrong. I assume this is because it changed11:57
apetrichoh that failure is expected.12:00
d0ugalaye12:01
d0ugalapetrich: on every new install12:02
d0ugalapetrich: upgrades etc. will already have it.12:02
apetrichoh true12:02
*** portdirect has quit IRC12:03
*** portdirect has joined #openstack-mistral12:04
*** akazakov has joined #openstack-mistral12:06
d0ugaljaosorior: How well do you remember this patch? :) https://review.openstack.org/#/c/455174/12:11
d0ugaljaosorior: I am wondering if it could have changed the exceptions that mistralclient raises12:11
d0ugalhmm12:12
d0ugalbut that should have been in 3.1.4, so it should be fine12:12
d0ugalapetrich: https://github.com/openstack/python-mistralclient/compare/3.1.4...3.2.012:12
apetrichd0ugal, was it released? why are we just seeing those errors12:12
apetrichd0ugal, looking12:12
apetrichthat does not seems messy at all12:13
d0ugalapetrich: yeah, that patch I linked was in 3.1.4, so ignore that12:13
d0ugalbut the regression should be in that range of commits12:13
therved0ugal, I don't think it's in 3.1.412:14
therveSame issue as yesterday12:14
apetrichtherve, aye, but I still didn't get why are we seeing those old regressions just now. Do you know why?12:15
jaosoriord0ugal: this part could change the exceptions https://review.openstack.org/#/c/455174/69/mistralclient/api/httpclient.py although, in some cases we were already using the keystone session object.12:15
jaosoriord0ugal: this attempted to catch the exceptions though https://review.openstack.org/#/c/455174/69/mistralclient/api/base.py12:16
d0ugaljaosorior: for context, we are seeing this error: http://logs.openstack.org/47/543447/3/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/7857e17/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2018-02-13_11_46_0112:16
d0ugaljaosorior: and I think it is because this exception changed: https://github.com/openstack/instack-undercloud/blob/master/instack_undercloud/undercloud.py#L176612:16
d0ugaltherve: yeah, you are correct - that patch never made it into 3.1.4. I got confused by the dates.12:17
jaosoriord0ugal: that sounds reasonable. Though I have no recollection on why the exception changed in this https://review.openstack.org/#/c/455174/69/mistralclient/api/base.py12:19
*** gkadam_ has quit IRC12:19
d0ugaljaosorior: k, thanks12:19
d0ugalI'll keep digging :)12:19
therveI'm pretty sure I made that change12:19
d0ugallol12:19
jaosoriorthey seem to have changed in patchset 4012:20
d0ugalah12:20
jaosoriord0ugal: but yeah, instead of raising keystone exceptions, it raises mistral specific ones12:20
d0ugalI forgot so many people were involved12:20
*** hjensas has joined #openstack-mistral12:21
therveI think tests were broken, so I didn't do it gratuitously12:22
therveBut yeah https://bugs.launchpad.net/heat/+bug/1714679 is the bug we had in heat12:22
openstackLaunchpad bug 1714679 in OpenStack Heat "deleting stack with mistral workflow resource (already deleted) fails with error" [High,Fix released] - Assigned to Rabi Mishra (rabi)12:22
jaosoriord0ugal: yeah, I started the patch and at some point couldn't continue it, so sharat sharma took over, then therve was helping with it too... and who knows who else :D12:22
therveI suspect the undercloud bit was in a transition where we used sessions, but mistral didn't support it super well12:22
therveSo my change was intended as a backward compatible change :/12:22
d0ugalRight12:22
therveSo we just need to fix instack I think, because raising mistral specific errors make sense12:23
therve*or*, we change the base class of the exceptions12:23
d0ugaltherve: despite being backwards incompatible?12:23
therveSo12:23
d0ugalI'm concerned about exception handling in other places12:23
*** ykarel|afk is now known as ykarel12:23
d0ugalI guess I could try and quickly scan tripleo-common12:23
therved0ugal, If you used mistral without sessions, it raised mistral errors12:24
therveIf you used sessions, it raised keystoneauth errors12:24
d0ugaloh, maybe we only ever catch APIException anyway. https://github.com/openstack/tripleo-common/blob/8a0910b15747bfcf025fe546a0a0523bdfed5afa/tripleo_common/actions/validations.py#L12612:24
d0ugalso t-c may be good.12:24
d0ugalbut who knows about other users12:24
therveThe patch to use session everywhere fixed by raising mistral error all the time12:24
d0ugalRight12:24
therved0ugal, Right because tc doesn't use sessions12:25
d0ugaloh yeah12:25
jaosoriordidn't we start using sessions in the undercloud already?12:25
thervejaosorior, Yes that's the issue :)12:26
jaosoriorah12:26
jaosoriorright12:26
therveinstack-undercloud used sessions, but mistraclient didn't support it well12:26
jaosorioruh.... how did we hit the issue now? that commit has been there for a bit12:26
therveWe only test releases12:26
therved0ugal, I'd catch both errors in instack12:26
jaosorioroh, and the change just got out now with this release?12:26
therveI think that's the right thing to do12:27
thervejaosorior, Right12:27
jaosorioroooh12:27
jaosoriorsorry, I'm a bit behind on this12:27
apetrichtherve, d0ugal yeah for catching both on instack12:27
therved0ugal, apetrich https://review.openstack.org/#/c/500346/ FWIW12:27
therveThat's what we had to deal with in Heat12:28
d0ugaltherve, jaosorior, apetrich: https://review.openstack.org/#/c/543916/12:29
d0ugalI caught both before I seen the above, glad you agree :)12:29
d0ugalI guess I need a bug for this to be backported...12:30
openstackgerritSagi Shnaidman proposed openstack/python-mistralclient master: Add TripleO jobs for mistral client  https://review.openstack.org/54344712:31
apetrichd0ugal, there's one. let me find it12:32
apetrichd0ugal, https://bugs.launchpad.net/tripleo/+bug/174875112:32
openstackLaunchpad bug 1748751 in python-mistralclient "Undercloud Install Fail - Configuring Mistral Workloads - Authentication Error - when using RDO master" [Undecided,In progress] - Assigned to Thomas Herve (therve)12:32
apetrichoh not tha12:32
apetricht12:32
*** ykarel_ has joined #openstack-mistral12:33
apetrichnever mind. I'm not finding it12:34
*** ykarel has quit IRC12:35
*** hardikjasani has quit IRC13:26
*** dprince has joined #openstack-mistral13:27
*** dprince has quit IRC13:43
*** ykarel_ is now known as ykarel|afk13:47
*** ykarel_ has joined #openstack-mistral13:56
*** ykarel|afk has quit IRC13:59
*** dprince has joined #openstack-mistral14:00
*** bobh has joined #openstack-mistral14:22
*** shardy has quit IRC14:24
*** shardy has joined #openstack-mistral14:25
*** openstackgerrit has quit IRC14:33
*** oidgar has quit IRC14:34
*** oidgar has joined #openstack-mistral14:45
*** thrash is now known as thrash|biab15:05
*** thrash|biab is now known as thrash15:29
*** shardy has quit IRC15:54
*** itlinux has joined #openstack-mistral16:01
*** mcdoker181818 has quit IRC16:09
*** mcdoker181818 has joined #openstack-mistral16:11
*** oidgar has quit IRC16:16
*** mcdoker181818 has quit IRC16:22
*** mcdoker181818 has joined #openstack-mistral16:25
*** ykarel_ has quit IRC16:28
*** openstackgerrit has joined #openstack-mistral16:36
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Add TripleO jobs for mistral client  https://review.openstack.org/54344716:36
*** itlinux has quit IRC16:46
*** itlinux has joined #openstack-mistral16:50
*** thrash is now known as thrash|f00dz17:06
*** jpich has quit IRC17:12
*** itlinux has quit IRC17:26
*** itlinux has joined #openstack-mistral17:31
*** AlexeyAbashkin has quit IRC17:38
*** thrash|f00dz is now known as thrash18:24
*** itlinux has quit IRC18:30
*** itlinux has joined #openstack-mistral18:44
*** itlinux has quit IRC18:57
*** itlinux has joined #openstack-mistral18:59
*** harlowja has joined #openstack-mistral19:03
*** itlinux has quit IRC19:39
*** itlinux has joined #openstack-mistral19:43
*** itlinux has quit IRC19:46
*** bobh has quit IRC19:52
*** itlinux has joined #openstack-mistral20:36
*** mcdoker181818 has quit IRC20:39
*** mcdoker181818 has joined #openstack-mistral20:40
*** mcdoker181818 has quit IRC20:47
*** mcdoker181818 has joined #openstack-mistral20:48
*** mcdoker181818 has quit IRC21:22
*** dprince has quit IRC21:31
*** itlinux has quit IRC22:23
*** itlinux has joined #openstack-mistral22:27
*** thrash is now known as thrash|g0ne22:32
*** akazakov has quit IRC22:35
*** itlinux has quit IRC22:46
*** kong has joined #openstack-mistral22:55

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!