| *** itlinux has joined #openstack-mistral | 00:06 | |
| *** threestrands has joined #openstack-mistral | 00:27 | |
| *** threestrands has quit IRC | 00:27 | |
| *** threestrands has joined #openstack-mistral | 00:27 | |
| *** itlinux has quit IRC | 00:34 | |
| *** matbu_ has joined #openstack-mistral | 00:36 | |
| *** zhurong has joined #openstack-mistral | 00:46 | |
| *** matbu_ has quit IRC | 00:51 | |
| *** harlowja has joined #openstack-mistral | 00:57 | |
| *** daidv_ has quit IRC | 01:05 | |
| *** zhurong has quit IRC | 01:11 | |
| *** zhurong has joined #openstack-mistral | 01:14 | |
| *** pengdake_ has joined #openstack-mistral | 01:27 | |
| *** threestrands has quit IRC | 01:29 | |
| *** gkadam has joined #openstack-mistral | 03:34 | |
| *** hardikjasani has joined #openstack-mistral | 04:08 | |
| *** pengdake_ has quit IRC | 04:14 | |
| *** zhurong has quit IRC | 04:35 | |
| rakhmerov | aspiers: hi Adam, most likely I won't go to Vancouver | 04:46 |
|---|---|---|
| rakhmerov | sorry | 04:46 |
| *** pengdake_ has joined #openstack-mistral | 04:54 | |
| *** harlowja has quit IRC | 05:10 | |
| *** gkadam_ has joined #openstack-mistral | 05:10 | |
| *** harlowja has joined #openstack-mistral | 05:35 | |
| *** zhurong has joined #openstack-mistral | 05:36 | |
| *** harlowja has quit IRC | 05:39 | |
| *** rbrady has quit IRC | 05:51 | |
| *** itlinux has joined #openstack-mistral | 05:58 | |
| *** itlinux has quit IRC | 06:27 | |
| *** rbrady has joined #openstack-mistral | 06:34 | |
| *** rbrady has joined #openstack-mistral | 06:34 | |
| *** pengdake_ has quit IRC | 06:37 | |
| *** pengdake_ has joined #openstack-mistral | 07:07 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:20 | |
| hardikjasani | Hi Renat! | 07:44 |
| *** AlexeyAbashkin has quit IRC | 07:44 | |
| hardikjasani | Or anyone, can someone point to some Openstack doc related to copyright strings? | 07:45 |
| hardikjasani | Is there some rules, or anything goes? | 07:46 |
| *** AlexeyAbashkin has joined #openstack-mistral | 07:54 | |
| *** openstackgerrit has joined #openstack-mistral | 08:25 | |
| openstackgerrit | Merged openstack/mistral master: Adding Keycloak authorization support. https://review.openstack.org/541376 | 08:25 |
| openstackgerrit | Merged openstack/mistral master: Consider size of output_on_error https://review.openstack.org/490414 | 08:29 |
| *** d0ugal has quit IRC | 08:33 | |
| *** d0ugal has joined #openstack-mistral | 08:48 | |
| *** jpich has joined #openstack-mistral | 09:02 | |
| *** zhurong has quit IRC | 09:16 | |
| d0ugal | apetrich: Morning | 09:21 |
| d0ugal | hardikjasani: They just need to be valid apache headers | 09:21 |
| hardikjasani | d0ugal: Oh cool! | 09:22 |
| apetrich | d0ugal, morning | 09:22 |
| d0ugal | hardikjasani: that is how I understand it anyway :) | 09:22 |
| d0ugal | hardikjasani: I assume you are asking about the copyright string at the top of files... I just copy it from another and usually don't include a company name - Red Hat don't need us to do that. | 09:23 |
| hardikjasani | d0ugal: No problems! Thanks. :) | 09:23 |
| d0ugal | (Red Hat being my employer) | 09:23 |
| d0ugal | apetrich: I think I am ready for you to review that patch | 09:24 |
| d0ugal | apetrich: I am just preparing proof that it works | 09:24 |
| hardikjasani | I figured there weren't any strict requirements! | 09:24 |
| d0ugal | hardikjasani: the only strict requirement is if the pep8 check fails, it validates the format - but seems quite flexible, I can't remember seeing it fail. | 09:24 |
| d0ugal | apetrich: you can see the cron trigger is created here to run every minute: http://logs.openstack.org/38/542238/4/check/tripleo-ci-centos-7-containers-multinode/941d5fb/logs/undercloud/var/log/mistral/api.log.txt.gz#_2018-02-09_05_27_01_559 | 09:26 |
| d0ugal | as per my testing patch: https://review.openstack.org/#/c/542238/ | 09:26 |
| apetrich | d0ugal, neat | 09:26 |
| d0ugal | apetrich: but here... http://logs.openstack.org/38/542238/4/check/tripleo-ci-centos-7-containers-multinode/941d5fb/logs/undercloud/var/log/mistral/engine.log.txt.gz | 09:27 |
| d0ugal | apetrich: search for "created by cron trigger" | 09:27 |
| d0ugal | apetrich: and you'll see it only actually runs every 10 mins | 09:27 |
| apetrich | oh | 09:27 |
| apetrich | I was about to ask that | 09:27 |
| d0ugal | if you agree that looks good, please merge: https://review.openstack.org/#/c/542202/ | 09:27 |
| d0ugal | :) | 09:27 |
| apetrich | neat it works | 09:28 |
| d0ugal | rakhmerov: I am going to create the release patch once my cron trigger patch merges. Is there anything else that you think we need? | 09:28 |
| d0ugal | apetrich: or anything else you want to see merge before the RC? | 09:28 |
| apetrich | -2 it requires me to type created correctly to search for it | 09:28 |
| d0ugal | lol | 09:28 |
| apetrich | done | 09:29 |
| d0ugal | apetrich: thanks! | 09:37 |
| *** dprince has joined #openstack-mistral | 09:41 | |
| *** shardy has joined #openstack-mistral | 09:49 | |
| *** AlexeyAbashkin has quit IRC | 09:56 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 09:57 | |
| aspiers | rakhmerov: no problem :) see you in Dublin though hopefully? | 10:01 |
| *** nsingh has joined #openstack-mistral | 10:06 | |
| *** niraj_singh has quit IRC | 10:08 | |
| *** dprince has quit IRC | 10:20 | |
| *** pengdake_ has quit IRC | 10:31 | |
| *** gkadam_ has quit IRC | 10:46 | |
| rakhmerov | d0ugal: no, go ahead | 10:48 |
| *** d0ugal has quit IRC | 10:59 | |
| *** d0ugal has joined #openstack-mistral | 11:17 | |
| *** AlexeyAbashkin has quit IRC | 11:27 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 11:30 | |
| openstackgerrit | Merged openstack/mistral master: Really make the cron trigger execution interval configurable https://review.openstack.org/542202 | 11:42 |
| *** toure|gone is now known as toure | 13:21 | |
| *** hardikjasani has quit IRC | 13:26 | |
| *** yangyapeng has quit IRC | 13:40 | |
| *** yangyapeng has joined #openstack-mistral | 13:51 | |
| *** yangyapeng has quit IRC | 13:55 | |
| d0ugal | FYI: 6.0.0.0rc1 release patch: https://review.openstack.org/542838 | 14:02 |
| *** yangyapeng has joined #openstack-mistral | 14:15 | |
| *** weshay is now known as weshay|ruck | 14:24 | |
| openstackgerrit | Merged openstack/mistral master: Tags in workflows were not being properly checked https://review.openstack.org/541829 | 14:51 |
| *** mcdoker181818 has joined #openstack-mistral | 14:58 | |
| mcdoker181818 | d0ugal: Hi. Are you here? | 14:59 |
| d0ugal | mcdoker181818: yup | 14:59 |
| mcdoker181818 | Do we plan a new pike release? | 14:59 |
| d0ugal | mcdoker181818: no plans, has there been a bugfix that needs released? | 15:00 |
| mcdoker181818 | We have a broken postgres in 5.2.0 | 15:00 |
| d0ugal | mcdoker181818: it could happen :) I am just not aware of anything being backported | 15:00 |
| d0ugal | mcdoker181818: did the fix land in master? | 15:00 |
| mcdoker181818 | d0ugal: yes. Master https://github.com/openstack/mistral/commit/05252da83572fb487054d03453da7494f3077f02 Pike https://github.com/openstack/mistral/commit/05252da83572fb487054d03453da7494f3077f02 | 15:02 |
| mcdoker181818 | d0ugal: How to propose a backport? I want to backport this too https://github.com/openstack/mistral/commit/05252da83572fb487054d03453da7494f3077f02 | 15:05 |
| mcdoker181818 | https://review.openstack.org/#/c/531861/ | 15:05 |
| d0ugal | mcdoker181818: 2 mins, just in a meeting and I need to quickly update something else before a patch is merged | 15:05 |
| mcdoker181818 | d0ugal: Ok. It's not urgent. | 15:06 |
| d0ugal | mcdoker181818: the easy way to do it is with gerrit. Find the review and click "cherry-pick" and select the correct branch | 15:10 |
| d0ugal | mcdoker181818: you can find the review by searching for the change-id | 15:10 |
| d0ugal | mcdoker181818: oh, you already found the review - sorry :) | 15:11 |
| d0ugal | mcdoker181818: "stable/pike" is the branch you want | 15:11 |
| openstackgerrit | Vitalii Solodilov proposed openstack/mistral stable/pike: Fixed integration of the unit tests with PosrgeSQL https://review.openstack.org/542876 | 15:12 |
| mcdoker181818 | d0ugal: Thank you :) | 15:13 |
| d0ugal | thrash: https://releases.openstack.org/queens/schedule.html | 15:15 |
| d0ugal | therve: "Final release for non-client libraries" and "Final release for client libraries" | 15:15 |
| d0ugal | therve: sorry | 15:15 |
| d0ugal | thrash: that shows you the dates for the different releases | 15:15 |
| thrash | d0ugal: ahh | 15:15 |
| thrash | thanks | 15:15 |
| d0ugal | mcdoker181818: did we have a bug report for this? | 15:15 |
| mcdoker181818 | d0ugal: https://bugs.launchpad.net/mistral/+bug/1736821 | 15:16 |
| openstack | Launchpad bug 1736821 in Mistral "Any workflows are not executed if you use PostgreSQL" [High,Fix released] - Assigned to Renat Akhmerov (rakhmerov) | 15:16 |
| d0ugal | mcdoker181818: for future reference it is useful to add "Closes-Bug: #1736821" to the commit message. | 15:17 |
| d0ugal | mcdoker181818: I am going to add it to the backport - sometimes the release team check for bugs to find out more about backports and check they are good | 15:18 |
| mcdoker181818 | d0ugal: Ok | 15:19 |
| rakhmerov | d0ugal: hi | 15:20 |
| d0ugal | rakhmerov: Hey | 15:20 |
| openstackgerrit | Dougal Matthews proposed openstack/mistral stable/pike: Fixed integration of the unit tests with PosrgeSQL https://review.openstack.org/542876 | 15:20 |
| rakhmerov | I can't understand for some reason what commit this hash points to: 82d5d10f8995b42104f4d5cd55a622d230207b03 | 15:20 |
| rakhmerov | I'm looking at your patch to releases | 15:20 |
| d0ugal | rakhmerov: I guess your local mistral is out of date? | 15:20 |
| rakhmerov | when I put it in the searchbox I get no results | 15:20 |
| d0ugal | searchbox? | 15:21 |
| d0ugal | https://github.com/openstack/mistral/commit/82d5d10f8995b42104f4d5cd55a622d230207b03 | 15:21 |
| d0ugal | ^ you can see it there | 15:21 |
| rakhmerov | github I mean | 15:21 |
| d0ugal | oh, maybe because it is a merge commit? | 15:21 |
| rakhmerov | ooh, may be | 15:21 |
| rakhmerov | yeah | 15:21 |
| rakhmerov | afaik, we should also be able to find it via gerrit UI too | 15:21 |
| rakhmerov | unless it's a merge commit | 15:22 |
| d0ugal | probably | 15:22 |
| d0ugal | I done it locally on the CLI | 15:22 |
| rakhmerov | ok, np | 15:22 |
| rakhmerov | I see now, just wanted to validate | 15:22 |
| rakhmerov | thanks | 15:22 |
| d0ugal | rakhmerov: btw, I am going to approve this backport if you are happy with it: https://review.openstack.org/#/c/542876/ | 15:22 |
| d0ugal | rakhmerov: and do a pike release | 15:22 |
| d0ugal | the postgres fix that mcdoker181818 done hasn't been released yet | 15:22 |
| *** livelace-link has joined #openstack-mistral | 15:23 | |
| rakhmerov | d0ugal: yes, I'm ok with it | 15:24 |
| rakhmerov | I'll approve | 15:24 |
| d0ugal | Thanks | 15:24 |
| d0ugal | rakhmerov: I am actually not sure what our backport review policy is. | 15:24 |
| d0ugal | i.e. in tripleo it is two core +2's unless the backport is proposed by a core | 15:25 |
| rakhmerov | I've always just approved it if we agreed on the idea of the backport itself | 15:26 |
| d0ugal | makes sense | 15:27 |
| *** livelace-link has quit IRC | 15:28 | |
| rakhmerov | d0ugal: once in a while we have to merge a changed version of the original commit. In this case IMO it should be the same policy as with master | 15:28 |
| rakhmerov | 2 +2 and approve | 15:28 |
| d0ugal | yeah, makes sense | 15:28 |
| *** livelace-link has joined #openstack-mistral | 15:30 | |
| *** kushalAgrawal has quit IRC | 15:36 | |
| *** kushalAgrawal has joined #openstack-mistral | 15:36 | |
| *** AlexeyAbashkin has quit IRC | 15:40 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 15:42 | |
| *** AlexeyAbashkin has quit IRC | 15:46 | |
| *** pengdake_ has joined #openstack-mistral | 16:04 | |
| *** jaosorior has quit IRC | 16:10 | |
| *** itlinux has joined #openstack-mistral | 16:11 | |
| *** pengdake_ has quit IRC | 16:20 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 17:12 | |
| *** jpich has quit IRC | 17:32 | |
| *** harlowja has joined #openstack-mistral | 17:37 | |
| *** mcdoker181818 has quit IRC | 17:45 | |
| *** AlexeyAbashkin has quit IRC | 17:48 | |
| *** shardy has quit IRC | 17:51 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 18:00 | |
| *** AlexeyAbashkin has quit IRC | 18:04 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 18:08 | |
| *** yangyapeng has quit IRC | 18:09 | |
| *** yangyapeng has joined #openstack-mistral | 18:10 | |
| *** yangyapeng has quit IRC | 18:14 | |
| *** yangyapeng has joined #openstack-mistral | 19:11 | |
| *** yangyapeng has quit IRC | 19:15 | |
| *** AlexeyAbashkin has quit IRC | 19:21 | |
| openstackgerrit | Merged openstack/mistral stable/pike: Fixed integration of the unit tests with PosrgeSQL https://review.openstack.org/542876 | 19:21 |
| *** AlexeyAbashkin has joined #openstack-mistral | 19:49 | |
| *** yangyapeng has joined #openstack-mistral | 19:51 | |
| *** AlexeyAbashkin has quit IRC | 19:53 | |
| *** yangyapeng has quit IRC | 19:56 | |
| *** yangyapeng has joined #openstack-mistral | 20:12 | |
| *** yangyapeng has quit IRC | 20:17 | |
| *** yangyapeng has joined #openstack-mistral | 20:22 | |
| *** yangyapeng has quit IRC | 20:26 | |
| *** yangyapeng has joined #openstack-mistral | 20:55 | |
| *** yangyapeng has quit IRC | 20:59 | |
| *** livelace-link has quit IRC | 21:10 | |
| *** yangyapeng has joined #openstack-mistral | 21:25 | |
| *** yangyapeng has quit IRC | 21:30 | |
| *** dprince has joined #openstack-mistral | 22:03 | |
| *** toure is now known as toure|gone | 22:03 | |
| *** kong has quit IRC | 22:05 | |
| *** kong has joined #openstack-mistral | 22:06 | |
| openstackgerrit | Winson Chan proposed openstack/mistral master: Implement notification of execution events https://review.openstack.org/467799 | 22:36 |
| *** yangyapeng has joined #openstack-mistral | 22:37 | |
| *** yangyapeng has quit IRC | 22:41 | |
| *** cargonza has quit IRC | 22:53 | |
| *** dprince has quit IRC | 22:54 | |
| *** cargonza has joined #openstack-mistral | 22:54 | |
| *** jtomasek has quit IRC | 23:11 | |
| *** csatari has quit IRC | 23:14 | |
| *** csatari has joined #openstack-mistral | 23:15 | |
| *** yangyapeng has joined #openstack-mistral | 23:48 | |
| *** yangyapeng has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!