| *** bobh has joined #openstack-mistral | 00:01 | |
| *** bobh has quit IRC | 00:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mistral master: Updated from global requirements https://review.openstack.org/538703 | 00:13 |
|---|---|---|
| *** bobh has joined #openstack-mistral | 00:20 | |
| *** bobh has quit IRC | 00:24 | |
| *** yangyapeng has quit IRC | 00:29 | |
| *** yangyapeng has joined #openstack-mistral | 00:30 | |
| *** bobh has joined #openstack-mistral | 00:31 | |
| *** yangyapeng has quit IRC | 00:34 | |
| *** bobh has quit IRC | 00:35 | |
| *** bobh has joined #openstack-mistral | 00:40 | |
| *** bobh has quit IRC | 00:45 | |
| *** kushalagrawal has quit IRC | 00:51 | |
| *** kushalagrawal has joined #openstack-mistral | 00:52 | |
| *** kushalagrawal has quit IRC | 01:16 | |
| *** yangyapeng has joined #openstack-mistral | 01:16 | |
| *** kushalagrawal has joined #openstack-mistral | 01:16 | |
| *** harlowja has joined #openstack-mistral | 03:11 | |
| *** harlowja has quit IRC | 03:18 | |
| *** gkadam_ has quit IRC | 03:58 | |
| *** kushalagrawal has quit IRC | 04:19 | |
| *** kushalagrawal has joined #openstack-mistral | 04:19 | |
| rakhmerov | apetrich, d0ugal: hi, I still didn't release Mistral server and client, they moved deadlines to today for servers and tomorrow for clients | 04:30 |
| rakhmerov | I'd like to get this patch in this release: https://review.openstack.org/#/c/538149/ | 04:30 |
| rakhmerov | if you have a minute to review it.. | 04:30 |
| *** daidv has joined #openstack-mistral | 04:31 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 05:06 | |
| *** AlexeyAbashkin has quit IRC | 05:10 | |
| rakhmerov | apetrich, d0ugal: https://review.openstack.org/#/c/506652/ | 05:12 |
| *** AlexeyAbashkin has joined #openstack-mistral | 05:31 | |
| *** mcdoker181818 has joined #openstack-mistral | 05:32 | |
| *** AlexeyAbashkin has quit IRC | 05:46 | |
| *** gkadam has joined #openstack-mistral | 05:47 | |
| openstackgerrit | Merged openstack/mistral master: Updated from global requirements https://review.openstack.org/538703 | 05:49 |
| *** kushalagrawal has quit IRC | 06:06 | |
| *** kushalagrawal has joined #openstack-mistral | 06:08 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 06:17 | |
| openstackgerrit | Tuan Luong-Anh proposed openstack/mistral master: Fix some reST field lists in docstrings https://review.openstack.org/538808 | 07:21 |
| *** kushalagrawal has quit IRC | 07:23 | |
| *** kushalagrawal has joined #openstack-mistral | 07:25 | |
| openstackgerrit | Renat Akhmerov proposed openstack/python-mistralclient master: Migrate python-mistralclient jobs to Zuul v3 https://review.openstack.org/509184 | 07:25 |
| openstackgerrit | Merged openstack/mistral master: Disable the wsme Sphinx extension from the API ref docs https://review.openstack.org/537848 | 07:28 |
| *** akazakov has joined #openstack-mistral | 07:48 | |
| *** AlexeyAbashkin has quit IRC | 07:55 | |
| *** jtomasek has joined #openstack-mistral | 08:01 | |
| *** zhenguo has joined #openstack-mistral | 08:16 | |
| *** d0ugal has quit IRC | 08:22 | |
| *** d0ugal has joined #openstack-mistral | 08:28 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 08:35 | |
| *** AlexeyAbashkin has quit IRC | 08:40 | |
| *** jpich has joined #openstack-mistral | 08:41 | |
| apetrich | rakhmerov, looking at it. when you say in the bug "We need to optimize the code in way that this call is not needed any more." just removing that call is all? | 08:42 |
| apetrich | rakhmerov, I need to reboot. I'll be right back | 08:43 |
| *** apetrich has quit IRC | 08:44 | |
| rakhmerov | apetrich: I thought something would crash on unit tests | 08:46 |
| rakhmerov | the fact that it nothing crashed tells me that this call wasn't needed | 08:46 |
| rakhmerov | but it really initializes (loads from DB) the entire collection which is redundant | 08:47 |
| rakhmerov | so from SQLAlchemy perspective, we don't break any flows where we use DB session | 08:47 |
| *** d0ugal has quit IRC | 09:00 | |
| *** d0ugal has joined #openstack-mistral | 09:20 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 09:22 | |
| *** apetrich has joined #openstack-mistral | 09:28 | |
| apetrich | rakhmerov, back. sorry the reboot was more eventful than I was hoping for | 09:28 |
| rakhmerov | apetrich: np ) | 09:29 |
| rakhmerov | thanks for review! | 09:29 |
| rakhmerov | ooh, it's not reviewed yet ) | 09:29 |
| rakhmerov | looked at the wrong patch )) | 09:29 |
| apetrich | :) so I'm looking at the https://review.openstack.org/#/c/538149/2 | 09:31 |
| apetrich | looks ok but I wanted more info | 09:31 |
| apetrich | rakhmerov, the other one I agree with you and would like more tests | 09:32 |
| rakhmerov | apetrich: indirectly, it's already tested ) | 09:35 |
| rakhmerov | because nothing is broken in unit tests | 09:35 |
| apetrich | aye | 09:35 |
| rakhmerov | the only thing else we can do is to check how SQLAlchemy session keeps info about this collection | 09:36 |
| apetrich | rakhmerov, the more tests comment was for the https://review.openstack.org/#/c/506652/16 | 09:36 |
| rakhmerov | but that sounds really horrible to me | 09:36 |
| rakhmerov | usually such tests are very unstable and give a lot of pain | 09:36 |
| apetrich | I'm multitasking and being bad at explaining that to others :) | 09:36 |
| apetrich | sorry | 09:36 |
| rakhmerov | so, honestly, I don't see a good way to explicitly test taht | 09:36 |
| rakhmerov | that | 09:36 |
| rakhmerov | that's ok | 09:37 |
| apetrich | let me fix on one at a time. talking about the "Remove addition of a new task execution to task_executions collection" | 09:37 |
| apetrich | looks fine and I just wanted more info why we had that call and don't need it anymore | 09:37 |
| rakhmerov | apetrich: we had this call because some long time ago we used wf_ex.task_executions collections after this place within the same transaction | 09:39 |
| rakhmerov | and found that it was not initialized properly, it didn't have this new element | 09:40 |
| rakhmerov | but then we made a lot of changes and we don't need this whole collection anymore within this transaction | 09:40 |
| rakhmerov | and we can simply omit it | 09:40 |
| apetrich | nesy | 09:41 |
| apetrich | neat* | 09:41 |
| rakhmerov | previously, unit tests would have failed if we had removed it | 09:41 |
| rakhmerov | I remember that very clearly | 09:41 |
| apetrich | thanks. reviewed | 09:41 |
| rakhmerov | thanks | 09:41 |
| *** shardy has joined #openstack-mistral | 09:43 | |
| apetrich | now talking about https://review.openstack.org/#/c/506652/16 I agree with your comment about having a bit more tests would be nice | 09:45 |
| apetrich | so I'm not sure if I should +1 or +2 that | 09:49 |
| apetrich | oh d0ugal just approved it | 09:51 |
| apetrich | :) | 09:51 |
| *** mcdoker181818 has quit IRC | 09:56 | |
| *** mcdoker181818 has joined #openstack-mistral | 09:57 | |
| *** AlexeyAbashkin has quit IRC | 10:13 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 10:13 | |
| *** mcdoker181818 has quit IRC | 10:14 | |
| *** mcdoker181818 has joined #openstack-mistral | 10:15 | |
| d0ugal | :-D | 10:21 |
| d0ugal | yolo | 10:22 |
| d0ugal | apetrich: toure said somewhere that he would add more tests in a follow up | 10:22 |
| d0ugal | I think I seen it in here | 10:22 |
| d0ugal | so I guess we just need to make sure that happens - opening a bug would be one way to make sure we don't forget. | 10:23 |
| d0ugal | I'll do that. | 10:23 |
| apetrich | d0ugal, neat | 10:24 |
| d0ugal | toure: Present for ya :) https://bugs.launchpad.net/mistral/+bug/1745962 | 10:27 |
| openstack | Launchpad bug 1745962 in Mistral "More tests for running a workflow based on an existing execution" [Medium,Confirmed] - Assigned to Toure Dunnon (toure) | 10:27 |
| d0ugal | apetrich: ^ | 10:27 |
| *** oidgar has joined #openstack-mistral | 10:28 | |
| *** threestrands_ has joined #openstack-mistral | 10:33 | |
| *** threestrands has quit IRC | 10:36 | |
| *** jappleii__ has joined #openstack-mistral | 10:37 | |
| *** jappleii__ has quit IRC | 10:38 | |
| *** jappleii__ has joined #openstack-mistral | 10:39 | |
| *** threestrands_ has quit IRC | 10:41 | |
| rakhmerov | :)) | 10:41 |
| rakhmerov | d0ugal: can you please help me with something? | 10:41 |
| rakhmerov | https://review.openstack.org/#/c/538438/ | 10:41 |
| d0ugal | I can try! | 10:41 |
| rakhmerov | I made a WIP for the client release | 10:41 |
| rakhmerov | but I think I don't understand something with versioning | 10:41 |
| d0ugal | Looking. | 10:41 |
| rakhmerov | the latest release is 3.1.4 | 10:41 |
| rakhmerov | I tried to make 3.1.5 and stable branch out of it | 10:41 |
| d0ugal | rakhmerov: "Initial releases in a series must increment at least the minor version or be beta versions. '3.1.5'" | 10:42 |
| d0ugal | You incremented the "patch" only | 10:42 |
| d0ugal | 3.2.0 | 10:42 |
| d0ugal | That would work. | 10:42 |
| rakhmerov | ooh, shoot.. | 10:43 |
| rakhmerov | so every cycle we have to increment at least a minor version | 10:43 |
| rakhmerov | ok | 10:43 |
| d0ugal | Yeah | 10:43 |
| d0ugal | because patch should be reserved for backported bug fixing | 10:43 |
| d0ugal | rakhmerov: looking at the previous releases... we have been a bit inconsistent :) | 10:45 |
| d0ugal | Sometimes we bump the major with the release, sometimes only the minor | 10:45 |
| rakhmerov | yeah.. I know | 10:45 |
| d0ugal | i.e. Ocata was 3.0, but I don't think it was backwards incompatible. | 10:46 |
| rakhmerov | ok, I'll make 3.2.0 | 10:46 |
| d0ugal | Sounds good, I think it is quite a small release for mistralclient. | 10:46 |
| rakhmerov | yes | 10:49 |
| rakhmerov | d0ugal: resent the patch | 10:49 |
| rakhmerov | d0ugal: can you please also look at https://review.openstack.org/#/c/538442/ ? | 10:49 |
| rakhmerov | I didn't fill the hash yet, still waiting for one more patch to merge | 10:49 |
| rakhmerov | but does the rest look OK? | 10:50 |
| d0ugal | rakhmerov: Yeah, looks good | 10:50 |
| *** jaosorior has joined #openstack-mistral | 10:52 | |
| rakhmerov | ok | 10:52 |
| rakhmerov | just waiting for https://review.openstack.org/#/c/538149/ | 10:53 |
| *** kushalagrawal has quit IRC | 10:53 | |
| mcdoker181818 | Hi. Do we have a time to merge this MR https://review.openstack.org/#/c/506653/ to new mistral-cli release ? | 10:53 |
| *** kushalagrawal has joined #openstack-mistral | 10:55 | |
| mcdoker181818 | Or is it too late? | 10:55 |
| rakhmerov | mcdoker181818: hi, theoretically yes | 10:57 |
| rakhmerov | the deadline for clients is tomorrow | 10:57 |
| rakhmerov | I can mark my release patch as WIP and give it a chance | 10:57 |
| rakhmerov | btw, seems like Zuul is down again.. | 10:58 |
| rakhmerov | damn.. | 10:58 |
| rakhmerov | yep, out of memory on Zuul: http://cacti.openstack.org/cacti/graph.php?action=view&local_graph_id=64792&rra_id=all | 11:00 |
| mcdoker181818 | rakhmerov: If possible. I think this feature will be used in most cases through mistral-cli. | 11:06 |
| rakhmerov | I agree with you | 11:06 |
| rakhmerov | mcdoker181818: btw, if you have capacity you can help finish this patch | 11:06 |
| rakhmerov | :) | 11:06 |
| mcdoker181818 | Okay, no problem. I'll do it in an hour | 11:11 |
| *** AlexeyAbashkin has quit IRC | 11:23 | |
| rakhmerov | mcdoker181818: yes, please | 11:25 |
| rakhmerov | the sooner the better | 11:25 |
| rakhmerov | given our CI problems I'd like to do it asap | 11:25 |
| rakhmerov | mcdoker181818: once you fix the patch, please let myself, apetrich and d0ugal know about it | 11:26 |
| *** kushalagrawal has quit IRC | 11:29 | |
| *** kushalagrawal has joined #openstack-mistral | 11:29 | |
| *** kushalagrawal has quit IRC | 11:49 | |
| *** kushalagrawal has joined #openstack-mistral | 11:50 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 11:59 | |
| *** katkapilatova has joined #openstack-mistral | 12:39 | |
| *** kushalagrawal has quit IRC | 13:03 | |
| *** kushalagrawal has joined #openstack-mistral | 13:04 | |
| openstackgerrit | Vitalii Solodilov proposed openstack/python-mistralclient master: Running new workflow based on existing execution. https://review.openstack.org/506653 | 13:12 |
| mcdoker181818 | rakhmerov: apetrich: d0ugal: please, take a look https://review.openstack.org/506653 | 13:13 |
| *** rbrady has joined #openstack-mistral | 13:13 | |
| *** thrash|g0ne is now known as thrash | 13:18 | |
| *** dprince has joined #openstack-mistral | 13:19 | |
| d0ugal | LGTM | 13:37 |
| *** d0ugal has quit IRC | 13:38 | |
| *** d0ugal has joined #openstack-mistral | 13:38 | |
| * toure accepts d0ugal's gift | 14:03 | |
| toure | :) | 14:03 |
| apetrich | mcdoker181818, for me two waiting for the ci to finish | 14:04 |
| *** zhenguo has quit IRC | 14:05 | |
| *** gkadam has quit IRC | 14:33 | |
| toure | d0ugal apetrich https://review.openstack.org/#/c/514360/ | 14:39 |
| toure | could you guys take a look | 14:39 |
| d0ugal | toure: I think we should maybe wait for rocky, since there isn't anything using it or testing it that I know of | 14:40 |
| toure | d0ugal that works for me | 14:40 |
| apetrich | toure, sure looking after scrum | 14:41 |
| *** daidv has quit IRC | 14:49 | |
| *** daidv has joined #openstack-mistral | 14:49 | |
| *** kushalagrawal has quit IRC | 14:51 | |
| *** kushalagrawal has joined #openstack-mistral | 14:51 | |
| *** yangyapeng has quit IRC | 15:01 | |
| mcdoker181818 | Where do I look a progress of a job execution? d0ugal mention http://zuulv3.openstack.org . But it doesn't work now. | 15:08 |
| d0ugal | mcdoker181818: I believe it has moved back to http://zuul.openstack.org/ | 15:09 |
| d0ugal | mcdoker181818: for a while zuul.o.org was the old version, seems like the switch happened recently. | 15:10 |
| mcdoker181818 | d0ugal: Thank you | 15:15 |
| d0ugal | np | 15:16 |
| d0ugal | mcdoker181818: for some reason I don't see that patch in the list... | 15:19 |
| *** oidgar has quit IRC | 15:19 | |
| openstackgerrit | Brad P. Crochet proposed openstack/python-mistralclient master: Migrate python-mistralclient jobs to Zuul v3 https://review.openstack.org/509184 | 15:21 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-mistralclient master: Migrate python-mistralclient jobs to Zuul v3 https://review.openstack.org/509184 | 15:23 |
| *** thrash is now known as thrash|biab | 15:25 | |
| *** bobh_ has joined #openstack-mistral | 15:26 | |
| *** bobh_ has quit IRC | 15:28 | |
| *** kushalagrawal has quit IRC | 15:29 | |
| *** kushalagrawal has joined #openstack-mistral | 15:30 | |
| *** thrash|biab is now known as thrash | 15:56 | |
| *** jappleii__ has quit IRC | 16:05 | |
| openstackgerrit | Merged openstack/mistral master: Remove addition of a new task execution to task_executions collection https://review.openstack.org/538149 | 16:16 |
| openstackgerrit | Merged openstack/mistral master: Running new workflow based on an existing execution. https://review.openstack.org/506652 | 16:23 |
| *** yangyapeng has joined #openstack-mistral | 16:30 | |
| *** yangyapeng has quit IRC | 16:34 | |
| *** oidgar has joined #openstack-mistral | 16:47 | |
| *** jpich has quit IRC | 16:59 | |
| rakhmerov | d0ugal: hey | 17:08 |
| rakhmerov | still here? | 17:08 |
| *** kushalagrawal has quit IRC | 17:28 | |
| *** kushalagrawal has joined #openstack-mistral | 17:28 | |
| *** yangyapeng has joined #openstack-mistral | 17:31 | |
| *** AlexeyAbashkin has quit IRC | 17:34 | |
| *** yangyapeng has quit IRC | 17:36 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 17:37 | |
| *** oidgar has quit IRC | 17:40 | |
| *** AlexeyAbashkin has quit IRC | 17:41 | |
| *** thrash is now known as thrash|biab | 17:50 | |
| *** yangyapeng has joined #openstack-mistral | 17:52 | |
| openstackgerrit | Vitalii Solodilov proposed openstack/python-mistralclient master: Running new workflow based on existing execution. https://review.openstack.org/506653 | 17:55 |
| *** yangyapeng has quit IRC | 17:56 | |
| *** weshay|ruck is now known as weshay|ruck|brb | 18:09 | |
| *** weshay|ruck|brb is now known as weshay | 18:20 | |
| *** weshay is now known as weshay|ruck | 18:20 | |
| *** kushalagrawal has quit IRC | 18:21 | |
| *** kushalagrawal has joined #openstack-mistral | 18:22 | |
| *** thrash|biab is now known as thrash | 18:42 | |
| *** kushalagrawal has quit IRC | 18:45 | |
| *** kushalagrawal has joined #openstack-mistral | 18:46 | |
| *** jaosorior has quit IRC | 18:48 | |
| *** yangyapeng has joined #openstack-mistral | 18:54 | |
| *** shardy has quit IRC | 18:56 | |
| *** yangyapeng has quit IRC | 18:58 | |
| *** kushalagrawal has quit IRC | 19:01 | |
| *** kushalagrawal has joined #openstack-mistral | 19:01 | |
| *** dprince has quit IRC | 19:10 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 19:11 | |
| *** yangyapeng has joined #openstack-mistral | 19:14 | |
| *** yangyapeng has quit IRC | 19:19 | |
| *** harlowja has joined #openstack-mistral | 19:25 | |
| *** yangyapeng has joined #openstack-mistral | 19:35 | |
| d0ugal | rakhmerov: not really :) | 19:37 |
| *** yangyapeng has quit IRC | 19:40 | |
| *** dprince has joined #openstack-mistral | 19:45 | |
| openstackgerrit | Brad P. Crochet proposed openstack/python-mistralclient master: Migrate python-mistralclient jobs to Zuul v3 https://review.openstack.org/509184 | 19:46 |
| *** yangyapeng has joined #openstack-mistral | 19:56 | |
| *** yangyapeng has quit IRC | 20:00 | |
| *** yangyapeng has joined #openstack-mistral | 20:16 | |
| *** mcdoker181818 has quit IRC | 20:21 | |
| *** yangyapeng has quit IRC | 20:21 | |
| *** mcdoker181818 has joined #openstack-mistral | 20:22 | |
| *** AlexeyAbashkin has quit IRC | 20:25 | |
| *** yangyapeng has joined #openstack-mistral | 20:37 | |
| *** kushalagrawal has quit IRC | 20:40 | |
| *** kushalagrawal has joined #openstack-mistral | 20:40 | |
| *** yangyapeng has quit IRC | 20:41 | |
| *** kushalagrawal has quit IRC | 21:00 | |
| *** yangyapeng has joined #openstack-mistral | 21:01 | |
| *** kushalagrawal has joined #openstack-mistral | 21:01 | |
| *** yangyapeng has quit IRC | 21:05 | |
| *** yangyapeng has joined #openstack-mistral | 21:22 | |
| *** kushalagrawal has quit IRC | 21:22 | |
| *** dprince has quit IRC | 21:22 | |
| *** kushalagrawal has joined #openstack-mistral | 21:24 | |
| *** yangyapeng has quit IRC | 21:26 | |
| *** threestrands has joined #openstack-mistral | 22:05 | |
| *** threestrands has quit IRC | 22:05 | |
| *** threestrands has joined #openstack-mistral | 22:05 | |
| *** threestrands_ has joined #openstack-mistral | 22:07 | |
| *** threestrands has quit IRC | 22:08 | |
| *** threestrands_ has quit IRC | 22:08 | |
| *** threestrands has joined #openstack-mistral | 22:08 | |
| *** threestrands has quit IRC | 22:08 | |
| *** threestrands has joined #openstack-mistral | 22:08 | |
| openstackgerrit | Vitalii Solodilov proposed openstack/python-mistralclient master: Running new workflow based on existing execution. https://review.openstack.org/506653 | 22:13 |
| *** threestrands_ has joined #openstack-mistral | 22:21 | |
| *** threestrands has quit IRC | 22:23 | |
| *** jappleii__ has joined #openstack-mistral | 22:35 | |
| *** jappleii__ has quit IRC | 22:36 | |
| *** jappleii__ has joined #openstack-mistral | 22:37 | |
| *** threestrands_ has quit IRC | 22:37 | |
| openstackgerrit | Vitalii Solodilov proposed openstack/mistral master: Propagated a task timeout to a action execution https://review.openstack.org/539039 | 22:55 |
| *** weshay|ruck is now known as weshay|ruck|afk | 23:07 | |
| *** yangyapeng has joined #openstack-mistral | 23:07 | |
| *** yangyapeng has quit IRC | 23:12 | |
| *** yangyapeng has joined #openstack-mistral | 23:16 | |
| *** yangyapeng has quit IRC | 23:21 | |
| *** yangyapeng has joined #openstack-mistral | 23:29 | |
| *** yangyapeng has quit IRC | 23:33 | |
| *** kushalagrawal has quit IRC | 23:34 | |
| *** kushalagrawal has joined #openstack-mistral | 23:35 | |
| *** igormarnat has quit IRC | 23:45 | |
| *** jistr has quit IRC | 23:45 | |
| *** yangyapeng has joined #openstack-mistral | 23:49 | |
| *** igormarnat has joined #openstack-mistral | 23:51 | |
| *** jistr has joined #openstack-mistral | 23:51 | |
| openstackgerrit | Vitalii Solodilov proposed openstack/mistral master: Improved the Docker integration https://review.openstack.org/539048 | 23:52 |
| *** yangyapeng has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!