*** bobh has joined #openstack-mistral | 00:08 | |
*** kushalagrawal has quit IRC | 00:28 | |
*** kushalagrawal has joined #openstack-mistral | 00:28 | |
*** bobh has quit IRC | 00:39 | |
*** zhurong has joined #openstack-mistral | 00:51 | |
*** zhurong_ has joined #openstack-mistral | 00:52 | |
*** apetrich has quit IRC | 00:55 | |
*** kushalagrawal has quit IRC | 00:59 | |
*** kushalagrawal has joined #openstack-mistral | 01:00 | |
*** kushalagrawal has quit IRC | 01:24 | |
*** bobh has joined #openstack-mistral | 01:24 | |
*** kushalagrawal has joined #openstack-mistral | 01:24 | |
*** bobh has quit IRC | 01:26 | |
*** apetrich has joined #openstack-mistral | 01:52 | |
*** kushalagrawal has quit IRC | 02:08 | |
*** kushalagrawal has joined #openstack-mistral | 02:09 | |
*** harlowja has quit IRC | 02:16 | |
*** zhurong has quit IRC | 02:24 | |
*** kushalagrawal has quit IRC | 02:32 | |
*** kushalagrawal has joined #openstack-mistral | 02:33 | |
*** kushalagrawal has quit IRC | 03:01 | |
*** kushalagrawal has joined #openstack-mistral | 03:03 | |
rakhmerov | thrash|g0ne: hey, still here? | 03:41 |
---|---|---|
rakhmerov | apetrich, d0ugal: hi, we need this patch in the release we're about to issue: https://review.openstack.org/#/c/512021/ | 03:42 |
rakhmerov | please spend some time to review it today | 03:42 |
rakhmerov | d0ugal: what is it for? https://review.openstack.org/#/c/537837 | 03:44 |
rakhmerov | :) | 03:44 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Fix the 'params' field of the workflow execution REST resource https://review.openstack.org/537793 | 03:46 |
rakhmerov | toure|gone: hey Toure, I voted +2 on https://review.openstack.org/#/c/506652 but I left a comment there about tests, please read | 03:50 |
*** kushalagrawal has quit IRC | 03:57 | |
*** kushalagrawal has joined #openstack-mistral | 03:58 | |
*** zhurong_ has quit IRC | 04:39 | |
rakhmerov | mcdoker181818: hi, could you please rebase https://review.openstack.org/#/c/528494/ ? | 04:47 |
*** harlowja has joined #openstack-mistral | 04:51 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: WIP: Fix docs to better reflect Jinja and YAQL usage https://review.openstack.org/538148 | 05:10 |
*** kushalagrawal has quit IRC | 05:11 | |
*** kushalagrawal has joined #openstack-mistral | 05:12 | |
*** zhurong has joined #openstack-mistral | 05:18 | |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Remove addition of a new task execution to task_executions collection https://review.openstack.org/538149 | 05:23 |
openstackgerrit | Vitalii Solodilov proposed openstack/mistral master: Fixed the length of a task name https://review.openstack.org/528494 | 06:20 |
mcdoker181818 | rakhmerov: Hi, done | 06:24 |
rakhmerov | thanks ) | 06:24 |
*** zhurong has quit IRC | 06:52 | |
*** gkadam has joined #openstack-mistral | 07:08 | |
*** kushalagrawal has quit IRC | 07:20 | |
*** kushalagrawal has joined #openstack-mistral | 07:21 | |
*** harlowja has quit IRC | 07:23 | |
*** mcdoker18181818 has joined #openstack-mistral | 07:23 | |
*** mcdoker181818 has quit IRC | 07:23 | |
openstackgerrit | Merged openstack/mistral master: Updated from global requirements https://review.openstack.org/537064 | 07:25 |
*** jtomasek has joined #openstack-mistral | 07:33 | |
apetrich | rakhmerov, that https://review.openstack.org/#/c/53783 was a test to see if the failing sphinx job was triggering | 07:39 |
rakhmerov | ok | 07:39 |
apetrich | rakhmerov, I will test the keystone patch today | 07:40 |
rakhmerov | ok | 07:40 |
rakhmerov | thanks | 07:40 |
rakhmerov | we need to make a release today | 07:40 |
rakhmerov | for both server and client | 07:40 |
apetrich | rakhmerov, I found this very neat way of testing patches https://docs.openstack.org/tripleo-docs/latest/contributor/reproduce-ci.html | 07:40 |
rakhmerov | that's I'm a little in rush | 07:41 |
apetrich | sure do | 07:41 |
apetrich | let me just start the day and then I will jump right into it | 07:41 |
openstackgerrit | Adriano Petrich proposed openstack/python-mistralclient master: Clean up keystone authentication https://review.openstack.org/512021 | 07:42 |
apetrich | I'm rebasing it btw | 07:43 |
rakhmerov | yes, ok | 07:59 |
*** d0ugal has quit IRC | 08:04 | |
rakhmerov | apetrich: I didn't quite understand what https://docs.openstack.org/tripleo-docs/latest/contributor/reproduce-ci.html is for | 08:08 |
rakhmerov | it allows to reproduce CI jobs but in what way? | 08:08 |
rakhmerov | what's the different between our regular CI and this stuff? | 08:09 |
*** kushalagrawal has quit IRC | 08:10 | |
*** akazakov has quit IRC | 08:11 | |
*** kushalagrawal has joined #openstack-mistral | 08:11 | |
*** akazakov has joined #openstack-mistral | 08:13 | |
*** jpich has joined #openstack-mistral | 08:14 | |
apetrich | it allows you to "rerun" the exact ci run with the same parameters | 08:21 |
apetrich | in an easy way | 08:21 |
akazakov | Hi guys! Does anyone know why mistral api service needs this setup_db() call when starting? https://github.com/openstack/mistral/blob/master/mistral/api/app.py#L54 | 08:23 |
akazakov | We have a case when mistral should start without available database. In such case api fails to start because of this call. | 08:23 |
*** d0ugal has joined #openstack-mistral | 08:23 | |
rakhmerov | akazakov: hi | 08:31 |
rakhmerov | Mistral needs a database :) | 08:31 |
rakhmerov | Mistral API I mean | 08:32 |
rakhmerov | that's why it needs to initialize what's needed to be able to work with DB | 08:32 |
rakhmerov | however, Mistral executor doesn't require DB and can run w/o it | 08:32 |
rakhmerov | a lot of API requests don't go to Mistral Engine, they simply work based on DB access | 08:33 |
rakhmerov | apetrich: ok, thanks. I may try that some day ) | 08:33 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Disable the wsme Sphinx extension from the API ref docs https://review.openstack.org/537848 | 08:34 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Fixed the length of a task name https://review.openstack.org/528494 | 08:36 |
rakhmerov | apetrich: our CI drives me crazy.. I don't already remember times when we could normally develop. Most of the time we struggle with CI issues | 08:37 |
rakhmerov | we need some breakthrough on that front ) | 08:37 |
openstackgerrit | Merged openstack/mistral master: Remove any old client actions that no longer exist https://review.openstack.org/536886 | 08:38 |
*** AlexeyAbashkin has joined #openstack-mistral | 08:39 | |
apetrich | yeah that's why this reproducer script made me happy | 08:39 |
apetrich | still doesn't solve all or even many of the ci issues but helps with some large ones | 08:39 |
akazakov | rakhmerov: of course, Mistral API needs a database to process requests. But does it require DB to _start_? | 08:51 |
akazakov | The specific behaviour I want to achieve: 1) DB is not available, Mistral API starts (but unable to process requests) 2) Then DB starts 3) Mistral API becomes able to process requests without restarting | 08:52 |
rakhmerov | it's impossible now | 08:52 |
rakhmerov | well, we potentially could make it more flexible in that way | 08:53 |
rakhmerov | the thing is that our DB layer is now initialized the same way for engine and API | 08:54 |
rakhmerov | and it's considered a part of startup process | 08:54 |
rakhmerov | so that if it fails to init DB then the component doesn't start | 08:54 |
rakhmerov | yeah, we could weaken this requirement probably but I'm not sure about all the consequences of that now | 08:55 |
rakhmerov | what's the point of running a component if DB is unavailable, hm.. ? | 08:55 |
rakhmerov | we kinda know that we're starting something that won't be functioning properly | 08:56 |
rakhmerov | why do we need that? | 08:56 |
rakhmerov | however, keep in mind that if DB was up initially when say API was started then it deal with temporary outages of DB | 08:57 |
rakhmerov | disconnections etc. | 08:57 |
rakhmerov | part of that is built-in into connection pool implementation, partially in Mistral itself | 08:57 |
akazakov | rakhmerov in my case it Disaster Recovery. In openshift, for example, mistral may start before DB service is available | 08:58 |
rakhmerov | can you start it after DB is available? | 08:58 |
rakhmerov | in my view, it's a regular dependency between software pieces | 08:58 |
rakhmerov | you have software A (Mistral) that requires software B (DB) to be installed | 08:59 |
rakhmerov | and it's a matter of proper installation order | 08:59 |
*** kushalagrawal has quit IRC | 09:00 | |
*** kushalagrawal has joined #openstack-mistral | 09:01 | |
csatari | Hi we (still) try to install and configure Mistral based on the install guide to test it. | 09:15 |
csatari | https://docs.openstack.org/developer/mistral/guides/configuration_guide.html suggest to use oslo-config-generator, but when we execute the suggested command only a warning message is returned. | 09:16 |
*** kushalagrawal has quit IRC | 09:16 | |
csatari | And no change is visible in the config file. | 09:17 |
*** kushalagrawal has joined #openstack-mistral | 09:17 | |
csatari | Is this step really needed or can we remove it from the config guide. | 09:17 |
mcdoker18181818 | How is it possible? I don't understand ) | 09:20 |
mcdoker18181818 | InternalError: (pymysql.err.InternalError) (1071, u'Specified key was too long; max key length is 767 bytes') [SQL: u'ALTER TABLE task_executions_v2 MODIFY unique_key VARCHAR(350) NULL'] | 09:20 |
mcdoker18181818 | http://logs.openstack.org/94/528494/6/check/tripleo-ci-centos-7-scenario003-multinode-oooq-container/0a52cab/logs/undercloud/home/zuul/undercloud_install.log.txt.gz | 09:20 |
akazakov | rakhmerov for us, it's more about order of start, not order of installation | 09:21 |
akazakov | If running API can deal with temporary DB outages, why not make it to be able to deal with outages during start? | 09:21 |
d0ugal | rakhmerov: from what I understand, other openstack services will keep retrying to connect to the db - is this what you need akazakov? | 09:21 |
rakhmerov | mcdoker18181818: that was probably my concern that I tried to express in your patch :) | 09:23 |
apetrich | rakhmerov, I've tested and was about to +2 the keystone but d0ugal beat me to it :) | 09:23 |
rakhmerov | mcdoker18181818: ooh, I think I'm starting to recall now. Mysql has a limit on the indexed fields! Or fields that has a unique constraint | 09:23 |
rakhmerov | mcdoker18181818: please try to find it in the mysql docs | 09:24 |
mcdoker18181818 | rakhmerov: о_О | 09:24 |
rakhmerov | akazakov: like I said, it can be potentially done, yes. We've never focused on that, nobody asked for it. And making it deal with outages during startup is much more complicated thing | 09:25 |
rakhmerov | for a number of reasons | 09:25 |
rakhmerov | mcdoker18181818: yeah :((( | 09:25 |
rakhmerov | I remember I was surprised as well )) | 09:25 |
rakhmerov | d0ugal: really? | 09:26 |
rakhmerov | I didn't really know that | 09:26 |
rakhmerov | hm.. may then Mistral can do that too :)) I just realized I probably never tried that | 09:26 |
d0ugal | I'll see if I can find out more about it. | 09:27 |
d0ugal | but it makes things much easier for installers | 09:27 |
rakhmerov | I believe DB initialization is not that different in Mistral comparing to other projects | 09:27 |
d0ugal | Yeah, I assumed Mistral would do this already :) Maybe I can find something. | 09:27 |
rakhmerov | hah.. interesting | 09:27 |
rakhmerov | mcdoker18181818: can you please then mark your patch as WIP? | 09:28 |
rakhmerov | so that we don't merge it by mistake | 09:28 |
d0ugal | tripleo CI is blocking it :) | 09:29 |
rakhmerov | ok | 09:29 |
d0ugal | We should really run the migrations on another job too... | 09:29 |
d0ugal | but for now, that is the only place I think | 09:29 |
rakhmerov | d0ugal, apetrich: let's merge https://review.openstack.org/#/c/538026/ | 09:29 |
rakhmerov | if it's ok | 09:29 |
apetrich | rakhmerov, aye | 09:30 |
akazakov | d0ugal "is this what you need akazakov?" yep, thanks for clarifying | 09:30 |
d0ugal | akazakov: do you know which services do this? so I can look to see how they handle it. I just need an example. Heat maybe? | 09:31 |
rakhmerov | akazakov: are you sure that if you run Mistral API w/o available DB it won't start? | 09:31 |
rakhmerov | akazakov: we're now in doubts :) | 09:31 |
*** yangyapeng has quit IRC | 09:32 | |
rakhmerov | d0ugal: yep, good question.. | 09:32 |
openstackgerrit | Renat Akhmerov proposed openstack/mistral master: Remove addition of a new task execution to task_executions collection https://review.openstack.org/538149 | 09:33 |
akazakov | d0ugal sorry, no. Mistral is the first one I work with | 09:35 |
rakhmerov | apetrich, d0ugal: on another topic, for some reason when I now click on nearly any CI job links (e.g. docs) I get a page with "File not found" | 09:35 |
rakhmerov | any idea why? | 09:35 |
*** yangyapeng has joined #openstack-mistral | 09:35 | |
d0ugal | akazakov: no problem, I'll ask around :) | 09:35 |
apetrich | I was wondering the same | 09:35 |
d0ugal | no idea, I hadn't noticed. | 09:36 |
d0ugal | rakhmerov: This is the only clue I have found so far: https://github.com/openstack/oslo.db/blob/master/oslo_db/api.py#L192-L193 | 09:37 |
openstackgerrit | Merged openstack/python-mistralclient master: Clean up keystone authentication https://review.openstack.org/512021 | 09:39 |
d0ugal | rakhmerov: btw the sphinx docbuild is different from the api-ref, so even if the link worked it wouldn't verify my patch. For the api-ref docs build we need to re-enable the CI job | 09:40 |
d0ugal | Which I can do by reverting this revert: https://review.openstack.org/537839 | 09:40 |
rakhmerov | ooh, it was yesterday :) | 09:50 |
rakhmerov | I didn't even notice it | 09:50 |
akazakov | rakhmerov d0ugal here is exception example when API starts without DB https://gist.github.com/justTon/f738d69586f5fd05c8b1068e1d1f7aac | 09:50 |
d0ugal | akazakov: thanks | 09:51 |
rakhmerov | akazakov: are you sure it doesn't try to reconnect? | 09:51 |
rakhmerov | does it just exit? | 09:52 |
rakhmerov | "could not translate host name "postgres" to address: Try again" looks interesting.. | 09:52 |
rakhmerov | what if the host name is resolved but DB is still unavailable? | 09:52 |
rakhmerov | d0ugal: so if we revert that revert, we'll again have that CI job. Will it be failing again or it was already fixed? | 09:53 |
rakhmerov | I'm slightly confused | 09:53 |
d0ugal | rakhmerov: the two patches I put up should mean that it doesn't fail | 09:53 |
d0ugal | rakhmerov: but it doesn't really do anything either... somebody setup the api-ref documentation structure, but it is empty | 09:53 |
d0ugal | rakhmerov: You can test what the job will do with "tox -e api-ref" | 09:54 |
rakhmerov | ok | 09:54 |
rakhmerov | I just don't any CI degradation today ) | 09:54 |
rakhmerov | I'm in favour of dealing with this api-ref after we make a release | 09:55 |
d0ugal | rakhmerov: sure | 09:56 |
rakhmerov | d0ugal, apetrich: a small doc fix: https://review.openstack.org/#/c/537793 | 09:57 |
rakhmerov | ok, I'll be off in the next few hours | 09:57 |
openstackgerrit | Merged openstack/python-mistralclient master: Restore devstack job for python-mistralclient https://review.openstack.org/538026 | 10:11 |
*** kushalagrawal has quit IRC | 10:16 | |
*** kushalagrawal has joined #openstack-mistral | 10:17 | |
*** Trpger has joined #openstack-mistral | 10:34 | |
*** Trpger has left #openstack-mistral | 10:36 | |
akazakov | rakhmerov here is another example, with DB host resolved https://gist.github.com/justTon/a9412e7acb85830a8144f63c1bda4517 | 10:40 |
akazakov | rakhmerov "are you sure it doesn't try to reconnect?" yes, it just exits | 10:40 |
*** daidv has quit IRC | 10:58 | |
d0ugal | apetrich: it seems like CI output is not being uploaded for most of the jobs :( | 10:59 |
d0ugal | apetrich: try and see any of the CI output here: https://review.openstack.org/#/c/537848/ | 11:00 |
d0ugal | Only the cover job works. | 11:00 |
apetrich | yeah http://logs.openstack.org/48/537848/2/check/ | 11:01 |
apetrich | Oh i'm reading back the log from ci people and they are trying to fix it | 11:02 |
apetrich | as in last night | 11:02 |
d0ugal | apetrich: ah, so it isn't a mistral-only issue? good :) | 11:05 |
d0ugal | apetrich: makes it hard to use a reproducer script when it isn't there :( | 11:07 |
apetrich | d0ugal, but of course it would disappear when I discover it :) | 11:11 |
*** jkilpatr has quit IRC | 11:24 | |
*** jkilpatr has joined #openstack-mistral | 11:59 | |
*** kushalagrawal has quit IRC | 12:00 | |
*** kushalagrawal has joined #openstack-mistral | 12:01 | |
*** thrash|g0ne is now known as thrash | 12:25 | |
openstackgerrit | Merged openstack/mistral master: Remove the redundant word https://review.openstack.org/536292 | 12:27 |
openstackgerrit | Merged openstack/mistral master: Fix the 'params' field of the workflow execution REST resource https://review.openstack.org/537793 | 12:27 |
thrash | rakhmerov: what's up? | 12:28 |
*** kushalagrawal has quit IRC | 12:46 | |
*** kushalagrawal has joined #openstack-mistral | 12:46 | |
*** thrash is now known as thrash|appt | 12:47 | |
*** dprince has joined #openstack-mistral | 13:07 | |
*** kushalagrawal has quit IRC | 13:33 | |
*** kushalagrawal has joined #openstack-mistral | 13:33 | |
*** kushalagrawal has quit IRC | 13:48 | |
*** kushalagrawal has joined #openstack-mistral | 13:49 | |
*** toure|gone is now known as toure | 13:57 | |
toure | rakhmerov saw you comment, and I will add a few more scenarios | 14:00 |
toure | **your** | 14:00 |
*** thrash|appt is now known as thrash | 14:12 | |
*** bobh has joined #openstack-mistral | 14:17 | |
*** kushalagrawal has quit IRC | 14:41 | |
*** kushalagrawal has joined #openstack-mistral | 14:42 | |
*** d0ugal has quit IRC | 14:57 | |
*** jaosorior has quit IRC | 15:04 | |
*** d0ugal has joined #openstack-mistral | 15:14 | |
*** kushalagrawal has quit IRC | 15:27 | |
*** kushalagrawal has joined #openstack-mistral | 15:28 | |
*** AlexeyAbashkin has quit IRC | 16:06 | |
*** rbrady has joined #openstack-mistral | 16:33 | |
*** rbrady is now known as rbrady-afk | 16:34 | |
*** gkadam has quit IRC | 16:48 | |
openstackgerrit | Andras Kovi proposed openstack/mistral master: Move X-Target-Service-Catalog header to request body https://review.openstack.org/538308 | 17:03 |
openstackgerrit | Andras Kovi proposed openstack/python-mistralclient master: Move X-Target-Service-Catalog header to request body https://review.openstack.org/538309 | 17:06 |
openstackgerrit | Andras Kovi proposed openstack/python-mistralclient master: Move X-Target-Service-Catalog header to request body https://review.openstack.org/538309 | 17:07 |
*** harlowja has joined #openstack-mistral | 17:10 | |
*** kushalagrawal has quit IRC | 17:25 | |
*** kushalagrawal has joined #openstack-mistral | 17:26 | |
*** jpich has quit IRC | 17:34 | |
*** AlexeyAbashkin has joined #openstack-mistral | 17:40 | |
*** AlexeyAbashkin has quit IRC | 17:45 | |
*** fultonj has left #openstack-mistral | 17:48 | |
*** jkilpatr has quit IRC | 17:56 | |
*** AlexeyAbashkin has joined #openstack-mistral | 18:09 | |
*** AlexeyAbashkin has quit IRC | 18:14 | |
*** kushalagrawal has quit IRC | 18:36 | |
*** kushalagrawal has joined #openstack-mistral | 18:36 | |
*** weshay is now known as weshay|ruck|brb | 18:43 | |
*** rbrady-afk is now known as rbrady | 18:51 | |
*** jtomasek has quit IRC | 19:09 | |
openstackgerrit | Honza Pokorny proposed openstack/mistral master: Add claim_messages and delete_messages zaqar actions https://review.openstack.org/538325 | 19:13 |
*** harlowja has quit IRC | 19:14 | |
*** dprince has quit IRC | 19:21 | |
*** jkilpatr has joined #openstack-mistral | 19:26 | |
*** weshay|ruck|brb is now known as weshay|ruck | 19:27 | |
*** akazakov has quit IRC | 19:34 | |
*** kushalagrawal has quit IRC | 19:45 | |
*** kushalagrawal has joined #openstack-mistral | 19:45 | |
*** harlowja has joined #openstack-mistral | 19:46 | |
*** dprince has joined #openstack-mistral | 19:56 | |
*** harlowja_ has joined #openstack-mistral | 19:58 | |
*** harlowja has quit IRC | 20:00 | |
*** kushalagrawal has quit IRC | 20:10 | |
*** kushalagrawal has joined #openstack-mistral | 20:12 | |
*** dprince has quit IRC | 20:47 | |
*** bobh has quit IRC | 20:54 | |
*** bobh has joined #openstack-mistral | 20:55 | |
*** jkilpatr has quit IRC | 20:57 | |
*** bobh has quit IRC | 21:00 | |
*** bobh has joined #openstack-mistral | 21:25 | |
*** kushalagrawal has quit IRC | 21:26 | |
*** kushalagrawal has joined #openstack-mistral | 21:27 | |
*** bobh has quit IRC | 21:47 | |
*** mcdoker18181818 has quit IRC | 22:06 | |
*** kushalagrawal has quit IRC | 22:07 | |
*** kushalagrawal has joined #openstack-mistral | 22:08 | |
*** kushalagrawal has quit IRC | 22:45 | |
*** kushalagrawal has joined #openstack-mistral | 22:46 | |
*** rbrady has quit IRC | 23:20 | |
*** kushalagrawal has quit IRC | 23:20 | |
*** kushalagrawal has joined #openstack-mistral | 23:21 | |
*** bobh has joined #openstack-mistral | 23:28 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!